[gem5-dev] Cron /z/m5/regression/do-regression quick

2016-11-16 Thread Cron Daemon 
* build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/minor-timing: passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby: 
passed.* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: 
passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: 
passed.* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing: 
passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/o3-timing: passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-atomic: passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing: passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby: 
passed.
* 
build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple:
 passed.
* build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: 
passed.
* build/ALPHA/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby: 
passed.
* 
build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-two-level:
 passed.
* build/ALPHA/tests/opt/quick/se/30.eon/alpha/tru64/simple-atomic: passed.
* build/ALPHA/tests/opt/quick/se/50.vortex/alpha/tru64/simple-atomic: 
passed.
* build/ALPHA/tests/opt/quick/se/50.vortex/alpha/tru64/simple-timing: 
passed.
* build/ALPHA/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby: 
passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic: 
passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual:
 passed.
* build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-atomic: passed.
* build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-timing: passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing: 
passed.
* 
build/ALPHA/tests/opt/quick/fs/80.netperf-stream/alpha/linux/twosys-tsunami-simple-atomic:
 passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing-dual:
 passed.
* 
build/ALPHA_MOESI_hammer/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MOESI_hammer:
 passed.
 * 
build/ALPHA_MOESI_hammer/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_hammer:
 passed.
* 
build/ALPHA_MOESI_hammer/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MOESI_hammer:
 passed.
* 
build/ALPHA_MOESI_hammer/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_hammer:
 passed.
* 
build/ALPHA_MESI_Two_Level/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MESI_Two_Level:
 passed.
* 
build/ALPHA_MESI_Two_Level/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MESI_Two_Level:
 passed.
* 
build/ALPHA_MESI_Two_Level/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MESI_Two_Level:
 passed.
* 
build/ALPHA_MESI_Two_Level/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MESI_Two_Level:
 passed.
* 
build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_directory:
 passed.
* 
build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_directory:
 passed.
* 
build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory:
 passed.
* 
build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_directory:
 passed.
* 
build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_token:
 passed.
* 
build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_token:
 passed.
* 
build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_token:
 passed.* 
build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_token:
 passed.
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing: passed.
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-atomic: passed.
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing-ruby: 
passed.
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/o3-timing: passed.
* 
build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-simple:
 passed.
* 
build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-two-level:
 passed.
* build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest: passed.
* build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest-filter: passed.
* build/NULL/tests/opt/quick/se/51.memcheck/null/none/memcheck: passed.
* build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-dram-ctrl: passed.
* b

[gem5-dev] Review Request 3706: style: local variable name correction

2016-11-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3706/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11726:71d4b80b78ab
---
style: local variable name correction


Diffs
-

  src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 

Diff: http://reviews.gem5.org/r/3706/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

2016-11-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3707/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11727:e576e1bd7cd6
---
syscall_emul: return -errno on a failed close call


Diffs
-

  src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 

Diff: http://reviews.gem5.org/r/3707/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3699: syscall_emul: [PATCH 18/22] refactor and add functionality for dup, dup2, and pipe

2016-11-16 Thread Brandon Potter 


> On Nov. 14, 2016, 7:36 p.m., Michael LeBeane wrote:
> > src/sim/syscall_emul.cc, line 236
> > 
> >
> > These style changes seem out-of-scope.

Separated into patch: http://reviews.gem5.org/r/3706/.


> On Nov. 14, 2016, 7:36 p.m., Michael LeBeane wrote:
> > src/sim/syscall_emul.cc, line 222
> > 
> >
> > Seems like an unrelated bug fix, should this be in a seperate changeset?

Separated into patch: http://reviews.gem5.org/r/3707/.


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3699/#review9060
---


On Nov. 7, 2016, 10:09 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3699/
> ---
> 
> (Updated Nov. 7, 2016, 10:09 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11707:01d31dbe35c4
> ---
> syscall_emul: [PATCH 18/22] refactor and add functionality for dup, dup2, and 
> pipe
> 
> 
> Diffs
> -
> 
>   src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3699/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

2016-11-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3700/
---

(Updated Nov. 16, 2016, 4:36 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11728:85a344df47dd
---
syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode


Diffs (updated)
-

  src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/se_signal.hh PRE-CREATION 
  src/sim/se_signal.cc PRE-CREATION 
  src/sim/SConscript c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 

Diff: http://reviews.gem5.org/r/3700/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

2016-11-16 Thread Tony Gutierrez 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3707/#review9084
---

Ship it!


Ship It!

- Tony Gutierrez


On Nov. 16, 2016, 8:25 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3707/
> ---
> 
> (Updated Nov. 16, 2016, 8:25 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11727:e576e1bd7cd6
> ---
> syscall_emul: return -errno on a failed close call
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3707/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3706: style: local variable name correction

2016-11-16 Thread Tony Gutierrez 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3706/#review9085
---

Ship it!


Ship It!

- Tony Gutierrez


On Nov. 16, 2016, 8:24 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3706/
> ---
> 
> (Updated Nov. 16, 2016, 8:24 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11726:71d4b80b78ab
> ---
> style: local variable name correction
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3706/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

2016-11-16 Thread Brandon Potter 


> On Nov. 14, 2016, 7:29 p.m., Michael LeBeane wrote:
> > src/sim/se_signal.hh, line 39
> > 
> >
> > LiveProcess is gone now, right?

I'd originally fixed this in http://reviews.gem5.org/r/3702/. I moved the 
changes into this patch (and also updated 3702).


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3700/#review9059
---


On Nov. 16, 2016, 4:36 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3700/
> ---
> 
> (Updated Nov. 16, 2016, 4:36 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11728:85a344df47dd
> ---
> syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode
> 
> 
> Diffs
> -
> 
>   src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/se_signal.hh PRE-CREATION 
>   src/sim/se_signal.cc PRE-CREATION 
>   src/sim/SConscript c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/
---

(Updated Nov. 16, 2016, 4:44 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11730:9ee83d124c9c
---
syscall_emul: [PATCH 21/22] rewrite code related to system call exits

The changeset refactors exit, exit_group, and futex related exit
functionality.


Diffs (updated)
-

  src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/futex_map.hh PRE-CREATION 
  src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 

Diff: http://reviews.gem5.org/r/3702/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2016-11-16 Thread Brandon Potter 


> On Oct. 19, 2016, 7:29 p.m., Steve Reinhardt wrote:
> > src/sim/syscall_emul.hh, line 1000
> > 
> >
> > I agree with Michael, these dynamic casts are ugly. I think you should 
> > either:
> > 
> > A. Go all the way and define virtual functions on FDEntry to implement 
> > all the fd-related syscalls, so you can just replace the whole body of this 
> > function with
> > process->fds[tgt_fd]->fchmod(bufPtr)
> > (or something like that), and put what used to be the body of this 
> > function in FileFDEntry::fchmod(), or
> > 
> > B. Back off, put sim_fd back in FDentry, and just have the common 
> > syscalls like this one be oblivious to the FDEntry subclass. Presumably the 
> > host will do the right thing for pipes/sockets vs. files, and if you force 
> > sim_fd to -1 for emulated devices, you'll automatically get EBADF for those 
> > without putting in any additional checks.

I went with B. and added sim_fd to the base class.


> On Oct. 19, 2016, 7:29 p.m., Steve Reinhardt wrote:
> > src/sim/fd_array.hh, line 65
> > 
> >
> > I suggest calling this setFileOffsets() since it ends up calling 
> > setFileOffset() on each FDEntry. Or maybe updateFileOffsets(), if you think 
> > 'set' is ambiguous. To me, 'find' doesn't imply a state update, so it's not 
> > as clear what this is doing.

I went with update.


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/#review8934
---


On Oct. 18, 2016, 8:01 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3676/
> ---
> 
> (Updated Oct. 18, 2016, 8:01 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11699:c22ac97e3372
> ---
> syscall_emul: [patch 10/22] refactor fdentry and add fdarray class
> 
> Several large changes happen in this patch.
> 
> The FDEntry class is rewritten so that file descriptors now correspond to
> types: 'Regular' which is normal file-backed file with the file open on the
> host machine, 'Pipe' which is a pipe that has been opened on the host machine,
> and 'Device' which does not have an open file on the host yet acts as a pseudo
> device with which to issue ioctls. Other types which might be added in the
> future are directory entries and sockets (off the top of my head).
> 
> The FDArray class was create to hold most of the file descriptor handling
> that was stuffed into the Process class. It uses shared pointers and
> the std::array type to hold the FDEntries mentioned above. The implementation
> could use a review; I feel that there's some room for improvement, but it
> seems like a decent first step.
> 
> The changes to these two classes needed to be propagated out to the rest
> of the code so there were quite a few changes for that. Also, comments were
> added where I thought they were needed to help others and extend our
> DOxygen coverage.
> 
> 
> Diffs
> -
> 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_array.hh PRE-CREATION 
>   src/sim/fd_array.cc PRE-CREATION 
>   src/sim/fd_entry.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_entry.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3676/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2016-11-16 Thread Brandon Potter 


> On Oct. 19, 2016, 7:29 p.m., Steve Reinhardt wrote:
> > src/sim/fd_array.hh, line 140
> > 
> >
> > Can't these be static variables and not per-instance? I don't see where 
> > they're modified after they're constructed.

I don't think that it's possible to initialize static variables with 
aggregates. I tried following through with this recommendation but I get 
"non-constant in-class initialization invalid for static member". I think that 
the aggregate initialization must be done at runtime, but for statics the 
resolution has to be done at compile time (just guessing).


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/#review8934
---


On Oct. 18, 2016, 8:01 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3676/
> ---
> 
> (Updated Oct. 18, 2016, 8:01 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11699:c22ac97e3372
> ---
> syscall_emul: [patch 10/22] refactor fdentry and add fdarray class
> 
> Several large changes happen in this patch.
> 
> The FDEntry class is rewritten so that file descriptors now correspond to
> types: 'Regular' which is normal file-backed file with the file open on the
> host machine, 'Pipe' which is a pipe that has been opened on the host machine,
> and 'Device' which does not have an open file on the host yet acts as a pseudo
> device with which to issue ioctls. Other types which might be added in the
> future are directory entries and sockets (off the top of my head).
> 
> The FDArray class was create to hold most of the file descriptor handling
> that was stuffed into the Process class. It uses shared pointers and
> the std::array type to hold the FDEntries mentioned above. The implementation
> could use a review; I feel that there's some room for improvement, but it
> seems like a decent first step.
> 
> The changes to these two classes needed to be propagated out to the rest
> of the code so there were quite a few changes for that. Also, comments were
> added where I thought they were needed to help others and extend our
> DOxygen coverage.
> 
> 
> Diffs
> -
> 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_array.hh PRE-CREATION 
>   src/sim/fd_array.cc PRE-CREATION 
>   src/sim/fd_entry.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_entry.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3676/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2016-11-16 Thread Brandon Potter 


> On Oct. 19, 2016, 7:29 p.m., Steve Reinhardt wrote:
> > src/sim/fd_array.hh, line 74
> > 
> >
> > Why doesn't a process that shares the same file descriptors just share 
> > the whole FDArray object?  This internal shared pointer thing is kinda 
> > awkward... which is OK if it's needed, but I don't understand why.

Steve, I'd like to drop this unless you're absolutely against me doing so.

The implementation may look a little weird, but the copy constructor largely 
contains the std::shared_ptr. In my opinion, it's better that the shared_ptr 
isn't visible outside the class. The object assignment looks like it's a normal 
object copy constructor being called rather than making it look like a pointer 
assignment.


> On Oct. 19, 2016, 7:29 p.m., Steve Reinhardt wrote:
> > src/sim/syscall_emul.hh, line 526
> > 
> >
> > I don't think this is true... the whole ENOTTY thing is for stdlib to 
> > figure out if stdout is buffered or not.

OK, wasn't aware of that. I removed the comment and put the tty check at the 
top of the function with the device check after.


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/#review8934
---


On Oct. 18, 2016, 8:01 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3676/
> ---
> 
> (Updated Oct. 18, 2016, 8:01 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11699:c22ac97e3372
> ---
> syscall_emul: [patch 10/22] refactor fdentry and add fdarray class
> 
> Several large changes happen in this patch.
> 
> The FDEntry class is rewritten so that file descriptors now correspond to
> types: 'Regular' which is normal file-backed file with the file open on the
> host machine, 'Pipe' which is a pipe that has been opened on the host machine,
> and 'Device' which does not have an open file on the host yet acts as a pseudo
> device with which to issue ioctls. Other types which might be added in the
> future are directory entries and sockets (off the top of my head).
> 
> The FDArray class was create to hold most of the file descriptor handling
> that was stuffed into the Process class. It uses shared pointers and
> the std::array type to hold the FDEntries mentioned above. The implementation
> could use a review; I feel that there's some room for improvement, but it
> seems like a decent first step.
> 
> The changes to these two classes needed to be propagated out to the rest
> of the code so there were quite a few changes for that. Also, comments were
> added where I thought they were needed to help others and extend our
> DOxygen coverage.
> 
> 
> Diffs
> -
> 
>   src/kern/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_array.hh PRE-CREATION 
>   src/sim/fd_array.cc PRE-CREATION 
>   src/sim/fd_entry.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/fd_entry.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3676/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2016-11-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/
---

(Updated Nov. 16, 2016, 5:59 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11717:7f3bf41cce5c
---
syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

Several large changes happen in this patch.

The FDEntry class is rewritten so that file descriptors now correspond to
types: 'Regular' which is normal file-backed file with the file open on the
host machine, 'Pipe' which is a pipe that has been opened on the host machine,
and 'Device' which does not have an open file on the host yet acts as a pseudo
device with which to issue ioctls. Other types which might be added in the
future are directory entries and sockets (off the top of my head).

The FDArray class was create to hold most of the file descriptor handling
that was stuffed into the Process class. It uses shared pointers and
the std::array type to hold the FDEntries mentioned above. The implementation
could use a review; I feel that there's some room for improvement, but it
seems like a decent first step.

The changes to these two classes needed to be propagated out to the rest
of the code so there were quite a few changes for that. Also, comments were
added where I thought they were needed to help others and extend our
DOxygen coverage.


Diffs (updated)
-

  src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/process.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/fd_entry.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/fd_entry.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/fd_array.hh PRE-CREATION 
  src/sim/fd_array.cc PRE-CREATION 
  src/sim/SConscript c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/gpu-compute/cl_driver.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/kern/tru64/tru64.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/arch/sparc/process.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 

Diff: http://reviews.gem5.org/r/3676/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

2016-11-16 Thread Jason Lowe-Power 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3707/#review9090
---

Ship it!


BTW, how are you finding all these bugs? Do you have some test suite you're 
running which exercises all of these syscalls?

- Jason Lowe-Power


On Nov. 16, 2016, 4:25 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3707/
> ---
> 
> (Updated Nov. 16, 2016, 4:25 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11727:e576e1bd7cd6
> ---
> syscall_emul: return -errno on a failed close call
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3707/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-16 Thread Tony Gutierrez 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3705/#review9091
---

Ship it!


Ship It!

- Tony Gutierrez


On Nov. 15, 2016, 1:22 p.m., Michael LeBeane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3705/
> ---
> 
> (Updated Nov. 15, 2016, 1:22 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11705:008f04dcc085
> ---
> dev: Fix buffer length when unserializing an eth pkt
> Changeset 11701 only serialized the useful portion of of an ethernet packets'
> payload.  However, the device models expect each ethernet packet to contain
> a 16KB buffer, even if there is no data in it.  This patch adds a 'bufLength'
> field to EthPacketData so the original size of the packet buffer can always be
> unserialized.
> 
> Reported-by: Gabor Dozsa 
> 
> 
> Diffs
> -
> 
>   src/dev/net/etherpkt.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/dev/net/etherpkt.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael LeBeane
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

2016-11-16 Thread Brandon Potter 


> On Nov. 16, 2016, 6:19 p.m., Jason Lowe-Power wrote:
> > BTW, how are you finding all these bugs? Do you have some test suite you're 
> > running which exercises all of these syscalls?

No, I don't have a test suite for it.

It's not really a bug in that it wouldn't do the "right" thing either; it's 
just that we have the convention or returning -errno for failed system calls. I 
don't know why it was missing from the code in the first place.


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3707/#review9090
---


On Nov. 16, 2016, 4:25 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3707/
> ---
> 
> (Updated Nov. 16, 2016, 4:25 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11727:e576e1bd7cd6
> ---
> syscall_emul: return -errno on a failed close call
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3707/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3705/#review9093
---

Ship it!


Ship It!

- Brandon Potter


On Nov. 15, 2016, 9:22 p.m., Michael LeBeane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3705/
> ---
> 
> (Updated Nov. 15, 2016, 9:22 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11705:008f04dcc085
> ---
> dev: Fix buffer length when unserializing an eth pkt
> Changeset 11701 only serialized the useful portion of of an ethernet packets'
> payload.  However, the device models expect each ethernet packet to contain
> a 16KB buffer, even if there is no data in it.  This patch adds a 'bufLength'
> field to EthPacketData so the original size of the packet buffer can always be
> unserialized.
> 
> Reported-by: Gabor Dozsa 
> 
> 
> Diffs
> -
> 
>   src/dev/net/etherpkt.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/dev/net/etherpkt.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael LeBeane
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-11-16 Thread Andreas Hansson 


> On Nov. 14, 2016, 5:41 p.m., Brandon Potter wrote:
> > src/arch/alpha/kernel_stats.cc, line 185
> > 
> >
> > I think that all that the stats do is record mode switches between user 
> > and kernel space. There's a small tracker for kvm switches in arm, but this 
> > doesn't look like very useful information outside of someone needing it for 
> > a publication. At least, it's not useful enough to implement for other 
> > architectures apparently. The other architectures only have stubs for this 
> > class: src/arch/*/kernel_stats.hh.
> > 
> > Instead of worrying about the maintenance, can we remove this and stop 
> > tracking the kernel stats altogether? (If it is deemed useful, it probably 
> > needs to be implemented for the other architectures too.)

ok, i suggest we move forward with the current patch as is and then take it 
from there. could i get a few ship its?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3688/#review9047
---


On Oct. 27, 2016, 7:45 a.m., Andreas Hansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3688/
> ---
> 
> (Updated Oct. 27, 2016, 7:45 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11705:6c2b4e24accf
> ---
> alpha: Remove ALPHA tru64 support and associated tests
> 
> No one appears to be using it, and it is causing build issues
> and increases the development and maintenance effort.
> 
> 
> Diffs
> -
> 
>   tests/long/se/30.eon/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/stats.txt 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/stats.txt 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/stats.txt 
> c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/smred.msg c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/smred.out c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/60.bzip2

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-16 Thread Andreas Hansson 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3705/#review9095
---


do we need a checkpoint updater, or does the call to paramIn return 0 if the 
parameter is not populated?

- Andreas Hansson


On Nov. 15, 2016, 9:22 p.m., Michael LeBeane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3705/
> ---
> 
> (Updated Nov. 15, 2016, 9:22 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11705:008f04dcc085
> ---
> dev: Fix buffer length when unserializing an eth pkt
> Changeset 11701 only serialized the useful portion of of an ethernet packets'
> payload.  However, the device models expect each ethernet packet to contain
> a 16KB buffer, even if there is no data in it.  This patch adds a 'bufLength'
> field to EthPacketData so the original size of the packet buffer can always be
> unserialized.
> 
> Reported-by: Gabor Dozsa 
> 
> 
> Diffs
> -
> 
>   src/dev/net/etherpkt.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/dev/net/etherpkt.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael LeBeane
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-11-16 Thread Tony Gutierrez 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3688/#review9096
---

Ship it!


Ship It!

- Tony Gutierrez


On Oct. 27, 2016, 12:45 a.m., Andreas Hansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3688/
> ---
> 
> (Updated Oct. 27, 2016, 12:45 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11705:6c2b4e24accf
> ---
> alpha: Remove ALPHA tru64 support and associated tests
> 
> No one appears to be using it, and it is causing build issues
> and increases the development and maintenance effort.
> 
> 
> Diffs
> -
> 
>   tests/long/se/30.eon/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 
>   tests/long/se/30.eon/ref/alpha/tru64/simple-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/minor-timing/stats.txt 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-atomic/stats.txt 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 
>   tests/long/se/40.perlbmk/ref/alpha/tru64/simple-timing/stats.txt 
> c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/smred.msg c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/smred.out c38fcdaa5fe5 
>   tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/simerr c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/simout c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/o3-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/simerr c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/simout c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-atomic/stats.txt c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/config.ini 
> c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/simerr c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/simout c38fcdaa5fe5 
>   tests/long/se/60.bzip2/ref/alpha/tru64/simple-timing/stats.txt c38fcdaa5fe5 
>   tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/config.ini c38fcdaa5fe5 
>   tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/simerr c38fcdaa5fe5 
>   tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/simout c38fcdaa5fe5 
>   tests/long/se/70.twolf/ref/alpha/tru64/minor-timing/stats.txt c38fcdaa5fe5 
>

[gem5-dev] Review Request 3708: commit 752c67b134f4cb0b7ca68a907c39a5a482de30b3

2016-11-16 Thread Rahul Thakur 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3708/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11705:df194a470063
---
commit 752c67b134f4cb0b7ca68a907c39a5a482de30b3
Author: Rahul Thakur 
Date:   Thu Oct 27 17:44:40 2016 -0700

mem: Add memory footprint probe

Change-Id: I0fba8995edd63df4ef49969347be6d2aefceca9f


Diffs
-

  src/mem/probes/mem_footprint.hh PRE-CREATION 
  src/mem/probes/mem_footprint.cc PRE-CREATION 
  COPYING c38fcdaa5fe5 
  configs/dram/lat_mem_rd.py c38fcdaa5fe5 
  src/mem/probes/MemFootprintProbe.py PRE-CREATION 
  src/mem/probes/SConscript c38fcdaa5fe5 

Diff: http://reviews.gem5.org/r/3708/diff/


Testing
---


Thanks,

Rahul Thakur

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev