Re: [m5-dev] Review Request: ruby: Added SC fail indication to trace profiling

[Nathan Binkert]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/109/#review166
---



src/mem/ruby/system/Sequencer.cc


Sorry, I wasn't looking for a comment.  I mostly thought that it was 
strange to create the flag at all instead of just returning the status 
directly.  Anyway, spent too much time on this already.  I'm fine.


- Nathan


On 2010-08-11 14:35:30, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/109/
> ---
> 
> (Updated 2010-08-11 14:35:30)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> ruby: Added SC fail indication to trace profiling
> 
> 
> Diffs
> -
> 
>   src/mem/ruby/system/Sequencer.hh a75564db03c3 
>   src/mem/ruby/system/Sequencer.cc a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/109/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: moved python protocol files

[Nathan Binkert]

> On 2010-08-08 08:13:16, Nathan Binkert wrote:
> > I think you should make it clear in the commit message that you moved the 
> > protocol files for the configuration.  (I assumed src/mem/protocol).  Also, 
> > did you use "hg mv" for this?  The diff doesn't show that, but that could 
> > be reviewboard screwing it up.

Ok, are you updating commit messages, but the updates aren't making it into 
reviewboard?


- Nathan


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/85/#review135
---


On 2010-08-11 14:36:58, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/85/
> ---
> 
> (Updated 2010-08-11 14:36:58)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> ruby: moved python protocol files
> 
> Moved the python protocol files back to their original location to avoid
> addToPath calls.
> 
> 
> Diffs
> -
> 
>   configs/ruby/MESI_CMP_directory.py PRE-CREATION 
>   configs/ruby/MI_example.py PRE-CREATION 
>   configs/ruby/MOESI_CMP_directory.py PRE-CREATION 
>   configs/ruby/MOESI_CMP_token.py PRE-CREATION 
>   configs/ruby/MOESI_hammer.py PRE-CREATION 
>   configs/ruby/Ruby.py a75564db03c3 
>   configs/ruby/protocols/MESI_CMP_directory.py a75564db03c3 
>   configs/ruby/protocols/MI_example.py a75564db03c3 
>   configs/ruby/protocols/MOESI_CMP_directory.py a75564db03c3 
>   configs/ruby/protocols/MOESI_CMP_token.py a75564db03c3 
>   configs/ruby/protocols/MOESI_hammer.py a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/85/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: hammer detail miss latency breakdown

[Nathan Binkert]

> On 2010-08-08 20:53:56, Nathan Binkert wrote:
> > The commit message is somewhat cryptic.

Still think it's cryptic.


- Nathan


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/114/#review150
---


On 2010-08-11 14:36:35, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/114/
> ---
> 
> (Updated 2010-08-11 14:36:35)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> ruby: hammer detail miss latency breakdown
> 
> 
> Diffs
> -
> 
>   src/mem/protocol/MOESI_hammer-cache.sm a75564db03c3 
>   src/mem/protocol/MOESI_hammer-dir.sm a75564db03c3 
>   src/mem/protocol/MOESI_hammer-msg.sm a75564db03c3 
>   src/mem/protocol/RubySlicc_Types.sm a75564db03c3 
>   src/mem/ruby/profiler/Profiler.hh a75564db03c3 
>   src/mem/ruby/profiler/Profiler.cc a75564db03c3 
>   src/mem/ruby/system/Sequencer.hh a75564db03c3 
>   src/mem/ruby/system/Sequencer.cc a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/114/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: m5: Fixed periodic interrupts to work with draining

[Nathan Binkert]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/107/#review163
---


Not sure what you did here, but I still think you should fix the commit message.

- Nathan


On 2010-08-11 14:35:01, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/107/
> ---
> 
> (Updated 2010-08-11 14:35:01)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> m5: Fixed periodic interrupts to work with draining
> 
> Added drain functions to the RTC and 8254 timer so that periodic interrupts
> stop when the system is draining.
> 
> 
> Diffs
> -
> 
>   src/dev/alpha/tsunami_io.hh a75564db03c3 
>   src/dev/alpha/tsunami_io.cc a75564db03c3 
>   src/dev/intel_8254_timer.hh a75564db03c3 
>   src/dev/intel_8254_timer.cc a75564db03c3 
>   src/dev/mc146818.hh a75564db03c3 
>   src/dev/mc146818.cc a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/107/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: memtest: Memtester support for DMA

[Nathan Binkert]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/92/#review162
---


It looks like you removed a whole lot of features in this diff.  Why did you do 
this?  Can you explain it in the commit message?


configs/example/memtest-ruby.py


Why did you remove this stuff?



configs/example/memtest-ruby.py


What does this mean?  Can you add some help?



configs/example/memtest-ruby.py


Why remove this?


- Nathan


On 2010-08-11 14:36:07, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/92/
> ---
> 
> (Updated 2010-08-11 14:36:07)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> memtest: Memtester support for DMA
> 
> This patch adds DMA testing to the Memtester and is inherits many changes from
> Polina's old tester_dma_extension patch.
> 
> 
> Diffs
> -
> 
>   configs/example/memtest-ruby.py a75564db03c3 
>   configs/ruby/MESI_CMP_directory.py PRE-CREATION 
>   configs/ruby/MI_example.py PRE-CREATION 
>   configs/ruby/MOESI_CMP_directory.py PRE-CREATION 
>   configs/ruby/MOESI_CMP_token.py PRE-CREATION 
>   configs/ruby/MOESI_hammer.py PRE-CREATION 
>   src/cpu/memtest/MemTest.py a75564db03c3 
>   src/cpu/memtest/memtest.hh a75564db03c3 
>   src/cpu/memtest/memtest.cc a75564db03c3 
>   src/mem/ruby/system/DMASequencer.cc a75564db03c3 
>   src/mem/ruby/system/SConscript a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/92/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] [m5-users] Regression tests for X86

[nathan binkert]

>  Aside from building a Linux kernel, you will need to build and configure a
> disk image as well, which is also a fair amount of work.  I've found that,
> unfortunately due to the long simulation time of Linux boot up, the
> iteration time to debug the X86_FS bootup is quite long.

Really, bootup is quite long?  It's pretty fast on Alpha and I
wouldn't expect that much more to be going on in x86.  There are a lot
of delay loops during bootup that slow things down.  Have you elided
all of those?

  Nate
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Regression tests for X86

[Joel Hestness]

Hi Dibakar,
  I recently built a Linux kernel for M5 X86_FS that was based on v2.6.28.4,
but modified and compiled specifically for M5.  I have patches for my
changes, but we're still in the debugging phases of bringing up X86_FS with
multicore support, so I'm not confident enough to send them around just yet.
 Aside from building a Linux kernel, you will need to build and configure a
disk image as well, which is also a fair amount of work.  I've found that,
unfortunately due to the long simulation time of Linux boot up, the
iteration time to debug the X86_FS bootup is quite long.
  I think it would be useful if you could describe what you would like to do
with X86_FS, and I can maybe give you some direction on how to get there or
whether it makes sense to wait for updates to M5.
  Thanks,
  Joel


On Sat, Aug 7, 2010 at 12:30 PM, dibakar gope  wrote:

> Hi All,
>
> I have few queries regarding the regression tests for X86.
>
> (1) I could build the x86 in FS mode for AtomicSimpleCPU, O3CPU and
> SimpleTimingCPU mode (I am using a bunch of x86-specific patches from
> http://www.csl.cornell.edu/~vince/projects/m5/m5_x86_64_se_status.html).
> I guess that the pre-compiled linux kernel (that can be downloaded
> from M5 site) was complied for alpha arch only. So I actually
> downloaded the linux-dist tarball from M5 site for x86 build. This
> tarball has a .config.M5 that can be used for compiling the kernel,
> but that .config.m5 is ALPHA-specific.
>
> So in order to compile the linux for x86, I used the config of my
> native linux machine kernel as a basis for our x86 config kernel and
> got the vmlinux for x86. Following commands are used for that:-
>
> cp /boot/config ./.config
> make menuconfig
> make-kpkg clean
> fakeroot make-kpkg --initrd --append-to-version=-v2.6.27 kernel_image
> kernel_headers
>
> I used that vmliux for X86_FS build and did not get any error during
> the build process.
>
> So my query is, are there any x86-specific patches (configurations)
> that I should have considered for compiling the linux kernel for x86.
>
>
> (2)Then I tried to test that X86_FS m5.opt using regression tests. All
> the several test programs present for the regression tests have
> config.ini files only for alpha in m5-dev tarball, but they don't have
> the same for X86. But using the following command, I can generate
> those x86-specific config-ini for the test-programs used in FS mode
> regression.
>
> build/X86_FS/m5.opt -re configs/example/fs.py
> --cmd=tests/test-progs//bin/x86/ binary>
>
> But the problem is that the m5-dev tarball (m5/tests/test-progs/*)
> does not have the test program binaries  (m5/tests/quick/*) (for
> example, 10.linux-boot,80.netperf-stream,50.memtest etc) except hello
> (which is not used for FS mode regression). So I could not generate
> the config.ini for x86 in order to run the regression tests.
>
> So my query is, have anyone worked on the X86 regression tests / faced
> the same problem? Before I use the x86_FS.opt for SPEC2000/2006
> benchmarks, I want that to pass the regression tests first.
>
>
> Thanks and Regards,
>
> Dibakar Gope
> Texas A&M University
> ___
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>



-- 
  Joel Hestness
  PhD Student, Computer Architecture
  Dept. of Computer Science, University of Texas - Austin
  http://www.cs.utexas.edu/~hestness
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Resurrected Ruby's deterministic tests

[Gabriel Michael Black]

That seems reasonable, but I still don't think being deterministic is  
a good distinguishing characteristic. M5 is designed to always be  
deterministic and the regressions assume the same test will always get  
the same answer, so -all- tests are deterministic, even if they're  
determinstically random which admittedly sounds contradictory.  
Assuming my interpretation of your description is correct, I think you  
mean directed tests which are, I think, tests directed towards testing  
something in particular. I'm not an expert on the terminology but I  
think that's right.


Gabe

Quoting "Beckmann, Brad" :

I think we should incorporate the ruby tester in the same directory  
structure.  How about we create a new directory cpu/testers and then  
move the three types of testers below that: cpu/testers/memtest,  
cpu/testers/rubytest, and cpu/testers/determtest


Brad


-Original Message-
From: Gabe Black [mailto:gabe.bl...@gmail.com] On Behalf Of Gabe Black
Sent: Sunday, August 15, 2010 2:16 PM
To: M5 Developer List
Cc: Beckmann, Brad; Nathan Binkert
Subject: Re: [m5-dev] Review Request: ruby: Resurrected Ruby's  
deterministic tests


How about putting the stuff currently in memtest into memtest/random and
this new stuff in memtest/directed? I think both are technically
determinstic as implemented.

Gabe

Brad Beckmann wrote:



On 2010-08-08 20:48:58, Nathan Binkert wrote:

I think the directory name needs to have tester in it.   
src/cpu/deterministic gives you no indication of what it actually  
is.  Beyond that, is it really necessary to have multiple  
testers?  Can we not fold the functionality into a single tester?




I used the name deterministic because the directory contains  
multiple deterministic testers.  I changed the name to  
determtest...does that work for you?  These deterministic testers  
serve a very different purpose than the random testers.  The  
deterministic testers are used for verifying latency and protocol  
operation for a specific transaction.  They do not stress races  
like the memtest or rubytest.  The deterministic testers are much  
simplier than the random testers.  I don't think it would be easy  
to merge the different testers' logic into a single tester and I'm  
not sure it is worth the effort.  This code is actually not new  
code.  It is actually fairly old GEMS code.  I'm not sure why it  
was moved over in the original transfer, but I've found the code to  
be very valuable.


I fixed the includes, guards, and comments.  Since these aren't new  
files, but actually old GEMS files, I don't think it appropriate to  
change the variable names in this patch.  Possibly later we can  
conver all the old GEMS files to the M5 variable convention.



- Brad


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/101/#review148
---


On 2010-08-11 12:01:17, Brad Beckmann wrote:


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/101/
---

(Updated 2010-08-11 12:01:17)


Review request for Default.


Summary
---

ruby: Resurrected Ruby's deterministic tests

Added the request series and invalidate deterministic tests as new  
cpu models

and removed the no longer needed ruby tests


Diffs
-

  configs/example/determ_test.py PRE-CREATION
  src/cpu/determtest/DetermGenerator.hh PRE-CREATION
  src/cpu/determtest/DetermGenerator.cc PRE-CREATION
  src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION
  src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION
  src/cpu/determtest/RubyDetermTester.hh PRE-CREATION
  src/cpu/determtest/RubyDetermTester.cc PRE-CREATION
  src/cpu/determtest/RubyDetermTester.py PRE-CREATION
  src/cpu/determtest/SConscript PRE-CREATION
  src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION
  src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION
  src/mem/protocol/RubySlicc_Exports.sm a75564db03c3
  src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3
  src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3
  src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3
  src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3
  src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3
  src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3
  src/mem/ruby/tester/SConscript a75564db03c3

Diff: http://reviews.m5sim.org/r/101/diff


Testing
---


Thanks,

Brad





___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev









___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Added consolidated network msg stats

[Brad Beckmann]

> On 2010-08-08 08:40:07, Nathan Binkert wrote:
> >

Fixed


- Brad


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/95/#review141
---


On 2010-08-11 14:37:14, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/95/
> ---
> 
> (Updated 2010-08-11 14:37:14)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> ruby: Added consolidated network msg stats
> 
> 
> Diffs
> -
> 
>   src/mem/ruby/network/simple/SimpleNetwork.cc a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/95/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: config: Added the topology name to m5 & ruby output

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/88/
---

(Updated 2010-08-11 14:39:35.284205)


Review request for Default.


Summary
---

config: Added the topology name to m5 & ruby output


Diffs (updated)
-

  src/mem/ruby/network/Network.py a75564db03c3 
  src/mem/ruby/network/topologies/Crossbar.py a75564db03c3 
  src/mem/ruby/network/topologies/Mesh.py a75564db03c3 
  src/mem/ruby/network/topologies/MeshDirCorners.py a75564db03c3 

Diff: http://reviews.m5sim.org/r/88/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Improve ruby simobject names

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/89/
---

(Updated 2010-08-11 14:39:22.529304)


Review request for Default.


Summary
---

ruby: Improve ruby simobject names

This patch attaches ruby objects to the system before the topology is
created so that their simobject names read their meaningful variable
names instead of their topology name.


Diffs (updated)
-

  configs/example/memtest-ruby.py a75564db03c3 
  configs/example/ruby_fs.py a75564db03c3 
  configs/example/ruby_se.py a75564db03c3 
  configs/example/rubytest.py a75564db03c3 
  configs/ruby/MESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MI_example.py PRE-CREATION 
  configs/ruby/MOESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MOESI_CMP_token.py PRE-CREATION 
  configs/ruby/MOESI_hammer.py PRE-CREATION 
  configs/ruby/Ruby.py a75564db03c3 

Diff: http://reviews.m5sim.org/r/89/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Removed try except blocks in ruby creation

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/105/
---

(Updated 2010-08-11 14:39:02.802971)


Review request for Default.


Summary
---

ruby: Removed try except blocks in ruby creation

Removed the try-except blocks used to catch problems in ruby python creation
because config error msgs would be caught and it was annoying to constantly
have to remove the blocks inorder to determine the exact error.


Diffs (updated)
-

  configs/ruby/Ruby.py a75564db03c3 

Diff: http://reviews.m5sim.org/r/105/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: reorganized how ruby specifies command-line options

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/86/
---

(Updated 2010-08-11 14:38:40.674413)


Review request for Default.


Summary
---

ruby: reorganized how ruby specifies command-line options


Diffs (updated)
-

  configs/common/Options.py a75564db03c3 
  configs/example/memtest-ruby.py a75564db03c3 
  configs/example/ruby_fs.py a75564db03c3 
  configs/example/ruby_se.py a75564db03c3 
  configs/example/rubytest.py a75564db03c3 
  configs/ruby/MESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MI_example.py PRE-CREATION 
  configs/ruby/MOESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MOESI_CMP_token.py PRE-CREATION 
  configs/ruby/MOESI_hammer.py PRE-CREATION 
  configs/ruby/Ruby.py a75564db03c3 

Diff: http://reviews.m5sim.org/r/86/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: added cmd options to control ruby debug

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/103/
---

(Updated 2010-08-11 14:38:29.485853)


Review request for Default.


Summary
---

ruby: added cmd options to control ruby debug


Diffs (updated)
-

  configs/ruby/Ruby.py a75564db03c3 

Diff: http://reviews.m5sim.org/r/103/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: regress: Regression tester updates

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/119/
---

(Updated 2010-08-11 14:37:58.960209)


Review request for Default.


Summary
---

regress: Regression tester updates


Diffs (updated)
-

  tests/configs/memtest-ruby.py a75564db03c3 
  tests/configs/rubytest-ruby.py a75564db03c3 
  tests/configs/simple-timing-mp-ruby.py a75564db03c3 
  tests/configs/simple-timing-ruby.py a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MESI_CMP_directory/config.ini
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MESI_CMP_directory/ruby.stats
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MESI_CMP_directory/simout
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MESI_CMP_directory/stats.txt
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/config.ini
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/ruby.stats
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/simout
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/stats.txt
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/config.ini
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/ruby.stats
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/simout 
a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/stats.txt
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/config.ini 
a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/ruby.stats 
a75564db03c3 
  tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/simout 
a75564db03c3 
  
tests/quick/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/stats.txt 
a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_CMP_directory/config.ini
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_CMP_directory/ruby.stats
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_CMP_directory/simout
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_CMP_directory/stats.txt
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/config.ini
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/ruby.stats
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/simout
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/stats.txt
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/config.ini
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/ruby.stats
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/simout 
a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/stats.txt
 a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/config.ini 
a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/ruby.stats 
a75564db03c3 
  tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/simout 
a75564db03c3 
  
tests/quick/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/stats.txt 
a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/config.ini
 a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/ruby.stats
 a75564db03c3 
  tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/simerr 
a75564db03c3 
  tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/simout 
a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/stats.txt
 a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_directory/config.ini
 a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_directory/ruby.stats
 a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_directory/simerr 
a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_directory/simout 
a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_directory/stats.txt
 a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_token/config.ini 
a75564db03c3 
  
tests/quick/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_token/ruby.stats 
a75564db03c3 
  tests/quick/50.memtest/ref/alpha/lin

Re: [m5-dev] Review Request: ruby: Added consolidated network msg stats

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/95/
---

(Updated 2010-08-11 14:37:14.700509)


Review request for Default.


Summary
---

ruby: Added consolidated network msg stats


Diffs (updated)
-

  src/mem/ruby/network/simple/SimpleNetwork.cc a75564db03c3 

Diff: http://reviews.m5sim.org/r/95/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: moved python protocol files

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/85/
---

(Updated 2010-08-11 14:36:58.271850)


Review request for Default.


Summary
---

ruby: moved python protocol files

Moved the python protocol files back to their original location to avoid
addToPath calls.


Diffs (updated)
-

  configs/ruby/MESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MI_example.py PRE-CREATION 
  configs/ruby/MOESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MOESI_CMP_token.py PRE-CREATION 
  configs/ruby/MOESI_hammer.py PRE-CREATION 
  configs/ruby/Ruby.py a75564db03c3 
  configs/ruby/protocols/MESI_CMP_directory.py a75564db03c3 
  configs/ruby/protocols/MI_example.py a75564db03c3 
  configs/ruby/protocols/MOESI_CMP_directory.py a75564db03c3 
  configs/ruby/protocols/MOESI_CMP_token.py a75564db03c3 
  configs/ruby/protocols/MOESI_hammer.py a75564db03c3 

Diff: http://reviews.m5sim.org/r/85/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: hammer detail miss latency breakdown

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/114/
---

(Updated 2010-08-11 14:36:35.566050)


Review request for Default.


Summary
---

ruby: hammer detail miss latency breakdown


Diffs (updated)
-

  src/mem/protocol/MOESI_hammer-cache.sm a75564db03c3 
  src/mem/protocol/MOESI_hammer-dir.sm a75564db03c3 
  src/mem/protocol/MOESI_hammer-msg.sm a75564db03c3 
  src/mem/protocol/RubySlicc_Types.sm a75564db03c3 
  src/mem/ruby/profiler/Profiler.hh a75564db03c3 
  src/mem/ruby/profiler/Profiler.cc a75564db03c3 
  src/mem/ruby/system/Sequencer.hh a75564db03c3 
  src/mem/ruby/system/Sequencer.cc a75564db03c3 

Diff: http://reviews.m5sim.org/r/114/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: memtest: Memtester support for DMA

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/92/
---

(Updated 2010-08-11 14:36:07.252833)


Review request for Default.


Summary
---

memtest: Memtester support for DMA

This patch adds DMA testing to the Memtester and is inherits many changes from
Polina's old tester_dma_extension patch.


Diffs (updated)
-

  configs/example/memtest-ruby.py a75564db03c3 
  configs/ruby/MESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MI_example.py PRE-CREATION 
  configs/ruby/MOESI_CMP_directory.py PRE-CREATION 
  configs/ruby/MOESI_CMP_token.py PRE-CREATION 
  configs/ruby/MOESI_hammer.py PRE-CREATION 
  src/cpu/memtest/MemTest.py a75564db03c3 
  src/cpu/memtest/memtest.hh a75564db03c3 
  src/cpu/memtest/memtest.cc a75564db03c3 
  src/mem/ruby/system/DMASequencer.cc a75564db03c3 
  src/mem/ruby/system/SConscript a75564db03c3 

Diff: http://reviews.m5sim.org/r/92/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Added SC fail indication to trace profiling

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/109/
---

(Updated 2010-08-11 14:35:30.334267)


Review request for Default.


Summary
---

ruby: Added SC fail indication to trace profiling


Diffs (updated)
-

  src/mem/ruby/system/Sequencer.hh a75564db03c3 
  src/mem/ruby/system/Sequencer.cc a75564db03c3 

Diff: http://reviews.m5sim.org/r/109/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: m5: Fixed periodic interrupts to work with draining

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/107/
---

(Updated 2010-08-11 14:35:01.551768)


Review request for Default.


Summary
---

m5: Fixed periodic interrupts to work with draining

Added drain functions to the RTC and 8254 timer so that periodic interrupts
stop when the system is draining.


Diffs (updated)
-

  src/dev/alpha/tsunami_io.hh a75564db03c3 
  src/dev/alpha/tsunami_io.cc a75564db03c3 
  src/dev/intel_8254_timer.hh a75564db03c3 
  src/dev/intel_8254_timer.cc a75564db03c3 
  src/dev/mc146818.hh a75564db03c3 
  src/dev/mc146818.cc a75564db03c3 

Diff: http://reviews.m5sim.org/r/107/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Resurrected Ruby's deterministic tests

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/101/
---

(Updated 2010-08-11 14:34:27.891106)


Review request for Default.


Summary
---

ruby: Resurrected Ruby's deterministic tests

Added the request series and invalidate deterministic tests as new cpu models
and removed the no longer needed ruby tests


Diffs (updated)
-

  configs/example/determ_test.py PRE-CREATION 
  src/cpu/determtest/DetermGenerator.hh PRE-CREATION 
  src/cpu/determtest/DetermGenerator.cc PRE-CREATION 
  src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION 
  src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.hh PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.cc PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.py PRE-CREATION 
  src/cpu/determtest/SConscript PRE-CREATION 
  src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION 
  src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION 
  src/mem/protocol/RubySlicc_Exports.sm a75564db03c3 
  src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3 
  src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3 
  src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3 
  src/mem/ruby/tester/SConscript a75564db03c3 

Diff: http://reviews.m5sim.org/r/101/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: slicc: Consolidated the protocol stats printing

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/90/
---

(Updated 2010-08-11 14:34:01.226901)


Review request for Default.


Summary
---

slicc: Consolidated the protocol stats printing

Created a separate ProfileDumper that consolidates the generated stats for
each controller of a certain type.


Diffs (updated)
-

  src/mem/slicc/ast/MachineAST.py a75564db03c3 
  src/mem/slicc/symbols/StateMachine.py a75564db03c3 

Diff: http://reviews.m5sim.org/r/90/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Stall and wait input messages instead of recycling

[Brad Beckmann]

> On 2010-08-08 16:49:43, Nathan Binkert wrote:
> >

Though I wrote the majority of the file, it is based on code from HP and 
Wisconsin.  I figured all three institutions own some portion of the copyright.


- Brad


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/116/#review143
---


On 2010-08-05 21:49:59, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/116/
> ---
> 
> (Updated 2010-08-05 21:49:59)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> ruby: Stall and wait input messages instead of recycling
> 
> This patch allows messages to be stalled in their input buffers and wait
> until a corresponding address changes state.  In order to make this work,
> all in_ports must be ranked in order of dependence and those in_ports that
> may unblock an address, must wake up the stalled messages.  Alot of this
> complexity is handled in slicc and the specification files simply
> annotate the in_ports.
> 
> 
> Diffs
> -
> 
>   src/mem/protocol/MOESI_hammer-dir.sm a75564db03c3 
>   src/mem/ruby/buffers/MessageBuffer.hh a75564db03c3 
>   src/mem/ruby/buffers/MessageBuffer.cc a75564db03c3 
>   src/mem/slicc/ast/InPortDeclAST.py a75564db03c3 
>   src/mem/slicc/ast/PeekStatementAST.py a75564db03c3 
>   src/mem/slicc/ast/StallAndWaitStatementAST.py PRE-CREATION 
>   src/mem/slicc/ast/WakeUpDependentsStatementAST.py PRE-CREATION 
>   src/mem/slicc/ast/__init__.py a75564db03c3 
>   src/mem/slicc/parser.py a75564db03c3 
>   src/mem/slicc/symbols/StateMachine.py a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/116/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: imported patch brad/uncacheable_debug

[Brad Beckmann]

> On 2010-08-08 16:50:50, Nathan Binkert wrote:
> > Need a commit message.

This patch has been removed.  I didn't mean to post it for review.


- Brad


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/108/#review144
---


On 2010-08-05 21:52:30, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/108/
> ---
> 
> (Updated 2010-08-05 21:52:30)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> imported patch brad/uncacheable_debug
> 
> 
> Diffs
> -
> 
>   src/mem/ruby/system/RubyPort.cc a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/108/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Resurrected Ruby's deterministic tests

[Beckmann, Brad]

I think we should incorporate the ruby tester in the same directory structure.  
How about we create a new directory cpu/testers and then move the three types 
of testers below that: cpu/testers/memtest, cpu/testers/rubytest, and 
cpu/testers/determtest

Brad


-Original Message-
From: Gabe Black [mailto:gabe.bl...@gmail.com] On Behalf Of Gabe Black
Sent: Sunday, August 15, 2010 2:16 PM
To: M5 Developer List
Cc: Beckmann, Brad; Nathan Binkert
Subject: Re: [m5-dev] Review Request: ruby: Resurrected Ruby's deterministic 
tests

How about putting the stuff currently in memtest into memtest/random and
this new stuff in memtest/directed? I think both are technically
determinstic as implemented.

Gabe

Brad Beckmann wrote:
>   
>> On 2010-08-08 20:48:58, Nathan Binkert wrote:
>> 
>>> I think the directory name needs to have tester in it.  
>>> src/cpu/deterministic gives you no indication of what it actually is.  
>>> Beyond that, is it really necessary to have multiple testers?  Can we not 
>>> fold the functionality into a single tester?
>>>   
>
> I used the name deterministic because the directory contains multiple 
> deterministic testers.  I changed the name to determtest...does that work for 
> you?  These deterministic testers serve a very different purpose than the 
> random testers.  The deterministic testers are used for verifying latency and 
> protocol operation for a specific transaction.  They do not stress races like 
> the memtest or rubytest.  The deterministic testers are much simplier than 
> the random testers.  I don't think it would be easy to merge the different 
> testers' logic into a single tester and I'm not sure it is worth the effort.  
> This code is actually not new code.  It is actually fairly old GEMS code.  
> I'm not sure why it was moved over in the original transfer, but I've found 
> the code to be very valuable.
>
> I fixed the includes, guards, and comments.  Since these aren't new files, 
> but actually old GEMS files, I don't think it appropriate to change the 
> variable names in this patch.  Possibly later we can conver all the old GEMS 
> files to the M5 variable convention.
>
>
> - Brad
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/101/#review148
> ---
>
>
> On 2010-08-11 12:01:17, Brad Beckmann wrote:
>   
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviews.m5sim.org/r/101/
>> ---
>>
>> (Updated 2010-08-11 12:01:17)
>>
>>
>> Review request for Default.
>>
>>
>> Summary
>> ---
>>
>> ruby: Resurrected Ruby's deterministic tests
>>
>> Added the request series and invalidate deterministic tests as new cpu models
>> and removed the no longer needed ruby tests
>>
>>
>> Diffs
>> -
>>
>>   configs/example/determ_test.py PRE-CREATION 
>>   src/cpu/determtest/DetermGenerator.hh PRE-CREATION 
>>   src/cpu/determtest/DetermGenerator.cc PRE-CREATION 
>>   src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION 
>>   src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION 
>>   src/cpu/determtest/RubyDetermTester.hh PRE-CREATION 
>>   src/cpu/determtest/RubyDetermTester.cc PRE-CREATION 
>>   src/cpu/determtest/RubyDetermTester.py PRE-CREATION 
>>   src/cpu/determtest/SConscript PRE-CREATION 
>>   src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION 
>>   src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION 
>>   src/mem/protocol/RubySlicc_Exports.sm a75564db03c3 
>>   src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3 
>>   src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3 
>>   src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3 
>>   src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3 
>>   src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3 
>>   src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3 
>>   src/mem/ruby/tester/SConscript a75564db03c3 
>>
>> Diff: http://reviews.m5sim.org/r/101/diff
>>
>>
>> Testing
>> ---
>>
>>
>> Thanks,
>>
>> Brad
>>
>>
>> 
>
> ___
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>   



___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Ruby Patches

[Beckmann, Brad]

Please disregard my previous question.  I just noticed that 'hg postreview' has 
a '-e' option where one can specify an existing review id to update.  It 
requires one to identify the review id for every patch, but it is much better 
than manually uploading patches.

Brad


From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of 
Beckmann, Brad
Sent: Wednesday, August 11, 2010 10:15 AM
To: M5 Developer List
Subject: Re: [m5-dev] Ruby Patches

I've addressed Nate's comments and I have a set of patch updates to post for 
review.  I noticed that 'hg postreview' won't update the current patch but 
instead will create new patches.  I see that I can manually update the patches 
on the reviewboard website, but for the number of patches I want to update, 
that is rather tedious.  Can anyone recommend a better method, or am I suck 
manually updating the patches through the website?

Thanks,

Brad


From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of 
Dan Gibson
Sent: Monday, August 09, 2010 5:57 AM
To: M5 Developer List
Subject: Re: [m5-dev] Ruby Patches

I recommend Derek, as Polina is away on internship.

Regards,
Dan

On Sun, Aug 8, 2010 at 9:58 PM, nathan binkert 
mailto:n...@binkert.org>> wrote:
Hi Brad,

I quickly skimmed the ruby patches, though I didn't do any "Ship It"
comments because I'm really not qualified to review them.  There is a
"Ruby" group in reviewboard, and I suggest that you change your
patches to use it so that it will include Polina and Derek in your
requests (or at least send them an e-mail and ask them to review your
changes.)

 Nate
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev



--
http://www.cs.wisc.edu/~gibson [esc]:wq!
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Resurrected Ruby's deterministic tests

[Gabe Black]

How about putting the stuff currently in memtest into memtest/random and
this new stuff in memtest/directed? I think both are technically
determinstic as implemented.

Gabe

Brad Beckmann wrote:
>   
>> On 2010-08-08 20:48:58, Nathan Binkert wrote:
>> 
>>> I think the directory name needs to have tester in it.  
>>> src/cpu/deterministic gives you no indication of what it actually is.  
>>> Beyond that, is it really necessary to have multiple testers?  Can we not 
>>> fold the functionality into a single tester?
>>>   
>
> I used the name deterministic because the directory contains multiple 
> deterministic testers.  I changed the name to determtest...does that work for 
> you?  These deterministic testers serve a very different purpose than the 
> random testers.  The deterministic testers are used for verifying latency and 
> protocol operation for a specific transaction.  They do not stress races like 
> the memtest or rubytest.  The deterministic testers are much simplier than 
> the random testers.  I don't think it would be easy to merge the different 
> testers' logic into a single tester and I'm not sure it is worth the effort.  
> This code is actually not new code.  It is actually fairly old GEMS code.  
> I'm not sure why it was moved over in the original transfer, but I've found 
> the code to be very valuable.
>
> I fixed the includes, guards, and comments.  Since these aren't new files, 
> but actually old GEMS files, I don't think it appropriate to change the 
> variable names in this patch.  Possibly later we can conver all the old GEMS 
> files to the M5 variable convention.
>
>
> - Brad
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/101/#review148
> ---
>
>
> On 2010-08-11 12:01:17, Brad Beckmann wrote:
>   
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviews.m5sim.org/r/101/
>> ---
>>
>> (Updated 2010-08-11 12:01:17)
>>
>>
>> Review request for Default.
>>
>>
>> Summary
>> ---
>>
>> ruby: Resurrected Ruby's deterministic tests
>>
>> Added the request series and invalidate deterministic tests as new cpu models
>> and removed the no longer needed ruby tests
>>
>>
>> Diffs
>> -
>>
>>   configs/example/determ_test.py PRE-CREATION 
>>   src/cpu/determtest/DetermGenerator.hh PRE-CREATION 
>>   src/cpu/determtest/DetermGenerator.cc PRE-CREATION 
>>   src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION 
>>   src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION 
>>   src/cpu/determtest/RubyDetermTester.hh PRE-CREATION 
>>   src/cpu/determtest/RubyDetermTester.cc PRE-CREATION 
>>   src/cpu/determtest/RubyDetermTester.py PRE-CREATION 
>>   src/cpu/determtest/SConscript PRE-CREATION 
>>   src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION 
>>   src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION 
>>   src/mem/protocol/RubySlicc_Exports.sm a75564db03c3 
>>   src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3 
>>   src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3 
>>   src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3 
>>   src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3 
>>   src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3 
>>   src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3 
>>   src/mem/ruby/tester/SConscript a75564db03c3 
>>
>> Diff: http://reviews.m5sim.org/r/101/diff
>>
>>
>> Testing
>> ---
>>
>>
>> Thanks,
>>
>> Brad
>>
>>
>> 
>
> ___
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>   

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Resurrected Ruby's deterministic tests

[Brad Beckmann]

> On 2010-08-08 20:48:58, Nathan Binkert wrote:
> > I think the directory name needs to have tester in it.  
> > src/cpu/deterministic gives you no indication of what it actually is.  
> > Beyond that, is it really necessary to have multiple testers?  Can we not 
> > fold the functionality into a single tester?

I used the name deterministic because the directory contains multiple 
deterministic testers.  I changed the name to determtest...does that work for 
you?  These deterministic testers serve a very different purpose than the 
random testers.  The deterministic testers are used for verifying latency and 
protocol operation for a specific transaction.  They do not stress races like 
the memtest or rubytest.  The deterministic testers are much simplier than the 
random testers.  I don't think it would be easy to merge the different testers' 
logic into a single tester and I'm not sure it is worth the effort.  This code 
is actually not new code.  It is actually fairly old GEMS code.  I'm not sure 
why it was moved over in the original transfer, but I've found the code to be 
very valuable.

I fixed the includes, guards, and comments.  Since these aren't new files, but 
actually old GEMS files, I don't think it appropriate to change the variable 
names in this patch.  Possibly later we can conver all the old GEMS files to 
the M5 variable convention.


- Brad


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/101/#review148
---


On 2010-08-11 12:01:17, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/101/
> ---
> 
> (Updated 2010-08-11 12:01:17)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> ruby: Resurrected Ruby's deterministic tests
> 
> Added the request series and invalidate deterministic tests as new cpu models
> and removed the no longer needed ruby tests
> 
> 
> Diffs
> -
> 
>   configs/example/determ_test.py PRE-CREATION 
>   src/cpu/determtest/DetermGenerator.hh PRE-CREATION 
>   src/cpu/determtest/DetermGenerator.cc PRE-CREATION 
>   src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION 
>   src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION 
>   src/cpu/determtest/RubyDetermTester.hh PRE-CREATION 
>   src/cpu/determtest/RubyDetermTester.cc PRE-CREATION 
>   src/cpu/determtest/RubyDetermTester.py PRE-CREATION 
>   src/cpu/determtest/SConscript PRE-CREATION 
>   src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION 
>   src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION 
>   src/mem/protocol/RubySlicc_Exports.sm a75564db03c3 
>   src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3 
>   src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3 
>   src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3 
>   src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3 
>   src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3 
>   src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3 
>   src/mem/ruby/tester/SConscript a75564db03c3 
> 
> Diff: http://reviews.m5sim.org/r/101/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: ruby: Resurrected Ruby's deterministic tests

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/101/
---

(Updated 2010-08-11 12:01:17.311934)


Review request for Default.


Summary
---

ruby: Resurrected Ruby's deterministic tests

Added the request series and invalidate deterministic tests as new cpu models
and removed the no longer needed ruby tests


Diffs (updated)
-

  configs/example/determ_test.py PRE-CREATION 
  src/cpu/determtest/DetermGenerator.hh PRE-CREATION 
  src/cpu/determtest/DetermGenerator.cc PRE-CREATION 
  src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION 
  src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.hh PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.cc PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.py PRE-CREATION 
  src/cpu/determtest/SConscript PRE-CREATION 
  src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION 
  src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION 
  src/mem/protocol/RubySlicc_Exports.sm a75564db03c3 
  src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3 
  src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3 
  src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3 
  src/mem/ruby/tester/SConscript a75564db03c3 

Diff: http://reviews.m5sim.org/r/101/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Ruby Patches

[Beckmann, Brad]

I've addressed Nate's comments and I have a set of patch updates to post for 
review.  I noticed that 'hg postreview' won't update the current patch but 
instead will create new patches.  I see that I can manually update the patches 
on the reviewboard website, but for the number of patches I want to update, 
that is rather tedious.  Can anyone recommend a better method, or am I suck 
manually updating the patches through the website?

Thanks,

Brad


From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of 
Dan Gibson
Sent: Monday, August 09, 2010 5:57 AM
To: M5 Developer List
Subject: Re: [m5-dev] Ruby Patches

I recommend Derek, as Polina is away on internship.

Regards,
Dan

On Sun, Aug 8, 2010 at 9:58 PM, nathan binkert 
mailto:n...@binkert.org>> wrote:
Hi Brad,

I quickly skimmed the ruby patches, though I didn't do any "Ship It"
comments because I'm really not qualified to review them.  There is a
"Ruby" group in reviewboard, and I suggest that you change your
patches to use it so that it will include Polina and Derek in your
requests (or at least send them an e-mail and ask them to review your
changes.)

 Nate
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev



--
http://www.cs.wisc.edu/~gibson [esc]:wq!
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] Review Request: ruby: Resurrected Ruby's deterministic tests

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/138/
---

Review request for Default.


Summary
---

ruby: Resurrected Ruby's deterministic tests

Added the request series and invalidate deterministic tests as new cpu models
and removed the no longer needed ruby tests


Diffs
-

  configs/example/determ_test.py PRE-CREATION 
  src/cpu/determtest/DetermGenerator.hh PRE-CREATION 
  src/cpu/determtest/DetermGenerator.cc PRE-CREATION 
  src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION 
  src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.hh PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.cc PRE-CREATION 
  src/cpu/determtest/RubyDetermTester.py PRE-CREATION 
  src/cpu/determtest/SConscript PRE-CREATION 
  src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION 
  src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION 
  src/mem/protocol/RubySlicc_Exports.sm a75564db03c3 
  src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3 
  src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3 
  src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3 
  src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3 
  src/mem/ruby/tester/SConscript a75564db03c3 

Diff: http://reviews.m5sim.org/r/138/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] Cron /z/m5/regression/do-regression quick

[Cron Daemon]

* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/o3-timing passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/inorder-timing 
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby 
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/o3-timing passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-atomic passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-atomic passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-timing passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-timing passed.
* build/ALPHA_SE/tests/fast/quick/01.hello-2T-smt/alpha/linux/o3-timing 
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby 
passed.
* build/ALPHA_SE/tests/fast/quick/20.eio-short/alpha/eio/simple-atomic 
passed.
* build/ALPHA_SE/tests/fast/quick/30.eio-mp/alpha/eio/simple-atomic-mp 
passed.
* build/ALPHA_SE/tests/fast/quick/20.eio-short/alpha/eio/simple-timing 
passed.
* build/ALPHA_SE/tests/fast/quick/30.eio-mp/alpha/eio/simple-timing-mp 
passed.
* build/ALPHA_SE/tests/fast/quick/50.memtest/alpha/linux/memtest passed.
* build/ALPHA_SE/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby 
passed.
* build/ALPHA_SE/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby 
passed.
* 
build/ALPHA_SE_MOESI_hammer/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MOESI_hammer
 passed.
* 
build/ALPHA_SE_MOESI_hammer/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MOESI_hammer
 passed.
* 
build/ALPHA_SE_MOESI_hammer/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby-MOESI_hammer
 passed.
* 
build/ALPHA_SE_MOESI_hammer/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MOESI_hammer
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-atomic 
passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual
 passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-timing-dual
 passed.
* 
build/ALPHA_FS/tests/fast/quick/80.netperf-stream/alpha/linux/twosys-tsunami-simple-atomic
 passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-timing 
passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/inorder-timing passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/o3-timing passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/simple-atomic passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/simple-timing passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/simple-timing-ruby 
passed.
* build/POWER_SE/tests/fast/quick/00.hello/power/linux/o3-timing passed.
* build/POWER_SE/tests/fast/quick/00.hello/power/linux/simple-atomic passed.
* build/SPARC_SE/tests/fast/quick/00.hello/sparc/linux/simple-atomic passed.
* build/SPARC_SE/tests/fast/quick/00.hello/sparc/linux/simple-timing passed.
* build/SPARC_SE/tests/fast/quick/02.insttest/sparc/linux/o3-timing passed.
* build/SPARC_SE/tests/fast/quick/02.insttest/sparc/linux/simple-atomic 
passed.
* build/SPARC_SE/tests/fast/quick/00.hello/sparc/linux/simple-timing-ruby 
passed.
* build/SPARC_SE/tests/fast/quick/02.insttest/sparc/linux/simple-timing 
passed.
* 
build/SPARC_SE/tests/fast/quick/40.m5threads-test-atomic/sparc/linux/simple-atomic-mp
 passed.
* 
build