Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- (Updated 2011-01-10 08:52:22.568922) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs (updated) - src/mem/ruby/libruby.hh b5d03e87db4e src/mem/ruby/libruby.cc b5d03e87db4e src/mem/ruby/recorder/TraceRecord.cc b5d03e87db4e src/mem/ruby/system/DMASequencer.cc b5d03e87db4e src/mem/ruby/system/RubyPort.cc b5d03e87db4e src/mem/ruby/system/Sequencer.cc b5d03e87db4e Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
On 2011-01-09 18:35:49, Ali Saidi wrote: Wasn't the alpha name for this load locked? That name or the ARM name (load exclusive) seems to make more sense to me than load linked. I choosed load linked because I think that is the more generally accepted computer science term for this type of synchronizaiton. Since this is on the Ruby side, I didn't want to use the ISA specific term. - Brad --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/#review685 --- On 2011-01-10 08:52:22, Brad Beckmann wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- (Updated 2011-01-10 08:52:22) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs - src/mem/ruby/libruby.hh b5d03e87db4e src/mem/ruby/libruby.cc b5d03e87db4e src/mem/ruby/recorder/TraceRecord.cc b5d03e87db4e src/mem/ruby/system/DMASequencer.cc b5d03e87db4e src/mem/ruby/system/RubyPort.cc b5d03e87db4e src/mem/ruby/system/Sequencer.cc b5d03e87db4e Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
Brad, this patch also did not apply cleanly. I think the patches that you are trying to upload do not follow git's style. On Mon, January 10, 2011 10:52 am, Brad Beckmann wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- (Updated 2011-01-10 08:52:22.568922) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs (updated) - src/mem/ruby/libruby.hh b5d03e87db4e src/mem/ruby/libruby.cc b5d03e87db4e src/mem/ruby/recorder/TraceRecord.cc b5d03e87db4e src/mem/ruby/system/DMASequencer.cc b5d03e87db4e src/mem/ruby/system/RubyPort.cc b5d03e87db4e src/mem/ruby/system/Sequencer.cc b5d03e87db4e Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev -- Nilay ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- (Updated 2011-01-10 11:09:50.845297) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs (updated) - src/mem/ruby/libruby.hh 9f9e10967912 src/mem/ruby/libruby.cc 9f9e10967912 src/mem/ruby/recorder/TraceRecord.cc 9f9e10967912 src/mem/ruby/system/DMASequencer.cc 9f9e10967912 src/mem/ruby/system/RubyPort.cc 9f9e10967912 src/mem/ruby/system/Sequencer.cc 9f9e10967912 Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
Oops...I forgot to include the -o option when updating it. I just uploaded a new patch...try it again. Brad -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Sent: Monday, January 10, 2011 9:01 AM To: M5 Developer List Subject: Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC Brad, this patch also did not apply cleanly. I think the patches that you are trying to upload do not follow git's style. On Mon, January 10, 2011 10:52 am, Brad Beckmann wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- (Updated 2011-01-10 08:52:22.568922) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs (updated) - src/mem/ruby/libruby.hh b5d03e87db4e src/mem/ruby/libruby.cc b5d03e87db4e src/mem/ruby/recorder/TraceRecord.cc b5d03e87db4e src/mem/ruby/system/DMASequencer.cc b5d03e87db4e src/mem/ruby/system/RubyPort.cc b5d03e87db4e src/mem/ruby/system/Sequencer.cc b5d03e87db4e Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev -- Nilay ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/#review685 --- Wasn't the alpha name for this load locked? That name or the ARM name (load exclusive) seems to make more sense to me than load linked. - Ali On 2011-01-06 16:07:31, Brad Beckmann wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- (Updated 2011-01-06 16:07:31) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs - src/mem/ruby/libruby.hh 9f9e10967912 src/mem/ruby/libruby.cc 9f9e10967912 src/mem/ruby/recorder/TraceRecord.cc 9f9e10967912 src/mem/ruby/system/DMASequencer.cc 9f9e10967912 src/mem/ruby/system/RubyPort.cc 9f9e10967912 src/mem/ruby/system/Sequencer.cc 9f9e10967912 Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/#review655 --- src/mem/ruby/libruby.cc http://reviews.m5sim.org/r/391/#comment892 Does it make sense to update these strings too? I'd think so, unless there's some reason not to. - Steve On 2011-01-06 16:07:31, Brad Beckmann wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- (Updated 2011-01-06 16:07:31) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs - src/mem/ruby/libruby.hh 9f9e10967912 src/mem/ruby/libruby.cc 9f9e10967912 src/mem/ruby/recorder/TraceRecord.cc 9f9e10967912 src/mem/ruby/system/DMASequencer.cc 9f9e10967912 src/mem/ruby/system/RubyPort.cc 9f9e10967912 src/mem/ruby/system/Sequencer.cc 9f9e10967912 Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
[m5-dev] Review Request: Ruby: Update the Ruby request type names for LL/SC
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/391/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Ruby: Update the Ruby request type names for LL/SC Diffs - src/mem/ruby/libruby.hh 9f9e10967912 src/mem/ruby/libruby.cc 9f9e10967912 src/mem/ruby/recorder/TraceRecord.cc 9f9e10967912 src/mem/ruby/system/DMASequencer.cc 9f9e10967912 src/mem/ruby/system/RubyPort.cc 9f9e10967912 src/mem/ruby/system/Sequencer.cc 9f9e10967912 Diff: http://reviews.m5sim.org/r/391/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
