Re: [VOTE] Release Apache AGE (incubating) 0.5.0

[Justin Mclean]

Hi,

> I didn’t see the issues with NOTICE, the wrong header on the file or the 
> unexpected binary files on your dev list but may have missed it.

Sorry ignore that, wrong release.

Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache AGE (incubating) 0.5.0

[Justin Mclean]

Hi,

> Agreed, these were called out in our dev@ vote

I didn’t see the issues with NOTICE, the wrong header on the file or the 
unexpected binary files on your dev list but may have missed it.

Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache AGE (incubating) 0.5.0

[Felix Cheung]

Agreed, these were called out in our dev@ vote

https://lists.apache.org/thread.html/r0f291fd923bd0217da1935811b4276699aac28715c1936d713e99002%40%3Cdev.age.apache.org%3E


On Fri, Jul 30, 2021 at 4:03 PM Justin Mclean 
wrote:

> Hi,
>
> +1 (binding) but only because of WIP disclaimer. Normally I would vote -1
> due to compiled code in the source release [1]
>
> I checked:
> - incubating in name
> - signatures and hashes exist
> - disclaimer exists
> - LICENSE is missing [2][3]
> - contains unexpected binary file [1]
> - A large number of source files under [4] are missing ASF headers
>
> Please read [5] and follow the instruction there before the next release.
>
> Kind Regards,
> Justin
>
> 1. ./drivers/jdbc/gradle/wrapper/gradle-wrapper.jar
> 2. ./drivers/jdbc/gradlew
> 3. ./drivers/jdbc/gradlew.bat
> 4. ./drivers/jdbc/lib/src/main/java/org/apache/age/jdbc/
> 5. https://issues.apache.org/jira/browse/LEGAL-469
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache NLPCraft (incubating) v 0.9.0

[Justin Mclean]

Hi,

+1 but only due to work in progress disclaimer. There are serval minor issues 
that need to be fixed.

I checked:
- incubating in name
- signatures and hashes good
- disclaimer exists
- license is missing information on a file [6]
- NOTICE is not correct. As mentioned on a previous release [1] there is no 
need to list licenses or unneeded copyright statement in NOTICE. If this is not 
fixed in a future release I will vote -1 on it.
- source release contains compiled code [2][3][4][5]
- This file incorrectly has an ASF header [6] and should be mention in LICENSE

This release is hard to review as for some reason rat doesn’t recognise the 
headers on the scala files. This may have hidden some other issues.

Kind Regards,
Justin

1. 
https://lists.apache.org/thread.html/rf79136697625906cdbf723eeed3b710eb6f4256a39493bbc715238a0%40%3Cgeneral.incubator.apache.org%3E
2. ./nlpcraft/src/main/python/ctxword/__pycache__/server.cpython-38.pyc
3. ./nlpcraft/src/main/python/ctxword/bertft/__pycache__/__init__.cpython-38.pyc
4. ./nlpcraft/src/main/python/ctxword/bertft/__pycache__/bertft.cpython-38.pyc
5. ./nlpcraft/src/main/python/ctxword/bertft/__pycache__/utils.cpython-38.pyc
6. ./nlpcraft/src/main/scala/org/apache/nlpcraft/common/util/NCIdGenerator.java
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache AGE (incubating) 0.5.0

[Justin Mclean]

Hi,

+1 (binding) but only because of WIP disclaimer. Normally I would vote -1 due 
to compiled code in the source release [1]

I checked:
- incubating in name
- signatures and hashes exist
- disclaimer exists
- LICENSE is missing [2][3]
- contains unexpected binary file [1]
- A large number of source files under [4] are missing ASF headers

Please read [5] and follow the instruction there before the next release.

Kind Regards,
Justin

1. ./drivers/jdbc/gradle/wrapper/gradle-wrapper.jar
2. ./drivers/jdbc/gradlew
3. ./drivers/jdbc/gradlew.bat
4. ./drivers/jdbc/lib/src/main/java/org/apache/age/jdbc/
5. https://issues.apache.org/jira/browse/LEGAL-469


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Justin Mclean]

Hi,

> the ./web component is in the release but I don't see its dependencies
> (even as MIT licensed) listed?

Dependancies don’t need to be mentioned in the LICENSE file if they don’t end 
up in the source release.

Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache NLPCraft (incubating) v 0.9.0

[Nikita Ivanov]

+1

Carrying over my vote from PPMC.
--
Nikita Ivanov


On Fri, Jul 30, 2021 at 10:34 AM Aaron Radzinski  wrote:
>
> Hello all,
> This is a call for a vote to release Apache NLPCraft (incubating)
> version 0.9.0. Apache NLPCraft is a library for adding a natural
> language interface to any application.
>
> The Apache NLPCraft community has voted on and approved a proposal to
> release Apache NLPCraft (Incubating) version 0.9.0. We would like to
> request the Incubator PMC members review and vote on this incubator
> release.
>
> Release information:
> 1. PPMC vote result thread:
> https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202107.mbox/%3CCACwEJt-vcEO6PO7Q2jm2JoypSduzwuVL-z1_7gCzDH24SG24mw%40mail.gmail.com%3E
> 2. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.9.0/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.9.0
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347778
> 5. KEYS file: 
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> PPMC vote has already provided a required majority approval and
> therefore this vote is a lazy consensus vote open for 72 hours.
>
> Please vote accordingly:
> +1 approve
> +0 no opinion
> -1 disapprove with the reason
>
> Thank you,
> Aaron.
> ---
> On behalf of NLPCraft community
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Felix Cheung]

Similar questions from me

- incubating in name
- signature and hash fine
- DISCLAIMER is fine
- No unexpected binary files

- LICENSE and NOTICE
the ./web component is in the release but I don't see its dependencies
(even as MIT licensed) listed?
Is anything bundled in there?


- these source files do not have ASF headers
./k8shim/test/e2e/predicates/predicates_suite_test.go
./k8shim/test/e2e/predicates/predicates_test.go
./core/pkg/scheduler/mock_plugin_test.go

the project has the normal disclaimer, so I'd think issues with LICENSE and
ASF header applies.
https://incubator.apache.org/guides/releasemanagement.html#choice_of_disclaimers


On Fri, Jul 30, 2021 at 2:31 AM Wilfred Spiegelenburg
 wrote:

> We are not using any of the polyfills except for the one that is mandatory
> (zone.js) which is part of the angular framework.
> The angular framework is not part of the source tar. The zone.js file is
> also not part of the source tar.
>
> The polyfills.ts file just defines that it will be imported when you build
> the app.
> After cleanup the polyfills.ts file would be a license header and 1 import
> statement.
>
> Is that acceptable?
>
> Wilfred
>
> > On 30 Jul 2021, at 18:55, Justin Mclean 
> wrote:
> >
> > Hi,
> >
> >> The base settings are code generated. The software that generates these
> base setting is angular. It shows up as a MIT license [1].
> >> The file content after the generation is part of the created project
> which then gets customised.
> >
> >
> > You might want to double check that. A quick glance that this page [1]
> mentions polyfills that are either public domain, MIT or Apache licensed.
> Obviously all of these licenses are compatible but it would be good to know
> which it is.
> >
> > Kind Regards,
> > Justin
> >
> > 1. https://angular.io/guide/browser-support
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
>
> Wilfred Spiegelenburg
> Staff Software Engineer
>  
>

[VOTE] Release Apache NLPCraft (incubating) v 0.9.0

[Aaron Radzinski]

Hello all,
This is a call for a vote to release Apache NLPCraft (incubating)
version 0.9.0. Apache NLPCraft is a library for adding a natural
language interface to any application.

The Apache NLPCraft community has voted on and approved a proposal to
release Apache NLPCraft (Incubating) version 0.9.0. We would like to
request the Incubator PMC members review and vote on this incubator
release.

Release information:
1. PPMC vote result thread:
https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202107.mbox/%3CCACwEJt-vcEO6PO7Q2jm2JoypSduzwuVL-z1_7gCzDH24SG24mw%40mail.gmail.com%3E
2. Release location:
https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.9.0/
3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.9.0
4. JIRA issues fixed in release:
https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347778
5. KEYS file: https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS

PPMC vote has already provided a required majority approval and
therefore this vote is a lazy consensus vote open for 72 hours.

Please vote accordingly:
+1 approve
+0 no opinion
-1 disapprove with the reason

Thank you,
Aaron.
---
On behalf of NLPCraft community

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

[VOTE] Release Apache AGE (incubating) 0.5.0

[Eya Badal]

Dear Apache Community, 

This is a call for releasing Apache AGE (Incubating) 0.5.0.

To learn more about Apache AGE (Incubating), please see http://age.apache.org
*

Apache AGE (incubating) community has voted and approved the release.
This vote passed with 9 +1 votes (3 bindings and 6 non-bindings) and no 0 or -1 
votes.


+1 (Bindings) 
 --
* Felix Cheung
* vongosling
* Kevin Ratnasekera 

*
The git tag to be discussed and voted upon:
https://github.com/apache/incubator-age/releases/tag/v0.5.0

The git commit hash:
commit e36e6d79c2a65259f4b46cd9a3623d69518605a4

The release files for 0.5.0, can be found at:
https://dist.apache.org/repos/dist/dev/incubator/age/0.5.0.rc0%20/

The signatures, files, etc. can be found at:
https://dist.apache.org/repos/dist/dev/incubator/age/

Signatures used for AGE RCs can be found in this file:
https://dist.apache.org/repos/dist/dev/incubator/age/KEYS

The fingerprint of key to sign release artifacts:
FD8B 268F 784A CE10 F201  E63B C063 8775 6375 38D2

For information about the contents of this release, see:
https://github.com/apache/incubator-age/releases/tag/v0.5.0



The vote will be open for 72 hours.
[ ] +1 release this package 
[ ] +0 no opinion
[ ] -1 do not release this package because...


Thank you for all your time. 

Best regards,
Eya Badal 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

?????? [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[????????]

+1 (binding)





----
??: 
   "general"

https://github.com/tokers

On Thu, Jul 29, 2021 at 4:04 PM Julia Kinga Marton https://lists.apache.org/thread.html/r0037975be6fa14069f83a724aa3f8e4d3e9654e374228768ba22aceb%40%3Cdev.yunikorn.apache.org%3E

 Vote result 
thread:https://lists.apache.org/thread.html/r568f7d7ae4520faec90443b2c7d6b54e05ab7faf2042a30a2858e23d%40%3Cdev.yunikorn.apache.org%3E

 Issues included in this
 release:https://issues.apache.org/jira/projects/YUNIKORN/versions/12350025

 The release 
candidate:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.11/

 This release has been signed with a PGP available
 here:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS

 Git tag for the release:
 - 
https://github.com/apache/incubator-yunikorn-core/tree/v0.11.0
 - 
https://github.com/apache/incubator-yunikorn-k8shim/tree/v0.11.0
 
-https://github.com/apache/incubator-yunikorn-scheduler-interface/tree/v0.11.0
 - https://github.com/apache/incubator-yunikorn-web/tree/v0.11.0

 The vote will be open for at least 72 hours or until the necessary number
 of votes is reached.

 Please vote accordingly:
 [ ] +1 Approve the release of Apache YuniKorn (Incubating) 0.11.0
 [ ] +0
 [ ] -1 Do not approve (please specify the reason)

 Thanks,
 Kinga Marton
 Apache YuniKorn (Incubating)

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0

[Zhang Yonglun]

I tried to run rat (version 0.9, 0.10, 0.11, 0.12, 0.13) via the command
line:
java -jar apache-rat-0.13.jar -d shenyu-admin

All the results are:
AL./src/test/java/org/apache/shenyu/admin/utils/ThreadLocalUtilTest.java

The results marked ThreadLocalUtilTest.java AL(Apache License headers), but
not unapproved licenses.

Did I miss something?


--

Zhang Yonglun
Apache ShenYu (Incubating)
Apache ShardingSphere


Justin Mclean  于2021年7月30日周五 下午3:59写道：

> Hi,
>
> > This file contains some very simple test cases, we assume that they are
> not
> > from another project, but just added a wrong license header. We are
> trying
> > to contact the contributor who contribute this file to make things clear.
> > Before he/she respond, we'd like to remove this file to avoid issues.
>
> Thanks for that. I assume they were not copied as well, and are ASF files,
> but best to make sure.
>
> > BTW, we check the licenses via apache-rat-plugin, but it didn't prompt
> this
> > file has a problem, even the header is not right.
>
> I also ran rat but via the command line, perhaps your rat exclusions are a
> little too wide?
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Wilfred Spiegelenburg]

We are not using any of the polyfills except for the one that is mandatory 
(zone.js) which is part of the angular framework.
The angular framework is not part of the source tar. The zone.js file is also 
not part of the source tar.

The polyfills.ts file just defines that it will be imported when you build the 
app.
After cleanup the polyfills.ts file would be a license header and 1 import 
statement.

Is that acceptable?

Wilfred

> On 30 Jul 2021, at 18:55, Justin Mclean  wrote:
> 
> Hi,
> 
>> The base settings are code generated. The software that generates these base 
>> setting is angular. It shows up as a MIT license [1].
>> The file content after the generation is part of the created project which 
>> then gets customised.
> 
> 
> You might want to double check that. A quick glance that this page [1] 
> mentions polyfills that are either public domain, MIT or Apache licensed. 
> Obviously all of these licenses are compatible but it would be good to know 
> which it is.
> 
> Kind Regards,
> Justin
> 
> 1. https://angular.io/guide/browser-support
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Wilfred Spiegelenburg
Staff Software Engineer
 

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Justin Mclean]

Hi,

> The base settings are code generated. The software that generates these base 
> setting is angular. It shows up as a MIT license [1].
> The file content after the generation is part of the created project which 
> then gets customised.


You might want to double check that. A quick glance that this page [1] mentions 
polyfills that are either public domain, MIT or Apache licensed. Obviously all 
of these licenses are compatible but it would be good to know which it is.

Kind Regards,
Justin

1. https://angular.io/guide/browser-support
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Wilfred Spiegelenburg]

> On 30 Jul 2021, at 18:22, Justin Mclean  wrote:
> 
> Hi,
> 
>> [3] is a settings file. The comments should have been cleaned up when the 
>> settings were customised.
> 
> Presumably the file (and it comments) are copyright to someone and under some 
> license? Do you know who/what that is?
> 

The base settings are code generated. The software that generates these base 
setting is angular. It shows up as a MIT license [1].
The file content after the generation is part of the created project which then 
gets customised.

Wilfred

[1] https://angular.io/license


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Justin Mclean]

Hi,

> [3] is a settings file. The comments should have been cleaned up when the 
> settings were customised.

Presumably the file (and it comments) are copyright to someone and under some 
license? Do you know who/what that is?

Thanks,
Justin

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0

[Justin Mclean]

Hi,

> This file contains some very simple test cases, we assume that they are not
> from another project, but just added a wrong license header. We are trying
> to contact the contributor who contribute this file to make things clear.
> Before he/she respond, we'd like to remove this file to avoid issues.

Thanks for that. I assume they were not copied as well, and are ASF files, but 
best to make sure.

> BTW, we check the licenses via apache-rat-plugin, but it didn't prompt this
> file has a problem, even the header is not right.

I also ran rat but via the command line, perhaps your rat exclusions are a 
little too wide?

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Wilfred Spiegelenburg]

[1] was added as part of jira YUNIKORN-505.
[2] was added as part of jira YUNIKORN-427.

Both are apache files: jiras have been logged to add the headers.

[3] is a settings file. The comments should have been cleaned up when the 
settings were customised.

I have filed a jira for the cleanup. The file was already in YuniKorn v0.10

Wilfred 

> On 30 Jul 2021, at 15:46, Justin Mclean  wrote:
> 
> Hi,
> 
> -1 (binding) as there files missing headers and a possible license issue. If 
> the licenses of these files are clarified my vote can change.
> 
> I checked:
> - incubating in name
> - signatures and hashes are fine
> - DISCLAIMER exists
> - LICENSE may be OK, except this file? [3]
> -  NOTICE is fine
> - No unexpected binary files
> - A couple of files are missing ASF headers
> 
> A couple of files are missing ASF headers, where did they come from and how 
> are these licensed? [1][2]
> 
> Is this file actually an ASF file or is it a 3rd party file? [3] If it a 3rd 
> party file how is it licensed?
> 
> Kind Regards,
> Justin
> 
> 1.  /core/pkg/scheduler/mock_plugin_test.go
> 2.  /k8shim/test/e2e/predicates/predicates_test.go
> 3. /web/src/polyfills.ts
> 
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Wilfred Spiegelenburg
Staff Software Engineer
 

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0

[Zhang Yonglun]

Hi Justin,

Thanks for your help.

> This file [1] has an incorrect header and may be from another project.
Where sis this code come from?
This file contains some very simple test cases, we assume that they are not
from another project, but just added a wrong license header. We are trying
to contact the contributor who contribute this file to make things clear.
Before he/she respond, we'd like to remove this file to avoid issues.

BTW, we check the licenses via apache-rat-plugin, but it didn't prompt this
file has a problem, even the header is not right. Can you give us some
suggestions that how you find out this problem? So that we can use the same
method to check all the files again before start the next round vote.

> This file [2] may incorrectly have an ASF header and contains 3rd party
code not mentioned in LICENSE. Looks like there may be other 3rd party code
(from the same project) in other files as well?
Yes, the other file contains 3rd party code is
./apache-shenyu-incubating-2.4.0-src/shenyu-admin/src/main/resources/static/index.40aac744.js
All the two files (index.6e738f45.css and index.40aac744.js) are built from
shenyu-dashboard, they should not appear in the src release package. We
will exclude these two files from the src package.

After resolve these two problems, we can start the round 2 vote process.

Thanks.


--

Zhang Yonglun
Apache ShenYu (Incubating)
Apache ShardingSphere



Justin Mclean  于2021年7月30日周五 下午3:16写道：

> Hi,
>
> Look like I hit send too soon there:
> "Sorry but it -1 binding form me. LICENSE is missing 3rd  party license
> information”
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Accept Linkis into the Apache Incubator

[Goson zhang]

+1 (nobinding)

Good luck,

Saisai Shao  于2021年7月29日周四 上午10:06写道：

> +1 (binding)
>
> Best,
> Saisai
>
> Willem Jiang  于2021年7月29日周四 上午7:59写道：
>
> > +1 (binding)
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, Jul 26, 2021 at 11:12 PM 俊平堵  wrote:
> > >
> > > Dear all,
> > >
> > >
> > > Following up the [DISCUSS] thread on Linkis[1], I would like to call a
> > > VOTE to accept Linkis into the Apache Incubator. Please cast your
> > > vote:
> > >
> > >   [ ] +1, bring Linkis into the Incubator
> > >   [ ] +0, I don't care either way
> > >   [ ] -1, do not bring Linkis into the Incubator, because...
> > >
> > > The vote will open for at least 72 hours. Only votes from the
> > > Incubator PMC are binding, but welcome for the votes from everyone.
> > >
> > > Please check out the Linkis Proposal from the incubator wiki[2].
> > > [1]
> >
> https://lists.apache.org/thread.html/r5d3af665795ebd3028ca9978e92af5d650a43b6680470d16e43f3847%40%3Cgeneral.incubator.apache.org%3E
> > > [2]
> https://cwiki.apache.org/confluence/display/INCUBATOR/LinkisProposal
> > >
> > > Regards,
> > > Junping Du
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0

[Justin Mclean]

Hi,

Look like I hit send too soon there:
"Sorry but it -1 binding form me. LICENSE is missing 3rd  party license 
information”

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache MXNet (incubating) version 1.9.0.rc6

[Justin Mclean]

Hi,

-1 (binding) for header and licensing issues

There also seems to be an issue with the directories  dlpack, dmlc, mshadow 
ands nnvm under the include directory in the tar file?

I checked:
- incubating in name
- DISCLAIMER exists
- LICENSE has issues
- NOTICE seems OK 
- A lot of files have header issues (see below)
- No unexpected binary files

I did a spot check on LICENSE and found a number of issues. I did not check 
everything so there are likely to be more issue that those below.
- This file [5] seem to incorrectly have an ASF header but is listed at MIT in 
the file and in LICENSE.
- As do these files [6][7][8]
- This file has a comment that states "Code is a direct translation of the 
erfinv m file in matlab version 2.0.” and the GitHub reference doesn't have a 
BSD file header. As far as I’m aware Matlab is not open source software. Is 
this Category X software?
- This file seem to also incorrectly have an ASF header and is an unknown 
license. I can’t see mentioned in LICENSE.
- This files seem to have incorrect licensing information [13] At the URL 
referenced it has a different header. I can’t see why the ASF copyright would 
be in this header.
- These files seem to incorrectly have an ASF header [15][16][17]

A large number of file have ASF headers but also state "Copyright (c) 201X by 
Contributors”. e.g [1][2][3][4] There looks to be more than 500 files like 
this.  Are these 3rd party file or ASF files? If they are ASF files there there 
should be no copyright line.

A number of files have "Copyright (c) 201X Microsoft” and also have ASF 
headers. Are these files 3rd party files or ASF files? e.g. [11] They look like 
3rd party files to me. Some are Apache licensed but some are not. e.g [12] I 
cannot see this mentioned in LICENSE.

I also noticed that the docker file refreshes to https://github.com/dmlc/mxnet 
Why is this? In fact there seems to be a large number of references to 
"https://github.com/dmlc” and "https://github.com/dmlc/mxnet;.

Kind Regards,
Justin

1. ./include/mxnet/op_attr_types.h
2 ./cpp-package/include/mxnet-cpp/op_suppl.h
3. ./src/initialize.cc
4 ./src/operator/cudnn_bilinear_sampler-inl.h
5. ./src/operator/nn/layer_norm.cc
6. ./src/operator/numpy/np_einsum_op.cc
7. ./src/operator/numpy/np_einsum_op-inl.h
8. ./src/operator/numpy/np_einsum_path_op-inl.h
9 ./src/operator/contrib/erfinv-inl.h
10. ./example/image-classification/predict-cpp/image-classification-predict.cc
11. ./src/operator/contrib/deformable_psroi_pooling.cu
12. ./src/operator/contrib/modulated_deformable_convolution.cu
13 ./src/operator/contrib/erfinv-inl.h
14. 
https://github.com/numpy/numpy/blob/master/numpy/core/src/multiarray/einsum.c.src
15. vi ./python/mxnet/onnx/mx2onnx/_export_onnx.py
16 ./cmake/Modules/FindJeMalloc.cmake
17 ./src/operator/nn/mkldnn/mkldnn_base-inl.h



-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org