RE: [MENTORS] December timeline reports due December 1st

2021-11-21 Thread Vira Vitanska 
Hi Justin,

I got it.

Thank you for your explanation.

Best regards,
Vira Vitanska
 

-Original Message-
From: Justin Mclean  
Sent: Sunday, November 21, 2021 10:07 AM
To: general@incubator.apache.org
Subject: Re: [MENTORS] December timeline reports due December 1st

Hi,

> DataLab was included in report for November. So, is the report failed? 
> https://urldefense.com/v3/__https://cwiki.apache.org/confluence/displa
> y/INCUBATOR/November2021__;!!GF_29dbcQIUBPA!l9rjjKc3XwCGkOSZpAu40bNjhC
> 6JRH6G31sZqHb0uh-oaCfQBNL0MoyhWp4qK_k3eQ$ [cwiki[.]apache[.]org] 
>  ay/INCUBATOR/November2021__;!!GF_29dbcQIUBPA!l9rjjKc3XwCGkOSZpAu40bNjh
> C6JRH6G31sZqHb0uh-oaCfQBNL0MoyhWp4qK_k3eQ$ [cwiki[.]apache[.]org]> 
> https://urldefense.com/v3/__https://whimsy.apache.org/board/minutes/Da
> taLab.html__;!!GF_29dbcQIUBPA!l9rjjKc3XwCGkOSZpAu40bNjhC6JRH6G31sZqHb0
> uh-oaCfQBNL0MoyhWp7nOxSc3A$ [whimsy[.]apache[.]org] 
>  ataLab.html__;!!GF_29dbcQIUBPA!l9rjjKc3XwCGkOSZpAu40bNjhC6JRH6G31sZqHb
> 0uh-oaCfQBNL0MoyhWp7nOxSc3A$ [whimsy[.]apache[.]org]>
> 
> Now, in this email it's mentioned that DataLab's report for December 
> is supposed to be done as well. However, DataLab is absent in the 
> Table of Contents for December: 
> https://urldefense.com/v3/__https://cwiki.apache.org/confluence/displa
> y/INCUBATOR/December2021__;!!GF_29dbcQIUBPA!l9rjjKc3XwCGkOSZpAu40bNjhC
> 6JRH6G31sZqHb0uh-oaCfQBNL0MoyhWp7muAeCkA$ [cwiki[.]apache[.]org] 
>  ay/INCUBATOR/December2021__;!!GF_29dbcQIUBPA!l9rjjKc3XwCGkOSZpAu40bNjh
> C6JRH6G31sZqHb0uh-oaCfQBNL0MoyhWp7muAeCkA$ [cwiki[.]apache[.]org]>
> 
> So, do we have to report for December?
> If yes, then do we have to add DataLab in the Table of contents by ourselves?

I'm not 100% sure why the script is picking up DataLab as needing to report 
it’s not on a monthly schedule and is in group 1 which doesn’t need to report 
this month. For some reason you are listed in the shepherds file. There's no 
need for you to report.

Kind Regards,
Justin

Re: [VOTE] Release Apache Pegasus (Incubating) 2.3.0-RC2

2021-11-21 Thread Duo Zhang 
+1(binding)

Checked sigs and sums: Matched
LICENSE and NOTICE: In place
DISCLAIMER-WIP: In place
Built from src: Succeeded with the steps mentioned here

https://github.com/pegasus-kv/pegasus-docker

I think we should also move this repo under the governance of ASF later.

Run UTs: First it failed with can not find libjvm.so, I had to manually add
the path for libjvm.so to the LD_LIBRARY_PATH, and this time I got a failure

[--] Global test environment tear-down
[==] 74 tests from 23 test cases ran. (43536 ms total)
[  PASSED  ] 73 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] pegasus_server_impl_test.test_table_level_slow_query

I assume this is only for me? And considering the name, I guess this is
just for performance, not correctness, so should not be a blocker.

Thanks.

Justin Mclean  于2021年11月21日周日 下午3:48写道：

> Hi,
>
> +1 (binding) because of WIP disclaimer
>
> I checked:
> - incubating in name
> - DISCLAIMER exists (WIP)
> - signatures and hashes are fine
> - NOTICE looks OK but given the large number of ALv2 code included I would
> expect some of them to have NOTICE files
> - From a quick quick LICENSE is missing some information. e.g this file
> [1] (other others) which is confusingly has copyright claimed by two
> companies or theses files [2][3] there are likely other files.
> - All ASF files have ASF headers
> - No unexpected binary files
> - Can't compile from source but assume that’s my platform
>
> Kind Regards,
> Justin
>
> 1. ./rdsn/src/utils/test/TokenBucketTest.cpp
> 2. ./rdsn/bin/FindRT.cmake
> 3. ./rdsn/scripts/linux/run-clang-format.py
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Wayang (Incubating) 0.6.0-RC6

2021-11-21 Thread Bertty Contreras 
Hi Justin,

Also we found other files that have the same issue and we fixed it :D.

We will prepare the new RC :D

Best Regards,
Bertty

On Sun, Nov 21, 2021 at 9:29 AM Justin Mclean 
wrote:

> Hi,
>
> Sorry but it -1 (binding) from me due to LICENSE and NOTICE issues and 3rd
> party code having an ASF header.
>
> I checked:
> - incubating in name
> - signatures and hashes are fine.
> - DISCLAIMER exists
> - NOTICE and LICENSE are not correct. Licenses need to be mentioned in
> LICENSE. If the code has a NOTICE file then it’s content need to be in
> NOTICE.
> - ASF headers have been incorrectly added to 3rd party files e.g. [1]
> - Other ASF files headers seem fine
> - Can compile from source
>
> Also please do not use the words "Copyright 2020 and onwards” as copyright
> has an expiry date.
>
> Kind Regards,
> Justin
>
> 1.
> ./wayang-commons/wayang-utils-profile-db/src/main/java/org/apache/wayang/commons/util/profiledb/instrumentation/StopWatch.java
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Wayang (Incubating) 0.6.0-RC6

2021-11-21 Thread Alexander Alten 
Hi,

Thanks for finding this, Justin. We fix and prepare the new RC. 

Stay safe, cheers,
—Alex 

> On 21. Nov 2021, at 09:29, Justin Mclean  wrote:
> 
> Hi,
> 
> Sorry but it -1 (binding) from me due to LICENSE and NOTICE issues and 3rd 
> party code having an ASF header.
> 
> I checked:
> - incubating in name
> - signatures and hashes are fine.
> - DISCLAIMER exists
> - NOTICE and LICENSE are not correct. Licenses need to be mentioned in 
> LICENSE. If the code has a NOTICE file then it’s content need to be in 
> NOTICE. 
> - ASF headers have been incorrectly added to 3rd party files e.g. [1]
> - Other ASF files headers seem fine
> - Can compile from source
> 
> Also please do not use the words "Copyright 2020 and onwards” as copyright 
> has an expiry date.
> 
> Kind Regards,
> Justin
> 
> 1. 
> ./wayang-commons/wayang-utils-profile-db/src/main/java/org/apache/wayang/commons/util/profiledb/instrumentation/StopWatch.java
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Sedona 1.1.1-incubating-rc1

2021-11-21 Thread Justin Mclean 
Hi,

I’m -1 (binding) on this release as the project website doesn’t have an obvious 
download page and they have made previous releases. This has been brought up on 
this list before and there was no response from the project.

For this release:
- incubating in name
- signatures and hashes are fine
- disclaimer exists
- LICENSE and NOTICE look OK but I didn’t do a detailed check
- The year in NOTICE looks incorrect as Sedona only started in the incubator in 
2020?
- ASF files have headers
- No unexpected binary files
- Can compile from source

Kind Regards,
Justin


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Wayang (Incubating) 0.6.0-RC6

2021-11-21 Thread Justin Mclean 
Hi,

Sorry but it -1 (binding) from me due to LICENSE and NOTICE issues and 3rd 
party code having an ASF header.

I checked:
- incubating in name
- signatures and hashes are fine.
- DISCLAIMER exists
- NOTICE and LICENSE are not correct. Licenses need to be mentioned in LICENSE. 
If the code has a NOTICE file then it’s content need to be in NOTICE. 
- ASF headers have been incorrectly added to 3rd party files e.g. [1]
- Other ASF files headers seem fine
- Can compile from source

Also please do not use the words "Copyright 2020 and onwards” as copyright has 
an expiry date.

Kind Regards,
Justin

1. 
./wayang-commons/wayang-utils-profile-db/src/main/java/org/apache/wayang/commons/util/profiledb/instrumentation/StopWatch.java
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [MENTORS] December timeline reports due December 1st

2021-11-21 Thread Justin Mclean 
Hi,

> DataLab was included in report for November. So, is the report failed? 
> https://cwiki.apache.org/confluence/display/INCUBATOR/November2021 
> 
> https://whimsy.apache.org/board/minutes/DataLab.html 
> 
> 
> Now, in this email it's mentioned that DataLab's report for December is 
> supposed to be done as well. However, DataLab is absent in the Table of 
> Contents for December: 
> https://cwiki.apache.org/confluence/display/INCUBATOR/December2021 
> 
> 
> So, do we have to report for December?
> If yes, then do we have to add DataLab in the Table of contents by ourselves?

I'm not 100% sure why the script is picking up DataLab as needing to report 
it’s not on a monthly schedule and is in group 1 which doesn’t need to report 
this month. For some reason you are listed in the shepherds file. There's no 
need for you to report.

Kind Regards,
Justin