Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc3

[Hagay Lupesko]

yay! so many goodies in this release, looking forward to see it out.
Kudos to everyone who assisted in the release...

On Wed, Feb 27, 2019 at 9:54 AM Piyush Ghai  wrote:

> Hi all,
>
> Thanks everyone for spending the time to test and vote.
>
> This vote passes with 5 +1 votes (4 binding) and no 0 or -1 votes.
>
> +1 votes
> Henri Yandell / binding
> Jason Dai / binding
> Justin Mclean / binding
> Michael Wall / binding
> Sheng Zha
>
> 0 votes
> No votes
>
> -1 votes
> No votes
>
> I will move forward with publishing the official release now.
>
> Thanks,
> Piyush
>
>
>
> On 2019/02/27 05:34:03, Sheng Zha  wrote:
> > +1
> >
> > And thanks to mentors and IPMC members for helping our release. NOTICE
> year
> > was caught in dev@ vote too. Master branch already has the fix [1] and
> we
> > promise to fix it in the next release.
> >
> > -sz
> >
> > [1]
> >
> https://github.com/apache/incubator-mxnet/pull/14043/files#diff-aa14599dc3fdfa9cc81a7c3c247b77b9L2
> >
> > On Tue, Feb 26, 2019 at 7:47 PM Michael Wall  wrote:
> >
> > > +1 binding
> > >
> > > Verified
> > > - Release files in correct location
> > > - Release files have the word incubating in their name
> > > - Digital signature and hashes correct
> > > - DISCLAIMER file exist
> > > - LICENSE and NOTICE files exists
> > > - LICENSE and NOTICE text correct
> > > - Un-included software dependencies are not mentioned in LICENSE or
> NOTICE
> > > - License information is not mentioned in NOTICE
> > > - All source files have ASF headers
> > > - Contents of the release match with what's tagged in version control
> > > - No unexpected binary files in the release
> > >
> > > Non verified
> > > - NOTICE year not correct, unfortunate it was updated when the release
> was
> > > cut again
> > > Is there any 3rd party code contained inside the release? If so:
> > > - Was not able to compile.  Stopped after 10 min, is
> > >
> > >
> https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html
> > > right place to look?  Instructions could be clearer
> > >
> > > Good work fixing the licensing.
> > >
> > > Mike
> > >
> > > On Tue, Feb 26, 2019 at 9:34 PM Justin Mclean <
> jus...@classsoftware.com>
> > > wrote:
> > >
> > > > HI,.
> > > >
> > > > +1 (binding)
> > > >
> > > > I didn’t have time to check all of the licenses so there may be some
> work
> > > > that’s still needed there, but it looks fairly comprehensive.
> > > >
> > > > I checked:
> > > > - incubating in name
> > > > - DISCLAIMER exists
> > > > - LICENSE looks OK
> > > > - NOTICE need year updating
> > > > - No unexpected binary files
> > > > - All ASF files have ASF headers
> > > > - I didn’t compile from source and assume others have
> > > >
> > > > Thanks,
> > > > Justin
> > > > -
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > >
> > >
> >

Re: [CANCELLED][VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

[Hagay Lupesko]

Based on Justin's feedback, can we resume the vote instead of cancelling it?

On Mon, Feb 11, 2019 at 12:02 AM Justin Mclean 
wrote:

> Hi,
>
> In future don’t be so hasty to cancel a release vote, people mind can be
> changed and a -1 is not a veto on a release.
>
> Thanks,
> Justin
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

[Hagay Lupesko]

Thanks Zach for jumping on this!

Justin - Zach's follow up is in this PR into 1.4 branch [1
], which includes all
changes (another PR was already merged to master)
Once you confirm changes look good, Steffen can restart the vote process.

Cheers,
Hagay

[1] - https://github.com/apache/incubator-mxnet/pull/13856


On Fri, Jan 11, 2019 at 3:42 PM Zach Kimberg 
wrote:

> Hi Justin,
>
> We will replace the file CC-BY-SA documentation file with a pointer then.
> Because it is a submodule, we can't change it in the code and will just
> replace it as part of our release process.
>
> Per you suggestion, I also added copyright owners to the license file in
> addition to fixing the various problems. Hopefully that makes it easier to
> review. I think our license should be correct now. Can you help take a look
> at our master branch (
> https://github.com/apache/incubator-mxnet/blob/master/LICENSE) to see if
> there are any problems that I have missed before we continue with our 1.4
> release?
>
> Thanks,
> Zach
>
> On Thu, Jan 10, 2019 at 1:27 AM Justin Mclean 
> wrote:
>
> > Hi,
> >
> > > Hi Justin, it would be great if we can clarify the policy the submodule
> > dependencies.
> >
> > Basically follow the guiding principle [1] what states anything that is
> > bundled in a release need to be mentioned in LICENSE. If it not in the
> > release then it doesn’t need to be included.
> >
> > Thanks,
> > Justin
> >
> > 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

[Hagay Lupesko]

Thanks for clarifying Justin.

On Mon, Jan 7, 2019 at 1:06 AM Justin Mclean 
wrote:

> Hi,
>
> > Good call. I will work with my colleagues in Amazon to try and help with
> > this.
>
> Great if you need any help just ask.
>
> > I'm not sure what is the best approach with 3P code issues though: you
> call
> > out 3rdparty/onnx-tensorrt as having a mix of license types and having
> > other issues. However, this is part of another repo, integrated into
> MXNet
> > as a git submodule (https://github.com/onnx/onnx-tensorrt.git).
> > Is it necessary to "fix" licensing of 3P packages as well? I think this
> > will be very difficult…
>
> Fixing downstream is good but not required, it all comes down to the
> guiding principle [1].  You need to look inside and 3rd party code to see
> what it contains and list all licenses that are bundled.
>
> A simple example is jQuery which is MIT licensed but includes MIT licensed
> Sizzle so both of these need to mention in the LICENSE file.
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

[Hagay Lupesko]

Justin,

Good call. I will work with my colleagues in Amazon to try and help with
this.

I'm not sure what is the best approach with 3P code issues though: you call
out 3rdparty/onnx-tensorrt as having a mix of license types and having
other issues. However, this is part of another repo, integrated into MXNet
as a git submodule (https://github.com/onnx/onnx-tensorrt.git).
Is it necessary to "fix" licensing of 3P packages as well? I think this
will be very difficult...

Curious to get your thoughts and perspective.

Hagay


On Sat, Jan 5, 2019 at 5:50 PM Justin Mclean 
wrote:

> Hi,
>
> I’m still -1 (binding) there are also some LICENSE issues that need to be
> looked into.
>
> I checked:
> - incubating in name
> - signature and hashes good
> - DISCLAIMER exists
> - LICENSE and NOTICE need some work (see below)
> - No unexpected binary files
> - A number of files are missing headers and it’s unclear how some of these
> are licensed
> - I didn’t try to compile
>
> These LICENSE files mentioned in LICENSE do not exist:
> - 3rdparty/tvm/dmlc-core/LICENSE
> - 3rdparty/tvm/nnvm/LICENSE
> - R-package/LICENSE
> - nnvm/tvm/HalideIR/LICENSE
>
> LICENSE is missing mention of:
> - ./docs/_static/js/clipboard.min.js (MIT licensed © Zeno Rocha) You may
> also want to include the non-minified code as that could be considered to
> being “compiled" code and could be thought of as category X.
> - ./julia
> - ./perl-package ? (unclear if this was developed at the ASF or not)
> - 3rdparty/openmp/LICENSE.txt
> -
> /apache-mxnet-src-1.4.0.rc0-incubating/3rdparty/mkldnn/src/cpu/xbyak/xbyak.h
> and other .h files in that directory - note the double headers
> - apache-mxnet-src-1.4.0.rc0-incubating/3rdparty/cub/test/mersenne.h
>
> And probably other files. It’s very hard to review when the copyright
> owners are not clearly indicated in LICENSE. It would help if all license
> file were placed in one directory, that way it would be easy to search if
> all required licenses have been included.
>
> I think a lot more work is needed on the LICENSE here for instance taking
> a look at one directory:
> 3rdparty/onnx-tensorrt
>
> With the LICENSE file containing:
> MIT License
> Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> Copyright (c) 2018 Open Neural Network Exchange
>
> However searching for license and copyright under that you can see it
> contains a mix of different licensed files, including MIT, BSD, Apache and
> at least 30 different copyright statements. I can see some of the
> sub-directory are also referenced but it doesn’t seem complete to me.
>
> There are lots of other files missing headers, in some cases it could be
> assumed that they are 3rd party files, but in some cases it is unclear. For
> instance:
>
> File in ./docs/_static/js/*.,js are missing headers. How are theses
> licensed?
>
> This files are missing headers - how are they licensed?
>   ./src/operator/special_functions-inl.h
>   ./src/operator/contrib/nn/deformable_im2col.cuh
>   ./src/operator/contrib/nn/deformable_im2col.h
>   ./src/operator/nn/im2col.cuh
>   ./src/operator/nn/im2col.h
>   ./src/operator/nn/pool.h
>
> It might help you if you used a tool like https://www.fossology.org to
> track everything a you have a large number of 3rd party licensed software
> from a large number of authors.
>
> Thanks,
> Justin
>
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.3.1.rc0

[Hagay Lupesko]

Great!
Thanks for the time people spent on testing and voting!

On Tue, Nov 27, 2018, 05:59 Anton Chernov  The vote has been closed and I'm happy to announce the results.
>
> This vote passes with 6 +1 votes (3 binding) and no 0 or -1 votes.
>
> +1 votes
>
> * Willem / binding
> * Jim / binding
> * Jason / binding
> * Kellen
> * Mohammad
> * Atri
>
> 0 votes
> * No votes
>
> -1 votes
> * No votes
>
> Thanks everyone for spending time on testing and voting.
>
> Best
> Anton
>
> вт, 27 нояб. 2018 г. в 08:00, Jason Dai :
>
> > +1 (binding)
> >
> > I checked:
> > - incubating in name
> > - DISCLAIMER exists
> > - LICENSE / NOTICE files look good
> > - Signatures and checksum good
> >
> > Thanks,
> > -Jason
> >
> >
> > On Mon, Nov 26, 2018 at 10:37 PM Jim Jagielski  wrote:
> >
> > > +1 (binding)
> > >
> > > > On Nov 21, 2018, at 9:30 AM, Anton Chernov 
> > wrote:
> > > >
> > > > Dear community,
> > > >
> > > > This is a call for a releasing Apache MXNet (incubating) 1.3.1,
> release
> > > > candidate 0.
> > > >
> > > > Apache MXNet (incubating) community has voted and approved the
> release.
> > > >
> > > > Vote thread:
> > > >
> > >
> >
> https://lists.apache.org/thread.html/32ab13b6d2d80fd75dbc2ec62151d12d09f6e0ca89799ae0aa26894b@%3Cdev.mxnet.apache.org%3E
> > > >
> > > > Result thread:
> > > >
> > >
> >
> https://lists.apache.org/thread.html/4b6559e75a1027a99fada99faa3161eac6604af9e786da457e051bc7@%3Cdev.mxnet.apache.org%3E
> > > >
> > > > The source tarball, including signatures, digests, etc. can be found
> > at:
> > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.3.1.rc0/
> > > >
> > > > The tag to be voted upon is 1.3.1.rc0:
> > > > https://github.com/apache/incubator-mxnet/releases/tag/1.3.1.rc0
> > > >
> > > > The release hash is c1327f3:
> > > >
> > >
> >
> https://github.com/apache/incubator-mxnet/commit/c1327f317a7f371a9803a3f27be6ff90dc6af707
> > > >
> > > > KEYS file available:
> > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> > > >
> > > > For information about the contents of this release, see:
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.3.1+Release+Notes
> > > >
> > > > The vote will be open for 72 hours.
> > > >
> > > > [ ] +1 release this package as 1.3.1
> > > > [ ] +0 no opinion
> > > > [ ] -1 do not release this package because...
> > > >
> > > > Best regards,
> > > > Anton Chernov
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.3.1.rc0

[Hagay Lupesko]

Thanks for the update Anton, and Happy Thanksgiving to everyone!

On Fri, Nov 23, 2018, 09:03 Anton Chernov  Due to not enough votes (and thanksgiving, probably) the vote is extended
> till Tuesday, the 27th of November 2018 14:30 CET.
>
> Best regards,
> Anton
>
> чт, 22 нояб. 2018 г. в 15:02, Anton Chernov :
>
> > Dear mentors,
> >
> > Jason Dai
> > Jim Jagielski
> > Bob Paulin
> > Sebastian Schelter
> > Michael Wall
> > Markus Weimer
> > Henri Yandell
> >
> > We, the MXNet community, would really appreciate your vote.
> >
> > Thank you.
> >
> > Best
> > Anton
> >
> >
> > ср, 21 нояб. 2018 г. в 23:31, kellen sunderland <
> > kellen.sunderl...@gmail.com>:
> >
> >> As in the prior vote thread I'm +1.  I tested the following on MacOS
> >> 10.13,
> >> High Sierra:
> >>
> >> INCUBATING IN RELEASE FILE: check.
> >> LICENSE check.
> >> NOTICE check.
> >> SIGNATURE check.
> >> HASH check.
> >> DISCLAIMER check.
> >> SOURCE COMPILES VIA MAKEFILE check.
> >> SOURCE COMPILES VIA CMAKE check.
> >> TESTS check.
> >>
> >> -Kellen
> >>
> >> On Wed, Nov 21, 2018 at 6:30 AM Anton Chernov 
> >> wrote:
> >>
> >> > Dear community,
> >> >
> >> > This is a call for a releasing Apache MXNet (incubating) 1.3.1,
> release
> >> > candidate 0.
> >> >
> >> > Apache MXNet (incubating) community has voted and approved the
> release.
> >> >
> >> > Vote thread:
> >> >
> >> >
> >>
> https://lists.apache.org/thread.html/32ab13b6d2d80fd75dbc2ec62151d12d09f6e0ca89799ae0aa26894b@%3Cdev.mxnet.apache.org%3E
> >> >
> >> > Result thread:
> >> >
> >> >
> >>
> https://lists.apache.org/thread.html/4b6559e75a1027a99fada99faa3161eac6604af9e786da457e051bc7@%3Cdev.mxnet.apache.org%3E
> >> >
> >> > The source tarball, including signatures, digests, etc. can be found
> at:
> >> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.3.1.rc0/
> >> >
> >> > The tag to be voted upon is 1.3.1.rc0:
> >> > https://github.com/apache/incubator-mxnet/releases/tag/1.3.1.rc0
> >> >
> >> > The release hash is c1327f3:
> >> >
> >> >
> >>
> https://github.com/apache/incubator-mxnet/commit/c1327f317a7f371a9803a3f27be6ff90dc6af707
> >> >
> >> > KEYS file available:
> >> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> >> >
> >> > For information about the contents of this release, see:
> >> >
> >> >
> >>
> https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.3.1+Release+Notes
> >> >
> >> > The vote will be open for 72 hours.
> >> >
> >> > [ ] +1 release this package as 1.3.1
> >> > [ ] +0 no opinion
> >> > [ ] -1 do not release this package because...
> >> >
> >> > Best regards,
> >> > Anton Chernov
> >> >
> >>
> >
>

Request for write access to wiki

[Hagay Lupesko]

Kindly provide write access to wiki, I'd like to help updating Apache MXNet
incubator report
Name: HagayLupesko

Thanks!

Re: Auto-cleaning up Stale PRs

[Hagay Lupesko]

Im also interested in this PR policy automation.

For Apache MXNet, there is no automation that I am aware of that handles
that. And it can be super helpful in handling stale PRs...

Hagay

On Tue, Sep 11, 2018, 12:07 Sid Anand  wrote:

> Hi Folks!
> I wanted a policy-driven approach to automatically label, comment, and
> close inactive/stale PRs. Probot does this, but need some write perms to
> GitHub.
>
> https://github.com/probot/stale
>
> I just learned this is not possible per
> https://issues.apache.org/jira/browse/INFRA-17005
>
> How are other projects solving this problem? And why is probot not on say
> an approved list of GitHub integrations?
>
> -s
>