Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[li gang]

@Twice
Hi,the link [1] introduce the treatment of third-party works.
1.https://www.apache.org/legal/src-headers.html#3party


Twice  于2023年2月13日周一 16:52写道：

> Hi @kezhenxu94,
>
> Thank you for taking the time to vote and for your valuable input.
>
> However, I would like to point out that
> - You can see the changes we have made to these files in the commit log,
>   and I have included some links [1-2] for your convenience.
> - I cannot find an official description of the inclusion of the ASF header
> to the modified third-party code: i.e.
>   how many changes can be described as not being "mostly the same"? Is
> there a quantifiable standard for this?
>
> [1]
>
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
> [2]
>
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
>
> Best,
> Twice
>
>
> On Mon, Feb 13, 2023 at 4:07 PM kezhenxu94  wrote:
>
> > Hi sorry -1 (binding) due to license issue, the following files [1] have
> > ASF license headers along with the original license header,
> > I saw you mentioned it's a conversion from C to C++ from Redis project,
> > but from my comparison they look to
> > be mostly the same so you might want to remove the ASF license header
> from
> > those files.
> >
> > Other files [2] might be controversial whether we should have dual
> license
> > headers, but I won't vote -1 on those files if [1] are resolved.
> >
> > [1]  - apache/incubator-kvrocks/src/types/geohash.cc  >
> >  - apache/incubator-kvrocks/src/common/sha1.cc 
> >
> > [2] - src/common/rand.cc src/common/rand.h
> > - src/storage/scripting.*
> >
> > > On Feb 11, 2023, at 22:43, Myth  wrote:
> > >
> > > Hello Incubator PMC,
> > >
> > > The Apache Kvrocks community has voted and approved the release of
> Apache
> > > Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members
> review
> > > and vote for this release.
> > >
> > > This is  the second call for a vote. The first call for a vote, which
> is
> > > cancelled:
> > > *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> > > *
> > >
> > > Kvrocks is a distributed key value NoSQL database that uses RocksDB as
> > the
> > > storage engine and is compatible with Redis protocol. The current
> release
> > > provides many new features, many improvements and fixes many bugs.
> > >
> > > Kvrocks community vote thread:
> > > https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> > >
> > > Vote result thread:
> > > https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> > >
> > > The release candidate:
> > > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> > >
> > > This release has been signed with a PGP available here:
> > > https://downloads.apache.org/incubator/kvrocks/KEYS
> > >
> > > Git tag for the release:
> > > https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> > >
> > > Docker image:
> > >
> >
> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> > >
> > > Build guide can be found at:
> > > https://github.com/apache/incubator-kvrocks#build
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> number
> > > of votes is reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> > > [ ] +0
> > > [ ] -1 Do not approve (please specify the reason)
> > >
> > > Thanks
> >
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>


-- 


--
Best Regards

DolphinScheduler PMC
Gang Li 李岗

lgcar...@apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Sheng Wu]

Hi Tison

AFAIK, this is not a failed vote. You are still have more +1 than -1.
You could consider whether waiting for another round, or any voted IPMC
member would change votes.

-1 is veto.

tison 于2023年2月14日 周二20:32写道：

> Hi Justin,
>
> Thanks for your information! I made this patch
> https://github.com/apache/incubator-kvrocks/pull/1259 to resolve the
> license issue. Since we're going to make a new RC with only this change,
> could you take a look at the patch whether there still remains some
> concerns? Then we can avoid another round of failed vote.
>
> Best,
> tison.
>
> Justin Mclean 于2023年2月14日 周二15:59写道：
>
> > Hi,
> >
> > > It can be a case of The Ship of Theseus. When you take a look at the
> > issued
> > > files[1][2], you may find a commit history touching them and modifying
> > > them. Anyway, it's not an identical copy or one-shot translation.
> >
> > This has been discussed many times on various lists, translating an
> > algorithm from one language to another does not change its license.
> >
> > > And we keep the origin comments.
> >
> > Which is also an IP issue.
> >
> > Kinds Regards,
> > Justin
> >
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> > --
> Best,
> tison.
>
-- 
Sheng Wu 吴晟

Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[tison]

Hi Justin,

Thanks for your information! I made this patch
https://github.com/apache/incubator-kvrocks/pull/1259 to resolve the
license issue. Since we're going to make a new RC with only this change,
could you take a look at the patch whether there still remains some
concerns? Then we can avoid another round of failed vote.

Best,
tison.

Justin Mclean 于2023年2月14日 周二15:59写道：

> Hi,
>
> > It can be a case of The Ship of Theseus. When you take a look at the
> issued
> > files[1][2], you may find a commit history touching them and modifying
> > them. Anyway, it's not an identical copy or one-shot translation.
>
> This has been discussed many times on various lists, translating an
> algorithm from one language to another does not change its license.
>
> > And we keep the origin comments.
>
> Which is also an IP issue.
>
> Kinds Regards,
> Justin
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
> --
Best,
tison.

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Justin Mclean]

Hi,

> It can be a case of The Ship of Theseus. When you take a look at the issued
> files[1][2], you may find a commit history touching them and modifying
> them. Anyway, it's not an identical copy or one-shot translation.

This has been discussed many times on various lists, translating an algorithm 
from one language to another does not change its license.

> And we keep the origin comments.

Which is also an IP issue.

Kinds Regards,
Justin


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

[CANCEL][VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Pengbo Cai]

Hello Incubator PMC,

I'm cancelling this vote due to license issues:
https://lists.apache.org/thread/q11wxgg3hdw694w5csf43trgv7yvj2jt

I will start a new vote after we have resolved those issues.

Best,
Pengbo Cai

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Pengbo Cai]

Due to doubts, I will cancel this release vote. I will start a new vote after 
we have resolved @kezhenxu94's issue.

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[tison]

I submit a patch: https://github.com/apache/incubator-kvrocks/pull/1259

@zhenxu you're welcome to help verify if it fixes your concerns.

... and -1 (binding)

@Myth I think we need a new release candidate :)

Best,
tison.


tison  于2023年2月14日周二 10:47写道：

> Thanks for your confirmation. Then I agree the content should be updated
> to avoid risk.
>
> kezhenxu94 于2023年2月14日 周二10:43写道：
>
>> But at the same time, the file header has `/* from valgrind tests */`,
>> I assumed you ported the variation of Valgrind.
>>
>> A good practice is not to add more license information than you
>> actually do, i.e., don't declare it's from valgrind tests if you
>> believe you are using the original Public Domain sha1.c file,
>> confusions arise like this.
>>
>> > On Feb 14, 2023, at 10:22, tison  wrote:
>> >
>> > Hi zhenxu,
>> >
>> > When you look at the header, it writes:
>> >
>> > SHA-1 in C
>> > By Steve Reid 
>> > 100% Public Domain
>> >
>> > Zhenxu Ke 于2023年2月14日 周二10:00写道：
>> >
>> >> Hi, sorry the mailer-dae...@apache.org just says it can't deliver my
>> >> email, which should be sent out last night (2023/02/13 22:49), here is
>> my
>> >> reply:
>> >>
>> >> Hi, now I would continue to vote -1 and I believe this should be fixed
>> >> ASAP, because you might copy the file[1] from Redis, but the file is
>> not
>> >> originated from Redis either, it’s copied from yet another project
>> >> valgrind[2], which is GPL licensed[3].
>> >>
>> >> [1] incubator-kvrocks/src/common/sha1.cc
>> >> [2]
>> https://github.com/danos/valgrind/blob/master/none/tests/sha1_test.c
>> >> [3] https://github.com/danos/valgrind/blob/master/COPYING
>> >>
>> >> On 2023/02/14 00:43:19 tison wrote:
>> >>> Hi Justin,
>> >>>
>> >>> It can be a case of The Ship of Theseus. When you take a look at the
>> >> issued
>> >>> files[1][2], you may find a commit history touching them and modifying
>> >>> them. Anyway, it's not an identical copy or one-shot translation. And
>> we
>> >>> keep the origin comments.
>> >>>
>> >>> Even a one-shot translation, if it's done by humans, generally
>> >> modification
>> >>> will be applied.
>> >>>
>> >>> But if you insist on "keep the original license header and don't add
>> the
>> >>> ASF header" with an existing documented guideline, the Kvrocks
>> >> contributors
>> >>> would be glad to change it.
>> >>>
>> >>> Best,
>> >>> tison.
>> >>>
>> >>> [1]
>> >>>
>> >>
>> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
>> >>> [2]
>> >>>
>> >>
>> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
>> >>>
>> >>>
>> >>> Justin Mclean  于2023年2月14日周二 05:39写道：
>> >>>
>>  Hi,
>> 
>>  In general porting a file from one language to another would not
>> change
>>  the original license.
>> 
>>  Kind Regards,
>>  Justin
>>  -
>>  To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>  For additional commands, e-mail: general-h...@incubator.apache.org
>> 
>> 
>> >>>
>> >>
>> >> -
>> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> >> For additional commands, e-mail: general-h...@incubator.apache.org
>> >>
>> >> --
>> > Best,
>> > tison.
>>
>>
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>> --
> Best,
> tison.
>

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[tison]

Thanks for your confirmation. Then I agree the content should be updated to
avoid risk.

kezhenxu94 于2023年2月14日 周二10:43写道：

> But at the same time, the file header has `/* from valgrind tests */`,
> I assumed you ported the variation of Valgrind.
>
> A good practice is not to add more license information than you
> actually do, i.e., don't declare it's from valgrind tests if you
> believe you are using the original Public Domain sha1.c file,
> confusions arise like this.
>
> > On Feb 14, 2023, at 10:22, tison  wrote:
> >
> > Hi zhenxu,
> >
> > When you look at the header, it writes:
> >
> > SHA-1 in C
> > By Steve Reid 
> > 100% Public Domain
> >
> > Zhenxu Ke 于2023年2月14日 周二10:00写道：
> >
> >> Hi, sorry the mailer-dae...@apache.org just says it can't deliver my
> >> email, which should be sent out last night (2023/02/13 22:49), here is
> my
> >> reply:
> >>
> >> Hi, now I would continue to vote -1 and I believe this should be fixed
> >> ASAP, because you might copy the file[1] from Redis, but the file is not
> >> originated from Redis either, it’s copied from yet another project
> >> valgrind[2], which is GPL licensed[3].
> >>
> >> [1] incubator-kvrocks/src/common/sha1.cc
> >> [2]
> https://github.com/danos/valgrind/blob/master/none/tests/sha1_test.c
> >> [3] https://github.com/danos/valgrind/blob/master/COPYING
> >>
> >> On 2023/02/14 00:43:19 tison wrote:
> >>> Hi Justin,
> >>>
> >>> It can be a case of The Ship of Theseus. When you take a look at the
> >> issued
> >>> files[1][2], you may find a commit history touching them and modifying
> >>> them. Anyway, it's not an identical copy or one-shot translation. And
> we
> >>> keep the origin comments.
> >>>
> >>> Even a one-shot translation, if it's done by humans, generally
> >> modification
> >>> will be applied.
> >>>
> >>> But if you insist on "keep the original license header and don't add
> the
> >>> ASF header" with an existing documented guideline, the Kvrocks
> >> contributors
> >>> would be glad to change it.
> >>>
> >>> Best,
> >>> tison.
> >>>
> >>> [1]
> >>>
> >>
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
> >>> [2]
> >>>
> >>
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
> >>>
> >>>
> >>> Justin Mclean  于2023年2月14日周二 05:39写道：
> >>>
>  Hi,
> 
>  In general porting a file from one language to another would not
> change
>  the original license.
> 
>  Kind Regards,
>  Justin
>  -
>  To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>  For additional commands, e-mail: general-h...@incubator.apache.org
> 
> 
> >>>
> >>
> >> -
> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >> For additional commands, e-mail: general-h...@incubator.apache.org
> >>
> >> --
> > Best,
> > tison.
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
> --
Best,
tison.

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[kezhenxu94]

But at the same time, the file header has `/* from valgrind tests */`,
I assumed you ported the variation of Valgrind.

A good practice is not to add more license information than you
actually do, i.e., don't declare it's from valgrind tests if you
believe you are using the original Public Domain sha1.c file,
confusions arise like this.

> On Feb 14, 2023, at 10:22, tison  wrote:
> 
> Hi zhenxu,
> 
> When you look at the header, it writes:
> 
> SHA-1 in C
> By Steve Reid 
> 100% Public Domain
> 
> Zhenxu Ke 于2023年2月14日 周二10:00写道：
> 
>> Hi, sorry the mailer-dae...@apache.org just says it can't deliver my
>> email, which should be sent out last night (2023/02/13 22:49), here is my
>> reply:
>> 
>> Hi, now I would continue to vote -1 and I believe this should be fixed
>> ASAP, because you might copy the file[1] from Redis, but the file is not
>> originated from Redis either, it’s copied from yet another project
>> valgrind[2], which is GPL licensed[3].
>> 
>> [1] incubator-kvrocks/src/common/sha1.cc
>> [2] https://github.com/danos/valgrind/blob/master/none/tests/sha1_test.c
>> [3] https://github.com/danos/valgrind/blob/master/COPYING
>> 
>> On 2023/02/14 00:43:19 tison wrote:
>>> Hi Justin,
>>> 
>>> It can be a case of The Ship of Theseus. When you take a look at the
>> issued
>>> files[1][2], you may find a commit history touching them and modifying
>>> them. Anyway, it's not an identical copy or one-shot translation. And we
>>> keep the origin comments.
>>> 
>>> Even a one-shot translation, if it's done by humans, generally
>> modification
>>> will be applied.
>>> 
>>> But if you insist on "keep the original license header and don't add the
>>> ASF header" with an existing documented guideline, the Kvrocks
>> contributors
>>> would be glad to change it.
>>> 
>>> Best,
>>> tison.
>>> 
>>> [1]
>>> 
>> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
>>> [2]
>>> 
>> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
>>> 
>>> 
>>> Justin Mclean  于2023年2月14日周二 05:39写道：
>>> 
 Hi,
 
 In general porting a file from one language to another would not change
 the original license.
 
 Kind Regards,
 Justin
 -
 To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
 For additional commands, e-mail: general-h...@incubator.apache.org
 
 
>>> 
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>> 
>> --
> Best,
> tison.


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[tison]

Hi zhenxu,

When you look at the header, it writes:

SHA-1 in C
By Steve Reid 
100% Public Domain

Zhenxu Ke 于2023年2月14日 周二10:00写道：

> Hi, sorry the mailer-dae...@apache.org just says it can't deliver my
> email, which should be sent out last night (2023/02/13 22:49), here is my
> reply:
>
> Hi, now I would continue to vote -1 and I believe this should be fixed
> ASAP, because you might copy the file[1] from Redis, but the file is not
> originated from Redis either, it’s copied from yet another project
> valgrind[2], which is GPL licensed[3].
>
> [1] incubator-kvrocks/src/common/sha1.cc
> [2] https://github.com/danos/valgrind/blob/master/none/tests/sha1_test.c
> [3] https://github.com/danos/valgrind/blob/master/COPYING
>
> On 2023/02/14 00:43:19 tison wrote:
> > Hi Justin,
> >
> > It can be a case of The Ship of Theseus. When you take a look at the
> issued
> > files[1][2], you may find a commit history touching them and modifying
> > them. Anyway, it's not an identical copy or one-shot translation. And we
> > keep the origin comments.
> >
> > Even a one-shot translation, if it's done by humans, generally
> modification
> > will be applied.
> >
> > But if you insist on "keep the original license header and don't add the
> > ASF header" with an existing documented guideline, the Kvrocks
> contributors
> > would be glad to change it.
> >
> > Best,
> > tison.
> >
> > [1]
> >
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
> > [2]
> >
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
> >
> >
> > Justin Mclean  于2023年2月14日周二 05:39写道：
> >
> > > Hi,
> > >
> > > In general porting a file from one language to another would not change
> > > the original license.
> > >
> > > Kind Regards,
> > > Justin
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
> --
Best,
tison.

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Zhenxu Ke]

Hi, sorry the mailer-dae...@apache.org just says it can't deliver my email, 
which should be sent out last night (2023/02/13 22:49), here is my reply:

Hi, now I would continue to vote -1 and I believe this should be fixed ASAP, 
because you might copy the file[1] from Redis, but the file is not originated 
from Redis either, it’s copied from yet another project valgrind[2], which is 
GPL licensed[3]. 

[1] incubator-kvrocks/src/common/sha1.cc
[2] https://github.com/danos/valgrind/blob/master/none/tests/sha1_test.c
[3] https://github.com/danos/valgrind/blob/master/COPYING

On 2023/02/14 00:43:19 tison wrote:
> Hi Justin,
> 
> It can be a case of The Ship of Theseus. When you take a look at the issued
> files[1][2], you may find a commit history touching them and modifying
> them. Anyway, it's not an identical copy or one-shot translation. And we
> keep the origin comments.
> 
> Even a one-shot translation, if it's done by humans, generally modification
> will be applied.
> 
> But if you insist on "keep the original license header and don't add the
> ASF header" with an existing documented guideline, the Kvrocks contributors
> would be glad to change it.
> 
> Best,
> tison.
> 
> [1]
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
> [2]
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
> 
> 
> Justin Mclean  于2023年2月14日周二 05:39写道：
> 
> > Hi,
> >
> > In general porting a file from one language to another would not change
> > the original license.
> >
> > Kind Regards,
> > Justin
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[tison]

Hi Justin,

It can be a case of The Ship of Theseus. When you take a look at the issued
files[1][2], you may find a commit history touching them and modifying
them. Anyway, it's not an identical copy or one-shot translation. And we
keep the origin comments.

Even a one-shot translation, if it's done by humans, generally modification
will be applied.

But if you insist on "keep the original license header and don't add the
ASF header" with an existing documented guideline, the Kvrocks contributors
would be glad to change it.

Best,
tison.

[1]
https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
[2]
https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc


Justin Mclean  于2023年2月14日周二 05:39写道：

> Hi,
>
> In general porting a file from one language to another would not change
> the original license.
>
> Kind Regards,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Justin Mclean]

Hi,

In general porting a file from one language to another would not change the 
original license.

Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[tison]

> you believe the original authors agree that the modifications
> are significant and can be relicensed, then I'm totally OK
> to add ASF license headers there

Hi zhenxu,

This is the case for Kvrocks. Kvrocks contributors port the file to cpp and
the original license is BSD 3-Clause which allows the recipient to
relicense.

Best,
tison.


kezhenxu94  于2023年2月13日周一 17:15写道：

> Hi,
>
> When it comes to human feelings there is no quantifiable standard,
> if the original authors granted you to relicense the file, or,
> you believe the original authors agree that the modifications
> are significant and can be relicensed, then I'm totally OK
> to add ASF license headers there.
>
> If that's neither the case, I'd be conservative to keep the original
> license header.
>
> I also remember there was a discussion already in this mailing list,
> but can't recall the link at the moment, anyone else can find
> and share would be appreciated.
>
> > On Feb 13, 2023, at 16:51, Twice  wrote:
> >
> > Hi @kezhenxu94,
> >
> > Thank you for taking the time to vote and for your valuable input.
> >
> > However, I would like to point out that
> > - You can see the changes we have made to these files in the commit log,
> >  and I have included some links [1-2] for your convenience.
> > - I cannot find an official description of the inclusion of the ASF
> header
> > to the modified third-party code: i.e.
> >  how many changes can be described as not being "mostly the same"? Is
> > there a quantifiable standard for this?
> >
> > [1]
> >
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
> > [2]
> >
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
> >
> > Best,
> > Twice
> >
> >
> > On Mon, Feb 13, 2023 at 4:07 PM kezhenxu94 
> wrote:
> >
> >> Hi sorry -1 (binding) due to license issue, the following files [1] have
> >> ASF license headers along with the original license header,
> >> I saw you mentioned it's a conversion from C to C++ from Redis project,
> >> but from my comparison they look to
> >> be mostly the same so you might want to remove the ASF license header
> from
> >> those files.
> >>
> >> Other files [2] might be controversial whether we should have dual
> license
> >> headers, but I won't vote -1 on those files if [1] are resolved.
> >>
> >> [1]  - apache/incubator-kvrocks/src/types/geohash.cc <
> http://geohash.cc/>
> >> - apache/incubator-kvrocks/src/common/sha1.cc 
> >>
> >> [2] - src/common/rand.cc src/common/rand.h
> >>- src/storage/scripting.*
> >>
> >>> On Feb 11, 2023, at 22:43, Myth  wrote:
> >>>
> >>> Hello Incubator PMC,
> >>>
> >>> The Apache Kvrocks community has voted and approved the release of
> Apache
> >>> Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members
> review
> >>> and vote for this release.
> >>>
> >>> This is  the second call for a vote. The first call for a vote, which
> is
> >>> cancelled:
> >>> *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> >>> *
> >>>
> >>> Kvrocks is a distributed key value NoSQL database that uses RocksDB as
> >> the
> >>> storage engine and is compatible with Redis protocol. The current
> release
> >>> provides many new features, many improvements and fixes many bugs.
> >>>
> >>> Kvrocks community vote thread:
> >>> https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> >>>
> >>> Vote result thread:
> >>> https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> >>>
> >>> The release candidate:
> >>> https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> >>>
> >>> This release has been signed with a PGP available here:
> >>> https://downloads.apache.org/incubator/kvrocks/KEYS
> >>>
> >>> Git tag for the release:
> >>> https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> >>>
> >>> Docker image:
> >>>
> >>
> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> >>>
> >>> Build guide can be found at:
> >>> https://github.com/apache/incubator-kvrocks#build
> >>>
> >>> The vote will be open for at least 72 hours or until the necessary
> number
> >>> of votes is reached.
> >>>
> >>> Please vote accordingly:
> >>> [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> >>> [ ] +0
> >>> [ ] -1 Do not approve (please specify the reason)
> >>>
> >>> Thanks
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >> For additional commands, e-mail: general-h...@incubator.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[kezhenxu94]

Hi, 

When it comes to human feelings there is no quantifiable standard,
if the original authors granted you to relicense the file, or,
you believe the original authors agree that the modifications
are significant and can be relicensed, then I'm totally OK
to add ASF license headers there.

If that's neither the case, I'd be conservative to keep the original
license header.

I also remember there was a discussion already in this mailing list,
but can't recall the link at the moment, anyone else can find
and share would be appreciated.

> On Feb 13, 2023, at 16:51, Twice  wrote:
> 
> Hi @kezhenxu94,
> 
> Thank you for taking the time to vote and for your valuable input.
> 
> However, I would like to point out that
> - You can see the changes we have made to these files in the commit log,
>  and I have included some links [1-2] for your convenience.
> - I cannot find an official description of the inclusion of the ASF header
> to the modified third-party code: i.e.
>  how many changes can be described as not being "mostly the same"? Is
> there a quantifiable standard for this?
> 
> [1]
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
> [2]
> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc
> 
> Best,
> Twice
> 
> 
> On Mon, Feb 13, 2023 at 4:07 PM kezhenxu94  wrote:
> 
>> Hi sorry -1 (binding) due to license issue, the following files [1] have
>> ASF license headers along with the original license header,
>> I saw you mentioned it's a conversion from C to C++ from Redis project,
>> but from my comparison they look to
>> be mostly the same so you might want to remove the ASF license header from
>> those files.
>> 
>> Other files [2] might be controversial whether we should have dual license
>> headers, but I won't vote -1 on those files if [1] are resolved.
>> 
>> [1]  - apache/incubator-kvrocks/src/types/geohash.cc 
>> - apache/incubator-kvrocks/src/common/sha1.cc 
>> 
>> [2] - src/common/rand.cc src/common/rand.h
>>- src/storage/scripting.*
>> 
>>> On Feb 11, 2023, at 22:43, Myth  wrote:
>>> 
>>> Hello Incubator PMC,
>>> 
>>> The Apache Kvrocks community has voted and approved the release of Apache
>>> Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review
>>> and vote for this release.
>>> 
>>> This is  the second call for a vote. The first call for a vote, which is
>>> cancelled:
>>> *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
>>> *
>>> 
>>> Kvrocks is a distributed key value NoSQL database that uses RocksDB as
>> the
>>> storage engine and is compatible with Redis protocol. The current release
>>> provides many new features, many improvements and fixes many bugs.
>>> 
>>> Kvrocks community vote thread:
>>> https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
>>> 
>>> Vote result thread:
>>> https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
>>> 
>>> The release candidate:
>>> https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
>>> 
>>> This release has been signed with a PGP available here:
>>> https://downloads.apache.org/incubator/kvrocks/KEYS
>>> 
>>> Git tag for the release:
>>> https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
>>> 
>>> Docker image:
>>> 
>> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
>>> 
>>> Build guide can be found at:
>>> https://github.com/apache/incubator-kvrocks#build
>>> 
>>> The vote will be open for at least 72 hours or until the necessary number
>>> of votes is reached.
>>> 
>>> Please vote accordingly:
>>> [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
>>> [ ] +0
>>> [ ] -1 Do not approve (please specify the reason)
>>> 
>>> Thanks
>> 
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>> 
>> 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Twice]

Hi @kezhenxu94,

Thank you for taking the time to vote and for your valuable input.

However, I would like to point out that
- You can see the changes we have made to these files in the commit log,
  and I have included some links [1-2] for your convenience.
- I cannot find an official description of the inclusion of the ASF header
to the modified third-party code: i.e.
  how many changes can be described as not being "mostly the same"? Is
there a quantifiable standard for this?

[1]
https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc
[2]
https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc

Best,
Twice


On Mon, Feb 13, 2023 at 4:07 PM kezhenxu94  wrote:

> Hi sorry -1 (binding) due to license issue, the following files [1] have
> ASF license headers along with the original license header,
> I saw you mentioned it's a conversion from C to C++ from Redis project,
> but from my comparison they look to
> be mostly the same so you might want to remove the ASF license header from
> those files.
>
> Other files [2] might be controversial whether we should have dual license
> headers, but I won't vote -1 on those files if [1] are resolved.
>
> [1]  - apache/incubator-kvrocks/src/types/geohash.cc 
>  - apache/incubator-kvrocks/src/common/sha1.cc 
>
> [2] - src/common/rand.cc src/common/rand.h
> - src/storage/scripting.*
>
> > On Feb 11, 2023, at 22:43, Myth  wrote:
> >
> > Hello Incubator PMC,
> >
> > The Apache Kvrocks community has voted and approved the release of Apache
> > Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review
> > and vote for this release.
> >
> > This is  the second call for a vote. The first call for a vote, which is
> > cancelled:
> > *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> > *
> >
> > Kvrocks is a distributed key value NoSQL database that uses RocksDB as
> the
> > storage engine and is compatible with Redis protocol. The current release
> > provides many new features, many improvements and fixes many bugs.
> >
> > Kvrocks community vote thread:
> > https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> >
> > Vote result thread:
> > https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> >
> > This release has been signed with a PGP available here:
> > https://downloads.apache.org/incubator/kvrocks/KEYS
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> >
> > Docker image:
> >
> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> >
> > Build guide can be found at:
> > https://github.com/apache/incubator-kvrocks#build
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes is reached.
> >
> > Please vote accordingly:
> > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> > [ ] +0
> > [ ] -1 Do not approve (please specify the reason)
> >
> > Thanks
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[kezhenxu94]

Hi sorry -1 (binding) due to license issue, the following files [1] have ASF 
license headers along with the original license header,
I saw you mentioned it's a conversion from C to C++ from Redis project, but 
from my comparison they look to
be mostly the same so you might want to remove the ASF license header from 
those files.

Other files [2] might be controversial whether we should have dual license 
headers, but I won't vote -1 on those files if [1] are resolved.

[1]  - apache/incubator-kvrocks/src/types/geohash.cc 
 - apache/incubator-kvrocks/src/common/sha1.cc 

[2] - src/common/rand.cc src/common/rand.h
- src/storage/scripting.*

> On Feb 11, 2023, at 22:43, Myth  wrote:
> 
> Hello Incubator PMC,
> 
> The Apache Kvrocks community has voted and approved the release of Apache
> Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review
> and vote for this release.
> 
> This is  the second call for a vote. The first call for a vote, which is
> cancelled:
> *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> *
> 
> Kvrocks is a distributed key value NoSQL database that uses RocksDB as the
> storage engine and is compatible with Redis protocol. The current release
> provides many new features, many improvements and fixes many bugs.
> 
> Kvrocks community vote thread:
> https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> 
> Vote result thread:
> https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> 
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> 
> This release has been signed with a PGP available here:
> https://downloads.apache.org/incubator/kvrocks/KEYS
> 
> Git tag for the release:
> https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> 
> Docker image:
> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> 
> Build guide can be found at:
> https://github.com/apache/incubator-kvrocks#build
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes is reached.
> 
> Please vote accordingly:
> [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> [ ] +0
> [ ] -1 Do not approve (please specify the reason)
> 
> Thanks


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Liang Chen]

+1 (binding)

I checked : 
- [X] Download links are valid.
- [X] signatures and hashes are ok.
- [X] No binary files
- [X] LICENSE and NOTICE are ok
- [X] incubating in name, all source files have ASF headers.

Regards
Liang

On 2023/02/13 02:41:51 hulk wrote:
> +1 (non-binding)
> 
> I checked:
> [x] Download links are valid.
> [x] Checksums and signatures.
> [x] LICENSE/NOTICE files exist
> [x] No unexpected binary files
> [x] All source files have ASF headers
> [x] Can compile from source
> [x] All Tests Passed
> [x] Docker image with right version
> [x] Docker image contains license files
> [x] Docker image can work well
> 
> 
> 
> On Mon, 13 Feb 2023 at 10:30, Xiaoqiao He  wrote:
> >
> > +1 (binding).
> >
> > - Download links are valid.
> > - Checksums and signatures are valid.
> > - LICENSE, NOTICE and DISCLAIMER files exist.
> > - All source files have apache license declare if necessary.
> > - Compile from source passed.
> > - No compiled archives bundled in the source archive.
> > - Run successfully simple commands about put,get etc.
> >
> > Best Regards,
> > - He Xiaoqiao
> >
> >
> > On Sun, Feb 12, 2023 at 7:24 PM tison  wrote:
> >
> > > +1 (binding)
> > >
> > > Verified:
> > >
> > > - [X] Download links are valid.
> > > - [X] Checksums and PGP signatures are valid.
> > > - [X] Source code artifacts have correct names matching the current
> > > release.
> > > - [X] LICENSE, NOTICE and DISCLAIMER are correct for the repository.
> > > - [X] All files have license headers if necessary.
> > > - [X] No compiled archives bundled in the source archive.
> > > - [X] Building is OK with: ./x.py build --ninja --ghproxy
> > > - [X] Stage docker image runs and serves properly
> > >
> > > Best,
> > > tison.
> > >
> > >
> > > Chao Zhang  于2023年2月12日周日 18:33写道：
> > >
> > > > Hi,
> > > >
> > > > +1 (non-binding) from me. I have checked:
> > > >
> > > > 1. All the above links are correct;
> > > > 2. The signature and checksum are correct;
> > > > 3. LICENSE and NOTICE files exist;
> > > >
> > > > Best regards
> > > > Chao Zhang
> > > >
> > > > https://github.com/tokers
> > > >
> > > > On Sat, Feb 11, 2023 at 10:44 PM Myth  wrote:
> > > > >
> > > > > Hello Incubator PMC,
> > > > >
> > > > > The Apache Kvrocks community has voted and approved the release of
> > > Apache
> > > > > Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members
> > > review
> > > > > and vote for this release.
> > > > >
> > > > > This is  the second call for a vote. The first call for a vote, which
> > > is
> > > > > cancelled:
> > > > > *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> > > > > *
> > > > >
> > > > > Kvrocks is a distributed key value NoSQL database that uses RocksDB as
> > > > the
> > > > > storage engine and is compatible with Redis protocol. The current
> > > release
> > > > > provides many new features, many improvements and fixes many bugs.
> > > > >
> > > > > Kvrocks community vote thread:
> > > > > https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> > > > >
> > > > > Vote result thread:
> > > > > https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> > > > >
> > > > > The release candidate:
> > > > > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> > > > >
> > > > > This release has been signed with a PGP available here:
> > > > > https://downloads.apache.org/incubator/kvrocks/KEYS
> > > > >
> > > > > Git tag for the release:
> > > > > https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> > > > >
> > > > > Docker image:
> > > > >
> > > >
> > > https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> > > > >
> > > > > Build guide can be found at:
> > > > > https://github.com/apache/incubator-kvrocks#build
> > > > >
> > > > > The vote will be open for at least 72 hours or until the necessary
> > > number
> > > > > of votes is reached.
> > > > >
> > > > > Please vote accordingly:
> > > > > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> > > > > [ ] +0
> > > > > [ ] -1 Do not approve (please specify the reason)
> > > > >
> > > > > Thanks
> > > >
> > > > -
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > >
> > >
> 
> 
> 
> --
> Best Regards,
> - Hulk Lin
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[hulk]

+1 (non-binding)

I checked:
[x] Download links are valid.
[x] Checksums and signatures.
[x] LICENSE/NOTICE files exist
[x] No unexpected binary files
[x] All source files have ASF headers
[x] Can compile from source
[x] All Tests Passed
[x] Docker image with right version
[x] Docker image contains license files
[x] Docker image can work well



On Mon, 13 Feb 2023 at 10:30, Xiaoqiao He  wrote:
>
> +1 (binding).
>
> - Download links are valid.
> - Checksums and signatures are valid.
> - LICENSE, NOTICE and DISCLAIMER files exist.
> - All source files have apache license declare if necessary.
> - Compile from source passed.
> - No compiled archives bundled in the source archive.
> - Run successfully simple commands about put,get etc.
>
> Best Regards,
> - He Xiaoqiao
>
>
> On Sun, Feb 12, 2023 at 7:24 PM tison  wrote:
>
> > +1 (binding)
> >
> > Verified:
> >
> > - [X] Download links are valid.
> > - [X] Checksums and PGP signatures are valid.
> > - [X] Source code artifacts have correct names matching the current
> > release.
> > - [X] LICENSE, NOTICE and DISCLAIMER are correct for the repository.
> > - [X] All files have license headers if necessary.
> > - [X] No compiled archives bundled in the source archive.
> > - [X] Building is OK with: ./x.py build --ninja --ghproxy
> > - [X] Stage docker image runs and serves properly
> >
> > Best,
> > tison.
> >
> >
> > Chao Zhang  于2023年2月12日周日 18:33写道：
> >
> > > Hi,
> > >
> > > +1 (non-binding) from me. I have checked:
> > >
> > > 1. All the above links are correct;
> > > 2. The signature and checksum are correct;
> > > 3. LICENSE and NOTICE files exist;
> > >
> > > Best regards
> > > Chao Zhang
> > >
> > > https://github.com/tokers
> > >
> > > On Sat, Feb 11, 2023 at 10:44 PM Myth  wrote:
> > > >
> > > > Hello Incubator PMC,
> > > >
> > > > The Apache Kvrocks community has voted and approved the release of
> > Apache
> > > > Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members
> > review
> > > > and vote for this release.
> > > >
> > > > This is  the second call for a vote. The first call for a vote, which
> > is
> > > > cancelled:
> > > > *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> > > > *
> > > >
> > > > Kvrocks is a distributed key value NoSQL database that uses RocksDB as
> > > the
> > > > storage engine and is compatible with Redis protocol. The current
> > release
> > > > provides many new features, many improvements and fixes many bugs.
> > > >
> > > > Kvrocks community vote thread:
> > > > https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> > > >
> > > > Vote result thread:
> > > > https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> > > >
> > > > The release candidate:
> > > > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> > > >
> > > > This release has been signed with a PGP available here:
> > > > https://downloads.apache.org/incubator/kvrocks/KEYS
> > > >
> > > > Git tag for the release:
> > > > https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> > > >
> > > > Docker image:
> > > >
> > >
> > https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> > > >
> > > > Build guide can be found at:
> > > > https://github.com/apache/incubator-kvrocks#build
> > > >
> > > > The vote will be open for at least 72 hours or until the necessary
> > number
> > > > of votes is reached.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> > > > [ ] +0
> > > > [ ] -1 Do not approve (please specify the reason)
> > > >
> > > > Thanks
> > >
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >



--
Best Regards,
- Hulk Lin

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Xiaoqiao He]

+1 (binding).

- Download links are valid.
- Checksums and signatures are valid.
- LICENSE, NOTICE and DISCLAIMER files exist.
- All source files have apache license declare if necessary.
- Compile from source passed.
- No compiled archives bundled in the source archive.
- Run successfully simple commands about put,get etc.

Best Regards,
- He Xiaoqiao


On Sun, Feb 12, 2023 at 7:24 PM tison  wrote:

> +1 (binding)
>
> Verified:
>
> - [X] Download links are valid.
> - [X] Checksums and PGP signatures are valid.
> - [X] Source code artifacts have correct names matching the current
> release.
> - [X] LICENSE, NOTICE and DISCLAIMER are correct for the repository.
> - [X] All files have license headers if necessary.
> - [X] No compiled archives bundled in the source archive.
> - [X] Building is OK with: ./x.py build --ninja --ghproxy
> - [X] Stage docker image runs and serves properly
>
> Best,
> tison.
>
>
> Chao Zhang  于2023年2月12日周日 18:33写道：
>
> > Hi,
> >
> > +1 (non-binding) from me. I have checked:
> >
> > 1. All the above links are correct;
> > 2. The signature and checksum are correct;
> > 3. LICENSE and NOTICE files exist;
> >
> > Best regards
> > Chao Zhang
> >
> > https://github.com/tokers
> >
> > On Sat, Feb 11, 2023 at 10:44 PM Myth  wrote:
> > >
> > > Hello Incubator PMC,
> > >
> > > The Apache Kvrocks community has voted and approved the release of
> Apache
> > > Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members
> review
> > > and vote for this release.
> > >
> > > This is  the second call for a vote. The first call for a vote, which
> is
> > > cancelled:
> > > *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> > > *
> > >
> > > Kvrocks is a distributed key value NoSQL database that uses RocksDB as
> > the
> > > storage engine and is compatible with Redis protocol. The current
> release
> > > provides many new features, many improvements and fixes many bugs.
> > >
> > > Kvrocks community vote thread:
> > > https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> > >
> > > Vote result thread:
> > > https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> > >
> > > The release candidate:
> > > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> > >
> > > This release has been signed with a PGP available here:
> > > https://downloads.apache.org/incubator/kvrocks/KEYS
> > >
> > > Git tag for the release:
> > > https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> > >
> > > Docker image:
> > >
> >
> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> > >
> > > Build guide can be found at:
> > > https://github.com/apache/incubator-kvrocks#build
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> number
> > > of votes is reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> > > [ ] +0
> > > [ ] -1 Do not approve (please specify the reason)
> > >
> > > Thanks
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[tison]

+1 (binding)

Verified:

- [X] Download links are valid.
- [X] Checksums and PGP signatures are valid.
- [X] Source code artifacts have correct names matching the current release.
- [X] LICENSE, NOTICE and DISCLAIMER are correct for the repository.
- [X] All files have license headers if necessary.
- [X] No compiled archives bundled in the source archive.
- [X] Building is OK with: ./x.py build --ninja --ghproxy
- [X] Stage docker image runs and serves properly

Best,
tison.


Chao Zhang  于2023年2月12日周日 18:33写道：

> Hi,
>
> +1 (non-binding) from me. I have checked:
>
> 1. All the above links are correct;
> 2. The signature and checksum are correct;
> 3. LICENSE and NOTICE files exist;
>
> Best regards
> Chao Zhang
>
> https://github.com/tokers
>
> On Sat, Feb 11, 2023 at 10:44 PM Myth  wrote:
> >
> > Hello Incubator PMC,
> >
> > The Apache Kvrocks community has voted and approved the release of Apache
> > Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review
> > and vote for this release.
> >
> > This is  the second call for a vote. The first call for a vote, which is
> > cancelled:
> > *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> > *
> >
> > Kvrocks is a distributed key value NoSQL database that uses RocksDB as
> the
> > storage engine and is compatible with Redis protocol. The current release
> > provides many new features, many improvements and fixes many bugs.
> >
> > Kvrocks community vote thread:
> > https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
> >
> > Vote result thread:
> > https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
> >
> > This release has been signed with a PGP available here:
> > https://downloads.apache.org/incubator/kvrocks/KEYS
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
> >
> > Docker image:
> >
> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
> >
> > Build guide can be found at:
> > https://github.com/apache/incubator-kvrocks#build
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes is reached.
> >
> > Please vote accordingly:
> > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> > [ ] +0
> > [ ] -1 Do not approve (please specify the reason)
> >
> > Thanks
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Chao Zhang]

Hi,

+1 (non-binding) from me. I have checked:

1. All the above links are correct;
2. The signature and checksum are correct;
3. LICENSE and NOTICE files exist;

Best regards
Chao Zhang

https://github.com/tokers

On Sat, Feb 11, 2023 at 10:44 PM Myth  wrote:
>
> Hello Incubator PMC,
>
> The Apache Kvrocks community has voted and approved the release of Apache
> Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review
> and vote for this release.
>
> This is  the second call for a vote. The first call for a vote, which is
> cancelled:
> *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
> *
>
> Kvrocks is a distributed key value NoSQL database that uses RocksDB as the
> storage engine and is compatible with Redis protocol. The current release
> provides many new features, many improvements and fixes many bugs.
>
> Kvrocks community vote thread:
> https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2
>
> Vote result thread:
> https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/
>
> This release has been signed with a PGP available here:
> https://downloads.apache.org/incubator/kvrocks/KEYS
>
> Git tag for the release:
> https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0
>
> Docker image:
> https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807
>
> Build guide can be found at:
> https://github.com/apache/incubator-kvrocks#build
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes is reached.
>
> Please vote accordingly:
> [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
> [ ] +0
> [ ] -1 Do not approve (please specify the reason)
>
> Thanks

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

[VOTE] Release Apache Kvrocks(incubating) 2.3.0(NEW VOTE)

[Myth]

Hello Incubator PMC,

The Apache Kvrocks community has voted and approved the release of Apache
Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review
and vote for this release.

This is  the second call for a vote. The first call for a vote, which is
cancelled:
*https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt
*

Kvrocks is a distributed key value NoSQL database that uses RocksDB as the
storage engine and is compatible with Redis protocol. The current release
provides many new features, many improvements and fixes many bugs.

Kvrocks community vote thread:
https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2

Vote result thread:
https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw

The release candidate:
https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/

This release has been signed with a PGP available here:
https://downloads.apache.org/incubator/kvrocks/KEYS

Git tag for the release:
https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0

Docker image:
https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807

Build guide can be found at:
https://github.com/apache/incubator-kvrocks#build

The vote will be open for at least 72 hours or until the necessary number
of votes is reached.

Please vote accordingly:
[ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0
[ ] +0
[ ] -1 Do not approve (please specify the reason)

Thanks