Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hello all, The vote for releasing Apache Singa (incubating) 2.0.0 is now closed. Vote result: 3 (+1 binding) (Alan Gates, Justin Mclean, Thejas Nair) 0 ( 0 binding) 0 (-1 binding) The vote has passed. Thank you for taking the time to review the release. Minor issues raised during the vote have been captured and will be fixed in the next release. We’ll now roll the release out to the mirrors. Best, Chonho On Thu, Apr 11, 2019 at 10:21 AM Chonho Lee wrote: > Hi all, > > The SINGA community has voted on and approved a proposal to release Apache > SINGA 2.0.0 (incubating). > > The vote thread is at: > > http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuVVE6SZe_%2B6A5OpApY5rDRhBWCfv8H1uZ%2BZuz1NR17_g%40mail.gmail.com%3E > > and the result is at: > > http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuUBih-sdopzPSp3%2BgS1%3DMYaL-7zjjqkBmGaxkbgLeLYw%40mail.gmail.com%3E > > We ask the IPMC to vote on this release. > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/ > > The hashes of the artifacts are as follows: > SHA512: D422ED7C 1AD370CA 66D5591B E581DC3C 2513396E 465CF983 80785929 > A70189AA 8944452A 1B10AF23 03F781BF 5D4066CE D994FE97 123280A1 EA34A681 > 3402BA12 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/dinhtta.asc > > and the signature file is: > > https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/apache-singa-incubating-2.0.0-RC1.tar.gz.asc > > > The Github tag is at: > https://github.com/apache/incubator-singa/releases/tag/2.0.0rc1 > commit ID is: 5f14f3dbc005a64fdbc508bff63db92e6d3e05b6 > > To check the license, you can use the Apache Rat tool as follows: > 1. download & decompress apache rat from > http://creadur.apache.org/rat/download_rat.cgi > 2. run the following command under singa folder: > java -jar /PATH/TO/RAT/apache-rat-0.11.jar -E rat-excludes -d . > > rat_check > 3. check the results in file named "rat_check" > > Please check and vote on releasing this package. The vote is open for at > least 72 hours and passes if a majority of at least three +1 votes are > cast. > > [ ] +1 Release this package as Apache SINGA 2.0.0-incubating > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Here is my vote: > +1 (non-binding) > > Best, > > -- > Chonho Lee > -- Chonho Lee
Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)
+1 binding On Wed, Apr 17, 2019 at 8:24 PM Justin Mclean wrote: > Hi, > > +1 (binding) See other email for what I reviewed. > > Thanks, > Justin > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi, +1 (binding) See other email for what I reviewed. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Thanks for the suggestion! We have created the jira ticket: https://issues.apache.org/jira/projects/SINGA/issues/SINGA-447. We would kindly request the Incubator PMC members to continue reviewing the release and voting on this thread. Regards, Wei On Wed, Apr 17, 2019 at 8:17 PM Justin Mclean wrote: > Hi, > > > Can we reopen the voting thread and create a jira ticket for this issue? > > I would do this and just ignore the cancel thread and fix in the next > release. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi, > Can we reopen the voting thread and create a jira ticket for this issue? I would do this and just ignore the cancel thread and fix in the next release. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi Justin, Can we reopen the voting thread and create a jira ticket for this issue? Or is it better to fix it and then start the voting again since we have already canceled it? Thanks. Regards, Wei On Wed, Apr 17, 2019 at 11:52 AM Justin Mclean wrote: > Hi, > > > We are canceling this voting to fix the license issue pointed by Justin. > > Which seems odd given they are very minor and I hadn’t voted -1. Something > like this can be fixed in a future release. In fact I had intended to vote > +1. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi, > We are canceling this voting to fix the license issue pointed by Justin. Which seems odd given they are very minor and I hadn’t voted -1. Something like this can be fixed in a future release. In fact I had intended to vote +1. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
[CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)
We are canceling this voting to fix the license issue pointed by Justin. Thanks! On Thu, Apr 11, 2019 at 10:21 AM Chonho Lee wrote: > Hi all, > > The SINGA community has voted on and approved a proposal to release Apache > SINGA 2.0.0 (incubating). > > The vote thread is at: > > http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuVVE6SZe_%2B6A5OpApY5rDRhBWCfv8H1uZ%2BZuz1NR17_g%40mail.gmail.com%3E > > and the result is at: > > http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuUBih-sdopzPSp3%2BgS1%3DMYaL-7zjjqkBmGaxkbgLeLYw%40mail.gmail.com%3E > > We ask the IPMC to vote on this release. > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/ > > The hashes of the artifacts are as follows: > SHA512: D422ED7C 1AD370CA 66D5591B E581DC3C 2513396E 465CF983 80785929 > A70189AA 8944452A 1B10AF23 03F781BF 5D4066CE D994FE97 123280A1 EA34A681 > 3402BA12 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/dinhtta.asc > > and the signature file is: > > https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/apache-singa-incubating-2.0.0-RC1.tar.gz.asc > > > The Github tag is at: > https://github.com/apache/incubator-singa/releases/tag/2.0.0rc1 > commit ID is: 5f14f3dbc005a64fdbc508bff63db92e6d3e05b6 > > To check the license, you can use the Apache Rat tool as follows: > 1. download & decompress apache rat from > http://creadur.apache.org/rat/download_rat.cgi > 2. run the following command under singa folder: > java -jar /PATH/TO/RAT/apache-rat-0.11.jar -E rat-excludes -d . > > rat_check > 3. check the results in file named "rat_check" > > Please check and vote on releasing this package. The vote is open for at > least 72 hours and passes if a majority of at least three +1 votes are > cast. > > [ ] +1 Release this package as Apache SINGA 2.0.0-incubating > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Here is my vote: > +1 (non-binding) > > Best, > > -- > Chonho Lee > -- Chonho Lee
Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi, > convert.py is explained in the LICENSE file > https://github.com/apache/incubator-singa/blob/master/LICENSE#L448 > Do we still need to include the header in [1]? Up to you. Files can get separated from where come from (like this one) and it then becomes unclear of what it’s license is or it’s IP provanance. It's also a little odd I don’t see the file here [1] and all the files there do have ALv2 headers copyright Google. A google search for "Converting tensorflow checkpoint file to key-val pkl file” only picks up the file in Singa so I’m not 100% sure where it came from. It may of come from [2] (see this change [3]) which also has an ALv2 header. If the original file had an ALv2 header it should not of been removed. [3] Thanks, Justin 1. https://github.com/tensorflow/models/tree/master/research/inception/inception 2. https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/tools/inspect_checkpoint.py 3. http://mail-archives.apache.org/mod_mbox/singa-commits/201707.mbox/%3c658df2418844497a8aac612b474b1...@git.apache.org%3E 4. https://www.apache.org/legal/src-headers.html#3party - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi Justin, convert.py is explained in the LICENSE file https://github.com/apache/incubator-singa/blob/master/LICENSE#L448 Do we still need to include the header in [1]? Thanks! Best Wei On Mon, Apr 15, 2019 at 6:06 AM Justin Mclean wrote: > Hi, > > I checked: > - incubating in name > - signatures and hashes good > - DISLAMIER exists > - LICENSE file good > - NOTICE year needs updating > - No unexpected binary files in releases > - All source files have headers except this one [1] > - Don't have a setup suitable to compile > > Thanks, > Justin > > 1. incubator-singa/examples/imagenet/inception/convert.py > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi, I checked: - incubating in name - signatures and hashes good - DISLAMIER exists - LICENSE file good - NOTICE year needs updating - No unexpected binary files in releases - All source files have headers except this one [1] - Don't have a setup suitable to compile Thanks, Justin 1. incubator-singa/examples/imagenet/inception/convert.py - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Forwarding my +1 from the dev list. Checked signatures, sha, did a quick check to make sure files without headers were referenced in LICENSE or NOTICE, looked for binary files in the distribution. Alan. On Wed, Apr 10, 2019 at 6:21 PM Chonho Lee wrote: > Hi all, > > The SINGA community has voted on and approved a proposal to release Apache > SINGA 2.0.0 (incubating). > > The vote thread is at: > > http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuVVE6SZe_%2B6A5OpApY5rDRhBWCfv8H1uZ%2BZuz1NR17_g%40mail.gmail.com%3E > > and the result is at: > > http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuUBih-sdopzPSp3%2BgS1%3DMYaL-7zjjqkBmGaxkbgLeLYw%40mail.gmail.com%3E > > We ask the IPMC to vote on this release. > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/ > > The hashes of the artifacts are as follows: > SHA512: D422ED7C 1AD370CA 66D5591B E581DC3C 2513396E 465CF983 80785929 > A70189AA 8944452A 1B10AF23 03F781BF 5D4066CE D994FE97 123280A1 EA34A681 > 3402BA12 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/dinhtta.asc > > and the signature file is: > > https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/apache-singa-incubating-2.0.0-RC1.tar.gz.asc > > > The Github tag is at: > https://github.com/apache/incubator-singa/releases/tag/2.0.0rc1 > commit ID is: 5f14f3dbc005a64fdbc508bff63db92e6d3e05b6 > > To check the license, you can use the Apache Rat tool as follows: > 1. download & decompress apache rat from > http://creadur.apache.org/rat/download_rat.cgi > 2. run the following command under singa folder: > java -jar /PATH/TO/RAT/apache-rat-0.11.jar -E rat-excludes -d . > > rat_check > 3. check the results in file named "rat_check" > > Please check and vote on releasing this package. The vote is open for at > least 72 hours and passes if a majority of at least three +1 votes are > cast. > > [ ] +1 Release this package as Apache SINGA 2.0.0-incubating > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Here is my vote: > +1 (non-binding) > > Best, > > -- > Chonho Lee >
[VOTE] Release apache-singa-incubating-2.0.0 (RC1)
Hi all, The SINGA community has voted on and approved a proposal to release Apache SINGA 2.0.0 (incubating). The vote thread is at: http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuVVE6SZe_%2B6A5OpApY5rDRhBWCfv8H1uZ%2BZuz1NR17_g%40mail.gmail.com%3E and the result is at: http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuUBih-sdopzPSp3%2BgS1%3DMYaL-7zjjqkBmGaxkbgLeLYw%40mail.gmail.com%3E We ask the IPMC to vote on this release. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/ The hashes of the artifacts are as follows: SHA512: D422ED7C 1AD370CA 66D5591B E581DC3C 2513396E 465CF983 80785929 A70189AA 8944452A 1B10AF23 03F781BF 5D4066CE D994FE97 123280A1 EA34A681 3402BA12 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/dinhtta.asc and the signature file is: https://dist.apache.org/repos/dist/dev/incubator/singa/2.0.0/apache-singa-incubating-2.0.0-RC1.tar.gz.asc The Github tag is at: https://github.com/apache/incubator-singa/releases/tag/2.0.0rc1 commit ID is: 5f14f3dbc005a64fdbc508bff63db92e6d3e05b6 To check the license, you can use the Apache Rat tool as follows: 1. download & decompress apache rat from http://creadur.apache.org/rat/download_rat.cgi 2. run the following command under singa folder: java -jar /PATH/TO/RAT/apache-rat-0.11.jar -E rat-excludes -d . > rat_check 3. check the results in file named "rat_check" Please check and vote on releasing this package. The vote is open for at least 72 hours and passes if a majority of at least three +1 votes are cast. [ ] +1 Release this package as Apache SINGA 2.0.0-incubating [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (non-binding) Best, -- Chonho Lee
