Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Hi,
On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch hirsch.d...@gmail.com wrote:
On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz bdelacre...@apache.org
wrote:
... 4) When trying to build esme-java-client with mvn clean install I
get Embedded error: Error while executing the external compiler if
JAVA_HOME is not set.
How can you deal with this via maven? Is this an ESME problem or a maven
problem?...
Looks just like a weird maven-compiler-plugin setup in
esme-java-client/pom.xml, the patch below fixes it. I get test
failures then, but that's another story.
-Bertrand
Index: pom.xml
===
--- pom.xml (revision 910855)
+++ pom.xml (working copy)
@@ -46,26 +46,6 @@
configuration
verbosetrue/verbose
forktrue/fork
- executable${JAVA_HOME}/bin/javac/executable
- !--
- define the JAVA_1_4_HOME property in .m2/settings.xml for
portability, e.g.:
- settings
- [...]
- profiles
- [...]
- profile
- idcompiler/id
- properties
- JAVA_1_4_HOMEC:\Program
Files\Java\j2sdk1.4.2_09/JAVA_1_4_HOME
- /properties
- /profile
- /profiles
- [...]
- activeProfiles
- activeProfilecompiler/activeProfile
- /activeProfiles
- /settings
- --
compilerVersion1.4/compilerVersion
/configuration
/plugin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Thanks Joe and Bertrand. Point taken. Better to be safe and respectful than sorry. I'll continue the discussion on the ESME list alone. Ethan On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer joe_schae...@yahoo.com wrote: - Original Message From: Bertrand Delacretaz bdelacre...@apache.org ...Unfortunately I'm -1 on the release, I have a few issues including a GPL dependency. 1) jwebunit dependency is GPL The server module depends on net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test which according to http://jwebunit.sourceforge.net/license.html is GPL. Well isn't jwebunit a test framework, in which case, (and assuming there are no dependencies on it in the production-ready codebase of esme) do we really care that it's GPL or not? ... I see your point, one could argue that people don't need jwebunit to *run* ESME, they only need it to run the tests when building it. Still, the code that is distributed contains imports of jwebunit, so I think that's stretching the concept too far. ... (Note an exception to the (L)GPL policy was recently granted for build dependencies, so I think it's might be possible to extend that to test deps.)... Might be possible, but getting rid of that jwwebunit dependency would be much cleaner IMO. I haven't checked how much work that represents, but according to http://jwebunit.sourceforge.net/ that's just a wrapper on top of HtmlUnit which has an Apache license, so using HtmlUnit instead might not be too hard. -Bertrand - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Thanks Joe and Bertrand. Point taken. Better to be safe and respectful than sorry. I'll try to spend some time looking at it. On the surface, it looks like it's imported into my API2 tests but is not really used. I'll try removing it from the tests in general, not just API2. It looks like it really is used in the JettySetup.scala file. I can try removing it from there as well, but I'm less optimistic that tests will still run. Who originally created this setup? David? Ethan On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer joe_schae...@yahoo.com wrote: - Original Message From: Bertrand Delacretaz bdelacre...@apache.org ...Unfortunately I'm -1 on the release, I have a few issues including a GPL dependency. 1) jwebunit dependency is GPL The server module depends on net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test which according to http://jwebunit.sourceforge.net/license.html is GPL. Well isn't jwebunit a test framework, in which case, (and assuming there are no dependencies on it in the production-ready codebase of esme) do we really care that it's GPL or not? ... I see your point, one could argue that people don't need jwebunit to *run* ESME, they only need it to run the tests when building it. Still, the code that is distributed contains imports of jwebunit, so I think that's stretching the concept too far. ... (Note an exception to the (L)GPL policy was recently granted for build dependencies, so I think it's might be possible to extend that to test deps.)... Might be possible, but getting rid of that jwwebunit dependency would be much cleaner IMO. I haven't checked how much work that represents, but according to http://jwebunit.sourceforge.net/ that's just a wrapper on top of HtmlUnit which has an Apache license, so using HtmlUnit instead might not be too hard. -Bertrand - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
+1 (mentor and IPMC binding) Some thoughts, but nothing that I would consider a show stopper since this is a source only release (aka: not providing a prebuilt war type thing or deploying it to Maven central): 1) The README mentions a Collective work: Copyright 2007, but the NOTICE starts the copyright at 2008. That said, I'd just remove the License section from the README entirely. 2) The tar unpacks into a trunk directory. That really should unpack into a apache-esme-1.0 directory or similar. 3) The version number in the pom is still 0.3.0-SNAPSHOT. Thus, if you build it, you get a snapshot war.Not a huge deal if we're not providing a binary war, but a bit unusual and unexpected. 4) Snapshot dependencies. It has dependencies on snapshots from Lift. Not good for a release as the release isn't really reproducible. 5) Very minor suggestion: if you are Java 6 only, you could exclude things like activation.jar, xml-apis, and most likely xerces to make the war a little bit smaller.. As far as the legal bits go, looks ok for a source release, so +1. Dan On Mon February 15 2010 10:05:43 am Richard Hirsch wrote: The ESME community has voted on and approved the release of ESME 1.0. We would now like to request the approval of the Incubator PMC for this release. Details of the ESME community vote can be found here: http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3C fa2d9f451002120649u54cdd8b5red151033d655b...@mail.gmail.com%3e The candidate can be found at: http://people.apache.org/~rhirsch/esme/ See the CHANGES.txt file for details on release contents. The release candidate is a tar archive of the sources in https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/ The MD5 checksum of the apache-esme-incubating-1.0- src.tar.gz release package is A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18 Please vote on releasing this package as Apache ESME 1.0-incubating. Please vote to publish this release by Thursday, Feb 18 16:03 CET, please include the testing you performed to arrive at your vote [ ] +1 Publish [ ] 0 Abstain [ ] -1 Don't publish, because... Below is a summary of the vote on the ESME mailing list Thanks Dick --- Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆ toesme-...@incubator.apache.org date Mon, Feb 15, 2010 at 4:00 PM subject [VOTE][RESULT] ESME 1.0 mailed-by gmail.com Hello All, Voting on the ESME 1.0 candidate release has concluded Results: 6 binding +1 vote Dick Hirsch +1 Mrinal Wadhwa +1 Vassil Dichev +1 Ethan Jewett +1 Anne Kathrine Petteroe +1 Darren Hague +1 1 non-binding +1 votes Daniel Koller +1 - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org -- Daniel Kulp dk...@apache.org http://www.dankulp.com/blog - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Hi guys, On 2/16/10 8:22 AM, Daniel Kulp dk...@apache.org wrote: What would be better in the pom.xml: versionapache-esme-1.0/version? No, just 1.0-incubator or similar. If this is the 1.0 release, the version number should be 1.0. The 1.1 release would have a version of 1.1. According to: http://incubator.apache.org/guides/releasemanagement.html#naming The release should contain the word: incubating. So, apache-esme-1.0-incubating is probably the appropriate title. HTH, Chris ++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: chris.mattm...@jpl.nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++ Adjunct Assistant Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++ - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Hi, On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch hirsch.d...@gmail.com wrote: ...The candidate can be found at: http://people.apache.org/~rhirsch/esme/ Unfortunately I'm -1 on the release, I have a few issues including a GPL dependency. 1) jwebunit dependency is GPL The server module depends on net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test which according to http://jwebunit.sourceforge.net/license.html is GPL. 2) The sha1 digest does not match, did I do something wrong? $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz SHA1(apache-esme-incubating-1.0-src.tar.gz)= a9ec8d95266d5944d493392a06eb1651c03222f1 $ cat apache-esme-incubating-1.0-src.tar.gz.sha apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6 64B3B76C 747BA64A FFC9A836 EDAB8D86 4E0735CC AA29ACA9 07767C58 D1C0FEDA CA7E73A3 ADA3944D 464314B2 4BE0E476 3) mvn dependency:analyze of the server module shows lots of unused declared dependencies, those should be cleaned up, especially openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is either GPL or CDDL license. Not sure which parts of OpenDMK are which license, but as it's unused better remove it. 4) When trying to build esme-java-client with mvn clean install I get Embedded error: Error while executing the external compiler if JAVA_HOME is not set. 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it should not have that. You could have created the release using svn export of http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/ to avoid that. 6) I couldn't find license information for the com.twitter:stats:jar:1.3:compile dependency, was that checked to be ok? Sorry that I didn't have time to look at that during the ESME podling vote. Apart from the GPL dependency the release preparation looks mostly ok, rat reports are good, license/notice are provided, etc. -Bertrand - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
- Original Message From: Bertrand Delacretaz bdelacre...@apache.org To: esme-...@incubator.apache.org Cc: general@incubator.apache.org Sent: Tue, February 16, 2010 11:28:22 AM Subject: Re: [VOTE] Approve the release of apache-esme-incubating-1.0 Hi, On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch wrote: ...The candidate can be found at: http://people.apache.org/~rhirsch/esme/ Unfortunately I'm -1 on the release, I have a few issues including a GPL dependency. 1) jwebunit dependency is GPL The server module depends on net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test which according to http://jwebunit.sourceforge.net/license.html is GPL. Well isn't jwebunit a test framework, in which case, (and assuming there are no dependencies on it in the production-ready codebase of esme) do we really care that it's GPL or not? (Note an exception to the (L)GPL policy was recently granted for build dependencies, so I think it's might be possible to extend that to test deps.) - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Like I said - I'm seeing this first release as a learning experience (grin, grin) On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch hirsch.d...@gmail.com wrote: ...The candidate can be found at: http://people.apache.org/~rhirsch/esme/http://people.apache.org/%7Erhirsch/esme/ Unfortunately I'm -1 on the release, I have a few issues including a GPL dependency. 1) jwebunit dependency is GPL The server module depends on net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test which according to http://jwebunit.sourceforge.net/license.html is GPL. I didn't check any maven dependencies, because they weren't part of SVN. 2) The sha1 digest does not match, did I do something wrong? $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz SHA1(apache-esme-incubating-1.0-src.tar.gz)= a9ec8d95266d5944d493392a06eb1651c03222f1 $ cat apache-esme-incubating-1.0-src.tar.gz.sha apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6 64B3B76C 747BA64A FFC9A836 EDAB8D86 4E0735CC AA29ACA9 07767C58 D1C0FEDA CA7E73A3 ADA3944D 464314B2 4BE0E476 I'm assuming I did something wrong. It was my first attempt at signing. I'll take another shot at it. 3) mvn dependency:analyze of the server module shows lots of unused declared dependencies, those should be cleaned up, especially openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is either GPL or CDDL license. Not sure which parts of OpenDMK are which license, but as it's unused better remove it. OK - I'll take a look at it. 4) When trying to build esme-java-client with mvn clean install I get Embedded error: Error while executing the external compiler if JAVA_HOME is not set. How can you deal with this via maven? Is this an ESME problem or a maven problem? 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it should not have that. You could have created the release using svn export of http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/ to avoid that. OK. Didn't know that. 6) I couldn't find license information for the com.twitter:stats:jar:1.3:compile dependency, was that checked to be ok? Don't know - I'll have to check. This was from our JMX interface . Sorry that I didn't have time to look at that during the ESME podling vote. Apart from the GPL dependency the release preparation looks mostly ok, rat reports are good, license/notice are provided, etc. -Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer joe_schae...@yahoo.com wrote: - Original Message From: Bertrand Delacretaz bdelacre...@apache.org ...Unfortunately I'm -1 on the release, I have a few issues including a GPL dependency. 1) jwebunit dependency is GPL The server module depends on net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test which according to http://jwebunit.sourceforge.net/license.html is GPL. Well isn't jwebunit a test framework, in which case, (and assuming there are no dependencies on it in the production-ready codebase of esme) do we really care that it's GPL or not? ... I see your point, one could argue that people don't need jwebunit to *run* ESME, they only need it to run the tests when building it. Still, the code that is distributed contains imports of jwebunit, so I think that's stretching the concept too far. ... (Note an exception to the (L)GPL policy was recently granted for build dependencies, so I think it's might be possible to extend that to test deps.)... Might be possible, but getting rid of that jwwebunit dependency would be much cleaner IMO. I haven't checked how much work that represents, but according to http://jwebunit.sourceforge.net/ that's just a wrapper on top of HtmlUnit which has an Apache license, so using HtmlUnit instead might not be too hard. -Bertrand - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Seems to work fine, although you should perhaps make super-clear in the next version's README that you require JDK 1.6 (I was on 1.5 and had build problems). +1 from me for the release. Thanks, --Glen On 2/15/2010 10:05 AM, Richard Hirsch wrote: The ESME community has voted on and approved the release of ESME 1.0. We would now like to request the approval of the Incubator PMC for this release. Details of the ESME community vote can be found here: http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3cfa2d9f451002120649u54cdd8b5red151033d655b...@mail.gmail.com%3e The candidate can be found at: http://people.apache.org/~rhirsch/esme/ See the CHANGES.txt file for details on release contents. The release candidate is a tar archive of the sources in https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/ The MD5 checksum of the apache-esme-incubating-1.0- src.tar.gz release package is A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18 Please vote on releasing this package as Apache ESME 1.0-incubating. Please vote to publish this release by Thursday, Feb 18 16:03 CET, please include the testing you performed to arrive at your vote [ ] +1 Publish [ ] 0 Abstain [ ] -1 Don't publish, because... Below is a summary of the vote on the ESME mailing list Thanks Dick --- Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆ toesme-...@incubator.apache.org date Mon, Feb 15, 2010 at 4:00 PM subject [VOTE][RESULT] ESME 1.0 mailed-by gmail.com Hello All, Voting on the ESME 1.0 candidate release has concluded Results: 6 binding +1 vote Dick Hirsch +1 Mrinal Wadhwa +1 Vassil Dichev +1 Ethan Jewett +1 Anne Kathrine Petteroe +1 Darren Hague +1 1 non-binding +1 votes Daniel Koller +1 - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
@Glen: Thanks for the tip. I've updated the README for the next release. D. On Mon, Feb 15, 2010 at 9:34 PM, Glen Daniels g...@thoughtcraft.com wrote: Seems to work fine, although you should perhaps make super-clear in the next version's README that you require JDK 1.6 (I was on 1.5 and had build problems). +1 from me for the release. Thanks, --Glen On 2/15/2010 10:05 AM, Richard Hirsch wrote: The ESME community has voted on and approved the release of ESME 1.0. We would now like to request the approval of the Incubator PMC for this release. Details of the ESME community vote can be found here: http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3cfa2d9f451002120649u54cdd8b5red151033d655b...@mail.gmail.com%3e The candidate can be found at: http://people.apache.org/~rhirsch/esme/http://people.apache.org/%7Erhirsch/esme/ See the CHANGES.txt file for details on release contents. The release candidate is a tar archive of the sources in https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/ The MD5 checksum of the apache-esme-incubating-1.0- src.tar.gz release package is A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18 Please vote on releasing this package as Apache ESME 1.0-incubating. Please vote to publish this release by Thursday, Feb 18 16:03 CET, please include the testing you performed to arrive at your vote [ ] +1 Publish [ ] 0 Abstain [ ] -1 Don't publish, because... Below is a summary of the vote on the ESME mailing list Thanks Dick --- Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆ toesme-...@incubator.apache.org date Mon, Feb 15, 2010 at 4:00 PM subject [VOTE][RESULT] ESME 1.0 mailed-by gmail.com Hello All, Voting on the ESME 1.0 candidate release has concluded Results: 6 binding +1 vote Dick Hirsch +1 Mrinal Wadhwa +1 Vassil Dichev +1 Ethan Jewett +1 Anne Kathrine Petteroe +1 Darren Hague +1 1 non-binding +1 votes Daniel Koller +1 - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
