Re: [gentoo-dev] Signed-off-by verification incoming
On 09/29/2018 10:52 AM, Thomas Deutschmann wrote: > On 2018-09-29 15:14, Jeroen Roovers wrote: >> Please: >> >> 0a) Explain to me how to fix my commits that I now can't push, or > > Like you have already figured out, "git commit --signoff" when doing > profile/eclass changes and to fix things, "git commit --amend --signoff". > > >> 1) Update repoman to enforce it _before_ the commit is executed. > > Please add > >> DCO_SIGNED_OFF_BY="Larry the Cow " > > to your make.conf and "repoman commit" will do it for your. > > >> 2) Wait for the repoman update to trickle down to all developers. > > DCO_SIGNED_OFF_BY is present since 2013-04-22 20:01:29 -0700. So it > should be available for all developers. > > >> 3) Announce it ahead of time. > > I agree. Communication was bad. We should have included dev howto with > that announcement. > > this thread was mentioned today in #gentoo-dev-help [20:35:26] I never would've thought to look for repoman docs there O__o [20:36:16] ironically, the documentation for this repoman feature is in the manpage for make.conf instead of the manpage for repoman - weird, but I guess it is technically documented already sneaky :) maybe could be in the repoman manpage instead? (too?)
[gentoo-dev] New project: Gentoo Proctors
Good evening community! It is my pleasure to announce, that after almost 1,5 years of the hard work, the Gentoo Proctors project [1] starts working as was discussed and approved by the Council at their last meeting [2]. The main purpose of the project is to create the disciplinary body handling direct Code of Conduct violations (this allows the Comrel team to focus on the most serious violations). The Code of Conduct page was updated accordingly [3]. I also want to give a shout out to dilfridge for his patience during making it fly! [1] - https://wiki.gentoo.org/wiki/Project:Proctors [2] - https://projects.gentoo.org/council/meeting-logs/20180909-summary.txt [3] - https://wiki.gentoo.org/wiki/Project:Council/Code_of_conduct signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] Signed-off-by verification incoming
On Sat, Sep 29, 2018 at 4:52 PM Thomas Deutschmann wrote: > I agree. Communication was bad. We should have included dev howto with > that announcement. > Thanks for the helpful pointers! Regards, Dirkjan
[gentoo-dev] Copyright notices in ebuild repositories
By GLEP 76, two forms of copyright notices are allowed for copyrightable files in Gentoo projects: A "long form": Copyright YEARS MAIN-CONTRIBUTOR [OTHER-CONTRIBUTOR]... [and others] or a "simplified form": Copyright YEARS Gentoo Authors The latter was introduced because keeping track of ebuild authors is close to impossible. We didn't want to put any burden on developers to decide when information about the main contributor should be updated in the notice. Or, by the GLEP's own wording: "Especially for ebuild repositories, constantly keeping track of the main copyright holder of any file would be rather inconvenient and tedious." Therefore, the recommendation is to use the simplified form (i.e., "Gentoo Authors") in the Gentoo repository, at least for ebuilds and profile files. Also, when doing a simple version bump based on a previous ebuild, the existing starting year should be kept. (I am aware that for most ebuilds 1999 will not be correct either. Not sure if aiming for something more accurate would be worth the effort, though.) Ulrich signature.asc Description: PGP signature
Re: [gentoo-dev] Signed-off-by verification incoming
On 2018-09-29 15:14, Jeroen Roovers wrote: > Please: > > 0a) Explain to me how to fix my commits that I now can't push, or Like you have already figured out, "git commit --signoff" when doing profile/eclass changes and to fix things, "git commit --amend --signoff". > 1) Update repoman to enforce it _before_ the commit is executed. Please add > DCO_SIGNED_OFF_BY="Larry the Cow " to your make.conf and "repoman commit" will do it for your. > 2) Wait for the repoman update to trickle down to all developers. DCO_SIGNED_OFF_BY is present since 2013-04-22 20:01:29 -0700. So it should be available for all developers. > 3) Announce it ahead of time. I agree. Communication was bad. We should have included dev howto with that announcement. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] Signed-off-by verification incoming
On 09/29/2018 09:29 AM, Rich Freeman wrote: > On Sat, Sep 29, 2018 at 9:25 AM Dirkjan Ochtman wrote: >> >> Some kind of repoman support would make this much easier to handle. As >> it is, doing this by hand for the trivial case (only my own changes) >> is a PITA. repoman could grow some kind of --sign-off option that >> appends this to the commit message presumably? >> > > Does "repoman commit" no longer do the right thing? > amd64 keyword-stable app-portage/repoman doesn't seem to, so I had to use repoman manifest && git commit -s -S recently
Re: [gentoo-dev] Signed-off-by verification incoming
On Sat, 29 Sep 2018 15:25:25 +0200 Dirkjan Ochtman wrote: > On Sat, Sep 29, 2018 at 3:14 PM Jeroen Roovers wrote: > > > 0a) Explain to me how to fix my commits that I now can't push, or > Try git rebase -i and use "r" for "reword" on every commit. `git rebase ---signoff` did the trick. Kind regards, jer
Re: [gentoo-dev] Signed-off-by verification incoming
On Sat, Sep 29, 2018 at 3:14 PM Jeroen Roovers wrote: > 0a) Explain to me how to fix my commits that I now can't push, or > 0b) disable that hook immediately. > Try git rebase -i and use "r" for "reword" on every commit. > 1) Update repoman to enforce it _before_ the commit is executed. > Some kind of repoman support would make this much easier to handle. As it is, doing this by hand for the trivial case (only my own changes) is a PITA. repoman could grow some kind of --sign-off option that appends this to the commit message presumably? I think repoman checks happen on the tree, not on the commit, so I'm not sure how you think enforcing it before the commit makes sense (the line is effectively part of the commit). > 2) Wait for the repoman update to trickle down to all developers. > 3) Announce it ahead of time. > Some more lead time would be appreciated, yes. Regards, Dirkjan
Re: [gentoo-dev] Signed-off-by verification incoming
On Sat, Sep 29, 2018 at 9:25 AM Dirkjan Ochtman wrote: > > Some kind of repoman support would make this much easier to handle. As > it is, doing this by hand for the trivial case (only my own changes) > is a PITA. repoman could grow some kind of --sign-off option that > appends this to the commit message presumably? > Does "repoman commit" no longer do the right thing? -- Rich
Re: [gentoo-dev] Signed-off-by verification incoming
On Sat, 29 Sep 2018 10:19:10 +0200 Michał Górny wrote: > Hi, everyone. > > Just FYI, I'm going to enable the git hook to verify Signed-off-by > tags on gentoo.git (most likely all repos later on). I've tested it > against all the test cases I could think of but if you have any > trouble pushing, please ping me or others in #-infra. > > Please note that for the hook to work: > > 1. Every commit must contain 'Signed-off-by' of the committer. > > 2. You must use your @gentoo.org address in committer (this was > already enforced) and in Signed-off-by. > > 3. You must use your real name *as stated in LDAP* in Signed-off-by > (committer can be anything). Both regular (cn) and ASCII (gecos) > version is accepted, and the match should be case-insensitive (at > least as far as case-insensitive works in bash). > > If you need to change your real name to match your preferred spelling > (e.g. 'Matt' to 'Matthew'), please ping us as well. > > As a side note, I'd like to repeat that while this is not enforced, > if you merge a copyrightable (i.e. non-trivial) external contribution, > please get Signed-off-by from its author and append yours below it. > remote: 8833535ff8f041d308284149193f5c7322b37b26: no GCO sign-off present remote: e034098e139484cddd1614b55b844898190b21d6: no GCO sign-off present remote: a1c64ac2ac71ef2291d472318d5ffc2218800cd4: no GCO sign-off present remote: 1e846c6372d629171b16282db5ce644577a991fc: no GCO sign-off present remote: e567d8374ec8cbb6f79ac1a3ceef3c71de529d6e: no GCO sign-off present remote: 6131f30065fbff4a50259b81b4e9e88b2ad03661: no GCO sign-off present Please: 0a) Explain to me how to fix my commits that I now can't push, or 0b) disable that hook immediately. 1) Update repoman to enforce it _before_ the commit is executed. 2) Wait for the repoman update to trickle down to all developers. 3) Announce it ahead of time. 4) Re-enable the hook.
Re: [gentoo-dev] [RFC] Removing support for mercurial repos in repositories.xml
On 2018-09-23 22:42, Michał Górny wrote: > Yes, I could add process timeouts. But small timeouts are going to > break the occasional necessity of cloning big repos, and big timeouts > are going to make little difference when Mercurial starts hanging again. > > If someone really cares about this horrible piece of software, I'd > appreciate patches (preferably going upstream) to make it timeout sanely > when something hangs. Otherwise, I'd like to announce discontinuation > of Mercurial support soon. FYI, I send an email to mercurial list to talk about this issue [1]. And it seems that for HTTP connections there is no timeout on the connection. I'm working to provide to the upstream a solution to be able to configure a timeout. [1] https://www.mercurial-scm.org/pipermail/mercurial/2018-September/051003.html -- Cédric Krier signature.asc Description: PGP signature
[gentoo-dev] Signed-off-by verification incoming
Hi, everyone. Just FYI, I'm going to enable the git hook to verify Signed-off-by tags on gentoo.git (most likely all repos later on). I've tested it against all the test cases I could think of but if you have any trouble pushing, please ping me or others in #-infra. Please note that for the hook to work: 1. Every commit must contain 'Signed-off-by' of the committer. 2. You must use your @gentoo.org address in committer (this was already enforced) and in Signed-off-by. 3. You must use your real name *as stated in LDAP* in Signed-off-by (committer can be anything). Both regular (cn) and ASCII (gecos) version is accepted, and the match should be case-insensitive (at least as far as case-insensitive works in bash). If you need to change your real name to match your preferred spelling (e.g. 'Matt' to 'Matthew'), please ping us as well. As a side note, I'd like to repeat that while this is not enforced, if you merge a copyrightable (i.e. non-trivial) external contribution, please get Signed-off-by from its author and append yours below it. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [RFC] Removing support for mercurial repos in repositories.xml
On Fri, 2018-09-28 at 23:44 -0400, desultory wrote: > On 09/27/18 10:21, Michał Górny wrote: > > On Fri, 2018-09-28 at 01:50 +1200, Kent Fredric wrote: > > > On Mon, 24 Sep 2018 07:59:46 +0200 > > > Michał Górny wrote: > > > > > > > I'm against dumb timeouts. Good timeout = die if nothing happens for T. > > > > Bad timeout = die if process doesn't finish for T (yet it may still be > > > > doing something). > > > > > > Could you perhaps adjust it so that when the timeout limit is exceeded, > > > the sync is aborted, and the sync status of that repository is flagged > > > as "bad", and notifies you somehow to fix it manually at your leisure, > > > but otherwise ceases to impede the progress of all the other > > > repositories? > > > > > > And if you're worried that a sync interruption midway could cause a > > > dirty state, maybe you could do an rsync trick where mercurial repos > > > are rsynced into a sandbox location, and then only rsynced back into > > > place on success? > > > > > > This process lets you go "sure, it may be doing something, but it took > > > too long anyway, so we'll let somebody with brains work it out and > > > pretend it was broken in the interim" > > > > No. > > > > Elucidate. My time is better spent elsewhere. You want mercurial, you fix it. This is open source, you can write the patches. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
