Re: [gentoo-dev] [PATCH 05/16] ebuild-writing/misc-files: replace the code for cvs commit with git #558642

2016-01-17 Thread Göktürk Yüksek 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Manuel Rüger:
> On 17.01.2016 08:55, Gokturk Yuksek wrote:
>> Replace "cvs commit" with the equivalent "git add && git commit"
>> version.
>> 
>> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=558642 
>> Signed-off-by: Gokturk Yuksek 
>> 
>> diff --git a/ebuild-writing/misc-files/metadata/text.xml
>> b/ebuild-writing/misc-files/metadata/text.xml index
>> e506b1c..a8beacc 100644 ---
>> a/ebuild-writing/misc-files/metadata/text.xml +++
>> b/ebuild-writing/misc-files/metadata/text.xml @@ -532,7 +532,8 @@
>> is currently:  xmllint --noout --valid metadata.xml 
>> glep31check metadata.xml -cvs commit -m "Adding category
>> metadata.xml for my-category" metadata.xml +git add metadata.xml 
>> +git commit --gpg-sign -m "Adding category metadata.xml for
>> my-category" 
>> 
>> 
>> 
> 
> Can we discourage to use "-m" and prefer to open up an editor
> instead?
> 
I think the purpose of "-m" is only to illustrate the example of
adding a category with a proper message rather than suggesting a
workflow. Note that the section for committing packages suggests
"repoman commit" which opens up an editor by default.

Is there a particular reason why we should discourage the use of "-m"?

> Cheers,
> 
> Manuel
> 

- --
gokturk

-BEGIN PGP SIGNATURE-

iQEcBAEBCgAGBQJWnBQ3AAoJEIT4AuXAiM4zkeUH/AuswPQV3Fw+aeuI08l8xjpx
q+BVZ8c7/5RNqgsQGF/0uKnkZI70WwbkLQwsk2nlHKXjuL5qUWmQ16YBC+fF03SG
JD5eiFhqnzUK79Y5i2Rnfoc2o6DlcLzBSXHXMjtVldg4ufsq+v7mP+Jw901MyJu+
VBY6gkjmkqsahXeaPqmuoXslcr3yQtDHKVU4m9YOptZ/0jTDg4asnvhpv6ERwdNL
uSrO4hzdbh314/o/R/4TWhGV56wlRVUaelzaVwDaBt2wxY5gYyKWhRizN5Exu8/w
BlWSDqwfpKbvHMS2ArrDh0PvvWqEZAMhNuXX2hateO2wQIJlrWZ5KSId5ioW0fw=
=s7Dj
-END PGP SIGNATURE-

Re: [gentoo-dev] [PATCH 05/16] ebuild-writing/misc-files: replace the code for cvs commit with git #558642

2016-01-17 Thread NP-Hardass 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Several reasons for discouraging -m.  Here are two (there may be others)
:
Firstly, with repoman commit, -m prepends "category/pkgname:" which is
the style required as per the git workflow wiki.
Additionally, for both repoman commit and git commit opening in an
editor allows the user to make sure the first line is under 80 chars
and enables the user to more easily conform to the desired format by
having additional information on lines >=3

On 01/17/2016 05:22 PM, Göktürk Yüksek wrote:
> Manuel Rüger:
>> On 17.01.2016 08:55, Gokturk Yuksek wrote:
>>> Replace "cvs commit" with the equivalent "git add && git
>>> commit" version.
>>> 
>>> X-Gentoo-Bug-URL:
>>> https://bugs.gentoo.org/show_bug.cgi?id=558642 Signed-off-by:
>>> Gokturk Yuksek 
>>> 
>>> diff --git a/ebuild-writing/misc-files/metadata/text.xml 
>>> b/ebuild-writing/misc-files/metadata/text.xml index 
>>> e506b1c..a8beacc 100644 --- 
>>> a/ebuild-writing/misc-files/metadata/text.xml +++ 
>>> b/ebuild-writing/misc-files/metadata/text.xml @@ -532,7 +532,8
>>> @@ is currently:  xmllint --noout --valid metadata.xml 
>>> glep31check metadata.xml -cvs commit -m "Adding category 
>>> metadata.xml for my-category" metadata.xml +git add
>>> metadata.xml +git commit --gpg-sign -m "Adding category
>>> metadata.xml for my-category" 
>>> 
>>> 
>>> 
> 
>> Can we discourage to use "-m" and prefer to open up an editor 
>> instead?
> 
> I think the purpose of "-m" is only to illustrate the example of 
> adding a category with a proper message rather than suggesting a 
> workflow. Note that the section for committing packages suggests 
> "repoman commit" which opens up an editor by default.
> 
> Is there a particular reason why we should discourage the use of
> "-m"?
> 
>> Cheers,
> 
>> Manuel
> 
> 
> 

- -- 
NP-Hardass
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJWnCFkAAoJEBzZQR2yrxj7p54P/2gBHfvyEJx59VrMSUZm/ZZi
fzQcOeOjRHWtI1Uz1f15J2eVjq0qQ+B8Wddczsq9Xj70sb8Bgd42B87Im+qo8AmD
2DJVkAveOEOd8UTz6BOkRqksYc2EDHLMv9Nu4ZukAdM56NwNQEfE2du9N/sOVr1D
LAuni26JD2nhIGc749qwUX46gijGEww5gOwNEtMlSS59XeLuYnWSDacxKj19zApM
Zx8HfHlysILT8EkM0HZ73fKEcAfT7ZKbgq2rKlPv4FwogprNcj/IWasD5o9d2d7b
0zFLExdBMGVHGHDc1hu8M8ofFB0B0cRa+3QEJX3hvSxPOqmRtb8E3GAu20JtPJ69
UVivK7CT1qQIaLuIlGC95Ny06ZRLKp5mNQ1Del6pDDJHjs3b2O3P1wTTNH/RuE5V
MZGKQpLojpmNTepOiBbOxfKJjvDhoQ5yzJ7qw0q4K23awRPj5j/5plKt8kwznySH
EBNLqRl8E+Q1BJ91wNJZVtXtOhc0Lu+03cEJ95D1f55sOUdStnjBaMiZAKP3gswa
YWdaRsONtuCx6BEhILdd0lVOnCIz75YwW8Le3DyitLO3Klf9WA2EeYAYmWmiLpas
L6Z7SU1I0M//gJFq1JdeEAZGNoVoVQJBVQ04tM+9VMxijmGdArzdRmye41J+60ZR
ctBkIkyPn5mlmrOp/Qxo
=pg/V
-END PGP SIGNATURE-

Re: [gentoo-dev] [PATCH 05/16] ebuild-writing/misc-files: replace the code for cvs commit with git #558642

2016-01-17 Thread Manuel Rüger 
On 17.01.2016 08:55, Gokturk Yuksek wrote:
> Replace "cvs commit" with the equivalent "git add && git commit" version.
> 
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=558642
> Signed-off-by: Gokturk Yuksek 
> 
> diff --git a/ebuild-writing/misc-files/metadata/text.xml 
> b/ebuild-writing/misc-files/metadata/text.xml
> index e506b1c..a8beacc 100644
> --- a/ebuild-writing/misc-files/metadata/text.xml
> +++ b/ebuild-writing/misc-files/metadata/text.xml
> @@ -532,7 +532,8 @@ is currently:
>  
>  xmllint --noout --valid metadata.xml
>  glep31check metadata.xml
> -cvs commit -m "Adding category metadata.xml for my-category" metadata.xml
> +git add metadata.xml
> +git commit --gpg-sign -m "Adding category metadata.xml for my-category"
>  
>  
>  
> 

Can we discourage to use "-m" and prefer to open up an editor instead?

Cheers,

Manuel



signature.asc
Description: OpenPGP digital signature

[gentoo-dev] [PATCH 05/16] ebuild-writing/misc-files: replace the code for cvs commit with git #558642

2016-01-16 Thread Gokturk Yuksek 
Replace "cvs commit" with the equivalent "git add && git commit" version.

X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=558642
Signed-off-by: Gokturk Yuksek 

diff --git a/ebuild-writing/misc-files/metadata/text.xml 
b/ebuild-writing/misc-files/metadata/text.xml
index e506b1c..a8beacc 100644
--- a/ebuild-writing/misc-files/metadata/text.xml
+++ b/ebuild-writing/misc-files/metadata/text.xml
@@ -532,7 +532,8 @@ is currently:
 
 xmllint --noout --valid metadata.xml
 glep31check metadata.xml
-cvs commit -m "Adding category metadata.xml for my-category" metadata.xml
+git add metadata.xml
+git commit --gpg-sign -m "Adding category metadata.xml for my-category"
 
 
 
-- 
2.4.10