Re: [Geoserver-devel] [Geotools-devel] GeoTools / GeoServer PMC meeting - 2024-01-02
On Thursday, 4 January 2024 10:03:25 AM AEDT Brad Hards wrote: > On Wednesday, 3 January 2024 7:21:43 PM AEDT Andrea Aime wrote: > > If so, it's big (the style part at > > least) but not massive. Looks like a lot of small changes, which would > > fit nicely in my "around one hour a week" typical availability. > > I don't have a good feel for how complete the list is, but at least > the style fixes probably a good estimate. > > I plan to do the style fixes first, then look at inline scripts. > > I can do most of them, but would like help with the "display: none" part, > especially in the base page where there is a comment about using the > feedback spinner as a veil (proxy?) for AJAX interactions. I have no idea > how that works, and its causing noise on every page that derives from it. I have worked through most of the inline styles, and have pushed the results as https://github.com/geoserver/geoserver/pull/7154/commits/ 08e471f3ee537a9522751605566175b0aa4d0e42 > Perhaps Michel who did the initial cleanup of inline styles can offer > perspective? If there is a better way to do any of that, please make it so. The "display:none" part is still to be done. There are a bunch of errors that appear to relate to jquery. I'm not sure why. I haven't done all of the templating module. Perhaps it needs its own CSS file. The GWC disk quota page has some computed style. I don't know how to fix that yet. Brad ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geotools-devel] GeoTools / GeoServer PMC meeting - 2024-01-02
Perhaps Michel who did the initial cleanup of inline styles can offer perspective? -- Jody Garnett On Wed, Jan 3, 2024 at 3:04 PM Brad Hards wrote: > On Wednesday, 3 January 2024 7:21:43 PM AEDT Andrea Aime wrote: > > If so, it's big (the style part at > > least) but not massive. Looks like a lot of small changes, which would > > fit nicely in my "around one hour a week" typical availability. > > I don't have a good feel for how complete the list is, but at least > the style fixes probably a good estimate. > > I plan to do the style fixes first, then look at inline scripts. > > I can do most of them, but would like help with the "display: none" part, > especially in the base page where there is a comment about using the > feedback > spinner as a veil (proxy?) for AJAX interactions. I have no idea how that > works, and its causing noise on every page that derives from it. > > Have dropped a comment in the PR to show the unsafe-inline setting. > > Brad > > > > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geotools-devel] GeoTools / GeoServer PMC meeting - 2024-01-02
On Wednesday, 3 January 2024 7:21:43 PM AEDT Andrea Aime wrote: > If so, it's big (the style part at > least) but not massive. Looks like a lot of small changes, which would > fit nicely in my "around one hour a week" typical availability. I don't have a good feel for how complete the list is, but at least the style fixes probably a good estimate. I plan to do the style fixes first, then look at inline scripts. I can do most of them, but would like help with the "display: none" part, especially in the base page where there is a comment about using the feedback spinner as a veil (proxy?) for AJAX interactions. I have no idea how that works, and its causing noise on every page that derives from it. Have dropped a comment in the PR to show the unsafe-inline setting. Brad ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] osgeo discourse option for mailing list / forum
Looks like osgeo is setting up discourse as a mailing list option when migrating from mailman 2. This can take the place of nabble as a searchable history (for osgeo lists), or operate as a forum - opening up for more casual communication that signing to an email list. How do we feel about that? Do we wish to migrate from sourceforge? -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geotools-devel] GeoTools / GeoServer PMC meeting - 2024-01-02
And of course I forgot the attachment. Here. Cheers Andrea On Wed, Jan 3, 2024 at 9:21 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Ok, let's try to find out how much work that is. > > I believe inline styling can be found this way? > git grep "style\s*=\s*" -- "*.html" > /tmp/style.txt > > Result attached. That's 95 occurrences that need to be removed with > classes in geoserver.css, some like "display:none" can probably > be controlled by code instead (making the wicket component non visible). > > For local scripts, the following returns 17 occurrences: > > > git grep -i " community/gsr/src/main/resources/demos/dynamic_map_layer.html: src="https://js.arcgis.com/4.5/";> > community/gsr/src/main/resources/demos/dynamic_map_layer.html: > community/gsr/src/main/resources/demos/layers-featurelayer-polygon.html: >