Re: [Geotools-devel] Bug when graphic-margin is greater than marker size

2023-12-19 Thread Cécile Vuilleumier 

Good question, yes it works like in CSS and it's mostly handled here:
https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/SLDStyleFactory.java#L1127
https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/VendorOptionParser.java#L114
So in markToTilableImage() the margin is either null or an array of 4 ints

On 12/19/23 4:38 PM, Jody Garnett wrote:
That looks good; and the change to the reference image covers your 
need for a test case.


Question: you assume the margin is an array of 4 numbers.

Does it work like with CSS where an array of a single number, or an 
array of two numbers could be provided?


--
Jody Garnett


On Tue, Dec 19, 2023 at 7:33 AM Cécile Vuilleumier 
 wrote:


Hi all

I am back again on the topic of polygon fill with repeated markers
(see https://osgeo-org.atlassian.net/browse/GEOT-7357)
Unfortunately my fix did introduce an unwanted side effect: if the
given margin is greater than the marker size, an error is thrown
and the layer is not drawn:
org.geotools.renderer.lite: x lies outside raster  -> it happens
on this line



Here is a proposed fix:

https://github.com/vuilleumierc/geotools/commit/b94415a586fdb86a923b072a9ad26af92c83b278

Is it OK for me to open an issue and a PR?

Cheers, Cécile

-- 
*camptocamp*

*Cécile Vuilleumier
*
Geospatial developer
www.camptocamp.com 
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] GeoTools PMC Meeting December 19 2023

2023-12-19 Thread Jody Garnett 
GeoTools / GeoServer PMC meeting - 2023-12-19Attending

   -

   Torben Barsballe
   -

   Kevin Smith
   -

   Andrea Aime
   -

   Gabriel Roldan
   -

   Jody Garnett


Actions from prior meetings:

   -

   Jody: Submit budget + sponsor activities
   

   to board (copy geotools example)
   -

   [DONE] Jody: Make a motion to sponsor Marlin and GISSA 2024

Agenda

   -

   Release 2.23.4 Planning
   -

   OSGeo Budget Request / Sponsorship Opportunities
   -

   GSIP 221 mkdocs
   -

   Java 21 work ongoing
   -

   Use maven CI friendly versions (
   https://maven.apache.org/maven-ci-friendly.html)
   -

   Security Vulnerability Roundup


Actions

   -

   Jody: Call for vote on GSIP 221, plan to update early Jan
   -

   Andrea: warn people about Java 21 build requirements and start merging
   PRs. Also make a GWC 21 PR.

Release 2.23.4 Planning

Looks like we have a volunteer - Peter! Thank you Peter!

He will need backup on GWC (if there are any changes)

   -

   checking: yes an update is needed


OSGeo Budget Request / Sponsorship Opportunities

The OSGeo elections are stalled on communication - so the current board has
not been replaced

   -

   that results in delay for budget communication stuff (sigh)
   -

   We are ready with a request:
   -


  
https://github.com/geoserver/geoserver/wiki/GeoServer-2024-Sponsorship-Opportunities
  -

   OSGeo request is updated to:
   -

  $1000 Operational
  -

  $1000 Security CRA reporting requirements
  -

  $0 AGM Attendance


Jody would like to plan a blog post for January 1st (new calendar year).

   -

   please provide feedback to the list; or contact jody directly with your
   input
   -

   there will be a pull-request for review/feedback

GSIP 221 mkdocs

https://github.com/geoserver/geoserver/wiki/GSIP-221


   -

   There is an example for A/B comparison
   -

   pending: Trying handle |version| or |release| substitutions
   -

   https://github.com/geoserver/geoserver/tree/mkdocs/doc/en/user


Q: Doc freeze?


Yes - a good idea when proposal is accepted

   -

   it is quick to convert as I have script? So can we freeze for 1-2 days
   after successful doc conversion

Q: Do we just want to update main? Or the active branches?

   -

   A: Update the active branches


Q: version selector version VS stable URLs

   -

   A: This is attractive; but we may be able to do it later …


   -

   If we update the active branches we can get a versions/language selector
   
   -

  https://docs.geonetwork-opensource.org/4.2/
  -

  https://docs.geonetwork-opensource.org/4.2/fr/
  -

  https://docs.geonetwork-opensource.org/latest/
  -

   It likes to have a directory structure like this:
   -

  version.json
  

  -

  2.24/
  -

  latest/
  -

  2.23/
  -

  stable/
  -

  2.22/
  -

  maintenance/
  -

   It is optimized for gh-pages deployment, but we have our manual deploy
   process…


Action: Jody will call for a vote on the proposal, plan to doc freeze the
1st week of January
Java 21 work ongoing

https://github.com/geotools/geotools/pull/4591

Q: Allow to Java 21 build to fail?

   -

   A: No, go for broke 


This handles people who just install java … and end up with Java 21.

Q: Why is this working? I thought JAI would break things …

   -

   A: We are not running QA - indeed if we build with Java 17 or Java 21
   the QA will fail
   -

   We compile with Java 11, and then Java 17 and Java 21 will load the
   older classes with less strict requirements


How to go with it? Just go with a warning that code will build with java 21
in the actions.
Use maven CI friendly versions

See https://maven.apache.org/maven-ci-friendly.html

Andrea +1

Requires Maven > 3.5.0

Jenkins is showing two different maven versions:

   -

   3.6.3 in the logs and when ssh’d to the server
   -

   3.9.5 in the web console
   https://build.geoserver.org/manage/configureTools/

We should probably be more consistent here, but in any case Jenkins
supports this tool as-is
Security Vulnerability Roundup

The Coordinated Vulnerability disclosure policy is going fine.

Notes:

   -

   sikeoka has been working on several fixes
   -

   gabe has one to look at
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Bug when graphic-margin is greater than marker size

2023-12-19 Thread Jody Garnett 
That looks good; and the change to the reference image covers your need for
a test case.

Question: you assume the margin is an array of 4 numbers.

Does it work like with CSS where an array of a single number, or an array
of two numbers could be provided?

--
Jody Garnett


On Tue, Dec 19, 2023 at 7:33 AM Cécile Vuilleumier <
cecile.vuilleum...@camptocamp.com> wrote:

> Hi all
>
> I am back again on the topic of polygon fill with repeated markers (see
> https://osgeo-org.atlassian.net/browse/GEOT-7357)
> Unfortunately my fix did introduce an unwanted side effect: if the given
> margin is greater than the marker size, an error is thrown and the layer is
> not drawn:
> org.geotools.renderer.lite: x lies outside raster  -> it happens on this
> line
> 
>
> Here is a proposed fix:
> https://github.com/vuilleumierc/geotools/commit/b94415a586fdb86a923b072a9ad26af92c83b278
>
> Is it OK for me to open an issue and a PR?
>
> Cheers, Cécile
>
> --
> *camptocamp*
>
> *Cécile Vuilleumier *
> Geospatial developer
> www.camptocamp.com
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] Bug when graphic-margin is greater than marker size

2023-12-19 Thread Cécile Vuilleumier 

Hi all

I am back again on the topic of polygon fill with repeated markers (see 
https://osgeo-org.atlassian.net/browse/GEOT-7357)
Unfortunately my fix did introduce an unwanted side effect: if the given 
margin is greater than the marker size, an error is thrown and the layer 
is not drawn:
org.geotools.renderer.lite: x lies outside raster  -> it happens on this 
line 



Here is a proposed fix: 
https://github.com/vuilleumierc/geotools/commit/b94415a586fdb86a923b072a9ad26af92c83b278


Is it OK for me to open an issue and a PR?

Cheers, Cécile
--
*camptocamp*
*Cécile Vuilleumier
*
Geospatial developer
www.camptocamp.com ___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel