Re: [Geotools-devel] Build failed in Jenkins: geotools-master #2562

2018-06-09 Thread Andrea Aime 
Hi Ben,
ah, good to know!
Hopefully no one will commit on January 1st 2020 :-p

Cheers
Andrea

On Sat, Jun 9, 2018 at 11:32 PM, Ben Caradoc-Davies 
wrote:

> Yes, I predicted last week that 
> DefaultTemporalGeometricPrimitiveTest.testDistance
> would file on 9 June 2018. I wrote:
>
> 
>
> There is a logic error in the test! The test assumes that the duration
> from 25 July 1985 from 1 January 2000 (6734 days) is not the same as the
> duration from 1 January 2000 to today. But this happens. Once! I am just
> not sure why it seems to have happened one week early on 2 June 2018.
>
> $ date -u -d "6734 day 12:00 25 July 1981 UTC"
> Sat  1 Jan 12:00:00 UTC 2000
>
> $ date -u -d "6734 day 12:00 1 Jan 2000 UTC"
> Sat  9 Jun 12:00:00 UTC 2018
>
> 
>
> It will work fine tomorrow. I followed identifying a test that will fail
> in 2020:
>
> 
>
> And we can also expect this test to fail on 1 January 2020:
> https://github.com/geotools/geotools/blob/master/modules/lib
> rary/main/src/test/java/org/geotools/temporal/object/Defau
> ltTemporalGeometricPrimitiveTest.java#L95
>
> The last time this test failed in 2012 the fix was to increase the year to
> 2020:
>
> [GEOT-3995] org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest
> fails in 2012
> https://osgeo-org.atlassian.net/browse/GEOT-3995
> https://github.com/geotools/geotools/commit/15aa91e588def1ec
> 9822b0308c9fffb8fff5821d#diff-8f07c1965dae55b7158e9080c79486e5
>
> 
>
> Kind regards,
> Ben.
>
>
> On 10/06/18 01:09, Andrea Aime wrote:
>
>> Hi Ben,
>> didn't you fiddle with this test, or a similar one, lately? Or reported
>> that this failure was about to happen again?
>>
>> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.005
>> sec <<< FAILURE! - in
>> org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest
>> testDistance(org.geotools.temporal.object.DefaultTemporalGeo
>> metricPrimitiveTest)
>>   Time elapsed: 0.005 sec  <<< FAILURE!
>> java.lang.AssertionError: null
>> at org.junit.Assert.fail(Assert.java:86)
>> at org.junit.Assert.assertTrue(Assert.java:41)
>> at org.junit.Assert.assertFalse(Assert.java:64)
>> at org.junit.Assert.assertFalse(Assert.java:74)
>> at org.geotools.temporal.object.DefaultTemporalGeometricPrimiti
>> veTest.testDistance(DefaultTemporalGeometricPrimitiveTest.java:73)
>>
>>
>> Cheers
>> Andrea
>>
>> On Sat, Jun 9, 2018 at 2:52 PM,  wrote:
>>
>> See >> y/redirect?page=changes>
>>>
>>> Changes:
>>>
>>> [Andrea Aime] Switch to explicit formatter checking, instead of local
>>> modification
>>>
>>> --
>>> [...truncated 323.44 KB...]
>>> [INFO] This project has been banned from the build due to previous
>>> failures.
>>> [INFO] 
>>> 
>>> [INFO]
>>>
>>> [INFO] 
>>> 
>>> [INFO] Skipping SWT widgets
>>> [INFO] This project has been banned from the build due to previous
>>> failures.
>>> [INFO] 
>>> 
>>> [INFO]
>>>
>>> [INFO] 
>>> 
>>> [INFO] Skipping Mapbox Styles Support
>>> [INFO] This project has been banned from the build due to previous
>>> failures.
>>> [INFO] 
>>> 
>>> [INFO]
>>>
>>> [INFO] 
>>> 
>>> [INFO] Skipping GRIB gridcoverage module
>>> [INFO] This project has been banned from the build due to previous
>>> failures.
>>> [INFO] 
>>> 
>>> [INFO]
>>>
>>> [INFO] 
>>> 
>>> [INFO] Skipping XML Parsing Support
>>> [INFO] This project has been banned from the build due to previous
>>> failures.
>>> [INFO] 
>>> 
>>> [INFO]
>>>
>>> [INFO] 
>>> 
>>> [INFO] Skipping WPS XML Support
>>> [INFO] This project has been banned from the build due to previous
>>> failures.
>>> [INFO] 
>>> 
>>> [INFO]
>>>
>>> [INFO] 
>>> 
>>> [INFO] Skipping YSLD Parser/Encoder
>>> [INFO] This project has been banned from the build due to previous
>>> failures.
>>> [INFO] 
>>> 
>>> [INFO]
>>>
>>> [INFO] 
>>> 
>>> [INFO] Skipping Cartographic CSS parser
>>> [INFO] This project has been banned from th

Re: [Geotools-devel] Build failed in Jenkins: geotools-master #2562

2018-06-09 Thread Ben Caradoc-Davies 
Yes, I predicted last week that 
DefaultTemporalGeometricPrimitiveTest.testDistance would file on 9 June 
2018. I wrote:




There is a logic error in the test! The test assumes that the duration 
from 25 July 1985 from 1 January 2000 (6734 days) is not the same as the 
duration from 1 January 2000 to today. But this happens. Once! I am just 
not sure why it seems to have happened one week early on 2 June 2018.


$ date -u -d "6734 day 12:00 25 July 1981 UTC"
Sat  1 Jan 12:00:00 UTC 2000

$ date -u -d "6734 day 12:00 1 Jan 2000 UTC"
Sat  9 Jun 12:00:00 UTC 2018



It will work fine tomorrow. I followed identifying a test that will fail 
in 2020:




And we can also expect this test to fail on 1 January 2020:
https://github.com/geotools/geotools/blob/master/modules/library/main/src/test/java/org/geotools/temporal/object/DefaultTemporalGeometricPrimitiveTest.java#L95

The last time this test failed in 2012 the fix was to increase the year 
to 2020:


[GEOT-3995] 
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest fails 
in 2012

https://osgeo-org.atlassian.net/browse/GEOT-3995
https://github.com/geotools/geotools/commit/15aa91e588def1ec9822b0308c9fffb8fff5821d#diff-8f07c1965dae55b7158e9080c79486e5



Kind regards,
Ben.

On 10/06/18 01:09, Andrea Aime wrote:

Hi Ben,
didn't you fiddle with this test, or a similar one, lately? Or reported
that this failure was about to happen again?

Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.005
sec <<< FAILURE! - in
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest
testDistance(org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest)
  Time elapsed: 0.005 sec  <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at 
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest.testDistance(DefaultTemporalGeometricPrimitiveTest.java:73)


Cheers
Andrea

On Sat, Jun 9, 2018 at 2:52 PM,  wrote:


See 

Changes:

[Andrea Aime] Switch to explicit formatter checking, instead of local
modification

--
[...truncated 323.44 KB...]
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping SWT widgets
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping Mapbox Styles Support
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping GRIB gridcoverage module
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping XML Parsing Support
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping WPS XML Support
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping YSLD Parser/Encoder
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping Cartographic CSS parser
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO] Skipping Dynamic symbolizer module based on JFreeChart and Eastwood
[INFO] This project has been banned from the build due to previous
failures.
[INFO] 

[INFO]

[INFO] 

[INFO] Skipping Application Schema Resolver
[INFO] This project has been banned from the build due to previous
failures.
[INFO] ---

Re: [Geotools-devel] Build failed in Jenkins: geotools-master #2562

2018-06-09 Thread Andrea Aime 
Hi Ben,
didn't you fiddle with this test, or a similar one, lately? Or reported
that this failure was about to happen again?

Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.005
sec <<< FAILURE! - in
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest
testDistance(org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest)
 Time elapsed: 0.005 sec  <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at 
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest.testDistance(DefaultTemporalGeometricPrimitiveTest.java:73)


Cheers
Andrea

On Sat, Jun 9, 2018 at 2:52 PM,  wrote:

> See  y/redirect?page=changes>
>
> Changes:
>
> [Andrea Aime] Switch to explicit formatter checking, instead of local
> modification
>
> --
> [...truncated 323.44 KB...]
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping SWT widgets
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping Mapbox Styles Support
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping GRIB gridcoverage module
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping XML Parsing Support
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping WPS XML Support
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping YSLD Parser/Encoder
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping Cartographic CSS parser
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO] Skipping Dynamic symbolizer module based on JFreeChart and Eastwood
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping Application Schema Resolver
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping Web Map Server client
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping Web Processing Service
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping Complex Features Support
> [INFO] This project has been banned from the build due to previous
> failures.
> [INFO] 
> 
> [INFO]
>
> [INFO] 
> 
> [INFO] Skipping Swing widgets
> [INFO] This project h

[Geotools-devel] Build failed in Jenkins: geotools-master #2562

2018-06-09 Thread monitor 
See 


Changes:

[Andrea Aime] Switch to explicit formatter checking, instead of local 
modification

--
[...truncated 323.44 KB...]
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping SWT widgets
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Mapbox Styles Support
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping GRIB gridcoverage module
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping XML Parsing Support
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping WPS XML Support
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping YSLD Parser/Encoder
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Cartographic CSS parser
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] Skipping Dynamic symbolizer module based on JFreeChart and Eastwood
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Application Schema Resolver
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Web Map Server client
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Web Processing Service
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Complex Features Support
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Swing widgets
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] ---