Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:

https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c@182
PS4, Line 182:   * FIXME: this would require having access to the trx_instance,
> Let's do it later in a separate change.
According to the specs (3GPP TS 05.08) the maintenance of both
timing advance and MS power control should be done separately
per each pair of DCCH/TCH and SACCH. This means it would be
good to store both TA and PWR in the corresponding lchans
instead of storing in a single common trx_instance...


https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c@255
PS4, Line 255:  llist_for_each_entry(prim, queue, list) {
> I think it would be more elegant to have a second queue for SACCH so we don't 
> have to scan the (shar […]
It could be done this way, but we would still have the need
to look for the relevant messages within this SACCH queue.

Why? Because a SACCH channel accomplishes either a DCCH,
or a TCH channel, so if one would have a few independent
connections (DCCH and/or TCH), e.g. for testing, then it
is important to distinguish between multiple SACCH channels.



--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 29 Sep 2018 06:19:12 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: gprs_gmm: Fix missing Security Command for 3G when attaching

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/11150 )

Change subject: gprs_gmm: Fix missing Security Command for 3G when attaching
..


Patch Set 1: Code-Review-1


--
To view, visit https://gerrit.osmocom.org/11150
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e12b0a32e58c6f78dba7b548f7d7016567229db
Gerrit-Change-Number: 11150
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sat, 29 Sep 2018 01:22:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Jenkins build is back to normal : master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2860

[jenkins]

See 

Jenkins build is back to normal : master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2860

[jenkins]

See 

Jenkins build is back to normal : master-osmo-bsc » a1=default,a2=default,a3=default,osmocom-master-debian9 #3635

[jenkins]

See 

Jenkins build is back to normal : master-osmo-msc » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #6015

[jenkins]

See 

Jenkins build is back to normal : master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #6015

[jenkins]

See 

Jenkins build is back to normal : master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5868

[jenkins]

See 

Jenkins build is back to normal : master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5868

[jenkins]

See 

Jenkins build is back to normal : master-osmo-mgw » --enable-mgcp-transcoding,a2=default,a3=default,osmocom-master-debian9 #1535

[jenkins]

See 

Jenkins build is back to normal : master-osmo-mgw » --disable-mgcp-transcoding,a2=default,a3=default,osmocom-master-debian9 #1535

[jenkins]

See 

Change in libosmocore[master]: Revert "osmo-config-merge: Add manual page"

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11151 )

Change subject: Revert "osmo-config-merge: Add manual page"
..

Revert "osmo-config-merge: Add manual page"

This reverts commit 6dd00d876e2b947e070f776f90fbb8305a237d21.

Unfortunately, it seems older a2x versions don't support "-D" for
manpage generation:

All the osmocom master builds started to fail with:

make[2]: Entering directory '/build/deps/libosmocore/man'
a2x --doctype manpage --format manpage -D . osmo-config-merge.adoc
a2x: WARNING: --destination-dir option is only applicable to HTML based outputs
a2x: ERROR: "xmllint" --nonet --noout --valid 
"/build/deps/libosmocore/man/osmo-config-merge.xml" returned
non-zero exit status 127
Makefile:545: recipe for target 'osmo-config-merge.8' failed

Change-Id: I0f45362d3e978c328d962a5c0d883eade27b875c
---
M .gitignore
M Makefile.am
M configure.ac
D man/Makefile.am
D man/osmo-config-merge.adoc
5 files changed, 1 insertion(+), 95 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/.gitignore b/.gitignore
index cb2ce68..451c883 100644
--- a/.gitignore
+++ b/.gitignore
@@ -81,7 +81,6 @@
 doc/gb
 doc/html.tar
 doc/*.tag
-man/*.8
 tags

 src/crc*gen.c
diff --git a/Makefile.am b/Makefile.am
index 745d482..de5eb35 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,7 +1,7 @@
 ACLOCAL_AMFLAGS = -I m4

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src src/vty src/codec src/gsm src/coding src/gb src/ctrl 
src/sim src/pseudotalloc utils tests man
+SUBDIRS = include src src/vty src/codec src/gsm src/coding src/gb src/ctrl 
src/sim src/pseudotalloc utils tests

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmocore.pc libosmocodec.pc libosmovty.pc libosmogsm.pc \
diff --git a/configure.ac b/configure.ac
index 529aad1..bc3358a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,19 +77,6 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")

-AC_ARG_ENABLE([man-doc],
- [AS_HELP_STRING([--disable-man-doc], [Disable man page 
documentation])],
- [ BUILD_MAN=$enableval ], [ BUILD_MAN="yes" ])
-
-AS_IF([test "x$BUILD_MAN" = "xyes"], [
-  AC_CHECK_PROG(A2X, [a2x], [yes])
-  AS_IF([test "$A2X" != "yes"],
-   [AC_MSG_ERROR([a2x not found, please install asciidoc or use the
-option --disable-man-doc])])
-])
-AM_CONDITIONAL(BUILD_MAN, test "x$BUILD_MAN" = "xyes")
-AC_SUBST(BUILD_MAN)
-
 # check for syscal fallback on glibc < 2.25 - can be removed once glibc 
version requirement is bumped
 AC_CHECK_DECLS([SYS_getrandom], [], [], [[#include ]])

@@ -383,7 +370,6 @@
libosmoctrl.pc
libosmosim.pc
include/Makefile
-   man/Makefile
src/Makefile
src/vty/Makefile
src/codec/Makefile
diff --git a/man/Makefile.am b/man/Makefile.am
deleted file mode 100644
index b287714..000
--- a/man/Makefile.am
+++ /dev/null
@@ -1,15 +0,0 @@
-if BUILD_MAN
-man_MANS =  osmo-config-merge.8
-endif
-
-ASCIIDOCS = osmo-config-merge.adoc
-
-A2X_OPTS_MANPAGE = --doctype manpage --format manpage -D ${builddir}
-
-%.8 : %.adoc
-   a2x ${A2X_OPTS_MANPAGE} $<
-
-EXTRA_DIST = ${ASCIIDOCS}
-
-CLEANFILES = \
-osmo-config-merge.8
diff --git a/man/osmo-config-merge.adoc b/man/osmo-config-merge.adoc
deleted file mode 100644
index 205fb50..000
--- a/man/osmo-config-merge.adoc
+++ /dev/null
@@ -1,64 +0,0 @@
-osmo-config-merge(8)
-=
-
-NAME
-
-osmo-config-merge - Merge osmocom config snippets into an existing config
-
-SYNOPSIS
-
-[verse]
-*osmo-config-merge*   [--debug]
-
-DESCRIPTION

-This utility allows you to merge an incremental config "patch"
-into an osmocom-style config file.
-
-The patch file follows the same syntax as the original config file.
-
-It works by appending the leaf nodes of the patch file to the respective
-nodes of the input config file.
-
-This process allows configuration file changes/updates to be performed
-in a more stable/reliable way than by means of (unified) diff files,
-as they break every time the context lines break.
-
-osmo-config-merge doesn't suffer from this problem, as it understands
-the tree-like nature of VTY config files.
-
-The resulting config is printed to stdout.
-
-NOTE: This only works with configuration files that have proper
-indenting, i.e. every level in the hierarchy must be indented excatly
-one character, not multiple.
-
-OPTIONS

-*--debug*::
-   Show debugging output when parsing the config tree. Needs to be the 
last argument.
-
-EXAMPLE USAGE
--
-[verse]
-$ osmo-config-merge osmo-msc.cfg.base osmo-msc_change_network.cfg > 
osmo-msc.cfg
-
-EXIT STATUS

-Exit status is 0 if the command was successful, and 1 in case of a
-wrong/missing argument. If

Change in libosmocore[master]: Revert "osmo-config-merge: Add manual page"

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11151 )

Change subject: Revert "osmo-config-merge: Add manual page"
..


Patch Set 1: Verified+1 Code-Review+2

I'm sorry we have to revert the manpage commit as it unfortunately breaks all 
master builds now :(


--
To view, visit https://gerrit.osmocom.org/11151
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f45362d3e978c328d962a5c0d883eade27b875c
Gerrit-Change-Number: 11151
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: daniel 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:44:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Revert "osmo-config-merge: Add manual page"

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/11151


Change subject: Revert "osmo-config-merge: Add manual page"
..

Revert "osmo-config-merge: Add manual page"

This reverts commit 6dd00d876e2b947e070f776f90fbb8305a237d21.

Unfortunately, it seems older a2x versions don't support "-D" for
manpage generation:

All the osmocom master builds started to fail with:

make[2]: Entering directory '/build/deps/libosmocore/man'
a2x --doctype manpage --format manpage -D . osmo-config-merge.adoc
a2x: WARNING: --destination-dir option is only applicable to HTML based outputs
a2x: ERROR: "xmllint" --nonet --noout --valid 
"/build/deps/libosmocore/man/osmo-config-merge.xml" returned
non-zero exit status 127
Makefile:545: recipe for target 'osmo-config-merge.8' failed

Change-Id: I0f45362d3e978c328d962a5c0d883eade27b875c
---
M .gitignore
M Makefile.am
M configure.ac
D man/Makefile.am
D man/osmo-config-merge.adoc
5 files changed, 1 insertion(+), 95 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/11151/1

diff --git a/.gitignore b/.gitignore
index cb2ce68..451c883 100644
--- a/.gitignore
+++ b/.gitignore
@@ -81,7 +81,6 @@
 doc/gb
 doc/html.tar
 doc/*.tag
-man/*.8
 tags

 src/crc*gen.c
diff --git a/Makefile.am b/Makefile.am
index 745d482..de5eb35 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,7 +1,7 @@
 ACLOCAL_AMFLAGS = -I m4

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src src/vty src/codec src/gsm src/coding src/gb src/ctrl 
src/sim src/pseudotalloc utils tests man
+SUBDIRS = include src src/vty src/codec src/gsm src/coding src/gb src/ctrl 
src/sim src/pseudotalloc utils tests

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmocore.pc libosmocodec.pc libosmovty.pc libosmogsm.pc \
diff --git a/configure.ac b/configure.ac
index 529aad1..bc3358a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,19 +77,6 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")

-AC_ARG_ENABLE([man-doc],
- [AS_HELP_STRING([--disable-man-doc], [Disable man page 
documentation])],
- [ BUILD_MAN=$enableval ], [ BUILD_MAN="yes" ])
-
-AS_IF([test "x$BUILD_MAN" = "xyes"], [
-  AC_CHECK_PROG(A2X, [a2x], [yes])
-  AS_IF([test "$A2X" != "yes"],
-   [AC_MSG_ERROR([a2x not found, please install asciidoc or use the
-option --disable-man-doc])])
-])
-AM_CONDITIONAL(BUILD_MAN, test "x$BUILD_MAN" = "xyes")
-AC_SUBST(BUILD_MAN)
-
 # check for syscal fallback on glibc < 2.25 - can be removed once glibc 
version requirement is bumped
 AC_CHECK_DECLS([SYS_getrandom], [], [], [[#include ]])

@@ -383,7 +370,6 @@
libosmoctrl.pc
libosmosim.pc
include/Makefile
-   man/Makefile
src/Makefile
src/vty/Makefile
src/codec/Makefile
diff --git a/man/Makefile.am b/man/Makefile.am
deleted file mode 100644
index b287714..000
--- a/man/Makefile.am
+++ /dev/null
@@ -1,15 +0,0 @@
-if BUILD_MAN
-man_MANS =  osmo-config-merge.8
-endif
-
-ASCIIDOCS = osmo-config-merge.adoc
-
-A2X_OPTS_MANPAGE = --doctype manpage --format manpage -D ${builddir}
-
-%.8 : %.adoc
-   a2x ${A2X_OPTS_MANPAGE} $<
-
-EXTRA_DIST = ${ASCIIDOCS}
-
-CLEANFILES = \
-osmo-config-merge.8
diff --git a/man/osmo-config-merge.adoc b/man/osmo-config-merge.adoc
deleted file mode 100644
index 205fb50..000
--- a/man/osmo-config-merge.adoc
+++ /dev/null
@@ -1,64 +0,0 @@
-osmo-config-merge(8)
-=
-
-NAME
-
-osmo-config-merge - Merge osmocom config snippets into an existing config
-
-SYNOPSIS
-
-[verse]
-*osmo-config-merge*   [--debug]
-
-DESCRIPTION

-This utility allows you to merge an incremental config "patch"
-into an osmocom-style config file.
-
-The patch file follows the same syntax as the original config file.
-
-It works by appending the leaf nodes of the patch file to the respective
-nodes of the input config file.
-
-This process allows configuration file changes/updates to be performed
-in a more stable/reliable way than by means of (unified) diff files,
-as they break every time the context lines break.
-
-osmo-config-merge doesn't suffer from this problem, as it understands
-the tree-like nature of VTY config files.
-
-The resulting config is printed to stdout.
-
-NOTE: This only works with configuration files that have proper
-indenting, i.e. every level in the hierarchy must be indented excatly
-one character, not multiple.
-
-OPTIONS

-*--debug*::
-   Show debugging output when parsing the config tree. Needs to be the 
last argument.
-
-EXAMPLE USAGE
--
-[verse]
-$ osmo-config-merge osmo-msc.cfg.base osmo-msc_change_network.cfg > 
osmo-msc.cfg
-
-EXIT STATUS

-Exit status is 0 if the command was successful, and 1 in case of a
-wrong/missing argumen

Change in docker-playground[master]: ttcn3-sgsn-test: save the log file to appear in the artifacts.

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11013 )

Change subject: ttcn3-sgsn-test: save the log file to appear in the artifacts.
..


Patch Set 3: Verified+1


--
To view, visit https://gerrit.osmocom.org/11013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06d0ad6f980e5800f65a128cd33d6937c47afa9
Gerrit-Change-Number: 11013
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:30:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-sgsn-test: save the log file to appear in the artifacts.

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11013 )

Change subject: ttcn3-sgsn-test: save the log file to appear in the artifacts.
..

ttcn3-sgsn-test: save the log file to appear in the artifacts.

The sgsn does not save anywhere it's logfile.

Change-Id: Ie06d0ad6f980e5800f65a128cd33d6937c47afa9
---
M ttcn3-sgsn-test/osmo-sgsn.cfg
1 file changed, 38 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/ttcn3-sgsn-test/osmo-sgsn.cfg b/ttcn3-sgsn-test/osmo-sgsn.cfg
index 20dea6e..72ca46d 100644
--- a/ttcn3-sgsn-test/osmo-sgsn.cfg
+++ b/ttcn3-sgsn-test/osmo-sgsn.cfg
@@ -40,6 +40,44 @@
  logging level lm3ua notice
  logging level lmgcp notice
 !
+log file sgsn-raw.log
+  logging filter all 1
+  logging color 0
+  logging print category 1
+  logging timestamp 1
+  logging print file 1
+  logging level all everything
+  logging level mm debug
+  logging level pag notice
+  logging level meas notice
+  logging level ref notice
+  logging level gprs debug
+  logging level ns info
+  logging level bssgp info
+  logging level llc debug
+  logging level sndcp debug
+  logging level slhc notice
+  logging level ranap info
+  logging level sua info
+  logging level v42bis info
+  logging level lglobal info
+  logging level llapd notice
+  logging level linp notice
+  logging level lmux notice
+  logging level lmi notice
+  logging level lmib notice
+  logging level lsms notice
+  logging level lctrl notice
+  logging level lgtp debug
+  logging level lstats notice
+  logging level lgsup debug
+  logging level loap notice
+  logging level lss7 notice
+  logging level lsccp info
+  logging level lsua notice
+  logging level lm3ua notice
+  logging level lmgcp notice
+!
 stats interval 5
 !
 line vty

--
To view, visit https://gerrit.osmocom.org/11013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie06d0ad6f980e5800f65a128cd33d6937c47afa9
Gerrit-Change-Number: 11013
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: lynxis lazus 

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5867

[jenkins]

See 


Changes:

[laforge] gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests NET_FAIL

--
[...truncated 43.58 KB...]
  CC   gsm0503_mapping.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_ns.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp.lo
  CC   common_vty.lo
  CC   gprs_bssgp_bss.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bi

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5867

[jenkins]

See 


Changes:

[laforge] gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests NET_FAIL

--
[...truncated 42.83 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_bssgp.lo
  CC   gprs_ns_vty.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_bss.lo
  CC   gprs_bssgp_vty.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bi

Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr

[Harald Welte]

Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/10452 )

Change subject: sdp: remove htonl() from in_addr
..


Abandoned

we have now merged a change to osmo-msc to be compatible with nitb and 
osmo-sip-connector.
--
To view, visit https://gerrit.osmocom.org/10452
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806
Gerrit-Change-Number: 10452
Gerrit-PatchSet: 2
Gerrit-Owner: Tobias Mädel (manawyrm) 
Gerrit-Reviewer: Keith Whyte 
Gerrit-Reviewer: Tobias Mädel (manawyrm) 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: kamilner 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Harald Welte 

Change in osmo-tetra[master]: add traffic dumping patch, use getopt to parse arguments

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10264 )

Change subject: add traffic dumping patch, use getopt to parse arguments
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10264
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94135753a76cadfa373167ffca18e89bee5bcff8
Gerrit-Change-Number: 10264
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Hrach 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:27:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-tetra[master]: add traffic dumping patch, use getopt to parse arguments

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10264 )

Change subject: add traffic dumping patch, use getopt to parse arguments
..

add traffic dumping patch, use getopt to parse arguments

Enable the user to specify a directory, where contents of traffic channel will
be saved. Together with this dump, a text file with SSIs of the engaged
stations is saved too.

Based on 0004-HACK-Quick-hack-to-save-the-speech-data-from-TCH.patch available 
at
https://build.opensuse.org/package/view_file/home:mnhauke:sdr/osmo-tetra/0004-HACK-Quick-hack-to-save-the-speech-data-from-TCH.patch

Change-Id: I94135753a76cadfa373167ffca18e89bee5bcff8
---
M src/lower_mac/tetra_lower_mac.c
M src/tetra-rx.c
M src/tetra_common.h
M src/tetra_gsmtap.c
M src/tetra_gsmtap.h
M src/tetra_upper_mac.c
6 files changed, 84 insertions(+), 22 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/lower_mac/tetra_lower_mac.c b/src/lower_mac/tetra_lower_mac.c
index 1e8f2e8..d6f9e41 100644
--- a/src/lower_mac/tetra_lower_mac.c
+++ b/src/lower_mac/tetra_lower_mac.c
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -184,6 +185,48 @@
DEBUGP("%s %s type4: %s\n", tbp->name, time_str,
osmo_ubit_dump(type4, tbp->type345_bits));

+   /* If this is a traffic channel, dump. */
+   if ((type == TPSAP_T_SCH_F) && tms->cur_burst.is_traffic && 
tms->dumpdir) {
+   char fname[PATH_MAX];
+   int16_t block[690];
+   FILE *f;
+   int i;
+
+   /* Open target file */
+   snprintf(fname, sizeof(fname), "%s/traffic_%d_%d.out", 
tms->dumpdir,
+   tms->cur_burst.is_traffic, tms->tsn);
+   f = fopen(fname, "ab");
+
+   /* Generate a block */
+   memset(block, 0x00, sizeof(int16_t) * 690);
+   for (i = 0; i < 6; i++)
+   block[115*i] = 0x6b21 + i;
+
+   for (i = 0; i < 114; i++)
+   block[1+i] = type4[i] ? -127 : 127;
+
+   for (i = 0; i < 114; i++)
+   block[116+i] = type4[114+i] ? -127 : 127;
+
+   for (i = 0; i < 114; i++)
+   block[231+i] = type4[228+i] ? -127 : 127;
+
+   for (i = 0; i < 90; i++)
+   block[346+i] = type4[342+i] ? -127 : 127;
+
+   /* Write it */
+   fwrite(block, sizeof(int16_t), 690, f);
+
+   fclose(f);
+
+   /* Write used ssi */
+   snprintf(fname, sizeof(fname), "%s/traffic_%d_%d.txt", 
tms->dumpdir,
+   tms->cur_burst.is_traffic, tms->tsn);
+   f = fopen(fname, "a");
+   fprintf(f, "%d\n", tms->ssi);
+   fclose(f);
+   }
+
if (tbp->interleave_a) {
/* Run block deinterleaving: type-3 bits */
block_deinterleave(tbp->type345_bits, tbp->interleave_a, type4, 
type3);
diff --git a/src/tetra-rx.c b/src/tetra-rx.c
index c751772..ed4d252 100644
--- a/src/tetra-rx.c
+++ b/src/tetra-rx.c
@@ -39,28 +39,39 @@
 int main(int argc, char **argv)
 {
int fd;
+   int opt;
struct tetra_rx_state *trs;
struct tetra_mac_state *tms;

-   if (argc < 2) {
-   fprintf(stderr, "Usage: %s \n", 
argv[0]);
-   exit(1);
-   }
-
-   fd = open(argv[1], O_RDONLY);
-   if (fd < 0) {
-   perror("open");
-   exit(2);
-   }
-
-   tetra_gsmtap_init("localhost", 0);
-
tms = talloc_zero(tetra_tall_ctx, struct tetra_mac_state);
tetra_mac_state_init(tms);

trs = talloc_zero(tetra_tall_ctx, struct tetra_rx_state);
trs->burst_cb_priv = tms;

+   while ((opt = getopt(argc, argv, "d:")) != -1) {
+   switch (opt) {
+   case 'd':
+   tms->dumpdir = strdup(optarg);
+   break;
+   default:
+   fprintf(stderr, "Unknown option %c\n", opt);
+   }
+   }
+
+   if (argc <= optind) {
+   fprintf(stderr, "Usage: %s [-d DUMPDIR] 
\n", argv[0]);
+   exit(1);
+   }
+
+   fd = open(argv[optind], O_RDONLY);
+   if (fd < 0) {
+   perror("open");
+   exit(2);
+   }
+
+   tetra_gsmtap_init("localhost", 0);
+
while (1) {
uint8_t buf[64];
int len;
@@ -76,6 +87,7 @@
tetra_burst_sync_in(trs, buf, len);
}

+   free(tms->dumpdir);
talloc_free(trs);
talloc_free(tms);

diff --git a/src/tetra_common.h b/src/tetra_common.h
index 3207c0d..d141e9b 100644
--- a/src/tetra_common.h
+++ b/src/tetra_common.h
@@ -47,7 +47,11 @@
struct {

Change in osmo-sgsn[master]: gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests NET_FAIL

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10033 )

Change subject: gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests 
NET_FAIL
..

gprs_gmm: dont answer unknown IMSI/TMSI on Service Requests NET_FAIL

NET_FAIL will result in asking again and again. Reject with IMPL_DETACHED to 
drop the
MS completely.

Change-Id: I195d533e330a4b577cad80c7e757d481f9c837df
---
M src/gprs/gprs_gmm.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index a363c70..a86fe2b 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1862,7 +1862,7 @@
ctx = sgsn_mm_ctx_by_imsi(mi_string);
if (!ctx) {
/* FIXME: We need to have a context for service 
request? */
-   reject_cause = GMM_CAUSE_NET_FAIL;
+   reject_cause = GMM_CAUSE_IMPL_DETACHED;
goto rejected;
}
msgid2mmctx(ctx, msg);
@@ -1875,7 +1875,7 @@
ctx = sgsn_mm_ctx_by_ptmsi(tmsi);
if (!ctx) {
/* FIXME: We need to have a context for service 
request? */
-   reject_cause = GMM_CAUSE_NET_FAIL;
+   reject_cause = GMM_CAUSE_IMPL_DETACHED;
goto rejected;
}
msgid2mmctx(ctx, msg);

--
To view, visit https://gerrit.osmocom.org/10033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I195d533e330a4b577cad80c7e757d481f9c837df
Gerrit-Change-Number: 10033
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: lynxis lazus 

Build failed in Jenkins: master-osmo-bsc » a1=default,a2=default,a3=default,osmocom-master-debian9 #3634

[jenkins]

See 


Changes:

[laforge] fix unaligned access in abis_nm_rx_ipacc()

--
[...truncated 35.06 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build

Change in libosmocore[master]: use reasonable value if PATH_MAX is not defined

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9202 )

Change subject: use reasonable value if PATH_MAX is not defined
..


Patch Set 1:

any interest in reworking this as suggested?


--
To view, visit https://gerrit.osmocom.org/9202
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia884f4c96b4c4eaa1a1be256e3ccda0b4dec4099
Gerrit-Change-Number: 9202
Gerrit-PatchSet: 1
Gerrit-Owner: Thorsten Alteholz 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:20:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: regen_docs: Add a script that extracts counter and vty info

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10273 )

Change subject: regen_docs: Add a script that extracts counter and vty info
..


Patch Set 1: Code-Review-1

now that we have osmo-config-merge, this patch could be rewritten in a more 
stable way by not containing full config files but only those few parameters 
that actually matter in terms of config extraction


--
To view, visit https://gerrit.osmocom.org/10273
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e57a64caccfbc982199f8f25bbb14c2d96e11a6
Gerrit-Change-Number: 10273
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:19:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: fix unaligned access in abis_nm_rx_ipacc()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10645 )

Change subject: fix unaligned access in abis_nm_rx_ipacc()
..

fix unaligned access in abis_nm_rx_ipacc()

Related: OS#3496
Change-Id: Ia9bdce39472719bfebec29e0a55a021ef45c8ea6
---
M src/osmo-bsc/abis_nm.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 4757c72..7f919a4 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -2662,9 +2663,7 @@
DEBUGPC(DNM, "IP=%s ", inet_ntoa(addr));
}
if (TLVP_PRESENT(&tp, NM_ATT_IPACC_DST_IP_PORT))
-   DEBUGPC(DNM, "PORT=%u ",
-   ntohs(*((uint16_t *)
-   TLVP_VAL(&tp, 
NM_ATT_IPACC_DST_IP_PORT;
+   DEBUGPC(DNM, "PORT=%" SCNu16 " ", 
osmo_load16be(TLVP_VAL(&tp, NM_ATT_IPACC_DST_IP_PORT)));
if (TLVP_PRESENT(&tp, NM_ATT_IPACC_STREAM_ID))
DEBUGPC(DNM, "STREAM=0x%02x ",
*TLVP_VAL(&tp, NM_ATT_IPACC_STREAM_ID));

--
To view, visit https://gerrit.osmocom.org/10645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9bdce39472719bfebec29e0a55a021ef45c8ea6
Gerrit-Change-Number: 10645
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-bsc[master]: fix unaligned access in abis_nm_rx_ipacc()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10645 )

Change subject: fix unaligned access in abis_nm_rx_ipacc()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9bdce39472719bfebec29e0a55a021ef45c8ea6
Gerrit-Change-Number: 10645
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:18:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Use pthread_setname_np to name threads

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11047 )

Change subject: Use pthread_setname_np to name threads
..

Use pthread_setname_np to name threads

osmo-trx can start a considerable amount of threads that can make
debugging it challenging at least. By using phtread_setname_np, the
system sets a meaningful name to the thread which can be seen while
debugging with gdb or by printing /proc/$pid/task/$tid/comm.

Now we also log system TID when setting the name so we can identify
different tasks in /proc even if pthread_setname_np fails.

Change-Id: I84711739c3e224cb383fd12b6db933785b28209e
---
M CommonLibs/Threads.cpp
M CommonLibs/Threads.h
M Transceiver52M/Transceiver.cpp
M Transceiver52M/device/uhd/UHDDevice.cpp
M Transceiver52M/radioInterface.cpp
M tests/CommonLibs/Makefile.am
6 files changed, 43 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/CommonLibs/Threads.cpp b/CommonLibs/Threads.cpp
index de6520b..2988e12 100644
--- a/CommonLibs/Threads.cpp
+++ b/CommonLibs/Threads.cpp
@@ -24,11 +24,17 @@
 */


-
-
+#include 
+#include 

 #include "Threads.h"
 #include "Timeval.h"
+#include "Logger.h"
+
+#ifndef gettid
+#include 
+#define gettid() syscall(SYS_gettid)
+#endif


 using namespace std;
@@ -102,6 +108,19 @@
pthread_cond_timedwait(&mSignal,&wMutex.mMutex,&waitTime);
 }

+void set_selfthread_name(const char *name)
+{
+   pthread_t selfid = pthread_self();
+   pid_t tid = gettid();
+   if (pthread_setname_np(selfid, name) == 0) {
+   LOG(INFO) << "Thread "<< selfid << " (task " << tid << ") set 
name: " << name;
+   } else {
+   char buf[256];
+   int err = errno;
+   char* err_str = strerror_r(err, buf, sizeof(buf));
+   LOG(NOTICE) << "Thread "<< selfid << " (task " << tid << ") set 
name \"" << name << "\" failed: (" << err << ") " << err_str;
+   }
+}

 void Thread::start(void *(*task)(void*), void *arg)
 {
diff --git a/CommonLibs/Threads.h b/CommonLibs/Threads.h
index 47c7275..857c5d9 100644
--- a/CommonLibs/Threads.h
+++ b/CommonLibs/Threads.h
@@ -141,6 +141,8 @@
 #define START_THREAD(thread,function,argument) \
thread.start((void *(*)(void*))function, (void*)argument);

+void set_selfthread_name(const char *name);
+
 /** A C++ wrapper for pthread threads.  */
 class Thread {

diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index cdfd79d..076db3e 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -1044,11 +1044,15 @@

 void *RxUpperLoopAdapter(TransceiverChannel *chan)
 {
+  char thread_name[16];
   Transceiver *trx = chan->trx;
   size_t num = chan->num;

   delete chan;

+  snprintf(thread_name, 16, "RxUpper%zu", num);
+  set_selfthread_name(thread_name);
+
   trx->setPriority(0.42);

   while (1) {
@@ -1060,6 +1064,8 @@

 void *RxLowerLoopAdapter(Transceiver *transceiver)
 {
+  set_selfthread_name("RxLower");
+
   transceiver->setPriority(0.45);

   while (1) {
@@ -1071,6 +1077,8 @@

 void *TxLowerLoopAdapter(Transceiver *transceiver)
 {
+  set_selfthread_name("TxLower");
+
   transceiver->setPriority(0.44);

   while (1) {
@@ -1082,11 +1090,15 @@

 void *ControlServiceLoopAdapter(TransceiverChannel *chan)
 {
+  char thread_name[16];
   Transceiver *trx = chan->trx;
   size_t num = chan->num;

   delete chan;

+  snprintf(thread_name, 16, "CtrlService%zu", num);
+  set_selfthread_name(thread_name);
+
   while (1) {
 trx->driveControl(num);
 pthread_testcancel();
@@ -1096,11 +1108,15 @@

 void *TxUpperLoopAdapter(TransceiverChannel *chan)
 {
+  char thread_name[16];
   Transceiver *trx = chan->trx;
   size_t num = chan->num;

   delete chan;

+  snprintf(thread_name, 16, "TxUpper%zu", num);
+  set_selfthread_name(thread_name);
+
   trx->setPriority(0.40);

   while (1) {
diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp 
b/Transceiver52M/device/uhd/UHDDevice.cpp
index b7109a4..c30f3a7 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -322,6 +322,7 @@

 void *async_event_loop(uhd_device *dev)
 {
+   set_selfthread_name("UHDAsyncEvent");
dev->setPriority(0.43);

while (1) {
diff --git a/Transceiver52M/radioInterface.cpp 
b/Transceiver52M/radioInterface.cpp
index 7d6a03b..0f949d7 100644
--- a/Transceiver52M/radioInterface.cpp
+++ b/Transceiver52M/radioInterface.cpp
@@ -148,6 +148,7 @@
 /** synchronization thread loop */
 void *AlignRadioServiceLoopAdapter(RadioInterface *radioInterface)
 {
+  set_selfthread_name("AlignRadio");
   while (1) {
 sleep(60);
 radioInterface->alignRadio();
diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am
index 4543c72..2a9a021 100644
--- a/tests/Co

Change in osmo-trx[master]: Use pthread_setname_np to name threads

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11047 )

Change subject: Use pthread_setname_np to name threads
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84711739c3e224cb383fd12b6db933785b28209e
Gerrit-Change-Number: 11047
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:17:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: gprs_gmm: Fix missing Security Command for 3G when attaching

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/11150


Change subject: gprs_gmm: Fix missing Security Command for 3G when attaching
..

gprs_gmm: Fix missing Security Command for 3G when attaching

Introduce a new FSM step in GMM Attach to send the
Security Command to the RNC after completing the
Authentication.

Fixes: f7198d7dbb84 ("gprs_gmm: introduce a GMM Attach Request FSM")
Change-Id: I1e12b0a32e58c6f78dba7b548f7d7016567229db
---
M include/osmocom/sgsn/gprs_gmm_attach.h
M src/gprs/gprs_gmm.c
M src/gprs/gprs_gmm_attach.c
3 files changed, 43 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/50/11150/1

diff --git a/include/osmocom/sgsn/gprs_gmm_attach.h 
b/include/osmocom/sgsn/gprs_gmm_attach.h
index 22fbd6f..0aa2123 100644
--- a/include/osmocom/sgsn/gprs_gmm_attach.h
+++ b/include/osmocom/sgsn/gprs_gmm_attach.h
@@ -11,6 +11,7 @@
ST_RETRIEVE_AUTH,
ST_AUTH,
ST_ASK_VLR,
+   ST_IU_SECURITY_CMD,
ST_ACCEPT,
ST_REJECT
 };
@@ -20,6 +21,7 @@
E_IDEN_RESP_RECV,
E_AUTH_RESP_RECV_SUCCESS,
E_AUTH_RESP_RECV_RESYNC,
+   E_IU_SECURITY_CMD_COMPLETE,
E_ATTACH_ACCEPTED,
E_ATTACH_ACCEPT_SENT,
E_ATTACH_COMPLETE_RECV,
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index a363c70..9dad9a7 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -205,7 +205,7 @@
REQUIRE_MM
/* Continue authentication here */
mm->iu.ue_ctx->integrity_active = 1;
-   rc = gsm48_gmm_authorize(mm);
+   osmo_fsm_inst_dispatch(mm->gmm_att_req.fsm, 
E_IU_SECURITY_CMD_COMPLETE, NULL);
break;
default:
LOGP(DRANAP, LOGL_NOTICE, "Unknown event received: %i\n", type);
diff --git a/src/gprs/gprs_gmm_attach.c b/src/gprs/gprs_gmm_attach.c
index 272fec7..e77faa4 100644
--- a/src/gprs/gprs_gmm_attach.c
+++ b/src/gprs/gprs_gmm_attach.c
@@ -157,7 +157,11 @@
switch (event) {
case E_AUTH_RESP_RECV_SUCCESS:
sgsn_auth_request(ctx);
-   osmo_fsm_inst_state_chg(fi, ST_ACCEPT, sgsn->cfg.timers.T3350, 
3350);
+   if (ctx->ran_type == MM_CTX_T_UTRAN_Iu && 
!ctx->iu.ue_ctx->integrity_active) {
+   osmo_fsm_inst_state_chg(fi, ST_IU_SECURITY_CMD, 
sgsn->cfg.timers.T3350, 3350);
+   } else {
+   osmo_fsm_inst_state_chg(fi, ST_ACCEPT, 
sgsn->cfg.timers.T3350, 3350);
+   }
break;
case E_AUTH_RESP_RECV_RESYNC:
if (ctx->gmm_att_req.auth_reattempt <= 1)
@@ -228,6 +232,32 @@
}
 }

+static void st_iu_security_cmd_on_enter(struct osmo_fsm_inst *fi, uint32_t 
prev_state)
+{
+#ifdef BUILD_IU
+   struct sgsn_mm_ctx *ctx = fi->priv;
+   int rc = 0;
+
+   /* TODO: shouldn't this set always? not only when the integrity_active? 
*/
+   if (ctx->iu.ue_ctx->integrity_active) {
+   osmo_fsm_inst_state_chg(fi, ST_ACCEPT, sgsn->cfg.timers.T3350, 
3350);
+   return;
+   }
+
+   ranap_iu_tx_sec_mode_cmd(ctx->iu.ue_ctx, &ctx->auth_triplet.vec, 0, 
ctx->iu.new_key);
+   ctx->iu.new_key = 0;
+#endif
+}
+
+static void st_iu_security_cmd(struct osmo_fsm_inst *fi, uint32_t event, void 
*data)
+{
+   switch(event) {
+   case E_IU_SECURITY_CMD_COMPLETE:
+   osmo_fsm_inst_state_chg(fi, ST_ACCEPT, sgsn->cfg.timers.T3350, 
3350);
+   break;
+   }
+}
+
 static struct osmo_fsm_state gmm_attach_req_fsm_states[] = {
/* default state for non-DTX and DTX when SPEECH is in progress */
[ST_INIT] = {
@@ -252,11 +282,18 @@
},
[ST_AUTH] = {
.in_event_mask = X(E_AUTH_RESP_RECV_SUCCESS) | 
X(E_AUTH_RESP_RECV_RESYNC),
-   .out_state_mask = X(ST_INIT) | X(ST_AUTH) | X(ST_ACCEPT) | 
X(ST_ASK_VLR) | X(ST_REJECT),
+   .out_state_mask = X(ST_INIT) | X(ST_AUTH) | 
X(ST_IU_SECURITY_CMD) | X(ST_ACCEPT) | X(ST_ASK_VLR) | X(ST_REJECT),
.name = "Authenticate",
.onenter = st_auth_on_enter,
.action = st_auth,
},
+   [ST_IU_SECURITY_CMD] = {
+   .in_event_mask = X(E_IU_SECURITY_CMD_COMPLETE),
+   .out_state_mask = X(ST_INIT) | X(ST_AUTH) | X(ST_ACCEPT) | 
X(ST_REJECT),
+   .name = "IuSecurityCommand",
+   .onenter = st_iu_security_cmd_on_enter,
+   .action = st_iu_security_cmd,
+   },
[ST_ACCEPT] = {
.in_event_mask = X(E_ATTACH_COMPLETE_RECV),
.out_state_mask = X(ST_INIT) | X(ST_REJECT),
@@ -280,6 +317,7 @@
{ E_ATTACH_ACCEPTED,"Attach accepted" },
{ E_ATTACH_ACCEPT_SENT, "Attach accept sent" },
{ E_ATTACH_COMPLETE_RECV,   "Attach complete rec

Change in osmo-gsm-tester[master]: ttcn3: BTS_Tests.cfg.tmpl: Use tolerance parameters

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11102 )

Change subject: ttcn3: BTS_Tests.cfg.tmpl: Use tolerance parameters
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11102
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e28d7c011f466d0eb2127f61032978c4e0bf16d
Gerrit-Change-Number: 11102
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:16:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-msc » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #6014

[jenkins]

See 


Changes:

[Stefan Sperling] fix a use-after-free in msc_mgcp.c:_handle_error()

--
[...truncated 39.66 KB...]
  CC   gsm0503_parity.lo
  CC   gsm0503_tables.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..

trxcon/scheduler: fix Measurement Reporting on SACCH

According to 3GPP TS 04.08, section 3.4.1, SACCH logical channel
accompanies either a traffic or a signaling channel. It has the
particularity that continuous transmission must occur in both
directions, so on the Uplink direction measurement result messages
are sent at each possible occasion when nothing else has to be sent.
The LAPDm fill frames (0x01, 0x03, 0x01, 0x2b, ...) are not
applicable on SACCH channels!

Unfortunately, 3GPP TS 04.08 doesn't clearly state which "else
messages" besides Measurement Reports can be send by the MS on
SACCH channels. However, in sub-clause 3.4.1 it's stated that
the interval between two successive measurement result messages
shall not exceed one L2 frame.

This change introduces a separate handler for SACCH primitives,
which dequeues a SACCH primitive from transmit queue, if present.
Otherwise it dequeues a cached Measurement Report (the last
received one). Finally, if the cache is empty, a "dummy"
measurement report is used. When it's possible,
a non-MR primitive is prioritized.

Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Related: OS#2988
---
M src/host/trxcon/sched_prim.c
M src/host/trxcon/sched_trx.c
M src/host/trxcon/sched_trx.h
3 files changed, 211 insertions(+), 14 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c
index 2067900..275a050 100644
--- a/src/host/trxcon/sched_prim.c
+++ b/src/host/trxcon/sched_prim.c
@@ -122,6 +122,194 @@
return 0;
 }

+/**
+ * Composes a new primitive using either cached (if populated),
+ * or "dummy" Measurement Report message.
+ *
+ * @param  lchan lchan to assign a primitive
+ * @return   SACCH primitive to be transmitted
+ */
+static struct trx_ts_prim *prim_compose_mr(struct trx_lchan_state *lchan)
+{
+   struct trx_ts_prim *prim;
+   uint8_t *mr_src_ptr;
+   bool cached;
+   int rc;
+
+   /* "Dummy" Measurement Report */
+   static const uint8_t meas_rep_dummy[] = {
+   /* L1 SACCH pseudo-header */
+   0x0f, 0x00,
+
+   /* LAPDm header */
+   0x01, 0x03, 0x49,
+
+   /* Measurement report */
+   0x06, 0x15, 0x36, 0x36, 0x01, 0xC0,
+
+   /* TODO: Padding? Randomize if so */
+   0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+   0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+   };
+
+   /* Allocate a new primitive */
+   rc = sched_prim_init(lchan, &prim, GSM_MACBLOCK_LEN,
+   trx_lchan_desc[lchan->type].chan_nr, TRX_CH_LID_SACCH);
+   OSMO_ASSERT(rc == 0);
+
+   /* Check if the MR cache is populated (verify LAPDm header) */
+   cached = (lchan->sacch.mr_cache[2] != 0x00
+   && lchan->sacch.mr_cache[3] != 0x00
+   && lchan->sacch.mr_cache[4] != 0x00);
+   if (cached) { /* Use the cached one */
+   mr_src_ptr = lchan->sacch.mr_cache;
+   lchan->sacch.mr_cache_usage++;
+   } else { /* Use "dummy" one */
+   mr_src_ptr = (uint8_t *) meas_rep_dummy;
+   }
+
+   /* Compose a new Measurement Report primitive */
+   memcpy(prim->payload, mr_src_ptr, GSM_MACBLOCK_LEN);
+
+#if 0
+   /**
+* Update the L1 SACCH pseudo-header (only for cached MRs)
+*
+* FIXME: this would require having access to the trx_instance,
+* what can be achieved either by chain-passing the pointer
+* through sched_prim_dequeue(), or by adding some
+* back-pointers to the logical channel state.
+*
+* TODO: filling of the actual values into cached Measurement
+* Reports would break the distance spoofing feature. If it
+* were known whether the spoofing is enabled or not, we could
+* decide whether to update the cached L1 SACCH header here.
+*/
+   if (!cached) {
+   prim->payload[0] = trx->tx_power;
+   prim->payload[1] = trx->ta;
+   }
+#endif
+
+   /* Inform about the cache usage count */
+   if (cached && lchan->sacch.mr_cache_usage > 5) {
+   LOGP(DSCHD, LOGL_NOTICE, "SACCH MR cache usage count=%u > 5 "
+   "on lchan=%s => ancient measurements, please fix!\n",
+   lchan->sacch.mr_cache_usage,
+   trx_lchan_desc[lchan->type].name);
+   }
+
+   LOGP(DSCHD, LOGL_NOTICE, "Using a %s Measurement Report "
+   "on lchan=%s\n", (cached ? "cached" : "dummy"),
+   trx_lchan_desc[lchan->type].name);
+
+   return prim;
+}
+
+/**
+ * Dequeues a SACCH primitive from transmit queue, if pr

Build failed in Jenkins: master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #6014

[jenkins]

See 


Changes:

[Stefan Sperling] fix a use-after-free in msc_mgcp.c:_handle_error()

--
[...truncated 47.15 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_vty.lo
  CC   common_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_bss.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/game

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..


Patch Set 4: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:

https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c@255
PS4, Line 255:  llist_for_each_entry(prim, queue, list) {
I think it would be more elegant to have a second queue for SACCH so we don't 
have to scan the (shared) queue and filter for SACCH messages, but simply can 
directly look at a queue containing only "relevant" messages. But that's just a 
matter of taste and doesn't have to happen at all, particularly not in this 
patch.



--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:15:49 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5866

[jenkins]

See 


--
[...truncated 38.07 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocor

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5866

[jenkins]

See 


--
[...truncated 46.82 KB...]
  CC   gsm0503_coding.lo
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_util.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore

Change in osmo-msc[master]: fix a use-after-free in msc_mgcp.c:_handle_error()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11146 )

Change subject: fix a use-after-free in msc_mgcp.c:_handle_error()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11146
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5df17c19e2a68c019f7eaf582b14585caa54b32a
Gerrit-Change-Number: 11146
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:12:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: fix a use-after-free in msc_mgcp.c:_handle_error()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11146 )

Change subject: fix a use-after-free in msc_mgcp.c:_handle_error()
..

fix a use-after-free in msc_mgcp.c:_handle_error()

Move code which needs to test the mgcp_ctx->free_ctx flag upwards
such that it runs before we're calling functions which will
potentially free mgcp_ctx. The code being moved up takes effect
only in case mgcp_ctx won't be freed, so there should be no
functional difference.

Change-Id: I5df17c19e2a68c019f7eaf582b14585caa54b32a
Related: OS#2885
---
M src/libmsc/msc_mgcp.c
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve; Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c
index e58b249..acdb785 100644
--- a/src/libmsc/msc_mgcp.c
+++ b/src/libmsc/msc_mgcp.c
@@ -183,6 +183,16 @@
LOGPFSMLSRC(mgcp_ctx->fsm, LOGL_ERROR, file, line, "%s -- graceful 
shutdown...\n",
get_value_string(msc_mgcp_cause_codes_names, cause));

+   /* Request the higher layers (gsm_04_08.c) to release the call. If the
+* problem occured after msc_mgcp_call_release() was calls, remain
+* silent because we already got informed and the higher layers might
+* already freed their context information (trans). */
+   if (!mgcp_ctx->free_ctx) {
+   mncc_set_cause(&mncc, GSM48_CAUSE_LOC_TRANS_NET,
+  GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
+   mncc_tx_to_cc(mgcp_ctx->trans->net, MNCC_REL_REQ, &mncc);
+   }
+
/* For the shutdown we have two options. Whenever it makes sense to
 * send a DLCX to the MGW in order to be sure that the connection is
 * properly cleaned up, the dlcx flag should be set. In other cases
@@ -205,16 +215,6 @@
osmo_fsm_inst_state_chg(fi, ST_HALT, 0, 0);
osmo_fsm_inst_dispatch(fi, EV_TEARDOWN_ERROR, mgcp_ctx);
}
-
-   /* Request the higher layers (gsm_04_08.c) to release the call. If the
-* problem occured after msc_mgcp_call_release() was calls, remain
-* silent because we already got informed and the higher layers might
-* already freed their context information (trans). */
-   if (!mgcp_ctx->free_ctx) {
-   mncc_set_cause(&mncc, GSM48_CAUSE_LOC_TRANS_NET,
-  GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
-   mncc_tx_to_cc(mgcp_ctx->trans->net, MNCC_REL_REQ, &mncc);
-   }
 }

 /* Timer callback to shut down in case of connectivity problems */

--
To view, visit https://gerrit.osmocom.org/11146
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5df17c19e2a68c019f7eaf582b14585caa54b32a
Gerrit-Change-Number: 11146
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: dexter 

Change in osmocom-bb[master]: trxcon/sched_prim.c: drop redundant tn validation

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11145 )

Change subject: trxcon/sched_prim.c: drop redundant tn validation
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11145
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I553b4cc39b2efd7b60346160c57f01ee4cf066be
Gerrit-Change-Number: 11145
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:12:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trxcon/sched_prim.c: drop redundant tn validation

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11145 )

Change subject: trxcon/sched_prim.c: drop redundant tn validation
..

trxcon/sched_prim.c: drop redundant tn validation

Change-Id: I553b4cc39b2efd7b60346160c57f01ee4cf066be
---
M src/host/trxcon/sched_prim.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c
index e03f93f..2067900 100644
--- a/src/host/trxcon/sched_prim.c
+++ b/src/host/trxcon/sched_prim.c
@@ -102,10 +102,6 @@

/* Determine TS index */
tn = chan_nr & 0x7;
-   if (tn > 7) {
-   LOGP(DSCH, LOGL_ERROR, "Incorrect TS index %u\n", tn);
-   return -EINVAL;
-   }

/* Check whether required timeslot is allocated and configured */
ts = trx->ts_list[tn];

--
To view, visit https://gerrit.osmocom.org/11145
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I553b4cc39b2efd7b60346160c57f01ee4cf066be
Gerrit-Change-Number: 11145
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-ttcn3-hacks[master]: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11149 )

Change subject: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy 
MeasRep
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn@1371
PS1, Line 1371: f_L1CTL_PARAM(L1CTL, ta, tx_power);
> Why do we need both variables? […]
In the context of "developer economy", let's please not debate such topics.  
Some people like to use a local variable to shorten the line length, others 
don't.  Especially in this example, both variants are equally readable.



--
To view, visit https://gerrit.osmocom.org/11149
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:11:16 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2859

[jenkins]

See 


--
[...truncated 42.45 KB...]
  CC   gsm0503_interleaving.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_vty.lo
  CC   common_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_bss.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /bu

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5865

[jenkins]

See 


--
[...truncated 55.16 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp.lo
  CC   common_vty.lo
  CC   gprs_bssgp_bss.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocor

Build failed in Jenkins: master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #6013

[jenkins]

See 


--
[...truncated 46.50 KB...]
  CC   gsm0503_interleaving.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp.lo
  CC   common_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   gprs_bssgp_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libos

Build failed in Jenkins: master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2859

[jenkins]

See 


--
[...truncated 42.46 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_coding.lo
  CC   gsm0503_parity.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_vty.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/d

Build failed in Jenkins: master-osmo-bsc » a1=default,a2=default,a3=default,osmocom-master-debian9 #3633

[jenkins]

See 


--
[...truncated 37.71 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp.lo
  CC   common_vty.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib

Build failed in Jenkins: master-osmo-msc » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #6013

[jenkins]

See 


--
[...truncated 46.98 KB...]
  CC   gsm0503_coding.lo
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_bssgp_bss.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_util.lo
  CC   common_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_ns_vty.lo
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5865

[jenkins]

See 


--
[...truncated 46.17 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_coding.lo
  CC   gsm0503_interleaving.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns_vty.lo
  CC   common_vty.lo
  CC   gprs_ns.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_bss.lo
  CC   gprs_ns_frgre.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libos

Change in osmo-ttcn3-hacks[master]: bts: Add parameter to set and expect a specific MS power level

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11148 )

Change subject: bts: Add parameter to set and expect a specific MS power level
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn@1169
PS1, Line 1169: l1header := 
valueof(ts_SACCH_L1_HEADER(g_pars.l1_pars.ms_power_level, false, 
g_pars.l1_pars.ms_actual_ta)),
> This is another improvement of the test, and I agree it makes sense but it 
> can be done in a later pa […]
It's also a question on what we want to test here, and how much of the normal 
MS behavior we want to emulate.  I'm not sure at this point...



--
To view, visit https://gerrit.osmocom.org/11148
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedab8681a0ba4652a6bb1c001418599a4ff746b6
Gerrit-Change-Number: 11148
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:08:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5864

[jenkins]

See 


--
[...truncated 37.53 KB...]
  CC   gsm0503_parity.lo
  CC   gsm0503_mapping.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp_bss.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_vty.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocor

Build failed in Jenkins: master-osmo-mgw » --disable-mgcp-transcoding,a2=default,a3=default,osmocom-master-debian9 #1534

[jenkins]

See 


--
[...truncated 36.58 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns_frgre.lo
  CC   gprs_ns.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp.lo
  CC   common_vty.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5864

[jenkins]

See 


--
[...truncated 44.75 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_coding.lo
  CC   gsm0503_parity.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp.lo
  CC   common_vty.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocor

Build failed in Jenkins: master-osmo-mgw » --enable-mgcp-transcoding,a2=default,a3=default,osmocom-master-debian9 #1534

[jenkins]

See 


--
[...truncated 36.57 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_coding.lo
  CC   gsm0503_parity.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_ns.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/s

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5863

[jenkins]

See 


--
[...truncated 36.10 KB...]
  CC   gsm0503_interleaving.lo
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns_vty.lo
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libo

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5863

[jenkins]

See 


--
[...truncated 36.87 KB...]
  CC   gsm0503_tables.lo
  CC   gsm0503_coding.lo
  CC   gsm0503_parity.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_vty.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore

Change in osmo-ttcn3-hacks[master]: L1CTL_Types: Add support to set L1 Header params during SACCH tx

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11147 )

Change subject: L1CTL_Types: Add support to set L1 Header params during SACCH tx
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id014f790ee2ede8ae796c37b1c6b25c4af9034d2
Gerrit-Change-Number: 11147
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:06:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: Revert "BSC_Tests: use consistant AMR S0-S15 bits"

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11129 )

Change subject: Revert "BSC_Tests: use consistant AMR S0-S15 bits"
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11129
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16d14c723773ce67508c7e6028e594c15779506
Gerrit-Change-Number: 11129
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:02:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11060 )

Change subject: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST
..


Patch Set 8: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11060
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 8
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:02:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: Revert "BSC_Tests: use consistant AMR S0-S15 bits"

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11129 )

Change subject: Revert "BSC_Tests: use consistant AMR S0-S15 bits"
..

Revert "BSC_Tests: use consistant AMR S0-S15 bits"

The change depends on another change in osmo-bsc, which
is not in master yet. Because of this TC_assignment_codec_amr_f
and TC_assignment_codec_amr_h are currently failing. So lets
revert this patch and re-submit it later.

See also: osmo-bsc change I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737

This reverts commit 7f5609ad3e65098cca3d79565a1aa80460c49bed.

Change-Id: Ib16d14c723773ce67508c7e6028e594c15779506
---
M bsc/BSC_Tests.ttcn
1 file changed, 4 insertions(+), 16 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 4a34310..25df52d 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1923,10 +1923,6 @@
 testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
-
-   /* Note: This setups the codec configuration. The parameter payload in
-* mr_conf must be consistant with the parameter codecElements in pars
-* and also must match the amr-config in osmo-bsc.cfg! */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1934,14 +1930,11 @@
}
};

-   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
-   pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
-   pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
-   pars.expect_mr_conf_ie := mr_conf;
-
f_init(1, true);
f_sleep(1.0);

+   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+   pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
 }
@@ -1949,8 +1942,6 @@
 testcase TC_assignment_codec_amr_h() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
-
-   /* See note above */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1958,14 +1949,11 @@
}
};

-   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
-   pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
-   pars.ass_codec_list.codecElements[0].s8_15 := '0111'B;
-   pars.expect_mr_conf_ie := mr_conf;
-
f_init(1, true);
f_sleep(1.0);

+   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
+   pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
 }

--
To view, visit https://gerrit.osmocom.org/11129
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib16d14c723773ce67508c7e6028e594c15779506
Gerrit-Change-Number: 11129
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Build failed in Jenkins: master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #6012

[jenkins]

See 


--
[...truncated 35.90 KB...]
  CC   gsm0503_parity.lo
  CC   gsm0503_coding.lo
  CC   gsm0503_tables.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns_frgre.lo
  CC   gprs_ns.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp.lo
  CC   common_vty.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_bss.lo
  CC   gprs_bssgp_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore

Build failed in Jenkins: master-osmo-msc » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #6012

[jenkins]

See 


--
[...truncated 36.38 KB...]
  CC   gsm0503_mapping.lo
  CC   gsm0503_tables.lo
  CC   gsm0503_coding.lo
  CCLD libosmocoding.la
make[3]: Entering directory '/build/deps/libosmocore/src/coding'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   
libosmocoding.la '/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmocoding.la'
libtool: install: (cd /build/deps/libosmocore/src/coding; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -Wl,--version-script=./libosmocoding.map 
-version-info 1:1:1 -no-undefined -ltalloc -o libosmocoding.la -rpath 
/build/deps/install/stow/libosmocore/lib gsm0503_interleaving.lo 
gsm0503_mapping.lo gsm0503_tables.lo gsm0503_parity.lo gsm0503_coding.lo 
../libosmocore.la ../gsm/libosmogsm.la ../codec/libosmocodec.la )
libtool: install: /usr/bin/install -c .libs/libosmocoding.so.0.1.1T 
/build/deps/install/stow/libosmocore/lib/libosmocoding.so.0.1.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so.0 || { rm -f libosmocoding.so.0 && ln 
-s libosmocoding.so.0.1.1 libosmocoding.so.0; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocoding.so.0.1.1 libosmocoding.so || { rm -f libosmocoding.so && ln -s 
libosmocoding.so.0.1.1 libosmocoding.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocoding.lai 
/build/deps/install/stow/libosmocore/lib/libosmocoding.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory '/build/deps/libosmocore/src/coding'
make[2]: Leaving directory '/build/deps/libosmocore/src/coding'
Making install in src/gb
make[2]: Entering directory '/build/deps/libosmocore/src/gb'
  CC   gprs_ns.lo
  CC   gprs_ns_frgre.lo
  CC   gprs_ns_vty.lo
  CC   gprs_bssgp.lo
  CC   gprs_bssgp_util.lo
  CC   gprs_bssgp_bss.lo
  CC   common_vty.lo
  CC   gprs_bssgp_vty.lo
  CCLD libosmogb.la
make[3]: Entering directory '/build/deps/libosmocore/src/gb'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmogb.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmogb.la'
libtool: install: (cd /build/deps/libosmocore/src/gb; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall 
-fno-strict-aliasing -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-Wl,--version-script=./libosmogb.map -version-info 7:0:1 -o libosmogb.la -rpath 
/build/deps/install/stow/libosmocore/lib gprs_ns.lo gprs_ns_frgre.lo 
gprs_ns_vty.lo gprs_bssgp.lo gprs_bssgp_util.lo gprs_bssgp_vty.lo 
gprs_bssgp_bss.lo common_vty.lo -ltalloc ../../src/libosmocore.la 
../../src/vty/libosmovty.la ../../src/gsm/libosmogsm.la )
libtool: install: /usr/bin/install -c .libs/libosmogb.so.6.1.0T 
/build/deps/install/stow/libosmocore/lib/libosmogb.so.6.1.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so.6 || { rm -f libosmogb.so.6 && ln -s 
libosmogb.so.6.1.0 libosmogb.so.6; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmogb.so.6.1.0 libosmogb.so || { rm -f libosmogb.so && ln -s 
libosmogb.so.6.1.0 libosmogb.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmogb.lai 
/build/deps/install/stow/libosmocore/lib/libosmogb.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore

Change in osmo-dev[master]: 3G+2G.deps: add osmo-sip-connector

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11140 )

Change subject: 3G+2G.deps: add osmo-sip-connector
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11140
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57fa43209581638c39554079d7c4b65ce24890f8
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:00:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: osmo-config-merge: Fix some small issues

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11132 )

Change subject: osmo-config-merge: Fix some small issues
..

osmo-config-merge: Fix some small issues

Allocate NULL context after exit_usage() calls and free it before exit
so * sanitizer is happy.
Also handle the error cases gracefully when a file is unreadable or
formatted wrong.

Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232
---
M utils/osmo-config-merge.c
1 file changed, 15 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/utils/osmo-config-merge.c b/utils/osmo-config-merge.c
index c76e42d..a872d64 100644
--- a/utils/osmo-config-merge.c
+++ b/utils/osmo-config-merge.c
@@ -44,6 +44,7 @@

 #include 
 #include 
+#include 

 #include 
 #include 
@@ -126,8 +127,11 @@
unsigned int line_num = 0;

infile = fopen(fname, "r");
-   if (!infile)
+   if (!infile) {
+   fprintf(stderr, "Could not open file '%s': %s\n",
+   fname, strerror(errno));
return NULL;
+   }

root = node_alloc(ctx);
last = root;
@@ -140,7 +144,7 @@
if (indent > cur_indent+1) {
fprintf(stderr, "File '%s' isn't well-formed in 
line %u, aborting!\n",
fname, line_num);
-   exit(2);
+   return NULL;
}
/* new child to last node */
n = node_alloc_child(last);
@@ -229,8 +233,7 @@
const char *base_fname, *patch_fname;
struct node *base_tree, *patch_tree;
bool debug_enabled = false;
-
-   void *ctx = talloc_named_const(NULL, 0, "root");
+   void *ctx;
 
if (argc < 3)
exit_usage(1);
@@ -245,9 +248,16 @@
exit_usage(1);
}

+   ctx = talloc_named_const(NULL, 0, "root");
+
base_tree = file_read(ctx, base_fname);
patch_tree = file_read(ctx, patch_fname);

+   if (!base_tree || ! patch_tree) {
+   talloc_free(ctx);
+   return 2;
+   }
+
if (debug_enabled) {
fprintf(stderr, "== dumping tree (base)\n");
dump_node(base_tree, stderr, true);
@@ -265,6 +275,7 @@
/* make AddressSanitizer / LeakSanitizer happy by recursively freeing 
the trees */
talloc_free(patch_tree);
talloc_free(base_tree);
+   talloc_free(ctx);

return 0;
 }

--
To view, visit https://gerrit.osmocom.org/11132
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232
Gerrit-Change-Number: 11132
Gerrit-PatchSet: 4
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 

Change in libosmocore[master]: osmo-config-merge: Add manual page

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11133 )

Change subject: osmo-config-merge: Add manual page
..

osmo-config-merge: Add manual page

Change-Id: Ifaa5afe28779a805764caf76a89efb0a3169942e
---
M .gitignore
M Makefile.am
M configure.ac
A man/Makefile.am
A man/osmo-config-merge.adoc
5 files changed, 95 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/.gitignore b/.gitignore
index 451c883..cb2ce68 100644
--- a/.gitignore
+++ b/.gitignore
@@ -81,6 +81,7 @@
 doc/gb
 doc/html.tar
 doc/*.tag
+man/*.8
 tags

 src/crc*gen.c
diff --git a/Makefile.am b/Makefile.am
index de5eb35..745d482 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,7 +1,7 @@
 ACLOCAL_AMFLAGS = -I m4

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src src/vty src/codec src/gsm src/coding src/gb src/ctrl 
src/sim src/pseudotalloc utils tests
+SUBDIRS = include src src/vty src/codec src/gsm src/coding src/gb src/ctrl 
src/sim src/pseudotalloc utils tests man

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmocore.pc libosmocodec.pc libosmovty.pc libosmogsm.pc \
diff --git a/configure.ac b/configure.ac
index bc3358a..529aad1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,6 +77,19 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")

+AC_ARG_ENABLE([man-doc],
+ [AS_HELP_STRING([--disable-man-doc], [Disable man page 
documentation])],
+ [ BUILD_MAN=$enableval ], [ BUILD_MAN="yes" ])
+
+AS_IF([test "x$BUILD_MAN" = "xyes"], [
+  AC_CHECK_PROG(A2X, [a2x], [yes])
+  AS_IF([test "$A2X" != "yes"],
+   [AC_MSG_ERROR([a2x not found, please install asciidoc or use the
+option --disable-man-doc])])
+])
+AM_CONDITIONAL(BUILD_MAN, test "x$BUILD_MAN" = "xyes")
+AC_SUBST(BUILD_MAN)
+
 # check for syscal fallback on glibc < 2.25 - can be removed once glibc 
version requirement is bumped
 AC_CHECK_DECLS([SYS_getrandom], [], [], [[#include ]])

@@ -370,6 +383,7 @@
libosmoctrl.pc
libosmosim.pc
include/Makefile
+   man/Makefile
src/Makefile
src/vty/Makefile
src/codec/Makefile
diff --git a/man/Makefile.am b/man/Makefile.am
new file mode 100644
index 000..b287714
--- /dev/null
+++ b/man/Makefile.am
@@ -0,0 +1,15 @@
+if BUILD_MAN
+man_MANS =  osmo-config-merge.8
+endif
+
+ASCIIDOCS = osmo-config-merge.adoc
+
+A2X_OPTS_MANPAGE = --doctype manpage --format manpage -D ${builddir}
+
+%.8 : %.adoc
+   a2x ${A2X_OPTS_MANPAGE} $<
+
+EXTRA_DIST = ${ASCIIDOCS}
+
+CLEANFILES = \
+osmo-config-merge.8
diff --git a/man/osmo-config-merge.adoc b/man/osmo-config-merge.adoc
new file mode 100644
index 000..205fb50
--- /dev/null
+++ b/man/osmo-config-merge.adoc
@@ -0,0 +1,64 @@
+osmo-config-merge(8)
+=
+
+NAME
+
+osmo-config-merge - Merge osmocom config snippets into an existing config
+
+SYNOPSIS
+
+[verse]
+*osmo-config-merge*   [--debug]
+
+DESCRIPTION
+---
+This utility allows you to merge an incremental config "patch"
+into an osmocom-style config file.
+
+The patch file follows the same syntax as the original config file.
+
+It works by appending the leaf nodes of the patch file to the respective
+nodes of the input config file.
+
+This process allows configuration file changes/updates to be performed
+in a more stable/reliable way than by means of (unified) diff files,
+as they break every time the context lines break.
+
+osmo-config-merge doesn't suffer from this problem, as it understands
+the tree-like nature of VTY config files.
+
+The resulting config is printed to stdout.
+
+NOTE: This only works with configuration files that have proper
+indenting, i.e. every level in the hierarchy must be indented excatly
+one character, not multiple.
+
+OPTIONS
+---
+*--debug*::
+   Show debugging output when parsing the config tree. Needs to be the 
last argument.
+
+EXAMPLE USAGE
+-
+[verse]
+$ osmo-config-merge osmo-msc.cfg.base osmo-msc_change_network.cfg > 
osmo-msc.cfg
+
+EXIT STATUS
+---
+Exit status is 0 if the command was successful, and 1 in case of a
+wrong/missing argument. If the tool detects an error in the patch file the
+exit status is 2.
+
+SEE ALSO
+
+The official Osmocom documentation including the VTY config refernce can be
+found at: http://ftp.osmocom.org/docs/latest/
+
+The Osmocom wiki is located at: http://projects.osmocom.org/
+
+
+AUTHORS
+---
+osmo-config-merge was written by Harald Welte.
+
+The man page was written by Daniel Willmann.

--
To view, visit https://gerrit.osmocom.org/11133
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType:

Change in libosmocore[master]: osmo-config-merge: Fix some small issues

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11132 )

Change subject: osmo-config-merge: Fix some small issues
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11132
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232
Gerrit-Change-Number: 11132
Gerrit-PatchSet: 4
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Fri, 28 Sep 2018 22:59:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: osmo-config-merge: Add manual page

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11133 )

Change subject: osmo-config-merge: Add manual page
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11133
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaa5afe28779a805764caf76a89efb0a3169942e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 5
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 22:58:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Jenkins build is back to normal : master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5862

[jenkins]

See 

Change in osmo-ttcn3-hacks[master]: bts: Add timing offset tolerance module parameter to support real HW

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11083 )

Change subject: bts: Add timing offset tolerance module parameter to support 
real HW
..


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn@1285
PS5, Line 1285: actual_ta := f_tolerance(l1p.ms_actual_ta, 0, 
63, mp_tolerance_timing_offset_256syms/256)
According to "3GPP TS 48.058", "9.3.10 L1 Information":
"""
Octets 2-3 contain the L1 header information of SACCH blocks. The information 
fields and codings are as defined in
3GPP TS 44.004.
"""

Then. According to "3GPP TS 44.004", "6.1  Physical layer protocol fields and 
procedures:"

"""
For all the bands except GSM 400, the values 0 to 63 are valid TA values.  The 
bit pattern "111" indicates that the
field does not contain a timing advance value. All other bit combinations (64 
to 126 decimal) are reserved. For all bands
except GSM 400 bit 8 is set to spare.
"""

So this one is good.


https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn@1288
PS5, Line 1288: var template uint8_t t_toffs := f_tolerance(offs, -63, 
192, mp_tolerance_timing_offset_256syms/256);
> I think I swapped these values with those of line 1285, I need to have a look 
> at these ranges again.
According to "3GPP TS 48.058", "9.3.37 MS Timing Offset":
"""
The meaning of the MS Timing Offset is as defined in 3GPP TS 45.010. The value 
of MS Timing Offset is the binary
value of the 8-bit Timing Offset field (octet 2) - 63. The range of MS Timing 
Offset is therefore -63 to 192.
"""

And looking for "Timing Offset" in TS 45.010 I could only find this:
"""
MS timing offset:
 delay of the received signal relative to the expect
ed signal from an MS at zero distance under static
channel conditions with zero timing advance. This is accurate to ± 1 symbol, 
and reported once per SACCH or after a
RACH as. required (i.e. at the same rate as timing advan
ce). For example, for an MS with a round trip propagation
delay of P symbols, but with a timing advance of T symbols, the reported timing 
offset will be P-T quantized to the
nearest symbol. For GPRS the MS timing offset is not reported.
"""

So, as a result:
line 1264 should have ranges (-63*256, 192*256).
line 1285 should have ranges (0,63) (correct in current version).
line 1288 should have ranges (0, 255).



--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 18:16:52 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11149 )

Change subject: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy 
MeasRep
..


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@11
PS1, Line 11: dummy
> As I already mentioned in 11138, the firmware actually […]
in firmware case, the cached message is also removed during L1CTL_DM_REL_REQ, 
because it is called this way: l1a_meas_msgb_set(NULL);

In turn L1CTL_RESET_REQ will reset variables used in tx_power.

So I think we need to keep this commit, but I can add something like:
 "If for whatever reason (eg. CPU scheduling saturation) the L1CTL cli (TTCN3) 
doesn't send Measurement Reports on time and no previous one is cached or has 
been erased by L1CTL_DM_REL_REQ,"


https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@13
PS1, Line 13: Those
> Only dummy MRs are filled with the actual parameters, […]
Agree. That's more a less what I'm saying here. I need to add to the tail: "in 
order to send expected values in case the cache is empty and we don't send the 
Measurement Report through L1CTL on time."


https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn@1371
PS1, Line 1371: f_L1CTL_PARAM(L1CTL, ta, tx_power);
> Why do we need both variables? […]
I'll pass the variables directly.



--
To view, visit https://gerrit.osmocom.org/11149
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 17:45:16 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Add parameter to set and expect a specific MS power level

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11148 )

Change subject: bts: Add parameter to set and expect a specific MS power level
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn@1169
PS1, Line 1169: l1header := 
valueof(ts_SACCH_L1_HEADER(g_pars.l1_pars.ms_power_level, false, 
g_pars.l1_pars.ms_actual_ta)),
> Also, I think it makes sense to use the parameters from L1 […]
This is another improvement of the test, and I agree it makes sense but it can 
be done in a later patch later in time.



--
To view, visit https://gerrit.osmocom.org/11148
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedab8681a0ba4652a6bb1c001418599a4ff746b6
Gerrit-Change-Number: 11148
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 17:31:25 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Add timing offset tolerance module parameter to support real HW

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11083 )

Change subject: bts: Add timing offset tolerance module parameter to support 
real HW
..


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn@1288
PS5, Line 1288: var template uint8_t t_toffs := f_tolerance(offs, -63, 
192, mp_tolerance_timing_offset_256syms/256);
I think I swapped these values with those of line 1285, I need to have a look 
at these ranges again.



--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 17:30:09 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Add timing offset tolerance module parameter to support real HW

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11083 )

Change subject: bts: Add timing offset tolerance module parameter to support 
real HW
..


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn@1264
PS5, Line 1264: 33024
> Where does this magic number comes from?
TBH, I don't recall how I ended it up here, but I now think it should be  
63*256=16128, right?



--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 17:26:51 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Add parameter to set and expect a specific MS power level

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11148 )

Change subject: bts: Add parameter to set and expect a specific MS power level
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn@1169
PS1, Line 1169: l1header := 
valueof(ts_SACCH_L1_HEADER(g_pars.l1_pars.ms_power_level, false, 
g_pars.l1_pars.ms_actual_ta)),
Also, I think it makes sense to use the parameters from L1
SACCH pseudo-header indicated on DL, i.e. from 'l1_dl'.

In the normal OsmocomBB setup, the SI 5/5ter/6 messages
are being forwarded from L1 to the higher layers, which
then instruct L1 via L1CTL_PARAM_REQ.



--
To view, visit https://gerrit.osmocom.org/11148
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedab8681a0ba4652a6bb1c001418599a4ff746b6
Gerrit-Change-Number: 11148
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 16:34:46 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5861

[jenkins]

See 


--
[...truncated 202.92 KB...]
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
configure.ac:21: installing './compile'
configure.ac:23: installing './config.guess'
configure.ac:23: installing './config.sub'
configure.ac:9: installing './install-sh'
configure.ac:9: installing './missing'
src/gprs/Makefile.am: installing './depcomp'
tests/gprs/Makefile.am:8: warning: source file 
'$(top_srcdir)/src/gprs/gprs_utils.c' is in a subdirectory,
tests/gprs/Makefile.am:8: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled.  For now, the corresponding 
output
automake: object file(s) will be placed in the top-level directory.  However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same 
subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
+ ./configure --enable-sanitize --enable-werror --disable-iu 
--enable-external-tests
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether make supports nested variables... (cached) yes
checking whether make sets $(MAKE)... (cached) yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to 
x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain 
format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
lib

Change in osmo-ttcn3-hacks[master]: bts: Add timing offset tolerance module parameter to support real HW

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11083 )

Change subject: bts: Add timing offset tolerance module parameter to support 
real HW
..


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11083/5/bts/BTS_Tests.ttcn@1264
PS5, Line 1264: 33024
Where does this magic number comes from?



--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 15:53:48 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11149 )

Change subject: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy 
MeasRep
..


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@11
PS1, Line 11: dummy
As I already mentioned in 11138, the firmware actually
implements MR caching. Dummy ones are being sent before
the first MR received from L23, then cached MR is used.

As soon as we mere 11138, trxcon will also follow this approach.


https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@13
PS1, Line 13: Those
Only dummy MRs are filled with the actual parameters,
cached ones remain the same until the next one appears.


https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn@1371
PS1, Line 1371: f_L1CTL_PARAM(L1CTL, ta, tx_power);
Why do we need both variables?
Why not to pass the values directly?

  f_L1CTL_PARAM(L1CTL,
g_pars.l1_pars.ms_actual_ta,
g_pars.l1_pars.ms_power_level);

should work just fine...



--
To view, visit https://gerrit.osmocom.org/11149
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 15:48:32 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #260

[jenkins]

See 


--
[...truncated 3.81 KB...]
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking how to run the C preprocessor... gcc -E
checking for a BSD-compatible install

Change in osmo-ttcn3-hacks[master]: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11149


Change subject: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy 
MeasRep
..

bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

If for whatever reason (eg. CPU scheduling saturation) the L1CTL cli
(TTCN3) doesn't send Measurement Reports on time, lower osmocombb layers
will generate their own dummy Measurement Reports since SACCH must
always be filled.
Those dummy Measurement Reports are filled from
parameters previosuly set using L1CTL_PARAM_REQ (implemented by
f_L1CTL_PARAM() in TTCN3).
Since that function is never called, we need to call it to set the
expected MS power level values in order to send expected values in case
we don't send the Measurement Report through L1CTL on time.

Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/49/11149/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index e7df027..097da13 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1365,7 +1365,10 @@
var GsmFrameNumber fn;
var ImmediateAssignment imm_ass;
var integer ra := 23;
+   var integer ta := g_pars.l1_pars.ms_actual_ta;
+   var integer tx_power := g_pars.l1_pars.ms_power_level;

+   f_L1CTL_PARAM(L1CTL, ta, tx_power);
fn := f_L1CTL_RACH(L1CTL, ra);
/* This arrives on CCHAN, so we cannot test for receiving CHAN RQDhere 
*/
//RSL.receive(tr_RSL_CHAN_RQD(int2oct(23,1)));

--
To view, visit https://gerrit.osmocom.org/11149
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: bts: Add parameter to set and expect a specific MS power level

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11148


Change subject: bts: Add parameter to set and expect a specific MS power level
..

bts: Add parameter to set and expect a specific MS power level

This change uses recently added ts_L1CTL_DATA_REQ_SACCH to be able to
set the L1 Header parameters to match the expected MS power level
announced by the BTS.

Change-Id: Iedab8681a0ba4652a6bb1c001418599a4ff746b6
---
M bts/BTS_Tests.ttcn
1 file changed, 10 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/48/11148/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 4209e4e..e7df027 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -57,6 +57,7 @@
integer mp_tolerance_rxlev := 3;
integer mp_tolerance_timing_offset_256syms := 0;
integer mp_rxlev_exp := 57;
+   integer mp_ms_power_level_exp := 7;
integer mp_ms_actual_ta_exp := 0;
integer mp_timing_offset_256syms_exp := 512;
 }
@@ -167,7 +168,7 @@

 template (value) CellSelectionParameters ts_CellSelPar_default := {
cell_resel_hyst_2dB := 2,
-   ms_txpwr_max_cch := 7,
+   ms_txpwr_max_cch := mp_ms_power_level_exp,
acs := '0'B,
neci := true,
rxlev_access_min := 0
@@ -526,7 +527,7 @@
},
timing_offset_256syms := mp_timing_offset_256syms_exp,
bs_power_level := 0,
-   ms_power_level := 0,
+   ms_power_level := mp_ms_power_level_exp,
ms_actual_ta := mp_ms_actual_ta_exp
},
spec := omit,
@@ -1163,9 +1164,13 @@
var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(true, 23, 
23, 0, 0, omit));
var LapdmFrameAB lb := valueof(ts_LAPDm_AB(0, false, false, 
enc_GsmRrL3Message(meas_rep)));
log("LAPDm: ", lb);
-   var octetstring pl := ''O & enc_LapdmFrameAB(lb);
-   L1CTL.send(ts_L1CTL_DATA_REQ(g_chan_nr, ts_RslLinkID_SACCH(0),
-   f_pad_oct(pl, 23, '2B'O)));
+
+   var L1ctlDataReq data_req := {
+   l1header := 
valueof(ts_SACCH_L1_HEADER(g_pars.l1_pars.ms_power_level, false, 
g_pars.l1_pars.ms_actual_ta)),
+   l2_payload := f_pad_oct(enc_LapdmFrameAB(lb), 21, '2B'O)
+   }
+   log("Sending Measurement Report: ", data_req);
+   L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, 
ts_RslLinkID_SACCH(0), data_req));
repeat;
}
 }

--
To view, visit https://gerrit.osmocom.org/11148
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedab8681a0ba4652a6bb1c001418599a4ff746b6
Gerrit-Change-Number: 11148
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in libosmocore[master]: osmo-config-merge: Add manual page

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11133 )

Change subject: osmo-config-merge: Add manual page
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11133
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaa5afe28779a805764caf76a89efb0a3169942e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 5
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 28 Sep 2018 14:24:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: L1CTL_Types: Add support to set L1 Header params during SACCH tx

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11147


Change subject: L1CTL_Types: Add support to set L1 Header params during SACCH tx
..

L1CTL_Types: Add support to set L1 Header params during SACCH tx

Change-Id: Id014f790ee2ede8ae796c37b1c6b25c4af9034d2
---
M library/L1CTL_Types.ttcn
1 file changed, 38 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/47/11147/1

diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn
index 656f292..0e1f036 100644
--- a/library/L1CTL_Types.ttcn
+++ b/library/L1CTL_Types.ttcn
@@ -263,6 +263,26 @@
OCT2padding
} with { variant "" };

+   /* TS 44.004 7.2.1 */
+   type record SACCH_L1_HEADER {
+   uint2_t reserved,
+   boolean fpc,
+   uint5_t ms_power_lvl,
+   uint8_t actual_ta
+   } with { variant "FIELDORDER(msb)" };
+
+   template (value) SACCH_L1_HEADER ts_SACCH_L1_HEADER(uint5_t 
ms_power_lvl, boolean fpc, uint8_t actual_ta) := {
+   reserved := 0,
+   fpc := fpc,
+   ms_power_lvl := ms_power_lvl,
+   actual_ta := actual_ta
+   };
+
+   type record L1ctlDataReq {
+   SACCH_L1_HEADER l1header optional,
+   octetstring l2_payload
+   } with { variant "" };
+
type record L1ctlH1 {
uint8_t hsn,
uint8_t maio,
@@ -320,6 +340,7 @@
L1CtlCryptoReq  crypto_req,
L1ctlTrafficReq traffic_req,
L1ctlTbfCfgReq  tbf_cfg_req,
+   L1ctlDataReqdata_req,
octetstring other
} with {
variant (other) "BYTEORDER(first)"
@@ -351,6 +372,7 @@
 crypto_req, header.msg_type = 
L1CTL_CRYPTO_REQ;
 traffic_req, header.msg_type = 
L1CTL_TRAFFIC_REQ;
 tbf_cfg_req, header.msg_type = 
L1CTL_TBF_CFG_REQ;
+data_req, header.msg_type = 
L1CTL_DATA_REQ;
 other, OTHERWISE;
)" };

@@ -542,6 +564,22 @@
}
}

+   template (value) L1ctlUlMessage ts_L1CTL_DATA_REQ_SACCH(template 
(value) RslChannelNr chan_nr,
+template (value) 
RslLinkId link_id,
+L1ctlDataReq data_req) 
:= {
+   header := ts_L1ctlHeader(L1CTL_DATA_REQ),
+   ul_info := {
+   chan_nr := chan_nr,
+   link_id := link_id,
+   padding := ''O
+   },
+   ul_info_tbf := omit,
+   ul_info_abs := omit,
+   payload := {
+   data_req := data_req
+   }
+   }
+
template (value) L1ctlUlMessage ts_L1CTL_TBF_CFG_REQ(boolean is_uplink, 
TfiUsfArr tfi_usf) := {
header := ts_L1ctlHeader(L1CTL_TBF_CFG_REQ),
ul_info := omit,

--
To view, visit https://gerrit.osmocom.org/11147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id014f790ee2ede8ae796c37b1c6b25c4af9034d2
Gerrit-Change-Number: 11147
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: bts: Add timing offset tolerance module parameter to support real HW

[Pau Espin Pedrol]

Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11083

to look at the new patch set (#5).

Change subject: bts: Add timing offset tolerance module parameter to support 
real HW
..

bts: Add timing offset tolerance module parameter to support real HW

When we don't use trxcon (ie we run real HW) we need to relax template
matching when we receive UL measurements in that case.

Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
---
M bts/BTS_Tests.ttcn
1 file changed, 15 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/83/11083/5
--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in libosmocore[master]: osmo-config-merge: Fix some small issues

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11132 )

Change subject: osmo-config-merge: Fix some small issues
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11132
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232
Gerrit-Change-Number: 11132
Gerrit-PatchSet: 4
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Fri, 28 Sep 2018 14:15:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: osmo-config-merge: Fix some small issues

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11132 )

Change subject: osmo-config-merge: Fix some small issues
..


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/11132/3/utils/osmo-config-merge.c
File utils/osmo-config-merge.c:

https://gerrit.osmocom.org/#/c/11132/3/utils/osmo-config-merge.c@130
PS3, Line 130: read
> I think "Could not open ..." would be a bit more informative. […]
Done


https://gerrit.osmocom.org/#/c/11132/3/utils/osmo-config-merge.c@236
PS3, Line 236:
> Not sure we need this white space. Let's just remove this chunk […]
Done



--
To view, visit https://gerrit.osmocom.org/11132
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232
Gerrit-Change-Number: 11132
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 14:07:46 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: osmo-config-merge: Add manual page

[daniel]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11133

to look at the new patch set (#4).

Change subject: osmo-config-merge: Add manual page
..

osmo-config-merge: Add manual page

Change-Id: Ifaa5afe28779a805764caf76a89efb0a3169942e
---
M .gitignore
M Makefile.am
M configure.ac
A man/Makefile.am
A man/osmo-config-merge.adoc
5 files changed, 94 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/11133/4
--
To view, visit https://gerrit.osmocom.org/11133
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifaa5afe28779a805764caf76a89efb0a3169942e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 4
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: osmo-config-merge: Fix some small issues

[daniel]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11132

to look at the new patch set (#4).

Change subject: osmo-config-merge: Fix some small issues
..

osmo-config-merge: Fix some small issues

Allocate NULL context after exit_usage() calls and free it before exit
so * sanitizer is happy.
Also handle the error cases gracefully when a file is unreadable or
formatted wrong.

Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232
---
M utils/osmo-config-merge.c
1 file changed, 15 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/11132/4
--
To view, visit https://gerrit.osmocom.org/11132
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232
Gerrit-Change-Number: 11132
Gerrit-PatchSet: 4
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-CC: Vadim Yanitskiy 

Change in osmo-ttcn3-hacks[master]: bts: Add module parameters with tolerance to support real HW

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11083 )

Change subject: bts: Add module parameters with tolerance to support real HW
..


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/11083/4//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11083/4//COMMIT_MSG@7
PS4, Line 7: bts: Add module parameters with tolerance to support real HW
> If the commit message states that we "add module parameters", […]
Agree


https://gerrit.osmocom.org/#/c/11083/4/library/L1CTL_Types.ttcn
File library/L1CTL_Types.ttcn:

https://gerrit.osmocom.org/#/c/11083/4/library/L1CTL_Types.ttcn@281
PS4, Line 281: L1ctlDataReq
> The L1CTL_DATA_REQ is not only used to carry SACCH messages. […]
That's why l1header is defined as optional. ts_L1CTL_DATA_REQ still uses 
"octetstring other", but could be changed to use L1ctlDataReq with l1header := 
omit.

It already contains the info_ul part, see ts_L1CTL_DATA_REQ and 
ts_L1CTL_DATA_REQ_SACCH.

I'll look into adding it to L3_Templates. I added it here since it looked like 
the less aggressive change, and I couldn't find a real good place for it (since 
it's actually a L1 header, not l2 apparently.



--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 13:46:52 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: fix a use-after-free in msc_mgcp.c:_handle_error()

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/11146 )

Change subject: fix a use-after-free in msc_mgcp.c:_handle_error()
..


Patch Set 1: Verified+1

> > Build Successful
 > >
 > > https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/686/ :
 > > SUCCESS'  --verified 1 --code-review 0


--
To view, visit https://gerrit.osmocom.org/11146
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5df17c19e2a68c019f7eaf582b14585caa54b32a
Gerrit-Change-Number: 11146
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Fri, 28 Sep 2018 13:32:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: fix a use-after-free in msc_mgcp.c:_handle_error()

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/11146 )

Change subject: fix a use-after-free in msc_mgcp.c:_handle_error()
..


Patch Set 1: Code-Review+1

> Build Successful
 >
 > https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/686/ :
 > SUCCESS'  --verified 1 --code-review 0


--
To view, visit https://gerrit.osmocom.org/11146
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5df17c19e2a68c019f7eaf582b14585caa54b32a
Gerrit-Change-Number: 11146
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Fri, 28 Sep 2018 13:14:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..


Patch Set 4:

> I expect a similar patch for l23_api/l1 firmware
> as there's some similar code there, right?

I just checked out the firmware source, and it turns out that
it already does the caching. No changes required there.


--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 12:43:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: fix a use-after-free in msc_mgcp.c:_handle_error()

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11146


Change subject: fix a use-after-free in msc_mgcp.c:_handle_error()
..

fix a use-after-free in msc_mgcp.c:_handle_error()

Move code which needs to test the mgcp_ctx->free_ctx flag upwards
such that it runs before we're calling functions which will
potentially free mgcp_ctx. The code being moved up takes effect
only in case mgcp_ctx won't be freed, so there should be no
functional difference.

Change-Id: I5df17c19e2a68c019f7eaf582b14585caa54b32a
Related: OS#2885
---
M src/libmsc/msc_mgcp.c
1 file changed, 10 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/46/11146/1

diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c
index e58b249..acdb785 100644
--- a/src/libmsc/msc_mgcp.c
+++ b/src/libmsc/msc_mgcp.c
@@ -183,6 +183,16 @@
LOGPFSMLSRC(mgcp_ctx->fsm, LOGL_ERROR, file, line, "%s -- graceful 
shutdown...\n",
get_value_string(msc_mgcp_cause_codes_names, cause));

+   /* Request the higher layers (gsm_04_08.c) to release the call. If the
+* problem occured after msc_mgcp_call_release() was calls, remain
+* silent because we already got informed and the higher layers might
+* already freed their context information (trans). */
+   if (!mgcp_ctx->free_ctx) {
+   mncc_set_cause(&mncc, GSM48_CAUSE_LOC_TRANS_NET,
+  GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
+   mncc_tx_to_cc(mgcp_ctx->trans->net, MNCC_REL_REQ, &mncc);
+   }
+
/* For the shutdown we have two options. Whenever it makes sense to
 * send a DLCX to the MGW in order to be sure that the connection is
 * properly cleaned up, the dlcx flag should be set. In other cases
@@ -205,16 +215,6 @@
osmo_fsm_inst_state_chg(fi, ST_HALT, 0, 0);
osmo_fsm_inst_dispatch(fi, EV_TEARDOWN_ERROR, mgcp_ctx);
}
-
-   /* Request the higher layers (gsm_04_08.c) to release the call. If the
-* problem occured after msc_mgcp_call_release() was calls, remain
-* silent because we already got informed and the higher layers might
-* already freed their context information (trans). */
-   if (!mgcp_ctx->free_ctx) {
-   mncc_set_cause(&mncc, GSM48_CAUSE_LOC_TRANS_NET,
-  GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
-   mncc_tx_to_cc(mgcp_ctx->trans->net, MNCC_REL_REQ, &mncc);
-   }
 }

 /* Timer callback to shut down in case of connectivity problems */

--
To view, visit https://gerrit.osmocom.org/11146
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5df17c19e2a68c019f7eaf582b14585caa54b32a
Gerrit-Change-Number: 11146
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 

Change in osmo-ttcn3-hacks[master]: bts: Add module parameters with tolerance to support real HW

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11083 )

Change subject: bts: Add module parameters with tolerance to support real HW
..


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/11083/4//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11083/4//COMMIT_MSG@7
PS4, Line 7: bts: Add module parameters with tolerance to support real HW
If the commit message states that we "add module parameters",
it should add module parameters, but not L1CTL/L3 templates.

A separate change makes sense I think ;)


https://gerrit.osmocom.org/#/c/11083/4/library/L1CTL_Types.ttcn
File library/L1CTL_Types.ttcn:

https://gerrit.osmocom.org/#/c/11083/4/library/L1CTL_Types.ttcn@281
PS4, Line 281: L1ctlDataReq
The L1CTL_DATA_REQ is not only used to carry SACCH messages.
Other message types (non-SACCH) have no L1 SACCH header.

It should actually contain the 'l1ctl_info_ul' header,
see OsmocomBB/l1ctl_proto.h for details.

Anyway, the L1CTL implementation should be abstracted
from this. What about L3_Templates.ttcn?



--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 12:10:17 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Add module parameters with tolerance to support real HW

[Pau Espin Pedrol]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11083

to look at the new patch set (#4).

Change subject: bts: Add module parameters with tolerance to support real HW
..

bts: Add module parameters with tolerance to support real HW

When we don't use trxcon (ie we run real HW) we cannot set some
parameters like ms power level, so we need to relax template matching
when we receive UL measurements in that case.

This commit makes tests TC_meas_res_sign_tchf and
TC_meas_res_sign_tchh_toa256 pass with motorola CXX and osmo-trx+osmo-bts-trx.

Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
---
M bts/BTS_Tests.ttcn
M library/L1CTL_Types.ttcn
2 files changed, 66 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/83/11083/4
--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmocom-bb[master]: trxcon/sched_prim.c: drop redundant tn validation

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11145


Change subject: trxcon/sched_prim.c: drop redundant tn validation
..

trxcon/sched_prim.c: drop redundant tn validation

Change-Id: I553b4cc39b2efd7b60346160c57f01ee4cf066be
---
M src/host/trxcon/sched_prim.c
1 file changed, 0 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/45/11145/1

diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c
index e03f93f..2067900 100644
--- a/src/host/trxcon/sched_prim.c
+++ b/src/host/trxcon/sched_prim.c
@@ -102,10 +102,6 @@

/* Determine TS index */
tn = chan_nr & 0x7;
-   if (tn > 7) {
-   LOGP(DSCH, LOGL_ERROR, "Incorrect TS index %u\n", tn);
-   return -EINVAL;
-   }

/* Check whether required timeslot is allocated and configured */
ts = trx->ts_list[tn];

--
To view, visit https://gerrit.osmocom.org/11145
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I553b4cc39b2efd7b60346160c57f01ee4cf066be
Gerrit-Change-Number: 11145
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..


Patch Set 4:

(1 comment)

> I expect a similar patch for l23_api/l1 firmware

Sure, I am going to work on it too :)

> as there's some similar code there, right?

It is similar, but the global state is used there,
so having multiple independent connections with Calypso PHY
is not possible. Anyway, this is not that important.

https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:

https://gerrit.osmocom.org/#/c/11138/4/src/host/trxcon/sched_prim.c@182
PS4, Line 182:   * FIXME: this would require having access to the trx_instance,
Let's do it later in a separate change.



--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 11:12:51 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Vadim Yanitskiy]

Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11138

to look at the new patch set (#4).

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..

trxcon/scheduler: fix Measurement Reporting on SACCH

According to 3GPP TS 04.08, section 3.4.1, SACCH logical channel
accompanies either a traffic or a signaling channel. It has the
particularity that continuous transmission must occur in both
directions, so on the Uplink direction measurement result messages
are sent at each possible occasion when nothing else has to be sent.
The LAPDm fill frames (0x01, 0x03, 0x01, 0x2b, ...) are not
applicable on SACCH channels!

Unfortunately, 3GPP TS 04.08 doesn't clearly state which "else
messages" besides Measurement Reports can be send by the MS on
SACCH channels. However, in sub-clause 3.4.1 it's stated that
the interval between two successive measurement result messages
shall not exceed one L2 frame.

This change introduces a separate handler for SACCH primitives,
which dequeues a SACCH primitive from transmit queue, if present.
Otherwise it dequeues a cached Measurement Report (the last
received one). Finally, if the cache is empty, a "dummy"
measurement report is used. When it's possible,
a non-MR primitive is prioritized.

Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Related: OS#2988
---
M src/host/trxcon/sched_prim.c
M src/host/trxcon/sched_trx.c
M src/host/trxcon/sched_trx.h
3 files changed, 211 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/38/11138/4
--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@143
PS2, Line 143: "Dummy" Measurement Report
> should the L1 SACCH header even of the dummy not contain the actual MS power 
> level that is used / th […]
Done


https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@192
PS2, Line 192:  LOGP(DSCHD, LOGL_NOTICE, "Transmitting a %s Measurement Report "
> We are not transmitting here. […]
Done


https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_trx.h
File src/host/trxcon/sched_trx.h:

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_trx.h@196
PS2, Line 196:  uint8_t mr_tx_last; /*!< 0x01 - yes, 0x00 - no */
> why not using a bool here?
Done



--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 10:58:21 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Vadim Yanitskiy]

Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11138

to look at the new patch set (#3).

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..

trxcon/scheduler: fix Measurement Reporting on SACCH

According to 3GPP TS 04.08, section 3.4.1, SACCH logical channel
accompanies either a traffic or a signaling channel. It has the
particularity that continuous transmission must occur in both
directions, so on the Uplink direction measurement result messages
are sent at each possible occasion when nothing else has to be sent.
The LAPDm fill frames (0x01, 0x03, 0x01, 0x2b, ...) are not
applicable on SACCH channels!

Unfortunately, 3GPP TS 04.08 doesn't clearly state which "else
messages" besides Measurement Reports can be send by the MS on
SACCH channels. However, in sub-clause 3.4.1 it's stated that
the interval between two successive measurement result messages
shall not exceed one L2 frame.

This change introduces a separate handler for SACCH primitives,
which dequeues a SACCH primitive from transmit queue, if present.
Otherwise it dequeues a cached Measurement Report (the last
received one). Finally, if the cache is empty, a "dummy"
measurement report is used. When it's possible,
a non-MR primitive is prioritized.

Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Related: OS#2988
---
M src/host/trxcon/sched_prim.c
M src/host/trxcon/sched_trx.c
M src/host/trxcon/sched_trx.h
3 files changed, 204 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/38/11138/3
--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
..


Patch Set 2: -Code-Review


--
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 28 Sep 2018 10:50:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes