Change in osmo-gsm-tester[master]: ms_driver: Fix subject in the header

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/11649


Change subject: ms_driver: Fix subject in the header
..

ms_driver: Fix subject in the header

Change-Id: I47e688b9fe3aef6679e3c82c641393ab041cbec3
---
M src/osmo_ms_driver/location_update_test.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/49/11649/1

diff --git a/src/osmo_ms_driver/location_update_test.py 
b/src/osmo_ms_driver/location_update_test.py
index 010c278..dfa33c3 100644
--- a/src/osmo_ms_driver/location_update_test.py
+++ b/src/osmo_ms_driver/location_update_test.py
@@ -1,4 +1,4 @@
-# osmo_ms_driver: Locationg Update Test
+# osmo_ms_driver: Location Update Test
 # Create MS's and wait for the Location Update to succeed.
 #
 # Copyright (C) 2018 by Holger Hans Peter Freyther

--
To view, visit https://gerrit.osmocom.org/11649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47e688b9fe3aef6679e3c82c641393ab041cbec3
Gerrit-Change-Number: 11649
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-gsm-tester[master]: ms_driver: Switch to process.Process from subprocess

[Holger Freyther]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11597

to look at the new patch set (#2).

Change subject: ms_driver: Switch to process.Process from subprocess
..

ms_driver: Switch to process.Process from subprocess

Use a single tmp/rundir for all these instances. In the next step
we can create separate directories.

Change-Id: Icf4d4e161ac4283a63ed4e0745b375e7e6a25004
---
M src/osmo_gsm_tester/ms_driver.py
M src/osmo_ms_driver/__main__.py
M src/osmo_ms_driver/location_update_test.py
M src/osmo_ms_driver/starter.py
4 files changed, 27 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/97/11597/2
--
To view, visit https://gerrit.osmocom.org/11597
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf4d4e161ac4283a63ed4e0745b375e7e6a25004
Gerrit-Change-Number: 11597
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: ms_driver: use the util.Dir and create one dir per instance

[Holger Freyther]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11598

to look at the new patch set (#2).

Change subject: ms_driver: use the util.Dir and create one dir per instance
..

ms_driver: use the util.Dir and create one dir per instance

Change-Id: Ie0f2fe99f6a6640606eb4e69fb1a2d22eae9b2c8
---
M src/osmo_gsm_tester/ms_driver.py
M src/osmo_ms_driver/__main__.py
M src/osmo_ms_driver/starter.py
3 files changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/98/11598/2
--
To view, visit https://gerrit.osmocom.org/11598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie0f2fe99f6a6640606eb4e69fb1a2d22eae9b2c8
Gerrit-Change-Number: 11598
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-gsm-tester[master]: ms_driver: Consult the suite to get the binaries

[Holger Freyther]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11599

to look at the new patch set (#2).

Change subject: ms_driver: Consult the suite to get the binaries
..

ms_driver: Consult the suite to get the binaries

Change-Id: I7fbb04cf67fe21378aacefcf1a15533d20d10d49
---
M src/osmo_gsm_tester/ms_driver.py
1 file changed, 29 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/99/11599/2
--
To view, visit https://gerrit.osmocom.org/11599
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fbb04cf67fe21378aacefcf1a15533d20d10d49
Gerrit-Change-Number: 11599
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ci[master]: ansible: Wrap distro version number as string for ansible

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/11648


Change subject: ansible: Wrap distro version number as string for ansible
..

ansible: Wrap distro version number as string for ansible

Change-Id: I58591ee37c6ec1479778c3f90ed8004a7e2adf1e
---
M ansible/roles/osmocom-jenkins-slave/tasks/debian.yml
M ansible/roles/osmocom-jenkins-slave/tasks/main.yml
M ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
3 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/48/11648/1

diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml 
b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml
index 87a616c..30e4ece 100644
--- a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml
+++ b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml
@@ -40,4 +40,4 @@
 install_recommends: no
   with_items:
 - openjdk-8-jre-headless
-  when: ansible_distribution == 'Debian' and ansible_distribution_version >= 9
+  when: ansible_distribution == 'Debian' and ansible_distribution_version >= 
'9'
diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml 
b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml
index 98cae55..36bc424 100644
--- a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml
+++ b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml
@@ -27,7 +27,7 @@

 - name: install ttcn3 dependencies
   include_tasks: ttcn3-slave.yml
-  when: ttcn3_slave and ansible_distribution == 'Debian' and 
ansible_distribution_version >= 9
+  when: ttcn3_slave and ansible_distribution == 'Debian' and 
ansible_distribution_version >= '9'

 - name: copy .gitconfig
   copy:
diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml 
b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
index 16e72ed..b2a2f2b 100644
--- a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
+++ b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
@@ -105,7 +105,7 @@
 install_recommends: no
   with_items:
 - liblua5.3-dev
-  when: ansible_distribution == 'Debian' and ansible_distribution_version >= 9
+  when: ansible_distribution == 'Debian' and ansible_distribution_version >= 
'9'

 - name: install liblimesuite-dev for stretch or later
   apt:
@@ -115,4 +115,4 @@
 install_recommends: no
   with_items:
 - liblimesuite-dev
-  when: ansible_distribution == 'Debian' and ansible_distribution_version >= 9
+  when: ansible_distribution == 'Debian' and ansible_distribution_version >= 
'9'

--
To view, visit https://gerrit.osmocom.org/11648
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58591ee37c6ec1479778c3f90ed8004a7e2adf1e
Gerrit-Change-Number: 11648
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-gsm-tester[master]: ms_driver: Allow to specify env and binary name/path

[Holger Freyther]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11596

to look at the new patch set (#2).

Change subject: ms_driver: Allow to specify env and binary name/path
..

ms_driver: Allow to specify env and binary name/path

For the proper trial/suite integration we can't assume that the
virtphy/mobile are in the PATH and that they can be executed
direcyly (e.g. need a LD_LIBRARY_PATH to be applied).

Introduce BinaryOptions to pass the name/path of the two executables
and the env to use. Default this to virtphy/mobile and an empty
environment.

Change-Id: I79a57e53bc20613ac061453c24fd29a6d05e1721
---
M src/osmo_gsm_tester/ms_driver.py
M src/osmo_ms_driver/__main__.py
M src/osmo_ms_driver/location_update_test.py
M src/osmo_ms_driver/starter.py
4 files changed, 27 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/96/11596/2
--
To view, visit https://gerrit.osmocom.org/11596
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79a57e53bc20613ac061453c24fd29a6d05e1721
Gerrit-Change-Number: 11596
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

[Holger Freyther]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11580

to look at the new patch set (#3).

Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH
..

misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

Instead of each binary launcher having to check if there is a lib/
directory and then setting a LD_LIBRARY_PATH we can use an RPATH and
know these binaries pick-up the right libraries.

This requires I6e4ad2e3855af7bcefc22d4190cc4e6f58581857.

Change-Id: If771767dd82662e13b6b10ee7a8b8d0c84dcbdb1
---
M contrib/jenkins-build-common.sh
1 file changed, 26 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/80/11580/3
--
To view, visit https://gerrit.osmocom.org/11580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If771767dd82662e13b6b10ee7a8b8d0c84dcbdb1
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Jenkins build is back to normal : master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #2392

[jenkins]

See 

Build failed in Jenkins: master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #2391

[jenkins]

See 


--
[...truncated 677.98 KB...]
  CC   HNBRegisterAccept.o
  CC   HNBRegisterReject.o
  CC   UERegisterRequest.o
  CC   UERegisterAccept.o
  CC   UERegisterReject.o
  CC   UEDe-Register.o
  CC   HNBDe-Register.o
  CC   ErrorIndication.o
  CC   CSGMembershipUpdate.o
  CC   TNLUpdateRequest.o
  CC   TNLUpdateResponse.o
  CC   TNLUpdateFailure.o
  CC   HNBConfigTransferRequest.o
  CC   HNBConfigTransferResponse.o
  CC   RelocationComplete.o
  CC   U-RNTIQueryRequest.o
  CC   U-RNTIQueryResponse.o
  CC   PrivateMessage.o
  CC   IE.o
  AR   libosmo-asn1-hnbap.a
ar: `u' modifier ignored since `D' is the default (see `U')
make[4]: Leaving directory 
'
Making all in rua
make[4]: Entering directory 
'
  CC   RUA_Presence.o
  CC   RUA_Criticality.o
  CC   RUA_ProcedureCode.o
  CC   RUA_ProtocolIE-ID.o
  CC   RUA_PrivateIE-ID.o
  CC   RUA_TriggeringMessage.o
  CC   RUA_IE-Extensions.o
  CC   RUA_CN-DomainIndicator.o
  CC   RUA_CSGMembershipStatus.o
  CC   RUA_Establishment-Cause.o
  CC   RUA_Context-ID.o
  CC   RUA_IntraDomainNasNodeSelector.o
  CC   RUA_Gsm-map-IDNNS.o
  CC   RUA_Ansi-41-IDNNS.o
  CC   RUA_RANAP-Message.o
  CC   RUA_RoutingParameter.o
  CC   RUA_Cause.o
  CC   RUA_CauseRadioNetwork.o
  CC   RUA_CauseTransport.o
  CC   RUA_CauseProtocol.o
  CC   RUA_CauseMisc.o
  CC   RUA_CriticalityDiagnostics.o
In file included from 
:8:0,
 from 
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:14,
 from ../../include/osmocom/rua/RUA_CriticalityDiagnostics.h:17,
 from RUA_CriticalityDiagnostics.c:7:
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:23: warning: 
‘struct Member’ declared inside parameter list will not be visible outside of 
this definition or declaration
  A_SEQUENCE_OF(struct Member {
   ^
:17:16:
 note: in definition of macro ‘A_SET_OF’
   void (*free)(type *);   \
^~~~
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:2: note: in 
expansion of macro ‘A_SEQUENCE_OF’
  A_SEQUENCE_OF(struct Member {
  ^
  CC   RUA_CriticalityDiagnostics-IE-List.o
  CC   RUA_TypeOfError.o
  CC   RUA_RUA-PDU.o
  CC   RUA_InitiatingMessage.o
In file included from 
:8:0,
 from 
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:14,
 from RUA_CriticalityDiagnostics-IE-List.c:7:
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:23: warning: 
‘struct Member’ declared inside parameter list will not be visible outside of 
this definition or declaration
  A_SEQUENCE_OF(struct Member {
   ^
:17:16:
 note: in definition of macro ‘A_SET_OF’
   void (*free)(type *);   \
^~~~
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:2: note: in 
expansion of macro ‘A_SEQUENCE_OF’
  A_SEQUENCE_OF(struct Member {
  ^
  CC   RUA_SuccessfulOutcome.o
  CC   RUA_UnsuccessfulOutcome.o
  CC   RUA_Connect.o
  CC   RUA_DirectTransfer.o
  CC   RUA_Disconnect.o
  CC   RUA_ConnectionlessTransfer.o
  CC   RUA_ErrorIndication.o
  CC   RUA_PrivateMessage.o
  CC   RUA_IE.o
  AR   libosmo-asn1-rua.a
ar: `u' modifier ignored since `D' is the default (see `U')
make[4]: Leaving directory 
'
Making all in ranap
make[4]: Entering directory 
'
  CC   RANAP_Criticality.lo
  CC 

Jenkins build is back to normal : master-osmo-bts » oct,master,default,osmocom-master-debian9 #1379

[jenkins]

See 

Change in osmo-bsc[master]: LCLS: move MGCP MDCX into separate function

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11564 )

Change subject: LCLS: move MGCP MDCX into separate function
..

LCLS: move MGCP MDCX into separate function

Move code using MDCX via MGCP into separate function to make adding
alternative MDCX variants easier.

Change-Id: I5fafa3b12a39c83bdf64e16e192dd2454d069cf4
Related: OS#3659
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 11 insertions(+), 9 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index b8bf601..e642976 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -227,6 +227,15 @@
osmo_fsm_inst_dispatch(conn->lcls.fi, LCLS_EV_APPLY_CFG_CSC, NULL);
 }

+/* Close the loop for LCLS using MGCP */
+static inline void lcls_mdcx(const struct gsm_subscriber_connection *conn, 
struct mgcp_conn_peer *mdcx_info)
+{
+   mgcp_pick_codec(mdcx_info, conn->lchan, false);
+
+   mgw_endpoint_ci_request(conn->user_plane.mgw_endpoint_ci_msc, 
MGCP_VERB_MDCX, mdcx_info,
+   NULL, 0, 0, NULL);
+}
+
 static void lcls_break_local_switching(struct gsm_subscriber_connection *conn)
 {
struct mgcp_conn_peer mdcx_info;
@@ -242,11 +251,7 @@
.port = conn->user_plane.msc_assigned_rtp_port,
};
osmo_strlcpy(mdcx_info.addr, conn->user_plane.msc_assigned_rtp_addr, 
sizeof(mdcx_info.addr));
-   mgcp_pick_codec(_info, conn->lchan, false);
-
-   mgw_endpoint_ci_request(conn->user_plane.mgw_endpoint_ci_msc,
-   MGCP_VERB_MDCX, _info,
-   NULL, 0, 0, NULL);
+   lcls_mdcx(conn, _info);
 }

 static bool lcls_enable_possible(struct gsm_subscriber_connection *conn)
@@ -596,10 +601,7 @@
mdcx_info = *other_mgw_info;
/* Make sure the request doesn't want to use the other side's endpoint 
string. */
mdcx_info.endpoint[0] = 0;
-   mgcp_pick_codec(_info, conn->lchan, false);
-   mgw_endpoint_ci_request(conn->user_plane.mgw_endpoint_ci_msc,
-   MGCP_VERB_MDCX, _info,
-   NULL, 0, 0, NULL);
+   lcls_mdcx(conn, _info);
 }

 static void lcls_locally_switched_wait_break_fn(struct osmo_fsm_inst *fi, 
uint32_t event, void *data)

--
To view, visit https://gerrit.osmocom.org/11564
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fafa3b12a39c83bdf64e16e192dd2454d069cf4
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: PCU: cleanup test config

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11643 )

Change subject: PCU: cleanup test config
..

PCU: cleanup test config

* remove unused parameters
* add expected results
* use control for default test execution
* only tests which could (in theory) pass are left in control

Previously generic control had some tests which never called
"setverdict(pass)" which means they would always fail. Such tests might
be useful during development but should not be part of test set executed
by default.

Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Related: OS#2890
---
M pcu/PCU_Tests.cfg
M pcu/PCU_Tests.ttcn
A pcu/expected-results.xml
3 files changed, 12 insertions(+), 22 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests.cfg b/pcu/PCU_Tests.cfg
index 7e0b9f2..5975290 100644
--- a/pcu/PCU_Tests.cfg
+++ b/pcu/PCU_Tests.cfg
@@ -7,10 +7,6 @@
 ConsoleMask := ERROR | WARNING | TESTCASE | TIMEROP_START | DEBUG_ENCDEC

 [MODULE_PARAMETERS]
-#mp_local_ip := "192.168.100.239"
-#mp_local_udp_port := 23000
-#mp_remote_ip := "192.168.100.196"
-#mp_remote_udp_port := 21000
 PCU_Tests.mp_nsconfig := {
local_ip := "127.0.0.1",
local_udp_port := 23000,
@@ -36,26 +32,18 @@
 }

 [TESTPORT_PARAMETERS]
-#*.BSCVTY.CTRL_MODE := "client"
-#*.BSCVTY.CTRL_HOSTNAME := "127.0.0.1"
-#*.BSCVTY.CTRL_PORTNUM := "4242"
-#*.BSCVTY.CTRL_LOGIN_SKIPPED := "yes"
-#*.BSCVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes"
-#*.BSCVTY.CTRL_READMODE := "buffered"
-#*.BSCVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes"
-#*.BSCVTY.PROMPT1 := "OpenBSC> "
-#*.BSCVTY.PROMPT2 := "OpenBSC# "
-#*.BSCVTY.REGEX_PROMPT1 := "^OpenBSC.*$"
-
 *.*.udpReuseAddress := "yes";

 [MAIN_CONTROLLER]

 [EXECUTE]
+PCU_Tests.control
+# for internal use only: will always fail when called as part of normal routine
 #PCU_Tests.TC_selftest_llc
 #PCU_Tests.TC_selftest_rlcmac
 #PCU_Tests.TC_selftest_bssgp
 #PCU_Tests.TC_nsem
 #PCU_Tests.TC_paging
-PCU_Tests.TC_rach
+#PCU_Tests.TC_rach
 #PCU_Tests.TC_selftest_rr
+#PCU_Tests.TC_dl_tbf
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index a63ca1d..adbc73e 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -630,12 +630,8 @@


control {
-   execute(TC_selftest_bssgp());
execute(TC_selftest_ns());
-   execute(TC_selftest_llc());
-   execute(TC_selftest_rr());
-   execute(TC_selftest_rlcmac());
-   execute(TC_nsem());
-   execute(TC_paging());
+   execute(TC_ul_tbf_single_llc_sizes());
+   execute(TC_ul_tbf());
}
 };
diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml
new file mode 100644
index 000..aec661d
--- /dev/null
+++ b/pcu/expected-results.xml
@@ -0,0 +1,6 @@
+
+
+  
+  
+  
+

--
To view, visit https://gerrit.osmocom.org/11643
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Gerrit-Change-Number: 11643
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-ttcn3-hacks[master]: NS: print ip:port on error

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11644 )

Change subject: NS: print ip:port on error
..

NS: print ip:port on error

Change-Id: I2f558021b7754db9593934888d12f9c879dc2988
---
M library/NS_Emulation.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/NS_Emulation.ttcn b/library/NS_Emulation.ttcn
index 7cccb25..ca4d1d6 100644
--- a/library/NS_Emulation.ttcn
+++ b/library/NS_Emulation.ttcn
@@ -83,7 +83,9 @@
/* Connect the UDP socket */
res := f_IPL4_connect(NSCP, config.remote_ip, 
config.remote_udp_port, config.local_ip, config.local_udp_port, 0, { udp := 
{}});
if (not ispresent(res.connId)) {
-   setverdict(fail, "Could not connect NS UDP socket, 
check your configuration");
+   setverdict(fail, "Could not connect NS UDP socket from 
" &
+  config.local_ip & ":"  & 
int2str(config.local_udp_port) &
+  " to " & config.remote_ip & ":" & 
int2str(config.remote_udp_port));
mtc.stop;
}
g_conn_id := res.connId;

--
To view, visit https://gerrit.osmocom.org/11644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f558021b7754db9593934888d12f9c879dc2988
Gerrit-Change-Number: 11644
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 

Jenkins build is back to normal : master-osmo-bts » lc15, origin/nrw/litecell15,default,osmocom-master-debian9 #1378

[jenkins]

See 

Build failed in Jenkins: master-osmo-bts » oct,master,default,osmocom-master-debian9 #1378

[jenkins]

See 


--
[...truncated 59.49 KB...]
Making install in src
make[2]: Entering directory 
'
  GEN  crc8gen.c
  GEN  crc16gen.c
  GEN  crc32gen.c
  GEN  crc64gen.c
make  install-am
make[3]: Entering directory 
'
  CC   timer.lo
  CC   timer_gettimeofday.lo
  CC   timer_clockgettime.lo
  CC   signal.lo
  CC   select.lo
  CC   bits.lo
  CC   bitvec.lo
  CC   msgb.lo
  CC   bitcomp.lo
  CC   counter.lo
  CC   fsm.lo
  CC   utils.lo
  CC   write_queue.lo
  CC   logging.lo
  CC   socket.lo
  CC   logging_syslog.lo
  CC   logging_gsmtap.lo
  CC   rate_ctr.lo
  CC   gsmtap_util.lo
  CC   crc16.lo
  CC   panic.lo
  CC   backtrace.lo
  CC   conv.lo
  CC   application.lo
  CC   rbtree.lo
  CC   strrb.lo
  CC   loggingrb.lo
  CC   crc8gen.lo
  CC   crc16gen.lo
  CC   crc32gen.lo
  CC   crc64gen.lo
  CC   macaddr.lo
  CC   stat_item.lo
  CC   stats.lo
  CC   stats_statsd.lo
  CC   prim.lo
  CC   conv_acc.lo
  CC   conv_acc_generic.lo
  CC   sercomm.lo
  CC   prbs.lo
  CC   isdnhdlc.lo
  CC   conv_acc_sse.lo
  CC   conv_acc_sse_avx.lo
  CC   plugin.lo
  CC   msgfile.lo
  CC   serial.lo
  CCLD libosmocore.la
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p 
'
 /bin/bash ../libtool   --mode=install /usr/bin/install -c   libosmocore.la 
'
libtool: install: /usr/bin/install -c .libs/libosmocore.so.11.0.0 

libtool: install: (cd 

 && { ln -s -f libosmocore.so.11.0.0 libosmocore.so.11 || { rm -f 
libosmocore.so.11 && ln -s libosmocore.so.11.0.0 libosmocore.so.11; }; })
libtool: install: (cd 

 && { ln -s -f libosmocore.so.11.0.0 libosmocore.so || { rm -f libosmocore.so 
&& ln -s libosmocore.so.11.0.0 libosmocore.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocore.lai 

libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/sbin" 
ldconfig -n 

--
Libraries have been installed in:
   


If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the '-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the 'LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the 'LD_RUN_PATH' environment variable
 during linking
   - use the '-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to '/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[4]: 

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.18

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11609 )

Change subject: layer23: Fix build against gpsd >= 3.18
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11609
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e97d3e8c3688064c959ea60ecef50cfbbc1bcd6
Gerrit-Change-Number: 11609
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:47:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.18

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11609 )

Change subject: layer23: Fix build against gpsd >= 3.18
..

layer23: Fix build against gpsd >= 3.18

Change-Id: I0e97d3e8c3688064c959ea60ecef50cfbbc1bcd6
---
M src/host/layer23/src/common/gps.c
1 file changed, 13 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/host/layer23/src/common/gps.c 
b/src/host/layer23/src/common/gps.c
index 3ec7377..35ee416 100644
--- a/src/host/layer23/src/common/gps.c
+++ b/src/host/layer23/src/common/gps.c
@@ -60,9 +60,20 @@

 #if GPSD_API_MAJOR_VERSION >= 5
 static struct gps_data_t _gdata;
-#define gps_poll gps_read
 #endif

+static inline int compat_gps_read(struct gps_data_t *data)
+{
+/* API break in gpsd 6bba8b329fc7687b15863d30471d5af402467802 */
+#if GPSD_API_MAJOR_VERSION >= 7 && GPSD_API_MINOR_VERSION >= 0
+   return gps_read(data, NULL, 0);
+#elif GPSD_API_MAJOR_VERSION >= 5
+   return gps_read(data);
+#else
+   return gps_poll(data);
+#endif
+}
+
 int osmo_gpsd_cb(struct osmo_fd *bfd, unsigned int what)
 {
struct tm *tm;
@@ -85,7 +96,7 @@
 #endif

/* polling returned an error */
-   if (gps_poll(gdata))
+   if (compat_gps_read(gdata))
goto gps_not_ready;

/* data are valid */

--
To view, visit https://gerrit.osmocom.org/11609
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e97d3e8c3688064c959ea60ecef50cfbbc1bcd6
Gerrit-Change-Number: 11609
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-ttcn3-hacks[master]: bts: Introduce mp_ipa_up_timeout parameter

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11568 )

Change subject: bts: Introduce mp_ipa_up_timeout parameter
..

bts: Introduce mp_ipa_up_timeout parameter

Some test env may take more than 10 seconds to (re-)start a BTS, so
let's make it variable through this parameter.
For instance it was observed that running osmo-bts-sysmo through ssh
inside a sysmobts can sometimes take a good number of seconds (specially
because ssh connection can take a while to be established successfully).

Change-Id: Ieb046358d8266ac94bd7b9e916e85f84de3ad319
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 64c2510..cde9562 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -63,6 +63,8 @@
integer mp_ms_power_level_exp := 7;
integer mp_ms_actual_ta_exp := 0;
integer mp_timing_offset_256syms_exp := 512;
+   /* Time to wait for RSL conn from BTS during startup of test */
+   float mp_ipa_up_timeout := 10.0;
 }

 type record of RslChannelNr ChannelNrs;
@@ -296,7 +298,7 @@

 /* global init function */
 function f_init(charstring id := "BTS-Test") runs on test_CT {
-   timer T := 10.0;
+   timer T := mp_ipa_up_timeout;
g_AllChannels := {
/* TS 1..4: TCH/F */
valueof(ts_RslChanNr_Bm(1)), valueof(ts_RslChanNr_Bm(2)),

--
To view, visit https://gerrit.osmocom.org/11568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb046358d8266ac94bd7b9e916e85f84de3ad319
Gerrit-Change-Number: 11568
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 

Change in osmocom-bb[master]: cosmetic: fix trailing whitespace

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11608 )

Change subject: cosmetic: fix trailing whitespace
..

cosmetic: fix trailing whitespace

Change-Id: I5c1a6d98079ad846d114584a17ba9d80d95e0595
---
M src/host/layer23/src/common/gps.c
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved



diff --git a/src/host/layer23/src/common/gps.c 
b/src/host/layer23/src/common/gps.c
index e9aaa97..3ec7377 100644
--- a/src/host/layer23/src/common/gps.c
+++ b/src/host/layer23/src/common/gps.c
@@ -234,7 +234,7 @@
if (line[23] == 'W')
longitude = 360.0 - longitude;
g.longitude = longitude;
-
+
LOGP(DGPS, LOGL_DEBUG, "%s\n", line);
LOGP(DGPS, LOGL_INFO, " time=%02d:%02d:%02d %04d-%02d-%02d, "
"diff-to-host=%d, latitude=%do%.4f, longitude=%do%.4f\n",
@@ -324,8 +324,8 @@
case  38400:
baud = B38400; break;
case  57600:
-   baud = B57600; break;
-   case 115200:
+   baud = B57600; break;
+   case 115200:
baud = B115200;break;
}

@@ -399,4 +399,3 @@
return;
}
 }
-

--
To view, visit https://gerrit.osmocom.org/11608
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c1a6d98079ad846d114584a17ba9d80d95e0595
Gerrit-Change-Number: 11608
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 

Change in osmo-ttcn3-hacks[master]: NS: print ip:port on error

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11644 )

Change subject: NS: print ip:port on error
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f558021b7754db9593934888d12f9c879dc2988
Gerrit-Change-Number: 11644
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:46:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: PCU: cleanup test config

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11643 )

Change subject: PCU: cleanup test config
..


Patch Set 1:

as an addition, the split of the config file between a .default file and a .cfg 
file makes sense.  The .default should contain things that are typically the 
same, like NSEI settings and the like, while the .cfg contains IP addresses and 
ports that are more likely to be overridden by local setup. This can be a 
follow-up patch.


--
To view, visit https://gerrit.osmocom.org/11643
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Gerrit-Change-Number: 11643
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:45:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: PCU: cleanup test config

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11643 )

Change subject: PCU: cleanup test config
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11643
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Gerrit-Change-Number: 11643
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:45:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: socket.c: fix IP and port buffer sizes

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11520 )

Change subject: socket.c: fix IP and port buffer sizes
..

socket.c: fix IP and port buffer sizes

Use INET6_ADDRSTRLEN (46) instead of 64 for IP address buffers, and 6
instead of 16 for port buffers (the highest possible port number is
65535).

Change-Id: Ia25e2f3277ad2f60df31c08d12f42c1e6d2a14a6
---
M src/socket.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/socket.c b/src/socket.c
index c7e1c9d..0e17a28 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -57,7 +57,7 @@
const char *host, uint16_t port, bool 
passive)
 {
struct addrinfo hints, *result;
-   char portbuf[16];
+   char portbuf[6];
int rc;

snprintf(portbuf, sizeof(portbuf), "%u", port);
@@ -698,7 +698,7 @@
 {
struct sockaddr sa;
socklen_t len = sizeof(sa);
-   char ipbuf[64], portbuf[16];
+   char ipbuf[INET6_ADDRSTRLEN], portbuf[6];
int rc;

rc = local ? getsockname(fd, , ) : getpeername(fd, , );
@@ -769,8 +769,8 @@
  */
 char *osmo_sock_get_name(void *ctx, int fd)
 {
-   char hostbuf_l[64], hostbuf_r[64];
-   char portbuf_l[16], portbuf_r[16];
+   char hostbuf_l[INET6_ADDRSTRLEN], hostbuf_r[INET6_ADDRSTRLEN];
+   char portbuf_l[6], portbuf_r[6];

/* get local */
if (osmo_sock_get_name2(fd, hostbuf_l, sizeof(hostbuf_l), portbuf_l, 
sizeof(portbuf_l), true))

--
To view, visit https://gerrit.osmocom.org/11520
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia25e2f3277ad2f60df31c08d12f42c1e6d2a14a6
Gerrit-Change-Number: 11520
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

[Harald Welte]

Harald Welte has removed a vote on this change.

Change subject: ansible: gsm-tester: Support power cycling multiple quad modems
..


Removed Verified+1 by Harald Welte 
--
To view, visit https://gerrit.osmocom.org/11628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11628 )

Change subject: ansible: gsm-tester: Support power cycling multiple quad modems
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:44:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: ansible: gsm-tester: Add IP addr for umtrx

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11619 )

Change subject: ansible: gsm-tester: Add IP addr for umtrx
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11619
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fb65e3c337fc82c787e925fbbdf9eaf7569defd
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:43:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: core/msgb.h: introduce msgb_l4len() helper

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11647 )

Change subject: core/msgb.h: introduce msgb_l4len() helper
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11647
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I755f2d654bbdad2a8b4f94df9023bdd370b07ae6
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:43:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: core/msgb.h: introduce msgb_l4len() helper

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11647 )

Change subject: core/msgb.h: introduce msgb_l4len() helper
..

core/msgb.h: introduce msgb_l4len() helper

There is already a group of similar functions for L1, L2 and L3,
but L4 was missing. The L4 is usually used for parsing of complex
L3 messages, such as SS/USSD and SMS.

This change introduces a similar halper for L4.

Change-Id: I755f2d654bbdad2a8b4f94df9023bdd370b07ae6
---
M TODO-RELEASE
M include/osmocom/core/msgb.h
2 files changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 64833d2..5222ec9 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -10,3 +10,4 @@
 libosmogsm gsm0480_l3hdr_push()removed from gsm/gsm0480.h (was not 
exposed)
 libosmogsm gsm48_push_l3hdr()  (re)introduced in gsm/gsm48.h (GSM 
04.08 API)
 libosmogsm gsm48_push_l3hdr_tid()  a wrapper around gsm48_push_l3hdr()
+libosmocoremsgb_l4len  new symbol (exposed as 'static inline' 
in msgb.h)
diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h
index b1cb6ec..8843db0 100644
--- a/include/osmocom/core/msgb.h
+++ b/include/osmocom/core/msgb.h
@@ -169,6 +169,18 @@
return msgb->tail - (uint8_t *)msgb_l3(msgb);
 }

+/*! determine length of L4 message
+ *  \param[in] msgb message buffer
+ *  \returns size of L4 message in bytes
+ *
+ * This function computes the number of bytes between the tail of the
+ * message and the layer 4 header.
+ */
+static inline unsigned int msgb_l4len(const struct msgb *msgb)
+{
+   return msgb->tail - (uint8_t *)msgb_sms(msgb);
+}
+
 /*! determine the length of the header
  *  \param[in] msgb message buffer
  *  \returns number of bytes between start of buffer and start of msg

--
To view, visit https://gerrit.osmocom.org/11647
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I755f2d654bbdad2a8b4f94df9023bdd370b07ae6
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: jenkins: print gcc version in log

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11646 )

Change subject: jenkins: print gcc version in log
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11646
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfac78868f64213413e80cc52ac585d9d4a2c93
Gerrit-Change-Number: 11646
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:43:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: jenkins: print gcc version in log

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11646 )

Change subject: jenkins: print gcc version in log
..

jenkins: print gcc version in log

Change-Id: I8dfac78868f64213413e80cc52ac585d9d4a2c93
---
M contrib/jenkins_arch.sh
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins_arch.sh b/contrib/jenkins_arch.sh
index 99ce5c1..93dd8bb 100755
--- a/contrib/jenkins_arch.sh
+++ b/contrib/jenkins_arch.sh
@@ -14,7 +14,11 @@
   exit 1
 fi

-set -x -e
+set -x
+
+gcc --version
+
+set -e

 case "$arch" in


--
To view, visit https://gerrit.osmocom.org/11646
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dfac78868f64213413e80cc52ac585d9d4a2c93
Gerrit-Change-Number: 11646
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: core/msgb.h: introduce msgb_l4len() helper

[Vadim Yanitskiy]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11647

to look at the new patch set (#2).

Change subject: core/msgb.h: introduce msgb_l4len() helper
..

core/msgb.h: introduce msgb_l4len() helper

There is already a group of similar functions for L1, L2 and L3,
but L4 was missing. The L4 is usually used for parsing of complex
L3 messages, such as SS/USSD and SMS.

This change introduces a similar halper for L4.

Change-Id: I755f2d654bbdad2a8b4f94df9023bdd370b07ae6
---
M TODO-RELEASE
M include/osmocom/core/msgb.h
2 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/11647/2
--
To view, visit https://gerrit.osmocom.org/11647
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I755f2d654bbdad2a8b4f94df9023bdd370b07ae6
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: core/msgb.h: introduce msgb_l4len() helper

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11647


Change subject: core/msgb.h: introduce msgb_l4len() helper
..

core/msgb.h: introduce msgb_l4len() helper

There is already a group of similar functions for L1, L2 and L3,
but L4 was missing. The L4 is usually used for parsing of complex
L3 messages, such as SS/USSD and SMS.

This change introduces a similar halper for L4.

Change-Id: I755f2d654bbdad2a8b4f94df9023bdd370b07ae6
---
M TODO-RELEASE
M include/osmocom/core/msgb.h
2 files changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/11647/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 64833d2..5222ec9 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -10,3 +10,4 @@
 libosmogsm gsm0480_l3hdr_push()removed from gsm/gsm0480.h (was not 
exposed)
 libosmogsm gsm48_push_l3hdr()  (re)introduced in gsm/gsm48.h (GSM 
04.08 API)
 libosmogsm gsm48_push_l3hdr_tid()  a wrapper around gsm48_push_l3hdr()
+libosmocoremsgb_l4len  new symbol (exposed as 'static inline' 
in msgb.h)
diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h
index b1cb6ec..86177f1 100644
--- a/include/osmocom/core/msgb.h
+++ b/include/osmocom/core/msgb.h
@@ -169,6 +169,18 @@
return msgb->tail - (uint8_t *)msgb_l3(msgb);
 }

+/*! determine length of L4 message
+ *  \param[in] msgb message buffer
+ *  \returns size of L4 message in bytes
+ *
+ * This function computes the number of bytes between the tail of the
+ * message and the layer 4 header.
+ */
+static inline unsigned int msgb_l4len(const struct msgb *msgb)
+{
+   return msgb->tail - (uint8_t *)msgb_l4(msgb);
+}
+
 /*! determine the length of the header
  *  \param[in] msgb message buffer
  *  \returns number of bytes between start of buffer and start of msg

--
To view, visit https://gerrit.osmocom.org/11647
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I755f2d654bbdad2a8b4f94df9023bdd370b07ae6
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 4:

jenkins tests with gcc 6.3.0-18+deb9u1, my gcc is gcc (Debian 8.2.0-9) 8.2.0.

So a) this code will work as soon as we upgrade gcc.
But b) do we really want to depend on newer gcc :/

Appears I need to think of some cumbersome magic to initialize the structs.


--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 20:22:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: jenkins: print gcc version in log

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11646


Change subject: jenkins: print gcc version in log
..

jenkins: print gcc version in log

Change-Id: I8dfac78868f64213413e80cc52ac585d9d4a2c93
---
M contrib/jenkins_arch.sh
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/11646/1

diff --git a/contrib/jenkins_arch.sh b/contrib/jenkins_arch.sh
index 99ce5c1..93dd8bb 100755
--- a/contrib/jenkins_arch.sh
+++ b/contrib/jenkins_arch.sh
@@ -14,7 +14,11 @@
   exit 1
 fi

-set -x -e
+set -x
+
+gcc --version
+
+set -e

 case "$arch" in


--
To view, visit https://gerrit.osmocom.org/11646
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dfac78868f64213413e80cc52ac585d9d4a2c93
Gerrit-Change-Number: 11646
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 2:

hrm.


--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 20:12:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11504/2/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/11504/2/tests/gsm0808/gsm0808_test.c@1721
PS2, Line 1721: struct test_cell_id_matching_data {
> Shouldn't all these structs be static? Maybe that helps with compiler error.
yep, should be static, regardless; thanks for catching. Since I can't reproduce 
the compiler error, let's see what jenkins says this time round.



--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 20:11:52 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11504

to look at the new patch set (#3).

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..

gsm0808: add BSSMAP Cell Identifier matching API

Add
* osmo_lai_cmp() (to use in gsm0808_cell_id_u_matches())
* osmo_cgi_cmp() (to use in gsm0808_cell_id_u_matches())
* gsm0808_cell_id_u_matches() (to re-use for single IDs and lists)
* gsm0808_cell_ids_match()
* gsm0808_cell_id_matches_list()
* Unit tests in gsm0808_test.c

Rationale:

For inter-BSC handover, it is interesting to find matches between *differing*
Cell Identity kinds. For example, if a cell as CGI 23-42-3-5, and a HO for
LAC-CI 3-5 should be handled, we need to see the match.

This is most interesting for osmo-msc, i.e. to direct the BSSMAP Handover
Request towards the correct BSC.

It is also interesting for osmo-bsc's VTY interface, to be able to manage
cells' neighbors and to trigger manual handovers by various Cell Identity
handles, as the user would expect them.

Change-Id: I5535f0d149c2173294538df75764dd181b023312
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/gsm23003.h
M src/gsm/gsm0808_utils.c
M src/gsm/gsm23003.c
M src/gsm/libosmogsm.map
M tests/gsm0808/gsm0808_test.c
M tests/gsm0808/gsm0808_test.ok
7 files changed, 573 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/11504/3
--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-bsc[master]: vty doc: drop "(HO algo 2 only)" strings

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11581 )

Change subject: vty doc: drop "(HO algo 2 only)" strings
..


Patch Set 1: Code-Review+2

let me apply this, since I'm 110% sure and there's no need for anyone to review 
it, really.


--
To view, visit https://gerrit.osmocom.org/11581
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d29542f7dd5bd125d6f10c7783569f13092612
Gerrit-Change-Number: 11581
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 06 Nov 2018 20:01:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: vty doc: drop "(HO algo 2 only)" strings

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11581 )

Change subject: vty doc: drop "(HO algo 2 only)" strings
..

vty doc: drop "(HO algo 2 only)" strings

These indicators are a legacy of early handover_decision_2.c work, where there
were no separate handover1 and handover2 config commands. No need to restate
the abundantly obvious anymore.

Change-Id: Id4d29542f7dd5bd125d6f10c7783569f13092612
---
M include/osmocom/bsc/handover_cfg.h
M src/osmo-bsc/handover_vty.c
M tests/handover_cfg.vty
3 files changed, 26 insertions(+), 27 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/handover_cfg.h 
b/include/osmocom/bsc/handover_cfg.h
index 865fab9..92b5cd4 100644
--- a/include/osmocom/bsc/handover_cfg.h
+++ b/include/osmocom/bsc/handover_cfg.h
@@ -21,11 +21,10 @@
 #define HO_CFG_STR_WIN_RXQUAL HO_CFG_STR_WIN "Received-Quality averaging\n"
 #define HO_CFG_STR_POWER_BUDGET "Neighbor cell power triggering\n" "Neighbor 
cell power triggering\n"
 #define HO_CFG_STR_AVG_COUNT "Number of values to average over\n"
-#define HO_CFG_STR_2 " (HO algo 2 only)\n"
-#define HO_CFG_STR_MIN "Minimum Level/Quality thresholds before triggering HO" 
HO_CFG_STR_2
-#define HO_CFG_STR_AFS_BIAS "Configure bias to prefer AFS (AMR on TCH/F) over 
other codecs" HO_CFG_STR_2
-#define HO_CFG_STR_MIN_TCH "Minimum free TCH timeslots before cell is 
considered congested" HO_CFG_STR_2
-#define HO_CFG_STR_PENALTY_TIME "Set penalty times to wait between repeated 
handovers" HO_CFG_STR_2
+#define HO_CFG_STR_MIN "Minimum Level/Quality thresholds before triggering 
HO\n"
+#define HO_CFG_STR_AFS_BIAS "Configure bias to prefer AFS (AMR on TCH/F) over 
other codecs\n"
+#define HO_CFG_STR_MIN_TCH "Minimum free TCH timeslots before cell is 
considered congested\n"
+#define HO_CFG_STR_PENALTY_TIME "Set penalty times to wait between repeated 
handovers\n"

 #define as_is(x) (x)

@@ -185,14 +184,14 @@
HO_CFG_ONE_MEMBER(bool, hodec2_as_active, 0, \
"handover2 ", "assignment", "0|1", a2bool, "%d", bool2i, \
HO_CFG_STR_HANDOVER2 \
-   "Enable or disable in-call channel re-assignment" HO_CFG_STR_2 \
+   "Enable or disable in-call channel re-assignment\n" \
"Disable in-call assignment\n" \
"Enable in-call assignment\n") \
\
HO_CFG_ONE_MEMBER(bool, hodec2_full_tdma, subset, \
"handover2 ", "tdma-measurement", "full|subset", a2tdma, "%s", 
tdma2a, \
HO_CFG_STR_HANDOVER2 \
-   "Define measurement set of TDMA frames" HO_CFG_STR_2 \
+   "Define measurement set of TDMA frames\n" \
"Full set of 102/104 TDMA frames\n" \
"Sub set of 4 TDMA frames (SACCH)\n") \
\
@@ -241,7 +240,7 @@
HO_CFG_ONE_MEMBER(int, hodec2_ho_max, , \
"handover2 ", "max-handovers", "<1->", atoi, "%d", as_is, \
HO_CFG_STR_HANDOVER2 \
-   "Maximum number of concurrent handovers allowed per cell" 
HO_CFG_STR_2 \
+   "Maximum number of concurrent handovers allowed per cell\n" \
"Number\n") \
\
HO_CFG_ONE_MEMBER(int, hodec2_penalty_max_dist, 300, \
@@ -268,7 +267,7 @@
HO_CFG_ONE_MEMBER(int, hodec2_retries, 0, \
"handover2 ", "retries", "<0-9>", atoi, "%d", as_is, \
HO_CFG_STR_HANDOVER2 \
-   "Immediately retry on handover/assignment failure" HO_CFG_STR_2 
\
+   "Immediately retry on handover/assignment failure\n" \
"Number of retries\n") \

 #define HO_CFG_ALL_MEMBERS \
diff --git a/src/osmo-bsc/handover_vty.c b/src/osmo-bsc/handover_vty.c
index 51e448e..7979511 100644
--- a/src/osmo-bsc/handover_vty.c
+++ b/src/osmo-bsc/handover_vty.c
@@ -106,7 +106,7 @@
 DEFUN(cfg_net_ho_congestion_check_interval, 
cfg_net_ho_congestion_check_interval_cmd,
   "handover2 congestion-check (disabled|<1-999>|now)",
   HO_CFG_STR_HANDOVER2
-  "Configure congestion check interval" HO_CFG_STR_2
+  "Configure congestion check interval\n"
   "Disable congestion checking, do not handover based on cell overload\n"
   "Congestion check interval in seconds (default "
   OSMO_STRINGIFY_VAL(HO_CFG_CONGESTION_CHECK_DEFAULT) ")\n"
diff --git a/tests/handover_cfg.vty b/tests/handover_cfg.vty
index 119eaf5..94c20d9 100644
--- a/tests/handover_cfg.vty
+++ b/tests/handover_cfg.vty
@@ -218,15 +218,15 @@
   windowMeasurement averaging settings
   power Neighbor cell power triggering
   maximum   Maximum Timing-Advance value (i.e. MS distance) before 
triggering HO
-  assignmentEnable or disable in-call channel re-assignment (HO algo 2 
only)
-  tdma-measurement  Define measurement set of TDMA frames 

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11628 )

Change subject: ansible: gsm-tester: Support power cycling multiple quad modems
..


Patch Set 1: Code-Review+2

i hope you verified that it works...


--
To view, visit https://gerrit.osmocom.org/11628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 06 Nov 2018 19:26:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: ipaccess-config: Use enum value for OML IP

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11641 )

Change subject: ipaccess-config: Use enum value for OML IP
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a708c3ba2271d9968daa264736411c9326fc404
Gerrit-Change-Number: 11641
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 06 Nov 2018 19:25:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: ipaccess-config: Use enum value for OML IP

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11641 )

Change subject: ipaccess-config: Use enum value for OML IP
..

ipaccess-config: Use enum value for OML IP

Change-Id: I3a708c3ba2271d9968daa264736411c9326fc404
---
M src/ipaccess/ipaccess-config.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c
index 5491700..0fb5ad9 100644
--- a/src/ipaccess/ipaccess-config.c
+++ b/src/ipaccess/ipaccess-config.c
@@ -409,7 +409,7 @@
msgb_put_u8(nmsg, NM_ATT_IPACC_PRIM_OML_CFG_LIST);
msgb_put_u16(nmsg, len);

-   msgb_put_u8(nmsg, 0x88);
+   msgb_put_u8(nmsg, NM_ATT_IPACC_PRIM_OML_CFG);

/* IP address */
msgb_put_u32(nmsg, ip);

--
To view, visit https://gerrit.osmocom.org/11641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a708c3ba2271d9968daa264736411c9326fc404
Gerrit-Change-Number: 11641
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-ci[master]: ttcn3-testsuites: collect artifacts again

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11618 )

Change subject: ttcn3-testsuites: collect artifacts again
..

ttcn3-testsuites: collect artifacts again

Collect build artifacts just like the manually created jobs did it.

Related: OS#3681
Change-Id: I5b0f5de87125374c9a48d0a47e6a4e655d7ed3bb
---
M jobs/ttcn3-testsuites.yml
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  osmith: Verified



diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index fc4f306..a5c5fe4 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -97,6 +97,13 @@
   notify-every-unstable-build: true
   recipients: lafo...@gnumonks.org
   send-to-individuals: false
+  - archive:
+  allow-empty: false
+  artifacts: logs/**/*
+  case-sensitive: true
+  default-excludes: true
+  fingerprint: false
+  only-if-success: false
 properties:
 - build-blocker:
 use-build-blocker: true

--
To view, visit https://gerrit.osmocom.org/11618
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b0f5de87125374c9a48d0a47e6a4e655d7ed3bb
Gerrit-Change-Number: 11618
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in osmo-ci[master]: ttcn3-testsuites: collect artifacts again

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11618 )

Change subject: ttcn3-testsuites: collect artifacts again
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11618
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b0f5de87125374c9a48d0a47e6a4e655d7ed3bb
Gerrit-Change-Number: 11618
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 06 Nov 2018 19:23:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: NS: print ip:port on error

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11644 )

Change subject: NS: print ip:port on error
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f558021b7754db9593934888d12f9c879dc2988
Gerrit-Change-Number: 11644
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 06 Nov 2018 18:34:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: msc_vlr_tests: tweak conn_exists()

[Max]

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11458

to look at the new patch set (#2).

Change subject: msc_vlr_tests: tweak conn_exists()
..

msc_vlr_tests: tweak conn_exists()

* constify function parameter
* internalize parameter check

Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
---
M tests/msc_vlr/msc_vlr_tests.c
M tests/msc_vlr/msc_vlr_tests.h
2 files changed, 10 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/58/11458/2
--
To view, visit https://gerrit.osmocom.org/11458
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
Gerrit-Change-Number: 11458
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: LCLS: explicitly check for *CX adjustment

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11558 )

Change subject: LCLS: explicitly check for *CX adjustment
..


Patch Set 4:

Moved to separate commit.


--
To view, visit https://gerrit.osmocom.org/11558
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b2c56991977b5e80c372a5b8338f348f14c076
Gerrit-Change-Number: 11558
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Harald Welte 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 06 Nov 2018 18:30:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC: log number of expected/seen *CX messages on failure

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11645


Change subject: BSC: log number of expected/seen *CX messages on failure
..

BSC: log number of expected/seen *CX messages on failure

Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/45/11645/1

diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 003813a..4b7a297 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -817,10 +817,10 @@
", mdcx_seen=", g_media.mgcp_conn[i].mdcx_seen, ", 
mdcx_seen_exp=", g_media.mgcp_conn[i].mdcx_seen_exp);

if(g_media.mgcp_conn[i].crcx_seen != 
g_media.mgcp_conn[i].crcx_seen_exp) {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-CRCX transactions");
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-CRCX transactions on g_media.mgcp_conn[" & int2str(i) 
& "]");
}
if(g_media.mgcp_conn[i].mdcx_seen != 
g_media.mgcp_conn[i].mdcx_seen_exp) {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-MDCX transactions");
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-MDCX transactions on g_media.mgcp_conn[" & int2str(i) 
& "]");
}
}
 }

--
To view, visit https://gerrit.osmocom.org/11645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
Gerrit-Change-Number: 11645
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-ttcn3-hacks[master]: BSC LCLS: restructure tests

[Max]

Hello daniel, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11555

to look at the new patch set (#4).

Change subject: BSC LCLS: restructure tests
..

BSC LCLS: restructure tests

Move duplicated code into separate functions to simplify adding test
cases which do not use MGW MDCX methods for closing the loop.

Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Related: OS#3659
---
M bsc/BSC_Tests_LCLS.ttcn
1 file changed, 52 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/55/11555/4
--
To view, visit https://gerrit.osmocom.org/11555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 

Change in osmo-ttcn3-hacks[master]: BSC LCLS: add bts-loop tests

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11559

to look at the new patch set (#5).

Change subject: BSC LCLS: add bts-loop tests
..

BSC LCLS: add bts-loop tests

Add basic establishment and teardown tests for 'bts-loop' mode of LCLS:
* add explicit vty init for desired LCLS kind
* add necessary IPA RSL MDCX functions
* explicitly pass LCLS kind as a parameter to shared
  functions (defaulting to 'mgw-loop')

Change-Id: I40e786b430591899c722d99d685db26efa868508
Related: OS#3659
---
M bsc/BSC_Tests.ttcn
M bsc/BSC_Tests_LCLS.ttcn
M bsc/expected-results.xml
3 files changed, 134 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/59/11559/5
--
To view, visit https://gerrit.osmocom.org/11559
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I40e786b430591899c722d99d685db26efa868508
Gerrit-Change-Number: 11559
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 

Change in osmo-ttcn3-hacks[master]: BSC LCLS: explicitly check for RSL_IE_CHAN_NR

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11556 )

Change subject: BSC LCLS: explicitly check for RSL_IE_CHAN_NR
..

BSC LCLS: explicitly check for RSL_IE_CHAN_NR

Check that channel number IE is present in the received message. This
fixes following warning:

The value returned by function `@RSL_Types.f_rsl_find_ie' is not used

Change-Id: Icc6824d7acef809d76c70b5ff060a8261a82e2be
Related: OS#3659
---
M bsc/BSC_Tests_LCLS.ttcn
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn
index 1c51995..0151329 100644
--- a/bsc/BSC_Tests_LCLS.ttcn
+++ b/bsc/BSC_Tests_LCLS.ttcn
@@ -605,8 +605,11 @@
[] CONN_A.receive(tr_RSL_DEACT_SACCH(?));
[] CONN_A.receive(tr_RSL_RF_CHAN_REL(?)) -> value rsl {
var RSL_IE_Body ieb;
-   f_rsl_find_ie(rsl, RSL_IE_CHAN_NR, ieb);
-   CONN_A.send(ts_RSL_RF_CHAN_REL_ACK(ieb.chan_nr));
+   if (f_rsl_find_ie(rsl, RSL_IE_CHAN_NR, ieb) == true) {
+   CONN_A.send(ts_RSL_RF_CHAN_REL_ACK(ieb.chan_nr));
+   } else {
+   log("Unable to find chan# in RSL_RF_CHAN_REL")
+   }
}
[] CONN_A.receive(tr_BSSMAP_ClearComplete) {
CONN_A.send(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);

--
To view, visit https://gerrit.osmocom.org/11556
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc6824d7acef809d76c70b5ff060a8261a82e2be
Gerrit-Change-Number: 11556
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmo-ttcn3-hacks[master]: cosmetic: fix compilation warnings

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11557 )

Change subject: cosmetic: fix compilation warnings
..

cosmetic: fix compilation warnings

Drop 'return' statements after 'mtc.stop' as they cause following
warning from TTCN-3 compiler:
warning: Control never reaches this statement

Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5
---
M library/MGCP_Emulation.ttcn
M library/Osmocom_CTRL_Functions.ttcn
2 files changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/MGCP_Emulation.ttcn b/library/MGCP_Emulation.ttcn
index c3d09b9..3dfbbc8 100644
--- a/library/MGCP_Emulation.ttcn
+++ b/library/MGCP_Emulation.ttcn
@@ -385,7 +385,6 @@
}
setverdict(fail, "Couldn't find Expect for CRCX", cmd);
mtc.stop;
-   return ret;
 }

 private function f_create_expect(ExpectCriteria crit, MGCP_ConnHdlr hdlr)
@@ -459,7 +458,6 @@

setverdict(fail, "Unknown payload type ", pt);
mtc.stop;
-   return "";
 }
 
 }
diff --git a/library/Osmocom_CTRL_Functions.ttcn 
b/library/Osmocom_CTRL_Functions.ttcn
index da3b80d..4356ba9 100644
--- a/library/Osmocom_CTRL_Functions.ttcn
+++ b/library/Osmocom_CTRL_Functions.ttcn
@@ -41,12 +41,10 @@
[] pt.receive(tr_CtrlMsgError) -> value rx {
setverdict(fail, "Error in CTRL GET ", variable, ": ", 
rx.err.reason);
mtc.stop;
-   return "FAIL";
}
[] T.timeout {
setverdict(fail, "Timeout waiting for CTRL GET REPLY ", 
variable);
mtc.stop;
-   return "TIMEOUT";
}
}
return rx.resp.val;
@@ -85,7 +83,6 @@
[] T.timeout {
setverdict(fail, "Timeout waiting for TRAP ", variable);
mtc.stop;
-   return "TIMEOUT";
}
}
return rx.trap.val;

--
To view, visit https://gerrit.osmocom.org/11557
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmo-bsc[master]: LCLS: move mode check into separate function

[Max]

Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11551

to look at the new patch set (#4).

Change subject: LCLS: move mode check into separate function
..

LCLS: move mode check into separate function

Before closing or breaking the loop in LCLS we do preliminary
checks. To facilitate adding new LCLS modes it's restructured as
follows:

* move check into dedicated static function
* explicitly check for MGW mode in endpoint check
* check for mode mismatch

Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c
Related: OS#3659
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 25 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/11551/4
--
To view, visit https://gerrit.osmocom.org/11551
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bsc[master]: LCLS: add bts-loop variant

[Max]

Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11552

to look at the new patch set (#4).

Change subject: LCLS: add bts-loop variant
..

LCLS: add bts-loop variant

Add LCLS variant where the loop is closed on BTS level instead of
MGW. The main difference is the handling of connection-related
messages (we use IPA RSL instead of MGCP), the configuration and
correlation logic remains the same.

Change-Id: I7e8379f31037f2c48da69a01919701919a3066a2
Fixes: OS#3659
---
M include/osmocom/bsc/bsc_msc_data.h
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/osmo_bsc_lcls.c
M src/osmo-bsc/osmo_bsc_vty.c
4 files changed, 29 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/11552/4
--
To view, visit https://gerrit.osmocom.org/11552
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e8379f31037f2c48da69a01919701919a3066a2
Gerrit-Change-Number: 11552
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 

Change in osmo-bsc[master]: LCLS: explicitly check for mode before closing the loop

[Max]

Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11565

to look at the new patch set (#2).

Change subject: LCLS: explicitly check for mode before closing the loop
..

LCLS: explicitly check for mode before closing the loop

* expand logging to print the name of LCLS mode in use
* explicitly check for MGW mode before closing the loop via MGCP MDCX

Change-Id: Ie91cc70de20ade2bfa3a1a108c731341f5e739bb
Related: OS#3659
---
M include/osmocom/bsc/bsc_msc_data.h
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/osmo_bsc_lcls.c
M src/osmo-bsc/osmo_bsc_vty.c
4 files changed, 26 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/11565/2
--
To view, visit https://gerrit.osmocom.org/11565
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie91cc70de20ade2bfa3a1a108c731341f5e739bb
Gerrit-Change-Number: 11565
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: NS: print ip:port on error

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11644


Change subject: NS: print ip:port on error
..

NS: print ip:port on error

Change-Id: I2f558021b7754db9593934888d12f9c879dc2988
---
M library/NS_Emulation.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/44/11644/1

diff --git a/library/NS_Emulation.ttcn b/library/NS_Emulation.ttcn
index 7cccb25..ca4d1d6 100644
--- a/library/NS_Emulation.ttcn
+++ b/library/NS_Emulation.ttcn
@@ -83,7 +83,9 @@
/* Connect the UDP socket */
res := f_IPL4_connect(NSCP, config.remote_ip, 
config.remote_udp_port, config.local_ip, config.local_udp_port, 0, { udp := 
{}});
if (not ispresent(res.connId)) {
-   setverdict(fail, "Could not connect NS UDP socket, 
check your configuration");
+   setverdict(fail, "Could not connect NS UDP socket from 
" &
+  config.local_ip & ":"  & 
int2str(config.local_udp_port) &
+  " to " & config.remote_ip & ":" & 
int2str(config.remote_udp_port));
mtc.stop;
}
g_conn_id := res.connId;

--
To view, visit https://gerrit.osmocom.org/11644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f558021b7754db9593934888d12f9c879dc2988
Gerrit-Change-Number: 11644
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-ttcn3-hacks[master]: PCU: cleanup test config

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11643


Change subject: PCU: cleanup test config
..

PCU: cleanup test config

* remove unused parameters
* add expected results
* use control for default test execution
* only tests which could (in theory) pass are left in control

Previously generic control had some tests which never called
"setverdict(pass)" which means they would always fail. Such tests might
be useful during development but should not be part of test set executed
by default.

Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Related: OS#2890
---
M pcu/PCU_Tests.cfg
M pcu/PCU_Tests.ttcn
A pcu/expected-results.xml
3 files changed, 12 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/43/11643/1

diff --git a/pcu/PCU_Tests.cfg b/pcu/PCU_Tests.cfg
index 7e0b9f2..5975290 100644
--- a/pcu/PCU_Tests.cfg
+++ b/pcu/PCU_Tests.cfg
@@ -7,10 +7,6 @@
 ConsoleMask := ERROR | WARNING | TESTCASE | TIMEROP_START | DEBUG_ENCDEC

 [MODULE_PARAMETERS]
-#mp_local_ip := "192.168.100.239"
-#mp_local_udp_port := 23000
-#mp_remote_ip := "192.168.100.196"
-#mp_remote_udp_port := 21000
 PCU_Tests.mp_nsconfig := {
local_ip := "127.0.0.1",
local_udp_port := 23000,
@@ -36,26 +32,18 @@
 }

 [TESTPORT_PARAMETERS]
-#*.BSCVTY.CTRL_MODE := "client"
-#*.BSCVTY.CTRL_HOSTNAME := "127.0.0.1"
-#*.BSCVTY.CTRL_PORTNUM := "4242"
-#*.BSCVTY.CTRL_LOGIN_SKIPPED := "yes"
-#*.BSCVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes"
-#*.BSCVTY.CTRL_READMODE := "buffered"
-#*.BSCVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes"
-#*.BSCVTY.PROMPT1 := "OpenBSC> "
-#*.BSCVTY.PROMPT2 := "OpenBSC# "
-#*.BSCVTY.REGEX_PROMPT1 := "^OpenBSC.*$"
-
 *.*.udpReuseAddress := "yes";

 [MAIN_CONTROLLER]

 [EXECUTE]
+PCU_Tests.control
+# for internal use only: will always fail when called as part of normal routine
 #PCU_Tests.TC_selftest_llc
 #PCU_Tests.TC_selftest_rlcmac
 #PCU_Tests.TC_selftest_bssgp
 #PCU_Tests.TC_nsem
 #PCU_Tests.TC_paging
-PCU_Tests.TC_rach
+#PCU_Tests.TC_rach
 #PCU_Tests.TC_selftest_rr
+#PCU_Tests.TC_dl_tbf
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index a63ca1d..adbc73e 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -630,12 +630,8 @@


control {
-   execute(TC_selftest_bssgp());
execute(TC_selftest_ns());
-   execute(TC_selftest_llc());
-   execute(TC_selftest_rr());
-   execute(TC_selftest_rlcmac());
-   execute(TC_nsem());
-   execute(TC_paging());
+   execute(TC_ul_tbf_single_llc_sizes());
+   execute(TC_ul_tbf());
}
 };
diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml
new file mode 100644
index 000..aec661d
--- /dev/null
+++ b/pcu/expected-results.xml
@@ -0,0 +1,6 @@
+
+
+  
+  
+  
+

--
To view, visit https://gerrit.osmocom.org/11643
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Gerrit-Change-Number: 11643
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Build failed in Jenkins: master-osmo-bts » lc15, origin/nrw/litecell15,default,osmocom-master-debian9 #1377

[jenkins]

See 


--
[...truncated 40.52 KB...]
config.status: creating Doxyfile.ctrl
config.status: creating Makefile
config.status: creating config.h
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
configure: WARNING: unrecognized options: --with-systemdsystemunitdir
+ make -j 8 install
echo 0.12.0.103-fa3b4 > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory 
'
Making install in include
make[2]: Entering directory 
'
  GEN  osmocom/gsm/gsm0503.h
Generating header file...
Generate 'xcch' declaration
Generate 'rach' declaration
Generate 'rach_ext' declaration
Generate 'sch' declaration
Generate 'cs2' declaration
Generate 'cs3' declaration
Generate 'cs2_np' declaration
Generate 'cs3_np' declaration
Generate 'tch_afs_12_2' declaration
Generate 'tch_afs_10_2' declaration
Generate 'tch_afs_7_95' declaration
Generate 'tch_afs_7_4' declaration
Generate 'tch_afs_6_7' declaration
Generate 'tch_afs_5_9' declaration
Generate 'tch_afs_5_15' declaration
Generate 'tch_afs_4_75' declaration
Generate 'tch_fr' declaration
Generate 'tch_hr' declaration
Generate 'tch_ahs_7_95' declaration
Generate 'tch_ahs_7_4' declaration
Generate 'tch_ahs_6_7' declaration
Generate 'tch_ahs_5_9' declaration
Generate 'tch_ahs_5_15' declaration
Generate 'tch_ahs_4_75' declaration
Generate 'mcs1_dl_hdr' declaration
Generate 'mcs1_ul_hdr' declaration
Generate 'mcs1' declaration
Generate 'mcs2' declaration
Generate 'mcs3' declaration
Generate 'mcs4' declaration
Generate 'mcs5_dl_hdr' declaration
Generate 'mcs5_ul_hdr' declaration
Generate 'mcs5' declaration
Generate 'mcs6' declaration
Generate 'mcs7_dl_hdr' declaration
Generate 'mcs7_ul_hdr' declaration
Generate 'mcs7' declaration
Generate 'mcs8' declaration
Generate 'mcs9' declaration
Generation complete.
make  install-am
make[3]: Entering directory 
'
  GEN  osmocom/core/bit64gen.h
  GEN  osmocom/core/bit32gen.h
  GEN  osmocom/core/bit16gen.h
  GEN  osmocom/core/crc16gen.h
  GEN  osmocom/core/crc8gen.h
  GEN  osmocom/core/crc64gen.h
  GEN  osmocom/core/crc32gen.h
  GEN  osmocom/core/bit32gen.h
  GEN  osmocom/core/bit64gen.h
  GEN  osmocom/core/bit16gen.h
  GEN  osmocom/core/crc16gen.h
  GEN  osmocom/core/crc32gen.h
  GEN  osmocom/core/crc64gen.h
  GEN  osmocom/core/crc8gen.h
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644  osmocom/core/application.h 
osmocom/core/backtrace.h osmocom/core/bit16gen.h osmocom/core/bit32gen.h 
osmocom/core/bit64gen.h osmocom/core/bits.h osmocom/core/bitvec.h 
osmocom/core/bitcomp.h osmocom/core/byteswap.h osmocom/core/conv.h 
osmocom/core/counter.h osmocom/core/crc16.h osmocom/core/crc16gen.h 
osmocom/core/crc32gen.h osmocom/core/crc64gen.h osmocom/core/crc8gen.h 
osmocom/core/crcgen.h osmocom/core/endian.h osmocom/core/defs.h 
osmocom/core/fsm.h osmocom/core/gsmtap.h osmocom/core/gsmtap_util.h 
osmocom/core/isdnhdlc.h osmocom/core/linuxlist.h osmocom/core/linuxrbtree.h 
osmocom/core/logging.h osmocom/core/loggingrb.h osmocom/core/stats.h 
osmocom/core/macaddr.h osmocom/core/msgb.h osmocom/core/panic.h 
osmocom/core/prbs.h osmocom/core/prim.h osmocom/core/process.h 
osmocom/core/rate_ctr.h osmocom/core/stat_item.h osmocom/core/select.h 
osmocom/core/sercomm.h osmocom/core/signal.h osmocom/core/socket.h 

Change in osmo-ttcn3-hacks[master]: BSC LCLS: restructure tests

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11555 )

Change subject: BSC LCLS: restructure tests
..


Patch Set 2: Code-Review-1


--
To view, visit https://gerrit.osmocom.org/11555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 06 Nov 2018 17:25:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Fix deprecation warning in gsm0808_test

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11602 )

Change subject: Fix deprecation warning in gsm0808_test
..

Fix deprecation warning in gsm0808_test

Use gsm0808_create_layer3_2() directly instead of deprecated wrapper.

Change-Id: I44772666c929dfd94d25953379cf51b371ce202c
---
M tests/gsm0808/gsm0808_test.c
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index 7111db9..671b839 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -102,7 +102,16 @@
0xef, 0xcd, GSM0808_SCT_FR2 | 0xa0, 0x9f,
GSM0808_SCT_CSD | 0x90, 0xc0
};
-
+   struct osmo_cell_global_id cgi = {
+   .lai = {
+   .plmn = {
+   .mcc = 0x2244,
+   .mnc = 0x1122,
+   },
+   .lac = 0x3366,
+   },
+   .cell_identity = 0x4488,
+   };
struct msgb *msg, *in_msg;
struct gsm0808_speech_codec_list sc_list;
printf("Testing creating Layer3 (AoIP)\n");
@@ -113,9 +122,8 @@
in_msg->l3h = in_msg->data;
msgb_v_put(in_msg, 0x23);

-   msg =
-   gsm0808_create_layer3_aoip(in_msg, 0x1122, 0x2244, 0x3366, 0x4488,
-  _list);
+   msg = gsm0808_create_layer3_2(in_msg, , _list);
+
VERIFY(msg, res, ARRAY_SIZE(res));

msgb_free(msg);

--
To view, visit https://gerrit.osmocom.org/11602
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44772666c929dfd94d25953379cf51b371ce202c
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-sgsn[master]: Cleanup non-existent files from debian/copyright

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11566 )

Change subject: Cleanup non-existent files from debian/copyright
..

Cleanup non-existent files from debian/copyright

Change-Id: I36a05b7c729cc1d050c8d07540ed1d867ca2d613
Related: OS#2534
---
M debian/copyright
1 file changed, 0 insertions(+), 18 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/debian/copyright b/debian/copyright
index 65f3ba7..cc631f4 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -50,8 +50,6 @@
src/gprs/.gitignore
src/gprs/Makefile.am
src/gprs/osmo_sgsn.cfg
-   src/libcommon/Makefile.am
-   src/libcommon/gsup_test_client.c
tests/Makefile.am
tests/atlocal.in
tests/gbproxy/Makefile.am
@@ -61,9 +59,6 @@
tests/gprs/gprs_test.ok
tests/gtphub/Makefile.am
tests/gtphub/gtphub_test.ok
-   tests/oap/Makefile.am
-   tests/oap/oap_client_test.err
-   tests/oap/oap_client_test.ok
tests/sgsn/Makefile.am
tests/sgsn/sgsn_test.ok
tests/slhc/Makefile.am
@@ -85,9 +80,7 @@
include/osmocom/sgsn/gprs_sndcp_pcomp.h
include/osmocom/sgsn/gprs_sndcp_xid.h
include/osmocom/sgsn/gprs_utils.h
-   include/osmocom/sgsn/gsup_client.h
include/osmocom/sgsn/gtphub.h
-   include/osmocom/sgsn/oap_client.h
include/osmocom/sgsn/signal.h
src/gprs/crc24.c
src/gprs/gb_proxy.c
@@ -111,11 +104,9 @@
src/gprs/gprs_sndcp_xid.c
src/gprs/gprs_subscriber.c
src/gprs/gprs_utils.c
-   src/gprs/gsup_client.c
src/gprs/gtphub.c
src/gprs/gtphub_main.c
src/gprs/gtphub_vty.c
-   src/gprs/oap_client.c
src/gprs/sgsn_ares.c
src/gprs/sgsn_auth.c
src/gprs/sgsn_cdr.c
@@ -123,16 +114,7 @@
src/gprs/sgsn_libgtp.c
src/gprs/sgsn_main.c
src/gprs/sgsn_vty.c
-   src/libcommon/debug.c
-   src/libcommon/gsm_data.c
-   src/libcommon/gsm_data_shared.c
-   src/libcommon/gsm_subscriber_base.c
-   src/libcommon/gsup_client.c
-   src/libcommon/oap_client.c
-   src/libcommon/socket.c
-   src/libcommon/talloc_ctx.c
tests/gtphub/gtphub_test.c
-   tests/oap/oap_client_test.c
tests/sgsn/sgsn_test.c
tests/slhc/slhc_test.c
tests/sndcp_xid/sndcp_xid_test.c

--
To view, visit https://gerrit.osmocom.org/11566
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I36a05b7c729cc1d050c8d07540ed1d867ca2d613
Gerrit-Change-Number: 11566
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: BSC LCLS: restructure tests

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11555 )

Change subject: BSC LCLS: restructure tests
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11555/2/bsc/BSC_Tests_LCLS.ttcn
File bsc/BSC_Tests_LCLS.ttcn:

https://gerrit.osmocom.org/#/c/11555/2/bsc/BSC_Tests_LCLS.ttcn@302
PS2, Line 302:  f_tc_lcls_recv_ls_exp_mgcp()
Missing semicolon ;
TTCN3 seems to accept it, but I think we want to keep this syntax as C-like as 
possible.



--
To view, visit https://gerrit.osmocom.org/11555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 06 Nov 2018 17:24:55 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC: remove explicit address

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11554 )

Change subject: BSC: remove explicit address
..

BSC: remove explicit address

The osmo-bsc.cfg should work on localhost. Having arbitrary IP address
in it seems confusing and might lead to hard-to-debug errors.

Change-Id: Ideb8a78348af435f9992c42bce0bb197d1e73e04
---
M bsc/osmo-bsc.cfg
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg
index c7f34fc..bca5b20 100644
--- a/bsc/osmo-bsc.cfg
+++ b/bsc/osmo-bsc.cfg
@@ -344,7 +344,6 @@
  no bsc-welcome-text
  no bsc-msc-lost-text
  no bsc-grace-text
- dest 192.168.100.11  0
  type normal
  allow-emergency allow
  amr-config 12_2k forbidden

--
To view, visit https://gerrit.osmocom.org/11554
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ideb8a78348af435f9992c42bce0bb197d1e73e04
Gerrit-Change-Number: 11554
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmo-bsc[master]: vty: don't show GPRS details if not configured

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11626 )

Change subject: vty: don't show GPRS details if not configured
..

vty: don't show GPRS details if not configured

In 'show bts' command only display details of GPRS MO if GPRS is
configured for this BTS.

Change-Id: I082a9fecfa337dff5342b79cca8144b0ceaab15d
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 13 insertions(+), 8 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 410cdac..84752dd 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -447,14 +447,19 @@
net_dump_nmstate(vty, >mo.nm_state);
vty_out(vty, "  Site Mgr NM State: ");
net_dump_nmstate(vty, >site_mgr.mo.nm_state);
-   vty_out(vty, "  GPRS NSE: ");
-   net_dump_nmstate(vty, >gprs.nse.mo.nm_state);
-   vty_out(vty, "  GPRS CELL: ");
-   net_dump_nmstate(vty, >gprs.cell.mo.nm_state);
-   vty_out(vty, "  GPRS NSVC0: ");
-   net_dump_nmstate(vty, >gprs.nsvc[0].mo.nm_state);
-   vty_out(vty, "  GPRS NSVC1: ");
-   net_dump_nmstate(vty, >gprs.nsvc[1].mo.nm_state);
+
+   if (bts->gprs.mode != BTS_GPRS_NONE) {
+   vty_out(vty, "  GPRS NSE: ");
+   net_dump_nmstate(vty, >gprs.nse.mo.nm_state);
+   vty_out(vty, "  GPRS CELL: ");
+   net_dump_nmstate(vty, >gprs.cell.mo.nm_state);
+   vty_out(vty, "  GPRS NSVC0: ");
+   net_dump_nmstate(vty, >gprs.nsvc[0].mo.nm_state);
+   vty_out(vty, "  GPRS NSVC1: ");
+   net_dump_nmstate(vty, >gprs.nsvc[1].mo.nm_state);
+   } else
+   vty_out(vty, "  GPRS: not configured%s", VTY_NEWLINE);
+
vty_out(vty, "  Paging: %u pending requests, %u free slots%s",
paging_pending_requests_nr(bts),
bts->paging.available_slots, VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/11626
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I082a9fecfa337dff5342b79cca8144b0ceaab15d
Gerrit-Change-Number: 11626
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: cosmetic: fix typos

[daniel]

daniel has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11553 )

Change subject: cosmetic: fix typos
..

cosmetic: fix typos

Change-Id: I6e75af46e134d33f752214988054105aba91366c
---
M bsc/BSC_Tests.ttcn
M bsc/BSC_Tests_LCLS.ttcn
M bsc/MSC_ConnectionHandler.ttcn
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index ae855bd..e3ac707 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -340,7 +340,7 @@
activate(as_Tguard());
 }

-/* expect to receive a RSL message matching a specified templaten on a given 
BTS / stream */
+/* expect to receive a RSL message matching a specified template on a given 
BTS / stream */
 function f_exp_ipa_rx(integer bts_nr, template RSL_Message t_rx, float t_secs 
:= 2.0, IpaStreamId sid := IPAC_PROTO_RSL_TRX0)
 runs on test_CT return RSL_Message {
var ASP_RSL_Unitdata rx_rsl_ud;
diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn
index dfbd946..1c51995 100644
--- a/bsc/BSC_Tests_LCLS.ttcn
+++ b/bsc/BSC_Tests_LCLS.ttcn
@@ -522,7 +522,7 @@

/* first call is not possible to be LS (no second leg yet) */
pars_a.lcls.exp_sts := LCLS_STS_not_possible_ls;
-   /* second call should then reuslt in LS */
+   /* second call should then result in LS */
pars_b.lcls.exp_sts := LCLS_STS_locally_switched;

/* Expect LS to be established successfully */
diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 546fa2d..003813a 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -432,7 +432,7 @@

 /* Note: Do not use valueof() to get a value of this template, use
  * f_gen_test_hdlr_pars() instead in order to get a configuration that is
- * matched to the current test sitation (aoio vs. sccplite) */
+ * matched to the current test situation (aoio vs. sccplite) */
 template (value) TestHdlrParams t_def_TestHdlrPars := {
ra := '23'O,
fn := 23,

--
To view, visit https://gerrit.osmocom.org/11553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e75af46e134d33f752214988054105aba91366c
Gerrit-Change-Number: 11553
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 

Change in osmo-ttcn3-hacks[master]: bts: Introduce mp_ipa_up_timeout parameter

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11568 )

Change subject: bts: Introduce mp_ipa_up_timeout parameter
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb046358d8266ac94bd7b9e916e85f84de3ad319
Gerrit-Change-Number: 11568
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 06 Nov 2018 17:07:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sip-connector[master]: configure.ac: add --enable-sanitize

[daniel]

daniel has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11592 )

Change subject: configure.ac: add --enable-sanitize
..

configure.ac: add --enable-sanitize

Add --enable-sanitize to ./configure, as a copy-paste from libosmocore.

When building libosmocore with --enable-sanitize, osmo-sip-connector cannot be
linked if it doesn't include asan as well.

This is particularly annoying to me when using sanitize.opts in osmo-dev. I'd
have to turn off *all* asan everywhere just to include the osmo-sip-connector
dep that was recently added.

Change-Id: I18761802db2f29d9f0c7f269197d5b5e191142c5
---
M configure.ac
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/configure.ac b/configure.ac
index 98fdc94..cdb42a5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -27,6 +27,18 @@
 PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.11.0)
 PKG_CHECK_MODULES(SOFIASIP, sofia-sip-ua-glib >= 1.12.0)

+AC_ARG_ENABLE(sanitize,
+   [AS_HELP_STRING(
+   [--enable-sanitize],
+   [Compile with address sanitizer enabled],
+   )],
+   [sanitize=$enableval], [sanitize="no"])
+if test x"$sanitize" = x"yes"
+then
+   CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined"
+   CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
+fi
+
 AC_ARG_ENABLE(werror,
[AS_HELP_STRING(
[--enable-werror],

--
To view, visit https://gerrit.osmocom.org/11592
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18761802db2f29d9f0c7f269197d5b5e191142c5
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 

Change in osmocom-bb[master]: cosmetic: fix trailing whitespace

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11608 )

Change subject: cosmetic: fix trailing whitespace
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11608
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1a6d98079ad846d114584a17ba9d80d95e0595
Gerrit-Change-Number: 11608
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 06 Nov 2018 17:00:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: ipaccess-config: Use enum value for OML IP

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11641


Change subject: ipaccess-config: Use enum value for OML IP
..

ipaccess-config: Use enum value for OML IP

Change-Id: I3a708c3ba2271d9968daa264736411c9326fc404
---
M src/ipaccess/ipaccess-config.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/41/11641/1

diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c
index 5491700..0fb5ad9 100644
--- a/src/ipaccess/ipaccess-config.c
+++ b/src/ipaccess/ipaccess-config.c
@@ -409,7 +409,7 @@
msgb_put_u8(nmsg, NM_ATT_IPACC_PRIM_OML_CFG_LIST);
msgb_put_u16(nmsg, len);

-   msgb_put_u8(nmsg, 0x88);
+   msgb_put_u8(nmsg, NM_ATT_IPACC_PRIM_OML_CFG);

/* IP address */
msgb_put_u32(nmsg, ip);

--
To view, visit https://gerrit.osmocom.org/11641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a708c3ba2271d9968daa264736411c9326fc404
Gerrit-Change-Number: 11641
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmocom-bb[master]: layer23: Avoid mempcy with NULL src

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11610 )

Change subject: layer23: Avoid mempcy with NULL src
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11610/1/src/host/layer23/src/common/main.c
File src/host/layer23/src/common/main.c:

https://gerrit.osmocom.org/#/c/11610/1/src/host/layer23/src/common/main.c@146
PS1, Line 146:  if (app && app->cfg_getopt_opt)
It may make more sense to check app_opp here since app->cfg_getopt_opt() could 
in theory omit to set app_opp or set it to NULL



--
To view, visit https://gerrit.osmocom.org/11610
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I009a5b53f1e5be72ce347d64d3a7cb1d95d37ea3
Gerrit-Change-Number: 11610
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 06 Nov 2018 16:58:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: introduce new InvokeID IE

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11640


Change subject: library/GSUP_Types.ttcn: introduce new InvokeID IE
..

library/GSUP_Types.ttcn: introduce new InvokeID IE

Each invoke component in TCAP is identified by an unique InvokeID,
assigned by the application that originates the invoke. The
InvokeID is returned in the response, and allows the originator
to correlate the reply with the invoke operation to which
it belongs.

Since GSUP has no TCAP layer, there are optional SESSION_ID and
SESSION_STATE IEs aimed to 'emulate' the dialog. This change
introduces the new optional INVOKE_ID IE.

InvokeID is required in order to support multy-part SMS over GSUP.

Change-Id: Ib7ed702cb05328dc4d1f459efc93df4fa947d7ae
Related: OS#3587
---
M library/GSUP_Types.ttcn
1 file changed, 42 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/40/11640/1

diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index d7d9a5b..fa8d1ce 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -43,6 +43,7 @@

OSMO_GSUP_SESSION_ID_IE ('30'O),
OSMO_GSUP_SESSION_STATE_IE  ('31'O),
+   OSMO_GSUP_INVOKE_ID_IE  ('32'O),
OSMO_GSUP_SS_INFO_IE('35'O),

/* SM related IEs (see 3GPP TS 29.002, section 7.6.8) */
@@ -140,6 +141,7 @@
 charg_char, tag = OSMO_GSUP_CHARG_CHAR_IE;
 session_state, tag = 
OSMO_GSUP_SESSION_STATE_IE;
 session_id, tag = OSMO_GSUP_SESSION_ID_IE;
+invoke_id, tag = OSMO_GSUP_INVOKE_ID_IE;
 ss_info, tag = OSMO_GSUP_SS_INFO_IE;
 sm_rp_da, tag = OSMO_GSUP_SM_RP_DA_IE;
 sm_rp_oa, tag = OSMO_GSUP_SM_RP_OA_IE;
@@ -176,6 +178,7 @@
/* Session information */
GSUP_SessionState   session_state,
OCT4session_id,
+   int8_t  invoke_id,
/* Supplementary Services */
octetstring ss_info,
/* Short Message Service */
@@ -613,6 +616,21 @@
}
 }

+template (value) GSUP_IE ts_GSUP_IE_InvokeID(int8_t invoke_id) := {
+   tag := OSMO_GSUP_INVOKE_ID_IE,
+   len := 0, /* overwritten */
+   val := {
+   invoke_id := invoke_id
+   }
+}
+template GSUP_IE tr_GSUP_IE_InvokeID(template int8_t invoke_id) := {
+   tag := OSMO_GSUP_INVOKE_ID_IE,
+   len := ?,
+   val := {
+   invoke_id := invoke_id
+   }
+}
+
 /* Possible identity types for SM-RP-{OA|DA} IEs */
 type enumerated GSUP_SM_RP_ODA_IdType {
OSMO_GSUP_SM_RP_ODA_ID_NONE ('00'O),
@@ -922,6 +940,7 @@
hexstring imsi, /* IMSI (dummy, because mandatory) */
OCT4 sid, /* TCAP transactionID */
GSUP_SessionState state, /* TCAP transaction state */
+   int8_t invoke_id, /* InvokeID */
GSUP_SM_RP_DA sm_rp_da, /* Destination Address, see 7.6.8.1 */
GSUP_SM_RP_OA sm_rp_oa, /* Originating Address, see 7.6.8.2 */
octetstring sm_rp_ui /* SM TPDU, see 7.6.8.4 */
@@ -931,6 +950,7 @@
valueof(ts_GSUP_IE_IMSI(imsi)),
valueof(ts_GSUP_IE_SessionId(sid)),
valueof(ts_GSUP_IE_SessionState(state)),
+   valueof(ts_GSUP_IE_InvokeID(invoke_id)),
valueof(ts_GSUP_IE_SM_RP_DA(sm_rp_da)),
valueof(ts_GSUP_IE_SM_RP_OA(sm_rp_oa)),
valueof(ts_GSUP_IE_SM_RP_UI(sm_rp_ui))
@@ -940,6 +960,7 @@
template hexstring imsi := ?,
template OCT4 sid := ?, /* TCAP TransactionID */
template GSUP_SessionState state := ?, /* TCAP transaction state */
+   template int8_t invoke_id := ?, /* InvokeID */
template GSUP_SM_RP_DA sm_rp_da, /* Destination Address, see 7.6.8.1 */
template GSUP_SM_RP_OA sm_rp_oa, /* Originating Address, see 7.6.8.2 */
template octetstring sm_rp_ui /* SM TPDU, see 7.6.8.4 */
@@ -949,6 +970,7 @@
tr_GSUP_IE_IMSI(imsi),
tr_GSUP_IE_SessionId(sid),
tr_GSUP_IE_SessionState(state),
+   tr_GSUP_IE_InvokeID(invoke_id),
tr_GSUP_IE_SM_RP_DA(sm_rp_da),
tr_GSUP_IE_SM_RP_OA(sm_rp_oa),
tr_GSUP_IE_SM_RP_UI(sm_rp_ui)
@@ -959,6 +981,7 @@
hexstring imsi,
OCT4 sid, /* TCAP TransactionID */
GSUP_SessionState state, /* TCAP transaction state */
+   int8_t invoke_id, /* InvokeID */
octetstring sm_rp_ui /* SM TPDU, see 7.6.8.4 */
 ) := ts_GSUP(
OSMO_GSUP_MSGT_MO_FORWARD_SM_RESULT,
@@ -966,6 +989,7 @@
valueof(ts_GSUP_IE_IMSI(imsi)),
valueof(ts_GSUP_IE_SessionId(sid)),

Change in osmo-gsm-manuals[master]: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11611 )

Change subject: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11611/1/common/chapters/abis.adoc
File common/chapters/abis.adoc:

https://gerrit.osmocom.org/#/c/11611/1/common/chapters/abis.adoc@85
PS1, Line 85: Primarly OML IP. You can find this tool in the OpenBSC repository 
under:
> OsmoBSC
Thanks, I actually fixed this in one of the later commits without realizing I 
introduced the issue. :-)



--
To view, visit https://gerrit.osmocom.org/11611
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b92a611abd6e92ad69f77f8ec81a6501224afe5
Gerrit-Change-Number: 11611
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 06 Nov 2018 16:36:02 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-gsm-manuals[master]: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo

[daniel]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11611

to look at the new patch set (#2).

Change subject: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo
..

Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo

Change-Id: I4b92a611abd6e92ad69f77f8ec81a6501224afe5
---
M common/chapters/abis.adoc
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/11/11611/2
--
To view, visit https://gerrit.osmocom.org/11611
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b92a611abd6e92ad69f77f8ec81a6501224afe5
Gerrit-Change-Number: 11611
Gerrit-PatchSet: 2
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-manuals[master]: common/chapters/bts: Remove duplicate spaces in text

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/11639


Change subject: common/chapters/bts: Remove duplicate spaces in text
..

common/chapters/bts: Remove duplicate spaces in text

Change-Id: I38f3e94342461f494ef547bcdccd2594c30e679d
---
M common/chapters/bts.adoc
1 file changed, 21 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/39/11639/1

diff --git a/common/chapters/bts.adoc b/common/chapters/bts.adoc
index eb28497..30a33cc 100644
--- a/common/chapters/bts.adoc
+++ b/common/chapters/bts.adoc
@@ -1,20 +1,20 @@
 [[bts]]
 == Reviewing and Provisioning BTS configuration

-The main functionality of the BSC component is to manage BTSs.  As such,
+The main functionality of the BSC component is to manage BTSs. As such,
 provisioning BTSs within the BSC is one of the most common tasks during
-BSC operation.   Just like about anything else in OsmoBSC, they are
+BSC operation. Just like about anything else in OsmoBSC, they are
 configured using the VTY.

 BTSs are internally numbered with integer numbers starting from "0" for
-the first BTS.  BTS numbers have to be contiguous, so you cannot
+the first BTS. BTS numbers have to be contiguous, so you cannot
 configure 0,1,2 and then 5.


 === Reviewing current BTS status and configuration

 In order to view the status and properties of a BTS, you can issue the
-`show bts` command.  If used without any BTS number, it will display
+`show bts` command. If used without any BTS number, it will display
 information about all provisioned BTS numbers.

 
@@ -55,9 +55,9 @@
 specified BTS (`show trx 0 0`).

 Furthermore, information on the individual timeslots can be shown by
-means of `show timeslot`.  The output can be restricted to the
+means of `show timeslot`. The output can be restricted to the
 timeslots of a single BTS (`show timeslot 0`) or that of a single
-TRX (`show timeslot 0 0`).  Finally, you can restrict the output to
+TRX (`show timeslot 0 0`). Finally, you can restrict the output to
 a single timeslot by specifying the BTS, TRX and TS numbers (`show
 timeslot 0 0 4`).

@@ -74,7 +74,7 @@
 === Provisioning a new BTS

 In order to provision BTSs, you have to enter the BTS config node of the
-VTY.  In order to configure BTS 0, you can issue the following sequence
+VTY. In order to configure BTS 0, you can issue the following sequence
 of commands:

 
@@ -87,12 +87,12 @@

 At this point, you have a plethora of commands, in fact an entire
 hierarchy of commands to configure all aspects of the BTS, as well as
-each of its TRX and each timeslot within each TRX.  For a full
+each of its TRX and each timeslot within each TRX. For a full
 reference, please consult the telnet VTY integrated help or the respective
 chapter in the VTY reference.

 BTS configuration depends quite a bit on the specific BTS vendor and
-model.  The section below provides just one possible example for the
+model. The section below provides just one possible example for the
 case of a sysmoBTS.

 Note that from the `configure terminal` command onwards, the telnet VTY
@@ -140,7 +140,7 @@

 A GSM BTS periodically transmits a series of 'SYSTEM INFORMATION'
 messages to mobile stations, both via the BCCH in idle mode, was well as
-via the SACCH in dedicated mode.  There are many different types of such
+via the SACCH in dedicated mode. There are many different types of such
 messages. For their detailed contents and encoding, please see _3GPP TS
 24.008_ <<3gpp-ts-24-008>>.

@@ -161,7 +161,7 @@
 === Neighbor List configuration

 Every BTS sends a list of ARFCNs of neighbor cells
-. within its 'SYSTEM INFORMATION 2' (and 2bis/2ter)  messages on the BCCH
+. within its 'SYSTEM INFORMATION 2' (and 2bis/2ter) messages on the BCCH
 . within its 'SYSTEM INFORMATION 5' messages on SACCH in dedicated mode

 For every BTS config node in the VTY, you can specify the behavior of
@@ -184,17 +184,17 @@
 === Configuring GPRS PCU parameters of a BTS

 In the case of BTS models using Abis/IP (IPA), the GPRS PCU is located
-inside the BTS.  The BTS then establishes a Gb connection to the SGSN.
+inside the BTS. The BTS then establishes a Gb connection to the SGSN.

 All the BTS-internal PCU configuration is performed via A-bis OML by
 means of configuring the 'CELL', 'NSVC' (NS Virtual Connection and 'NSE'
 (NS Entity).

 There is one 'CELL' node and one 'NSE' node, but there are two 'NSVC'
-nodes.  At the time of this writing, only the NSVC 0 is supported by
+nodes. At the time of this writing, only the NSVC 0 is supported by
 OsmoBTS, while both NSVC are supported by the ip.access nanoBTS.

-The respective VTY configuration parameters are described below.  They
+The respective VTY configuration parameters are described below. They
 all exist beneath each BTS VTY config node.

 But let's first start with a small example
@@ -224,29 +224,29 @@

  `gprs 

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11637 )

Change subject: hlr: Fix DTE by requesting the correct type
..


Patch Set 1: Code-Review+1

Oh, damn, thanks a lot for this fix!


--
To view, visit https://gerrit.osmocom.org/11637
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5075b17a810762651e0c7d638cc4c35c58436cd9
Gerrit-Change-Number: 11637
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 06 Nov 2018 16:28:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: Change OpenBSC mentions to OsmoBSC where applicable

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11616 )

Change subject: Change OpenBSC mentions to OsmoBSC where applicable
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11616/1/common/chapters/bts.adoc
File common/chapters/bts.adoc:

https://gerrit.osmocom.org/#/c/11616/1/common/chapters/bts.adoc@6
PS1, Line 6: BSC operation.   Just like about anything else in OsmoBSC, they are
> take chance to remove extra spacing after dot?
I did it in an extra patch now (for this file only).
There are quite a few places where more spaces are used (without any effect on 
the output) so I removed them all.



--
To view, visit https://gerrit.osmocom.org/11616
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc6874302b6089a54d44b09f08660a25e46d4dc
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 16:26:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: gsm_29_118: add missing include to header file

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11638 )

Change subject: gsm_29_118: add missing include to header file
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11638
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f9bb62d29cd068820ad5aa677717bd448de3f4a
Gerrit-Change-Number: 11638
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 16:23:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11562 )

Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on 
RSL
..

bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

We cannot notify RSL Emulation layer about expecting a specific FN
(during ts_RSLDC_ChanRqd) because we only know the FN after sending the
RACH request, and since notification to RSL Emulation happens async, it
can happen (verified) that ChanRqd message from BTS arrives and is
handled before we register the RACH req into the ConnectionTable.

Change-Id: I438fd3ee82d88498d928dbcc89ce9bd80d37ab64
---
M bts/BTS_Tests.ttcn
M library/RSL_Emulation.ttcn
2 files changed, 70 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 5b073ef..64c2510 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1344,6 +1344,28 @@
}
 }

+/* Send RACH request through l1CTL and wait for ChanReq on RSL BST->BSC */
+private function f_rach_req_wait_chan_rqd(integer ra) runs on ConnHdlr return 
GsmFrameNumber {
+   var GsmFrameNumber fn;
+   timer T := 8.0;
+
+   /* advertise to RSL Emulation that we expect to receive confirmation 
from RACH */
+   RSL.send(ts_RSLDC_ChanRqd_anyFN(int2oct(ra,1)));
+
+   f_L1CTL_PARAM(L1CTL, g_pars.l1_pars.ms_actual_ta, 
g_pars.l1_pars.ms_power_level);
+   /* Send the actual RACH */
+   fn := f_L1CTL_RACH(L1CTL, ra);
+
+   T.start;
+   alt {
+   [] RSL.receive(tr_RSL_CHAN_RQD(int2oct(ra,1), fn)) { setverdict(pass, 
"Received CHAN-RQD from RACH REQ") }
+   [] T.timeout {
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
log2str("Timeout waiting for CHAN-RQD from RACH REQ <", ra, ", ", fn, ">"));
+   }
+   }
+   T.stop
+   return fn;
+}

 /* Establish dedicated channel: L1CTL + RSL side */
 private function f_est_dchan(boolean encr_enable := false) runs on ConnHdlr {
@@ -1351,10 +1373,8 @@
var ImmediateAssignment imm_ass;
var integer ra := 23;

-   f_L1CTL_PARAM(L1CTL, g_pars.l1_pars.ms_actual_ta, 
g_pars.l1_pars.ms_power_level);
-   fn := f_L1CTL_RACH(L1CTL, ra);
-   /* This arrives on CCHAN, so we cannot test for receiving CHAN RQDhere 
*/
-   //RSL.receive(tr_RSL_CHAN_RQD(int2oct(23,1)));
+   /* Send RACH request and wait for ChanReq */
+   fn := f_rach_req_wait_chan_rqd(ra);

/* Activate channel on BTS side */
f_rsl_chan_act(g_pars.chan_mode, encr_enable);
diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index cf02d00..cdeca74 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -47,14 +47,19 @@

 type record RSLDC_ChanRqd {
OCT1ra,
-   GsmFrameNumber  fn
+   GsmFrameNumber  fn optional
 };

-template RSLDC_ChanRqd ts_RSLDC_ChanRqd(OCT1 ra, GsmFrameNumber fn) := {
+template (value) RSLDC_ChanRqd ts_RSLDC_ChanRqd(OCT1 ra, GsmFrameNumber fn) := 
{
ra := ra,
fn := fn
 }

+template (value) RSLDC_ChanRqd ts_RSLDC_ChanRqd_anyFN(OCT1 ra) := {
+   ra := ra,
+   fn := omit
+}
+
 type port RSL_DCHAN_PT message {
inout RSLDC_ChanRqd, RSL_Message;
 } with { extension "internal" };
@@ -183,15 +188,36 @@
return -1;
 }

+/* Matches by only RA if FN is ommited in one of the connections allocated */
+private function f_cid_by_ra_fn2(OCT1 ra, RSL_IE_FrameNumber fn)
+runs on RSL_Emulation_CT return integer {
+   var integer i;
+   for (i := 0; i < sizeof(ConnectionTable); i := i+1) {
+   if (ispresent(ConnectionTable[i].ra) and
+   ConnectionTable[i].ra == ra) {
+   if (not ispresent(ConnectionTable[i].ra_fn) or
+   fn == 
valueof(ts_RSL_IE_FrameNumber(ConnectionTable[i].ra_fn))) {
+   return i;
+   }
+   }
+   }
+   log("No Dchan handler for ", ra, fn);
+   return -1;
+}
+
 /* create an ew client with given RA and FN */
-private function f_cid_create(OCT1 ra, GsmFrameNumber fn, RSL_DchanHdlr 
comp_ref)
+private function f_cid_create(OCT1 ra, template (omit) GsmFrameNumber fn, 
RSL_DchanHdlr comp_ref)
 runs on RSL_Emulation_CT {
var integer i;
for (i := 0; i < sizeof(ConnectionTable); i := i+1) {
if (not ispresent(ConnectionTable[i].ra) and
not ispresent(ConnectionTable[i].trx_nr)) {
ConnectionTable[i].ra := ra;
-   ConnectionTable[i].ra_fn := fn;
+   if (ispresent(fn)) {
+   ConnectionTable[i].ra_fn := valueof(fn);
+   } else {
+

Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11562 )

Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on 
RSL
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11562
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438fd3ee82d88498d928dbcc89ce9bd80d37ab64
Gerrit-Change-Number: 11562
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 06 Nov 2018 16:19:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm_29_118: add missing include to header file

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11638


Change subject: gsm_29_118: add missing include to header file
..

gsm_29_118: add missing include to header file

The header file gsm_29_118.h is defining variables of type struct
value_string, which is declared in core/utils.h. We should add an
include to utils.h to prevent confusion when the header is used.

Change-Id: I9f9bb62d29cd068820ad5aa677717bd448de3f4a
Related: OS#3615
---
M include/osmocom/gsm/protocol/gsm_29_118.h
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/11638/1

diff --git a/include/osmocom/gsm/protocol/gsm_29_118.h 
b/include/osmocom/gsm/protocol/gsm_29_118.h
index 24e9de2..c344f04 100644
--- a/include/osmocom/gsm/protocol/gsm_29_118.h
+++ b/include/osmocom/gsm/protocol/gsm_29_118.h
@@ -1,5 +1,6 @@
 #pragma once

+#include 

 /* TS 29.118 Section 9.2 */
 enum sgsap_msg_type {

--
To view, visit https://gerrit.osmocom.org/11638
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f9bb62d29cd068820ad5aa677717bd448de3f4a
Gerrit-Change-Number: 11638
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/11637


Change subject: hlr: Fix DTE by requesting the correct type
..

hlr: Fix DTE by requesting the correct type

Previous commit d686a8a54873eb61fae7d55cb001378dae3fbd7d from Vadim
introduced a copy and paste error.

Change-Id: I5075b17a810762651e0c7d638cc4c35c58436cd9
---
M hlr/HLR_EUSE.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/37/11637/1

diff --git a/hlr/HLR_EUSE.ttcn b/hlr/HLR_EUSE.ttcn
index 93eb8f4..fbb496c 100644
--- a/hlr/HLR_EUSE.ttcn
+++ b/hlr/HLR_EUSE.ttcn
@@ -58,7 +58,7 @@
var SS_FacilityInformation dec_fac, rsp_fac;
var octetstring ss_rsp;

-   f_gsup_find_ie(rx_pdu, OSMO_GSUP_SS_INFO_IE, state_ie);
+   f_gsup_find_ie(rx_pdu, OSMO_GSUP_SESSION_STATE_IE, state_ie);
var GSUP_SessionState ss_state := state_ie.session_state;

f_gsup_find_ie(rx_pdu, OSMO_GSUP_SS_INFO_IE, ss_ie);

--
To view, visit https://gerrit.osmocom.org/11637
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5075b17a810762651e0c7d638cc4c35c58436cd9
Gerrit-Change-Number: 11637
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 

Change in libosmocore[master]: NS: log address:port on error

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11636


Change subject: NS: log address:port on error
..

NS: log address:port on error

Change-Id: If2dc533a6dc150254f5d44b672f04bb728e7e927
---
M src/gb/gprs_ns.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/11636/1

diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 198ead1..34bbfde 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -1510,6 +1510,8 @@
struct msgb *msg = gprs_ns_msgb_alloc();
int ret = 0;
socklen_t saddr_len = sizeof(*saddr);
+   uint16_t port, addr_len = 32;
+   char addr[addr_len];

if (!msg) {
*error = -ENOMEM;
@@ -1519,8 +1521,9 @@
ret = recvfrom(bfd->fd, msg->data, NS_ALLOC_SIZE - NS_ALLOC_HEADROOM, 0,
(struct sockaddr *)saddr, _len);
if (ret < 0) {
-   LOGP(DNS, LOGL_ERROR, "recv error %s during NSIP recv\n",
-   strerror(errno));
+   osmo_sockaddr_to_str_and_uint(addr, addr_len, , (const 
struct sockaddr*)saddr);
+   LOGP(DNS, LOGL_ERROR, "recv error %s during NSIP recvfrom 
%s:%u\n",
+strerror(errno), addr, port);
msgb_free(msg);
*error = ret;
return NULL;

--
To view, visit https://gerrit.osmocom.org/11636
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2dc533a6dc150254f5d44b672f04bb728e7e927
Gerrit-Change-Number: 11636
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-gsm-tester[master]: resources.conf.prod: Update modem info after HW upgrade

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11631 )

Change subject: resources.conf.prod: Update modem info after HW upgrade
..

resources.conf.prod: Update modem info after HW upgrade

A new quadmodem with 4xEC20 has been added to the Prod setup.

Change-Id: I51f0b7dd7a1857d34fc2c5076016caeffa15240d
---
M example/resources.conf.prod
1 file changed, 35 insertions(+), 7 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/example/resources.conf.prod b/example/resources.conf.prod
index b4ab445..0cab84f 100644
--- a/example/resources.conf.prod
+++ b/example/resources.conf.prod
@@ -132,13 +132,6 @@
   ciphers: [a5_0, a5_1]
   features: ['sms', 'voice', 'ussd', 'sim']

-- label: ec20
-  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.4/1-5.4.1/1-5.4.1.6'
-  ki: '07F35D0A9476646169669401215580E0'
-  auth_algo: 'comp128v1'
-  ciphers: [a5_0, a5_1]
-  features: ['sms', 'voice', 'ussd', 'gprs', 'sim']
-
 - label: gobi2k
   path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.4/1-5.4.1/1-5.4.1.5'
   ki: '5752B3F43277C35D2D1D957007DF74E2'
@@ -146,5 +139,40 @@
   ciphers: [a5_0, a5_1]
   features: ['sim']

+- label: ec20_1
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.4/1-5.4.1/1-5.4.1.6'
+  ki: '07F35D0A9476646169669401215580E0'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'gprs', 'sim']
+
+- label: ec20_2
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.2'
+  ki: '278B899D126C31F3B24D21E3EB556530'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'gprs', 'sim']
+
+- label: ec20_3
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.3'
+  ki: 'B43BBCD8DE4D594F4146DE3D8ADC589D'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'gprs', 'sim']
+
+- label: ec20_4
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.5'
+  ki: 'A41F06F39DE3B0295C178A674D3E3636'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'gprs', 'sim']
+
+- label: ec20_5
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.6'
+  ki: '8CCBE85A62C6DC7AC2A9886F4BBC3146'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'gprs', 'sim']
+
 osmocon_phone:
   - serial_device: 
'/dev/serial/by-id/usb-Silicon_Labs_CP2104_USB_to_UART_Bridge_Controller_00897B41-if00-port0'

--
To view, visit https://gerrit.osmocom.org/11631
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51f0b7dd7a1857d34fc2c5076016caeffa15240d
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: resources.conf.prod: Update modem info after HW upgrade

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11631 )

Change subject: resources.conf.prod: Update modem info after HW upgrade
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11631
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51f0b7dd7a1857d34fc2c5076016caeffa15240d
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 15:47:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Hello osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11560

to look at the new patch set (#5).

Change subject: replace src/* git scripts with a single src/gits
..

replace src/* git scripts with a single src/gits

I keep re-using this functionality in completely unrelated realms, and decided
to unify the oddly named scripts in a single 'gits' meta-repos tool, so I can
just symlink this script into my ~/bin and use it everywhere.

Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
---
M src/README
D src/e
D src/g
D src/git_branch_summary.py
A src/gits
D src/s
D src/st
7 files changed, 426 insertions(+), 298 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/60/11560/5
--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11635


Change subject: 2G.deps: add osmo-sip-connector
..

2G.deps: add osmo-sip-connector

Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
---
M 2G.deps
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/35/11635/1

diff --git a/2G.deps b/2G.deps
index c77646e..e4a4be5 100644
--- a/2G.deps
+++ b/2G.deps
@@ -10,4 +10,5 @@
 osmo-msc   libosmo-sccp osmo-mgw libsmpp34
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  libosmo-sccp osmo-ggsn osmo-hlr
+osmo-sip-connector libosmocore
 #osmo-trx  libosmocore

--
To view, visit https://gerrit.osmocom.org/11635
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
Gerrit-Change-Number: 11635
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-dev[master]: sanitize.opts: add osmo-sip-connector --enable-sanitize

[Neels Hofmeyr]

Neels Hofmeyr has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/11593 )

Change subject: sanitize.opts: add osmo-sip-connector --enable-sanitize
..

sanitize.opts: add osmo-sip-connector --enable-sanitize

Otherwise it is not able to link asan-enabled libosmocore in the binaries.

Change-Id: I5e04ef38982ee6c89110776fc941ee0e2c193196
---
M sanitize.opts
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/93/11593/2
--
To view, visit https://gerrit.osmocom.org/11593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e04ef38982ee6c89110776fc941ee0e2c193196
Gerrit-Change-Number: 11593
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-dev[master]: deps: comment out osmo-trx

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11634


Change subject: deps: comment out osmo-trx
..

deps: comment out osmo-trx

osmo-trx shouldn't run with address sanitizer. But omitting --enable-sanitize
from osmo-trx breaks 'make check', so then the whole top-level makefile will
end in error with sanitize.opts.

A user wanting to build osmo-trx can just uncomment that line.

Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
---
M 2G.deps
M 3G+2G.deps
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/34/11634/1

diff --git a/2G.deps b/2G.deps
index cf2723a..c77646e 100644
--- a/2G.deps
+++ b/2G.deps
@@ -10,4 +10,4 @@
 osmo-msc   libosmo-sccp osmo-mgw libsmpp34
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  libosmo-sccp osmo-ggsn osmo-hlr
-osmo-trx   libosmocore
+#osmo-trx  libosmocore
diff --git a/3G+2G.deps b/3G+2G.deps
index b82e7c9..71691a0 100644
--- a/3G+2G.deps
+++ b/3G+2G.deps
@@ -13,4 +13,4 @@
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  osmo-iuh osmo-ggsn osmo-hlr
 osmo-sip-connector libosmocore
-osmo-trx   libosmocore
+#osmo-trx  libosmocore

--
To view, visit https://gerrit.osmocom.org/11634
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bts[master]: prevent potential NULL dereference in virtbts's tx_tchh_fn

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11632 )

Change subject: prevent potential NULL dereference in virtbts's tx_tchh_fn
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11632/1/src/osmo-bts-virtual/scheduler_virtbts.c
File src/osmo-bts-virtual/scheduler_virtbts.c:

https://gerrit.osmocom.org/#/c/11632/1/src/osmo-bts-virtual/scheduler_virtbts.c@463
PS1, Line 463:  if (msg_facch) {
IIUC, whe chan_state->dl_ongoing_facch is TRUE, that means msg_facch cannot be 
NULL (unless something really bad is going on), and as a result we always go 
into this branch.

Can tx_tch_common return msg_facch==NULL and msg_tch==NULL at the same time?



--
To view, visit https://gerrit.osmocom.org/11632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3
Gerrit-Change-Number: 11632
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 15:36:41 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11560 )

Change subject: replace src/* git scripts with a single src/gits
..


Patch Set 4:

(13 comments)

patch set coming up...

https://gerrit.osmocom.org/#/c/11560/4/src/gits
File src/gits:

https://gerrit.osmocom.org/#/c/11560/4/src/gits@2
PS4, Line 2: argparse
> argparse is not used. […]
the reason why argparse will not work so well is passing arguments to git. 
consider:

  gits clean -dxf

then 'gits' will argparse the -dxf arguments, but they were intended to be 
passed on to each 'cd subdir/; git clean -dxf' cmdline.

good catch about -h


https://gerrit.osmocom.org/#/c/11560/4/src/gits@11
PS4, Line 11: re_status_mods = re.compile('^\t(modified|deleted):.*')
> This is only used once in the code. […]
I think I'd rather precompile all others here as well


https://gerrit.osmocom.org/#/c/11560/4/src/gits@29
PS4, Line 29: print(' '.join(cmd))
> How about differentiating the command from the output it produces? For 
> example with a leading '>' ch […]
can do. I think I'd use the '+ ' ala 'set -x'


https://gerrit.osmocom.org/#/c/11560/4/src/gits@37
PS4, Line 37: sys.stderr.flush()
> why flush the output only when the section_marker is needed?
not sure. probably came from previous code... should probably flush above 
instead


https://gerrit.osmocom.org/#/c/11560/4/src/gits@45
PS4, Line 45: m
> how about "branch" as variable name?
it's a re "match object"


https://gerrit.osmocom.org/#/c/11560/4/src/gits@48
PS4, Line 48:   return m.group(1)
this one is the branch


https://gerrit.osmocom.org/#/c/11560/4/src/gits@68
PS4, Line 68: up to date
> With git 2.11.0 I get: […]
yeah, that's the main ultra drawback of this script so far. I really really 
shouldn't use porcelain. I'm not sure how to use plumbing though, so far it's 
"works-for-me" -- do you know how to fix that?


https://gerrit.osmocom.org/#/c/11560/4/src/gits@122
PS4, Line 122: strs.append(''.join(branch_info))
> why make a list first, and then join it?
that's my common string composition pattern. If I do "str = str + more", then I 
create an ever growing string in a loop. If I append to a list and later join, 
I only create one large string in the end. Well, it's premature optimization, 
but I prefer that style.

In this instance it was about conditionally adding strings. a bit overboard, yes


https://gerrit.osmocom.org/#/c/11560/4/src/gits@194
PS4, Line 194: print('\n= %s =' % git_dir)
> If we print out something like "> cd %s && %s" before the output of the 
> command, it would be consist […]
I like more visible markers in this case


https://gerrit.osmocom.org/#/c/11560/4/src/gits@200
PS4, Line 200: SkipThisRepos
> How about "SkipThisRepo"? repo is commonly used to abbreviate repository, so 
> when reading "repos" I' […]
I've always thought of "repos", not "repo", had the same "conflict" with stsp 
many years ago... :)


https://gerrit.osmocom.org/#/c/11560/4/src/gits@223
PS4, Line 223:   if v == answer:
 : return answer
 :   if v == '*':
 : return answer
> how about: […]
I see, but I prefer listing each valid_answers case in its separate 'if'


https://gerrit.osmocom.org/#/c/11560/4/src/gits@359
PS4, Line 359: cmd_do(sys.argv[1:])
> I'm not sure if it's a good idea to perform "do" by default - whenever 
> there's a typo in any of the  […]
but I want to write 'gits fetch' :)
and don't want to write a shim for each and every one of those...

you're right of course, maybe a shim then.


https://gerrit.osmocom.org/#/c/11560/4/src/gits@362
PS4, Line 362: # vim: shiftwidth=2 expandtab tabstop=2
> Since there are not Python coding guidelines in the wiki yet: […]
wow, you're just as obsessed with details like I am!



--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 06 Nov 2018 15:31:09 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: GSUP: introduce new InvokeID Information Element

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11633


Change subject: GSUP: introduce new InvokeID Information Element
..

GSUP: introduce new InvokeID Information Element

Each invoke component in TCAP is identified by an unique InvokeID,
assigned by the application that originates the invoke. The
InvokeID is returned in the response, and allows the originator
to correlate the reply with the invoke operation to which
it belongs.

Since GSUP has no TCAP layer, there are optional SESSION_ID and
SESSION_STATE IEs aimed to 'emulate' the dialog. This change
introduces the new optional INVOKE_ID IE.

InvokeID is required in order to support multy-part SMS over GSUP.

Change-Id: If14006b035ff465b73b39ea4cd59e5fd16a4d7ff
Related: OS#3587
---
M TODO-RELEASE
M include/osmocom/gsm/gsup.h
M src/gsm/gsup.c
M tests/gsup/gsup_test.c
M tests/gsup/gsup_test.err
5 files changed, 33 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/11633/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index a4c48ca..4bed90d 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -11,3 +11,4 @@
 libosmogsm gsm48_push_l3hdr()  (re)introduced in gsm/gsm48.h (GSM 
04.08 API)
 libosmogsm gsm48_push_l3hdr_tid()  a wrapper around gsm48_push_l3hdr()
 libosmogsm osmo_gsup_message   extended with SMS related fields
+libosmogsm osmo_gsup_message   extended with InvokeID
diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h
index f314672..867b409 100644
--- a/include/osmocom/gsm/gsup.h
+++ b/include/osmocom/gsm/gsup.h
@@ -86,6 +86,7 @@

OSMO_GSUP_SESSION_ID_IE = 0x30,
OSMO_GSUP_SESSION_STATE_IE  = 0x31,
+   OSMO_GSUP_INVOKE_ID_IE  = 0x32,

/*! Supplementary Services payload */
OSMO_GSUP_SS_INFO_IE= 0x35,
@@ -223,6 +224,9 @@
/*! Unique session identifier and origination flag.
 * Encoded only when \ref session_state != 0x00 */
uint32_tsession_id;
+   /*! InvokeID, maps REQ/RES pairs within a single session.
+* Encoded only when \ref invoke_id != NULL */
+   int8_t  *invoke_id;

/*! ASN.1 encoded MAP payload for Supplementary Services */
uint8_t *ss_info;
diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c
index dbab424..d68 100644
--- a/src/gsm/gsup.c
+++ b/src/gsm/gsup.c
@@ -448,6 +448,10 @@
gsup_msg->session_state = *value;
break;

+   case OSMO_GSUP_INVOKE_ID_IE:
+   gsup_msg->invoke_id = (int8_t *) value;
+   break;
+
case OSMO_GSUP_SS_INFO_IE:
gsup_msg->ss_info = value;
gsup_msg->ss_info_len = value_len;
@@ -657,6 +661,12 @@
msgb_tlv_put(msg, OSMO_GSUP_SESSION_STATE_IE, sizeof(u8), );
}
 
+   if (gsup_msg->invoke_id) {
+   uint8_t *invoke_id = (uint8_t *) gsup_msg->invoke_id;
+   msgb_tlv_put(msg, OSMO_GSUP_INVOKE_ID_IE,
+   sizeof(*invoke_id), invoke_id);
+   }
+
if (gsup_msg->ss_info) {
msgb_tlv_put(msg, OSMO_GSUP_SS_INFO_IE,
gsup_msg->ss_info_len, gsup_msg->ss_info);
diff --git a/tests/gsup/gsup_test.c b/tests/gsup/gsup_test.c
index 4eef483..a8c0b4e 100644
--- a/tests/gsup/gsup_test.c
+++ b/tests/gsup/gsup_test.c
@@ -226,6 +226,8 @@
0xde, 0xad, 0xbe, 0xef,
0x31, 0x01, /* Session state (BEGIN) */
0x01,
+   0x32, 0x01, /* InvokeID */
+   0xfa,
 
/* SM related IEs */
0x40, 0x09, /* SM-RP-DA (Destination Address) */
@@ -246,6 +248,8 @@
0xde, 0xad, 0xbe, 0xef,
0x31, 0x01, /* Session state (BEGIN) */
0x01,
+   0x32, 0x01, /* InvokeID */
+   0xfa,

/* SM related IEs */
0x40, 0x0a, /* SM-RP-DA (Destination Address) */
@@ -267,6 +271,8 @@
0xde, 0xad, 0xbe, 0xef,
0x31, 0x01, /* Session state (END) */
0x03,
+   0x32, 0x01, /* InvokeID */
+   0xfa,

/* SM related IEs */
0x42, 0x04, /* SM-RP-UI (TPDU) */
diff --git a/tests/gsup/gsup_test.err b/tests/gsup/gsup_test.err
index 37aa4ce..864b6af 100644
--- a/tests/gsup/gsup_test.err
+++ b/tests/gsup/gsup_test.err
@@ -49,14 +49,14 @@
   generated message: 22 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 
03 35 08 a3 06 02 01 01 02 01 47
   original message:  22 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 
03 35 08 

Change in osmo-bts[master]: prevent potential NULL dereference in virtbts's tx_tchh_fn

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11632


Change subject: prevent potential NULL dereference in virtbts's tx_tchh_fn
..

prevent potential NULL dereference in virtbts's tx_tchh_fn

If chan_state->ongoing_facch is set, this code's logic
suggests that both msg_facch and msg_tch could be NULL.
Don't dereference msg_tch unconditionally.

Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3
Related: CID#172047
---
M src/osmo-bts-virtual/scheduler_virtbts.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/11632/1

diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c 
b/src/osmo-bts-virtual/scheduler_virtbts.c
index 2248afc..25f6583 100644
--- a/src/osmo-bts-virtual/scheduler_virtbts.c
+++ b/src/osmo-bts-virtual/scheduler_virtbts.c
@@ -463,7 +463,7 @@
if (msg_facch) {
tx_to_virt_um(l1t, tn, fn, chan, msg_facch);
msgb_free(msg_tch);
-   } else
+   } else if (msg_tch)
tx_to_virt_um(l1t, tn, fn, chan, msg_tch);

 send_burst:

--
To view, visit https://gerrit.osmocom.org/11632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3
Gerrit-Change-Number: 11632
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 

Change in osmo-gsm-tester[master]: resources.conf.prod: Update modem info after HW upgrade

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11631

to look at the new patch set (#2).

Change subject: resources.conf.prod: Update modem info after HW upgrade
..

resources.conf.prod: Update modem info after HW upgrade

A new quadmodem with 4xEC20 has been added to the Prod setup.

Change-Id: I51f0b7dd7a1857d34fc2c5076016caeffa15240d
---
M example/resources.conf.prod
1 file changed, 35 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/31/11631/2
--
To view, visit https://gerrit.osmocom.org/11631
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51f0b7dd7a1857d34fc2c5076016caeffa15240d
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #299

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in osmo-gsm-tester[master]: resources.conf.prod: Update modem info after HW upgrade

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11631


Change subject: resources.conf.prod: Update modem info after HW upgrade
..

resources.conf.prod: Update modem info after HW upgrade

A new quadmodem with 4xEC20 has been added to the Prod setup.

Change-Id: I51f0b7dd7a1857d34fc2c5076016caeffa15240d
---
M example/resources.conf.prod
1 file changed, 35 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/31/11631/1

diff --git a/example/resources.conf.prod b/example/resources.conf.prod
index b4ab445..1c7eb4a 100644
--- a/example/resources.conf.prod
+++ b/example/resources.conf.prod
@@ -132,13 +132,6 @@
   ciphers: [a5_0, a5_1]
   features: ['sms', 'voice', 'ussd', 'sim']

-- label: ec20
-  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.4/1-5.4.1/1-5.4.1.6'
-  ki: '07F35D0A9476646169669401215580E0'
-  auth_algo: 'comp128v1'
-  ciphers: [a5_0, a5_1]
-  features: ['sms', 'voice', 'ussd', 'gprs', 'sim']
-
 - label: gobi2k
   path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.4/1-5.4.1/1-5.4.1.5'
   ki: '5752B3F43277C35D2D1D957007DF74E2'
@@ -146,5 +139,40 @@
   ciphers: [a5_0, a5_1]
   features: ['sim']

+- label: ec20_1
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.4/1-5.4.1/1-5.4.1.6'
+  ki: '07F35D0A9476646169669401215580E0'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'sim']
+
+- label: ec20_2
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.2'
+  ki: '278B899D126C31F3B24D21E3EB556530'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'sim']
+
+- label: ec20_3
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.3'
+  ki: 'B43BBCD8DE4D594F4146DE3D8ADC589D'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'sim']
+
+- label: ec20_4
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.5'
+  ki: 'A41F06F39DE3B0295C178A674D3E3636'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'sim']
+
+- label: ec20_5
+  path: '/sys/devices/pci:00/:00:12.2/usb1/1-5/1-5.3/1-5.3.6'
+  ki: '8CCBE85A62C6DC7AC2A9886F4BBC3146'
+  auth_algo: 'comp128v1'
+  ciphers: [a5_0, a5_1]
+  features: ['sms', 'voice', 'ussd', 'sim']
+
 osmocon_phone:
   - serial_device: 
'/dev/serial/by-id/usb-Silicon_Labs_CP2104_USB_to_UART_Bridge_Controller_00897B41-if00-port0'

--
To view, visit https://gerrit.osmocom.org/11631
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51f0b7dd7a1857d34fc2c5076016caeffa15240d
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-bsc[master]: prevent a NULL pointer dereference in debug_candidate()

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11630


Change subject: prevent a NULL pointer dereference in debug_candidate()
..

prevent a NULL pointer dereference in debug_candidate()

Prevent a potential NULL pointer dereference in debug logging
of the handover decision 2 implementation. The existing logic
didn't correctly account for the fact that bts->candidate may
be a NULL pointer.

Change-Id: Ie3d672d835bbc136809e593a819a6dda7c84a88e
Related: CID#10
---
M src/osmo-bsc/handover_decision_2.c
1 file changed, 15 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/11630/1

diff --git a/src/osmo-bsc/handover_decision_2.c 
b/src/osmo-bsc/handover_decision_2.c
index a8fff63..833b1d0 100644
--- a/src/osmo-bsc/handover_decision_2.c
+++ b/src/osmo-bsc/handover_decision_2.c
@@ -827,18 +827,21 @@
"RX level %d -> %d\n",
rxlev2dbm(rxlev), 
rxlev2dbm(candidate->avg));

-   if (candidate->bts == lchan->ts->trx->bts)
-   LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,
-"RX level %d; "
-HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) "\n",
-rxlev2dbm(candidate->avg),
-HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));
-   else if (candidate->bts)
-   LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,
-"RX level %d -> %d; "
-HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) "\n",
-rxlev2dbm(rxlev), rxlev2dbm(candidate->avg),
-HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));
+   if (candidate->bts) {
+   if (candidate->bts == lchan->ts->trx->bts) {
+   LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,
+"RX level %d; "
+HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) 
"\n",
+rxlev2dbm(candidate->avg),
+HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));
+   } else {
+   LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,
+"RX level %d -> %d; "
+HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) 
"\n",
+rxlev2dbm(rxlev), rxlev2dbm(candidate->avg),
+HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));
+   }
+   }
 }

 /* add candidate for re-assignment within the current cell */

--
To view, visit https://gerrit.osmocom.org/11630
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3d672d835bbc136809e593a819a6dda7c84a88e
Gerrit-Change-Number: 11630
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 

Change in osmo-bsc[master]: check return value of gsm48_multirate_config()

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11629 )

Change subject: check return value of gsm48_multirate_config()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11629
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61153a44e8b7a38332bf38718397be9b339d5f25
Gerrit-Change-Number: 11629
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 06 Nov 2018 14:46:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: check return value of gsm48_multirate_config()

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11629


Change subject: check return value of gsm48_multirate_config()
..

check return value of gsm48_multirate_config()

Check the return value of gsm48_multirate_config() in function
lchan_set_single_amr_mode(). This prevents an invalid AMR mode
from being configured for a logical channel.

Because the VTY parsier limits the AMR mode range to 0-7 this
is just a theoretical issue. However, this fact is beyond the
understanding of a static code analyzer, and the absence of
error handling was indeed setting a bad example.

Change-Id: I61153a44e8b7a38332bf38718397be9b339d5f25
Related: CID#188940
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 21 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/11629/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 410cdac..0b951c0 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4483,10 +4483,11 @@
 }

 /* configure the lchan for a single AMR mode (as specified) */
-static int lchan_set_single_amr_mode(struct gsm_lchan *lchan, uint8_t amr_mode)
+static int lchan_set_single_amr_mode(struct vty *vty, struct gsm_lchan *lchan, 
uint8_t amr_mode)
 {
struct amr_multirate_conf mr;
struct gsm48_multi_rate_conf *mr_conf;
+   int rc, vty_rc = CMD_SUCCESS;
mr_conf = (struct gsm48_multi_rate_conf *) _ie;

if (amr_mode > 7)
@@ -4505,10 +4506,22 @@

/* encode this configuration into the lchan for both uplink and
 * downlink direction */
-   gsm48_multirate_config(lchan->mr_ms_lv, mr_conf, mr.ms_mode, 
mr.num_modes);
-   gsm48_multirate_config(lchan->mr_bts_lv, mr_conf, mr.bts_mode, 
mr.num_modes);
+   rc = gsm48_multirate_config(lchan->mr_ms_lv, mr_conf, mr.ms_mode, 
mr.num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (%s, amr mode %d, 
ms) - check parameters%s",
+   gsm_lchant_name(lchan->type), amr_mode, VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }
+   rc = gsm48_multirate_config(lchan->mr_bts_lv, mr_conf, mr.bts_mode, 
mr.num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (%s, amr mode %d, 
bts) - check parameters%s",
+   gsm_lchant_name(lchan->type), amr_mode, VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }

-   return 0;
+   return vty_rc;
 }

 /* Debug/Measurement command to activate a given logical channel
@@ -4564,14 +4577,16 @@
else if (!strcmp(codec_str, "efr"))
lchan->tch_mode = GSM48_CMODE_SPEECH_EFR;
else if (!strcmp(codec_str, "amr")) {
-   int amr_mode;
+   int amr_mode, vty_rc;
if (argc < 7) {
vty_out(vty, "%% AMR requires specification of 
AMR mode%s", VTY_NEWLINE);
return CMD_WARNING;
}
amr_mode = atoi(argv[6]);
lchan->tch_mode = GSM48_CMODE_SPEECH_AMR;
-   lchan_set_single_amr_mode(lchan, amr_mode);
+   vty_rc = lchan_set_single_amr_mode(vty, lchan, 
amr_mode);
+   if (vty_rc != CMD_SUCCESS)
+   return vty_rc;
}
vty_out(vty, "%% activating lchan %s%s", gsm_lchan_name(lchan), 
VTY_NEWLINE);
rsl_tx_chan_activ(lchan, RSL_ACT_TYPE_INITIAL, 0);

--
To view, visit https://gerrit.osmocom.org/11629
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61153a44e8b7a38332bf38718397be9b339d5f25
Gerrit-Change-Number: 11629
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11628


Change subject: ansible: gsm-tester: Support power cycling multiple quad modems
..

ansible: gsm-tester: Support power cycling multiple quad modems

uhubctl doesn't support acting on several hubs from same vendor at once.

Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
---
M ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
1 file changed, 8 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/28/11628/1

diff --git a/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh 
b/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
index 626a04e..f461d81 100755
--- a/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
+++ b/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
@@ -1,9 +1,15 @@
 #!/bin/sh
 set -ex
-uhubctl -p 123456 -a 0 -n 1d50:4002
+
+locations="$(uhubctl -n 1d50:4002 | grep "Current status for hub" | awk 
'{print $5}')"
+for l in $locations; do
+   uhubctl -p 123456 -a 0 -n 1d50:4002 -l $l
+done
 # give a lot of time to discharge capacitors on the board
 sleep 20
-uhubctl -p 123456 -a 1 -n 1d50:4002
+for l in $locations; do
+   uhubctl -p 123456 -a 1 -n 1d50:4002 -l $l
+done
 attempts=30
 while [ "x$(uhubctl | grep -e 05c6 -e 1199 -c)" != "x{{ gsm_modems }}" ]; do
attempts=$(($attempts - 1))

--
To view, visit https://gerrit.osmocom.org/11628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ci[master]: ansible: gsm-tester: prod has now 8 modems attached

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11627


Change subject: ansible: gsm-tester: prod has now 8 modems attached
..

ansible: gsm-tester: prod has now 8 modems attached

4 EC20 modems were attached,  and the issue with only 3 out of the 4
showing up was fixed a while ago.

Change-Id: I0e0876fd5581e9eb56c498078ae8cd8c68ede5b5
---
M ansible/host_vars/osmo-gsm-tester-prod.yml
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/27/11627/1

diff --git a/ansible/host_vars/osmo-gsm-tester-prod.yml 
b/ansible/host_vars/osmo-gsm-tester-prod.yml
index 9d195de..92d8169 100644
--- a/ansible/host_vars/osmo-gsm-tester-prod.yml
+++ b/ansible/host_vars/osmo-gsm-tester-prod.yml
@@ -8,4 +8,4 @@
 ip: 10.42.42.122

 # how many modems are connected via a quadmodem?
-gsm_modems: 3
+gsm_modems: 8

--
To view, visit https://gerrit.osmocom.org/11627
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e0876fd5581e9eb56c498078ae8cd8c68ede5b5
Gerrit-Change-Number: 11627
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol