Jenkins build is back to normal : master-libosmo-sccp » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #1934

[jenkins]

See 

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: drop meaningless warnings

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12291


Change subject: trx_toolkit/ctrl_if_trx.py: drop meaningless warnings
..

trx_toolkit/ctrl_if_trx.py: drop meaningless warnings

A timeslot can be reconfigured at runtime, this is normal.
We should neither complain nor reject such commands.

Change-Id: I0a69ebceed5aa724093e6d1b23faad8c16705055
---
M src/target/trx_toolkit/ctrl_if_trx.py
1 file changed, 0 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/91/12291/1

diff --git a/src/target/trx_toolkit/ctrl_if_trx.py 
b/src/target/trx_toolkit/ctrl_if_trx.py
index b9fa751..5b2332b 100644
--- a/src/target/trx_toolkit/ctrl_if_trx.py
+++ b/src/target/trx_toolkit/ctrl_if_trx.py
@@ -120,18 +120,10 @@
# Deactivate TS (remove from the list of active 
timeslots)
if ts in self.trx.ts_list:
self.trx.ts_list.remove(ts)
-   else:
-   log.warning("TS %u was not activated 
before" % ts)
-   # TODO: uncomment as soon as RESET is 
introduced
-   # return -1
else:
# Activate TS (add to the list of active 
timeslots)
if ts not in self.trx.ts_list:
self.trx.ts_list.append(ts)
-   else:
-   log.warning("TS %u was already 
activated before" % ts)
-   # TODO: uncomment as soon as RESET is 
introduced
-   # return -1

return 0


--
To view, visit https://gerrit.osmocom.org/12291
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a69ebceed5aa724093e6d1b23faad8c16705055
Gerrit-Change-Number: 12291
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Build failed in Jenkins: master-libosmo-sccp » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #1933

[jenkins]

See 


--
[...truncated 115.10 KB...]
   - use the '-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to '/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in tests
make[2]: Entering directory 
'
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
make[2]: Entering directory 
'
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644 libosmoabis.pc libosmotrau.pc 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
+ 
STOW_DIR=
 stow --restow libosmo-abis
+ osmo-build-dep.sh libosmo-netif



 === libosmo-netif ===

+ mkdir -p 

+ cd 

+ osmo-deps.sh libosmo-netif 
+ project=libosmo-netif
+ branch=master
+ git branch -a
+ grep -c remotes/origin/master$
+ [ x1 != x0 ]
+ branch=origin/master
+ test -d libosmo-netif
+ cd libosmo-netif
+ git fetch --tags origin
+ git fetch origin
+ deps= osmo-clean-workspace.sh
+ chmod -R +w .
+ git checkout -f HEAD
+ git clean -dxf
+ [ -d  ]
+ [ -d layer1-headers ]
+ git checkout -f origin/master
HEAD is now at dc8fcf5... logging: fix typo in stream.c
+ git rev-parse HEAD
dc8fcf5a696781048e2287e058f2b21af6164c9e
+ cd libosmo-netif
+ mkdir -p 

+ autoreconf --install --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:20: 

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Use lchan name based logging

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12289


Change subject: osmo-bts-trx/loops.c: Use lchan name based logging
..

osmo-bts-trx/loops.c: Use lchan name based logging

The loops.c code dates back to ancient times when we printed the TRX
number and the raw channel number to identify a logical channel.  We
meanwhile have gsm_lchan_name() and should use it to log messages
related to this lchan in a common format.

This commit introduces the LOGPLCHAN() helper macro [similar to
osmo-bsc], and uses it from loops.c.

As a result, some functions don't need a chan_nr argument anymore,
while some need to add a new lchan argument.

Change-Id: I6976dd7444c26b1f52741bc367b0311ebbef1718
Related: OS#1622, OS#1851
---
M include/osmo-bts/gsm_data.h
M src/osmo-bts-trx/loops.c
2 files changed, 38 insertions(+), 56 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/12289/1

diff --git a/include/osmo-bts/gsm_data.h b/include/osmo-bts/gsm_data.h
index 9e62cdf..1de5edd 100644
--- a/include/osmo-bts/gsm_data.h
+++ b/include/osmo-bts/gsm_data.h
@@ -24,6 +24,8 @@
 #define GSM_BTS_AGCH_QUEUE_LOW_LEVEL_DEFAULT 41
 #define GSM_BTS_AGCH_QUEUE_HIGH_LEVEL_DEFAULT 91

+#define LOGPLCHAN(lchan, ss, lvl, fmt, args...) LOGP(ss, lvl, "%s " fmt, 
gsm_lchan_name(lchan), ## args)
+
 struct gsm_network {
struct llist_head bts_list;
unsigned int num_bts;
diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index cb4a9cc..e9bc560 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -39,9 +39,8 @@

 /*! compute the new MS POWER LEVEL communicated to the MS and store it in 
lchan.
  *  \param lchan logical channel for which to compute (and in whihc to store) 
new power.
- *  \param[in] chan_nr RSL channel number of the channel, only used for 
logging purpose.
  *  \param[in] diff input delta value (in dB) */
-static void ms_power_diff(struct gsm_lchan *lchan, uint8_t chan_nr, int8_t 
diff)
+static void ms_power_diff(struct gsm_lchan *lchan, int8_t diff)
 {
struct gsm_bts_trx *trx = lchan->ts->trx;
enum gsm_band band = trx->bts->band;
@@ -77,20 +76,16 @@
new_power = lchan->ms_power_ctrl.current - MS_RAISE_MAX;

if (lchan->ms_power_ctrl.current == new_power) {
-   LOGP(DLOOP, LOGL_INFO, "Keeping MS new_power of trx=%u "
-   "chan_nr=0x%02x at control level %d (%d dBm)\n",
-   trx->nr, chan_nr, new_power,
-   ms_pwr_dbm(band, new_power));
+   LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Keeping MS new_power at 
control level %d (%d dBm)\n",
+   new_power, ms_pwr_dbm(band, new_power));

return;
}

-   LOGP(DLOOP, LOGL_INFO, "%s MS new_power of trx=%u chan_nr=0x%02x from "
-   "control level %d (%d dBm) to %d (%d dBm)\n",
+   LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "%s MS new_power from control level 
%d (%d dBm) to %d (%d dBm)\n",
(diff > 0) ? "Raising" : "Lowering",
-   trx->nr, chan_nr, lchan->ms_power_ctrl.current,
-   ms_pwr_dbm(band, lchan->ms_power_ctrl.current), new_power,
-   ms_pwr_dbm(band, new_power));
+   lchan->ms_power_ctrl.current, ms_pwr_dbm(band, 
lchan->ms_power_ctrl.current),
+   new_power, ms_pwr_dbm(band, new_power));

/* store the resulting new MS power level in the lchan */
lchan->ms_power_ctrl.current = new_power;
@@ -99,15 +94,16 @@
 }

 /*! Input a new RSSI value into the MS power control loop for the given 
logical channel.
+ *  \param lchan logical channel
  *  \param chan_state L1 channel state of the logical channel.
  *  \param rssi Received Signal Strength Indication (in dBm) */
-static void ms_power_val(struct l1sched_chan_state *chan_state, int8_t rssi)
+static void ms_power_val(struct gsm_lchan *lchan, struct l1sched_chan_state 
*chan_state, int8_t rssi)
 {
/* ignore inserted dummy frames, treat as lost frames */
if (rssi < -127)
return;

-   LOGP(DLOOP, LOGL_DEBUG, "Got RSSI value of %d\n", rssi);
+   LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG, "Got RSSI value of %d\n", rssi);

chan_state->meas.rssi_count++;

@@ -122,10 +118,8 @@
 }

 /*! Process a single clock tick of the MS power control loop.
- *  \param lchan Logical channel to which the clock tick applies
- *  \param[in] chan_nr RSL channel number (for logging purpose) */
-static void ms_power_clock(struct gsm_lchan *lchan,
-   uint8_t chan_nr, struct l1sched_chan_state *chan_state)
+ *  \param lchan Logical channel to which the clock tick applies */
+static void ms_power_clock(struct gsm_lchan *lchan, struct l1sched_chan_state 
*chan_state)
 {
struct gsm_bts_trx *trx = lchan->ts->trx;
struct phy_instance *pinst = trx_phy_instance(trx);
@@ -137,7 +131,7 @@

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Make code control flow more readable

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12290


Change subject: osmo-bts-trx/loops.c: Make code control flow more readable
..

osmo-bts-trx/loops.c: Make code control flow more readable

Use the 'else' construct where applicable to avoid too many return paths
from functions

Change-Id: I819f0c80e90855e8b3252795c837f8e3053b6e87
Related: OS#1622, OS#1851
---
M src/osmo-bts-trx/loops.c
1 file changed, 9 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/12290/1

diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index e9bc560..a0b979a 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -78,19 +78,15 @@
if (lchan->ms_power_ctrl.current == new_power) {
LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Keeping MS new_power at 
control level %d (%d dBm)\n",
new_power, ms_pwr_dbm(band, new_power));
+   } else {
+   LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "%s MS new_power from 
control level %d (%d dBm) to %d (%d dBm)\n",
+   (diff > 0) ? "Raising" : "Lowering",
+   lchan->ms_power_ctrl.current, ms_pwr_dbm(band, 
lchan->ms_power_ctrl.current),
+   new_power, ms_pwr_dbm(band, new_power));

-   return;
+   /* store the resulting new MS power level in the lchan */
+   lchan->ms_power_ctrl.current = new_power;
}
-
-   LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "%s MS new_power from control level 
%d (%d dBm) to %d (%d dBm)\n",
-   (diff > 0) ? "Raising" : "Lowering",
-   lchan->ms_power_ctrl.current, ms_pwr_dbm(band, 
lchan->ms_power_ctrl.current),
-   new_power, ms_pwr_dbm(band, new_power));
-
-   /* store the resulting new MS power level in the lchan */
-   lchan->ms_power_ctrl.current = new_power;
-
-   return;
 }

 /*! Input a new RSSI value into the MS power control loop for the given 
logical channel.
@@ -110,8 +106,7 @@
chan_state->meas.rssi_got_burst = 1;

/* store and process RSSI */
-   if (chan_state->meas.rssi_valid_count
-   == ARRAY_SIZE(chan_state->meas.rssi))
+   if (chan_state->meas.rssi_valid_count == 
ARRAY_SIZE(chan_state->meas.rssi))
return;
chan_state->meas.rssi[chan_state->meas.rssi_valid_count++] = rssi;
chan_state->meas.rssi_valid_count++;
@@ -293,11 +288,7 @@
chan_state->dl_cmr - 1);
chan_state->dl_cmr--;
}
-   return;
-   }
-
-   /* upgrade */
-   if (chan_state->dl_cmr < chan_state->codecs - 1) {
+   } else if (chan_state->dl_cmr < chan_state->codecs - 1) {
/* degrade, if ber is above threshold  FIXME: C/I*/
if (ber <
lchan->tch.amr_mr.bts_mode[chan_state->dl_cmr].threshold
@@ -307,8 +298,6 @@
chan_state->dl_cmr + 1);
chan_state->dl_cmr++;
}
-
-   return;
}
 }


--
To view, visit https://gerrit.osmocom.org/12290
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I819f0c80e90855e8b3252795c837f8e3053b6e87
Gerrit-Change-Number: 12290
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bts[master]: osmo-bts-trx/loops.[ch]: Make functions "void" if they always return 0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12288


Change subject: osmo-bts-trx/loops.[ch]: Make functions "void" if they always 
return 0
..

osmo-bts-trx/loops.[ch]: Make functions "void" if they always return 0

The concept of a return value only makes sense if there's actually ever
something non-constant to return, and if the caller actually processes
that return value.  If we always "return 0" and ignore it on the caller
side, functions should be of "void" type.

Change-Id: I3575a2cef75f3fd4c3f95eddb40719d28a055b54
Related: OS#1622, OS#1851
---
M src/osmo-bts-trx/loops.c
M src/osmo-bts-trx/loops.h
2 files changed, 35 insertions(+), 54 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/12288/1

diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index cca2417..cb4a9cc 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -40,9 +40,8 @@
 /*! compute the new MS POWER LEVEL communicated to the MS and store it in 
lchan.
  *  \param lchan logical channel for which to compute (and in whihc to store) 
new power.
  *  \param[in] chan_nr RSL channel number of the channel, only used for 
logging purpose.
- *  \param[in] diff input delta value (in dB)
- *  \returns 0 in all cases */
-static int ms_power_diff(struct gsm_lchan *lchan, uint8_t chan_nr, int8_t diff)
+ *  \param[in] diff input delta value (in dB) */
+static void ms_power_diff(struct gsm_lchan *lchan, uint8_t chan_nr, int8_t 
diff)
 {
struct gsm_bts_trx *trx = lchan->ts->trx;
enum gsm_band band = trx->bts->band;
@@ -53,7 +52,7 @@
new_power = lchan->ms_power_ctrl.current - (diff >> 1);

if (diff == 0)
-   return 0;
+   return;

/* ms transmit power level cannot become negative */
if (new_power < 0)
@@ -83,7 +82,7 @@
trx->nr, chan_nr, new_power,
ms_pwr_dbm(band, new_power));

-   return 0;
+   return;
}

LOGP(DLOOP, LOGL_INFO, "%s MS new_power of trx=%u chan_nr=0x%02x from "
@@ -96,18 +95,17 @@
/* store the resulting new MS power level in the lchan */
lchan->ms_power_ctrl.current = new_power;

-   return 0;
+   return;
 }

 /*! Input a new RSSI value into the MS power control loop for the given 
logical channel.
  *  \param chan_state L1 channel state of the logical channel.
- *  \param rssi Received Signal Strength Indication (in dBm)
- *  \return 0 in all cases */
-static int ms_power_val(struct l1sched_chan_state *chan_state, int8_t rssi)
+ *  \param rssi Received Signal Strength Indication (in dBm) */
+static void ms_power_val(struct l1sched_chan_state *chan_state, int8_t rssi)
 {
/* ignore inserted dummy frames, treat as lost frames */
if (rssi < -127)
-   return 0;
+   return;

LOGP(DLOOP, LOGL_DEBUG, "Got RSSI value of %d\n", rssi);

@@ -118,18 +116,15 @@
/* store and process RSSI */
if (chan_state->meas.rssi_valid_count
== ARRAY_SIZE(chan_state->meas.rssi))
-   return 0;
+   return;
chan_state->meas.rssi[chan_state->meas.rssi_valid_count++] = rssi;
chan_state->meas.rssi_valid_count++;
-
-   return 0;
 }

 /*! Process a single clock tick of the MS power control loop.
  *  \param lchan Logical channel to which the clock tick applies
- *  \param[in] chan_nr RSL channel number (for logging purpose)
- *  \returns 0 in all cases */
-static int ms_power_clock(struct gsm_lchan *lchan,
+ *  \param[in] chan_nr RSL channel number (for logging purpose) */
+static void ms_power_clock(struct gsm_lchan *lchan,
uint8_t chan_nr, struct l1sched_chan_state *chan_state)
 {
struct gsm_bts_trx *trx = lchan->ts->trx;
@@ -140,21 +135,22 @@
/* skip every second clock, to prevent oscillating due to roundtrip
 * delay */
if (!(chan_state->meas.clock & 1))
-   return 0;
+   return;

LOGP(DLOOP, LOGL_DEBUG, "Got SACCH master clock at RSSI count %d\n",
chan_state->meas.rssi_count);

/* wait for initial burst */
if (!chan_state->meas.rssi_got_burst)
-   return 0;
+   return;

/* if no burst was received from MS at clock */
if (chan_state->meas.rssi_count == 0) {
LOGP(DLOOP, LOGL_NOTICE, "LOST SACCH frame of trx=%u "
"chan_nr=0x%02x, so we raise MS power\n",
trx->nr, chan_nr);
-   return ms_power_diff(lchan, chan_nr, MS_RAISE_MAX);
+   ms_power_diff(lchan, chan_nr, MS_RAISE_MAX);
+   return;
}

/* reset total counter */
@@ -163,7 +159,7 @@
/* check the minimum level received after MS acknowledged the ordered
 * 

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Add comments documenting TA + MS power control ...

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12287


Change subject: osmo-bts-trx/loops.c: Add comments documenting TA + MS power 
control loop
..

osmo-bts-trx/loops.c: Add comments documenting TA + MS power control loop

The loops.c code is not very easily understood, so let's add some
comments to it.

As can be seen, there are functions of integer type which always return
0, and whose callers don't check for the return value.  This will be
adressed in subsequent patches.

Change-Id: Iafea07eb751ed85d29b214576bb0d31ea919cd72
Related: OS#1622, OS#1851
---
M src/osmo-bts-trx/loops.c
1 file changed, 30 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/12287/1

diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index 926b4c6..cca2417 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -37,6 +37,11 @@
  * MS Power loop
  */

+/*! compute the new MS POWER LEVEL communicated to the MS and store it in 
lchan.
+ *  \param lchan logical channel for which to compute (and in whihc to store) 
new power.
+ *  \param[in] chan_nr RSL channel number of the channel, only used for 
logging purpose.
+ *  \param[in] diff input delta value (in dB)
+ *  \returns 0 in all cases */
 static int ms_power_diff(struct gsm_lchan *lchan, uint8_t chan_nr, int8_t diff)
 {
struct gsm_bts_trx *trx = lchan->ts->trx;
@@ -44,14 +49,17 @@
uint16_t arfcn = trx->arfcn;
int8_t new_power;

+   /* compute new target MS output power level based on current value 
subtracted by 'diff/2' */
new_power = lchan->ms_power_ctrl.current - (diff >> 1);

if (diff == 0)
return 0;

+   /* ms transmit power level cannot become negative */
if (new_power < 0)
new_power = 0;

+   /* saturate at the maximum possible power level for the given band */
// FIXME: to go above 1W, we need to know classmark of MS
if (arfcn >= 512 && arfcn <= 885) {
if (new_power > 15)
@@ -61,6 +69,8 @@
new_power = 19;
}

+   /* don't ever change more than MS_{LOWER,RAISE}_MAX during one loop 
iteration, i.e.
+* reduce the speed at which the MS transmit power can change */
/* a higher value means a lower level (and vice versa) */
if (new_power > lchan->ms_power_ctrl.current + MS_LOWER_MAX)
new_power = lchan->ms_power_ctrl.current + MS_LOWER_MAX;
@@ -83,11 +93,16 @@
ms_pwr_dbm(band, lchan->ms_power_ctrl.current), new_power,
ms_pwr_dbm(band, new_power));

+   /* store the resulting new MS power level in the lchan */
lchan->ms_power_ctrl.current = new_power;

return 0;
 }

+/*! Input a new RSSI value into the MS power control loop for the given 
logical channel.
+ *  \param chan_state L1 channel state of the logical channel.
+ *  \param rssi Received Signal Strength Indication (in dBm)
+ *  \return 0 in all cases */
 static int ms_power_val(struct l1sched_chan_state *chan_state, int8_t rssi)
 {
/* ignore inserted dummy frames, treat as lost frames */
@@ -110,6 +125,10 @@
return 0;
 }

+/*! Process a single clock tick of the MS power control loop.
+ *  \param lchan Logical channel to which the clock tick applies
+ *  \param[in] chan_nr RSL channel number (for logging purpose)
+ *  \returns 0 in all cases */
 static int ms_power_clock(struct gsm_lchan *lchan,
uint8_t chan_nr, struct l1sched_chan_state *chan_state)
 {
@@ -213,6 +232,14 @@
return 0;
 }

+/*! Process a SACCH event as input to the MS power control and TA loop.  
Function
+ *  is called once every uplink SACCH block is received.
+ * \param l1t L1 TRX instance on which we operate
+ * \param chan_nr RSL channel number on which we operate
+ * \param chan_state L1 scheduler channel state of the channel on which we 
operate
+ * \param[in] rssi Receive Signal Strength Indication
+ * \param[in] toa256 Time of Arrival in 1/256 symbol periods
+ * \returns 0 in all cases */
 int trx_loop_sacch_input(struct l1sched_trx *l1t, uint8_t chan_nr,
struct l1sched_chan_state *chan_state, int8_t rssi, int16_t toa256)
 {
@@ -220,15 +247,18 @@
.lchan[l1sap_chan2ss(chan_nr)];
struct phy_instance *pinst = trx_phy_instance(l1t->trx);

+   /* if MS power control loop is enabled, handle it */
if (pinst->phy_link->u.osmotrx.trx_ms_power_loop)
ms_power_val(chan_state, rssi);

+   /* if TA loop is enabled, handle it */
if (pinst->phy_link->u.osmotrx.trx_ta_loop)
ta_val(lchan, chan_nr, chan_state, toa256);
 
return 0;
 }

+/*! Called once every downlink SACCH block needs to be sent. */
 int trx_loop_sacch_clock(struct l1sched_trx *l1t, uint8_t chan_nr,
struct 

Re: build slave segfaults

[Harald Welte]

On Wed, Dec 12, 2018 at 05:10:17PM +0100, Neels Hofmeyr wrote:
> On Wed, Dec 12, 2018 at 01:26:45PM +0100, Pau Espin Pedrol wrote:
> > on the virtualization layer being used by OBS to run containers.
> 
> This is our own jenkins build slave, not an OBS package builder.

might be useful to look at whether it happens on one particular build slave
only, or on multiple/all. If it's only one particular machine, then very clearly
that machine is likely broken.

-- 
- Harald Weltehttp://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11827 )

Change subject: LCLS, TS 29.205: add GCR routines
..


Patch Set 24: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 24
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 20:58:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MSC_Tests: remove unused control interface

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11690 )

Change subject: MSC_Tests: remove unused control interface
..


Patch Set 8: Code-Review-1

> (1 comment)
 >
 > > I mean, it would be nicer to allow having a ctrl for both sides,
 > > but if it fixes the status quo, this patch is ok, right?
 >
 > Making the control interface available from both sides requires an
 > additional architecture to route the message back and forth between
 > the two entities.

I'm not sure I'm following you here.  Why would two components not be
able to each independently talk to the CTRL interface?  Where exactly
is the problem here?  Where is what kind of "architecture" needed?

 > The patch does not break anything, also having the control
 > interface available at the BSC_ConnectionHandler makes more sense
 > than having it on the MTC_CT.

For your particular use case right now, this may be true.  For other use cases, 
it is different.  I put it there intentionally at a time.  As other test suites 
also show, for some tests it makes sense to access CTRL or VTY from the main 
test component,and for others from the respective *Handler.  There's no one 
truth here.


--
To view, visit https://gerrit.osmocom.org/11690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I204b2e96057d13342f4bd4fdaf08fb7b88b6b11d
Gerrit-Change-Number: 11690
Gerrit-PatchSet: 8
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 12 Dec 2018 20:57:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12237 )

Change subject: MGCP: fix pattern warning
..


Patch Set 2: Code-Review-1

I wouldn't dare to touch those regexes without first implementing thorough 
unit/selftests.  And as nobody has time to invest in implementing said tests 
only to remove a warning from the compile process: Let it be.


--
To view, visit https://gerrit.osmocom.org/12237
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 12 Dec 2018 20:54:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c@40
PS1, Line 40: #define VERIFY(msg, data, len)
\
> This one can be dropped then right?
I would rather change this to:

  #define VERIFY(msg, data) \
if (!msgb_eq_l3_data_print(msg, data, ARRAY_SIZE(data))) \
  abort();



--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 12 Dec 2018 20:41:55 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12286


Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
---
M Makefile.am
M configure.ac
A contrib/Makefile.am
A contrib/systemd/Makefile.am
A contrib/systemd/osmo-sysmon.service
5 files changed, 41 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/86/12286/1

diff --git a/Makefile.am b/Makefile.am
index a838715..6018753 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,3 +1,6 @@
-SUBDIRS = doc src
+SUBDIRS = contrib doc src

 ACLOCAL_AMFLAGS = -I m4
+
+AM_DISTCHECK_CONFIGURE_FLAGS = \
+   --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
diff --git a/configure.ac b/configure.ac
index 734ac99..ba44f98 100644
--- a/configure.ac
+++ b/configure.ac
@@ -120,6 +120,23 @@
CPPFLAGS="$CPPFLAGS -pg"
 fi

+# https://www.freedesktop.org/software/systemd/man/daemon.html
+PKG_PROG_PKG_CONFIG
+AC_ARG_WITH([systemdsystemunitdir],
+ [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
+ [with_systemdsystemunitdir=auto])
+AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
+ def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
+
+ AS_IF([test "x$def_systemdsystemunitdir" = "x"],
+   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
+[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
+with_systemdsystemunitdir=no],
+   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
+AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
+  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
+AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
+
 AC_MSG_RESULT([CFLAGS="$CFLAGS"])
 AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])

@@ -127,6 +144,8 @@
 AM_CONFIG_HEADER(config.h)

 AC_OUTPUT(
+contrib/Makefile
+contrib/systemd/Makefile
 doc/Makefile
 doc/examples/Makefile
 src/Makefile
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
new file mode 100644
index 000..3439c97
--- /dev/null
+++ b/contrib/Makefile.am
@@ -0,0 +1 @@
+SUBDIRS = systemd
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
new file mode 100644
index 000..10b28d9
--- /dev/null
+++ b/contrib/systemd/Makefile.am
@@ -0,0 +1,6 @@
+EXTRA_DIST = osmo-sysmon.service
+
+if HAVE_SYSTEMD
+systemdsystemunit_DATA = \
+osmo-sysmon.service
+endif
diff --git a/contrib/systemd/osmo-sysmon.service 
b/contrib/systemd/osmo-sysmon.service
new file mode 100644
index 000..50d6639
--- /dev/null
+++ b/contrib/systemd/osmo-sysmon.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Osmocom System Monitoring daemon
+
+[Service]
+Type=simple
+Restart=always
+ExecStart=/usr/bin/osmo-sysmon -c /etc/osmocom/osmo-sysmon.cfg
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target

--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-sysmon[master]: Add cmdline option parsing support

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12285


Change subject: Add cmdline option parsing support
..

Add cmdline option parsing support

Change-Id: I742974bd1440b09b49d26703c13361dd1c41008b
---
M src/osysmon_main.c
1 file changed, 95 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/85/12285/1

diff --git a/src/osysmon_main.c b/src/osysmon_main.c
index 5983212..486ee8f 100644
--- a/src/osysmon_main.c
+++ b/src/osysmon_main.c
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 

 #include "config.h"
 #include "osysmon.h"
@@ -69,8 +70,6 @@
.is_config_node = osysmon_is_config_node,
 };

-
-static const char *config_file = "osmo-sysmon.cfg";
 struct osysmon_state *g_oss;


@@ -110,6 +109,88 @@
}
 }

+static void print_usage()
+{
+   printf("Usage: osmo-sysmon\n");
+}
+
+static void print_help()
+{
+   printf("  -h --help  This text.\n");
+   printf("  -c --config-file filename  The config file to use.\n");
+   printf("  -d option --debug=DRLL:DCC:DMM:DRR:DRSL:DNM  Enable 
debugging.\n");
+   printf("  -D --daemonize Fork the process into a background 
daemon.\n");
+   printf("  -s --disable-color Do not print ANSI colors in the 
log\n");
+   printf("  -T --timestamp Prefix every log line with a 
timestamp.\n");
+   printf("  -e --log-level number  Set a global loglevel.\n");
+   printf("  -V --version   Print the version of OsmoHLR.\n");
+}
+
+static struct {
+   const char *config_file;
+   bool daemonize;
+} cmdline_opts = {
+   .config_file = "osmo-sysmon.cfg",
+   .daemonize = false,
+};
+
+static void handle_options(int argc, char **argv)
+{
+   while (1) {
+   int option_index = 0, c;
+   static struct option long_options[] = {
+   {"help", 0, 0, 'h'},
+   {"config-file", 1, 0, 'c'},
+   {"debug", 1, 0, 'd'},
+   {"daemonize", 0, 0, 'D'},
+   {"disable-color", 0, 0, 's'},
+   {"log-level", 1, 0, 'e'},
+   {"timestamp", 0, 0, 'T'},
+   {"version", 0, 0, 'V' },
+   {0, 0, 0, 0}
+   };
+
+   c = getopt_long(argc, argv, "hc:d:Dse:TV",
+   long_options, _index);
+   if (c == -1)
+   break;
+
+   switch (c) {
+   case 'h':
+   print_usage();
+   print_help();
+   exit(0);
+   case 'c':
+   cmdline_opts.config_file = optarg;
+   break;
+   case 'd':
+   log_parse_category_mask(osmo_stderr_target, optarg);
+   break;
+   case 'D':
+   cmdline_opts.daemonize = 1;
+   break;
+   case 's':
+   log_set_use_color(osmo_stderr_target, 0);
+   break;
+   case 'e':
+   log_set_log_level(osmo_stderr_target, atoi(optarg));
+   break;
+   case 'T':
+   log_set_print_timestamp(osmo_stderr_target, 1);
+   break;
+   case 'V':
+   print_version(1);
+   exit(0);
+   break;
+   default:
+   /* catch unknown options *as well as* missing 
arguments. */
+   fprintf(stderr, "Error in command line options. 
Exiting.\n");
+   exit(-1);
+   break;
+   }
+   }
+}
+
 int main(int argc, char **argv)
 {
int rc;
@@ -122,14 +203,16 @@
INIT_LLIST_HEAD(_oss->files);

vty_init(_info);
+   handle_options(argc, argv);
osysmon_sysinfo_init();
osysmon_ctrl_init();
osysmon_rtnl_init();
osysmon_file_init();

-   rc = vty_read_config_file(config_file, NULL);
+   rc = vty_read_config_file(cmdline_opts.config_file, NULL);
if (rc < 0) {
-   fprintf(stderr, "Failed to parse the config file %s\n", 
config_file);
+   fprintf(stderr, "Failed to parse the config file %s\n",
+   cmdline_opts.config_file);
exit(2);
}

@@ -137,6 +220,14 @@
signal(SIGUSR2, _handler);
osmo_init_ignore_signals();

+   if (cmdline_opts.daemonize) {
+   rc = osmo_daemonize();
+   if (rc < 0) {
+   perror("Error during daemonize");
+   exit(1);
+   }
+   }
+
while (1) {

Change in osmo-sysmon[master]: Move source code to src subdir

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12284


Change subject: Move source code to src subdir
..

Move source code to src subdir

Change-Id: I1aa2893e2b274f8d087a0d2f126486cd4afcbdfe
---
M Makefile.am
M configure.ac
A src/Makefile.am
R src/osmo-ctrl-client.c
R src/osysmon.h
R src/osysmon_ctrl.c
R src/osysmon_file.c
R src/osysmon_main.c
R src/osysmon_rtnl.c
R src/osysmon_sysinfo.c
R src/simple_ctrl.c
R src/simple_ctrl.h
R src/value_node.c
R src/value_node.h
14 files changed, 56 insertions(+), 56 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/84/12284/1

diff --git a/Makefile.am b/Makefile.am
index cdf67bf..a838715 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,58 +1,3 @@
-SUBDIRS = doc
+SUBDIRS = doc src

 ACLOCAL_AMFLAGS = -I m4
-
-AM_CPPFLAGS = \
-   $(all_includes) \
-   -I$(top_srcdir) \
-   $(NULL)
-
-AM_CFLAGS = \
-   -Wall \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOVTY_CFLAGS) \
-   $(LIBMNL_CFLAGS) \
-   $(NULL)
-
-AM_LDFLAGS = \
-   $(COVERAGE_LDFLAGS) \
-   $(NULL)
-
-bin_PROGRAMS = \
-   osmo-sysmon \
-   osmo-ctrl-client \
-   $(NULL)
-
-osmo_sysmon_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(LIBOSMOVTY_LIBS) \
-   $(LIBMNL_LIBS) \
-   $(NULL)
-
-osmo_sysmon_SOURCES = \
-   value_node.c \
-   simple_ctrl.c \
-   osysmon_ctrl.c \
-   osysmon_sysinfo.c \
-   osysmon_rtnl.c \
-   osysmon_file.c \
-   osysmon_main.c \
-   $(NULL)
-
-osmo_ctrl_client_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(NULL)
-
-osmo_ctrl_client_SOURCES = \
-   simple_ctrl.c \
-   osmo-ctrl-client.c \
-   $(NULL)
-
-noinst_HEADERS = \
-   osysmon.h \
-   simple_ctrl.h \
-   value_node.h \
-   $(NULL)
diff --git a/configure.ac b/configure.ac
index 13082b7..734ac99 100644
--- a/configure.ac
+++ b/configure.ac
@@ -129,4 +129,5 @@
 AC_OUTPUT(
 doc/Makefile
 doc/examples/Makefile
+src/Makefile
 Makefile)
diff --git a/src/Makefile.am b/src/Makefile.am
new file mode 100644
index 000..9ad5947
--- /dev/null
+++ b/src/Makefile.am
@@ -0,0 +1,54 @@
+AM_CPPFLAGS = \
+   $(all_includes) \
+   -I$(top_srcdir) \
+   $(NULL)
+
+AM_CFLAGS = \
+   -Wall \
+   $(LIBOSMOCORE_CFLAGS) \
+   $(LIBOSMOGSM_CFLAGS) \
+   $(LIBOSMOVTY_CFLAGS) \
+   $(LIBMNL_CFLAGS) \
+   $(NULL)
+
+AM_LDFLAGS = \
+   $(COVERAGE_LDFLAGS) \
+   $(NULL)
+
+bin_PROGRAMS = \
+   osmo-sysmon \
+   osmo-ctrl-client \
+   $(NULL)
+
+osmo_sysmon_LDADD = \
+   $(LIBOSMOCORE_LIBS) \
+   $(LIBOSMOGSM_LIBS) \
+   $(LIBOSMOVTY_LIBS) \
+   $(LIBMNL_LIBS) \
+   $(NULL)
+
+osmo_sysmon_SOURCES = \
+   value_node.c \
+   simple_ctrl.c \
+   osysmon_ctrl.c \
+   osysmon_sysinfo.c \
+   osysmon_rtnl.c \
+   osysmon_file.c \
+   osysmon_main.c \
+   $(NULL)
+
+osmo_ctrl_client_LDADD = \
+   $(LIBOSMOCORE_LIBS) \
+   $(LIBOSMOGSM_LIBS) \
+   $(NULL)
+
+osmo_ctrl_client_SOURCES = \
+   simple_ctrl.c \
+   osmo-ctrl-client.c \
+   $(NULL)
+
+noinst_HEADERS = \
+   osysmon.h \
+   simple_ctrl.h \
+   value_node.h \
+   $(NULL)
diff --git a/osmo-ctrl-client.c b/src/osmo-ctrl-client.c
similarity index 100%
rename from osmo-ctrl-client.c
rename to src/osmo-ctrl-client.c
diff --git a/osysmon.h b/src/osysmon.h
similarity index 100%
rename from osysmon.h
rename to src/osysmon.h
diff --git a/osysmon_ctrl.c b/src/osysmon_ctrl.c
similarity index 100%
rename from osysmon_ctrl.c
rename to src/osysmon_ctrl.c
diff --git a/osysmon_file.c b/src/osysmon_file.c
similarity index 100%
rename from osysmon_file.c
rename to src/osysmon_file.c
diff --git a/osysmon_main.c b/src/osysmon_main.c
similarity index 100%
rename from osysmon_main.c
rename to src/osysmon_main.c
diff --git a/osysmon_rtnl.c b/src/osysmon_rtnl.c
similarity index 100%
rename from osysmon_rtnl.c
rename to src/osysmon_rtnl.c
diff --git a/osysmon_sysinfo.c b/src/osysmon_sysinfo.c
similarity index 100%
rename from osysmon_sysinfo.c
rename to src/osysmon_sysinfo.c
diff --git a/simple_ctrl.c b/src/simple_ctrl.c
similarity index 100%
rename from simple_ctrl.c
rename to src/simple_ctrl.c
diff --git a/simple_ctrl.h b/src/simple_ctrl.h
similarity index 100%
rename from simple_ctrl.h
rename to src/simple_ctrl.h
diff --git a/value_node.c b/src/value_node.c
similarity index 100%
rename from value_node.c
rename to src/value_node.c
diff --git a/value_node.h b/src/value_node.h
similarity index 100%
rename from value_node.h
rename to src/value_node.h

--
To view, visit https://gerrit.osmocom.org/12284
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: 

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
..


Patch Set 1:

> Patch Set 1: Code-Review+2
>
> I don't agree, I don't like leaving a define dangling in a commit, but 
> anyway, not that important.

So far I haven't found a way to make this cleanup with spatch as well 
unfortunately and I'd rather have 2 separate patches than mix up manual and 
autogenerated changes.


--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 18:10:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sysmon[master]: Add m4 missing files to fix build

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12283


Change subject: Add m4 missing files to fix build
..

Add m4 missing files to fix build

Same files are available in other osmocom projects, otherwise configure
fails with "Please install autoconf-archive; re-run 'autoreconf -fi' for
it to take effect.".

Change-Id: Iabe3207fff8f076a3f4ddc81720bb7fdc671a46c
---
M Makefile.am
A m4/README
A m4/ax_check_compile_flag.m4
3 files changed, 79 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/83/12283/1

diff --git a/Makefile.am b/Makefile.am
index 5eb1cfb..cdf67bf 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,5 +1,7 @@
 SUBDIRS = doc

+ACLOCAL_AMFLAGS = -I m4
+
 AM_CPPFLAGS = \
$(all_includes) \
-I$(top_srcdir) \
diff --git a/m4/README b/m4/README
new file mode 100644
index 000..92eb30b
--- /dev/null
+++ b/m4/README
@@ -0,0 +1,3 @@
+We want to avoid creating too many external build-time dependencies
+like this one to autoconf-archive.  This directory provides a local
+copy of required m4 rules.
diff --git a/m4/ax_check_compile_flag.m4 b/m4/ax_check_compile_flag.m4
new file mode 100644
index 000..ca36397
--- /dev/null
+++ b/m4/ax_check_compile_flag.m4
@@ -0,0 +1,74 @@
+# ===
+#   http://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html
+# ===
+#
+# SYNOPSIS
+#
+#   AX_CHECK_COMPILE_FLAG(FLAG, [ACTION-SUCCESS], [ACTION-FAILURE], 
[EXTRA-FLAGS], [INPUT])
+#
+# DESCRIPTION
+#
+#   Check whether the given FLAG works with the current language's compiler
+#   or gives an error.  (Warnings, however, are ignored)
+#
+#   ACTION-SUCCESS/ACTION-FAILURE are shell commands to execute on
+#   success/failure.
+#
+#   If EXTRA-FLAGS is defined, it is added to the current language's default
+#   flags (e.g. CFLAGS) when the check is done.  The check is thus made with
+#   the flags: "CFLAGS EXTRA-FLAGS FLAG".  This can for example be used to
+#   force the compiler to issue an error when a bad flag is given.
+#
+#   INPUT gives an alternative input source to AC_COMPILE_IFELSE.
+#
+#   NOTE: Implementation based on AX_CFLAGS_GCC_OPTION. Please keep this
+#   macro in sync with AX_CHECK_{PREPROC,LINK}_FLAG.
+#
+# LICENSE
+#
+#   Copyright (c) 2008 Guido U. Draheim 
+#   Copyright (c) 2011 Maarten Bosmans 
+#
+#   This program is free software: you can redistribute it and/or modify it
+#   under the terms of the GNU General Public License as published by the
+#   Free Software Foundation, either version 3 of the License, or (at your
+#   option) any later version.
+#
+#   This program is distributed in the hope that it will be useful, but
+#   WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
+#   Public License for more details.
+#
+#   You should have received a copy of the GNU General Public License along
+#   with this program. If not, see .
+#
+#   As a special exception, the respective Autoconf Macro's copyright owner
+#   gives unlimited permission to copy, distribute and modify the configure
+#   scripts that are the output of Autoconf when processing the Macro. You
+#   need not follow the terms of the GNU General Public License when using
+#   or distributing such scripts, even though portions of the text of the
+#   Macro appear in them. The GNU General Public License (GPL) does govern
+#   all other use of the material that constitutes the Autoconf Macro.
+#
+#   This special exception to the GPL applies to versions of the Autoconf
+#   Macro released by the Autoconf Archive. When you make and distribute a
+#   modified version of the Autoconf Macro, you may extend this special
+#   exception to the GPL to apply to your modified version as well.
+
+#serial 4
+
+AC_DEFUN([AX_CHECK_COMPILE_FLAG],
+[AC_PREREQ(2.64)dnl for _AC_LANG_PREFIX and AS_VAR_IF
+AS_VAR_PUSHDEF([CACHEVAR],[ax_cv_check_[]_AC_LANG_ABBREV[]flags_$4_$1])dnl
+AC_CACHE_CHECK([whether _AC_LANG compiler accepts $1], CACHEVAR, [
+  ax_check_save_flags=$[]_AC_LANG_PREFIX[]FLAGS
+  _AC_LANG_PREFIX[]FLAGS="$[]_AC_LANG_PREFIX[]FLAGS $4 $1"
+  AC_COMPILE_IFELSE([m4_default([$5],[AC_LANG_PROGRAM()])],
+[AS_VAR_SET(CACHEVAR,[yes])],
+[AS_VAR_SET(CACHEVAR,[no])])
+  _AC_LANG_PREFIX[]FLAGS=$ax_check_save_flags])
+AS_VAR_IF(CACHEVAR,yes,
+  [m4_default([$2], :)],
+  [m4_default([$3], :)])
+AS_VAR_POPDEF([CACHEVAR])dnl
+])dnl AX_CHECK_COMPILE_FLAGS

-- 
To view, visit https://gerrit.osmocom.org/12283
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: 

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 2:

> Let me try again:
 >
 > Assume this name is used by active GSUP connections. If this name
 > is changed via VTY, what should happen to those active connections?
 > Should those connections be left as they are? Should they be
 > replaced with new connections which use the new name? I don't think
 > there is a trivial answer, is there?
 >
 > I believe the easiest answer is that changing this name should
 > require a restart of osmo-sgsn (and likewise osmo-msc).
 >

They can be left as they are I guess. You can try re-establishing them in the 
patch if you see it's easy to do so with current code base.
I think it's fine requiring the user to re-start the process for the change to 
take effect, I was just pointing out that independent of that topic, there 
should be a "no foobar" for the reason I introduced.


 > If there was a way to mark a VTY option such that it can only be
 > set while the configuration file is being loaded, and not via a
 > run-time VTY shell, then this option would be a good candidate for
 > such treatment.

Agree, that would be handy in general.
You could otherwise check if the link towards the HLR is ON when the VTY 
command is run, and if  that's the case, print warning stating it won't be 
applied until it is reconnected. But still save the new value in order to be 
able to save the changed config if the user desires to do so.


--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:54:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 )

Change subject: remove pointless declaration of struct gsm_network
..


Patch Set 2:

Good, but now commit message require adjustment as well :)


--
To view, visit https://gerrit.osmocom.org/12242
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759
Gerrit-Change-Number: 12242
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:46:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 2:

I forgot one important point: There are routes which refer to this name in 
other components of the network, such as the HLR. What needs to happen to those 
routes when the name is changed? Do we even have the means to synchronize such 
changes across several active GSUP speakers?


--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:42:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 2:

> Patch Set 2: Code-Review-1
>
> Some people may want to use "no foobar" and then safe config to file. If you 
> don't add the "no foobar" one and it's enabled, it's not possible to disable 
> it and save the cfg.

I don't understand this response. You're not answering my question.

Let me try again:

Assume this name is used by active GSUP connections. If this name is changed 
via VTY, what should happen to those active connections?
Should those connections be left as they are? Should they be replaced with new 
connections which use the new name? I don't think there is a trivial answer, is 
there?

I believe the easiest answer is that changing this name should require a 
restart of osmo-sgsn (and likewise osmo-msc).

If there was a way to mark a VTY option such that it can only be set while the 
configuration file is being loaded, and not via a run-time VTY shell, then this 
option would be a good candidate for such treatment.


--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:35:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 2: Code-Review-1

Some people may want to use "no foobar" and then safe config to file. If you 
don't add the "no foobar" one and it's enabled, it's not possible to disable it 
and save the cfg.


--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:09:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Timeval: Move to osmo_clock_gettime

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12281


Change subject: Timeval: Move to osmo_clock_gettime
..

Timeval: Move to osmo_clock_gettime

Change-Id: I24da3e1136c5396062662be1d10b07b4d97cfc2e
---
M CommonLibs/Timeval.cpp
M CommonLibs/Timeval.h
2 files changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/81/12281/1

diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp
index 21072fc..fd1bcda 100644
--- a/CommonLibs/Timeval.cpp
+++ b/CommonLibs/Timeval.cpp
@@ -27,8 +27,17 @@

 #include "Timeval.h"

+extern "C" {
+#include 
+}
+
 using namespace std;

+void Timeval::now()
+{
+   osmo_clock_gettime(CLOCK_REALTIME, );
+}
+
 void Timeval::future(unsigned offset)
 {
now();
diff --git a/CommonLibs/Timeval.h b/CommonLibs/Timeval.h
index b780af1..7c6a6f6 100644
--- a/CommonLibs/Timeval.h
+++ b/CommonLibs/Timeval.h
@@ -47,7 +47,7 @@
public:

/** Set the value to current time. */
-   void now() { clock_gettime(CLOCK_REALTIME, ); }
+   void now();

/** Set the value to gettimeofday plus an offset. */
void future(unsigned ms);

--
To view, visit https://gerrit.osmocom.org/12281
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24da3e1136c5396062662be1d10b07b4d97cfc2e
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12245 )

Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12245/4/tests/Transceiver52M/Makefile.am
File tests/Transceiver52M/Makefile.am:

https://gerrit.osmocom.org/#/c/12245/4/tests/Transceiver52M/Makefile.am@25
PS4, Line 25:   $(top_builddir)/Transceiver52M/device/lms/.libs/LMSDevice.o \
Use $(builddir)/device/lms/libdevice.la here

You should add $(LMS_CFLAGS) to LMSDeviceTest_CPPFLAGS, see 
Transceiver52/Makefile.am towards the end of file (DEVICE_LMS).



--
To view, visit https://gerrit.osmocom.org/12245
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852
Gerrit-Change-Number: 12245
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:07:21 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: TimevalTest: Make test deterministic with fake time

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12282


Change subject: TimevalTest: Make test deterministic with fake time
..

TimevalTest: Make test deterministic with fake time

Change-Id: I74e577a0142fb6d1ef3630e02aff9910b191bff9
---
M tests/CommonLibs/TimevalTest.cpp
1 file changed, 18 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/82/12282/1

diff --git a/tests/CommonLibs/TimevalTest.cpp b/tests/CommonLibs/TimevalTest.cpp
index 61a92c9..b822982 100644
--- a/tests/CommonLibs/TimevalTest.cpp
+++ b/tests/CommonLibs/TimevalTest.cpp
@@ -31,34 +31,45 @@
 #include 
 #include 

+extern "C" {
+#include 
+}
+
 using namespace std;

 int main(int argc, char *argv[])
 {
-   long last_remaining = 1;
+
+   osmo_clock_override_enable(CLOCK_REALTIME, true);
+
+   struct timespec *clk = osmo_clock_override_gettimespec(CLOCK_REALTIME);
+   clk->tv_sec = 0;
+   clk->tv_nsec = 1000;
+
+   long last_remaining = 1; /*10 sec */
Timeval then(last_remaining);
assert(then.elapsed() == -last_remaining);
cerr << then << " elapsed: " << then.elapsed() << endl;

/* Check that last_remaining parameter affects setting time in the 
future */
-   usleep(1);
+   osmo_clock_override_add(CLOCK_REALTIME, 0, 10*1000*1000);
double increased_time_secs = Timeval().seconds();
-   assert(increased_time_secs <= then.seconds());
+   assert(increased_time_secs < then.seconds());

struct timespec invariant_time  = then.timespec();
int loops = 0;

while (!then.passed()) {
struct timespec tspecnow = then.timespec();
-   cerr << "now: " << Timeval().seconds() << " then: " << then << 
" remaining: " << then.remaining() << endl;
+   cerr << "["<< loops << "] now: " << Timeval().seconds() << " 
then: " << then << " remaining: " << then.remaining() << endl;
assert(last_remaining >= then.remaining());
assert(tspecnow.tv_sec == invariant_time.tv_sec && 
tspecnow.tv_nsec == invariant_time.tv_nsec);
-   usleep(50);
+   osmo_clock_override_add(CLOCK_REALTIME, 0, 50*1000);
loops++;
}
cerr << "now: " << Timeval() << " then: " << then << " remaining: " << 
then.remaining() << endl;
-   assert(then.remaining() <= 0);
-   assert(loops >= 18);
+   assert(then.remaining() == -10);
+   assert(loops == 20);

printf("Done\n");
 }

--
To view, visit https://gerrit.osmocom.org/12282
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74e577a0142fb6d1ef3630e02aff9910b191bff9
Gerrit-Change-Number: 12282
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-trx[master]: Timeval: Move implementation to use clock_gettime and timespec

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12280


Change subject: Timeval: Move implementation to use clock_gettime and timespec
..

Timeval: Move implementation to use clock_gettime and timespec

According to gettimeofday manual:
"Applications should use the clock_gettime() function instead of the
obsolescent gettimeofday() function."

Furthermore, it may be desirable in the future to use other clocks such
as monotonic.

Change-Id: I2286998c5eefbf3c3dfb105c223daec7a1083803
---
M CommonLibs/Timeval.cpp
M CommonLibs/Timeval.h
2 files changed, 28 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/80/12280/1

diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp
index 991e241..21072fc 100644
--- a/CommonLibs/Timeval.cpp
+++ b/CommonLibs/Timeval.cpp
@@ -34,36 +34,33 @@
now();
unsigned sec = offset/1000;
unsigned msec = offset%1000;
-   mTimeval.tv_usec += msec*1000;
-   mTimeval.tv_sec += sec;
-   if (mTimeval.tv_usec>100) {
-   mTimeval.tv_usec -= 100;
-   mTimeval.tv_sec += 1;
+   mTimespec.tv_nsec += msec*1000*1000;
+   mTimespec.tv_sec += sec;
+   if (mTimespec.tv_nsec > 1000*1000*1000) {
+   mTimespec.tv_nsec -= 1000*1000*1000;
+   mTimespec.tv_sec += 1;
}
 }


 struct timespec Timeval::timespec() const
 {
-   struct timespec retVal;
-   retVal.tv_sec = mTimeval.tv_sec;
-   retVal.tv_nsec = 1000 * (long)mTimeval.tv_usec;
-   return retVal;
+   return mTimespec;
 }


 bool Timeval::passed() const
 {
Timeval nowTime;
-   if (nowTime.mTimeval.tv_sec < mTimeval.tv_sec) return false;
-   if (nowTime.mTimeval.tv_sec > mTimeval.tv_sec) return true;
-   if (nowTime.mTimeval.tv_usec >= mTimeval.tv_usec) return true;
+   if (nowTime.mTimespec.tv_sec < mTimespec.tv_sec) return false;
+   if (nowTime.mTimespec.tv_sec > mTimespec.tv_sec) return true;
+   if (nowTime.mTimespec.tv_nsec >= mTimespec.tv_nsec) return true;
return false;
 }

 double Timeval::seconds() const
 {
-   return ((double)mTimeval.tv_sec) + 1e-6*((double)mTimeval.tv_usec);
+   return ((double)mTimespec.tv_sec) + 1e-9*((double)mTimespec.tv_nsec);
 }


@@ -72,8 +69,8 @@
 {
// 2^31 milliseconds is just over 4 years.
int32_t deltaS = other.sec() - sec();
-   int32_t deltaUs = other.usec() - usec();
-   return 1000*deltaS + deltaUs/1000;
+   int32_t deltaNs = other.nsec() - nsec();
+   return 1000*deltaS + deltaNs/100;
 }


@@ -89,7 +86,7 @@

 ostream& operator<<(ostream& os, const struct timespec& ts)
 {
-   os << ts.tv_sec << "," << ts.tv_nsec;
+   os << ts.tv_sec << "," << ts.tv_nsec/1000;
return os;
 }

diff --git a/CommonLibs/Timeval.h b/CommonLibs/Timeval.h
index c497864..b780af1 100644
--- a/CommonLibs/Timeval.h
+++ b/CommonLibs/Timeval.h
@@ -42,12 +42,12 @@

private:

-   struct timeval mTimeval;
+   struct timespec mTimespec;

public:

-   /** Set the value to gettimeofday. */
-   void now() { gettimeofday(,NULL); }
+   /** Set the value to current time. */
+   void now() { clock_gettime(CLOCK_REALTIME, ); }

/** Set the value to gettimeofday plus an offset. */
void future(unsigned ms);
@@ -55,16 +55,18 @@
//@{
Timeval(unsigned sec, unsigned usec)
{
-   mTimeval.tv_sec = sec;
-   mTimeval.tv_usec = usec;
+   mTimespec.tv_sec = sec;
+   mTimespec.tv_nsec = usec*1000;
}

Timeval(const struct timeval& wTimeval)
-   :mTimeval(wTimeval)
-   {}
+   {
+   mTimespec.tv_sec = wTimeval.tv_sec;
+   mTimespec.tv_nsec = wTimeval.tv_sec*1000;
+   }

/**
-   Create a Timeval offset into the future.
+   Create a Timespec offset into the future.
@param offset milliseconds
*/
Timeval(unsigned offset=0) { future(offset); }
@@ -76,8 +78,9 @@
/** Return total seconds. */
double seconds() const;

-   uint32_t sec() const { return mTimeval.tv_sec; }
-   uint32_t usec() const { return mTimeval.tv_usec; }
+   uint32_t sec() const { return mTimespec.tv_sec; }
+   uint32_t usec() const { return mTimespec.tv_nsec / 1000; }
+   uint32_t nsec() const { return mTimespec.tv_nsec; }

/** Return differnce from other (other-self), in ms. */
long delta(const Timeval& other) const;
@@ -88,11 +91,11 @@
/** Remaining time in ms. */
long remaining() const { return -elapsed(); }

-   /** Return true if the time has passed, as per gettimeofday. */
+   /** Return true if the time has passed, as per 
clock_gettime(CLOCK_REALTIME). */
bool passed() const;

Change in osmo-trx[master]: Timeval: passed() returns true if time is equal

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12279


Change subject: Timeval: passed() returns true if time is equal
..

Timeval: passed() returns true if time is equal

Change-Id: I96a9d26657f85447609693bc6932d218d354b84a
---
M CommonLibs/Timeval.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/79/12279/1

diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp
index 50ce05d..991e241 100644
--- a/CommonLibs/Timeval.cpp
+++ b/CommonLibs/Timeval.cpp
@@ -57,7 +57,7 @@
Timeval nowTime;
if (nowTime.mTimeval.tv_sec < mTimeval.tv_sec) return false;
if (nowTime.mTimeval.tv_sec > mTimeval.tv_sec) return true;
-   if (nowTime.mTimeval.tv_usec > mTimeval.tv_usec) return true;
+   if (nowTime.mTimeval.tv_usec >= mTimeval.tv_usec) return true;
return false;
 }


--
To view, visit https://gerrit.osmocom.org/12279
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96a9d26657f85447609693bc6932d218d354b84a
Gerrit-Change-Number: 12279
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Stefan Sperling]

Hello Pau Espin Pedrol, Max, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12243

to look at the new patch set (#2).

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..

make gsup ipa name configurable in osmo-sgsn.cfg

Add a 'ipa-name' VTY command which overrides the default IPA
name used by the SGSN on the GSUP link towards the HLR.
This is required for GSUP routing in multi-SGSN networks.

Related: OS#3356

Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
---
M include/osmocom/sgsn/sgsn.h
M src/gprs/gprs_subscriber.c
M src/gprs/sgsn_vty.c
3 files changed, 30 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/43/12243/2
--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12243/1/src/gprs/sgsn_vty.c
File src/gprs/sgsn_vty.c:

https://gerrit.osmocom.org/#/c/12243/1/src/gprs/sgsn_vty.c@1376
PS1, Line 1376: //install_element(SGSN_NODE, _ggsn_remote_port_cmd);
> kind of a weird spot to put it, right in the middle of the ggsn cfg :) better 
> fit is below with the  […]
Fair enough. I've moved it down in the next patch set.



--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 17:02:14 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 1:

> Patch Set 1:
>
> actually, the same applies to the osmo-msc patch.
>
> Please add 'no ipa-name'

Does changing this option at run-time make sense?

Currently, the option only affect new connections. Nothing is done to existing 
connections if the name is changed after the fact.
Is managing connections when the name changes something we actually want to do? 
What is bad about requiring a restart in this case?


--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:55:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-trx[master]: osmo-trx.cpp: move comma_delimited_to_vector() to Utils.cpp

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12278 )

Change subject: osmo-trx.cpp: move comma_delimited_to_vector() to Utils.cpp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12278
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3f0f682ca453c2b0a06175ec9626567932cfce6
Gerrit-Change-Number: 12278
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:54:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

[osmith]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12245

to look at the new patch set (#4).

Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg
..

LMSDevice: make use of dev-args in osmo-trx.cfg

Allow selecting a specific LimeSDR device by setting dev-args in the
config file. Split up the given dev-args address by comma and select
the device where all substrings can be found.

I could not test this with real hardware, but I have added a test case
to make sure this works as expected.

Related: OS#3654
Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852
---
M .gitignore
M Transceiver52M/device/lms/LMSDevice.cpp
A tests/Transceiver52M/LMSDeviceTest.cpp
M tests/Transceiver52M/Makefile.am
M tests/testsuite.at
5 files changed, 97 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/45/12245/4
--
To view, visit https://gerrit.osmocom.org/12245
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852
Gerrit-Change-Number: 12245
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

[Stefan Sperling]

Hello Max, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12242

to look at the new patch set (#2).

Change subject: remove pointless declaration of struct gsm_network
..

remove pointless declaration of struct gsm_network

We were passing a NULL pointer of type struct gsm_network * to
ctrl_interface_setup_dynip(). Remove the pointless declaration
of this struct. Also, replace the sgsn_controlif_setup() helper
function with a direct call to ctrl_interface_setup_dynip().
The helper fnuction was just a thin wrapper around the latter.

Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759
Related: OS#3356
---
M include/osmocom/sgsn/gprs_sgsn.h
M src/gprs/sgsn_ctrl.c
M src/gprs/sgsn_main.c
3 files changed, 2 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/42/12242/2
--
To view, visit https://gerrit.osmocom.org/12242
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759
Gerrit-Change-Number: 12242
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-trx[master]: osmo-trx.cpp: move comma_delimited_to_vector() to Utils.cpp

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12278


Change subject: osmo-trx.cpp: move comma_delimited_to_vector() to Utils.cpp
..

osmo-trx.cpp: move comma_delimited_to_vector() to Utils.cpp

Make the "opt" argument const. This function will also be used by
LMSDevice.cpp in a follow-up commit.

Related: OS#3654
Change-Id: If3f0f682ca453c2b0a06175ec9626567932cfce6
---
M CommonLibs/Makefile.am
A CommonLibs/Utils.cpp
A CommonLibs/Utils.h
M Transceiver52M/osmo-trx.cpp
4 files changed, 63 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/78/12278/1

diff --git a/CommonLibs/Makefile.am b/CommonLibs/Makefile.am
index 9fabcf1..83bd0c0 100644
--- a/CommonLibs/Makefile.am
+++ b/CommonLibs/Makefile.am
@@ -34,6 +34,7 @@
Threads.cpp \
Timeval.cpp \
Logger.cpp \
+   Utils.cpp \
trx_vty.c \
debug.c
 libcommon_la_LIBADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) 
$(LIBOSMOVTY_LIBS)
@@ -48,6 +49,7 @@
Timeval.h \
Vector.h \
Logger.h \
+   Utils.h \
trx_vty.h \
debug.h \
osmo_signal.h \
diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp
new file mode 100644
index 000..6cd4f84
--- /dev/null
+++ b/CommonLibs/Utils.cpp
@@ -0,0 +1,36 @@
+/*
+ * Copyright 2018 sysmocom - s.f.m.c. GmbH
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include 
+#include 
+#include 
+
+std::vector comma_delimited_to_vector(const char* opt)
+{
+   std::string str = std::string(opt);
+   std::vector result;
+   std::stringstream ss(str);
+
+   while( ss.good() )
+   {
+   std::string substr;
+   getline(ss, substr, ',');
+   result.push_back(substr);
+   }
+   return result;
+}
diff --git a/CommonLibs/Utils.h b/CommonLibs/Utils.h
new file mode 100644
index 000..4f0fbc0
--- /dev/null
+++ b/CommonLibs/Utils.h
@@ -0,0 +1,24 @@
+/*
+ * Copyright 2018 sysmocom - s.f.m.c. GmbH
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#pragma once
+
+#include 
+#include 
+
+std::vector comma_delimited_to_vector(const char* opt);
diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 2b69da4..0e63020 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -22,6 +22,7 @@

 #include "Transceiver.h"
 #include "radioDevice.h"
+#include "Utils.h"

 #include 
 #include 
@@ -194,21 +195,6 @@
osmo_init_ignore_signals();
 }

-static std::vector comma_delimited_to_vector(char* opt)
-{
-   std::string str = std::string(opt);
-   std::vector result;
-   std::stringstream ss(str);
-
-   while( ss.good() )
-   {
-   std::string substr;
-   getline(ss, substr, ',');
-   result.push_back(substr);
-   }
-   return result;
-}
-
 static void print_help()
 {
fprintf(stdout, "Options:\n"

--
To view, visit https://gerrit.osmocom.org/12278
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3f0f682ca453c2b0a06175ec9626567932cfce6
Gerrit-Change-Number: 12278
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

[osmith]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12245

to look at the new patch set (#3).

Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg
..

LMSDevice: make use of dev-args in osmo-trx.cfg

Allow selecting a specific LimeSDR device by setting dev-args in the
config file. Split up the given dev-args address by comma and select
the device where all substrings can be found.

I could not test this with real hardware, but I have added a test case
to make sure this works as expected.

Related: OS#3654
Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852
---
M .gitignore
M Transceiver52M/device/lms/LMSDevice.cpp
A tests/Transceiver52M/LMSDeviceTest.cpp
M tests/Transceiver52M/Makefile.am
M tests/testsuite.at
5 files changed, 97 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/45/12245/3
--
To view, visit https://gerrit.osmocom.org/12245
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852
Gerrit-Change-Number: 12245
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12242 )

Change subject: remove pointless declaration of struct gsm_network
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12242/1/src/gprs/sgsn_ctrl.c
File src/gprs/sgsn_ctrl.c:

https://gerrit.osmocom.org/#/c/12242/1/src/gprs/sgsn_ctrl.c@64
PS1, Line 64: struct ctrl_handle *sgsn_controlif_setup(void *data, const char 
*bind_addr, uint16_t port)
> In fact, entire function is trivial one-line wrapper used in single place. […]
Yes, good point. I'll do that.



--
To view, visit https://gerrit.osmocom.org/12242
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759
Gerrit-Change-Number: 12242
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:44:51 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in docker-playground[master]: MSC: use config file for mncc path

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12277


Change subject: MSC: use config file for mncc path
..

MSC: use config file for mncc path

Use config file parameter instead of command line option for MNCC socket
path.

Change-Id: I689cfb3bad09b76859ef7e42c1312c636eebe637
---
M ttcn3-msc-test/jenkins.sh
M ttcn3-msc-test/osmo-msc.cfg
2 files changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/77/12277/1

diff --git a/ttcn3-msc-test/jenkins.sh b/ttcn3-msc-test/jenkins.sh
index 662c377..82ec483 100755
--- a/ttcn3-msc-test/jenkins.sh
+++ b/ttcn3-msc-test/jenkins.sh
@@ -38,7 +38,7 @@
-v $VOL_BASE_DIR/unix:/data/unix \
--name ${BUILD_TAG}-msc -d \
$REPO_USER/osmo-msc-$IMAGE_SUFFIX \
-   /usr/local/bin/osmo-msc -M /data/unix/mncc
+   /usr/local/bin/osmo-msc

 echo Starting container with MSC testsuite
 docker run --rm \
diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg
index f0180d8..4c3555b 100644
--- a/ttcn3-msc-test/osmo-msc.cfg
+++ b/ttcn3-msc-test/osmo-msc.cfg
@@ -73,6 +73,7 @@
  cs7-instance-iu 0
  mgw remote-ip 172.18.1.103
  emergency-call route-to-msisdn 112
+ mncc external /data/unix/mncc
 mncc-int
  default-codec tch-f fr
  default-codec tch-h hr

--
To view, visit https://gerrit.osmocom.org/12277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I689cfb3bad09b76859ef7e42c1312c636eebe637
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-hlr[master]: disable recording of LU timestamps by default

[Stefan Sperling]

Stefan Sperling has abandoned this change. ( https://gerrit.osmocom.org/12228 )

Change subject: disable recording of LU timestamps by default
..


Abandoned

Fair enough. I've made my point.
--
To view, visit https://gerrit.osmocom.org/12228
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2f18b5ddc9b4b8e1174c6dea71cddf1c8d2230df
Gerrit-Change-Number: 12228
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-ci[master]: master-builds: openbsc: make SSH keys available

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12276 )

Change subject: master-builds: openbsc: make SSH keys available
..

master-builds: openbsc: make SSH keys available

Mount ~/.ssh in openbsc's docker container, just like it is done with
all other Osmocom projects that build in docker (see Change-Id
Icfff3b6a620de79d1bab7ff6a35309f828581c09 ("master-builds: make SSH keys
available in Docker")).

Related: OS#3385
Change-Id: Ib31ab4033c1cc71c10a96445e8bcc3b9f02e2a1f
---
M jobs/master-builds.yml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Harald Welte: Looks good to me, approved
  osmith: Verified



diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 97e193a..eb5db88 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -164,6 +164,7 @@
   -w /build -i -u build \
   -v "$PWD:/build" \
   -v "$HOME/bin:/build_bin" \
+  -v "$HOME/.ssh:/home/build/.ssh:ro" \
   -v "$ARTIFACT_STORE:/artifact_store" \
   osmocom:amd64 /build/contrib/jenkins.sh


--
To view, visit https://gerrit.osmocom.org/12276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib31ab4033c1cc71c10a96445e8bcc3b9f02e2a1f
Gerrit-Change-Number: 12276
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-ci[master]: master-builds: openbsc: make SSH keys available

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12276 )

Change subject: master-builds: openbsc: make SSH keys available
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31ab4033c1cc71c10a96445e8bcc3b9f02e2a1f
Gerrit-Change-Number: 12276
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:32:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: master-builds: openbsc: make SSH keys available

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12276 )

Change subject: master-builds: openbsc: make SSH keys available
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31ab4033c1cc71c10a96445e8bcc3b9f02e2a1f
Gerrit-Change-Number: 12276
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:31:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: cleanup: remove unused define

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12272 )

Change subject: cleanup: remove unused define
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12272
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibff603dd581f60b600f2469ad464a0bf77e24bfe
Gerrit-Change-Number: 12272
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:23:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
..


Patch Set 1: Code-Review+2

I don't agree, I don't like leaving a define dangling in a commit, but anyway, 
not that important.


--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:23:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
..


Patch Set 1:

> Patch Set 1:
> I know you wanted to split them based on spatch

Exactly.

> but this way adds extra verbosity to history and makes it more difficult to 
> revert for no good reason.

I don't think it's actually a problem: reverting 2 patches would be 2 clicks 
instead of 1 (and we rarely have to do this anyway). I think keeping manual 
changes separated from automated code editing is worth it.


--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:20:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: master-builds: openbsc: make SSH keys available

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12276 )

Change subject: master-builds: openbsc: make SSH keys available
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31ab4033c1cc71c10a96445e8bcc3b9f02e2a1f
Gerrit-Change-Number: 12276
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:17:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Re: build slave segfaults

[Neels Hofmeyr]

On Wed, Dec 12, 2018 at 01:26:45PM +0100, Pau Espin Pedrol wrote:
> on the virtualization layer being used by OBS to run containers.

This is our own jenkins build slave, not an OBS package builder.

In our build slaves, sporadic failures usually didn't happen. Might hint at
faulty RAM or somesuch. Or just a flapping bug, of course.

~N


signature.asc
Description: PGP signature

Change in osmo-ci[master]: master-builds: openbsc: make SSH keys available

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12276


Change subject: master-builds: openbsc: make SSH keys available
..

master-builds: openbsc: make SSH keys available

Mount ~/.ssh in openbsc's docker container, just like it is done with
all other Osmocom projects that build in docker (see Change-Id
Icfff3b6a620de79d1bab7ff6a35309f828581c09 ("master-builds: make SSH keys
available in Docker")).

Related: OS#3385
Change-Id: Ib31ab4033c1cc71c10a96445e8bcc3b9f02e2a1f
---
M jobs/master-builds.yml
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/12276/1

diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 97e193a..eb5db88 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -164,6 +164,7 @@
   -w /build -i -u build \
   -v "$PWD:/build" \
   -v "$HOME/bin:/build_bin" \
+  -v "$HOME/.ssh:/home/build/.ssh:ro" \
   -v "$ARTIFACT_STORE:/artifact_store" \
   osmocom:amd64 /build/contrib/jenkins.sh


--
To view, visit https://gerrit.osmocom.org/12276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib31ab4033c1cc71c10a96445e8bcc3b9f02e2a1f
Gerrit-Change-Number: 12276
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Jenkins build is back to normal : master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,default,osmocom-master-debian9 #3399

[jenkins]

See 

Jenkins build is back to normal : master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,default,osmocom-master-debian9 #3399

[jenkins]

See 

Build failed in Jenkins: master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,default,osmocom-master-debian9 #3398

[jenkins]

See 


Changes:

[Oliver Smith] contrib/jenkins.sh: build and publish manuals

--
[...truncated 1.03 MB...]
else \
mode=644; \
fi; \
install -vDm$mode "$i" 
""/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals"/$i" || exit 
1; \
done;
install: creating directory '/build/deps/install/stow/osmo-gsm-manuals/share'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build'
'build/diag-filter.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/diag-filter.conf'
'build/known_hosts' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/known_hosts'
'build/docinfo-releaseinfo.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf'
'build/mscgen-filter.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/mscgen-filter.conf'
'build/unix-time-to-fmt.py' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/unix-time-to-fmt.py'
'build/python2-filter.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/python2-filter.conf'
'build/Makefile.docbook.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.docbook.inc'
'build/Makefile.vty-reference.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.vty-reference.inc'
'build/custom-dblatex.sty' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/custom-dblatex.sty'
'build/Makefile.common.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.common.inc'
'build/vty_reference_combine.sh' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/vty_reference_combine.sh'
'build/Makefile.asciidoc.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc'
'build/filter-wrapper.py' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/filter-wrapper.py'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common'
'common/vty_additions.xml' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/vty_additions.xml'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images'
'common/images/osmocom.pdf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/osmocom.pdf'
'common/images/lte-eps-sgs.dot' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/lte-eps-sgs.dot'
'common/images/sysmocom.pdf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/sysmocom.pdf'
'common/images/wireshark-gsmtap-log.png' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/wireshark-gsmtap-log.png'
'common/images/lte-eps.dot' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/lte-eps.dot'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters'
'common/chapters/sigtran.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/sigtran.adoc'
'common/chapters/bibliography.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/bibliography.adoc'
'common/chapters/msc_mncc_mo_rtp.msc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/msc_mncc_mo_rtp.msc'
'common/chapters/bts.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/bts.adoc'
'common/chapters/rf.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/rf.adoc'
'common/chapters/sigtran-simple-2g.dot' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/sigtran-simple-2g.dot'
'common/chapters/logging.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/logging.adoc'
'common/chapters/control_if.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/control_if.adoc'
'common/chapters/vty.xml' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/vty.xml'
'common/chapters/oap.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/oap.adoc'
'common/chapters/port_numbers.adoc' -> 

Build failed in Jenkins: master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,default,osmocom-master-debian9 #3398

[jenkins]

See 


Changes:

[Oliver Smith] contrib/jenkins.sh: build and publish manuals

--
[...truncated 1.03 MB...]
else \
mode=644; \
fi; \
install -vDm$mode "$i" 
""/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals"/$i" || exit 
1; \
done;
install: creating directory '/build/deps/install/stow/osmo-gsm-manuals/share'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build'
'build/diag-filter.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/diag-filter.conf'
'build/known_hosts' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/known_hosts'
'build/docinfo-releaseinfo.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf'
'build/mscgen-filter.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/mscgen-filter.conf'
'build/unix-time-to-fmt.py' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/unix-time-to-fmt.py'
'build/python2-filter.conf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/python2-filter.conf'
'build/Makefile.docbook.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.docbook.inc'
'build/Makefile.vty-reference.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.vty-reference.inc'
'build/custom-dblatex.sty' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/custom-dblatex.sty'
'build/Makefile.common.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.common.inc'
'build/vty_reference_combine.sh' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/vty_reference_combine.sh'
'build/Makefile.asciidoc.inc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc'
'build/filter-wrapper.py' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/build/filter-wrapper.py'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common'
'common/vty_additions.xml' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/vty_additions.xml'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images'
'common/images/osmocom.pdf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/osmocom.pdf'
'common/images/lte-eps-sgs.dot' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/lte-eps-sgs.dot'
'common/images/sysmocom.pdf' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/sysmocom.pdf'
'common/images/wireshark-gsmtap-log.png' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/wireshark-gsmtap-log.png'
'common/images/lte-eps.dot' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/images/lte-eps.dot'
install: creating directory 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters'
'common/chapters/sigtran.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/sigtran.adoc'
'common/chapters/bibliography.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/bibliography.adoc'
'common/chapters/msc_mncc_mo_rtp.msc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/msc_mncc_mo_rtp.msc'
'common/chapters/bts.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/bts.adoc'
'common/chapters/rf.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/rf.adoc'
'common/chapters/sigtran-simple-2g.dot' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/sigtran-simple-2g.dot'
'common/chapters/logging.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/logging.adoc'
'common/chapters/control_if.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/control_if.adoc'
'common/chapters/vty.xml' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/vty.xml'
'common/chapters/oap.adoc' -> 
'/build/deps/install/stow/osmo-gsm-manuals/share/osmo-gsm-manuals/common/chapters/oap.adoc'
'common/chapters/port_numbers.adoc' -> 

Change in libosmocore[master]: ipa_ccm_idtag_parse*: Fix reported length value

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10216 )

Change subject: ipa_ccm_idtag_parse*: Fix reported length value
..


Patch Set 3:

assigning this to neels. Not sure why this patch never got any review for 
months.


--
To view, visit https://gerrit.osmocom.org/10216
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I435aaa33605bd48635715a2c81aa2d231c1abf51
Gerrit-Change-Number: 10216
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 12 Dec 2018 15:48:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in openbsc[master]: contrib/jenkins.sh: build and publish manuals

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12275 )

Change subject: contrib/jenkins.sh: build and publish manuals
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12275
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89be11d346d50169282c991235ffc47dacc30b11
Gerrit-Change-Number: 12275
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 15:47:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: contrib/jenkins.sh: build and publish manuals

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12275 )

Change subject: contrib/jenkins.sh: build and publish manuals
..

contrib/jenkins.sh: build and publish manuals

Add new environment variables WITH_MANUALS and PUBLISH to control if
the manuals should be built and uploaded. Describe all environment vars
on top of the file.

Related: OS#3385
Change-Id: I89be11d346d50169282c991235ffc47dacc30b11
---
M contrib/jenkins.sh
1 file changed, 29 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 5bab5bf..7083976 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,4 +1,13 @@
 #!/bin/sh -ex
+# jenkins build helper script for openbsc.  This is how we build on 
jenkins.osmocom.org
+#
+# environment variables:
+# * IU: configure 3G support (values: "--enable-iu", "--disable-iu")
+# * MGCP: configure transcoding for MGCP (values: "--enable-mgcp-transcoding", 
"--disable-mgcp-transcoding")
+# * SMPP: configure the SMPP interface (values: "--enable-smpp", 
"--disable-smpp")
+# * WITH_MANUALS: build manual PDFs if set to "1"
+# * PUBLISH: upload manuals after building if set to "1" (ignored without 
WITH_MANUALS = "1")
+#

 osmo-clean-workspace.sh

@@ -59,4 +68,24 @@

 . osmo-build.sh

+# Build and publish manuals
+if [ "$WITH_MANUALS" = "1" ]; then
+   # Build all manuals first
+   osmo-build-dep.sh osmo-gsm-manuals
+   for dir in "$base"/manuals/*/; do
+   make -C "$dir"
+   done
+
+   # Run 'make check' for the OsmoNITB manuals.
+   # The other dirs only have VTY references, so there is no 'make check' 
target for them.
+   make -C "$base/manuals/OsmoNITB" check
+
+   # Publish all at once
+   if [ "$PUBLISH" = "1" ]; then
+   for dir in "$base"/manuals/*/; do
+   make -C "$dir" publish
+   done
+   fi
+fi
+
 osmo-clean-workspace.sh

--
To view, visit https://gerrit.osmocom.org/12275
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89be11d346d50169282c991235ffc47dacc30b11
Gerrit-Change-Number: 12275
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bts[master]: clear GPRS indicator in SI3 while PCU is disconnected

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/10170 )

Change subject: clear GPRS indicator in SI3 while PCU is disconnected
..


Patch Set 1:

Shouldn't this be marked as WIP while we're waiting on license clarification 
and related gerrit patch?


--
To view, visit https://gerrit.osmocom.org/10170
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6f5c636c0fe098ee31c280d4572a3f8122b44b
Gerrit-Change-Number: 10170
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 12 Dec 2018 15:00:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: comment: vlr: put the 'balancing' comment closer to the put()

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12240 )

Change subject: comment: vlr: put the 'balancing' comment closer to the put()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
Gerrit-Change-Number: 12240
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 14:47:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12266 )

Change subject: vty: show subscriber: put() before printing the use count
..


Patch Set 1:

(2 comments)

Please clarify.

https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c@821
PS1, Line 821: argv[1]);
If this taints the count than what about all other calls to get_vsub_by_argv()?


https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c@830
PS1, Line 830:   * and since it existed before we called _get() on it above. */
Are you referring to get_vsub_by_argv()? Better use function name - it's more 
likely to persist than relative positions.



--
To view, visit https://gerrit.osmocom.org/12266
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id02b57b7ed299b010b9f8b9e809548eb1e6aa699
Gerrit-Change-Number: 12266
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 12 Dec 2018 14:44:24 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-trx[master]: configure.ac: check boost only if USRP1 support is enabled

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12088 )

Change subject: configure.ac: check boost only if USRP1 support is enabled
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12088
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c3fa3ff58fd552d0cb4c4cf2033615d84c07c96
Gerrit-Change-Number: 12088
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 12 Dec 2018 14:32:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: tests: rename convolve_test -> ConvolveTest

[osmith]

osmith has abandoned this change. ( https://gerrit.osmocom.org/12244 )

Change subject: tests: rename convolve_test -> ConvolveTest
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/12244
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4ca533ca8c5e19b6dbe7b0aba672ee14cf5c3bd1
Gerrit-Change-Number: 12244
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in libosmocore[master]: cleanup: remove unused define

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12272 )

Change subject: cleanup: remove unused define
..


Patch Set 1:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/12272
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibff603dd581f60b600f2469ad464a0bf77e24bfe
Gerrit-Change-Number: 12272
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Wed, 12 Dec 2018 14:24:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Jenkins build is back to normal : master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #738

[jenkins]

See 

Change in osmo-mgw[master]: drop/replace very weird logging in mgcp_client.c

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12269 )

Change subject: drop/replace very weird logging in mgcp_client.c
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12269
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6877ed7fd7dbe009b2ece8792d5160d040c1aaa
Gerrit-Change-Number: 12269
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 12 Dec 2018 14:04:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: drop/replace very weird logging in mgcp_client.c

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/12269 )

Change subject: drop/replace very weird logging in mgcp_client.c
..


Patch Set 1: Code-Review+1

> Leaving +2 until dexter has a look at it.

I think this ok, the logging seems to be indeed strange since the for loop 
replaces all \r or \n with \0, this means the message will be chopped off very 
early. Now we should get a more complete message (as long as it is not longer 
than 255 chars.)


--
To view, visit https://gerrit.osmocom.org/12269
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6877ed7fd7dbe009b2ece8792d5160d040c1aaa
Gerrit-Change-Number: 12269
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:49:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Jenkins build is back to normal : master-osmo-pcu » origin/nrw/litecell15,0,osmocom-master-debian9,lc15,True #1069

[jenkins]

See 

Build failed in Jenkins: master-osmo-pcu » origin/nrw/litecell15,0,osmocom-master-debian9,lc15,True #1068

[jenkins]

See 


--
[...truncated 95.85 KB...]
make[2]: Leaving directory 
'
make[2]: Entering directory 
'
make[3]: Entering directory 
'
 /bin/mkdir -p 
'
 /bin/mkdir -p 
'
 /bin/mkdir -p 
'
 /usr/bin/install -c osmo-release.sh 
'
 /usr/bin/install -c -m 644 osmo-release.mk 
'
 /usr/bin/install -c -m 644 libosmocore.pc libosmocodec.pc libosmovty.pc 
libosmogsm.pc libosmogb.pc libosmoctrl.pc libosmocoding.pc libosmosim.pc 
'
make  install-data-hook
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-data-hook'.
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
+ 
STOW_DIR=
 stow --restow libosmocore
+ export 
PKG_CONFIG_PATH=:
+ export 
LD_LIBRARY_PATH=
+ export 
PATH=:/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin
+ [ 0 = 1 ]
+ set +x



 === osmo-pcu ===

+ autoreconf --install --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac,
libtoolize: and 

Change in osmocom-bb[master]: contrib/jenkins.sh: build and publish manuals

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12274 )

Change subject: contrib/jenkins.sh: build and publish manuals
..

contrib/jenkins.sh: build and publish manuals

Add new environment variables WITH_MANUALS and PUBLISH to control if
the manuals should be built and uploaded. Describe all environment vars
on top of the file.

Related: OS#3385
Change-Id: I856e4bc71e1b648de5f27d4044aa60bd0b45e0f5
---
M contrib/jenkins.sh
1 file changed, 17 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve; Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index f886c21..aa02b28 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,4 +1,10 @@
 #!/bin/sh
+# jenkins build helper script for osmocom-bb.  This is how we build on 
jenkins.osmocom.org
+#
+# environment variables:
+# * WITH_MANUALS: build manual PDFs if set to "1"
+# * PUBLISH: upload manuals after building if set to "1" (ignored without 
WITH_MANUALS = "1")
+#

 set -ex

@@ -35,4 +41,15 @@
make
 done

+# Build and publish manuals
+if [ "$WITH_MANUALS" = "1" ]; then
+   osmo-build-dep.sh osmo-gsm-manuals
+   make -C "$base/doc/manuals"
+   make -C "$base/doc/manuals" check
+
+   if [ "$PUBLISH" = "1" ]; then
+   make -C "$base/doc/manuals" publish
+   fi
+fi
+
 osmo-clean-workspace.sh

--
To view, visit https://gerrit.osmocom.org/12274
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I856e4bc71e1b648de5f27d4044aa60bd0b45e0f5
Gerrit-Change-Number: 12274
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmocom-bb[master]: contrib/jenkins.sh: build and publish manuals

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12274 )

Change subject: contrib/jenkins.sh: build and publish manuals
..


Patch Set 1: Verified+1 Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12274
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I856e4bc71e1b648de5f27d4044aa60bd0b45e0f5
Gerrit-Change-Number: 12274
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:20:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: Build verification: manuals for the rest

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12273 )

Change subject: Build verification: manuals for the rest
..

Build verification: manuals for the rest

Build manuals for osmocom-bb and openbsc in gerrit-verifications.yml.
Build and publish manuals for osmocom-bb, openbsc and osmo-gsm-tester
in master-builds.yml.

Following recommendations on the ML, building manuals for
osmo-gsm-tester was not done with a new job in gerrit-verifications.yml.
It will be done with the existing osmo-gsm-tester_gerrit job (which is
generated by osmo-gsm-tester-runner.yml). No changes are necessary for
that in osmo-ci.git, see I4ebfe12a164f807b63bc897aff44db83fc0705bd
("contrib/jenkins*: build and publish manuals") in osmo-gsm-tester.git.

Related: OS#3385
Change-Id: I2845d14b656f11e3a07107b4f16e8d7a0e3c7bbf
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
2 files changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve; Verified



diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index d17934d..20eceef 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -81,6 +81,7 @@
   -e MGCP="$MGCP" \
   -e PATH="$PATH:/build_bin" \
   -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+  -e WITH_MANUALS="1" \
   -w /build -i -u build \
   -v "$PWD:/build" \
   -v "$HOME/bin:/build_bin" \
@@ -247,7 +248,8 @@
   combination_filter: >
 (INSTR == "--with-sse" && WITH_MANUALS == "1")

-  - osmocom-bb
+  - osmocom-bb:
+  cmd: WITH_MANUALS=1 ./contrib/jenkins.sh
   - osmo-tetra
   - osmo-sysmon
   - osmo-remsim
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 1b7cdfd..97e193a 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -159,6 +159,8 @@
   -e MGCP="$MGCP" \
   -e PATH="$PATH:/build_bin" \
   -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+  -e WITH_MANUALS="1" \
+  -e PUBLISH="1" \
   -w /build -i -u build \
   -v "$PWD:/build" \
   -v "$HOME/bin:/build_bin" \
@@ -220,6 +222,9 @@
# keep first line with less indent to preserve newlines
 ./contrib/jenkins.sh

+  - osmo-gsm-tester:
+  cmd: PUBLISH=1 ./contrib/jenkins-build-manuals.sh
+
   - osmo-hlr:
   cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh

@@ -349,7 +354,9 @@
 (INSTR == "--with-sse" && WITH_MANUALS == "1")
   cmd: PUBLISH=1 ./contrib/jenkins.sh

-  - osmocom-bb
+  - osmocom-bb:
+  cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh
+
   - osmo-sysmon
   - osmo-remsim
   - simtrace2:

--
To view, visit https://gerrit.osmocom.org/12273
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2845d14b656f11e3a07107b4f16e8d7a0e3c7bbf
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-ci[master]: Build verification: manuals for the rest

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12273 )

Change subject: Build verification: manuals for the rest
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12273
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2845d14b656f11e3a07107b4f16e8d7a0e3c7bbf
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:20:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: Build verification: manuals for the rest

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12273 )

Change subject: Build verification: manuals for the rest
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12273
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2845d14b656f11e3a07107b4f16e8d7a0e3c7bbf
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:19:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: contrib/jenkins.sh: build and publish manuals

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12275 )

Change subject: contrib/jenkins.sh: build and publish manuals
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12275
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89be11d346d50169282c991235ffc47dacc30b11
Gerrit-Change-Number: 12275
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:17:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: contrib/jenkins.sh: build and publish manuals

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12274 )

Change subject: contrib/jenkins.sh: build and publish manuals
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12274
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I856e4bc71e1b648de5f27d4044aa60bd0b45e0f5
Gerrit-Change-Number: 12274
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:17:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: Build verification: manuals for the rest

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12273 )

Change subject: Build verification: manuals for the rest
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12273
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2845d14b656f11e3a07107b4f16e8d7a0e3c7bbf
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:10:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #737

[jenkins]

See 


--
[...truncated 266.38 KB...]
make[4]: Leaving directory 
'
Making install in uhd
make[4]: Entering directory 
'
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
Making install in lms
make[4]: Entering directory 
'
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[4]: Entering directory 
'
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[3]: Entering directory 
'
make[4]: Entering directory 
'
 /bin/mkdir -p 
'
  /bin/bash ../libtool   --mode=install /usr/bin/install -c osmo-trx-uhd 
osmo-trx-usrp1 osmo-trx-lms 
'
libtool: install: /usr/bin/install -c osmo-trx-uhd 

Change in openbsc[master]: contrib/jenkins.sh: build and publish manuals

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12275


Change subject: contrib/jenkins.sh: build and publish manuals
..

contrib/jenkins.sh: build and publish manuals

Add new environment variables WITH_MANUALS and PUBLISH to control if
the manuals should be built and uploaded. Describe all environment vars
on top of the file.

Related: OS#3385
Change-Id: I89be11d346d50169282c991235ffc47dacc30b11
---
M contrib/jenkins.sh
1 file changed, 29 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/75/12275/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 5bab5bf..7083976 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,4 +1,13 @@
 #!/bin/sh -ex
+# jenkins build helper script for openbsc.  This is how we build on 
jenkins.osmocom.org
+#
+# environment variables:
+# * IU: configure 3G support (values: "--enable-iu", "--disable-iu")
+# * MGCP: configure transcoding for MGCP (values: "--enable-mgcp-transcoding", 
"--disable-mgcp-transcoding")
+# * SMPP: configure the SMPP interface (values: "--enable-smpp", 
"--disable-smpp")
+# * WITH_MANUALS: build manual PDFs if set to "1"
+# * PUBLISH: upload manuals after building if set to "1" (ignored without 
WITH_MANUALS = "1")
+#

 osmo-clean-workspace.sh

@@ -59,4 +68,24 @@

 . osmo-build.sh

+# Build and publish manuals
+if [ "$WITH_MANUALS" = "1" ]; then
+   # Build all manuals first
+   osmo-build-dep.sh osmo-gsm-manuals
+   for dir in "$base"/manuals/*/; do
+   make -C "$dir"
+   done
+
+   # Run 'make check' for the OsmoNITB manuals.
+   # The other dirs only have VTY references, so there is no 'make check' 
target for them.
+   make -C "$base/manuals/OsmoNITB" check
+
+   # Publish all at once
+   if [ "$PUBLISH" = "1" ]; then
+   for dir in "$base"/manuals/*/; do
+   make -C "$dir" publish
+   done
+   fi
+fi
+
 osmo-clean-workspace.sh

--
To view, visit https://gerrit.osmocom.org/12275
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89be11d346d50169282c991235ffc47dacc30b11
Gerrit-Change-Number: 12275
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in osmocom-bb[master]: contrib/jenkins.sh: build and publish manuals

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12274


Change subject: contrib/jenkins.sh: build and publish manuals
..

contrib/jenkins.sh: build and publish manuals

Add new environment variables WITH_MANUALS and PUBLISH to control if
the manuals should be built and uploaded. Describe all environment vars
on top of the file.

Related: OS#3385
Change-Id: I856e4bc71e1b648de5f27d4044aa60bd0b45e0f5
---
M contrib/jenkins.sh
1 file changed, 17 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/74/12274/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index f886c21..aa02b28 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,4 +1,10 @@
 #!/bin/sh
+# jenkins build helper script for osmocom-bb.  This is how we build on 
jenkins.osmocom.org
+#
+# environment variables:
+# * WITH_MANUALS: build manual PDFs if set to "1"
+# * PUBLISH: upload manuals after building if set to "1" (ignored without 
WITH_MANUALS = "1")
+#

 set -ex

@@ -35,4 +41,15 @@
make
 done

+# Build and publish manuals
+if [ "$WITH_MANUALS" = "1" ]; then
+   osmo-build-dep.sh osmo-gsm-manuals
+   make -C "$base/doc/manuals"
+   make -C "$base/doc/manuals" check
+
+   if [ "$PUBLISH" = "1" ]; then
+   make -C "$base/doc/manuals" publish
+   fi
+fi
+
 osmo-clean-workspace.sh

--
To view, visit https://gerrit.osmocom.org/12274
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I856e4bc71e1b648de5f27d4044aa60bd0b45e0f5
Gerrit-Change-Number: 12274
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
..


Patch Set 1:

Ah it's done in next patch. I know you wanted to split them based on spatch, 
but this way adds extra verbosity to history and makes it more difficult to 
revert for no good reason.


--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:07:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: Build verification: manuals for the rest

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12273


Change subject: Build verification: manuals for the rest
..

Build verification: manuals for the rest

Build manuals for osmocom-bb and openbsc in gerrit-verifications.yml.
Build and publish manuals for osmocom-bb, openbsc and osmo-gsm-tester
in master-builds.yml.

Following recommendations on the ML, building manuals for
osmo-gsm-tester was not done with a new job in gerrit-verifications.yml.
It will be done with the existing osmo-gsm-tester_gerrit job (which is
generated by osmo-gsm-tester-runner.yml). No changes are necessary for
that in osmo-ci.git, see I4ebfe12a164f807b63bc897aff44db83fc0705bd
("contrib/jenkins*: build and publish manuals") in osmo-gsm-tester.git.

Related: OS#3385
Change-Id: I2845d14b656f11e3a07107b4f16e8d7a0e3c7bbf
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
2 files changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/73/12273/1

diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index d17934d..20eceef 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -81,6 +81,7 @@
   -e MGCP="$MGCP" \
   -e PATH="$PATH:/build_bin" \
   -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+  -e WITH_MANUALS="1" \
   -w /build -i -u build \
   -v "$PWD:/build" \
   -v "$HOME/bin:/build_bin" \
@@ -247,7 +248,8 @@
   combination_filter: >
 (INSTR == "--with-sse" && WITH_MANUALS == "1")

-  - osmocom-bb
+  - osmocom-bb:
+  cmd: WITH_MANUALS=1 ./contrib/jenkins.sh
   - osmo-tetra
   - osmo-sysmon
   - osmo-remsim
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 1b7cdfd..97e193a 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -159,6 +159,8 @@
   -e MGCP="$MGCP" \
   -e PATH="$PATH:/build_bin" \
   -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+  -e WITH_MANUALS="1" \
+  -e PUBLISH="1" \
   -w /build -i -u build \
   -v "$PWD:/build" \
   -v "$HOME/bin:/build_bin" \
@@ -220,6 +222,9 @@
# keep first line with less indent to preserve newlines
 ./contrib/jenkins.sh

+  - osmo-gsm-tester:
+  cmd: PUBLISH=1 ./contrib/jenkins-build-manuals.sh
+
   - osmo-hlr:
   cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh

@@ -349,7 +354,9 @@
 (INSTR == "--with-sse" && WITH_MANUALS == "1")
   cmd: PUBLISH=1 ./contrib/jenkins.sh
 
-  - osmocom-bb
+  - osmocom-bb:
+  cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh
+
   - osmo-sysmon
   - osmo-remsim
   - simtrace2:

--
To view, visit https://gerrit.osmocom.org/12273
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2845d14b656f11e3a07107b4f16e8d7a0e3c7bbf
Gerrit-Change-Number: 12273
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c@40
PS1, Line 40: #define VERIFY(msg, data, len)
\
This one can be dropped then right?



--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-CC: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:05:53 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: master-builds: set PUBLISH=0 temporarily

[osmith]

osmith has abandoned this change. ( https://gerrit.osmocom.org/12137 )

Change subject: master-builds: set PUBLISH=0 temporarily
..


Abandoned

Harald adjusted the config of rita.osmocom.org, now publishing works \o/ 
http://ftp.osmocom.org/docs/latest/ (see last changed date). Tested with 
osmo-hlr (without Docker) and osmo-mgw (with Docker) so far, triggered all 
master jobs once to update the manuals.
--
To view, visit https://gerrit.osmocom.org/12137
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I946f2e17229d3c602bbe79a72cc37104745ea552
Gerrit-Change-Number: 12137
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-mgw[master]: mgcp_client: logging tweaks

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12270 )

Change subject: mgcp_client: logging tweaks
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12270/1/src/libosmo-mgcp-client/mgcp_client.c
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/#/c/12270/1/src/libosmo-mgcp-client/mgcp_client.c@851
PS1, Line 851:  LOGP(DLMGCP, LOGL_INFO, "MGCP GW connection: %s\n", 
osmo_sock_get_name2(wq->bfd.fd));
Why issuing a syscall if we already have the information stored in a struct?



--
To view, visit https://gerrit.osmocom.org/12270
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae728192f499330d16836d9435648f6b8ed213b6
Gerrit-Change-Number: 12270
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:58:39 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: cleanup: remove unused define

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12272


Change subject: cleanup: remove unused define
..

cleanup: remove unused define

Change-Id: Ibff603dd581f60b600f2469ad464a0bf77e24bfe
---
M tests/gsm0808/gsm0808_test.c
1 file changed, 0 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/12272/1

diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index a31e7d4..23961c8 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -37,19 +37,6 @@
OSMO_ASSERT(rc_enc == msg->len); \
} while(0)

-#define VERIFY(msg, data, len) 
\
-   if (msgb_l3len(msg) != len) {   \
-   printf("%s:%d Length don't match: %d vs. %d. %s\n", \
-   __func__, __LINE__, msgb_l3len(msg), (int) len, \
-   osmo_hexdump(msg->l3h, msgb_l3len(msg)));   \
-   abort();\
-   } else if (memcmp(msg->l3h, data, len) != 0) {  \
-   printf("%s:%d didn't match: got: %s\n", \
-   __func__, __LINE__, \
-   osmo_hexdump(msg->l3h, msgb_l3len(msg)));   \
-   abort();\
-   }
-
 /* Setup a fake codec list for testing */
 static void setup_codec_list(struct gsm0808_speech_codec_list *scl)
 {

--
To view, visit https://gerrit.osmocom.org/12272
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibff603dd581f60b600f2469ad464a0bf77e24bfe
Gerrit-Change-Number: 12272
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12271


Change subject: Use msgb helper instead of local #define for debug print
..

Use msgb helper instead of local #define for debug print

This change was made using following spatch program:
@@
expression a, b, c;
@@
- VERIFY(a, b, c);
+ if (!msgb_eq_l3_data_print(a, b, c))
+  abort();

Which was applied as follows:
spatch --in-place --sp-file verif.spatch tests/gsm0808/gsm0808_test.c

Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
---
M tests/gsm0808/gsm0808_test.c
1 file changed, 62 insertions(+), 31 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/12271/1

diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index 63b8720..a31e7d4 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -116,7 +116,8 @@
msgb_v_put(in_msg, 0x23);

msg = gsm0808_create_layer3_2(in_msg, , NULL);
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();
msgb_free(msg);
msgb_free(in_msg);
 }
@@ -152,7 +153,8 @@

msg = gsm0808_create_layer3_2(in_msg, , _list);

-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();

msgb_free(msg);
msgb_free(in_msg);
@@ -165,7 +167,8 @@

printf("Testing creating Reset\n");
msg = gsm0808_create_reset();
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();
msgb_free(msg);
 }
 
@@ -176,7 +179,8 @@

printf("Testing creating Reset Ack\n");
msg = gsm0808_create_reset_ack();
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();
msgb_free(msg);
 }

@@ -188,7 +192,8 @@

printf("Testing creating Clear Command\n");
msg = gsm0808_create_clear_command(0x23);
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();
msgb_free(msg);
 }

@@ -199,7 +204,8 @@

printf("Testing creating Clear Complete\n");
msg = gsm0808_create_clear_complete();
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();
msgb_free(msg);
 }

@@ -234,12 +240,14 @@
printf("Testing creating Chipher Mode Command\n");
msg = gsm0808_create_cipher(, NULL);
OSMO_ASSERT(msg);
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+ abort();
msgb_free(msg);

msg = gsm0808_create_cipher(, _imeisv);
OSMO_ASSERT(msg);
-   VERIFY(msg, res2, ARRAY_SIZE(res2));
+   if (!msgb_eq_l3_data_print(msg, res2, ARRAY_SIZE(res2)))
+ abort();
msgb_free(msg);
 }

@@ -259,19 +267,22 @@

/* with l3 data */
msg = gsm0808_create_cipher_complete(l3, 4);
-   VERIFY(msg, res1, ARRAY_SIZE(res1));
+   if (!msgb_eq_l3_data_print(msg, res1, ARRAY_SIZE(res1)))
+   abort();
msgb_free(msg);

/* with l3 data but short */
l3->len -= 1;
l3->tail -= 1;
msg = gsm0808_create_cipher_complete(l3, 4);
-   VERIFY(msg, res2, ARRAY_SIZE(res2));
+   if (!msgb_eq_l3_data_print(msg, res2, ARRAY_SIZE(res2)))
+   abort();
msgb_free(msg);

/* without l3 data */
msg = gsm0808_create_cipher_complete(NULL, 4);
-   VERIFY(msg, res2, ARRAY_SIZE(res2));
+   if (!msgb_eq_l3_data_print(msg, res2, ARRAY_SIZE(res2)))
+   abort();
msgb_free(msg);


@@ -308,7 +319,8 @@

printf("Testing creating Cipher Reject\n");
msg = gsm0808_create_cipher_reject(cause);
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();

parse_cipher_reject(msg, cause);

@@ -323,7 +335,8 @@

printf("Testing creating Cipher Reject (extended)\n");
msg = gsm0808_create_cipher_reject_ext(GSM0808_CAUSE_CLASS_INVAL, 
cause);
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();

parse_cipher_reject(msg, cause);

@@ -342,12 +355,14 @@

printf("Testing creating CM U\n");
msg = gsm0808_create_classmark_update(, 1, , 1);
-   VERIFY(msg, res, ARRAY_SIZE(res));
+   if (!msgb_eq_l3_data_print(msg, res, ARRAY_SIZE(res)))
+   abort();

msgb_free(msg);

msg = gsm0808_create_classmark_update(, 1, NULL, 0);
-   VERIFY(msg, res2o, ARRAY_SIZE(res2o));
+   if (!msgb_eq_l3_data_print(msg, res2o, 

Change in osmo-mgw[master]: drop/replace very weird logging in mgcp_client.c

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12269 )

Change subject: drop/replace very weird logging in mgcp_client.c
..


Patch Set 1: Code-Review+1

Leaving +2 until dexter has a look at it.


--
To view, visit https://gerrit.osmocom.org/12269
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6877ed7fd7dbe009b2ece8792d5160d040c1aaa
Gerrit-Change-Number: 12269
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:55:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: add to osmo_sock_get_name*() API

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12268 )

Change subject: add to osmo_sock_get_name*() API
..


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h
File include/osmocom/core/socket.h:

https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h@63
PS1, Line 63: const char *osmo_sock_get_name2(int fd);
what about osmo_sock_get_name_static()?


https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h@64
PS1, Line 64: int osmo_sock_get_name2_buf(char *str, size_t str_len, int fd);
no need to have a 2 here.


https://gerrit.osmocom.org/#/c/12268/1/src/socket.c
File src/socket.c:

https://gerrit.osmocom.org/#/c/12268/1/src/socket.c@796
PS1, Line 796:  *  \param[out] str  Destination string buffer.
2 whitespace here and in next line.



--
To view, visit https://gerrit.osmocom.org/12268
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad89ac447c9c582742e70d082072bdd40a5a398
Gerrit-Change-Number: 12268
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:49:09 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 )

Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..


Patch Set 18:

(1 comment)

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c@586
PS4, Line 586: {
No need to be bitter about it: it's not the first time people disagree with you 
(or me, or Pau...) nor the last.

> you dismiss a sound argument
If you find it sound it doesn't mean others would automatically share your 
opinion.

Here're some more details since you insist:

> memset() is the byte hacking way and I don't like it...
It's a standard function and your liking/disliking it is irrelevant and hardly 
a sound argument.

> just 'var = {0}' doesn't work you need to supply the type name to the 
> compiler (unless it is a new variable declaration init...
Irrelevant in this case because "it's a new variable declaration init".

> the struct variable is part of ran_conn...
Irrelevant again - it's standalone struct which we initialize entirely.

> to write "{0}" means that I indicate the first item's value to be zero...
The only part of your link which is actually applicable to the code you're 
commenting on. Yes, initializing via {} is equivalent to {0} precisely because 
{} initialize entire thing with 0 and { x } initialize first byte with x and 
the rest with 0. And yes, it's "more general" if you will. But nobody have 
argued with those points to begin with. My point was (and still is) that it's 
easier to read the code because the 0 immediately reminds you how the rest is 
initialized. That's also seems to be preferred variant in libosmocore so far 
according to git grep.



--
To view, visit https://gerrit.osmocom.org/12020
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d
Gerrit-Change-Number: 12020
Gerrit-PatchSet: 18
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:46:30 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: check_rtp: on IP:port errors, log the IP and port

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12265 )

Change subject: check_rtp: on IP:port errors, log the IP and port
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12265
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e98d464a27038904797c5c10735a98ef5b7b9c3
Gerrit-Change-Number: 12265
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:35:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12020 )

Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c@586
PS4, Line 586:  struct gsm29205_gcr g = { .net_len = 3, .node = 0xDEAD }, p = { 
0 };
> Pretty poor show, guys, how you dismiss a sound argument by not naming 
> sources nor examples (Pau) an […]
You could call your show about answering one week later poor too, I may have 
remembered better what I read and could more easily provide more feedback, and 
I already lost too much time with this detail, I don't want to spend it a 
second time trying to find the exact commit and web page with the information.



--
To view, visit https://gerrit.osmocom.org/12020
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d
Gerrit-Change-Number: 12020
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:33:39 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Re: build slave segfaults

[Pau Espin Pedrol]

There's no much we can do about that other than opening an OBS bug 
report. It's a segfault in either bash or libtool, so not related to us. 
It could be a bug in bash/libtool or even on the virtualization layer 
being used by OBS to run containers.


Regards,
Pau

--
- Pau Espin Pedrol  http://www.sysmocom.de/
===
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12020 )

Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..


Patch Set 18:

(1 comment)

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c@586
PS4, Line 586: {
> Since the opinions differ I'd rather keep the code as it is because I find it 
> easier to read. […]
Pretty poor show, guys, how you dismiss a sound argument by not naming sources 
nor examples (Pau) and not even mentioning why it is not convincing (Max). If 
you declare the argument closed, then have something to show for it besides "I 
once read somewhere" and "nah you know, mh-nah". It makes me not want to spend 
time on your code.

I'm going to let this one go because it's just a zero, but next time please be 
a little more considerate.



--
To view, visit https://gerrit.osmocom.org/12020
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d
Gerrit-Change-Number: 12020
Gerrit-PatchSet: 18
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:14:34 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG@12
PS1, Line 12: have to be the same as for WAIT_SUB_PRES, i.e. also 
WAIT_IMEI_TMSI and
> Don't you mean WAIT_IMEI_TMSI (IMEI, not IEMI)? :-P
now you're confusing me! There is no IEMI, is there?? if you carry on I will 
write WAUT_UNEU_UNSU



--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:37:10 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

[Neels Hofmeyr]

Neels Hofmeyr has removed a vote on this change.

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Removed Code-Review+1 by Neels Hofmeyr 
--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 2: Code-Review+1

trying out whether we have +3 now...


--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:34:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12266 )

Change subject: vty: show subscriber: put() before printing the use count
..


Patch Set 1:

> looks a bit like a hack and rely on not-really-always-guaranteed-behavior.  I 
> guess the cleaner way would be to tell the printing function to subtract one..

I thought about that, but then also the 'show subscriber cache' iterates 
subscribers without get()ting them. And, since this is not multithreaded, there 
actually is no way how a subscriber can exist before this invocation and then 
be discarded by the put(). By definition we only find subscribers with a use 
count initially >= 1, and this count cannot decrease externally while the vty 
command is running. right?

Instead, printing a use count that is not actually there is IMHO the hacky 
solution. Thinking if we might at some point add a used-by bitflag like for 
ran_conn, then we'd have to hack around in that, too...

I guess the least hacky is to always get() and put() and expect a use count of 
2 on the vty output. Yet ... the 
single-threaded-there-is-no-way-to-lose-the-vsub argument makes sense to me. 
Further opinions welcome...


--
To view, visit https://gerrit.osmocom.org/12266
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id02b57b7ed299b010b9f8b9e809548eb1e6aa699
Gerrit-Change-Number: 12266
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:33:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: log: by default start with all categories on LOGL_NOTICE

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12267 )

Change subject: log: by default start with all categories on LOGL_NOTICE
..


Patch Set 1: Code-Review+2

please consider this for other osmo-* projects, too.


--
To view, visit https://gerrit.osmocom.org/12267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b46e9107a7a1d81a44d2a2eb855c10960a1ab6b
Gerrit-Change-Number: 12267
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:09:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12266 )

Change subject: vty: show subscriber: put() before printing the use count
..


Patch Set 1:

looks a bit like a hack and rely on not-really-always-guaranteed-behavior.  I 
guess the cleaner way would be to tell the printing function to subtract one..


--
To view, visit https://gerrit.osmocom.org/12266
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id02b57b7ed299b010b9f8b9e809548eb1e6aa699
Gerrit-Change-Number: 12266
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:08:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12243/1/src/gprs/sgsn_vty.c
File src/gprs/sgsn_vty.c:

https://gerrit.osmocom.org/#/c/12243/1/src/gprs/sgsn_vty.c@1376
PS1, Line 1376: install_element(SGSN_NODE, _sgsn_ipa_name_cmd);
kind of a weird spot to put it, right in the middle of the ggsn cfg :) better 
fit is below with the gsup stuff



--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:07:50 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 1:

actually, the same applies to the osmo-msc patch.

Please add 'no ipa-name'


--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:05:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

build slave segfaults

[Neels Hofmeyr]

I see sporadic segfaults during jenkins builds every now and then...
Let's keep an eye on it.

This one built on build2-deb9build-ansible

~N

On Wed, Dec 12, 2018 at 12:52:59AM +, jenk...@lists.osmocom.org wrote:
> See 
> 
> 
...
>   CC   auth_milenage.lo
> /bin/bash: line 2:  6091 Segmentation fault  (core dumped) /bin/bash 
> ../../libtool --silent --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. 
> -I../.. -I../../include -I../../include -I/usr/include/p11-kit-1 
> -DBUILDING_LIBOSMOCORE -Wall -Wall -g -O2 -DBUILDING_LIBOSMOCORE -Wall -MT 
> auth_milenage.lo -MD -MP -MF $depbase.Tpo -c -o auth_milenage.lo 
> auth_milenage.c
> make[3]: *** [auth_milenage.lo] Error 139
> Makefile:582: recipe for target 'auth_milenage.lo' failed
> make[3]: *** Waiting for unfinished jobs
> make[3]: Leaving directory '/build/deps/libosmocore/src/gsm'


signature.asc
Description: PGP signature

Change in openbsc[master]: CTRL: remove boilerplate

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/1576 )

Change subject: CTRL: remove boilerplate
..


Patch Set 5:

> Easiest to get rid of them is to just "Reply", so bear with me

You mean you've saved yourself 2 mouse clicks to publish instead of discard? In 
future, please try to choose slightly less easy solution to avoid spamming 
people - clicking couple of times is hardly a backbreaking effort.


--
To view, visit https://gerrit.osmocom.org/1576
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bcea0b4f4b8f535bef2b423f2013b8b4a218b5b
Gerrit-Change-Number: 1576
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 12 Dec 2018 10:06:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: No