Build failed in Jenkins: master-simtrace2 » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #263

[jenkins]

See 


--
[...truncated 21.08 KB...]
 /usr/bin/install -c -m 644  osmocom/gprs/gprs_bssgp.h 
osmocom/gprs/gprs_bssgp_bss.h osmocom/gprs/gprs_msgb.h osmocom/gprs/gprs_ns.h 
osmocom/gprs/gprs_ns_frgre.h osmocom/gprs/gprs_rlc.h 
'
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644  osmocom/crypt/auth.h osmocom/crypt/gprs_cipher.h 
'
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644  osmocom/ctrl/control_cmd.h 
osmocom/ctrl/control_if.h osmocom/ctrl/ports.h osmocom/ctrl/control_vty.h 
'
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644  osmocom/gprs/protocol/gsm_04_60.h 
osmocom/gprs/protocol/gsm_08_16.h osmocom/gprs/protocol/gsm_08_18.h 
'
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644  osmocom/codec/ecu.h osmocom/codec/codec.h 
osmocom/codec/gsm610_bits.h 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in src
make[2]: Entering directory 
'
  GEN  crc8gen.c
  GEN  crc16gen.c
  GEN  crc32gen.c
  GEN  crc64gen.c
make  install-am
make[3]: Entering directory 
'
  CC   timer.lo
  CC   timer_gettimeofday.lo
  CC   timer_clockgettime.lo
  CC   select.lo
  CC   signal.lo
  CC   bits.lo
  CC   bitvec.lo
  CC   msgb.lo
  CC   bitcomp.lo
  CC   counter.lo
  CC   fsm.lo
  CC   write_queue.lo
  CC   utils.lo
  CC   socket.lo
  CC   logging.lo
  CC   logging_syslog.lo
  CC   logging_gsmtap.lo
  CC   rate_ctr.lo
  CC   gsmtap_util.lo
  CC   crc16.lo
  CC   panic.lo
  CC   backtrace.lo
  CC   conv.lo
  CC   application.lo
  CC   rbtree.lo
  CC   loggingrb.lo
  CC   strrb.lo
  CC   crc8gen.lo
  CC   crc16gen.lo
  CC   crc32gen.lo
  CC   crc64gen.lo
  CC   macaddr.lo
  CC   stat_item.lo
  CC   stats.lo
  CC   stats_statsd.lo
  CC   prim.lo
  CC   conv_acc.lo
  CC   conv_acc_generic.lo
  CC   sercomm.lo
  CC   prbs.lo
  CC   isdnhdlc.lo
  CC   conv_acc_sse.lo
  CC   conv_acc_sse_avx.lo
  CC   plugin.lo
  CC   msgfile.lo
  CC   serial.lo
  CCLD libosmocore.la
make[4]: Entering directory 
'
make[4]: Noth

Jenkins build is back to normal : master-libosmocore » a2=default,a3=default,a4=default,amd64,osmocom-master-debian9 #723

[jenkins]

See 

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #836

[jenkins]

See 


Changes:

[tnt] tests: Rework the convolve_test

[tnt] tests: Re-enable the convolve_test by default

--
[...truncated 107.07 KB...]
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

 /usr/bin/install -c -m 644 ../README 
'
cp -r html 

make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Ent

Change in osmo-trx[master]: tests: Re-enable the convolve_test by default

[tnt]

tnt has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12418 )

Change subject: tests: Re-enable the convolve_test by default
..

tests: Re-enable the convolve_test by default

Change-Id: Ia26ef75bb11482fc0db3b790db1c93c8b74229d1
Signed-off-by: Sylvain Munaut 
---
M tests/testsuite.at
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/tests/testsuite.at b/tests/testsuite.at
index 22de782..f83ac65 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -52,8 +52,6 @@

 AT_SETUP([convolve_test])
 AT_KEYWORDS([convolve_test])
-# Different results for i686, x86_64 and ARM. see  OS#2826, OS#2828, and 
https://lists.osmocom.org/pipermail/openbsc/2018-January/011655.html
-AT_SKIP_IF(true)
 cat $abs_srcdir/Transceiver52M/convolve_test.ok > expout
 AT_CHECK([$abs_top_builddir/tests/Transceiver52M/convolve_test], [], [expout], 
[])
 AT_CLEANUP

--
To view, visit https://gerrit.osmocom.org/12418
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26ef75bb11482fc0db3b790db1c93c8b74229d1
Gerrit-Change-Number: 12418
Gerrit-PatchSet: 6
Gerrit-Owner: tnt 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: tnt 

Change in osmo-msc[master]: Various logging fixes

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12615 )

Change subject: Various logging fixes
..

Various logging fixes

Log transaction allocation errors as such. While at it, use proper
subsystem to log missing VLR subscriber.

Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
---
M src/libmsc/gsm_04_08_cc.c
M src/libmsc/gsm_09_11.c
M src/libmsc/transaction.c
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 7172184..0119e7b 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -1931,7 +1931,7 @@
/* Create transaction */
trans = trans_alloc(net, vsub, GSM48_PDISC_CC, 0xff, 
data->callref);
if (!trans) {
-   DEBUGP(DCC, "No memory for trans.\n");
+   LOGP(DCC, LOGL_ERROR, "No memory for trans.\n");
vlr_subscr_put(vsub);
/* Ressource unavailable */
mncc_release_ind(net, NULL, data->callref,
@@ -2129,7 +2129,7 @@
GSM48_PDISC_CC,
transaction_id, new_callref++);
if (!trans) {
-   DEBUGP(DCC, "No memory for trans.\n");
+   LOGP(DCC, LOGL_ERROR, "No memory for trans.\n");
rc = gsm48_tx_simple(conn,
 GSM48_PDISC_CC | (transaction_id 
<< 4),
 GSM48_MT_CC_RELEASE_COMPL);
diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c
index 12bec9d..608d4ff 100644
--- a/src/libmsc/gsm_09_11.c
+++ b/src/libmsc/gsm_09_11.c
@@ -101,7 +101,7 @@
trans = trans_alloc(conn->network, conn->vsub,
GSM48_PDISC_NC_SS, tid, new_callref++);
if (!trans) {
-   DEBUGP(DMM, " -> No memory for trans\n");
+   LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n");
gsm48_tx_simple(conn,
GSM48_PDISC_NC_SS | (tid << 4),
GSM0480_MTYPE_RELEASE_COMPLETE);
@@ -298,7 +298,7 @@
trans = trans_alloc(net, vsub, GSM48_PDISC_NC_SS,
0xff, gsup_msg->session_id);
if (!trans) {
-   DEBUGP(DMM, " -> No memory for trans\n");
+   LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n");
return NULL;
}

diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c
index df770ed..17f8e96 100644
--- a/src/libmsc/transaction.c
+++ b/src/libmsc/transaction.c
@@ -109,7 +109,7 @@

/* a valid subscriber is indispensable */
if (vsub == NULL) {
-   LOGP(DCC, LOGL_NOTICE,
+   LOGP(DVLR, LOGL_ERROR,
 "unable to alloc transaction, invalid subscriber 
(NULL)\n");
return NULL;
}

--
To view, visit https://gerrit.osmocom.org/12615
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
Gerrit-Change-Number: 12615
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 

Change in openbsc[master]: Remove meas_* utils

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12655 )

Change subject: Remove meas_* utils
..

Remove meas_* utils

The counterparts in OsmoBSC repo are actively maintained and (partially) 
packaged
for .deb - let's drop old versions to minimize user confusion.

Change-Id: Ia0cedaad4b717c8c5198842e2acd610f8e03f957
---
M openbsc/src/utils/Makefile.am
D openbsc/src/utils/meas_db.c
D openbsc/src/utils/meas_db.h
D openbsc/src/utils/meas_json.c
D openbsc/src/utils/meas_pcap2db.c
D openbsc/src/utils/meas_udp2db.c
D openbsc/src/utils/meas_vis.c
7 files changed, 0 insertions(+), 1,199 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/utils/Makefile.am b/openbsc/src/utils/Makefile.am
index 26494e1..76a73a3 100644
--- a/openbsc/src/utils/Makefile.am
+++ b/openbsc/src/utils/Makefile.am
@@ -18,30 +18,10 @@
$(COVERAGE_LDFLAGS) \
$(NULL)

-noinst_HEADERS = \
-   meas_db.h \
-   $(NULL)
-
 bin_PROGRAMS = \
bs11_config \
isdnsync \
-   meas_json \
$(NULL)
-if HAVE_SQLITE3
-bin_PROGRAMS += \
-   osmo-meas-udp2db \
-   $(NULL)
-if HAVE_PCAP
-bin_PROGRAMS += \
-   osmo-meas-pcap2db \
-   $(NULL)
-endif
-endif
-if HAVE_LIBCDK
-bin_PROGRAMS += \
-   meas_vis \
-   $(NULL)
-endif

 if BUILD_SMPP
 noinst_PROGRAMS = \
@@ -77,71 +57,3 @@
$(LIBOSMOGSM_LIBS) \
$(LIBSMPP34_LIBS) \
$(NULL)
-
-meas_vis_SOURCES = \
-   meas_vis.c \
-   $(NULL)
-
-meas_vis_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   -lcdk \
-   -lncurses \
-   $(NULL)
-
-meas_vis_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(NULL)
-
-osmo_meas_pcap2db_SOURCES = \
-   meas_pcap2db.c \
-   meas_db.c \
-   $(NULL)
-
-osmo_meas_pcap2db_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(SQLITE3_LIBS) \
-   -lpcap \
-   $(NULL)
-
-osmo_meas_pcap2db_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOABIS_CFLAGS) \
-   $(NULL)
-
-osmo_meas_udp2db_SOURCES = \
-   meas_udp2db.c \
-   meas_db.c \
-   $(NULL)
-
-osmo_meas_udp2db_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(SQLITE3_LIBS) \
-   $(NULL)
-
-osmo_meas_udp2db_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOABIS_CFLAGS) \
-   $(NULL)
-
-meas_json_SOURCES = \
-   meas_json.c \
-   $(NULL)
-
-meas_json_LDADD = \
-   $(top_builddir)/src/libcommon/libcommon.a \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(NULL)
-
-meas_json_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOABIS_CFLAGS) \
-   $(NULL)
-
diff --git a/openbsc/src/utils/meas_db.c b/openbsc/src/utils/meas_db.c
deleted file mode 100644
index d81efca..000
--- a/openbsc/src/utils/meas_db.c
+++ /dev/null
@@ -1,330 +0,0 @@
-/* Routines for storing measurement reports in SQLite3 database */
-
-/* (C) 2012 by Harald Welte 
- *
- * All Rights Reserved
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see .
- *
- */
-
-#include 
-#include 
-#include 
-
-#include 
-
-#include 
-#include 
-#include 
-#include 
-
-#include "meas_db.h"
-
-#define INS_MR "INSERT INTO meas_rep (time, imsi, name, scenario, nr, 
bs_power, ms_timing_offset, fpc, ms_l1_pwr, ms_l1_ta) VALUES 
(?,?,?,?,?,?,?,?,?,?)"
-#define INS_UD "INSERT INTO meas_rep_unidir (meas_id, rx_lev_full, rx_lev_sub, 
rx_qual_full, rx_qual_sub, dtx, uplink) VALUES (?,?,?,?,?,?,?)"
-#define UPD_MR "UPDATE meas_rep SET ul_unidir=?, dl_unidir=? WHERE id=?"
-
-struct meas_db_state {
-   sqlite3 *db;
-   sqlite3_stmt *stmt_ins_ud;
-   sqlite3_stmt *stmt_ins_mr;
-   sqlite3_stmt *stmt_upd_mr;
-};
-
-/* macros to check for SQLite3 result codes */
-#define _SCK_OK(db, call, exp) \
-   do {\
-   int rc = call;  \
-   if (rc != exp) {\
-   fprintf(stderr,"SQL Error in line %u: %s\n",\
-   

Change in openbsc[master]: Remove osmocom-ipaccess-utils-dbg package

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12657 )

Change subject: Remove osmocom-ipaccess-utils-dbg package
..

Remove osmocom-ipaccess-utils-dbg package

The rest was dropped in I9c04f9b469e60802461a2a6e421d3ba27e6dafa1.

Change-Id: If56c288121bd26fead9a921c1f04f9958468e1b6
---
M debian/control
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/control b/debian/control
index a78ff3e..557467e 100644
--- a/debian/control
+++ b/debian/control
@@ -85,14 +85,6 @@
 Description: Debug symbols for the OpenBSC NITB
  Make debugging possible

-Package: osmocom-ipaccess-utils-dbg
-Architecture: any
-Section: debug
-Priority: extra
-Depends: osmocom-ipaccess-utils (= ${binary:Version}), ${misc:Depends}
-Description: Debug symbols for the OpenBSC ip.access utils
- Make debugging possible
-
 Package: osmocom-bs11-utils-dbg
 Architecture: any
 Section: debug

--
To view, visit https://gerrit.osmocom.org/12657
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If56c288121bd26fead9a921c1f04f9958468e1b6
Gerrit-Change-Number: 12657
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in openbsc[master]: Remove openbsc-dev package

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12656 )

Change subject: Remove openbsc-dev package
..

Remove openbsc-dev package

There're no external utilities which rely on it anymore so we can
simplify our packaging by removing it.

Change-Id: I9a96c217999416099aa7ce690845f56fc132274c
---
M debian/control
D debian/openbsc-dev.install
M openbsc/Makefile.am
M openbsc/configure.ac
D openbsc/openbsc.pc.in
5 files changed, 0 insertions(+), 28 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/control b/debian/control
index a841acf..a78ff3e 100644
--- a/debian/control
+++ b/debian/control
@@ -69,17 +69,6 @@
  ${misc:Depends}
 Description: OsmoBSC-MGCP: Osmocom's Legacy Media Gateway.

-Package: openbsc-dev
-Architecture: all
-Depends: ${misc:Depends}
-Description: Header file needed by tools tightly integrated
- Some other programs depend on gsm_data_shared.h and gsm_data_shared.c
- from OpenBSC. This package installs these files to your file system so
- that the other packages can build-depend on this package.
- .
- The directory structure is copied after the structure in the repository
- and the header and .c file are installed into /usr/src/osmocom/openbsc/.
-
 Package: osmocom-bsc-sccplite-dbg
 Architecture: any
 Section: debug
diff --git a/debian/openbsc-dev.install b/debian/openbsc-dev.install
deleted file mode 100644
index b669b0f..000
--- a/debian/openbsc-dev.install
+++ /dev/null
@@ -1,3 +0,0 @@
-openbsc/include/openbsc/gsm_data_shared.h 
usr/src/osmocom/openbsc/openbsc/include/openbsc/
-openbsc/src/libcommon/gsm_data_shared.c 
usr/src/osmocom/openbsc/openbsc/src/libcommon/
-usr/lib/*/pkgconfig/openbsc.pc
diff --git a/openbsc/Makefile.am b/openbsc/Makefile.am
index 1b1..f42e6d0 100644
--- a/openbsc/Makefile.am
+++ b/openbsc/Makefile.am
@@ -16,9 +16,6 @@
contrib \
$(NULL)

-pkgconfigdir = $(libdir)/pkgconfig
-pkgconfig_DATA = openbsc.pc
-
 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen osmoappdesc.py .version

diff --git a/openbsc/configure.ac b/openbsc/configure.ac
index 64285e0..109bad8 100644
--- a/openbsc/configure.ac
+++ b/openbsc/configure.ac
@@ -243,7 +243,6 @@
 AM_CONFIG_HEADER(bscconfig.h)

 AC_OUTPUT(
-openbsc.pc
 include/openbsc/Makefile
 include/Makefile
 src/Makefile
diff --git a/openbsc/openbsc.pc.in b/openbsc/openbsc.pc.in
deleted file mode 100644
index 17e265d..000
--- a/openbsc/openbsc.pc.in
+++ /dev/null
@@ -1,10 +0,0 @@
-prefix=@prefix@
-exec_prefix=@exec_prefix@
-libdir=@libdir@
-includedir=@includedir@/
-
-Name: OpenBSC
-Description: OpenBSC base station controller
-Requires:
-Version: @VERSION@
-Cflags: -I${includedir}

--
To view, visit https://gerrit.osmocom.org/12656
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a96c217999416099aa7ce690845f56fc132274c
Gerrit-Change-Number: 12656
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in libosmocore[master]: osmo_fsm_state_name: make robust against NULL fi

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12670 )

Change subject: osmo_fsm_state_name: make robust against NULL fi
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
Gerrit-Change-Number: 12670
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:26:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: add osmo_hexdump_b(), osmo_hexdump_nospc_b()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12671 )

Change subject: add osmo_hexdump_b(), osmo_hexdump_nospc_b()
..


Patch Set 2:

I am not a friend of those functions.  In the end, we will have "second static 
buffer" versions of all of our functions, and megabytes of static buffers.  I 
think if it's needed twice in one "printf" statement, the caller will simply 
use the _buf() variant and put the buffer on the local stack of the caller.


--
To view, visit https://gerrit.osmocom.org/12671
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia48fc6b984f06b972a6846b173b8cf8d30737460
Gerrit-Change-Number: 12671
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:26:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: add osmo_hexdump_buf() and test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12658 )

Change subject: add osmo_hexdump_buf() and test
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12658
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I590595567b218b24e53c9eb1fd8736c0324d371d
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 6
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:25:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 11: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 11
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:24:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..

common: extend glossary.adoc

Add EIR, IMEISV, LU, SS, TS, USSD, and VLR, clarify the difference
between IMEI and IMEISV.

Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
---
M common/chapters/glossary.adoc
1 file changed, 23 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/common/chapters/glossary.adoc b/common/chapters/glossary.adoc
index 74973b3..e8fed3c 100644
--- a/common/chapters/glossary.adoc
+++ b/common/chapters/glossary.adoc
@@ -85,6 +85,9 @@
   GPRS; introduces 8PSK
 EGPRS::
   Enhanced GPRS; the part of EDGE relating to GPRS services
+EIR::
+  Equipment Identity Register; core network element that stores and manages
+  IMEI numbers
 ESME::
   External SMS Entity; an external application interfacing with a SMSC
   over SMPP
@@ -128,7 +131,11 @@
 IE::
   Information Element
 IMEI::
-  International Mobile Equipment Identity; unique identifier for the mobile 
phone
+  International Mobile Equipment Identity; unique 14-digit decimal number to
+  globally identify a mobile device, optionally with a 15th checksum digit
+IMEISV::
+  IMEI software version; unique 14-digit decimal number to globally identify a
+  mobile device (same as IMEI) plus two software version digits (total digits: 
16)
 IMSI::
   International Mobile Subscriber Identity; 15-digit unique identifier
   for the subscriber/SIM; starts with MCC/MNC of issuing operator
@@ -147,6 +154,9 @@
   44.064_ <<3gpp-ts-44-064>>)
 Location Area::
   Location Area; a geographic area containing multiple BTS
+LU::
+  Location Updating; can be of type IMSI-Attach or Periodic. Procedure that
+  indicates a subscriber's physical presence in a given radio cell.
 M2PA::
   MTP2 Peer-to-Peer Adaptation; a SIGTRAN Variant (_RFC 4165_ <>)
 M2UA::
@@ -284,6 +294,10 @@
   Short Message Service Center; store-and-forward relay for short messages
 SS7::
   Signaling System No. 7; Classic digital telephony signaling system
+SS::
+  Supplementary Services; query and set various service parameters between
+  subscriber and core network (e.g. USSD, 3rd-party calls, hold/retrieve,
+  advice-of-charge, call deflection)
 SSH::
   Secure Shell; _IETF RFC 4250_ <> to 4254
 SSN::
@@ -306,6 +320,8 @@
   Trivial File Transfer Protocol; (_IETF RFC 1350_ <>)
 TRX::
   Transceiver; element of a BTS serving a single carrier
+TS::
+  Technical Specification
 u-Boot::
   Boot loader used in various embedded systems
 UBI::
@@ -324,10 +340,16 @@
 USIM::
   Universal Subscriber Identity Module; application running on a UICC
   to provide subscriber identity for UMTS and GSM networks
+USSD::
+  Unstructured Supplementary Service Data; textual dialog between subscriber
+  and core network, e.g. '*#100#' -> 'Your extension is 1234'
 VCTCXO::
   Voltage Controlled, Temperature Compensated Crystal Oscillator;  a
   precision oscillator, superior to a classic crystal oscillator, but
   inferior to an OCXO
+VLR::
+  Visitor Location Register; volatile storage of attached subscribers in
+  the MSC
 VPLMN::
   Visited PLMN; the network in which the subscriber is currently
   registered; may differ from HPLMN when on roaming

--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:23:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: tests: Rework the convolve_test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12416 )

Change subject: tests: Rework the convolve_test
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12416
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e203d2c4b778af77d630ed15d4cef6b0c0eb76d
Gerrit-Change-Number: 12416
Gerrit-PatchSet: 5
Gerrit-Owner: tnt 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:22:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: Remove meas_* utils

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12655 )

Change subject: Remove meas_* utils
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12655
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0cedaad4b717c8c5198842e2acd610f8e03f957
Gerrit-Change-Number: 12655
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:21:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: Remove osmocom-ipaccess-utils-dbg package

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12657 )

Change subject: Remove osmocom-ipaccess-utils-dbg package
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12657
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If56c288121bd26fead9a921c1f04f9958468e1b6
Gerrit-Change-Number: 12657
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:21:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: Remove openbsc-dev package

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12656 )

Change subject: Remove openbsc-dev package
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12656
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a96c217999416099aa7ce690845f56fc132274c
Gerrit-Change-Number: 12656
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:21:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Various logging fixes

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12615 )

Change subject: Various logging fixes
..


Patch Set 2: Code-Review+2

(giving +2 as Vadim already gave +1)


--
To view, visit https://gerrit.osmocom.org/12615
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
Gerrit-Change-Number: 12615
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:58:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in gr-gsm[master]: MacOS fixes

[Vasil Velichkov]

Vasil Velichkov has uploaded this change for review. ( 
https://gerrit.osmocom.org/12692


Change subject: MacOS fixes
..

MacOS fixes

- Include grgsm/endian.h in tch_h_decoder_impl.cc
- Revert 0ed39fbf9340bdfb254bec5e3b94d9f00cf9d151 as linking with
  boost_thread is needed

Fixes GH-444

Change-Id: I00884962295082cff3eb64fa21e9f73437be0001
---
M CMakeLists.txt
M lib/decoding/tch_h_decoder_impl.cc
2 files changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/92/12692/1

diff --git a/CMakeLists.txt b/CMakeLists.txt
index d539b24..27a3df7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -88,7 +88,7 @@
 "1.60.0" "1.60" "1.61.0" "1.61" "1.62.0" "1.62" "1.63.0" "1.63" "1.64.0" 
"1.64"
 "1.65.0" "1.65" "1.66.0" "1.66" "1.67.0" "1.67" "1.68.0" "1.68" "1.69.0" 
"1.69"
 )
-find_package(Boost "1.35" COMPONENTS filesystem system)# thread)
+find_package(Boost "1.35" COMPONENTS filesystem system thread)

 if(NOT Boost_FOUND)
 message(FATAL_ERROR "Boost required to compile gr-gsm")
diff --git a/lib/decoding/tch_h_decoder_impl.cc 
b/lib/decoding/tch_h_decoder_impl.cc
index d2f29c7..11da907 100644
--- a/lib/decoding/tch_h_decoder_impl.cc
+++ b/lib/decoding/tch_h_decoder_impl.cc
@@ -25,6 +25,7 @@
 #endif

 #include 
+#include 
 #include "tch_h_decoder_impl.h"

 extern "C" {

--
To view, visit https://gerrit.osmocom.org/12692
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00884962295082cff3eb64fa21e9f73437be0001
Gerrit-Change-Number: 12692
Gerrit-PatchSet: 1
Gerrit-Owner: Vasil Velichkov 

Change in osmo-msc[master]: Various logging fixes

[Max]

Hello Stefan Sperling, Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, osmith, 
Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12615

to look at the new patch set (#2).

Change subject: Various logging fixes
..

Various logging fixes

Log transaction allocation errors as such. While at it, use proper
subsystem to log missing VLR subscriber.

Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
---
M src/libmsc/gsm_04_08_cc.c
M src/libmsc/gsm_09_11.c
M src/libmsc/transaction.c
3 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/15/12615/2
--
To view, visit https://gerrit.osmocom.org/12615
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
Gerrit-Change-Number: 12615
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 

Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12608 )

Change subject: Handle LCLS-NOTIFICATION message from BSS
..

Handle LCLS-NOTIFICATION message from BSS

Change-Id: Ibf5f9cad1f70aee56d5bca8fe09a24ca417e7a63
Related: OS#2487
---
M src/libmsc/a_iface_bssap.c
1 file changed, 25 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c
index 41af93c..cb245b8 100644
--- a/src/libmsc/a_iface_bssap.c
+++ b/src/libmsc/a_iface_bssap.c
@@ -585,6 +585,29 @@
return 0;
 }

+/* Handle incoming LCLS-NOTIFICATION BSSMAP message: 3GPP TS 48.008 §3.2.1.93 
*/
+static int bssmap_rx_lcls_notif(const struct ran_conn *conn, const struct msgb 
*msg, const struct tlv_parsed *tp)
+{
+
+   bool status_avail = TLVP_PRESENT(tp, GSM0808_IE_LCLS_BSS_STATUS),
+ break_avail = TLVP_PRESENT(tp, GSM0808_IE_LCLS_BREAK_REQ);
+
+   /* Either §3.2.2.119 LCLS-BSS-Status or §3.2.2.120 LCLS-Break-Request 
shall be present */
+   if (!(status_avail ^ break_avail)) {
+   LOGPCONN(conn, LOGL_ERROR, "Ignoring broken LCLS Notification 
message\n");
+   return -EINVAL;
+   }
+
+   if (status_avail)
+   LOGPCONN(conn, LOGL_NOTICE, "Received LCLS Status: %s\n",
+gsm0808_lcls_status_name(tlvp_val8(tp, 
GSM0808_IE_LCLS_BSS_STATUS, GSM0808_LCLS_STS_NA)));
+
+   if (break_avail)
+   LOGPCONN(conn, LOGL_NOTICE, "Received LCLS Break Request\n");
+
+   return 0;
+}
+
 /* Handle incoming connection oriented BSSMAP messages */
 static int rx_bssmap(struct osmo_sccp_user *scu, const struct a_conn_info 
*a_conn_info, struct msgb *msg)
 {
@@ -646,6 +669,8 @@
return bssmap_rx_sapi_n_rej(conn, msg, &tp);
case BSS_MAP_MSG_ASSIGMENT_COMPLETE:
return bssmap_rx_ass_compl(conn, msg, &tp);
+   case BSS_MAP_MSG_LCLS_NOTIFICATION:
+   return bssmap_rx_lcls_notif(conn, msg, &tp);
default:
LOGPCONN(conn, LOGL_ERROR, "Unimplemented msg type: %s\n", 
gsm0808_bssmap_name(msg_type));
return -EINVAL;

--
To view, visit https://gerrit.osmocom.org/12608
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5f9cad1f70aee56d5bca8fe09a24ca417e7a63
Gerrit-Change-Number: 12608
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Vadim Yanitskiy 

Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12608 )

Change subject: Handle LCLS-NOTIFICATION message from BSS
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12608
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5f9cad1f70aee56d5bca8fe09a24ca417e7a63
Gerrit-Change-Number: 12608
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:23:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-abis[master]: Set local IP in ipa_server_link properly

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12653 )

Change subject: Set local IP in ipa_server_link properly
..

Set local IP in ipa_server_link properly

When creating IPA link for server we might be called without explicit
address (which is legit - it means bind to all available
addresses). However in this case we won't have 'addr' field of
ipa_server_link initialized properly.

Fix this by following changes:

* don't copy NULL value as address
* use socket's local IP when no address set explicitly

Change-Id: I33679bb35f426d4cafb223b9200fccbf407e0cf6
---
M src/input/ipa.c
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/input/ipa.c b/src/input/ipa.c
index 09e3426..9853ffa 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -248,6 +248,7 @@
 static int ipa_server_fd_cb(struct osmo_fd *ofd, unsigned int what)
 {
int fd, ret;
+   char ipbuf[INET6_ADDRSTRLEN + 1];
struct sockaddr_in sa;
socklen_t sa_len = sizeof(sa);
struct ipa_server_link *link = ofd->data;
@@ -258,6 +259,13 @@
"peer, reason=`%s'\n", strerror(errno));
return fd;
}
+
+   if (!link->addr) {
+   ret = osmo_sock_get_local_ip(fd, ipbuf, INET6_ADDRSTRLEN + 1);
+   if (ret == 0)
+   link->addr = talloc_strdup(link, ipbuf);
+   }
+
LOGP(DLINP, LOGL_NOTICE, "accept()ed new link from %s to port %u\n",
inet_ntoa(sa.sin_addr), link->port);

@@ -290,7 +298,8 @@
ipa_link->ofd.when |= BSC_FD_READ | BSC_FD_WRITE;
ipa_link->ofd.cb = ipa_server_fd_cb;
ipa_link->ofd.data = ipa_link;
-   ipa_link->addr = talloc_strdup(ipa_link, addr);
+   if (addr)
+   ipa_link->addr = talloc_strdup(ipa_link, addr);
ipa_link->port = port;
ipa_link->accept_cb = accept_cb;
ipa_link->line = line;

--
To view, visit https://gerrit.osmocom.org/12653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I33679bb35f426d4cafb223b9200fccbf407e0cf6
Gerrit-Change-Number: 12653
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in libusrp[master]: Add config for git-review

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12691 )

Change subject: Add config for git-review
..


Patch Set 1:

I didn't know about git-review yet, nice!
https://docs.openstack.org/infra/git-review/usage.html


--
To view, visit https://gerrit.osmocom.org/12691
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29617f080af81921e4ee0f7a53eaae5ba2e3c30b
Gerrit-Change-Number: 12691
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:22:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-abis[master]: Set local IP in ipa_server_link properly

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12653 )

Change subject: Set local IP in ipa_server_link properly
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33679bb35f426d4cafb223b9200fccbf407e0cf6
Gerrit-Change-Number: 12653
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:21:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-abis[master]: Log peer's port in accept callback

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12654 )

Change subject: Log peer's port in accept callback
..


Patch Set 1:

It's great that you want to add useful information.  However, removing other 
useful information (like to which local port) is not good.  Thre are many 
interfaces that use IPA (Abis, SCCPlite, CTRL, GSUP, ...) and the local port 
number could help to determine which of those the message relates to.  Maybe 
use the full tuple and use osmo_sock_get_name2() instead?


--
To view, visit https://gerrit.osmocom.org/12654
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
Gerrit-Change-Number: 12654
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:20:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libusrp[master]: Add config for git-review

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12691 )

Change subject: Add config for git-review
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12691
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29617f080af81921e4ee0f7a53eaae5ba2e3c30b
Gerrit-Change-Number: 12691
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:19:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-asf4-dfu[master]: remove OCTSIM in USB ID

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12609 )

Change subject: remove OCTSIM in USB ID
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12609
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc46f0d8b4b649fd00b5c6cea5bad91a93891f14
Gerrit-Change-Number: 12609
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:15:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: VLR: use msgb_eq_data_print() for comparison

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12571 )

Change subject: VLR: use msgb_eq_data_print() for comparison
..


Patch Set 2: Code-Review+1

Change looks good to me.

I find this useful, and I can't see how having a multiline string logged here 
would be an issue. As Max said, it is only logged in case of error anyway. The 
code does look cleaner to me in the new version.

Old output:

 Mismatch! Expected:
 1401080971004026f0280102

New output:

 DLGLOBAL __wrap_osmo_gsup_client_send() L0 data mismatch:
 expected 14 01 08 09 71 00 00 00 40 26 f0 28 01 02
  !!
 msgb 04 01 08 09 71 00 00 00 40 26 f0 28 01 02


--
To view, visit https://gerrit.osmocom.org/12571
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:15:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12625/4//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12625/4//COMMIT_MSG@22
PS4, Line 22: Since the BSC currently only trys the first best codec/rate that 
is
I think it's "tries".



--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 24 Jan 2019 16:57:04 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/gsm_04_11.c: introduce and use gsm411_assign_sm_rp_mr()

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12628 )

Change subject: libmsc/gsm_04_11.c: introduce and use gsm411_assign_sm_rp_mr()
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife6d954c46b7d8348a4221ab677d0355eb3ee7ac
Gerrit-Change-Number: 12628
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 24 Jan 2019 16:59:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sip-connector[master]: Support Emergency Calling

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )

Change subject: Support Emergency Calling
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c@427
PS1, Line 427:  if (data->emergency) {
> data->called is invalid

I don't get it: if data->called is invalid than how can you set a number inside 
of it? Also, no code between goto and cont_setup seems to access data->called 
so I don't understand which of the checks below fails and why?



--
To view, visit https://gerrit.osmocom.org/12682
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1
Gerrit-Change-Number: 12682
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:03:52 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@377
PS4, Line 377:  if (lchan_type_compat_with_mode(conn->lchan->type, 
&req->ch_mode_rate_pref)) {
> -1: code dup: please implement this only once in a utility function, and call 
> it twice: once for the […]
mistake in my comment: should be

  if (!conn->assignment.new_lchan)

in both places



--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 24 Jan 2019 16:58:42 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 4: Code-Review-1

(11 comments)

my earlier higher level reservations are resolved, but now I did find low level 
problems:

https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@300
PS4, Line 300:  struct channel_mode_and_rate ch_mode_rate;
> put this in the user_plane scope?
this ^ should probably go inside the assignment{} scope instead, see other 
comments


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@304
PS4, Line 304: static int check_requires_voice_stream(struct 
gsm_subscriber_connection *conn)
-1: code dup: please write one function that takes a chan_mode as input and 
returns a requires_voice_stream bool, and call this function twice; once for 
the primary chan_mode and once for the alternate chan_mode.

-1: actually, the requires_voice_stream must be identical between first and 
alternate preference, right?

-1: it doesn't make sense to fail the assignment if only one of the choices is 
not supported.


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@377
PS4, Line 377:  if (lchan_type_compat_with_mode(conn->lchan->type, 
&req->ch_mode_rate_pref)) {
-1: code dup: please implement this only once in a utility function, and call 
it twice: once for the primary choice, and if that failed then for the alt_pref.

Below, I expect it to look something like this:

  if (check_for_existing_lchan(conn, &req->ch_mode_rate_pref)
  || check_for_existing_lchan(conn, &req->ch_mode_rate_alt)) {
  /* re-using existing lchan succeeded. Discard FSM instance, it is not 
needed. */
  osmo_fsm_inst_term(conn->assignment.fi);
  return;
  }

  check_new_lchan(conn, &req->ch_mode_rate_pref);
  if (!conn->lchan)
  check_new_lchan(conn, &req->ch_mode_rate_alt);
  if (!conn->lchan) {
  assignment_fail(No lchan available...);
  return;
  }


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@443
PS4, Line 443:  if (!conn->assignment.new_lchan && 
req->ch_mode_rate_alt_present) {
-1: code dup (same)


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@479
PS4, Line 479:  fi = osmo_fsm_inst_alloc_child(&assignment_fsm, conn->fi, 
GSCON_EV_ASSIGNMENT_END);
(FYI, I considered whether it is better to allocate the FSM instance only 
*after* we checked whether the current lchan is sufficient, but IMHO it makes 
more sense to allocate it and use it as logging context. Also this makes sure 
the ASSIGNMENT_END signal gets dispatched to the conn FSM, which we apparently 
also forget to do in the re-use case at the moment. Also FYI, the channel 
re-use code path is completely broken for many other reasons, see 
https://gerrit.osmocom.org/c/osmo-bsc/+/12401 )


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@495
PS4, Line 495:  if (check_for_existing_lchan(conn))
> ...maybe we can deallocate the assignment. […]
^ still valid, but don't worry about this one, see 
https://gerrit.osmocom.org/c/osmo-bsc/+/12401


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@501
PS4, Line 501:  conn->ch_mode_rate = req->ch_mode_rate_pref;
-1: the ch_mode_rate use must not be ambiguous: does it apply to the current 
conn->lchan or to the new assignment.new_lchan?

The point is that if the assignment fails for whatever reason, you must be able 
to just discard the assignment information and keep on using the previous lchan 
without having modified any other state of the conn.

So, instead of modifying the conn->ch_mode_rate, you must stay inside the 
conn->assignment.* scope.
Only when the new lchan gets accepted and moved from conn->assignment.new_lchan 
to conn->lchan is when the conn->ch_mode_rate is allowed to be modified.

Maybe it makes more sense to place ch_mode_rate into the lchan struct instead?
Or if it is only used during assignment negotiation, put it in the 
conn->assignment{} scope.


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@503
PS4, Line 503:  /* In case the lchan allocation fails, we try with the alternat
("alternate". use line width.)


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/osmo_bsc_bssap.c@609
PS4, Line 609: static int select_codec(struct assignment_request *req, struct 
gsm0808_channel_type *ct,
"select_codecs" ?


https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/osmo_bsc_bssap.c@632
PS4, Line 632:RATE_PREF_NONE);
(if fu

Change in libusrp[master]: Add config for git-review

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12691


Change subject: Add config for git-review
..

Add config for git-review

Change-Id: I29617f080af81921e4ee0f7a53eaae5ba2e3c30b
---
A .gitreview
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/91/12691/1

diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..7f120b8
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,3 @@
+[gerrit]
+host=gerrit.osmocom.org
+project=libusrp

--
To view, visit https://gerrit.osmocom.org/12691
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29617f080af81921e4ee0f7a53eaae5ba2e3c30b
Gerrit-Change-Number: 12691
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-msc[master]: Log transaction allocation errors as such

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12615 )

Change subject: Log transaction allocation errors as such
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12615/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12615/1//COMMIT_MSG@7
PS1, Line 7: Log transaction allocation errors as such
How about: "Various logging fixes" as title and writing the "Log transaction 
allocation errors as such." line into the description below?



--
To view, visit https://gerrit.osmocom.org/12615
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
Gerrit-Change-Number: 12615
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 16:47:28 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..


Patch Set 5:

Note: test failure doesn't seem to be related to the code change - I've created 
https://osmocom.org/issues/3766 to track it.


--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-CC: Tom Tsou 
Gerrit-CC: tnt 
Gerrit-Comment-Date: Thu, 24 Jan 2019 16:23:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Jenkins build is back to normal : master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #835

[jenkins]

See 

Change in osmo-bsc[master]: fix lchan modifications: switch off re-using lchan during assignment

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12401 )

Change subject: fix lchan modifications: switch off re-using lchan during 
assignment
..


Patch Set 3:

- I have no time to write a test.
- It is so obviously broken.
- Why it is broken is explained in this patch and its comments.

I also found another failure in this code path just now: the assignment FSM 
does not get terminated in the lchan re-use case, and hence the ASSIGNMENT_END 
event never gets dispatched.

This is completely untested, unneccessary, broken.

> why disable instead of removing

if the failures around this get fixed, the disabled part still makes sense. It 
serves as a reminder where to implement channel re-use in the future.

Note that https://gerrit.osmocom.org/c/osmo-bsc/+/12625 is a merge conflict 
with this patch. I will put this one after the other.


--
To view, visit https://gerrit.osmocom.org/12401
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355
Gerrit-Change-Number: 12401
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 24 Jan 2019 16:30:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: jenkins-common.sh: exit if image fails to build

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12690 )

Change subject: jenkins-common.sh: exit if image fails to build
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
Gerrit-Change-Number: 12690
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 16:28:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..

VTY: add extended (11-bit) RACH detection toggle

Since I838c21db29c54f1924dd478c2b34b46b70aab2cd we have both TS1
and TS2 synch. sequences, in addition to "default" TS0. Let's
finally introduce the VTY configuration parameter, that can
be used to toggle optional detection of both TS1 and TS2.

Note: we keep this optional because of potentially bad impact on
performance. There's no point in paying the performance penalty
unless upper levels (BTS, PCU) actually make use of it.

Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Related: OS#3054
---
M CommonLibs/trx_vty.c
M CommonLibs/trx_vty.h
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
M Transceiver52M/osmo-trx.cpp
5 files changed, 36 insertions(+), 10 deletions(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index 45b58eb..3b1b979 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -304,6 +304,21 @@
return CMD_SUCCESS;
 }

+DEFUN(cfg_ext_rach, cfg_ext_rach_cmd,
+   "ext-rach (disable|enable)",
+   "Enable extended (11-bit) RACH (default=disable)\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   if (strcmp("disable", argv[0]) == 0)
+   trx->cfg.ext_rach = false;
+
+   if (strcmp("enable", argv[0]) == 0)
+   trx->cfg.ext_rach = true;
+
+   return CMD_SUCCESS;
+}
+
 DEFUN(cfg_rt_prio, cfg_rt_prio_cmd,
"rt-prio <1-32>",
"Set the SCHED_RR real-time priority\n"
@@ -417,6 +432,7 @@
vty_out(vty, " rssi-offset %f%s", trx->cfg.rssi_offset, 
VTY_NEWLINE);
vty_out(vty, " swap-channels %s%s", trx->cfg.swap_channels ? "enable" : 
"disable", VTY_NEWLINE);
vty_out(vty, " egprs %s%s", trx->cfg.egprs ? "enable" : "disable", 
VTY_NEWLINE);
+   vty_out(vty, " ext-rach %s%s", trx->cfg.ext_rach ? "enable" : 
"disable", VTY_NEWLINE);
if (trx->cfg.sched_rr != 0)
vty_out(vty, " rt-prio %u%s", trx->cfg.sched_rr, VTY_NEWLINE);

@@ -454,6 +470,7 @@
vty_out(vty, " RSSI to dBm offset: %f%s", trx->cfg.rssi_offset, 
VTY_NEWLINE);
vty_out(vty, " Swap channels: %s%s", trx->cfg.swap_channels ? "Enabled" 
: "Disabled", VTY_NEWLINE);
vty_out(vty, " EDGE support: %s%s", trx->cfg.egprs ? "Enabled" : 
"Disabled", VTY_NEWLINE);
+   vty_out(vty, " Extended RACH support: %s%s", trx->cfg.ext_rach ? 
"Enabled" : "Disabled", VTY_NEWLINE);
vty_out(vty, " Real Time Priority: %u (%s)%s", trx->cfg.sched_rr,
trx->cfg.sched_rr ? "Enabled" : "Disabled", VTY_NEWLINE);
vty_out(vty, " Channels: %u%s", trx->cfg.num_chans, VTY_NEWLINE);
@@ -564,6 +581,7 @@
install_element(TRX_NODE, &cfg_rssi_offset_cmd);
install_element(TRX_NODE, &cfg_swap_channels_cmd);
install_element(TRX_NODE, &cfg_egprs_cmd);
+   install_element(TRX_NODE, &cfg_ext_rach_cmd);
install_element(TRX_NODE, &cfg_rt_prio_cmd);
install_element(TRX_NODE, &cfg_filler_cmd);

diff --git a/CommonLibs/trx_vty.h b/CommonLibs/trx_vty.h
index c921722..8d251ee 100644
--- a/CommonLibs/trx_vty.h
+++ b/CommonLibs/trx_vty.h
@@ -57,6 +57,7 @@
double offset;
double rssi_offset;
bool swap_channels;
+   bool ext_rach;
bool egprs;
unsigned int sched_rr;
unsigned int num_chans;
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index df1c0bd..cfb36c3 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -159,7 +159,8 @@
  * are still expected to report clock indications through control channel
  * activity.
  */
-bool Transceiver::init(FillerType filler, size_t rtsc, unsigned rach_delay, 
bool edge)
+bool Transceiver::init(FillerType filler, size_t rtsc, unsigned rach_delay,
+   bool edge, bool ext_rach)
 {
   int d_srcport, d_dstport, c_srcport, c_dstport;

@@ -173,6 +174,7 @@
 return false;
   }

+  mExtRACH = ext_rach;
   mEdge = edge;

   mDataSockets.resize(mChans);
@@ -497,16 +499,16 @@
 break;
   case IV:
   case VI:
-return RACH;
+return mExtRACH ? EXT_RACH : RACH;
 break;
   case V: {
 int mod51 = burstFN % 51;
 if ((mod51 <= 36) && (mod51 >= 14))
-  return RACH;
+  return mExtRACH ? EXT_RACH : RACH;
 else if ((mod51 == 4) || (mod51 == 5))
-  return RACH;
+  return mExtRACH ? EXT_RACH : RACH;
 else if ((mod51 == 45) || (mod51 == 46))
-  return RACH;
+  return mExtRACH ? EXT_RACH : RACH;
 else if (mHandover[burstTN][sdcch4_subslot[burstFN % 102]])
   return RACH;
 els

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 4: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h
File include/osmocom/bsc/codec_pref.h:

https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h@24
PS2, Line 24:const struct gsm_bts *bts, enum rate_pref 
rate_pref);
> in ch_mode_rate, we add a 'bool full_rate', and we also add a 'rate_pref'? […]
Also talked about this in person, and obviously ch_mode_rate is an 
out-argument, while the rate_pref is an input argument. I got confused about 
that because the function internals looked as if they were using 
ch_mode_rate->full rate as input, and overlooked that before using 
ch_mode_rate->full_rate, that value is already set, and it is in fact not an 
in-arg.


https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@121
PS4, Line 121:  struct channel_mode_and_rate ch_mode_rate_alt;
> Are there really only two possible mode,rate combinations? […]
We talked in person, and there really are only two possible outcomes: one for 
an FR and one for an HR lchan.
So keeping exactly two preferences is perfectly correct.
Keeping the lchan_select() out of the codec iteration is also a good idea in 
terms of complexity of that loop, and in terms of separate testability.


https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@300
PS4, Line 300:  struct channel_mode_and_rate ch_mode_rate;
put this in the user_plane scope?



--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:46:33 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in docker-playground[master]: jenkins-common.sh: exit if image fails to build

[osmith]

Hello daniel, Max, Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12690

to look at the new patch set (#3).

Change subject: jenkins-common.sh: exit if image fails to build
..

jenkins-common.sh: exit if image fails to build

docker_images_require() must fail when a new image can not be built,
even if an old image already exists.

We have this situation in a lot of the -latest tests right now, which
makes it harder to find the actual error.

Note that we can't simply use #!/bin/sh -e in all the jenkins.sh
scripts that source jenkins_common.sh, because they must be able to
clean up the docker containers on failure. So they can't abort
somewhere in the middle of the scripts. We could rewrite them to do the
clean up in a trap, but this should be done in a separate commit.

Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
---
M jenkins-common.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/90/12690/3
--
To view, visit https://gerrit.osmocom.org/12690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
Gerrit-Change-Number: 12690
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in docker-playground[master]: jenkins-common.sh: exit if image fails to build

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12690 )

Change subject: jenkins-common.sh: exit if image fails to build
..


Patch Set 2:

> why is the entire script not executed within "set -e" to exit on any errors 
> of all commands?

This script is sourced by the various jenkins.sh scripts. The jenkins.sh 
scripts can not simply have "set -e", because they need to clean up the Docker 
containers that run in the background (so if they exit half way during the 
scripts, these are not cleaned up).


--
To view, visit https://gerrit.osmocom.org/12690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
Gerrit-Change-Number: 12690
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:31:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: bsc_vty: add vty command to display all lchans

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12679 )

Change subject: bsc_vty: add vty command to display all lchans
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12679/1/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/12679/1/src/osmo-bsc/bsc_vty.c@1576
PS1, Line 1576:   "show lchan all [<0-255>] [<0-255>] [<0-7>] [<0-7>]",
we talked in person and the result is that 'show lchan summary-all' is a good 
compromise, and otherwise this patch is completely fine. (the 'all' flag could 
be implemented differently, but it's a bikeshed from me)



--
To view, visit https://gerrit.osmocom.org/12679
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d763476905fa8f84b4d7cdad4cc7dd879f84a5
Gerrit-Change-Number: 12679
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:31:10 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-hlr[master]: VTY tests: fill DB before running test

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12680 )

Change subject: VTY tests: fill DB before running test
..

VTY tests: fill DB before running test

Create a test_subscriber.vty.sql file with a dummy entry that has the
ID 100. All entries created in test_subscriber.vty have an ID > 100
now. This will be used in follow-up commit [1] to create a database
entry with an invalid IMEI value to test the related error handling
code path (that entry could not be created through the VTY).

[1]: change-id I1af7b573ca2a1cb22497052665012d9c1acf3b30
 "VTY: integrate IMEI"

Related: OS#3733
Change-Id: I48a3a503d7ca96798e2d5f70429b5fc36393420e
---
M tests/Makefile.am
M tests/test_subscriber.vty
A tests/test_subscriber.vty.sql
3 files changed, 65 insertions(+), 60 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/tests/Makefile.am b/tests/Makefile.am
index e07749c..4da8ab1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -56,6 +56,8 @@
 #   make vty-test U=-u
 vty-test:
-rm -f $(VTY_TEST_DB)
+   sqlite3 $(VTY_TEST_DB) < $(top_srcdir)/sql/hlr.sql
+   sqlite3 $(VTY_TEST_DB) < $(srcdir)/test_subscriber.vty.sql
osmo_verify_transcript_vty.py -v \
-n OsmoHLR -p 4258 \
-r "$(top_builddir)/src/osmo-hlr -c 
$(top_srcdir)/doc/examples/osmo-hlr.cfg -l $(VTY_TEST_DB)" \
diff --git a/tests/test_subscriber.vty b/tests/test_subscriber.vty
index 8677c9b..d310eb3 100644
--- a/tests/test_subscriber.vty
+++ b/tests/test_subscriber.vty
@@ -29,15 +29,15 @@

 OsmoHLR# subscriber imsi 123456789023000 show
 % No subscriber for imsi = '123456789023000'
-OsmoHLR# subscriber id 1 show
-% No subscriber for id = '1'
+OsmoHLR# subscriber id 101 show
+% No subscriber for id = '101'
 OsmoHLR# subscriber msisdn 12345 show
 % No subscriber for msisdn = '12345'

 OsmoHLR# show subscriber imsi 123456789023000
 % No subscriber for imsi = '123456789023000'
-OsmoHLR# show subscriber id 1
-% No subscriber for id = '1'
+OsmoHLR# show subscriber id 101
+% No subscriber for id = '101'
 OsmoHLR# show subscriber msisdn 12345
 % No subscriber for msisdn = '12345'

@@ -50,16 +50,16 @@

 OsmoHLR# subscriber imsi 123456789023000 create
 % Created subscriber 123456789023000
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: none

 OsmoHLR# subscriber imsi 123456789023000 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: none
-OsmoHLR# subscriber id 1 show
-ID: 1
+OsmoHLR# subscriber id 101 show
+ID: 101
 IMSI: 123456789023000
 MSISDN: none
 OsmoHLR# subscriber msisdn 12345 show
@@ -69,15 +69,15 @@
 % Updated subscriber IMSI='123456789023000' to MSISDN='12345'

 OsmoHLR# subscriber imsi 123456789023000 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 12345
-OsmoHLR# subscriber id 1 show
-ID: 1
+OsmoHLR# subscriber id 101 show
+ID: 101
 IMSI: 123456789023000
 MSISDN: 12345
 OsmoHLR# subscriber msisdn 12345 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 12345

@@ -91,26 +91,26 @@
 OsmoHLR# subscriber msisdn 423 show
 % No subscriber for msisdn = '423'
 OsmoHLR# subscriber imsi 123456789023000 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: none
 OsmoHLR# subscriber imsi 123456789023000 update msisdn 423
 % Updated subscriber IMSI='123456789023000' to MSISDN='423'
 OsmoHLR# subscriber msisdn 423 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423

 OsmoHLR# subscriber imsi 123456789023000 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423
-OsmoHLR# subscriber id 1 show
-ID: 1
+OsmoHLR# subscriber id 101 show
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423
 OsmoHLR# subscriber msisdn 423 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423

@@ -141,7 +141,7 @@

 OsmoHLR# subscriber imsi 123456789023000 update aud2g xor ki 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d
 OsmoHLR# subscriber imsi 123456789023000 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423
 2G auth: XOR
@@ -149,39 +149,39 @@

 OsmoHLR# subscriber imsi 123456789023000 update aud2g comp128v1 ki 
BeefedCafeFaceAcedAddedDecadeFee
 OsmoHLR# subscriber imsi 123456789023000 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423
 2G auth: COMP128v1
  KI=beefedcafefaceacedaddeddecadefee
-OsmoHLR# subscriber id 1 show
-ID: 1
+OsmoHLR# subscriber id 101 show
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423
 2G auth: COMP128v1
  KI=beefedcafefaceacedaddeddecadefee
 OsmoHLR# subscriber msisdn 423 show
-ID: 1
+ID: 101
 IMSI: 123456789023000
 MSISDN: 423
 2G auth: COMP128v1
  KI=beefedcafefaceacedaddeddecadefee

Change in osmo-hlr[master]: Add IMEI column to subscriber table

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12525 )

Change subject: Add IMEI column to subscriber table
..

Add IMEI column to subscriber table

Extend the database scheme, add imei to the hlr_subscriber struct and
create db_subscr_update_imei_by_imsi() and db_subscr_get_by_imei(). The
new functions are used in db_test, and in follow-up commits [1], [2].

Upgrade DB schema to version 2. SQLite can only insert new columns at
the end of the table, so this happens when upgrading the database. In
new databases, the column is placed after the IMEISV column (where it
makes more sense in my opinion). This should not have any effect, as
we never rely on the order of the columns in the tables.

Follow-up commit [1] will make use of this column to save the IMEI as
received from the MSC/VLR with the Check-IMEI Procedure. It was
decided to use Check-IMEI instead of the recent Automatic Device
Detection Procedure (which would send the IMEISV) in OS#3733, because
with Check-IMEI we don't need to rely on very recent releases of the
specification.

[1] change-id I09274ecbed64224f7ae305e09ede773931da2a57
"Optionally store IMEI in subscriber table"
[2] change-id I1af7b573ca2a1cb22497052665012d9c1acf3b30
"VTY: integrate IMEI"

Depends: Id2d2a3a93b033bafc74c62e15297034bf4aafe61 (libosmocore)
Related: OS#2541
Change-Id: If232c80bea35d5c6864b889ae92d477eeaa3f45d
---
M sql/hlr.sql
M src/db.c
M src/db.h
M src/db_hlr.c
M tests/db/db_test.c
M tests/db/db_test.err
6 files changed, 203 insertions(+), 14 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/sql/hlr.sql b/sql/hlr.sql
index 9ff9867..10838f2 100644
--- a/sql/hlr.sql
+++ b/sql/hlr.sql
@@ -5,8 +5,10 @@
imsiVARCHAR(15) UNIQUE NOT NULL,
-- Chapter 2.1.2
msisdn  VARCHAR(15) UNIQUE,
-   -- Chapter 2.2.3: Most recent / current IMEI
+   -- Chapter 2.2.3: Most recent / current IMEISV
imeisv  VARCHAR,
+   -- Chapter 2.1.9: Most recent / current IMEI
+   imeiVARCHAR(14),
-- Chapter 2.4.5
vlr_number  VARCHAR(15),
-- Chapter 2.4.6
@@ -74,4 +76,4 @@

 -- Set HLR database schema version number
 -- Note: This constant is currently duplicated in src/db.c and must be kept in 
sync!
-PRAGMA user_version = 1;
+PRAGMA user_version = 2;
diff --git a/src/db.c b/src/db.c
index f7cbace..09e1776 100644
--- a/src/db.c
+++ b/src/db.c
@@ -28,12 +28,13 @@
 #include "db_bootstrap.h"

 /* This constant is currently duplicated in sql/hlr.sql and must be kept in 
sync! */
-#define CURRENT_SCHEMA_VERSION 1
+#define CURRENT_SCHEMA_VERSION 2

 #define SEL_COLUMNS \
"id," \
"imsi," \
"msisdn," \
+   "imei," \
"vlr_number," \
"sgsn_number," \
"sgsn_address," \
@@ -50,8 +51,10 @@
[DB_STMT_SEL_BY_IMSI] = "SELECT " SEL_COLUMNS " FROM subscriber WHERE 
imsi = ?",
[DB_STMT_SEL_BY_MSISDN] = "SELECT " SEL_COLUMNS " FROM subscriber WHERE 
msisdn = ?",
[DB_STMT_SEL_BY_ID] = "SELECT " SEL_COLUMNS " FROM subscriber WHERE id 
= ?",
+   [DB_STMT_SEL_BY_IMEI] = "SELECT " SEL_COLUMNS " FROM subscriber WHERE 
imei = ?",
[DB_STMT_UPD_VLR_BY_ID] = "UPDATE subscriber SET vlr_number = $number 
WHERE id = $subscriber_id",
[DB_STMT_UPD_SGSN_BY_ID] = "UPDATE subscriber SET sgsn_number = $number 
WHERE id = $subscriber_id",
+   [DB_STMT_UPD_IMEI_BY_IMSI] = "UPDATE subscriber SET imei = $imei WHERE 
imsi = $imsi",
[DB_STMT_AUC_BY_IMSI] =
"SELECT id, algo_id_2g, ki, algo_id_3g, k, op, opc, sqn, 
ind_bitlen"
" FROM subscriber"
@@ -290,6 +293,40 @@
return rc;
 }

+static int db_upgrade_v2(struct db_context *dbc)
+{
+   sqlite3_stmt *stmt;
+   int rc;
+   const char *update_stmt_sql = "ALTER TABLE subscriber ADD COLUMN imei 
VARCHAR(14) default NULL";
+   const char *set_schema_version_sql = "PRAGMA user_version = 2";
+
+   rc = sqlite3_prepare_v2(dbc->db, update_stmt_sql, -1, &stmt, NULL);
+   if (rc != SQLITE_OK) {
+   LOGP(DDB, LOGL_ERROR, "Unable to prepare SQL statement '%s'\n", 
update_stmt_sql);
+   return rc;
+   }
+   rc = sqlite3_step(stmt);
+   db_remove_reset(stmt);
+   sqlite3_finalize(stmt);
+   if (rc != SQLITE_DONE) {
+   LOGP(DDB, LOGL_ERROR, "Unable to update HLR database schema to 
version %d\n", 1);
+   return rc;
+   }
+
+   rc = sqlite3_prepare_v2(dbc->db, set_schema_version_sql, -1, &stmt, 
NULL);
+   if (rc != SQLITE_OK) {
+   LOGP(DDB, LOGL_ERROR, "Unable to prepare SQL statement '%s'\n", 
set_schema_version_sql);
+   return rc;
+   }
+   rc = sqlite3_step(stmt);
+   if (rc != 

Change in osmo-hlr[master]: VTY tests: fill DB before running test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12680 )

Change subject: VTY tests: fill DB before running test
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12680
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48a3a503d7ca96798e2d5f70429b5fc36393420e
Gerrit-Change-Number: 12680
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:29:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: VTY: integrate IMEI

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12527 )

Change subject: VTY: integrate IMEI
..

VTY: integrate IMEI

Display the IMEI in "subscriber ... show", allow showing and modifying
subscribers by their IMEI with: "subscriber imei ...". For debug
purposes (and to have proper VTY tests), make it possible to change the
IMEI with "subscriber ... update imei".

IMEIs are saved in the database without the 15th checksum number. When
the checksum gets passed, verify it and cut it off.

Related: OS#2541
Depends: I02b54cf01a674a1911c5c897fbec02240f88b521 (libosmocore)
Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30
---
M src/hlr_vty_subscr.c
M tests/test_nodes.vty
M tests/test_subscriber.vty
M tests/test_subscriber.vty.sql
4 files changed, 152 insertions(+), 15 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/hlr_vty_subscr.c b/src/hlr_vty_subscr.c
index 92cfa2a..998d1be 100644
--- a/src/hlr_vty_subscr.c
+++ b/src/hlr_vty_subscr.c
@@ -58,6 +58,15 @@

vty_out(vty, "IMSI: %s%s", *subscr->imsi ? subscr->imsi : "none", 
VTY_NEWLINE);
vty_out(vty, "MSISDN: %s%s", *subscr->msisdn ? subscr->msisdn : 
"none", VTY_NEWLINE);
+
+   if (*subscr->imei) {
+   char checksum = osmo_luhn(subscr->imei, 14);
+   if (checksum == -EINVAL)
+   vty_out(vty, "IMEI: %s (INVALID LENGTH!)%s", 
subscr->imei, VTY_NEWLINE);
+   else
+   vty_out(vty, "IMEI: %s%c%s", subscr->imei, 
checksum, VTY_NEWLINE);
+   }
+
if (*subscr->vlr_number)
vty_out(vty, "VLR number: %s%s", subscr->vlr_number, 
VTY_NEWLINE);
if (*subscr->sgsn_number)
@@ -131,6 +140,7 @@

 static int get_subscr_by_argv(struct vty *vty, const char *type, const char 
*id, struct hlr_subscriber *subscr)
 {
+   char imei_buf[GSM23003_IMEI_NUM_DIGITS_NO_CHK+1];
int rc = -1;
if (strcmp(type, "imsi") == 0)
rc = db_subscr_get_by_imsi(g_hlr->dbc, id, subscr);
@@ -138,6 +148,17 @@
rc = db_subscr_get_by_msisdn(g_hlr->dbc, id, subscr);
else if (strcmp(type, "id") == 0)
rc = db_subscr_get_by_id(g_hlr->dbc, atoll(id), subscr);
+   else if (strcmp(type, "imei") == 0) {
+   /* Verify IMEI with checksum digit */
+   if (osmo_imei_str_valid(id, true)) {
+   /* Cut the checksum off */
+   osmo_strlcpy(imei_buf, id, sizeof(imei_buf));
+   id = imei_buf;
+   vty_out(vty, "%% Checksum validated and stripped for 
search: imei = '%s'%s", id,
+   VTY_NEWLINE);
+   }
+   rc = db_subscr_get_by_imei(g_hlr->dbc, id, subscr);
+   }
if (rc)
vty_out(vty, "%% No subscriber for %s = '%s'%s",
type, id, VTY_NEWLINE);
@@ -147,12 +168,13 @@
 #define SUBSCR_CMD "subscriber "
 #define SUBSCR_CMD_HELP "Subscriber management commands\n"

-#define SUBSCR_ID "(imsi|msisdn|id) IDENT"
+#define SUBSCR_ID "(imsi|msisdn|id|imei) IDENT"
 #define SUBSCR_ID_HELP \
"Identify subscriber by IMSI\n" \
"Identify subscriber by MSISDN (phone number)\n" \
"Identify subscriber by database ID\n" \
-   "IMSI/MSISDN/ID of the subscriber\n"
+   "Identify subscriber by IMEI\n" \
+   "IMSI/MSISDN/ID/IMEI of the subscriber\n"

 #define SUBSCR SUBSCR_CMD SUBSCR_ID " "
 #define SUBSCR_HELPSUBSCR_CMD_HELP SUBSCR_ID_HELP
@@ -508,6 +530,54 @@
return CMD_SUCCESS;
 }

+DEFUN(subscriber_imei,
+  subscriber_imei_cmd,
+  SUBSCR_UPDATE "imei (none|IMEI)",
+  SUBSCR_UPDATE_HELP
+  "Set IMEI of the subscriber (normally populated from MSC, no need to set 
this manually)\n"
+  "Forget IMEI\n"
+  "Set IMEI (use for debug only!)\n")
+{
+   struct hlr_subscriber subscr;
+   const char *id_type = argv[0];
+   const char *id = argv[1];
+   const char *imei = argv[2];
+   char imei_buf[GSM23003_IMEI_NUM_DIGITS_NO_CHK+1];
+
+   if (strcmp(imei, "none") == 0)
+   imei = NULL;
+   else {
+   /* Verify IMEI with checksum digit */
+   if (osmo_imei_str_valid(imei, true)) {
+   /* Cut the checksum off */
+   osmo_strlcpy(imei_buf, imei, sizeof(imei_buf));
+   imei = imei_buf;
+   } else if (!osmo_imei_str_valid(imei, false)) {
+   vty_out(vty, "%% IMEI invalid: '%s'%s", imei, 
VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+   }
+
+   if (get_subscr_by_argv(vty, id_type, id, &subscr))
+   return CMD_WARNING;
+
+

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12526 )

Change subject: Optionally store IMEI in subscriber table
..

Optionally store IMEI in subscriber table

Add VTY config option "store-imei". When it is set, store the IMEI
sent from the VLR with CHECK-IMEI in the database.

Related: OS#2541
Change-Id: I09274ecbed64224f7ae305e09ede773931da2a57
---
M src/hlr.c
M src/hlr.h
M src/hlr_vty.c
M tests/test_nodes.vty
4 files changed, 43 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/hlr.c b/src/hlr.c
index 614e99f..0098a32 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -419,8 +419,22 @@
return -1;
}

-   /* Only print the IMEI for now, it's planned to store it here (OS#2541) 
*/
-   LOGP(DMAIN, LOGL_INFO, "%s: has IMEI: %s\n", gsup->imsi, imei);
+   /* Save in DB if desired */
+   if (g_hlr->store_imei) {
+   LOGP(DAUC, LOGL_DEBUG, "IMSI='%s': storing IMEI = %s\n", 
gsup->imsi, imei);
+   if (db_subscr_update_imei_by_imsi(g_hlr->dbc, gsup->imsi, imei) 
< 0) {
+   gsup_send_err_reply(conn, gsup->imsi, 
gsup->message_type, GMM_CAUSE_INV_MAND_INFO);
+   return -1;
+   }
+   } else {
+   /* Check if subscriber exists and print IMEI */
+   LOGP(DMAIN, LOGL_INFO, "IMSI='%s': has IMEI = %s (consider 
setting 'store-imei')\n", gsup->imsi, imei);
+   struct hlr_subscriber subscr;
+   if (db_subscr_get_by_imsi(g_hlr->dbc, gsup->imsi, &subscr) < 0) 
{
+   gsup_send_err_reply(conn, gsup->imsi, 
gsup->message_type, GMM_CAUSE_INV_MAND_INFO);
+   return -1;
+   }
+   }

/* Accept all IMEIs */
gsup_reply.imei_result = OSMO_GSUP_IMEI_RESULT_ACK;
diff --git a/src/hlr.h b/src/hlr.h
index e9cc747..00fa43c 100644
--- a/src/hlr.h
+++ b/src/hlr.h
@@ -51,6 +51,8 @@
struct llist_head ussd_routes;

struct llist_head ss_sessions;
+
+   bool store_imei;
 };

 extern struct hlr *g_hlr;
diff --git a/src/hlr_vty.c b/src/hlr_vty.c
index 6706aa4..04e0191 100644
--- a/src/hlr_vty.c
+++ b/src/hlr_vty.c
@@ -71,6 +71,8 @@
 static int config_write_hlr(struct vty *vty)
 {
vty_out(vty, "hlr%s", VTY_NEWLINE);
+   if (g_hlr->store_imei)
+   vty_out(vty, " store-imei%s", VTY_NEWLINE);
return CMD_SUCCESS;
 }
 
@@ -305,6 +307,23 @@
return CMD_SUCCESS;
 }

+DEFUN(cfg_store_imei, cfg_store_imei_cmd,
+   "store-imei",
+   "Save the IMEI in the database when receiving Check IMEI requests. Note 
that an MSC does not necessarily send"
+   " Check IMEI requests (for OsmoMSC, you may want to set 'check-imei-rqd 
1').")
+{
+   g_hlr->store_imei = true;
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_no_store_imei, cfg_no_store_imei_cmd,
+   "no store-imei",
+   "Do not save the IMEI in the database, when receiving Check IMEI 
requests.")
+{
+   g_hlr->store_imei = false;
+   return CMD_SUCCESS;
+}
+
 /***
  * Common Code
  ***/
@@ -368,6 +387,8 @@
install_element(HLR_NODE, &cfg_ussd_defaultroute_cmd);
install_element(HLR_NODE, &cfg_ussd_no_defaultroute_cmd);
install_element(HLR_NODE, &cfg_ncss_guard_timeout_cmd);
+   install_element(HLR_NODE, &cfg_store_imei_cmd);
+   install_element(HLR_NODE, &cfg_no_store_imei_cmd);

hlr_vty_subscriber_init();
 }
diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index 63d3da0..6e72ed0 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -79,6 +79,8 @@
   ussd default-route external EUSE
   no ussd default-route
   ncss-guard-timeout <0-255>
+  store-imei
+  no store-imei

 OsmoHLR(config-hlr)# gsup
 OsmoHLR(config-hlr-gsup)# list
@@ -98,6 +100,7 @@
 OsmoHLR(config)# exit
 OsmoHLR# configure terminal
 OsmoHLR(config)# hlr
+OsmoHLR(config-hlr)# store-imei
 OsmoHLR(config-hlr)# gsup
 OsmoHLR(config-hlr-gsup)# end
 OsmoHLR# disable
@@ -116,6 +119,7 @@
  logging level ss info
 ...
 hlr
+ store-imei
  gsup
   bind ip 127.0.0.1
  ussd route prefix *#100# internal own-msisdn

--
To view, visit https://gerrit.osmocom.org/12526
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09274ecbed64224f7ae305e09ede773931da2a57
Gerrit-Change-Number: 12526
Gerrit-PatchSet: 8
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedr

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12526 )

Change subject: Optionally store IMEI in subscriber table
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12526
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09274ecbed64224f7ae305e09ede773931da2a57
Gerrit-Change-Number: 12526
Gerrit-PatchSet: 7
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:28:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: Add IMEI column to subscriber table

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12525 )

Change subject: Add IMEI column to subscriber table
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12525
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If232c80bea35d5c6864b889ae92d477eeaa3f45d
Gerrit-Change-Number: 12525
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:28:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: VTY: integrate IMEI

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12527 )

Change subject: VTY: integrate IMEI
..


Patch Set 12: Code-Review+2


-- 
To view, visit https://gerrit.osmocom.org/12527
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30
Gerrit-Change-Number: 12527
Gerrit-PatchSet: 12
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-CC: Max 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:27:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-CC: Tom Tsou 
Gerrit-CC: tnt 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:18:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: jenkins-common.sh: exit if image fails to build

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12690 )

Change subject: jenkins-common.sh: exit if image fails to build
..


Patch Set 2:

why is the entire script not executed within "set -e" to exit on any errors of 
all commands?


--
To view, visit https://gerrit.osmocom.org/12690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
Gerrit-Change-Number: 12690
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Thu, 24 Jan 2019 15:17:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: jenkins-common.sh: exit if image fails to build

[osmith]

Hello daniel, Max, Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12690

to look at the new patch set (#2).

Change subject: jenkins-common.sh: exit if image fails to build
..

jenkins-common.sh: exit if image fails to build

docker_images_require() must fail when a new image can not be built,
even if an old image already exists.

We have this situation in a lot of the -latest tests right now, which
makes it harder to find the actual error.

Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
---
M jenkins-common.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/90/12690/2
--
To view, visit https://gerrit.osmocom.org/12690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
Gerrit-Change-Number: 12690
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 

Change in docker-playground[master]: jenkins-common.sh: exit if image fails to build

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12690


Change subject: jenkins-common.sh: exit if image fails to build
..

jenkins-common.sh: exit if image fails to build

docker_images_require() must fail when a new image can not be built,
even if an old image already exists.

We have this situation in a lot of the -latest tests right now, which
makes it harder to find the actual error.

Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
---
M jenkins-common.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/90/12690/1

diff --git a/jenkins-common.sh b/jenkins-common.sh
index f3d6c61..4289d0b 100644
--- a/jenkins-common.sh
+++ b/jenkins-common.sh
@@ -7,7 +7,7 @@
# Trigger image build (cache will be used when up-to-date)
if [ -z "$NO_DOCKER_IMAGE_BUILD" ]; then
echo "Building image: $i (export 
NO_DOCKER_IMAGE_BUILD=1 to prevent this)"
-   make -C "../$i"
+   make -C "../$i" || exit 1
fi

# Detect missing images (build skipped/failure)

--
To view, visit https://gerrit.osmocom.org/12690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7039089457b62b8798a79c5efd62bd91622986d3
Gerrit-Change-Number: 12690
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Build failure of network:osmocom:latest/eclipse-titan in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/xUbuntu_17.04/i586

Package network:osmocom:latest/eclipse-titan failed to build in 
xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:latest eclipse-titan

Last lines of build log:
[  790s]"Build date (Base Library): " __DATE__ " " __TIME__ "\n"
[  790s]   ^~~~
[  791s] ar -r libttcn3-parallel.a RT1/TitanLoggerApi.o 
RT1/TitanLoggerControl.o config_process.lex.o config_process.tab.o 
RT1/PreGenRecordOf.o Addfunc.o Array.o ASN_Any.o ASN_CharacterString.o 
ASN_EmbeddedPDV.o ASN_External.o ASN_Null.o Basetype.o BER.o Bitstring.o 
Boolean.o Charstring.o Communication.o Component.o Default.o Encdec.o Error.o 
Float.o Hexstring.o RInt.o Integer.o Logger.o LoggerPlugin.o 
LoggerPluginManager.o LegacyLogger.o LoggingBits.o Module_list.o Objid.o 
Octetstring.o Port.o RAW.o Runtime.o Snapshot.o Struct_of.o Template.o TEXT.o 
Textbuf.o Timer.o Param_Types.o Universal_charstring.o Verdicttype.o XER.o 
XmlReader.o TitanLoggerControlImpl.o TCov.o JSON.o Profiler.o ProfilerTools.o 
Debugger.o DebuggerUI.o OER.o ../common/memory.o ../common/pattern_la.o 
../common/pattern_p.o ../common/config_preproc.o ../common/config_preproc_la.o 
../common/config_preproc_p.tab.o ../common/path.o ../common/pattern_uni.o 
../common/Quadruple.o ../common/NetworkHandler.o ../common/Path2.o 
../common/ModuleVersion.o ../common/JSON_Tokenizer.o ../common/UnicharPattern.o 
LoggerPlugin_static.o Parallel_main.o
[  791s] ar: creating libttcn3-parallel.a
[  791s] g++ -c -Wdate-time -D_FORTIFY_SOURCE=2 -DYY_NO_INPUT -DNDEBUG  -DLINUX 
-DUSE_EPOLL -DYY_NO_INPUT -DNDEBUG  -DLINUX -DUSE_EPOLL -I. -IRT1 
-I/usr/include/libxml2 -I../common -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fPIE -fstack-protector-strong 
-Wformat -Werror=format-security -Wall -Wno-long-long -O2 -fPIC -Wall 
-Wno-long-long -O2 -fPIC LoggerPlugin_dynamic.cc -o LoggerPlugin_dynamic.o
[  791s] g++ -shared -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z,relro 
-Wl,-z,now  -fPIC  -fPIC -o libttcn3-dynamic.so RT1/TitanLoggerApi.o 
RT1/TitanLoggerControl.o config_process.lex.o config_process.tab.o 
RT1/PreGenRecordOf.o Addfunc.o Array.o ASN_Any.o ASN_CharacterString.o 
ASN_EmbeddedPDV.o ASN_External.o ASN_Null.o Basetype.o BER.o Bitstring.o 
Boolean.o Charstring.o Communication.o Component.o Default.o Encdec.o Error.o 
Float.o Hexstring.o RInt.o Integer.o Logger.o LoggerPlugin.o 
LoggerPluginManager.o LegacyLogger.o LoggingBits.o Module_list.o Objid.o 
Octetstring.o Port.o RAW.o Runtime.o Snapshot.o Struct_of.o Template.o TEXT.o 
Textbuf.o Timer.o Param_Types.o Universal_charstring.o Verdicttype.o XER.o 
XmlReader.o TitanLoggerControlImpl.o TCov.o JSON.o Profiler.o ProfilerTools.o 
Debugger.o DebuggerUI.o OER.o ../common/memory.o ../common/pattern_la.o 
../common/pattern_p.o ../common/config_preproc.o ../common/config_preproc_la.o 
../common/config_preproc_p.tab.o ../common/path.o ../common/pattern_uni.o 
../common/Quadruple.o ../common/NetworkHandler.o ../common/Path2.o 
../common/ModuleVersion.o ../common/JSON_Tokenizer.o ../common/UnicharPattern.o 
LoggerPlugin_dynamic.o Single_main.o -Ldefault/lib -lcrypto -lxml2
[  792s] /usr/bin/ld: LoggerPlugin_dynamic.o: undefined reference to symbol 
'dlopen@@GLIBC_2.1'
[  792s] //lib/i386-linux-gnu/libdl.so.2: error adding symbols: DSO missing 
from command line
[  792s] collect2: error: ld returned 1 exit status
[  792s] Makefile:344: recipe for target 'libttcn3-dynamic.so' failed
[  792s] make[2]: *** [libttcn3-dynamic.so] Error 1
[  792s] make[2]: Leaving directory '/usr/src/packages/BUILD/core'
[  792s] Makefile:65: recipe for target 'all' failed
[  792s] make[1]: *** [all] Error 2
[  792s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  792s] dh_auto_build: make -j1 returned exit code 2
[  792s] debian/rules:6: recipe for target 'build' failed
[  792s] make: *** [build] Error 2
[  792s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  792s] 
[  792s] cloud117 failed "build eclipse-titan_6.3.1-1.dsc" at Thu Jan 24 
15:03:01 UTC 2019.
[  792s] 
[  792s] ### VM INTERACTION START ###
[  795s] [  737.358797] sysrq: SysRq : Power Off
[  795s] [  737.363171] reboot: Power down
[  797s] ### VM INTERACTION END ###
[  797s] 
[  797s] cloud117 failed "build eclipse-titan_6.3.1-1.dsc" at Thu Jan 24 
15:03:08 UTC 2019.
[  797s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/eclipse-titan in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/xUbuntu_17.04/x86_64

Package network:osmocom:latest/eclipse-titan failed to build in 
xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest eclipse-titan

Last lines of build log:
[  525s]"Build date (Base Library): " __DATE__ " " __TIME__ "\n"
[  525s]   ^~~~
[  526s] ar -r libttcn3-parallel.a RT1/TitanLoggerApi.o 
RT1/TitanLoggerControl.o config_process.lex.o config_process.tab.o 
RT1/PreGenRecordOf.o Addfunc.o Array.o ASN_Any.o ASN_CharacterString.o 
ASN_EmbeddedPDV.o ASN_External.o ASN_Null.o Basetype.o BER.o Bitstring.o 
Boolean.o Charstring.o Communication.o Component.o Default.o Encdec.o Error.o 
Float.o Hexstring.o RInt.o Integer.o Logger.o LoggerPlugin.o 
LoggerPluginManager.o LegacyLogger.o LoggingBits.o Module_list.o Objid.o 
Octetstring.o Port.o RAW.o Runtime.o Snapshot.o Struct_of.o Template.o TEXT.o 
Textbuf.o Timer.o Param_Types.o Universal_charstring.o Verdicttype.o XER.o 
XmlReader.o TitanLoggerControlImpl.o TCov.o JSON.o Profiler.o ProfilerTools.o 
Debugger.o DebuggerUI.o OER.o ../common/memory.o ../common/pattern_la.o 
../common/pattern_p.o ../common/config_preproc.o ../common/config_preproc_la.o 
../common/config_preproc_p.tab.o ../common/path.o ../common/pattern_uni.o 
../common/Quadruple.o ../common/NetworkHandler.o ../common/Path2.o 
../common/ModuleVersion.o ../common/JSON_Tokenizer.o ../common/UnicharPattern.o 
LoggerPlugin_static.o Parallel_main.o
[  526s] ar: creating libttcn3-parallel.a
[  526s] g++ -c -Wdate-time -D_FORTIFY_SOURCE=2 -DYY_NO_INPUT -DNDEBUG  -DLINUX 
-DUSE_EPOLL -DYY_NO_INPUT -DNDEBUG  -DLINUX -DUSE_EPOLL -I. -IRT1 
-I/usr/include/libxml2 -I../common -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fPIE -fstack-protector-strong 
-Wformat -Werror=format-security -Wall -Wno-long-long -O2 -fPIC -Wall 
-Wno-long-long -O2 -fPIC LoggerPlugin_dynamic.cc -o LoggerPlugin_dynamic.o
[  526s] g++ -shared -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z,relro 
-Wl,-z,now  -fPIC  -fPIC -o libttcn3-dynamic.so RT1/TitanLoggerApi.o 
RT1/TitanLoggerControl.o config_process.lex.o config_process.tab.o 
RT1/PreGenRecordOf.o Addfunc.o Array.o ASN_Any.o ASN_CharacterString.o 
ASN_EmbeddedPDV.o ASN_External.o ASN_Null.o Basetype.o BER.o Bitstring.o 
Boolean.o Charstring.o Communication.o Component.o Default.o Encdec.o Error.o 
Float.o Hexstring.o RInt.o Integer.o Logger.o LoggerPlugin.o 
LoggerPluginManager.o LegacyLogger.o LoggingBits.o Module_list.o Objid.o 
Octetstring.o Port.o RAW.o Runtime.o Snapshot.o Struct_of.o Template.o TEXT.o 
Textbuf.o Timer.o Param_Types.o Universal_charstring.o Verdicttype.o XER.o 
XmlReader.o TitanLoggerControlImpl.o TCov.o JSON.o Profiler.o ProfilerTools.o 
Debugger.o DebuggerUI.o OER.o ../common/memory.o ../common/pattern_la.o 
../common/pattern_p.o ../common/config_preproc.o ../common/config_preproc_la.o 
../common/config_preproc_p.tab.o ../common/path.o ../common/pattern_uni.o 
../common/Quadruple.o ../common/NetworkHandler.o ../common/Path2.o 
../common/ModuleVersion.o ../common/JSON_Tokenizer.o ../common/UnicharPattern.o 
LoggerPlugin_dynamic.o Single_main.o -Ldefault/lib -lcrypto -lxml2
[  526s] /usr/bin/ld: LoggerPlugin_dynamic.o: undefined reference to symbol 
'dlclose@@GLIBC_2.2.5'
[  526s] //lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing 
from command line
[  526s] collect2: error: ld returned 1 exit status
[  526s] Makefile:344: recipe for target 'libttcn3-dynamic.so' failed
[  526s] make[2]: *** [libttcn3-dynamic.so] Error 1
[  526s] make[2]: Leaving directory '/usr/src/packages/BUILD/core'
[  526s] Makefile:65: recipe for target 'all' failed
[  526s] make[1]: *** [all] Error 2
[  526s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  526s] dh_auto_build: make -j1 returned exit code 2
[  526s] debian/rules:6: recipe for target 'build' failed
[  526s] make: *** [build] Error 2
[  526s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  526s] 
[  526s] lamb12 failed "build eclipse-titan_6.3.1-1.dsc" at Thu Jan 24 14:58:33 
UTC 2019.
[  526s] 
[  526s] ### VM INTERACTION START ###
[  530s] [  517.832903] sysrq: SysRq : Power Off
[  530s] [  517.844169] reboot: Power down
[  530s] ### VM INTERACTION END ###
[  530s] 
[  530s] lamb12 failed "build eclipse-titan_6.3.1-1.dsc" at Thu Jan 24 14:58:37 
UTC 2019.
[  530s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..


Patch Set 5: Code-Review+1

I've dropped changes from .cfg - after all, it's a temporary plug until further 
optimizations are implemented to allow developers to run tests without 
affecting regular users. Once optimizations are in place than we can simply 
enable this by default without the need to change configs as well.


--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-CC: Tom Tsou 
Gerrit-CC: tnt 
Gerrit-Comment-Date: Thu, 24 Jan 2019 14:50:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Max]

Max has uploaded a new patch set (#5) to the change originally created by Vadim 
Yanitskiy. ( https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..

VTY: add extended (11-bit) RACH detection toggle

Since I838c21db29c54f1924dd478c2b34b46b70aab2cd we have both TS1
and TS2 synch. sequences, in addition to "default" TS0. Let's
finally introduce the VTY configuration parameter, that can
be used to toggle optional detection of both TS1 and TS2.

Note: we keep this optional because of potentially bad impact on
performance. There's no point in paying the performance penalty
unless upper levels (BTS, PCU) actually make use of it.

Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Related: OS#3054
---
M CommonLibs/trx_vty.c
M CommonLibs/trx_vty.h
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
M Transceiver52M/osmo-trx.cpp
5 files changed, 36 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/23/11423/5
--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Max]

Max has uploaded a new patch set (#4) to the change originally created by Vadim 
Yanitskiy. ( https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..

VTY: add extended (11-bit) RACH detection toggle

Since I838c21db29c54f1924dd478c2b34b46b70aab2cd we have both TS1
and TS2 synch. sequences, in addition to "default" TS0. Let's
finally introduce the VTY configuration parameter, that can
be used to toggle optional detection of both TS1 and TS2.

Note: we keep this optional because of potentially bad impact on
performance. There's no point in paying the performance penalty
unless upper levels (BTS, PCU) actually make use of it.

Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Related: OS#3054
---
M CommonLibs/trx_vty.c
M CommonLibs/trx_vty.h
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
M Transceiver52M/osmo-trx.cpp
5 files changed, 37 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/23/11423/4
--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 
Gerrit-CC: Pau Espin Pedrol 

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #834

[jenkins]

See 


--
[...truncated 122.97 KB...]
Searching INPUT for files to process...
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

 /usr/bin/install -c -m 644 ../README 
'
cp -r html 

make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Entering directory 
'

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 24 Jan 2019 12:42:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: Store subscriber's cell identity in ran_conn

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 )

Change subject: Store subscriber's cell identity in ran_conn
..


Patch Set 6:

(1 comment)

> Meta: AFAIK we already store the entire CGI in the vlr_subscr?
> maybe we should instead drop the LAC info from struct ran_conn completely?

Fine by me.

> (code looks like we are never storing the CI part of vls_subscr->cgi, that 
> would be nice to fix)

The question is if it's ok to use vls_subscr's CGI - do we have 1:1 relation 
between ran_conn and vls_subscr after your handover changes?

> Meta meta: in the course of inter-MSC HO I am refactoring what the ran_conn 
> represents, so I'd prefer to park this patch and revisit after the inter-MSC 
> changes, to avoid merge conflicts and back-and-forths.

I understand your concerns although it's kinda inconvenient to halt all OsmoMSC 
development until you're done with HO. Any chance you could start pushing 
ran_conn related changes to gerrit perhaps?

https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@320
PS2, Line 320:  case CELL_IDENT_CI:
> a CELL_IDENT_CI is *only* a CI without a LAC;

So it's impossible to have CI without LAC? Do you have a spec reference I can 
add in here instead of FIXME?



--
To view, visit https://gerrit.osmocom.org/11746
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e
Gerrit-Change-Number: 11746
Gerrit-PatchSet: 6
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 24 Jan 2019 12:11:25 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_04_11.c: also assign SM-RP-MR to MO transactions

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12687 )

Change subject: libmsc/gsm_04_11.c: also assign SM-RP-MR to MO transactions
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/12687
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d07354175444f9764fb0dd6ea188a64494d79fe
Gerrit-Change-Number: 12687
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 10:08:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_04_11.c: introduce and use gsm411_assign_sm_rp_mr()

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12628 )

Change subject: libmsc/gsm_04_11.c: introduce and use gsm411_assign_sm_rp_mr()
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/12628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife6d954c46b7d8348a4221ab677d0355eb3ee7ac
Gerrit-Change-Number: 12628
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 24 Jan 2019 10:08:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mo_mt_sms_rp_mr

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12689


Change subject: MSC_Tests.ttcn: introduce TC_gsup_mo_mt_sms_rp_mr
..

MSC_Tests.ttcn: introduce TC_gsup_mo_mt_sms_rp_mr

The idea of this test case is to verify SM-RP-MR assignment for
a few concurrent MO/MT SMS being sent over GSUP.

Basically, the algorythm is the following:

1.0 establish a RAN connection,
1.1 send CM Service Request for MO SMMA indication,
1.2 submit MO SMMA indication on DTAP,
1.3 expect MO-ForwardSM-Req on GSUP,

2.0 send MT SMS using MT-ForwardSM-Req on GSUP,
2.1 expect CP-DATA/RP-DATA for MT SMS on DTAP,

3.0 compare both SM-RP-MR values (for MT, assigned by the MSC),
3.1 send MO-ForwardSM-Res for MO SMMA on GSUP,
3.1.1 expect CP-DATA/RP-ACK for MO SMMA on DTAP,
3.2 send CP-DATA/RP-ACK for MT SMS on DTAP,
3.2.1 expect MT-ForwardSM-Res for MT SMS on GSUP.

Change-Id: I17cbbaa64d9bce770f985588e93cd3eecd732120
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 106 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/89/12689/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index fb0798c..8d29e7a 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2521,6 +2521,110 @@
f_vty_config(MSCVTY, "msc", "no sms-over-gsup");
 }

+/* Test SM-RP-MR assignment for MT-SMS over GSUP */
+private function f_tc_gsup_mo_mt_sms_rp_mr(charstring id, BSC_ConnHdlrPars 
pars)
+runs on BSC_ConnHdlr {
+   var SmsParameters spars_mo := valueof(t_SmsPars); /* MO SMMA */
+   var SmsParameters spars_mt := valueof(t_SmsPars); /* MT SMS */
+
+   f_init_handler(pars);
+
+   /* We need to inspect GSUP activity */
+   f_create_gsup_expect(hex2str(g_pars.imsi));
+
+   /* Perform location update */
+   f_perform_lu();
+
+   /* Register an 'expect' for given IMSI (+TMSI) */
+   if (isvalue(g_pars.tmsi)) {
+   f_bssmap_register_imsi(g_pars.imsi, g_pars.tmsi);
+   } else {
+   f_bssmap_register_imsi(g_pars.imsi, ''O);
+   }
+
+   /* Send CM Service Request for MO SMMA */
+   f_establish_fully(EST_TYPE_MO_SMS);
+
+   /* Submit MO SMMA on DTAP */
+   log("Submit MO SMMA on DTAP, SM-RP-MR is '00'O");
+   spars_mo.rp.msg_ref := '00'O;
+   f_mo_smma(spars_mo);
+
+   /* Expect MO-forwardSM-Req for MO SMMA on GSUP */
+   alt {
+   [] GSUP.receive(tr_GSUP_MO_READY_FOR_SM_REQ(
+   imsi := g_pars.imsi,
+   sm_rp_mr := spars_mo.rp.msg_ref,
+   sm_alert_rsn := GSUP_SM_ALERT_RSN_TYPE_MEM_AVAIL
+   )) {
+   log("RX MO-ReadyForSM-Req, SM-RP-MR is '00'O");
+   setverdict(pass);
+   }
+   [] GSUP.receive {
+   log("RX unexpected GSUP message");
+   setverdict(fail);
+   mtc.stop;
+   }
+   }
+
+   /* Submit MT SMS on GSUP */
+   log("TX MT-forwardSM-Req for the MT SMS");
+   f_gsup_forwardSM_req(spars_mt);
+
+   /* Wait for MT SMS on DTAP */
+   f_mt_sms_expect(spars_mt);
+   log("RX MT SMS on DTAP, DTAP TID is ", spars_mt.tid,
+   ", SM-RP-MR is ", spars_mt.rp.msg_ref);
+
+   /* Both SM-RP-MR values shall be different */
+   if (spars_mo.rp.msg_ref == spars_mt.rp.msg_ref) {
+   log("Both SM-RP-MR values shall be different");
+   setverdict(fail);
+   }
+
+   /* SM-RP-MR value for MT SMS shall be assigned */
+   if (spars_mt.rp.msg_ref == 'FF'O) {
+   log("Unassigned SM-RP-MR value for the MT SMS");
+   setverdict(fail);
+   }
+
+   /* Trigger RP-ACK for MO SMMA by sending MO-forwardSM-Res */
+   GSUP.send(valueof(ts_GSUP_MO_READY_FOR_SM_RES(
+   imsi := g_pars.imsi,
+   sm_rp_mr := spars_mo.rp.msg_ref)));
+   /* Expect RP-ACK for MO SMMA on DTAP */
+   f_mo_sms_wait_rp_ack(spars_mo);
+
+   /* Send RP-ACK for MT SMS and expect MT-forwardSM-Res on GSUP */
+   f_mt_sms_send_rp_ack(spars_mt);
+   alt {
+   [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_RES(
+   imsi := g_pars.imsi,
+   sm_rp_mr := spars_mt.rp.msg_ref
+   )) {
+   log("RX MT-forwardSM-Res (RP-ACK)");
+   setverdict(pass);
+   }
+   [] GSUP.receive {
+   log("RX unexpected GSUP message");
+   setverdict(fail);
+   mtc.stop;
+   }
+   }
+
+   f_expect_clear();
+}
+testcase TC_gsup_mo_mt_sms_rp_mr() runs on MTC_CT {
+   var BSC_ConnHdlrPars pars;
+   var BSC_ConnHdlr vc_conn;
+   f_init();
+   pars := f_init_pars(93);
+   f_vty_config(MSCVTY, "msc", "sms-over-gsup");
+   vc_conn := f_start_handler_with_pars(refers(f_tc_gsup_mo_mt_sms_rp_mr), 
pars);
+   vc_conn.done;
+   f_vty_config(MSCV

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #833

[jenkins]

See 


--
[...truncated 122.34 KB...]
Searching INPUT for files to process...
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

 /usr/bin/install -c -m 644 ../README 
'
cp -r html 

make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Entering directory 
'