Build failure of network:osmocom:nightly/ulfius in Debian_Testing/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Testing/x86_64
Package network:osmocom:nightly/ulfius failed to build in Debian_Testing/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly ulfius
Last lines of build log:
[ 146s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5
of 'MHD_start_daemon' from incompatible pointer type
[-Werror=incompatible-pointer-types]
[ 146s] 839 | mhd_flags, u_instance->port, NULL, NULL,
_webservice_dispatcher, (void *)u_instance,
[ 146s] |
^
[ 146s] ||
[ 146s] |int (*)(void *,
struct MHD_Connection *, const char *, const char *, const char *, const char
*, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)}
[ 146s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46,
[ 146s] from /usr/src/packages/BUILD/include/u_private.h:29,
[ 146s] from /usr/src/packages/BUILD/src/ulfius.c:29:
[ 146s] /usr/include/microhttpd.h:2425:1: note: expected
'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *, long
unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *,
size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)'}
[ 146s] 2425 | MHD_start_daemon (unsigned int flags,
[ 146s] | ^~~~
[ 146s] cc1: all warnings being treated as errors
[ 146s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144:
CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1
[ 146s] make[3]: *** Waiting for unfinished jobs
[ 146s] make[3]: Leaving directory '/usr/src/packages/BUILD/build'
[ 146s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all]
Error 2
[ 146s] make[2]: Leaving directory '/usr/src/packages/BUILD/build'
[ 146s] make[1]: *** [Makefile:166: all] Error 2
[ 146s] make[1]: Leaving directory '/usr/src/packages/BUILD/build'
[ 146s] dh_auto_build: error: cd build && make -j8 "INSTALL=install
--strip-program=true" returned exit code 2
[ 146s] make: *** [debian/rules:9: build] Error 25
[ 146s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 146s] ### VM INTERACTION START ###
[ 149s] [ 136.539266] sysrq: SysRq : Power Off
[ 149s] [ 136.545829] reboot: Power down
[ 149s] ### VM INTERACTION END ###
[ 149s]
[ 149s] lamb56 failed "build ulfius_2.5.2-4.1.dsc" at Fri Jul 10 03:53:40 UTC
2020.
[ 149s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/ulfius in Debian_Testing/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Testing/x86_64
Package network:osmocom:latest/ulfius failed to build in Debian_Testing/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest ulfius
Last lines of build log:
[ 121s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5
of 'MHD_start_daemon' from incompatible pointer type
[-Werror=incompatible-pointer-types]
[ 121s] 839 | mhd_flags, u_instance->port, NULL, NULL,
_webservice_dispatcher, (void *)u_instance,
[ 121s] |
^
[ 121s] ||
[ 121s] |int (*)(void *,
struct MHD_Connection *, const char *, const char *, const char *, const char
*, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)}
[ 121s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46,
[ 121s] from /usr/src/packages/BUILD/include/u_private.h:29,
[ 121s] from /usr/src/packages/BUILD/src/ulfius.c:29:
[ 121s] /usr/include/microhttpd.h:2425:1: note: expected
'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *, long
unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *,
size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)'}
[ 121s] 2425 | MHD_start_daemon (unsigned int flags,
[ 121s] | ^~~~
[ 122s] cc1: all warnings being treated as errors
[ 122s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144:
CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1
[ 122s] make[3]: *** Waiting for unfinished jobs
[ 122s] make[3]: Leaving directory '/usr/src/packages/BUILD/build'
[ 122s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all]
Error 2
[ 122s] make[2]: Leaving directory '/usr/src/packages/BUILD/build'
[ 122s] make[1]: *** [Makefile:166: all] Error 2
[ 122s] make[1]: Leaving directory '/usr/src/packages/BUILD/build'
[ 122s] dh_auto_build: error: cd build && make -j8 "INSTALL=install
--strip-program=true" returned exit code 2
[ 122s] make: *** [debian/rules:9: build] Error 25
[ 122s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 122s] ### VM INTERACTION START ###
[ 125s] [ 113.294731] sysrq: SysRq : Power Off
[ 125s] [ 113.302472] reboot: Power down
[ 125s] ### VM INTERACTION END ###
[ 125s]
[ 125s] lamb61 failed "build ulfius_2.5.2-4.1.dsc" at Fri Jul 10 03:52:42 UTC
2020.
[ 125s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_10/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586
Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly open5gs
Last lines of build log:
[ 248s] ^~~
[ 248s] ../src/udr/nnrf-handler.c:77:17: note: in expansion of macro ‘ogs_warn’
[ 248s] ogs_warn("[%s] Forced to %d seconds",
[ 248s] ^~~~
[ 248s] ../src/udr/nnrf-handler.c:78:44: note: in expansion of macro
‘ogs_time_sec’
[ 248s] subscription->id,
(int)ogs_time_sec(VALIDITY_MINIMUM));
[ 248s] ^~~~
[ 248s] ../src/udr/nnrf-handler.c:78:57: note: in expansion of macro
‘VALIDITY_MINIMUM’
[ 248s] subscription->id,
(int)ogs_time_sec(VALIDITY_MINIMUM));
[ 248s]
^~~~
[ 248s] cc1: some warnings being treated as errors
[ 248s] [2185/2412] cc -o src/nrf/open5gs-nrfd
'src/nrf/f570ec2@@open5gs-nrfd@exe/app.c.o'
'src/nrf/f570ec2@@open5gs-nrfd@exe/.._main.c.o' -Wl,--no-undefined
-Wl,--as-needed -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro
-Wl,-z,now -Wl,--start-group src/nrf/libnrf.a lib/ipfw/libogsipfw.so.1.3.0
lib/app/libogsapp.so.1.3.0 lib/core/libogscore.so.1.3.0
lib/dbi/libogsdbi.so.1.3.0 lib/crypt/libogscrypt.so.1.3.0
lib/sbi/libogssbi.so.1.3.0 lib/sbi/openapi/libogssbi-openapi.so.1.3.0
/usr/lib/i386-linux-gnu/libyaml.so
/usr/lib/gcc/i686-linux-gnu/8/../../../i386-linux-gnu/libmongoc-1.0.so
/usr/lib/gcc/i686-linux-gnu/8/../../../i386-linux-gnu/libbson-1.0.so -lgnutls
/usr/lib/i386-linux-gnu/libmicrohttpd.so /usr/lib/i386-linux-gnu/libcurl.so
-lgnutls -Wl,--end-group -pthread
'-Wl,-rpath,$ORIGIN/:$ORIGIN/../../lib/ipfw:$ORIGIN/../../lib/app:$ORIGIN/../../lib/core:$ORIGIN/../../lib/dbi:$ORIGIN/../../lib/crypt:$ORIGIN/../../lib/sbi:$ORIGIN/../../lib/sbi/openapi'
-Wl,-rpath-link,/usr/src/packages/BUILD/obj-i686-linux-gnu/src/nrf:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/ipfw:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/app:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/core:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/dbi:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/crypt:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/sbi:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/sbi/openapi
[ 248s] [2186/2412] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi
-I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0
-I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes
-Werror=missing-declarations -Werror=implicit-function-declaration
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4
-ffunction-sections -fdata-sections -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
'src/udr/e340f29@@udr@sta/nf-sm.c.o' -MF 'src/udr/e340f29@@udr@sta/nf-sm.c.o.d'
-o 'src/udr/e340f29@@udr@sta/nf-sm.c.o' -c ../src/udr/nf-sm.c
[ 248s] [2187/2412] cc -Isrc/pcrf/9bf4e44@@pcrf@sta -Isrc/pcrf -I../src/pcrf
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi
-I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/diameter/rx -I../lib/diameter/rx
-Ilib/diameter/common -I../lib/diameter/common
-Isubprojects/freeDiameter/include -I../subprojects/freeDiameter/include
-Isubprojects/freeDiameter -I../subprojects/freeDiameter -Ilib/diameter/gx
-I../lib/diameter/gx -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra
-Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith
-Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
-Werror=missing-prototypes -Werror=missing-declarations
-Werror=implicit-function-declaration -Werror=return-type
-Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes
-Wredundant-decls -Wimplicit-fallthrough=5
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 257s] Build dir: /usr/src/packages/BUILD/obj-i686-linux-gnu [ 257s] Build type: native build [ 257s] [ 257s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 257s] [ 257s] A full log can be found at /usr/src/packages/BUILD/obj-i686-linux-gnu/meson-logs/meson-log.txt [ 257s]cd obj-i686-linux-gnu && tail -v -n \+0 meson-logs/meson-log.txt [ 257s] ==> meson-logs/meson-log.txt <== [ 257s] Build started at 2020-07-10T01:36:10.954098 [ 257s] Main binary: /usr/bin/python3 [ 257s] Python system: Linux [ 257s] The Meson build system [ 257s] Version: 0.45.1 [ 257s] Source dir: /usr/src/packages/BUILD [ 257s] Build dir: /usr/src/packages/BUILD/obj-i686-linux-gnu [ 257s] Build type: native build [ 257s] [ 257s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 257s] dh_auto_configure: cd obj-i686-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/i386-linux-gnu --libexecdir=lib/i386-linux-gnu returned exit code 1 [ 257s] debian/rules:11: recipe for target 'binary' failed [ 257s] make: *** [binary] Error 2 [ 257s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 [ 257s] ### VM INTERACTION START ### [ 260s] [ 248.612551] sysrq: SysRq : Power Off [ 260s] [ 248.639906] reboot: Power down [ 260s] ### VM INTERACTION END ### [ 260s] [ 260s] lamb03 failed "build open5gs_1.3.0.20200710.dsc" at Fri Jul 10 01:36:14 UTC 2020. [ 260s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 130s] Build dir: /usr/src/packages/BUILD/obj-x86_64-linux-gnu [ 130s] Build type: native build [ 130s] [ 130s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 130s] [ 130s] A full log can be found at /usr/src/packages/BUILD/obj-x86_64-linux-gnu/meson-logs/meson-log.txt [ 130s]cd obj-x86_64-linux-gnu && tail -v -n \+0 meson-logs/meson-log.txt [ 130s] ==> meson-logs/meson-log.txt <== [ 130s] Build started at 2020-07-10T01:33:35.841734 [ 130s] Main binary: /usr/bin/python3 [ 130s] Python system: Linux [ 130s] The Meson build system [ 130s] Version: 0.45.1 [ 130s] Source dir: /usr/src/packages/BUILD [ 130s] Build dir: /usr/src/packages/BUILD/obj-x86_64-linux-gnu [ 130s] Build type: native build [ 130s] [ 130s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 130s] dh_auto_configure: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu --libexecdir=lib/x86_64-linux-gnu returned exit code 1 [ 130s] debian/rules:11: recipe for target 'binary' failed [ 130s] make: *** [binary] Error 2 [ 130s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 [ 130s] ### VM INTERACTION START ### [ 133s] [ 123.410758] sysrq: SysRq : Power Off [ 133s] [ 123.417519] reboot: Power down [ 133s] ### VM INTERACTION END ### [ 133s] [ 133s] lamb59 failed "build open5gs_1.3.0.20200710.dsc" at Fri Jul 10 01:33:39 UTC 2020. [ 133s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.10/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: nction-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/nrf/src@nrf@@nrf@sta/sbi-path.c.o' -MF 'src/nrf/src@nrf@@nrf@sta/sbi-path.c.o.d' -o 'src/nrf/src@nrf@@nrf@sta/sbi-path.c.o' -c ../src/nrf/sbi-path.c [ 98s] [2172/2412] cc -Isrc/nrf/src@nrf@@open5gs-nrfd@exe -Isrc/nrf -I../src/nrf -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/nrf.yaml"' -MD -MQ 'src/nrf/src@nrf@@open5gs-nrfd@exe/.._main.c.o' -MF 'src/nrf/src@nrf@@open5gs-nrfd@exe/.._main.c.o.d' -o 'src/nrf/src@nrf@@open5gs-nrfd@exe/.._main.c.o' -c ../src/main.c [ 98s] [2173/2412] rm -f src/mme/libmme.a && gcc-ar csrD src/mme/libmme.a 'src/mme/src@mme@@mme@sta/mme-init.c.o' 'src/mme/src@mme@@mme@sta/mme-event.c.o' 'src/mme/src@mme@@mme@sta/mme-timer.c.o' 'src/mme/src@mme@@mme@sta/mme-context.c.o' 'src/mme/src@mme@@mme@sta/s1ap-sm.c.o' 'src/mme/src@mme@@mme@sta/s1ap-build.c.o' 'src/mme/src@mme@@mme@sta/s1ap-handler.c.o' 'src/mme/src@mme@@mme@sta/s1ap-sctp.c.o' 'src/mme/src@mme@@mme@sta/s1ap-path.c.o' 'src/mme/src@mme@@mme@sta/sgsap-sm.c.o' 'src/mme/src@mme@@mme@sta/sgsap-build.c.o' 'src/mme/src@mme@@mme@sta/sgsap-handler.c.o' 'src/mme/src@mme@@mme@sta/sgsap-conv.c.o' 'src/mme/src@mme@@mme@sta/sgsap-sctp.c.o' 'src/mme/src@mme@@mme@sta/sgsap-path.c.o' 'src/mme/src@mme@@mme@sta/mme-fd-path.c.o' 'src/mme/src@mme@@mme@sta/mme-s6a-handler.c.o' 'src/mme/src@mme@@mme@sta/nas-security.c.o' 'src/mme/src@mme@@mme@sta/nas-path.c.o' 'src/mme/src@mme@@mme@sta/emm-sm.c.o' 'src/mme/src@mme@@mme@sta/emm-handler.c.o' 'src/mme/src@mme@@mme@sta/emm-build.c.o' 'src/mme/src@mme@@mme@sta/esm-sm.c.o' 'src/mme/src@mme@@mme@sta/esm-handler.c.o' 'src/mme/src@mme@@mme@sta/esm-build.c.o' 'src/mme/src@mme@@mme@sta/mme-gtp-path.c.o' 'src/mme/src@mme@@mme@sta/mme-s11-build.c.o' 'src/mme/src@mme@@mme@sta/mme-s11-handler.c.o' 'src/mme/src@mme@@mme@sta/mme-sm.c.o' 'src/mme/src@mme@@mme@sta/mme-path.c.o' 'src/mme/src@mme@@mme@sta/sbc-handler.c.o' [ 98s] [2174/2412] cc -Isrc/nrf/src@nrf@@nrf@sta -Isrc/nrf -I../src/nrf -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5
Change in osmocom-bb[master]: trxcon/scheduler: check TDMA frame order, drop out of order bursts
Hello neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201 to look at the new patch set (#4). Change subject: trxcon/scheduler: check TDMA frame order, drop out of order bursts .. trxcon/scheduler: check TDMA frame order, drop out of order bursts When running together with fake_trx.py (mostly used back-end), it is currently possible that Downlink bursts are received in a wrong order if more than one transceiver is configured (multi-trx mode). This is how it looks like: DTRXD DEBUG trx_if.c:612 RX burst tn=3 fn=629 rssi=-86 toa=0 DSCHD DEBUG sched_lchan_tchf.c:60 Traffic received on TCH/F: fn=629 ts=3 bid=1 DTRXD DEBUG trx_if.c:612 RX burst tn=3 fn=630 rssi=-86 toa=0 DSCHD DEBUG sched_lchan_tchf.c:60 Traffic received on TCH/F: fn=630 ts=3 bid=2 DTRXD DEBUG trx_if.c:612 RX burst tn=3 fn=631 rssi=-86 toa=0 DSCHD DEBUG sched_lchan_tchf.c:60 Traffic received on TCH/F: fn=631 ts=3 bid=3 DTRXD DEBUG trx_if.c:612 RX burst tn=3 fn=633 (!) rssi=-86 toa=0 DSCHD NOTICE sched_trx.c:663 Substituting (!) lost TDMA frame 632 on TCH/F DSCHD DEBUG sched_lchan_tchf.c:60 Traffic received on TCH/F: fn=632 ts=3 bid=0 DSCHD DEBUG sched_lchan_tchf.c:60 Traffic received on TCH/F: fn=633 ts=3 bid=1 DTRXD DEBUG trx_if.c:612 RX burst tn=3 fn=632 (!) rssi=-86 toa=0 DTRXD NOTICE sched_trx.c:640 Too many (>104) contiguous TDMA frames elapsed (2715647) since the last processed fn=633 (current fn=632) so here a burst with TDMA fn=633 was received earlier than a burst with TDMA fn=632. The burst loss detection logic considered the latter one as lost, and substituted it with a dummy burst. When finally the out-of-order burst with TDMA fn=632 was received, we got the large number of allegedly elapsed frames: ((632 + 2715648) - 633) % 2715648 == 2715647 Given that late bursts get substituted, the best thing we can do is to reject them and log an error. Passing them to the logical channel handler (again) might lead to undefined behaviour. Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772 Related: OS#4658, OS#4546 --- M src/host/trxcon/sched_trx.c 1 file changed, 26 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/01/19201/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: trxcon/scheduler: check TDMA frame order, drop out of order bursts
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19201 ) Change subject: trxcon/scheduler: check TDMA frame order, drop out of order bursts .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 21:19:06 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-e1d[master]: migrate to proper allocated USB Product ID
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19199 ) Change subject: migrate to proper allocated USB Product ID .. migrate to proper allocated USB Product ID The 0xe1e1 was a neat hack in the early days, but now 0x6145 has been allocated within the Openmoko USB VendorID.The current device firmware already uses the new ProductID, let's change it here, too. Change-Id: Iea6087ce02c931c796d9c9cae89cdf5b5e0b28c5 --- M src/usb.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/usb.c b/src/usb.c index 578bc34..e8cd212 100644 --- a/src/usb.c +++ b/src/usb.c @@ -39,7 +39,7 @@ #define USB_VID0x1d50 -#define USB_PID0xe1e1 +#define USB_PID0x6145 libusb_context *g_usb = NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iea6087ce02c931c796d9c9cae89cdf5b5e0b28c5 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-e1d[master]: add missing call to logging_vty_add_cmds() during startup
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19208 ) Change subject: add missing call to logging_vty_add_cmds() during startup .. add missing call to logging_vty_add_cmds() during startup Otherwise, the usual logging related VTY commands are absent. Change-Id: I07038dfb204301bb1696ca312b2ec29671b86ae5 --- M src/osmo-e1d.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-e1d.c b/src/osmo-e1d.c index 647b039..10d7a5e 100644 --- a/src/osmo-e1d.c +++ b/src/osmo-e1d.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include @@ -173,6 +174,7 @@ INIT_LLIST_HEAD(>interfaces); vty_init(_info); + logging_vty_add_cmds(); e1d_vty_init(e1d); handle_options(argc, argv); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I07038dfb204301bb1696ca312b2ec29671b86ae5 Gerrit-Change-Number: 19208 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-e1d[master]: usb.c: Fix error introducing Tx underflows
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19209 ) Change subject: usb.c: Fix error introducing Tx underflows .. usb.c: Fix error introducing Tx underflows In Change-Id I7d4d4ab39cb3e7e6a7eb8e738a367122eb3fbee2 I inroduced a bug that would cause e1_usb_xfer_out() to return four bytes too little, which in turn causes E1 Tx underflows to happen in the device firmware. Change-Id: I71675d4de781421286f0d1febedfdb1f7b523c38 --- M src/usb.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/usb.c b/src/usb.c index e8cd212..7a5dce2 100644 --- a/src/usb.c +++ b/src/usb.c @@ -135,7 +135,7 @@ memset(buf, 0xff, 4); - return e1_line_mux_out(line, buf+4, fts); + return e1_line_mux_out(line, buf+4, fts) + 4; } static int -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I71675d4de781421286f0d1febedfdb1f7b523c38 Gerrit-Change-Number: 19209 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-e1d[master]: usb.c: Fix error introducing Tx underflows
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19209 ) Change subject: usb.c: Fix error introducing Tx underflows .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I71675d4de781421286f0d1febedfdb1f7b523c38 Gerrit-Change-Number: 19209 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 09 Jul 2020 20:55:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1d[master]: migrate to proper allocated USB Product ID
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/19199 to look at the new patch set (#2). Change subject: migrate to proper allocated USB Product ID .. migrate to proper allocated USB Product ID The 0xe1e1 was a neat hack in the early days, but now 0x6145 has been allocated within the Openmoko USB VendorID.The current device firmware already uses the new ProductID, let's change it here, too. Change-Id: Iea6087ce02c931c796d9c9cae89cdf5b5e0b28c5 --- M src/usb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/99/19199/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iea6087ce02c931c796d9c9cae89cdf5b5e0b28c5 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-e1d[master]: add missing call to logging_vty_add_cmds() during startup
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19208 ) Change subject: add missing call to logging_vty_add_cmds() during startup .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I07038dfb204301bb1696ca312b2ec29671b86ae5 Gerrit-Change-Number: 19208 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 20:54:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1d[master]: migrate to proper allocated USB Product ID
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19199 ) Change subject: migrate to proper allocated USB Product ID .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iea6087ce02c931c796d9c9cae89cdf5b5e0b28c5 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 20:54:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1d[master]: usb.c: Fix error introducing Tx underflows
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19209 ) Change subject: usb.c: Fix error introducing Tx underflows .. usb.c: Fix error introducing Tx underflows In Change-Id I7d4d4ab39cb3e7e6a7eb8e738a367122eb3fbee2 I inroduced a bug that would cause e1_usb_xfer_out() to return four bytes too little, which in turn causes E1 Tx underflows to happen in the device firmware. Change-Id: I71675d4de781421286f0d1febedfdb1f7b523c38 --- M src/usb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/09/19209/1 diff --git a/src/usb.c b/src/usb.c index e8cd212..7a5dce2 100644 --- a/src/usb.c +++ b/src/usb.c @@ -135,7 +135,7 @@ memset(buf, 0xff, 4); - return e1_line_mux_out(line, buf+4, fts); + return e1_line_mux_out(line, buf+4, fts) + 4; } static int -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I71675d4de781421286f0d1febedfdb1f7b523c38 Gerrit-Change-Number: 19209 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-e1d[master]: add missing call to logging_vty_add_cmds() during startup
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19208 ) Change subject: add missing call to logging_vty_add_cmds() during startup .. add missing call to logging_vty_add_cmds() during startup Otherwise, the usual logging related VTY commands are absent. Change-Id: I07038dfb204301bb1696ca312b2ec29671b86ae5 --- M src/osmo-e1d.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/08/19208/1 diff --git a/src/osmo-e1d.c b/src/osmo-e1d.c index 647b039..10d7a5e 100644 --- a/src/osmo-e1d.c +++ b/src/osmo-e1d.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include @@ -173,6 +174,7 @@ INIT_LLIST_HEAD(>interfaces); vty_init(_info); + logging_vty_add_cmds(); e1d_vty_init(e1d); handle_options(argc, argv); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I07038dfb204301bb1696ca312b2ec29671b86ae5 Gerrit-Change-Number: 19208 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-trx[master]: Introduce rate counters to detect issues in received Dl bursts from TRXD
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19205 ) Change subject: Introduce rate counters to detect issues in received Dl bursts from TRXD .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/19205/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/19205/1/Transceiver52M/Transceiver.cpp@1072 PS1, Line 1072: some FN was lost in the middle > I did some test with a PDCH and it was not triggering, so I expected the same > for TCH/H and alike. PDCH on Downlink is gapless, i.e. you always get monotonic-increasing frame numbers... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia34f7e7d780ad1e12f24638a07f05fe91f2afea5 Gerrit-Change-Number: 19205 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 20:14:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-trx[master]: Introduce rate counters to detect issues in received Dl bursts from TRXD
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19205 ) Change subject: Introduce rate counters to detect issues in received Dl bursts from TRXD .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/19205/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/19205/1/Transceiver52M/Transceiver.cpp@1072 PS1, Line 1072: some FN was lost in the middle > Isn't it expected and normal? Imagine you have a TCH/H timeslot with only one > sub-channel active. […] I did some test with a PDCH and it was not triggering, so I expected the same for TCH/H and alike. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia34f7e7d780ad1e12f24638a07f05fe91f2afea5 Gerrit-Change-Number: 19205 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Jul 2020 19:50:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-trx[master]: Introduce rate counters to detect issues in received Dl bursts from TRXD
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19205 ) Change subject: Introduce rate counters to detect issues in received Dl bursts from TRXD .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/19205/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/19205/1/Transceiver52M/Transceiver.cpp@1072 PS1, Line 1072: some FN was lost in the middle Isn't it expected and normal? Imagine you have a TCH/H timeslot with only one sub-channel active. Same applies to SDCCH4 and SDCCH8 on TRX#N > 0 (where you don't need to send dummy bursts). -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia34f7e7d780ad1e12f24638a07f05fe91f2afea5 Gerrit-Change-Number: 19205 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Jul 2020 19:20:58 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-trx[master]: Add rate counter for missing Txbursts when scheduled towards the radi...
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/19207 )
Change subject: Add rate counter for missing Txbursts when scheduled towards
the radioInterface
..
Add rate counter for missing Txbursts when scheduled towards the radioInterface
Related: OS#4487
Change-Id: Ibb2c492b3c67cbab11fbb936ae3a090fb5756aa8
---
M CommonLibs/osmo_signal.h
M CommonLibs/trx_rate_ctr.cpp
M CommonLibs/trx_rate_ctr.h
M CommonLibs/trx_vty.c
M Transceiver52M/Transceiver.cpp
5 files changed, 20 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/07/19207/1
diff --git a/CommonLibs/osmo_signal.h b/CommonLibs/osmo_signal.h
index 5cd90c6..13646a1 100644
--- a/CommonLibs/osmo_signal.h
+++ b/CommonLibs/osmo_signal.h
@@ -60,7 +60,8 @@
/* signal cb for signal */
struct trx_counters {
size_t chan;
- unsigned int tx_stale_bursts; /* Amount of Tx bursts dropped to to
arriving too late from TRXD */
+ unsigned int tx_stale_bursts;
+ unsigned int tx_unavailable_bursts;
unsigned int tx_trxd_fn_repeated;
unsigned int tx_trxd_fn_outoforder;
unsigned int tx_trxd_fn_skipped;
diff --git a/CommonLibs/trx_rate_ctr.cpp b/CommonLibs/trx_rate_ctr.cpp
index c74602a..ea65ac9 100644
--- a/CommonLibs/trx_rate_ctr.cpp
+++ b/CommonLibs/trx_rate_ctr.cpp
@@ -103,6 +103,7 @@
{ TRX_CTR_DEV_TX_DROP_EV, "tx_drop_events" },
{ TRX_CTR_DEV_TX_DROP_SMPL, "tx_drop_samples" },
{ TRX_CTR_TRX_TX_STALE_BURSTS, "tx_stale_bursts" },
+ { TRX_CTR_TRX_TX_UNAVAILABLE_BURSTS, "tx_unavailable_bursts" },
{ TRX_CTR_TRX_TRXD_FN_REPEATED, "tx_trxd_fn_repeated" },
{ TRX_CTR_TRX_TRXD_FN_OUTOFORDER, "tx_trxd_fn_outoforder" },
{ TRX_CTR_TRX_TRXD_FN_SKIPPED, "tx_trxd_fn_skipped" },
@@ -117,6 +118,7 @@
[TRX_CTR_DEV_TX_DROP_EV]= { "device:tx_drop_events",
"Number of times Tx samples were dropped by HW" },
[TRX_CTR_DEV_TX_DROP_SMPL] = { "device:tx_drop_samples",
"Number of Tx samples dropped by HW" },
[TRX_CTR_TRX_TX_STALE_BURSTS] = { "trx:tx_stale_bursts",
"Number of Tx burts dropped by TRX due to arriving too late" },
+ [TRX_CTR_TRX_TX_UNAVAILABLE_BURSTS] = {
"trx:tx_unavailable_bursts","Number of Tx burts unavailable (not enqueued) at
the time they should be transmitted" },
[TRX_CTR_TRX_TRXD_FN_REPEATED] = { "trx:tx_trxd_fn_repeated",
"Number of Tx burts received from TRXD with repeated FN" },
[TRX_CTR_TRX_TRXD_FN_OUTOFORDER]= {
"trx:tx_trxd_fn_outoforder","Number of Tx burts received from TRXD with a past
FN" },
[TRX_CTR_TRX_TRXD_FN_SKIPPED] = { "trx:tx_trxd_fn_skipped",
"Number of Tx burts potentially skipped due to FN jumps" },
@@ -172,6 +174,8 @@
LOGCHAN(chan, DMAIN, INFO) << "rate_ctr update";
ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TX_STALE_BURSTS];
rate_ctr_add(ctr, trx_ctrs_pending[chan].tx_stale_bursts -
ctr->current);
+ ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TX_UNAVAILABLE_BURSTS];
+ rate_ctr_add(ctr, trx_ctrs_pending[chan].tx_unavailable_bursts
- ctr->current);
ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TRXD_FN_REPEATED];
rate_ctr_add(ctr, trx_ctrs_pending[chan].tx_trxd_fn_repeated -
ctr->current);
ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TRXD_FN_OUTOFORDER];
diff --git a/CommonLibs/trx_rate_ctr.h b/CommonLibs/trx_rate_ctr.h
index cef3c21..c4c05ef 100644
--- a/CommonLibs/trx_rate_ctr.h
+++ b/CommonLibs/trx_rate_ctr.h
@@ -11,6 +11,7 @@
TRX_CTR_DEV_TX_DROP_EV,
TRX_CTR_DEV_TX_DROP_SMPL,
TRX_CTR_TRX_TX_STALE_BURSTS,
+ TRX_CTR_TRX_TX_UNAVAILABLE_BURSTS,
TRX_CTR_TRX_TRXD_FN_REPEATED,
TRX_CTR_TRX_TRXD_FN_OUTOFORDER,
TRX_CTR_TRX_TRXD_FN_SKIPPED,
diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index 941a435..e37ecaf 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -390,7 +390,7 @@
return -1;
}
-#define THRESHOLD_ARGS
"(rx_overruns|tx_underruns|rx_drop_events|rx_drop_samples|tx_drop_events|tx_drop_samples|tx_stale_bursts|tx_trxd_fn_repeated|tx_trxd_fn_outoforder|tx_trxd_fn_skipped)"
+#define THRESHOLD_ARGS
"(rx_overruns|tx_underruns|rx_drop_events|rx_drop_samples|tx_drop_events|tx_drop_samples|tx_stale_bursts|tx_unavailable_bursts|tx_trxd_fn_repeated|tx_trxd_fn_outoforder|tx_trxd_fn_skipped)"
#define THRESHOLD_STR_VAL(s) "Set threshold value for rate_ctr device:"
OSMO_STRINGIFY_VAL(s) "\n"
#define THRESHOLD_STRS \
THRESHOLD_STR_VAL(rx_overruns) \
@@ -400,6 +400,7 @@
THRESHOLD_STR_VAL(tx_drop_events) \
THRESHOLD_STR_VAL(tx_drop_samples) \
THRESHOLD_STR_VAL(tx_stale_bursts) \
+ THRESHOLD_STR_VAL(tx_unavailable_bursts) \
Change in osmo-trx[master]: Transceiver: Fix race condition obtaining Dl burst from Upper layer
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/19206 )
Change subject: Transceiver: Fix race condition obtaining Dl burst from Upper
layer
..
Transceiver: Fix race condition obtaining Dl burst from Upper layer
The queue was being accessed sequentially obtaining and releasing the
mutual exclusion zone twice. First in getStaleBurst() dropping all
FN filler(mChans, true);
bool stale_bursts_changed;
+ TN = nowTime.TN();
+
for (size_t i = 0; i < mChans; i ++) {
state = [i];
stale_bursts_changed = false;
+zeros[i] = state->chanType[TN] == NONE;
+
+Mutex *mtx = mTxPriorityQueues[i].getMutex();
+mtx->lock();
while ((burst = mTxPriorityQueues[i].getStaleBurst(nowTime))) {
LOGCHAN(i, DTRXDDL, NOTICE) << "dumping STALE burst in TRX->SDR
interface ("
@@ -445,15 +451,6 @@
delete burst;
}
-if (stale_bursts_changed)
- dispatch_trx_rate_ctr_change(state, i);
-
-TN = nowTime.TN();
-modFN = nowTime.FN() % state->fillerModulus[TN];
-
-bursts[i] = state->fillerTable[modFN][TN];
-zeros[i] = state->chanType[TN] == NONE;
-
if ((burst = mTxPriorityQueues[i].getCurrentBurst(nowTime))) {
bursts[i] = burst->getVector();
@@ -463,9 +460,16 @@
burst->setVector(NULL);
filler[i] = false;
}
-
delete burst;
+} else {
+ modFN = nowTime.FN() % state->fillerModulus[TN];
+ bursts[i] = state->fillerTable[modFN][TN];
}
+
+mtx->unlock();
+
+if (stale_bursts_changed)
+ dispatch_trx_rate_ctr_change(state, i);
}
mRadioInterface->driveTransmitRadio(bursts, zeros);
diff --git a/Transceiver52M/radioVector.cpp b/Transceiver52M/radioVector.cpp
index ad40a11..68e42c5 100644
--- a/Transceiver52M/radioVector.cpp
+++ b/Transceiver52M/radioVector.cpp
@@ -120,38 +120,26 @@
radioVector* VectorQueue::getStaleBurst(const GSM::Time& targTime)
{
- mLock.lock();
- if ((mQ.size()==0)) {
- mLock.unlock();
+ if ((mQ.size()==0))
return NULL;
- }
if (mQ.top()->getTime() < targTime) {
radioVector* retVal = mQ.top();
mQ.pop();
- mLock.unlock();
return retVal;
}
- mLock.unlock();
-
return NULL;
}
radioVector* VectorQueue::getCurrentBurst(const GSM::Time& targTime)
{
- mLock.lock();
- if ((mQ.size()==0)) {
- mLock.unlock();
+ if ((mQ.size()==0))
return NULL;
- }
if (mQ.top()->getTime() == targTime) {
radioVector* retVal = mQ.top();
mQ.pop();
- mLock.unlock();
return retVal;
}
- mLock.unlock();
-
return NULL;
}
diff --git a/Transceiver52M/radioVector.h b/Transceiver52M/radioVector.h
index 0a14a4d..84e3987 100644
--- a/Transceiver52M/radioVector.h
+++ b/Transceiver52M/radioVector.h
@@ -65,6 +65,7 @@
GSM::Time nextTime() const;
radioVector* getStaleBurst(const GSM::Time& targTime);
radioVector* getCurrentBurst(const GSM::Time& targTime);
+ Mutex *getMutex() const { return };
};
#endif /* RADIOVECTOR_H */
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19206
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If1fd8d7fc5f21ee2894192ef1ac2a3cdda6bbb98
Gerrit-Change-Number: 19206
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-trx[master]: Introduce rate counters to detect issues in received Dl bursts from TRXD
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/19205 to look at the new patch set (#2). Change subject: Introduce rate counters to detect issues in received Dl bursts from TRXD .. Introduce rate counters to detect issues in received Dl bursts from TRXD This ones together with rate counters already available in lower layers allows to understand better the source of the problem with stalled tx bursts. Change-Id: Ia34f7e7d780ad1e12f24638a07f05fe91f2afea5 --- M CommonLibs/osmo_signal.h M CommonLibs/trx_rate_ctr.cpp M CommonLibs/trx_rate_ctr.h M CommonLibs/trx_vty.c M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 6 files changed, 73 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/05/19205/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia34f7e7d780ad1e12f24638a07f05fe91f2afea5 Gerrit-Change-Number: 19205 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: amarisoft_mme: make sure mcc/mnc are zero padded
srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19204 ) Change subject: amarisoft_mme: make sure mcc/mnc are zero padded .. Patch Set 1: > Patch Set 1: > > did you know that there are 2-digit and 3-digit MNCs? So 001-01 is > different from 001-001, this is why treating either of the two values as > integers is always leading to confusign bugs. > > The SIM card contains an explicit field that encodes the MNC length, as > otherwise the UE would not know where the MCC/MNC prefix of the IMSI ends. True. We don't have the notion of length notion of the MNC, other than the value you put in the config. I guess the only way to make sure we don't confuse 001 with 01 in MNC is to make sure the the leading zeros in the default.conf or resources.conf don't get stripped away. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I80a84e01ec9530c285634452d7c18c17bdd595ce Gerrit-Change-Number: 19204 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: srs_andre Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 15:24:51 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-trx[master]: Introduce rate counters to detect issues in received Dl bursts from TRXD
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/19205 )
Change subject: Introduce rate counters to detect issues in received Dl bursts
from TRXD
..
Introduce rate counters to detect issues in received Dl bursts from TRXD
This ones together with rate counters already available in lower layers
allows to understand better the source of the problem with stalled tx
bursts.
Change-Id: Ia34f7e7d780ad1e12f24638a07f05fe91f2afea5
---
M CommonLibs/osmo_signal.h
M CommonLibs/trx_rate_ctr.cpp
M CommonLibs/trx_rate_ctr.h
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
5 files changed, 68 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/05/19205/1
diff --git a/CommonLibs/osmo_signal.h b/CommonLibs/osmo_signal.h
index de17b1d..5cd90c6 100644
--- a/CommonLibs/osmo_signal.h
+++ b/CommonLibs/osmo_signal.h
@@ -61,4 +61,7 @@
struct trx_counters {
size_t chan;
unsigned int tx_stale_bursts; /* Amount of Tx bursts dropped to to
arriving too late from TRXD */
+ unsigned int tx_trxd_fn_repeated;
+ unsigned int tx_trxd_fn_outoforder;
+ unsigned int tx_trxd_fn_skipped;
};
diff --git a/CommonLibs/trx_rate_ctr.cpp b/CommonLibs/trx_rate_ctr.cpp
index 76aff7d..c74602a 100644
--- a/CommonLibs/trx_rate_ctr.cpp
+++ b/CommonLibs/trx_rate_ctr.cpp
@@ -103,6 +103,9 @@
{ TRX_CTR_DEV_TX_DROP_EV, "tx_drop_events" },
{ TRX_CTR_DEV_TX_DROP_SMPL, "tx_drop_samples" },
{ TRX_CTR_TRX_TX_STALE_BURSTS, "tx_stale_bursts" },
+ { TRX_CTR_TRX_TRXD_FN_REPEATED, "tx_trxd_fn_repeated" },
+ { TRX_CTR_TRX_TRXD_FN_OUTOFORDER, "tx_trxd_fn_outoforder" },
+ { TRX_CTR_TRX_TRXD_FN_SKIPPED, "tx_trxd_fn_skipped" },
{ 0, NULL }
};
@@ -114,6 +117,9 @@
[TRX_CTR_DEV_TX_DROP_EV]= { "device:tx_drop_events",
"Number of times Tx samples were dropped by HW" },
[TRX_CTR_DEV_TX_DROP_SMPL] = { "device:tx_drop_samples",
"Number of Tx samples dropped by HW" },
[TRX_CTR_TRX_TX_STALE_BURSTS] = { "trx:tx_stale_bursts",
"Number of Tx burts dropped by TRX due to arriving too late" },
+ [TRX_CTR_TRX_TRXD_FN_REPEATED] = { "trx:tx_trxd_fn_repeated",
"Number of Tx burts received from TRXD with repeated FN" },
+ [TRX_CTR_TRX_TRXD_FN_OUTOFORDER]= {
"trx:tx_trxd_fn_outoforder","Number of Tx burts received from TRXD with a past
FN" },
+ [TRX_CTR_TRX_TRXD_FN_SKIPPED] = { "trx:tx_trxd_fn_skipped",
"Number of Tx burts potentially skipped due to FN jumps" },
};
static const struct rate_ctr_group_desc trx_chan_ctr_group_desc = {
@@ -166,6 +172,12 @@
LOGCHAN(chan, DMAIN, INFO) << "rate_ctr update";
ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TX_STALE_BURSTS];
rate_ctr_add(ctr, trx_ctrs_pending[chan].tx_stale_bursts -
ctr->current);
+ ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TRXD_FN_REPEATED];
+ rate_ctr_add(ctr, trx_ctrs_pending[chan].tx_trxd_fn_repeated -
ctr->current);
+ ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TRXD_FN_OUTOFORDER];
+ rate_ctr_add(ctr, trx_ctrs_pending[chan].tx_trxd_fn_outoforder
- ctr->current);
+ ctr = _ctrs[chan]->ctr[TRX_CTR_TRX_TRXD_FN_SKIPPED];
+ rate_ctr_add(ctr, trx_ctrs_pending[chan].tx_trxd_fn_skipped -
ctr->current);
/* Mark as done */
trx_ctrs_pending[chan].chan = PENDING_CHAN_NONE;
}
diff --git a/CommonLibs/trx_rate_ctr.h b/CommonLibs/trx_rate_ctr.h
index 588ac2f..cef3c21 100644
--- a/CommonLibs/trx_rate_ctr.h
+++ b/CommonLibs/trx_rate_ctr.h
@@ -11,6 +11,9 @@
TRX_CTR_DEV_TX_DROP_EV,
TRX_CTR_DEV_TX_DROP_SMPL,
TRX_CTR_TRX_TX_STALE_BURSTS,
+ TRX_CTR_TRX_TRXD_FN_REPEATED,
+ TRX_CTR_TRX_TRXD_FN_OUTOFORDER,
+ TRX_CTR_TRX_TRXD_FN_SKIPPED,
};
struct ctr_threshold {
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 2ae5eda..01714db 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -52,6 +52,14 @@
/* Number of running values use in noise average */
#define NOISE_CNT 20
+
+static void dispatch_trx_rate_ctr_change(TransceiverState *state, unsigned int
chan) {
+thread_enable_cancel(false);
+state->ctrs.chan = chan;
+osmo_signal_dispatch(SS_DEVICE, S_TRX_COUNTER_CHANGE, >ctrs);
+thread_enable_cancel(true);
+}
+
TransceiverState::TransceiverState()
: mRetrans(false), mNoiseLev(0.0), mNoises(NOISE_CNT), mPower(0.0)
{
@@ -437,12 +445,8 @@
delete burst;
}
-if (stale_bursts_changed) {
- thread_enable_cancel(false);
- state->ctrs.chan = i;
- osmo_signal_dispatch(SS_DEVICE, S_TRX_COUNTER_CHANGE, >ctrs);
- thread_enable_cancel(true);
Change in osmo-mgw[master]: manuals: generate vty reference xml at build time
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18927 ) Change subject: manuals: generate vty reference xml at build time .. Removed Verified+1 by laforge -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I526af21134087e2b43b9ada59c93f636ae242e24 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote
Change in osmo-mgw[master]: add osmo-mgw --vty-ref-xml: dump VTY ref XML to stdout
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18926 ) Change subject: add osmo-mgw --vty-ref-xml: dump VTY ref XML to stdout .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia988ea1c3f5169bdb4d21f2f05933665711cfcbf Gerrit-Change-Number: 18926 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 14:21:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: manuals: generate vty reference xml at build time
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18927 ) Change subject: manuals: generate vty reference xml at build time .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I526af21134087e2b43b9ada59c93f636ae242e24 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 14:21:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: add osmo-mgw --vty-ref-xml: dump VTY ref XML to stdout
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18926 ) Change subject: add osmo-mgw --vty-ref-xml: dump VTY ref XML to stdout .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia988ea1c3f5169bdb4d21f2f05933665711cfcbf Gerrit-Change-Number: 18926 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 14:20:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: manuals: generate vty reference xml at build time
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18925 ) Change subject: manuals: generate vty reference xml at build time .. Patch Set 3: Code-Review+1 This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib872e7979c5b5a9da1347a3f326307844cf76536 Gerrit-Change-Number: 18925 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 14:20:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: manuals: generate vty reference xml at build time
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18927 ) Change subject: manuals: generate vty reference xml at build time .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I526af21134087e2b43b9ada59c93f636ae242e24 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 14:19:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: amarisoft_mme: make sure mcc/mnc are zero padded
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19204 ) Change subject: amarisoft_mme: make sure mcc/mnc are zero padded .. Patch Set 1: did you know that there are 2-digit and 3-digit MNCs? So 001-01 is different from 001-001, this is why treating either of the two values as integers is always leading to confusign bugs. The SIM card contains an explicit field that encodes the MNC length, as otherwise the UE would not know where the MCC/MNC prefix of the IMSI ends. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I80a84e01ec9530c285634452d7c18c17bdd595ce Gerrit-Change-Number: 19204 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 14:17:11 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: amarisoft_mme: make sure mcc/mnc are zero padded
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19204 )
Change subject: amarisoft_mme: make sure mcc/mnc are zero padded
..
amarisoft_mme: make sure mcc/mnc are zero padded
same as for srsEPC this is also required for Amarisoft MME to support, i.e.
001/01
Change-Id: I80a84e01ec9530c285634452d7c18c17bdd595ce
---
M src/osmo_gsm_tester/templates/amarisoft_ltemme.cfg.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/04/19204/1
diff --git a/src/osmo_gsm_tester/templates/amarisoft_ltemme.cfg.tmpl
b/src/osmo_gsm_tester/templates/amarisoft_ltemme.cfg.tmpl
index 5fcc74a..da681da 100644
--- a/src/osmo_gsm_tester/templates/amarisoft_ltemme.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/amarisoft_ltemme.cfg.tmpl
@@ -39,7 +39,7 @@
s1ap_bind_addr: "${epc.run_addr}",
- plmn: "${epc.mcc}${epc.mnc}",
+ plmn: "${'{0:03}'.format(int(epc.mcc))}${'{0:02}'.format(int(epc.mnc))}",
mme_group_id: 32769,
mme_code: 1,
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19204
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I80a84e01ec9530c285634452d7c18c17bdd595ce
Gerrit-Change-Number: 19204
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: srsue.conf.tmpl: use UE cat 8 whenever more than one carrier is confi...
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19187 ) Change subject: srsue.conf.tmpl: use UE cat 8 whenever more than one carrier is configured .. srsue.conf.tmpl: use UE cat 8 whenever more than one carrier is configured Change-Id: Id96827960cac436b8ac363e28c2b0ab7b6acf57f --- M src/osmo_gsm_tester/templates/srsue.conf.tmpl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl b/src/osmo_gsm_tester/templates/srsue.conf.tmpl index f1a5333..a75be23 100644 --- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl +++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl @@ -145,7 +145,7 @@ # mbms_service_port: Port of the MBMS service # [rrc] -% if int(ue.num_carriers) == 2: +% if int(ue.num_carriers) > 1: ue_category = 7 release = 10 % else: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Id96827960cac436b8ac363e28c2b0ab7b6acf57f Gerrit-Change-Number: 19187 Gerrit-PatchSet: 3 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: jenkins-build-srslte.sh: pass extra configuration_opts to build_repo
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19189 ) Change subject: jenkins-build-srslte.sh: pass extra configuration_opts to build_repo .. jenkins-build-srslte.sh: pass extra configuration_opts to build_repo this allows to pass extra CMake opts to, e.g., enable address sanitizer Change-Id: I6fd00025a7225b1e075704d69354a8eb5e7f30ec --- M contrib/jenkins-build-srslte.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins-build-srslte.sh b/contrib/jenkins-build-srslte.sh index dd75e86..80e4ffc 100755 --- a/contrib/jenkins-build-srslte.sh +++ b/contrib/jenkins-build-srslte.sh @@ -8,6 +8,6 @@ . "$(dirname "$0")/jenkins-build-common.sh" #TODO: make sure libconfig, zeroMQ is installed -build_repo $project_name +build_repo $project_name $configure_opts create_bin_tgz "srsue srsenb srsepc" -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6fd00025a7225b1e075704d69354a8eb5e7f30ec Gerrit-Change-Number: 19189 Gerrit-PatchSet: 3 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: enb_amarisoft: add support for PHY signal log file
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188 )
Change subject: enb_amarisoft: add support for PHY signal log file
..
enb_amarisoft: add support for PHY signal log file
when phy.signal=1 is set in the log_options, the eNB will dump
a binary file that needs to be copied back as well
Change-Id: I63d13cb74572ac065d5a3fcfb1632552d0a6dbc6
---
M src/osmo_gsm_tester/obj/enb_amarisoft.py
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_gsm_tester/obj/enb_amarisoft.py
b/src/osmo_gsm_tester/obj/enb_amarisoft.py
index c7a9810..657cb2e 100644
--- a/src/osmo_gsm_tester/obj/enb_amarisoft.py
+++ b/src/osmo_gsm_tester/obj/enb_amarisoft.py
@@ -49,6 +49,7 @@
CFGFILE_RF = 'amarisoft_rf_driver.cfg'
CFGFILE_DRB = 'amarisoft_drb.cfg'
LOGFILE = 'lteenb.log'
+PHY_SIGNAL_FILE = 'lteenb.log.bin'
def __init__(self, testenv, conf):
super().__init__(testenv, conf, 'amarisoftenb')
@@ -95,6 +96,11 @@
except Exception as e:
self.log(repr(e))
+try:
+self.rem_host.scpfrom('scp-back-phy-signal-log',
self.remote_phy_signal_file, self.phy_signal_file)
+except Exception as e:
+self.log(repr(e))
+
def start(self, epc):
self.log('Starting AmarisoftENB')
self._epc = epc
@@ -140,6 +146,7 @@
self.config_rf_file = self.run_dir.child(AmarisoftENB.CFGFILE_RF)
self.config_drb_file = self.run_dir.child(AmarisoftENB.CFGFILE_DRB)
self.log_file = self.run_dir.child(AmarisoftENB.LOGFILE)
+self.phy_signal_file = self.run_dir.child(AmarisoftENB.PHY_SIGNAL_FILE)
if not self._run_node.is_local():
self.rem_host = remote.RemoteHost(self.run_dir,
self._run_node.ssh_user(), self._run_node.ssh_addr())
@@ -153,6 +160,7 @@
self.remote_config_rf_file =
remote_run_dir.child(AmarisoftENB.CFGFILE_RF)
self.remote_config_drb_file =
remote_run_dir.child(AmarisoftENB.CFGFILE_DRB)
self.remote_log_file = remote_run_dir.child(AmarisoftENB.LOGFILE)
+self.remote_phy_signal_file =
remote_run_dir.child(AmarisoftENB.PHY_SIGNAL_FILE)
values = super().configure(['amarisoft', 'amarisoftenb'])
@@ -191,6 +199,9 @@
logfile = self.log_file if self._run_node.is_local() else
self.remote_log_file
config.overlay(values, dict(enb=dict(log_filename=logfile)))
+phy_signal_file = self.phy_signal_file if self._run_node.is_local()
else self.remote_phy_signal_file
+config.overlay(values, dict(enb=dict(phy_signal_file=phy_signal_file)))
+
# rf driver is shared between amarisoft enb and ue, so it has a
# different cfg namespace 'trx'. Copy needed values over there:
config.overlay(values,
dict(trx=dict(rf_dev_type=values['enb'].get('rf_dev_type', None),
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I63d13cb74572ac065d5a3fcfb1632552d0a6dbc6
Gerrit-Change-Number: 19188
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Reviewer: srs_andre
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: srsepc.conf.tmpl: zero-pad mnc and mcc in config
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19202 ) Change subject: srsepc.conf.tmpl: zero-pad mnc and mcc in config .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ie63cd1b15b961e493a6dcbd7e5a4fbabe0bb6f33 Gerrit-Change-Number: 19202 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 13:42:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 ) Change subject: enb_amarisoft: add option to enable and configure DL AWGN channel .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40 Gerrit-Change-Number: 19185 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Thu, 09 Jul 2020 13:42:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: rfemu_minicircuits: reset attenuation to zero in dtor
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19186 )
Change subject: rfemu_minicircuits: reset attenuation to zero in dtor
..
rfemu_minicircuits: reset attenuation to zero in dtor
this avoids issues when the channel emulation stops in the middle
of a high attenuation values and the device is left in this state.
Change-Id: I9aeafc68bf81b8932aac4cb28040b9aea6bfcbdb
---
M src/osmo_gsm_tester/obj/rfemu_minicircuits.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_gsm_tester/obj/rfemu_minicircuits.py
b/src/osmo_gsm_tester/obj/rfemu_minicircuits.py
index 6214040..c501dcf 100644
--- a/src/osmo_gsm_tester/obj/rfemu_minicircuits.py
+++ b/src/osmo_gsm_tester/obj/rfemu_minicircuits.py
@@ -42,6 +42,10 @@
raise log.Error('No "port" attribute provided in supply conf!')
self.set_name('minicircuits(%s:%r)' % (self.addr, self.ports))
+def __del__(self):
+self.dbg('Resetting channel attenuation to zero')
+self.set_attenuation(0)
+
def _url_prefix(self):
#http://10.12.1.216/:SetAttPerChan:1:0_2:0_3:0_4:0
return 'http://' + self.addr
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19186
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I9aeafc68bf81b8932aac4cb28040b9aea6bfcbdb
Gerrit-Change-Number: 19186
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: srsepc.conf.tmpl: zero-pad mnc and mcc in config
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19202 )
Change subject: srsepc.conf.tmpl: zero-pad mnc and mcc in config
..
srsepc.conf.tmpl: zero-pad mnc and mcc in config
srsEPC expect zero-padding MNC/MCC in config file. However,
001 and mcc will end up as 1 in the rendered template.
Therefore, they need to be formatted correctly.
Change-Id: Ie63cd1b15b961e493a6dcbd7e5a4fbabe0bb6f33
---
M src/osmo_gsm_tester/templates/srsepc.conf.tmpl
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
index f855127..830cd32 100644
--- a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
@@ -24,8 +24,8 @@
mme_code = 0x1a
mme_group = 0x0001
tac = 0x0007
-mcc = ${epc.mcc}
-mnc = ${epc.mnc}
+mcc = ${'{0:03}'.format(int(epc.mcc))}
+mnc = ${'{0:02}'.format(int(epc.mnc))}
mme_bind_addr = ${epc.run_addr}
apn = srsapn
dns_addr = 8.8.8.8
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19202
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ie63cd1b15b961e493a6dcbd7e5a4fbabe0bb6f33
Gerrit-Change-Number: 19202
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 )
Change subject: enb_amarisoft: add option to enable and configure DL AWGN
channel
..
enb_amarisoft: add option to enable and configure DL AWGN channel
expose option to enable DL AWGN noise and make SNR configurable
Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40
---
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/enb_amarisoft.py
M src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
M sysmocom/defaults.conf
4 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py
index d9fe1a5..be48887 100644
--- a/src/osmo_gsm_tester/obj/enb.py
+++ b/src/osmo_gsm_tester/obj/enb.py
@@ -36,6 +36,8 @@
'rf_dev_args': schema.STR,
'additional_args[]': schema.STR,
'enable_measurements': schema.BOOL_STR,
+'enable_dl_awgn': schema.BOOL_STR,
+'dl_awgn_snr': schema.INT,
'a1_report_type': schema.STR,
'a1_report_value': schema.INT,
'a1_hysteresis': schema.INT,
diff --git a/src/osmo_gsm_tester/obj/enb_amarisoft.py
b/src/osmo_gsm_tester/obj/enb_amarisoft.py
index 4b24844..c7a9810 100644
--- a/src/osmo_gsm_tester/obj/enb_amarisoft.py
+++ b/src/osmo_gsm_tester/obj/enb_amarisoft.py
@@ -160,6 +160,8 @@
self.enable_measurements =
util.str2bool(values['enb'].get('enable_measurements', 'false'))
config.overlay(values, dict(enb={'enable_measurements':
self.enable_measurements}))
+config.overlay(values, dict(enb={'enable_dl_awgn':
util.str2bool(values['enb'].get('enable_dl_awgn', 'false'))}))
+
# We need to set some specific variables programatically here to match
IP addresses:
if self._conf.get('rf_dev_type') == 'zmq':
base_srate = self.num_prb2base_srate(self.num_prb())
diff --git a/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
b/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
index 09532cc..7896ecb 100644
--- a/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
@@ -38,6 +38,13 @@
/* RF driver configuration */
include "amarisoft_rf_driver.cfg",
+% if enb.enable_dl_awgn:
+ channel_dl: {
+type: "awgn",
+snr: ${enb.dl_awgn_snr}
+ },
+% endif
+
mme_list: [
{
s1ap_bind_addr: "${enb.addr}",
diff --git a/sysmocom/defaults.conf b/sysmocom/defaults.conf
index 2c99e04..dd97456 100644
--- a/sysmocom/defaults.conf
+++ b/sysmocom/defaults.conf
@@ -113,6 +113,8 @@
transmission_mode: 1
num_cells: 1
enable_measurements: false
+ enable_dl_awgn: false
+ dl_awgn_snr: 30
a1_report_type: rsrp
a1_report_value: -105
a1_hysteresis: 0
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40
Gerrit-Change-Number: 19185
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Reviewer: srs_andre
Gerrit-MessageType: merged
Change in osmo-mgw[master]: manuals: generate vty reference xml at build time
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18927 ) Change subject: manuals: generate vty reference xml at build time .. Patch Set 3: > I can accept that (even though I dislike it). The questio is: Will this > patch create fall-out? I guess not in the OBS builds, as they (even those > for raspbian) are built "natively", and not cross-compiled. The sysmocom OE > builds are cross-compiled. Might be worth checking if they disable the build > of manuals before merging this. even if they build the vty reference, they would still build a vty reference from a different build... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I526af21134087e2b43b9ada59c93f636ae242e24 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 13:33:04 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-mgw[master]: refactor: use msgb to receive, pass and send RTP packets
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18913 ) Change subject: refactor: use msgb to receive, pass and send RTP packets .. Patch Set 4: > Patch Set 4: Code-Review+1 > > +1. assigning to dexter to determine if it should be merged now; I don't want > his work for E1 support to clash with this all over the place. yes, that's also why I think it would be good to get this patch in rather earlier than later, so that we can reduce merge conflicts -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3af40b63bc49f8636d4e7ea2f8f83bb67f6619ee Gerrit-Change-Number: 18913 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 13:31:36 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: SI2quater EARFCNs: span entire value range of EARFCNs
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19200 )
Change subject: bsc: SI2quater EARFCNs: span entire value range of EARFCNs
..
bsc: SI2quater EARFCNs: span entire value range of EARFCNs
Change-Id: I992771826d57669d06887c776303f85ef22f6c71
---
M bsc/BSC_Tests.ttcn
1 file changed, 31 insertions(+), 9 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index cba7e03..cc7346f 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1711,19 +1711,44 @@
f_init_bts_and_check_sysinfo(0, expect_si :=
SystemInformationConfig_default);
}
+/* We're testing SI2quater with lists of EARFCNs. Instead of just incrementing
EARFCNs, also pick some from the edges of
+ * the entire value range. This function provides the same EARFCN numbers for
the same earfcn_index */
+private function f_test_si2quater_earfcn_by_idx(integer earfcn_index) return
uint16_t
+{
+ select (earfcn_index) {
+ case (0) {
+ /* E-ARFCN 111 is already added in the osmo-bsc.cfg */
+ return 111;
+ }
+ case (1) {
+ return 1;
+ }
+ case (2) {
+ return 0;
+ }
+ case (3) {
+ return 65535;
+ }
+ case else {
+ return 23 * (earfcn_index - 3);
+ }
+ }
+}
+
function f_test_si2quater(integer total_earfcns, template
SystemInformationConfig expect_si) runs on test_CT {
f_init(0);
/* E-ARFCN 111 is already added in the osmo-bsc.cfg, so only add more
arfcns if total_earfcns > 1 */
for (var integer i := 1; i < total_earfcns; i := i + 1) {
- f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list add earfcn " &
int2str(22 + i) & " thresh-hi 20 thresh-lo 10 prio 3 qrxlv 22 meas 3"});
+ f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list add earfcn " &
int2str(f_test_si2quater_earfcn_by_idx(i))
+& " thresh-hi 20 thresh-lo 10 prio 3 qrxlv
22 meas 3"});
}
f_init_bts_and_check_sysinfo(0, expect_si := expect_si);
for (var integer i := 1; i < total_earfcns; i := i + 1) {
- f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list del earfcn " &
int2str(22 + i)});
+ f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list del earfcn " &
int2str(f_test_si2quater_earfcn_by_idx(i))});
}
}
@@ -1733,11 +1758,7 @@
var integer si2quater_count := (count + 2) / 3;
for (var integer i := 0; i < count; i := i + 1) {
- var integer earfcn := 22 + i;
- /* First earfcn is 111 from osmo-bsc.cfg */
- if (i == 0) {
- earfcn := 111;
- }
+ var integer earfcn := f_test_si2quater_earfcn_by_idx(i);
var integer index := i / 3;
var integer earfcn_index := i mod 3;
if (index >= lengthof(si2quater)) {
@@ -1808,7 +1829,8 @@
f_init(0);
for (var integer i := 1; i < 48; i := i + 1) {
- f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list add earfcn " &
int2str(22 + i) & " thresh-hi 20 thresh-lo 10 prio 3 qrxlv 22 meas 3"});
+ f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list add earfcn " &
int2str(f_test_si2quater_earfcn_by_idx(i))
+& " thresh-hi 20 thresh-lo 10 prio 3 qrxlv
22 meas 3"});
}
/* The 49th EARFCN no longer fits, expect VTY error */
@@ -1828,7 +1850,7 @@
f_init_bts_and_check_sysinfo(0, expect_si := sic);
for (var integer i := 1; i < 48; i := i + 1) {
- f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list del earfcn " &
int2str(22 + i)});
+ f_bts_0_cfg(BSCVTY, {"si2quater neighbor-list del earfcn " &
int2str(f_test_si2quater_earfcn_by_idx(i))});
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19200
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I992771826d57669d06887c776303f85ef22f6c71
Gerrit-Change-Number: 19200
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: bsc: more SI2quater EUTRAN ARFCN tests
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19181 )
Change subject: bsc: more SI2quater EUTRAN ARFCN tests
..
bsc: more SI2quater EUTRAN ARFCN tests
Add more EUTRAN ARFCNs, reaching the maximum allowed amount.
Add tests with 12, 23, 42 EARFCNs, just for the sake of testing some arbitrary
numbers.
Add tests with 32 and 33 EARFCNs because before osmo-bsc
Iabeed10053ee5899b4def3509aedd25abb2410a9, only 32 EARFCNs could be stored by
osmo-bsc.
Add a test with 48 EARFCNs to verify the maximum amount of EARFCNs and maximum
amount of SI2quater multiplexes works as expected.
Add a test with 49 EARFCNs to verify the VTY error response when adding too
many EARFCNs, and showing that osmo-bsc still sends 16 SI2quater with 48
EARFCNs.
Depends: Iabeed10053ee5899b4def3509aedd25abb2410a9 (osmo-bsc)
Change-Id: I99bf9b3381812d1db6fd0757f65995bae48da776
---
M bsc/BSC_Tests.ttcn
M library/GSM_RestOctets.ttcn
2 files changed, 99 insertions(+), 116 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index f1aea75..cba7e03 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -61,6 +61,7 @@
import from GSM_SystemInformation all;
import from GSM_RestOctets all;
+import from TCCConversion_Functions all;
const integer NUM_BTS := 3;
const integer NUM_MSC := 3;
@@ -96,7 +97,7 @@
SystemInformationType2 si2 optional,
SystemInformationType2bis si2bis optional,
SystemInformationType2ter si2ter optional,
- record of SI2quaterRestOctets si2quater optional,
+ SI2quaterRestOctetsList si2quater optional,
SystemInformationType3 si3 optional,
SystemInformationType4 si4 optional,
/* TODO: replace with proper decoding of SI13, implement SI13 in
GSM_SystemInformation.ttcn */
@@ -1726,135 +1727,109 @@
}
}
-testcase TC_si2quater_2_earfcns() runs on test_CT {
+private function f_tr_si2quater_earfcns(integer count) return template
SI2quaterRestOctetsList
+{
+ var template SI2quaterRestOctetsList si2quater := {};
+ var integer si2quater_count := (count + 2) / 3;
+
+ for (var integer i := 0; i < count; i := i + 1) {
+ var integer earfcn := 22 + i;
+ /* First earfcn is 111 from osmo-bsc.cfg */
+ if (i == 0) {
+ earfcn := 111;
+ }
+ var integer index := i / 3;
+ var integer earfcn_index := i mod 3;
+ if (index >= lengthof(si2quater)) {
+ si2quater[index] := tr_SI2quaterRestOctets_EUTRAN(index
:= index, count := si2quater_count - 1);
+ }
+
si2quater[index].rel_additions.rel5.rel6.rel7.rel8.prio_eutran_params_desc.desc.eutran_params_desc.desc.repeated_neigh_cells[0].cell_desc_list[earfcn_index]
:= tr_EUTRAN_CellDesc_default(e_arfcn := earfcn);
+ }
+
+ return si2quater;
+}
+
+private function f_tc_si2quater_n_earfcns(integer n) runs on test_CT
+{
var template SystemInformationConfig sic :=
SystemInformationConfig_default;
- sic.si2quater := {
- tr_SI2quaterRestOctets_EUTRAN(
- repeated_neigh_cells := {
- tr_EUTRAN_NeighbourCells_default(
- cell_desc_list := {
-
tr_EUTRAN_CellDesc_default(e_arfcn := 111),
-
tr_EUTRAN_CellDesc_default(e_arfcn := 23)
- }
- )
- }
- )
- };
- f_test_si2quater(2, sic);
+sic.si2quater := f_tr_si2quater_earfcns(n);
+ f_test_si2quater(n, sic);
+}
+
+testcase TC_si2quater_2_earfcns() runs on test_CT {
+ f_tc_si2quater_n_earfcns(2);
}
testcase TC_si2quater_3_earfcns() runs on test_CT {
- var template SystemInformationConfig sic :=
SystemInformationConfig_default;
- sic.si2quater := {
- tr_SI2quaterRestOctets_EUTRAN(
- repeated_neigh_cells := {
- tr_EUTRAN_NeighbourCells_default(
- cell_desc_list := {
-
tr_EUTRAN_CellDesc_default(e_arfcn := 111),
-
tr_EUTRAN_CellDesc_default(e_arfcn := 23),
-
tr_EUTRAN_CellDesc_default(e_arfcn := 24)
- }
- )
- }
- )
- };
- f_test_si2quater(3, sic);
+ f_tc_si2quater_n_earfcns(3);
}
testcase TC_si2quater_4_earfcns() runs on test_CT {
-
Change in osmo-ttcn3-hacks[master]: BSC_Tests: extend TC_chan_act_ack_noest with emergency call
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19203 )
Change subject: BSC_Tests: extend TC_chan_act_ack_noest with emergency call
..
BSC_Tests: extend TC_chan_act_ack_noest with emergency call
TC_chan_act_ack_noest requests a channel and then releases it again.
However, this does not test yet what happens if the requestor (BTS) uses
a request reference that indicates an emergancy call. Depending on the
configuration the BSC should reject or allow the channel to be
established.
Change-Id: If828c0f5786d89efa7608f38d648e2a2b8f6f675
Related: OS#4549
---
M bsc/BSC_Tests.ttcn
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/03/19203/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index f1aea75..7762906 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -972,13 +972,13 @@
}
/* CHAN RQD -> CHAN ACT -> CHAN ACT ACK -> RF CHAN REL */
-testcase TC_chan_act_ack_noest() runs on test_CT {
+private function f_TC_chan_act_ack_noest(OCT1 ra := '23'O) runs on test_CT {
var RSL_Message rx_rsl;
f_init(1);
/* Send CHAN RQD and wait for allocation; acknowledge it */
- var RslChannelNr chan_nr := f_chreq_act_ack();
+ var RslChannelNr chan_nr := f_chreq_act_ack(ra);
/* expect BSC to disable the channel again if there's no RLL EST IND */
rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL),
T3101_MAX);
@@ -986,6 +986,17 @@
setverdict(pass);
}
+/* Normal variant */
+testcase TC_chan_act_ack_noest() runs on test_CT {
+f_TC_chan_act_ack_noest();
+}
+
+/* Emergency call variant */
+testcase TC_chan_act_ack_noest_emerg() runs on test_CT {
+/* See also: 3GPP TS 04.08, Table 9.9, ra=101x */
+f_TC_chan_act_ack_noest(ra := 'A5'O);
+}
+
/* Test behavior if MSC never answers to CR */
testcase TC_chan_act_ack_est_ind_noreply() runs on test_CT {
var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
@@ -5830,6 +5841,7 @@
execute( TC_chan_act_noreply() );
execute( TC_chan_act_counter() );
execute( TC_chan_act_ack_noest() );
+ execute( TC_chan_act_ack_noest_emerg() );
execute( TC_chan_act_ack_est_ind_noreply() );
execute( TC_chan_act_ack_est_ind_refused() );
execute( TC_chan_act_nack() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19203
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If828c0f5786d89efa7608f38d648e2a2b8f6f675
Gerrit-Change-Number: 19203
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: BTS_Tests: extend rach content tests with emergency call
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19198 )
Change subject: BTS_Tests: extend rach content tests with emergency call
..
BTS_Tests: extend rach content tests with emergency call
The testcase tests if a CHANNEL REQUEST on the RACH leads to the correct
CHANNEL REQUIRED message on RSL level. When a MS is sending a CHANNEL
REQUEST to establish an emergency call, it uses a slightly different
layout for the request reference (RA). Lets add another similar testcase
(TC_rach_content_emerg) to cover the emergency call situation as well.
Change-Id: Ie5b7af3e93efaa6d0b412d3b1c77bc9514424f52
Related: OS#4549
---
M bts/BTS_Tests.ttcn
1 file changed, 35 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 1ff0c61..587e14a 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1296,6 +1296,14 @@
return false;
}
+private function ra_is_emerg(OCT1 ra) return boolean {
+ /* See also: 3GPP TS 04.08, Table 9.9, ra=101x */
+ if ((ra and4b 'E0'O == 'A0'O) and (ra and4b '1F'O != '1F'O)) {
+ return true;
+ }
+ return false;
+}
+
/* generate a random RACH for circuit-switched */
private function f_rnd_ra_cs() return OCT1 {
var OCT1 ra;
@@ -1305,6 +1313,15 @@
return ra;
}
+/* generate a random RACH for emergency */
+private function f_rnd_ra_emerg() return OCT1 {
+ var OCT1 ra;
+ do {
+ ra := f_rnd_octstring(1);
+ } while (not ra_is_emerg(ra));
+ return ra;
+}
+
/* generate a random RACH for packet-switched */
private function f_rnd_ra_ps() return OCT1 {
var OCT1 ra;
@@ -1321,7 +1338,7 @@
}
/* Send 1000 RACH requests and check their RA+FN on the RSL side */
-testcase TC_rach_content() runs on test_CT {
+private function f_TC_rach_content(boolean emerg) runs on test_CT {
f_init();
f_init_l1ctl();
f_l1_tune(L1CTL);
@@ -1329,7 +1346,12 @@
var GsmFrameNumber fn_last := 0;
var boolean test_failed := false;
for (var integer i := 0; i < 1000; i := i+1) {
- var OCT1 ra := f_rnd_ra_cs();
+ var OCT1 ra := f_rnd_ra_emerg();
+ if (emerg == true) {
+ ra := f_rnd_ra_emerg();
+ } else {
+ ra := f_rnd_ra_cs();
+ }
var GsmFrameNumber fn := f_L1CTL_RACH(L1CTL, oct2int(ra));
if (fn == fn_last) {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Two
RACH in same FN?!?");
@@ -1359,6 +1381,16 @@
Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
+/* Normal variant */
+testcase TC_rach_content() runs on test_CT {
+f_TC_rach_content(emerg := false);
+}
+
+/* Emergency call variant */
+testcase TC_rach_content_emerg() runs on test_CT {
+f_TC_rach_content(emerg := true);
+}
+
/* Send 1000 RACH Requests (flood ~ 89/s) and count if count(Abis) ==
count(Um) */
testcase TC_rach_count() runs on test_CT {
f_init();
@@ -6683,6 +6715,7 @@
execute( TC_sacch_chan_act_ho_async() );
execute( TC_sacch_chan_act_ho_sync() );
execute( TC_rach_content() );
+ execute( TC_rach_content_emerg() );
execute( TC_rach_count() );
execute( TC_rach_max_ta() );
execute( TC_ho_rach() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19198
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie5b7af3e93efaa6d0b412d3b1c77bc9514424f52
Gerrit-Change-Number: 19198
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel
srs_andre has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 )
Change subject: enb_amarisoft: add option to enable and configure DL AWGN
channel
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py
File src/osmo_gsm_tester/obj/enb_amarisoft.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py@164
PS1, Line 164: config.overlay(values, dict(enb={'dl_awgn_snr':
values['enb'].get('dl_awgn_snr', 30)}))
> Fine with keeping the enable_ var then, simply work on the defaults.conf part.
Should be done.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40
Gerrit-Change-Number: 19185
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 09 Jul 2020 12:39:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: srs_andre
Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 )
Change subject: enb_amarisoft: add option to enable and configure DL AWGN
channel
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py
File src/osmo_gsm_tester/obj/enb_amarisoft.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py@164
PS1, Line 164: config.overlay(values, dict(enb={'dl_awgn_snr':
values['enb'].get('dl_awgn_snr', 30)}))
> Good idea about the false in the defaults.conf. […]
Fine with keeping the enable_ var then, simply work on the defaults.conf part.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40
Gerrit-Change-Number: 19185
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 09 Jul 2020 12:35:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: srs_andre
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb_amarisoft: add support for PHY signal log file
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188 ) Change subject: enb_amarisoft: add support for PHY signal log file .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I63d13cb74572ac065d5a3fcfb1632552d0a6dbc6 Gerrit-Change-Number: 19188 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Thu, 09 Jul 2020 12:34:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb_amarisoft: add support for PHY signal log file
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188 to look at the new patch set (#2). Change subject: enb_amarisoft: add support for PHY signal log file .. enb_amarisoft: add support for PHY signal log file when phy.signal=1 is set in the log_options, the eNB will dump a binary file that needs to be copied back as well Change-Id: I63d13cb74572ac065d5a3fcfb1632552d0a6dbc6 --- M src/osmo_gsm_tester/obj/enb_amarisoft.py 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/88/19188/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I63d13cb74572ac065d5a3fcfb1632552d0a6dbc6 Gerrit-Change-Number: 19188 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: srsepc.conf.tmpl: zero-pad mnc and mcc in config
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19202 )
Change subject: srsepc.conf.tmpl: zero-pad mnc and mcc in config
..
srsepc.conf.tmpl: zero-pad mnc and mcc in config
srsEPC expect zero-padding MNC/MCC in config file. However,
001 and mcc will end up as 1 in the rendered template.
Therefore, they need to be formatted correctly.
Change-Id: Ie63cd1b15b961e493a6dcbd7e5a4fbabe0bb6f33
---
M src/osmo_gsm_tester/templates/srsepc.conf.tmpl
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/02/19202/1
diff --git a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
index f855127..830cd32 100644
--- a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
@@ -24,8 +24,8 @@
mme_code = 0x1a
mme_group = 0x0001
tac = 0x0007
-mcc = ${epc.mcc}
-mnc = ${epc.mnc}
+mcc = ${'{0:03}'.format(int(epc.mcc))}
+mnc = ${'{0:02}'.format(int(epc.mnc))}
mme_bind_addr = ${epc.run_addr}
apn = srsapn
dns_addr = 8.8.8.8
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19202
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ie63cd1b15b961e493a6dcbd7e5a4fbabe0bb6f33
Gerrit-Change-Number: 19202
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 to look at the new patch set (#2). Change subject: enb_amarisoft: add option to enable and configure DL AWGN channel .. enb_amarisoft: add option to enable and configure DL AWGN channel expose option to enable DL AWGN noise and make SNR configurable Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40 --- M src/osmo_gsm_tester/obj/enb.py M src/osmo_gsm_tester/obj/enb_amarisoft.py M src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl M sysmocom/defaults.conf 4 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/85/19185/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40 Gerrit-Change-Number: 19185 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: srs_andre Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel
srs_andre has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 )
Change subject: enb_amarisoft: add option to enable and configure DL AWGN
channel
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py
File src/osmo_gsm_tester/obj/enb_amarisoft.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py@164
PS1, Line 164: config.overlay(values, dict(enb={'dl_awgn_snr':
values['enb'].get('dl_awgn_snr', 30)}))
> Looks like you only really need to add 30 to defaults.conf and get rid of
> this line? […]
Good idea about the false in the defaults.conf.
But I think the boolean to enable/disable it is still needed. Note that
basically any real value is a valid SNR. Ok, -1000 is not realistic but I guess
rather than using such a magic number we can have the boolean and make it
explicit.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40
Gerrit-Change-Number: 19185
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 09 Jul 2020 12:28:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: extend rach content tests with emergency call
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19198 ) Change subject: BTS_Tests: extend rach content tests with emergency call .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5b7af3e93efaa6d0b412d3b1c77bc9514424f52 Gerrit-Change-Number: 19198 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 12:27:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb_amarisoft: add support for PHY signal log file
srs_andre has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188 )
Change subject: enb_amarisoft: add support for PHY signal log file
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188/1/src/osmo_gsm_tester/obj/enb_amarisoft.py
File src/osmo_gsm_tester/obj/enb_amarisoft.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188/1/src/osmo_gsm_tester/obj/enb_amarisoft.py@96
PS1, Line 96: self.rem_host.scpfrom('scp-back-phy-signal-log',
self.remote_phy_signal_file, self.phy_signal_file)
> Better put it in a separate try except block, so that if log_file is not
> there for whatever reason, […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19188
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I63d13cb74572ac065d5a3fcfb1632552d0a6dbc6
Gerrit-Change-Number: 19188
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Reviewer: srs_andre
Gerrit-Comment-Date: Thu, 09 Jul 2020 12:25:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-virt: Don't rely on gsmtap_makemsg() returning NULL for GSMTAP_CH...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19161 ) Change subject: bts-virt: Don't rely on gsmtap_makemsg() returning NULL for GSMTAP_CHANNEL_UNKNOWN .. Patch Set 1: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I233afd930d3e43f7b120d40192c7c192102e38d9 Gerrit-Change-Number: 19161 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 11:44:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Revert "gsmtap_makemsg_ex: NULL for unknown chan_type"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19067 ) Change subject: Revert "gsmtap_makemsg_ex: NULL for unknown chan_type" .. Patch Set 2: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ebaa89cc3422df1d7fd2365a6176cb2902d1c67 Gerrit-Change-Number: 19067 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 11:43:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-virt: Don't rely on gsmtap_makemsg() returning NULL for GSMTAP_CH...
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/19161 )
Change subject: bts-virt: Don't rely on gsmtap_makemsg() returning NULL for
GSMTAP_CHANNEL_UNKNOWN
..
bts-virt: Don't rely on gsmtap_makemsg() returning NULL for
GSMTAP_CHANNEL_UNKNOWN
commit d211c490cad38f2009943121d57bdb7df8eee9b0 avoided sending
GSMTAP packets on the virtual Um interface with type
GSMTAP_CHANNEL_UNKNOWN by relying on gsmtap_makemsg returning NULL.
But that's not the corect approach since it's totally fine to be sending
GSMTAP_CHANNEL_UNKNOWN on some GSMTAP cases (for instance when the
program fails to infer the type when decoding a message), since then
this way one can study pcap files and find the offending encoded
messages which failed to be decoded.
This patch goes togehter with revert patch introduced in libosmocore as
explained in the commit referred above.
Change-Id: I233afd930d3e43f7b120d40192c7c192102e38d9
---
M src/osmo-bts-virtual/scheduler_virtbts.c
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Hoernchen: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c
b/src/osmo-bts-virtual/scheduler_virtbts.c
index 1c2b057..466e864 100644
--- a/src/osmo-bts-virtual/scheduler_virtbts.c
+++ b/src/osmo-bts-virtual/scheduler_virtbts.c
@@ -78,9 +78,12 @@
else
gsmtap_chantype = chantype_rsl2gsmtap2(rsl_chantype,
chdesc->link_id, is_voice_frame); /* the logical channel type */
- if (gsmtap_chantype == GSMTAP_CHANNEL_UNKNOWN)
+ if (gsmtap_chantype == GSMTAP_CHANNEL_UNKNOWN) {
LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "Tx GSMTAP for RSL
channel type 0x%02x: cannot send, this"
" channel type is unknown in GSMTAP\n", rsl_chantype);
+ msgb_free(msg);
+ return;
+ }
#if MODULO_HYPERFRAME
/* Restart fn after every superframe (26 * 51 frames) to simulate
hyperframe overflow each 6 seconds. */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19161
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I233afd930d3e43f7b120d40192c7c192102e38d9
Gerrit-Change-Number: 19161
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: Revert "gsmtap_makemsg_ex: NULL for unknown chan_type"
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19067 ) Change subject: Revert "gsmtap_makemsg_ex: NULL for unknown chan_type" .. Revert "gsmtap_makemsg_ex: NULL for unknown chan_type" Reverting due to being completely normal for some applications to submit usning this channel type when decoding/parsing failed and hence not being able to determine channel type. This reverts Change-Id Ib4147a33a75c3cf425c30da8b0678c7fba8a371d (commit 12f93be6073ed89055862baafbfe0e08e50ed17a.) Change-Id: I6ebaa89cc3422df1d7fd2365a6176cb2902d1c67 --- M src/gsmtap_util.c 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c index 8674f1c..9a0ac02 100644 --- a/src/gsmtap_util.c +++ b/src/gsmtap_util.c @@ -169,8 +169,7 @@ * \param[in] snr Signal/Noise Ratio (SNR) * \param[in] data Pointer to data buffer * \param[in] len Length of \ref data - * \return dynamically allocated message buffer containing data, - * or NULL for unknown chan_type + * \return dynamically allocated message buffer containing data * * This function will allocate a new msgb and fill it with a GSMTAP * header containing the information @@ -183,9 +182,6 @@ struct gsmtap_hdr *gh; uint8_t *dst; - if (chan_type == GSMTAP_CHANNEL_UNKNOWN) - return NULL; - msg = msgb_alloc(sizeof(*gh) + len, "gsmtap_tx"); if (!msg) return NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ebaa89cc3422df1d7fd2365a6176cb2902d1c67 Gerrit-Change-Number: 19067 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: merged
Change in osmo-pcu[master]: pdch.cpp: Store TLLI promptly on newly created TLLI in rcv_resource_r...
Hello fixeria, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/19197 to look at the new patch set (#2). Change subject: pdch.cpp: Store TLLI promptly on newly created TLLI in rcv_resource_request .. pdch.cpp: Store TLLI promptly on newly created TLLI in rcv_resource_request The TLLI is tried to be updated later anyway during tbf_alloc_ul(), but this way it's clear that information is stored where it belongs as soon as possible. The change already shows clearer log lines in TbfTest.err. Change-Id: I20ce4eb94ecf85ce2835275d0056d9ecd1b558c3 --- M src/pdch.cpp M tests/tbf/TbfTest.err 2 files changed, 91 insertions(+), 90 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/19197/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I20ce4eb94ecf85ce2835275d0056d9ecd1b558c3 Gerrit-Change-Number: 19197 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: encoding.cpp: Fix missing spacing in function param
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/19193 to look at the new patch set (#2). Change subject: encoding.cpp: Fix missing spacing in function param .. encoding.cpp: Fix missing spacing in function param Change-Id: I4f30a0cea615d57cd7783a92ae782790c8075a6c --- M src/encoding.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/93/19193/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4f30a0cea615d57cd7783a92ae782790c8075a6c Gerrit-Change-Number: 19193 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: pdch.cpp: Avoid dropping existing DL TBF during rcv_resource_request
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/19194 to look at the new patch set (#2). Change subject: pdch.cpp: Avoid dropping existing DL TBF during rcv_resource_request .. pdch.cpp: Avoid dropping existing DL TBF during rcv_resource_request There's no real good explanation on why the DL TBF is dropped there, since PKT RESOUCE REQUEST is used basically during UL TBF establishment. Also, as decribed by TS 44.060 11.2.16 "Packet Resource Request": """ This message is sent on the PACCH by the mobile station to the network to request a change in the uplink resources assigned. """ Change-Id: Iab4afb66f0d671f7ad54909d2685a1613e12ab4d --- M src/pdch.cpp M tests/tbf/TbfTest.err 2 files changed, 0 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/94/19194/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iab4afb66f0d671f7ad54909d2685a1613e12ab4d Gerrit-Change-Number: 19194 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19196 ) Change subject: pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq received .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19196/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19196/1/src/pdch.cpp@574 PS1, Line 574:"MS requests UL TBF in PACKET RESOURCE REQ of " > (seems odd to trivially tweak the log message to uppercase; in the test log > other logging still prin […] Uppercase is already used in other log lines in this file, and it matches what wireshark uses, as well as making it easier to understand it's a packet type and not some description. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4b4367126d6a16055cd2f45afc4a6b9c15a7c980 Gerrit-Change-Number: 19196 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 11:40:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in osmo-pcu[master]: pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq...
Hello neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/19196 to look at the new patch set (#2). Change subject: pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq received .. pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq received It's perfectly fine receiving a Resource Request message under some circumstances (as stated in the comment added in the commit). To print issues only under non-expected circumstances, the function rcv_resource_request need to be refactored: * Destroying older UL_TBF is delayed because it is needed further down. * When the old UL_TBF is FINISHED, it's an acceptable time to receive a Resource request, so we check if that's the case and don't print a warning in that case. Change-Id: I4b4367126d6a16055cd2f45afc4a6b9c15a7c980 --- M src/pdch.cpp M tests/tbf/TbfTest.err 2 files changed, 22 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/19196/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4b4367126d6a16055cd2f45afc4a6b9c15a7c980 Gerrit-Change-Number: 19196 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in...
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/19195 to look at the new patch set (#2). Change subject: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in MS RadioAccCap .. pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in MS RadioAccCap If the information is not found in the message, 0 (unknown MS class) will be returned. If the MS already had some previous information on the MS class, let's not lose it by setting it back to 0. Take the opportunity to drop related log lines which are no needed, since set_(egprs_)ms_class() functions already log the value changes. Change-Id: Icd52209fd4395d78dc770e7869d1b1fe45a18ca0 --- M src/pdch.cpp M tests/tbf/TbfTest.err 2 files changed, 6 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/95/19195/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icd52209fd4395d78dc770e7869d1b1fe45a18ca0 Gerrit-Change-Number: 19195 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: encoding: Encode TA as unsigned and check validty against GSM48_TA_IN...
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/19176 to look at the new patch set (#3). Change subject: encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID .. encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID According to 3GPP TS 44.018 sec 10.5.2.40, Timing Advance value is 8 bit and range is 0-63 (0-219 on GSM400). Unsigned value (uint8_t) is used everywhere else, so avoid using a signed one here, and simply check for GSM48_TA_INVALID here, which we use everywhere else to initialize when the value is not known. Ideally we should check for value based on band, but it makes more sense to check that when receiving the data and storing in in set_ta(). Change-Id: I82b13561d0fe5ebafb5c3a8b9a501045c29809bc --- M src/encoding.cpp 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/19176/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I82b13561d0fe5ebafb5c3a8b9a501045c29809bc Gerrit-Change-Number: 19176 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: neels Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19195 ) Change subject: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in MS RadioAccCap .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/tests/tbf/TbfTest.err File tests/tbf/TbfTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/tests/tbf/TbfTest.err@a3113 PS1, Line 3113: EGPRS MS class 0 -> 1 > likely this is where it is logged already, just one line above. Indeed. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icd52209fd4395d78dc770e7869d1b1fe45a18ca0 Gerrit-Change-Number: 19195 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 11:38:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-pcu[master]: pdch.cpp: Avoid dropping existing DL TBF during rcv_resource_request
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19194 ) Change subject: pdch.cpp: Avoid dropping existing DL TBF during rcv_resource_request .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19194/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19194/1/src/pdch.cpp@570 PS1, Line 570: RACH > this is then also wrong. We're processing a packet resource request, not RACH > here. […] Indeed, it's wrong, but unrelated to this patch. I'm fixing it in next commits. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iab4afb66f0d671f7ad54909d2685a1613e12ab4d Gerrit-Change-Number: 19194 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Jul 2020 11:38:03 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-bts[master]: common: Avoid changing OPSTATE to Enabled upon RSL up
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/19156 to look at the new patch set (#2). Change subject: common: Avoid changing OPSTATE to Enabled upon RSL up .. common: Avoid changing OPSTATE to Enabled upon RSL up the RSL link has nothing to do regarding the state of the Radio Carrier, as in it being up is not enough to have a working (enabled) Radio Carrier. Change-Id: Iefb5c4e1097233b5c31e4d621c544d51516af678 --- M src/common/bts_trx.c 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/19156/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iefb5c4e1097233b5c31e4d621c544d51516af678 Gerrit-Change-Number: 19156 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: Move struct gsm_bts_trx: gsm_data.* & bts.* => bts_trx.*
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/19124 to look at the new patch set (#3). Change subject: Move struct gsm_bts_trx: gsm_data.* & bts.* => bts_trx.* .. Move struct gsm_bts_trx: gsm_data.* & bts.* => bts_trx.* Move all struct gsm_bts_trx references from bulky gsm_data to its own file containing all related definitions and implementations. Also move a few functions clearly related to that object which were placed in bts.* Change-Id: Iebaf5b221c48b571f45408af867ce6f9c0cd9f4a --- M include/osmo-bts/Makefile.am M include/osmo-bts/bts.h A include/osmo-bts/bts_trx.h M include/osmo-bts/gsm_data.h M include/osmo-bts/phy_link.h M src/common/Makefile.am M src/common/abis.c M src/common/bts.c M src/common/bts_ctrl_lookup.c A src/common/bts_trx.c M src/common/gsm_data.c M src/common/sysinfo.c M src/common/tx_power.c 13 files changed, 283 insertions(+), 237 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/24/19124/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iebaf5b221c48b571f45408af867ce6f9c0cd9f4a Gerrit-Change-Number: 19124 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: bsc: more SI2quater EUTRAN ARFCN tests
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19181 ) Change subject: bsc: more SI2quater EUTRAN ARFCN tests .. Patch Set 3: Code-Review+2 Thanks, that looks a lot better now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I99bf9b3381812d1db6fd0757f65995bae48da776 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 11:15:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/scheduler: check TDMA frame order, drop out of order bursts
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/19201 )
Change subject: trxcon/scheduler: check TDMA frame order, drop out of order
bursts
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmocom-bb/+/19201/2/src/host/trxcon/sched_trx.c
File src/host/trxcon/sched_trx.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/19201/2/src/host/trxcon/sched_trx.c@723
PS2, Line 723: if (fn < lchan->tdma.last_proc) {
> Don't you need to consider wrap around in here?
Nice catch! Thanks.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772
Gerrit-Change-Number: 19201
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 09 Jul 2020 11:14:26 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/scheduler: check TDMA frame order, drop out of order bursts
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/19201 )
Change subject: trxcon/scheduler: check TDMA frame order, drop out of order
bursts
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmocom-bb/+/19201/2/src/host/trxcon/sched_trx.c
File src/host/trxcon/sched_trx.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/19201/2/src/host/trxcon/sched_trx.c@723
PS2, Line 723: if (fn < lchan->tdma.last_proc) {
Don't you need to consider wrap around in here?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772
Gerrit-Change-Number: 19201
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 09 Jul 2020 11:10:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h File include/osmocom/gsm/protocol/gsm_12_21.h: https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@514 PS2, Line 514: , /* not sure if it is legal to have two enum members map to the same value (NM_ATT_BS11_PASSWORD just a few lines above). We may have to eithe use unique values, or move to a different enum or #defines for the osmcoom specific NM_ATT. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:56:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bts_features: add feature BTS_FEAT_IPV6_NSVC
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19145 ) Change subject: bts_features: add feature BTS_FEAT_IPV6_NSVC .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19145/2/include/osmocom/gsm/bts_features.h File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/19145/2/include/osmocom/gsm/bts_features.h@28 PS2, Line 28: BTS_FEAT_IPV6_NSVC, > What's the point in using this? Why not simply using a correct IP address > type when configuring (con […] The NSVC remote IP address is specified in the BSC config file. IT is passed in vendor-specific OML IEs to the BTS. Existing versions of (nanobts, osmo-bts) only support IPv4 here. So we need a way how the BSC can identify if the BTS (and the BTS-colocated PCU) support the new additional IE for IPv6 address. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9ef7949f66764b3c639e45eb440122e318da44a0 Gerrit-Change-Number: 19145 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:55:16 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: socket.c: fix osmo_sock_get_ip_and_port for IPv6
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19147 ) Change subject: socket.c: fix osmo_sock_get_ip_and_port for IPv6 .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19147/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/19147/1//COMMIT_MSG@9 PS1, Line 9: The struct sockaddr is too small for IPv6. IPv6 has a 16 byte address, while > Hmm I thought struct sockaddr was a struct big enough to hold any address? 'struct sockaddr_storage' is large enough for [at leaast] IPv4 and IPv6. I don't think 'struct sockaddr' should ever be used directly , other than some kind of abstract data type to which you cast pointers when calling socket API. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4e69d814367168c05f0da161ec9b705db36ad096 Gerrit-Change-Number: 19147 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:53:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: socket.c add osmo_sockaddr_valid()
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/19144 )
Change subject: socket.c add osmo_sockaddr_valid()
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/19144/2/src/socket.c
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/19144/2/src/socket.c@1532
PS2, Line 1532: if (addr->u.sas.ss_family == AF_INET) {
> So indeed you are using one of the fields in a substruct of the union to find
> out the type. […]
it's a non-issue AFAICT, see my comment to another patch.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19144
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib6fb050e1bfe3f3a8d8bbe5e762351ce6b7cc48c
Gerrit-Change-Number: 19144
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-CC: laforge
Gerrit-Comment-Date: Thu, 09 Jul 2020 10:52:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in libosmocore[master]: socket.c: introduce osmo_sock_init3 & osmo_sock_init3_ofd
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 ) Change subject: socket.c: introduce osmo_sock_init3 & osmo_sock_init3_ofd .. Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@448 PS2, Line 448: #define OSMO_SOCKADDR_TO_STR(sockaddr) \ > I don't get how this macro is supposed to work. […] Ack https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@451 PS2, Line 451: strcpy(sastr.ip, "Invalid IP") > osmo_strlcpy Ack https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@453 PS2, Line 453: int osmo_sock_init3(uint16_t type, uint8_t proto, > Missing documentation Ack https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@931 PS2, Line 931: return osmo_fd_init_ofd(ofd, osmo_sock_init3(type, proto, local, remote, flags)); > passing -1 to osmo_fd_init_ofd if osmo_sock_init3 fails? No thanks. Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 10:51:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: socket.h: introduce osmo_sockaddr to hold v4 and v6 endpoints
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19141 ) Change subject: socket.h: introduce osmo_sockaddr to hold v4 and v6 endpoints .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If80172373735193401af872b18e1ff00c93880e7 Gerrit-Change-Number: 19141 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:47:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns.h: add missing prototype gprs_ns_rcvmsg()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19138 ) Change subject: gprs_ns.h: add missing prototype gprs_ns_rcvmsg() .. gprs_ns.h: add missing prototype gprs_ns_rcvmsg() gprs_ns_rcvmsg is already exported, but never declared. Change-Id: I7edc5f4fb6e1fda059e35ea0988d0ef42208aa50 --- M include/osmocom/gprs/gprs_ns.h 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/gprs/gprs_ns.h b/include/osmocom/gprs/gprs_ns.h index 65c7df3..af25825 100644 --- a/include/osmocom/gprs/gprs_ns.h +++ b/include/osmocom/gprs/gprs_ns.h @@ -188,6 +188,11 @@ /* main function for higher layers (BSSGP) to send NS messages */ int gprs_ns_sendmsg(struct gprs_ns_inst *nsi, struct msgb *msg); +/* Receive incoming NS message from underlying transport layer */ +int gprs_ns_rcvmsg(struct gprs_ns_inst *nsi, struct msgb *msg, + struct sockaddr_in *saddr, enum gprs_ns_ll ll); + + int gprs_ns_tx_alive(struct gprs_nsvc *nsvc); int gprs_ns_tx_alive_ack(struct gprs_nsvc *nsvc); int gprs_ns_tx_reset(struct gprs_nsvc *nsvc, uint8_t cause); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7edc5f4fb6e1fda059e35ea0988d0ef42208aa50 Gerrit-Change-Number: 19138 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-mgw[master]: refactor: use msgb to receive, pass and send RTP packets
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18913 ) Change subject: refactor: use msgb to receive, pass and send RTP packets .. Patch Set 4: Code-Review+1 +1. assigning to dexter to determine if it should be merged now; I don't want his work for E1 support to clash with this all over the place. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3af40b63bc49f8636d4e7ea2f8f83bb67f6619ee Gerrit-Change-Number: 18913 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-Comment-Date: Thu, 09 Jul 2020 10:46:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: do not print redundant info in l1sap_chan_act()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19182 ) Change subject: l1sap: do not print redundant info in l1sap_chan_act() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8a1dd7da7098fe8c8a015459608d9134821fb322 Gerrit-Change-Number: 19182 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:43:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: SI2quater: allow storing 48 EARFCNs
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19180 ) Change subject: SI2quater: allow storing 48 EARFCNs .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iabeed10053ee5899b4def3509aedd25abb2410a9 Gerrit-Change-Number: 19180 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:43:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: do not print redundant info in l1sap_chan_act()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19182 ) Change subject: l1sap: do not print redundant info in l1sap_chan_act() .. l1sap: do not print redundant info in l1sap_chan_act() LOGPLCHAN() prepends the BTS/TRX/TS numbers itself. Change-Id: I8a1dd7da7098fe8c8a015459608d9134821fb322 --- M src/common/l1sap.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 17a6c5d..e05ec78 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1729,8 +1729,7 @@ struct gsm48_chan_desc *cd; int rc; - LOGPLCHAN(lchan, DL1C, LOGL_INFO, "activating channel chan_nr=%s trx=%d\n", - rsl_chan_nr_str(chan_nr), trx->nr); + LOGPLCHAN(lchan, DL1C, LOGL_INFO, "activating channel %s\n", rsl_chan_nr_str(chan_nr)); /* osmo-pcu calls this without a valid 'tp' parameter, so we * need to make sure ew don't crash here */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8a1dd7da7098fe8c8a015459608d9134821fb322 Gerrit-Change-Number: 19182 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: SI2quater: allow storing 48 EARFCNs
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19180 ) Change subject: SI2quater: allow storing 48 EARFCNs .. SI2quater: allow storing 48 EARFCNs Up to 16 SI2quater are multiplexed; each fits 3 EARFCNS, so the practical maximum is 48 (of course depending on how many bits are used by other SI2quater elements). Change-Id: Iabeed10053ee5899b4def3509aedd25abb2410a9 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index ce18d1b..0f5fc54 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -393,7 +393,10 @@ #define A38_XOR_MAX_KEY_LEN16 #define A38_COMP128_KEY_LEN16 #define RSL_ENC_ALG_A5(x) (x+1) -#define MAX_EARFCN_LIST 32 +/* Up to 16 SI2quater are multiplexed; each fits 3 EARFCNS, so the practical maximum is 3*16. + * The real maximum that fits in a total of 16 SI2quater rest octets also depends on the bits left by other SI2quater + * rest octets elements, so to really fit 48 EARFCNs most other SI2quater elements need to be omitted. */ +#define MAX_EARFCN_LIST (3*16) /* is the data link established? who established it? */ #define LCHAN_SAPI_UNUSED 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iabeed10053ee5899b4def3509aedd25abb2410a9 Gerrit-Change-Number: 19180 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: bsc: more SI2quater EUTRAN ARFCN tests
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19181 ) Change subject: bsc: more SI2quater EUTRAN ARFCN tests .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I99bf9b3381812d1db6fd0757f65995bae48da776 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:41:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: SI2quater EARFCNs: span entire value range of EARFCNs
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19200 ) Change subject: bsc: SI2quater EARFCNs: span entire value range of EARFCNs .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I992771826d57669d06887c776303f85ef22f6c71 Gerrit-Change-Number: 19200 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 10:41:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: manuals: generate vty reference xml at build time
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18927 ) Change subject: manuals: generate vty reference xml at build time .. Patch Set 3: Code-Review+1 > Patch Set 3: > > > You cannot fail if it doesn't match since you also get output from other > > git repositories in there (lib dependencies). > > true. > > I'm still for generating it automatically and not build the vty reference in > cross compilation. It's worth it to always have an up-to-date vty reference > and not drag outdated vtyref data along for ages in the git source tree > without anyone noticing. I can accept that (even though I dislike it). The questio is: Will this patch create fall-out? I guess not in the OBS builds, as they (even those for raspbian) are built "natively", and not cross-compiled. The sysmocom OE builds are cross-compiled. Might be worth checking if they disable the build of manuals before merging this. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I526af21134087e2b43b9ada59c93f636ae242e24 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:35:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_vty: fix endpoint number configuration
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19121 ) Change subject: mgcp_vty: fix endpoint number configuration .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c@45 PS3, Line 45: trunk->virtual.vty_number_endpoints = 32; : trunk->e1.vty_timeslot_first = 1; : trunk->e1.vty_timeslot_num = 2; > Just thought that a bit of flexibility would not hurt. […] we should open timeslots at the time of a CRCX. IF it succeeds - great. If it fails -> return an error message. I think adding code complexity about ranges, or even configuration complexity does not serve any purpose here (other than open up new ways of how things can go wrong). So either we allocate all endpoints for all timeslots (15*30=450 per E1 trunk) at start-up, or we dynamically allocate them by demand whenever we get the related CRCX. Pre-allocating all of them sounds like a bit of a waste, at 64 trunks * 450 we end up with 28800 endpoints. Not sure how large our data structures are, but even if an endpoint would be 1kB, it's "only" 28MB of total RAM _if_ somebody went for full 64 trunks. Not elegant, but not a big desaster with todays memory sizes. And if we are worried about this, we could make the creation of sub-slot endpoints optional, i.e. allow only 64k slots for the non-Abis cases (A interface, classic ISDN) and only go for the full I.460 in Abis use cases. Honestly, I don't think it's worth spending any effort in optimization now. So let's just allocate all possible endpoints for each E1 trunk at startup/config time and avoid additional complexity about ranges. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77 Gerrit-Change-Number: 19121 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:33:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_vty: be more specific about E1 trunks
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19103 ) Change subject: mgcp_vty: be more specific about E1 trunks .. Patch Set 6: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/19103/6/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19103/6/src/libosmo-mgcp/mgcp_vty.c@858 PS6, Line 858: "trunk e1 <1-64>", "Configure Trunk\n" "E1 trunk\n" "Trunk Nr\n") > do we need compatibility for old 'trunk <1-64>' command? I don't think so, because the existing code in osmo-mgw for E1 trunks did not work anyway. So there cannot be any people with [reasonable, working] config files that end up in trouble here. https://gerrit.osmocom.org/c/osmo-mgw/+/19103/6/src/libosmo-mgcp/mgcp_vty.c@897 PS6, Line 897: vty_out(vty, " trunk-e1 %d%s", trunk->trunk_nr, VTY_NEWLINE); > above you wrote "trunk e1" so I doubt this can be parsed I think we may also want some kind of dispatch here. After all, we iterate over the global list of trunks (g_cfg->trunks) and not just the list of E1 trunks. So either a )the list always only contains E1 trunks (which it doesn't, as the virtual trunk is part of the list). If this were true, we could keep this patch as-is but rename the list to g_cfg->e1_trunks. b) the list contains all kinds of trunks. In this case, * if we have a E1 trunk specific node, and a specific config_write_ for E1, we ust also make sure that we actually only dump trunks of E1 Type here, and skip all others * alternatively, keep the node name and hence also the config_write function shared (non E1 specific), but simply have a switch statement inside this function dispatching different trunk types. This current patch is, IMHO, creating a more confusing situation than we currently have. We should be careful to avoid this. I personally think that we should keep a common/shared trunk node and not rename the NODE define / name nor this function. All that should be renamed is the 'trunk ...' VTY command to make it E1 specific, in order for us to be able to introduce compatible etensions later on. But to be honest, we could also do that even with the existing 'trunk <1-64>', command: It could later be extended to 'trunk <1-64 [(foo|bar|buz)]' with an implicit default to E1. or we handle it like we handle bts models in OsmBSC: With an explicit 'type (foo|bar|baz)' command within the 'trunk' node. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I22c39ee9a36e4e737992c91677f3e315907a4c7e Gerrit-Change-Number: 19103 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:21:51 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_trunk: use talloc_zero_array instead of _talloc_zero_array
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19174 ) Change subject: mgcp_trunk: use talloc_zero_array instead of _talloc_zero_array .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I27549585016a7998e9233c52f6d86429fc75f509 Gerrit-Change-Number: 19174 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 10:12:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: l1ctl: do not explicitly decativate all lchans on L1CTL_DM_EST_REQ
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18094 ) Change subject: l1ctl: do not explicitly decativate all lchans on L1CTL_DM_EST_REQ .. Patch Set 1: Code-Review-2 Every L1CTL connection handles one real or virtual MS, and hence only one active dedicated channel. There can never be more than one dedicated chanel active concurrently. You need multiple connections to one L1CTL socket, or multiple L1CTL sockets with one connection each in order to model this. I think this should be abandoned. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iad309b7aacdead986a7a5ad52bf712b6c6197b66 Gerrit-Change-Number: 18094 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Jul 2020 10:12:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: l1ctl: preserve TS configuration for HR channels
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18095 ) Change subject: l1ctl: preserve TS configuration for HR channels .. Patch Set 1: Code-Review-2 Every L1CTL connection handles one real or virtual MS, and hence only one active dedicated channel. There can never be more than one dedicated chanel active concurrently. You need multiple connections to one L1CTL socket, or multiple L1CTL sockets with one connection each in order to model this. I think this should be abandoned. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ac0ae22c40e3cb99c44f1156000c6909f739ad4 Gerrit-Change-Number: 18095 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:11:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/scheduler: check TDMA frame order, drop out of order bursts
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19201 ) Change subject: trxcon/scheduler: check TDMA frame order, drop out of order bursts .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 10:09:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pdch.cpp: Store TLLI promply on newly created TLLI in rcv_resource_re...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19197 ) Change subject: pdch.cpp: Store TLLI promply on newly created TLLI in rcv_resource_request .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I20ce4eb94ecf85ce2835275d0056d9ecd1b558c3 Gerrit-Change-Number: 19197 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 10:07:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19195 ) Change subject: pdch.cpp: Avoid resetting (egprs_)ms_class to unknown if not found in MS RadioAccCap .. Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/src/pdch.cpp@a604 PS1, Line 604: ms->egprs_ms_class()); > isn't this interesting to still see in, say, a DEBUG log? the commitlog states it is already logged in another place. https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/tests/tbf/TbfTest.err File tests/tbf/TbfTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/19195/1/tests/tbf/TbfTest.err@a3113 PS1, Line 3113: EGPRS MS class 0 -> 1 likely this is where it is logged already, just one line above. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icd52209fd4395d78dc770e7869d1b1fe45a18ca0 Gerrit-Change-Number: 19195 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 10:05:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in osmo-pcu[master]: pdch.cpp: Avoid dropping existing DL TBF during rcv_resource_request
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19194 ) Change subject: pdch.cpp: Avoid dropping existing DL TBF during rcv_resource_request .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19194/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19194/1/src/pdch.cpp@570 PS1, Line 570: RACH this is then also wrong. We're processing a packet resource request, not RACH here. The comment above, too. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iab4afb66f0d671f7ad54909d2685a1613e12ab4d Gerrit-Change-Number: 19194 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Jul 2020 10:04:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: encoding.cpp: Fix missing spacing in function param
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19193 ) Change subject: encoding.cpp: Fix missing spacing in function param .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4f30a0cea615d57cd7783a92ae782790c8075a6c Gerrit-Change-Number: 19193 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Jul 2020 10:02:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: encoding: Encode TA as unsigned and check validty against GSM48_TA_IN...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19176 ) Change subject: encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2//COMMIT_MSG@12 PS2, Line 12: here.ch we use everywhere else to initialize when the : value is not known. > ? Ack https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2/src/encoding.cpp@553 PS2, Line 553: int8_t ta_idx > This is actually the Timing Advance Index on PTCCH/U, it's not the Timing > Advance value itself. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I82b13561d0fe5ebafb5c3a8b9a501045c29809bc Gerrit-Change-Number: 19176 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: neels Gerrit-Comment-Date: Thu, 09 Jul 2020 10:02:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: neels Gerrit-MessageType: comment
