Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64

2021-01-09 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64

Package network:osmocom:latest/osmo-iuh failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-iuh

Last lines of build log:
1-ranap.a/RANAP_RAB-SetupItem-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupItem-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemFirst.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemSecond.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SubflowCombinationBitRate.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedItem-EnhancedRelocCompleteRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-Mapping.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-MappingItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABDataVolumeReport.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABParametersList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABased.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferItem.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferList.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAC.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI-List.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListwithNoIdleModeUEsAnyMore.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationRequest.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationResponse.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-PDU.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-RelocationInformation.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAT-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIM-Transfer.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMRoutingAddress.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNC-ID.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNCTraceInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNSAPRelocationParameters.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RRC-Container.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Extension.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-HO-Indication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Information.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Operation-Possible.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RTLoadValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RateControlAllowed.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectAttemptFlag.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionCompleted.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionIndication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RejectCauseValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancel.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancelAcknowledge.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCommand.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationComplete.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationDetect.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationFailure.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationPreparationFailure.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationRe

Change in osmo-bsc[master]: manual: Location Services: clarify BSC side address

2021-01-09 Thread neels
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22081 )


Change subject: manual: Location Services: clarify BSC side address
..

manual: Location Services: clarify BSC side address

A clarification that I promised a while back but forgot to submit.

Related: SYS#4876
Change-Id: I9b06ac7a2f2cb34cabfcec10af761322b8e962fb
---
M doc/manuals/chapters/smlc.adoc
1 file changed, 18 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/22081/1

diff --git a/doc/manuals/chapters/smlc.adoc b/doc/manuals/chapters/smlc.adoc
index 7fd3e12..3bd4f84 100644
--- a/doc/manuals/chapters/smlc.adoc
+++ b/doc/manuals/chapters/smlc.adoc
@@ -46,6 +46,9 @@
 The point-codes are configurable, and default to OsmoBSC's local point-code
 0.23.3 (187), and remote SMLC point-code 0.23.6 (190).

+Typically, multiple BSCs connect to the same SMLC, so that each BSC needs to
+have a distinct point-code, while the SMLC has a single, fixed point-code.
+
 To configure a different remote SMLC point-code, first configure an arbitrarily
 named SCCP address in the `cs7` address book, and then apply that to the
 `smlc-addr` configuration:
@@ -55,11 +58,24 @@
  sccp-address my-smlc
   point-code 0.42.6
 smlc
+ enable
  smlc-addr my-smlc
 

-Similarly, OsmoBSC's local point-code on the Lb-interface is configured by the
-`bsc-addr` configuration:
+For the BSC side, it suffices to configure a point-code in the `cs7` section,
+so that the BSC typically uses the same point-code on A and Lb interfaces. In
+this example, the BSC has point-code `1.2.3` on the Lb interface:
+
+
+cs7 instance 0
+ point-code 1.2.3
+smlc
+ enable
+
+
+It is also possible to configure a distinct BSC's point-code on Lb, using the
+`bsc-addr` configuration. In the following example, the BSC uses point-code
+`0.42.3` only on the Lb interface, while the A interface remains unchanged:

 
 cs7 instance 0

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22081
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9b06ac7a2f2cb34cabfcec10af761322b8e962fb
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange


Change in osmo-bsc[master]: handover_test: safeguard against unhandled chan req

2021-01-09 Thread neels
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21981 )

Change subject: handover_test: safeguard against unhandled chan req
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21981/1/tests/handover/handover_test.c
File tests/handover/handover_test.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21981/1/tests/handover/handover_test.c@709
PS1, Line 709:  fprintf(stderr, "Test script is 
erratic: a channel is requested"
> osmo_panic could be used here.
throughout the handover_test.c, this is how failures are reported. (wasn't my 
idea, taken from legacy code)

reading osmo_panic doc -- since this is a regression test, we don't need panic 
handlers or a backtrace...



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21981
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib0d5c4647af23e6729cc19e98b1870cdde2fe994
Gerrit-Change-Number: 21981
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sat, 09 Jan 2021 11:53:16 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


Change in osmo-bsc[master]: hodec2: fix congestion oscillation bug

2021-01-09 Thread neels
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/21989

to look at the new patch set (#3).

Change subject: hodec2: fix congestion oscillation bug
..

hodec2: fix congestion oscillation bug

When evenly distributing congestion across cells, count the number of
occupied lchans surpassing congestion, and not the overall number of
free lchans -- which disregards congestion thresholds.

Fix the bugs shown by
 test_congestion_no_oscillation.ho_vty
 test_balance_congestion_tchf_tchh.ho_vty

An example to illustrate what this is about:

Cell A has min-free-slots 2, and has 1 slot remaining free.
Cell B has min-free-slots 4, and has 2 slots remaining free.

If we decide where to place another lchan by counting congested lchans,
as implemented in this patch:
- Another lchan added, cell A ends up with a congestion count of 2: two
  more lchans in use than "allowed".
- Cell B ends up with a congestion count of 3, which is worse than 2.
We decide that cell A should receive the additional lchan, because it
will then have a lower congestion count.  However, that makes cell A
completely occupied, while cell B has two lchans remaining free.

There are two alternative fix variants in consideration:
- count the number of free lchans, but only after reaching congestion.
- calculate the percentage of load surpassing congestion.

When using percentage of remaining lchans, we would see that if cell A
receives another lchan, it would be 100% loaded above its congestion
threshold (2 of 2 remaining lchans in use), but cell B would only be 75%
loaded above its treshold (3 of 4 remaining lchans in use).  So a
percentage comparison would place the next lchan in cell B, leaving the
last lchan of cell A free.

Another option would be to count the number of remaining free lchans
(after the congestion threshold is surpassed), instead of the used ones
above the congestion threshold. But then, as soon as all cells are
congested, configuring different thresholds would no longer have an
effect. I would no longer be able to configure a particular cell to
remain more free than others: once congested, only that cell would fill
up until it reaches the same load as the other cells.

In the field, where all cells likely have the same min-free-slots
settings, this entire consideration is moot, because congestion counts
correspond 1:1 to percentage between all cells and also 1:1 to remaining
free slots. However, when looking at distribution across TCH/F and
TCH/H, it is quite likely that min-free-slots settings differ for TCH/F
and TCH/H, so this is in fact a thing to consider even for identically
configured cells.

Related: SYS#5259
Change-Id: Icb373dc6bfc9819446db5e96f71921781fe2026d
---
M src/osmo-bsc/handover_decision_2.c
M tests/handover/test_balance_congestion_tchf_tchh.ho_vty
M tests/handover/test_congestion_no_oscillation.ho_vty
M tests/handover/test_congestion_no_oscillation2.ho_vty
4 files changed, 13 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/89/21989/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icb373dc6bfc9819446db5e96f71921781fe2026d
Gerrit-Change-Number: 21989
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Change in osmo-bsc[master]: handover_test: show bug: add test_balance_congestion_tchf_tchh.ho_vty

2021-01-09 Thread neels
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22083 )


Change subject: handover_test: show bug: add 
test_balance_congestion_tchf_tchh.ho_vty
..

handover_test: show bug: add test_balance_congestion_tchf_tchh.ho_vty

Change-Id: I78fd146fb9b9f9e5d61234065abecbedb9f30a3a
---
M tests/handover/handover_tests.ok
A tests/handover/test_balance_congestion_tchf_tchh.ho_vty
2 files changed, 54 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/22083/1

diff --git a/tests/handover/handover_tests.ok b/tests/handover/handover_tests.ok
index 521a0fe..95442a3 100644
--- a/tests/handover/handover_tests.ok
+++ b/tests/handover/handover_tests.ok
@@ -8,6 +8,7 @@
 pass test_amr_tch_h_to_f_congestion_two_cells.ho_vty
 pass test_balance_congestion.ho_vty
 pass test_balance_congestion_2.ho_vty
+pass test_balance_congestion_tchf_tchh.ho_vty
 pass test_congestion.ho_vty
 pass test_congestion_favor_best_target_rxlev.ho_vty
 pass test_congestion_intra_vs_inter_cell.ho_vty
diff --git a/tests/handover/test_balance_congestion_tchf_tchh.ho_vty 
b/tests/handover/test_balance_congestion_tchf_tchh.ho_vty
new file mode 100644
index 000..d7b3cf5
--- /dev/null
+++ b/tests/handover/test_balance_congestion_tchf_tchh.ho_vty
@@ -0,0 +1,53 @@
+# Balance congestion across cells and across TCH/F and TCH/H.
+
+network
+ handover2 min-free-slots tch/f 3
+ handover2 min-free-slots tch/h 3
+
+create-bts trx-count 1 timeslots   c+s4TCH/F   TCH/F   TCH/F   TCH/F   
TCH/H   TCH/H   TCH/H
+
+# both TCH/H and TCH/F have one lchan above congestion, nothing happens
+set-ts-use trx 0 0 states  *   TCH/F   TCH/F   -   -   
TCH/HH  TCH/HH  -
+meas-rep lchan * * * * rxlev 10 rxqual 0 ta 0
+congestion-check
+expect-no-chan
+
+# TCH/F = +1, TCH/H = +2 above congestion. Moving a TCH/H to TCH/F would just 
reverse the situation to F=+2 H=+1. Nothing happens.
+set-ts-use trx 0 0 states  *   TCH/F   TCH/F   -   -   
TCH/HH  TCH/HH  TCH/H-
+meas-rep lchan * * * * rxlev 10 rxqual 0 ta 0
+congestion-check
+expect-no-chan
+
+# F=+1 H=+3. Balance to F=+2 H=+2
+set-ts-use trx 0 0 states  *   TCH/F   TCH/F   -   -   
TCH/HH  TCH/HH  TCH/HH
+meas-rep lchan * * * * rxlev 10 rxqual 0 ta 0
+congestion-check
+expect-ho from lchan 0 0 5 0 to lchan 0 0 3 0
+
+# Now the exact same thing, just with different min-free-slots settings for
+# tch/f vs tch/h
+
+network
+ handover2 min-free-slots tch/f 3
+ handover2 min-free-slots tch/h 5
+
+# both TCH/H and TCH/F have one lchan above congestion, nothing happens
+set-ts-use trx 0 0 states  *   TCH/F   TCH/F   -   -   
TCH/HH  -   -
+meas-rep lchan * * * * rxlev 20 rxqual 0 ta 0
+congestion-check
+# FAIL: should be the same as above, but seeing a handover from F to H
+expect-ho from lchan 0 0 1 0 to lchan 0 0 6 0
+
+# TCH/F = +1, TCH/H = +2 above congestion. Moving a TCH/H to TCH/F would just
+# reverse the situation to F=+2 H=+1. Nothing happens.
+set-ts-use trx 0 0 states  *   TCH/F   TCH/F   -   -   
TCH/HH  TCH/H-  -
+meas-rep lchan * * * * rxlev 20 rxqual 0 ta 0
+congestion-check
+expect-no-chan
+
+# F=+1 H=+3. Balance to F=+2 H=+2
+set-ts-use trx 0 0 states  *   TCH/F   TCH/F   -   -   
TCH/HH  TCH/HH  -
+meas-rep lchan * * * * rxlev 20 rxqual 0 ta 0
+congestion-check
+# FAIL: should be the same as above, from lchan 0 0 5 0 to lchan 0 0 3 0, but 
no handover happens
+expect-no-chan

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I78fd146fb9b9f9e5d61234065abecbedb9f30a3a
Gerrit-Change-Number: 22083
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange


Change in osmo-bsc[master]: handover_test: add lchan wildcards to meas-rep cmd

2021-01-09 Thread neels
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22082 )


Change subject: handover_test: add lchan wildcards to meas-rep cmd
..

handover_test: add lchan wildcards to meas-rep cmd

With 'set-ts-use', it is convenient to build a scenario of lchan usage,
but still inconvenient to send measurement reports to all lchans.

I need this for testing congestion-check, because each lchan needs to
have at least one measurement report, or congestion check is skipped.

Example:

 set-ts-use trx 0 0 states * TCH/F TCH/F - - TCH/HH TCH/HH TCH/H-
 meas-rep lchan * * * * rxlev 10 rxqual 0 ta 0

This patch adds the '*' for the lchan arguments, usually being bts idx,
trx idx, timeslot idx and subslot idx.

Use lchan wildcards at the appropriate places to shorten some tests.

Change-Id: I441f92348508d45e1069a3dfa1ff3842dbba97d6
---
M tests/handover/handover_test.c
M tests/handover/test_balance_congestion_2.ho_vty
M tests/handover/test_congestion.ho_vty
M tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty
M tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty
M tests/handover/test_no_congestion.ho_vty
6 files changed, 72 insertions(+), 44 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/22082/1

diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index d422a9d..dff1390 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -741,6 +741,50 @@
return &ts->lchan[atoi(argv[3])];
 }

+#define LCHAN_WILDCARD_ARGS "lchan (<0-255>|*) (<0-255>|*) (<0-7>|*) (<0-7>|*)"
+#define LCHAN_WILDCARD_ARGS_DOC "identify an lchan\nBTS nr\nall BTS\nTRX 
nr\nall BTS\nTimeslot nr\nall TS\nSubslot nr\nall subslots\n"
+
+static void parse_lchan_wildcard_args(const char **argv, void (*cb)(struct 
gsm_lchan*, void*), void *cb_data)
+{
+   const char *bts_str = argv[0];
+   const char *trx_str = argv[1];
+   const char *ts_str = argv[2];
+   const char *ss_str = argv[3];
+   int bts_num = (strcmp(bts_str, "*") == 0)? -1 : atoi(bts_str);
+   int trx_num = (strcmp(trx_str, "*") == 0)? -1 : atoi(trx_str);
+   int ts_num = (strcmp(ts_str, "*") == 0)? -1 : atoi(ts_str);
+   int ss_num = (strcmp(ss_str, "*") == 0)? -1 : atoi(ss_str);
+
+   int bts_i;
+   int trx_i;
+   int ts_i;
+   int ss_i;
+
+   for (bts_i = ((bts_num == -1) ? 0 : bts_num);
+bts_i < ((bts_num == -1) ? bsc_gsmnet->num_bts : bts_num + 1);
+bts_i++) {
+   struct gsm_bts *bts = gsm_bts_num(bsc_gsmnet, bts_i);
+
+   for (trx_i = ((trx_num == -1) ? 0 : trx_num);
+trx_i < ((trx_num == -1) ? bts->num_trx : trx_num + 1);
+trx_i++) {
+   struct gsm_bts_trx *trx = gsm_bts_trx_num(bts, trx_i);
+
+   for (ts_i = ((ts_num == -1) ? 0 : ts_num);
+ts_i < ((ts_num == -1) ? 8 : ts_num + 1);
+ts_i++) {
+   struct gsm_bts_trx_ts *ts = &trx->ts[ts_i];
+
+   for (ss_i = ((ss_num == -1) ? 0 : ss_num);
+ss_i < ((ss_num == -1) ? 
pchan_subslots(ts->pchan_is) : ss_num + 1);
+ss_i++) {
+   cb(&ts->lchan[ss_i], cb_data);
+   }
+   }
+   }
+   }
+}
+
 static int vty_step = 1;

 #define VTY_ECHO() \
@@ -814,18 +858,24 @@
return CMD_SUCCESS;
 }

-static int _meas_rep(struct vty *vty, int argc, const char **argv)
+struct meas_rep_data {
+   int argc;
+   const char **argv;
+};
+
+static void _meas_rep_cb(struct gsm_lchan *lc, void *data)
 {
-   struct gsm_lchan *lc;
+   struct meas_rep_data *d = data;
+   int argc = d->argc;
+   const char **argv = d->argv;
uint8_t rxlev;
uint8_t rxqual;
uint8_t ta;
int i;
struct neighbor_meas nm[6] = {};

-   lc = parse_lchan_args(argv);
-   argv += 4;
-   argc -= 4;
+   if (!lchan_state_is(lc, LCHAN_ST_ESTABLISHED))
+   return;

rxlev = atoi(argv[0]);
rxqual = atoi(argv[1]);
@@ -863,14 +913,24 @@
nm[i].rxlev);
}
gen_meas_rep(lc, rxlev, rxqual, ta, argc, nm);
+}
+
+static int _meas_rep(struct vty *vty, int argc, const char **argv)
+{
+   struct meas_rep_data d = {
+   .argc = argc - 4,
+   .argv = argv + 4,
+   };
+   parse_lchan_wildcard_args(argv, _meas_rep_cb, &d);
return CMD_SUCCESS;
 }

-#define MEAS_REP_ARGS  LCHAN_ARGS " rxlev <0-255> rxqual <0-7> ta <0-255>" \
+
+#define MEAS_REP_ARGS  LCHAN_WILDCARD_ARGS " rxlev <0-255> rxqual <0-7> ta 
<0-255>" \
" [neighbors] [<0-255>] [<0-255>] [<0-25

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_20.10/x86_64

2021-01-09 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_20.10/x86_64

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_20.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   36s] Processing triggers for libc-bin (2.32-0ubuntu3) ...
[   36s] [185/499] installing libzzip-0-13-0.13.62-3.2ubuntu1
[   36s] Processing triggers for libc-bin (2.32-0ubuntu3) ...
[   36s] [186/499] installing m4-1.4.18-4
[   36s] [187/499] installing osmo-libasn1c1-0.9.32-1
[   36s] Processing triggers for libc-bin (2.32-0ubuntu3) ...
[   36s] [188/499] installing unzip-6.0-25ubuntu1
[   36s] Processing triggers for mime-support (3.64ubuntu1) ...
[   36s] [189/499] installing xz-utils-5.2.4-1ubuntu1
[   36s] update-alternatives: using /usr/bin/xz to provide /usr/bin/lzma (lzma) 
in auto mode
[   36s] [190/499] installing bsdextrautils-2.36-3ubuntu1
[   36s] update-alternatives: using /usr/bin/write.ul to provide /usr/bin/write 
(write) in auto mode
[   36s] [191/499] installing libasan6-10.2.0-13ubuntu1
[   36s] Processing triggers for libc-bin (2.32-0ubuntu3) ...
[   36s] [192/499] installing libasn1c1-0.9.32
[   36s] dpkg: error processing archive .init_b_cache/libasn1c1.deb (--install):
[   36s]  trying to overwrite '/usr/lib/x86_64-linux-gnu/libasn1c.so.1.0.1', 
which is also in package osmo-libasn1c1:amd64 0.9.32-1
[   36s] dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
[   36s] Processing triggers for libc-bin (2.32-0ubuntu3) ...
[   36s] Errors were encountered while processing:
[   36s]  .init_b_cache/libasn1c1.deb
[   36s] exit ...
[   36s] ### VM INTERACTION START ###
[   39s] [   27.649689] sysrq: Power Off
[   39s] [   27.656591] reboot: Power down
[   40s] ### VM INTERACTION END ###
[   40s] 
[   40s] goat17 failed "build osmo-msc_1.6.3.dsc" at Sat Jan  9 12:23:35 UTC 
2021.
[   40s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:latest/osmo-msc in xUbuntu_20.04/x86_64

2021-01-09 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_20.04/x86_64

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_20.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   38s] Processing triggers for libc-bin (2.31-0ubuntu9) ...
[   38s] [163/450] installing libxdmcp6-1:1.1.3-0ubuntu1
[   38s] Processing triggers for libc-bin (2.31-0ubuntu9) ...
[   38s] [164/450] installing libzzip-0-13-0.13.62-3.2ubuntu1
[   38s] Processing triggers for libc-bin (2.31-0ubuntu9) ...
[   38s] [165/450] installing m4-1.4.18-4
[   38s] [166/450] installing osmo-libasn1c1-0.9.32-1
[   38s] Processing triggers for libc-bin (2.31-0ubuntu9) ...
[   38s] [167/450] installing unzip-6.0-25ubuntu1
[   38s] Processing triggers for mime-support (3.64ubuntu1) ...
[   38s] [168/450] installing xz-utils-5.2.4-1
[   38s] update-alternatives: using /usr/bin/xz to provide /usr/bin/lzma (lzma) 
in auto mode
[   38s] [169/450] installing libasan5-9.3.0-10ubuntu2
[   38s] Processing triggers for libc-bin (2.31-0ubuntu9) ...
[   38s] [170/450] installing libasn1c1-0.9.32
[   38s] dpkg: error processing archive .init_b_cache/libasn1c1.deb (--install):
[   38s]  trying to overwrite '/usr/lib/x86_64-linux-gnu/libasn1c.so.1.0.1', 
which is also in package osmo-libasn1c1:amd64 0.9.32-1
[   38s] dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
[   38s] Processing triggers for libc-bin (2.31-0ubuntu9) ...
[   38s] Errors were encountered while processing:
[   38s]  .init_b_cache/libasn1c1.deb
[   38s] exit ...
[   38s] ### VM INTERACTION START ###
[   41s] [   27.487887] sysrq: Power Off
[   41s] [   27.491402] reboot: Power down
[   41s] ### VM INTERACTION END ###
[   41s] 
[   41s] old-atreju3 failed "build osmo-msc_1.6.3.dsc" at Sat Jan  9 12:23:35 
UTC 2021.
[   41s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Change in osmo-gsm-tester[master]: enb: add abstract method stop()

2021-01-09 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054 )

Change subject: enb: add abstract method stop()
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054/3/src/osmo_gsm_tester/obj/enb.py
File src/osmo_gsm_tester/obj/enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054/3/src/osmo_gsm_tester/obj/enb.py@331
PS3, Line 331: raise log.Error('stop() not implemented!')
This should stay as "pass", since it's abstract and code in it is never going 
to be executed, because python will fail when allocating the child class or 
this parent class.



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
Gerrit-Change-Number: 22054
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:38:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers

2021-01-09 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/21862 )

Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..


Patch Set 8:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h
File include/osmocom/gprs/gprs_bssgp_rim.h:

https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@7
PS6, Line 7:struct {
> Makes sense, but I could not find a parsing function for the struct. […]
see gsm0808_decode_cell_id_u()



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 8
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:40:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment


Change in osmo-bsc[master]: manual: Location Services: clarify BSC side address

2021-01-09 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22081 )

Change subject: manual: Location Services: clarify BSC side address
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/22081/1/doc/manuals/chapters/smlc.adoc
File doc/manuals/chapters/smlc.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/22081/1/doc/manuals/chapters/smlc.adoc@85
PS1, Line 85:  bsc-addr my-bsc-on-lb
You also probably miss an "enable" line here



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22081
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9b06ac7a2f2cb34cabfcec10af761322b8e962fb
Gerrit-Change-Number: 22081
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:44:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-bsc[master]: hodec2: fix congestion oscillation bug

2021-01-09 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21989 )

Change subject: hodec2: fix congestion oscillation bug
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icb373dc6bfc9819446db5e96f71921781fe2026d
Gerrit-Change-Number: 21989
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:48:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: handover_test: add lchan wildcards to meas-rep cmd

2021-01-09 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22082 )

Change subject: handover_test: add lchan wildcards to meas-rep cmd
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22082
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I441f92348508d45e1069a3dfa1ff3842dbba97d6
Gerrit-Change-Number: 22082
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:50:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: handover_test: show bug: add test_balance_congestion_tchf_tchh.ho_vty

2021-01-09 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22083 )

Change subject: handover_test: show bug: add 
test_balance_congestion_tchf_tchh.ho_vty
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I78fd146fb9b9f9e5d61234065abecbedb9f30a3a
Gerrit-Change-Number: 22083
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:51:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: hodec2: fix congestion oscillation bug

2021-01-09 Thread neels
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/21989

to look at the new patch set (#4).

Change subject: hodec2: fix congestion oscillation bug
..

hodec2: fix congestion oscillation bug

When evenly distributing congestion across cells, count the number of
occupied lchans surpassing congestion, and not the overall number of
free lchans -- which disregards congestion thresholds.

Fix the bugs shown by
 test_congestion_no_oscillation.ho_vty
 test_balance_congestion_tchf_tchh.ho_vty

An example to illustrate what this is about:

Cell A has min-free-slots 2, and has 1 slot remaining free.
Cell B has min-free-slots 4, and has 2 slots remaining free.

If we decide where to place another lchan by counting congested lchans,
as implemented in this patch:
- Another lchan added, cell A ends up with a congestion count of 2: two
  more lchans in use than "allowed".
- Cell B ends up with a congestion count of 3, which is worse than 2.
We decide that cell A should receive the additional lchan, because it
will then have a lower congestion count.  However, that makes cell A
completely occupied, while cell B has two lchans remaining free.

There are two alternative fix variants in consideration:
- count the number of free lchans, but only after reaching congestion.
- calculate the percentage of load surpassing congestion.

When using percentage of remaining lchans, we would see that if cell A
receives another lchan, it would be 100% loaded above its congestion
threshold (2 of 2 remaining lchans in use), but cell B would only be 75%
loaded above its treshold (3 of 4 remaining lchans in use).  So a
percentage comparison would place the next lchan in cell B, leaving the
last lchan of cell A free.

Another option would be to count the number of remaining free lchans
(after the congestion threshold is surpassed), instead of the used ones
above the congestion threshold. But then, as soon as all cells are
congested, configuring different thresholds would no longer have an
effect. I would no longer be able to configure a particular cell to
remain more free than others: once congested, only that cell would fill
up until it reaches the same load as the other cells.

In the field, where all cells likely have the same min-free-slots
settings, this entire consideration is moot, because congestion counts
correspond 1:1 to percentage between all cells and also 1:1 to remaining
free slots. However, when looking at distribution across TCH/F and
TCH/H, it is quite likely that min-free-slots settings differ for TCH/F
and TCH/H, so this is in fact a thing to consider even for identically
configured cells.

Related: SYS#5259
Change-Id: Icb373dc6bfc9819446db5e96f71921781fe2026d
---
M src/osmo-bsc/handover_decision_2.c
M tests/handover/test_balance_congestion_tchf_tchh.ho_vty
M tests/handover/test_congestion_no_oscillation.ho_vty
M tests/handover/test_congestion_no_oscillation2.ho_vty
4 files changed, 14 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/89/21989/4
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icb373dc6bfc9819446db5e96f71921781fe2026d
Gerrit-Change-Number: 21989
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Change in osmo-bsc[master]: hodec2: to balance congestion, use overload percent

2021-01-09 Thread neels
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22085 )


Change subject: hodec2: to balance congestion, use overload percent
..

hodec2: to balance congestion, use overload percent

For balancing load across congested cells and across congested TCH/*
kinds, instead of comparing the number of lchans above the configured
congestion threshold, compare the percent of lchans of overload.

In short, using a percentage prevents cells with less min-free-slots to
fill up 100% while neighbor cells still may have several free lchans
available.

An obvious example of why this is desirable is illustrated by
test_balance_congestion_by_percentage.ho_vty:

Cell A has min-free-slots 2, and has all slots occupied.
Cell B has min-free-slots 4, and has 2 slots remaining free.

If we count congested lchans as in current master: cell A has a
congestion count of 2: two more lchans in use than "allowed". If we move
one lchan over to cell B, it ends up with a congestion count of 3, which
is worse than 2. So when counting lchans, we decide that cell A should
remain full.

Instead, when comparing percentage of remaining lchans, we would see
that cell A is loaded 100% above congestion (2 of 2 remaining lchans in
use), but when moving one lchan to cell B, that would only be 75% loaded
above its treshold (3 of 4 remaining lchans in use). So a percentage
comparison would cause a handover to cell B.

Change-Id: I55234c6c99eb02ceee52be0d7388bea14304930f
---
M src/osmo-bsc/handover_decision_2.c
M tests/handover/handover_tests.ok
M tests/handover/test_balance_congestion_by_percentage.ho_vty
M tests/handover/test_balance_congestion_tchf_tchh.ho_vty
4 files changed, 52 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/22085/1

diff --git a/src/osmo-bsc/handover_decision_2.c 
b/src/osmo-bsc/handover_decision_2.c
index c265f5f..d29f762 100644
--- a/src/osmo-bsc/handover_decision_2.c
+++ b/src/osmo-bsc/handover_decision_2.c
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -387,6 +388,27 @@
return false;
 }

+#define LOAD_PRECISION 6
+
+/* Return a number representing overload, i.e. the fraction of lchans used 
above the congestion threshold.
+ * Think of it as a percentage of used lchans above congestion, just 
represented in a fixed-point fraction with N
+ * decimal digits of fractional part. If there is no congestion (free_tch > 
min_free_tch), return 0.
+ */
+static int32_t load_above_congestion(int free_tch, int min_free_tch)
+{
+   int32_t v;
+   /* Avoid division by zero, and return zero overload when there is no 
congestion threshold. */
+   if (!min_free_tch
+   || free_tch >= min_free_tch)
+   return 0;
+   /* There can be no negative amount of free TCH/x, clamp to a minimum of 
zero available slots. This could
+* theoretically happen when a caller subtracts one from free_tch to 
regard the slots after a handover. */
+   v = min_free_tch - OSMO_MAX(0, free_tch);
+   v *= pow(10, LOAD_PRECISION);
+   v /= min_free_tch;
+   return v;
+}
+
 /*
  * Check what requirements the given cell fulfills.
  * A bit mask of fulfilled requirements is returned.
@@ -443,7 +465,7 @@
 {
uint8_t requirement = 0;
unsigned int penalty_time;
-   int current_overbooked;
+   int32_t current_overbooked;
c->requirements = 0;

/* Requirement A */
@@ -626,17 +648,25 @@

/* Requirement C */

-   /* the nr of lchans surpassing congestion on the target cell must be <= 
the lchans surpassing congestion on the
-* current cell _after_ handover/assignment */
-   current_overbooked = c->current.min_free_tch - c->current.free_tch;
+   /* the load percentage above congestion on the target cell *after* HO 
must be < the load percentage above
+* congestion on the current cell, hence the - 1 on the target. */
+   current_overbooked = load_above_congestion(c->current.free_tch, 
c->current.min_free_tch);
if (requirement & REQUIREMENT_A_TCHF) {
-   int target_overbooked = c->target.min_free_tchf - 
c->target.free_tchf;
-   if (target_overbooked + 1 <= current_overbooked - 1)
+   int32_t target_overbooked = 
load_above_congestion(c->target.free_tchf - 1, c->target.min_free_tchf);
+   LOGPHOLCHANTOBTS(c->current.lchan, c->target.bts, LOGL_DEBUG,
+"current overbooked = %s%%, TCH/F target 
overbooked after HO = %s%%\n",
+osmo_int_to_float_str_c(OTC_SELECT, 
current_overbooked, LOAD_PRECISION - 2),
+osmo_int_to_float_str_c(OTC_SELECT, 
target_overbooked, LOAD_PRECISION - 2));
+   if (target_overbooked < current_overbooked)
requirement |= REQUIREMENT_C_TCHF;
 

Change in osmo-bsc[master]: handover_test: add test_balance_congestion_by_percentage.ho_vty

2021-01-09 Thread neels
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/22084 )


Change subject: handover_test: add test_balance_congestion_by_percentage.ho_vty
..

handover_test: add test_balance_congestion_by_percentage.ho_vty

Considering feedback by a customer, we prefer congestion balancing by
using percentage of overload instead of number of lchans of overload.
This test is intended to illustrate the change in behavior.

Change-Id: I314915718f66aec50e8dcf94569b0a52ca34b96f
---
A tests/handover/test_balance_congestion_by_percentage.ho_vty
1 file changed, 34 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/22084/1

diff --git a/tests/handover/test_balance_congestion_by_percentage.ho_vty 
b/tests/handover/test_balance_congestion_by_percentage.ho_vty
new file mode 100644
index 000..e00636e
--- /dev/null
+++ b/tests/handover/test_balance_congestion_by_percentage.ho_vty
@@ -0,0 +1,34 @@
+# To balance congestion, use the remaining free percentage instead of free 
lchan counts.
+#
+# Cell A has min-free-slots 2, and has all slots occupied.
+# Cell B has min-free-slots 4, and has 2 slots remaining free.
+#
+# If we count congested lchans: cell A has a congestion count of 2: two more 
lchans in use than "allowed".
+# If we move one lchan over to cell B, it ends up with a congestion count of 
3, which is worse than 2.
+# So when counting lchans, we decide that cell A should remain full.
+#
+# Instead, when comparing percentage of remaining lchans, we would see that 
cell A is loaded 100% above congestion (2 of
+# 2 remaining lchans in use), but when moving one lchan to cell B, it would 
only be 75% loaded above its treshold (3 of
+# 4 remaining lchans in use). So a percentage comparison would cause a 
handover to cell B.
+#
+# This test currently expects the behavior of counting lchans; a patch will 
change to use percentage, which should
+# reflect in this test.
+
+create-bts trx-count 1 timeslots c+s4 TCH/F TCH/F TCH/F TCH/F TCH/F TCH/F PDCH
+create-bts trx-count 1 timeslots c+s4 TCH/F TCH/F TCH/F TCH/F TCH/F TCH/F PDCH
+
+network
+ bts 0
+  handover2 min-free-slots tch/f 2
+ bts 1
+  handover2 min-free-slots tch/f 4
+
+set-ts-use trx 0 0 states*TCH/F TCH/F TCH/F TCH/F TCH/F TCH/F *
+set-ts-use trx 1 0 states*TCH/F TCH/F TCH/F TCH/F - - *
+
+meas-rep lchan * * * * rxlev 40 rxqual 0 ta 0 neighbors 30
+expect-no-chan
+
+# bts 0 is full, but by counting lchans above congestion, it should remain 
full.
+congestion-check
+expect-no-chan

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22084
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I314915718f66aec50e8dcf94569b0a52ca34b96f
Gerrit-Change-Number: 22084
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64

2021-01-09 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  155s] [COMPILING apps/dfu/main.c]
[  155s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c]
[  155s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c]
[  155s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c]
[  155s] Memory region Used Size  Region Size  %age Used
[  155s]  rom:   16580 B16 KB101.20%
[  155s]  ram:   11672 B48 KB 
23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: 
changing start of section .stack by 4 bytes
[  155s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  155s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom'
[  155s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  155s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  155s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  155s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region 
`rom' overflowed by 196 bytes
[  155s] collect2: error: ld returned 1 exit status
[  155s] %
[  155s] make[2]: *** [Makefile:234: flash] Error 1
[  155s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  155s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2
[  155s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  155s] dh_auto_build: error: make -j1 returned exit code 2
[  155s] make: *** [debian/rules:16: build] Error 25
[  155s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  155s] ### VM INTERACTION START ###
[  158s] [  146.982912] sysrq: Power Off
[  158s] [  146.990039] reboot: Power down
[  158s] ### VM INTERACTION END ###
[  158s] 
[  158s] lamb24 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sun Jan 10 
01:46:54 UTC 2021.
[  158s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64

2021-01-09 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  156s] [COMPILING libboard/qmod/source/wwan_perst.c]
[  156s] [COMPILING libboard/qmod/source/card_pres.c]
[  156s] [COMPILING libboard/qmod/source/wwan_led.c]
[  156s] [COMPILING libboard/qmod/source/i2c.c]
[  156s] [COMPILING libboard/qmod/source/board_qmod.c]
[  156s] [COMPILING apps/dfu/main.c]
[  157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c]
[  157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c]
[  157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c]
[  157s] Memory region Used Size  Region Size  %age Used
[  157s]  rom:   16588 B16 KB101.25%
[  157s]  ram:   11672 B48 KB 
23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom'
[  157s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region 
`rom' overflowed by 204 bytes
[  157s] collect2: error: ld returned 1 exit status
[  157s] %
[  157s] make[2]: *** [Makefile:234: flash] Error 1
[  157s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  157s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2
[  157s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  157s] dh_auto_build: error: make -j1 returned exit code 2
[  157s] make: *** [debian/rules:16: build] Error 25
[  157s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  157s] ### VM INTERACTION START ###
[  160s] [  149.246296] sysrq: Power Off
[  160s] [  149.253627] reboot: Power down
[  160s] ### VM INTERACTION END ###
[  160s] 
[  160s] lamb02 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sun Jan 10 
01:47:05 UTC 2021.
[  160s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)