Change in libosmo-pfcp[master]: PFCP: add Network Instance IE in PDI IE
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30248 )
Change subject: PFCP: add Network Instance IE in PDI IE
..
PFCP: add Network Instance IE in PDI IE
So far the optional Network Instance IE in PDI IEs was not coded by
libosmo-pfcp. Add it.
Test it by adding Network Instance IEs in pfcp_test.c.
osmo-upf needs this, because we are about to add support for Network
Instance in PDI IEs, to determine which local interface to use for GTP
tunnel mapping and encapsulation/decapsulation.
Related: SYS#6192
Change-Id: I162299e70b4fb0c3fef8039d693ac7d3fe4df16a
---
M src/libosmo-pfcp/gen__pfcp_ies_auto.c
M tests/libosmo-pfcp/pfcp_test.c
M tests/libosmo-pfcp/pfcp_test.ok
3 files changed, 23 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/48/30248/1
diff --git a/src/libosmo-pfcp/gen__pfcp_ies_auto.c
b/src/libosmo-pfcp/gen__pfcp_ies_auto.c
index 0dfb43c..5649fe3 100644
--- a/src/libosmo-pfcp/gen__pfcp_ies_auto.c
+++ b/src/libosmo-pfcp/gen__pfcp_ies_auto.c
@@ -99,6 +99,7 @@
static const struct osmo_gtlv_gen_ie_o ies_in_pdi[] = {
Ms(source_iface),
O(f_teid, "local_f_teid"),
+ O(ALL_FROM_NAME, "network_inst"),
O(ALL_FROM_NAME, "ue_ip_address"),
Os(traffic_endpoint_id),
O(iface_type, "source_iface_type"),
diff --git a/tests/libosmo-pfcp/pfcp_test.c b/tests/libosmo-pfcp/pfcp_test.c
index b204a9f..801932c 100644
--- a/tests/libosmo-pfcp/pfcp_test.c
+++ b/tests/libosmo-pfcp/pfcp_test.c
@@ -205,6 +205,10 @@
.precedence = 255,
.pdi = {
.source_iface =
OSMO_PFCP_SOURCE_IFACE_CORE,
+ .network_inst_present = true,
+ .network_inst = {
+ .str = "foo",
+ },
.ue_ip_address_present = true,
.ue_ip_address = {
.ip_is_destination =
true,
@@ -224,6 +228,10 @@
.source_iface =
OSMO_PFCP_SOURCE_IFACE_ACCESS,
.local_f_teid_present = true,
.local_f_teid =
f_teid_access_local,
+ .network_inst_present = true,
+ .network_inst = {
+ .str = "bar",
+ },
},
.outer_header_removal_present = true,
.outer_header_removal = {
@@ -318,6 +326,10 @@
.source_iface =
OSMO_PFCP_SOURCE_IFACE_ACCESS,
.local_f_teid_present = true,
.local_f_teid =
f_teid_access_local,
+ .network_inst_present = true,
+ .network_inst = {
+ .str = "baz",
+ },
},
.outer_header_removal_present = true,
.outer_header_removal = {
@@ -349,6 +361,10 @@
.source_iface =
OSMO_PFCP_SOURCE_IFACE_ACCESS,
.local_f_teid_present = true,
.local_f_teid =
f_teid_access_local,
+ .network_inst_present = true,
+ .network_inst = {
+ .str = "moo",
+ },
},
.outer_header_removal_present = true,
.outer_header_removal = {
diff --git a/tests/libosmo-pfcp/pfcp_test.ok b/tests/libosmo-pfcp/pfcp_test.ok
index 23ce16d..b8eddb9 100644
--- a/tests/libosmo-pfcp/pfcp_test.ok
+++ b/tests/libosmo-pfcp/pfcp_test.ok
@@ -67,10 +67,10 @@
=== start test_enc_dec[6]
encoding: SESSION_EST_REQ
-PFCPv1 SESSION_EST_REQ hdr={seq=7 SEID=0x0} ies={ 'Node ID'=v4:127.0.0.1
'F-SEID'=0x1234567890abcdef,v4:10.9.8.7 'Create PDR'={ { 'PDR ID'=1
'Precedence'=255 'PDI'={ 'Source Interface'=Core 'UE IP
Change in libosmo-pfcp[master]: pfcp_test: add missing 'pdi_present = true'
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30247 )
Change subject: pfcp_test: add missing 'pdi_present = true'
..
pfcp_test: add missing 'pdi_present = true'
test_enc_dec[8] includes a PDI IE in Update PDR. The PDI is optional
here, so it requires setting a presence flag to true. This was missing,
hence the PDI part was not being tested at all. Add this presence flag.
This was probably a copy-paste error from testing the Create PDR IE,
where the PDI is mandatory and has no presence flag.
Change-Id: Idc70ae23f15d3af65f98557cc51a111f2e6d75c9
---
M tests/libosmo-pfcp/pfcp_test.c
M tests/libosmo-pfcp/pfcp_test.ok
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/47/30247/1
diff --git a/tests/libosmo-pfcp/pfcp_test.c b/tests/libosmo-pfcp/pfcp_test.c
index d6853b1..b204a9f 100644
--- a/tests/libosmo-pfcp/pfcp_test.c
+++ b/tests/libosmo-pfcp/pfcp_test.c
@@ -344,6 +344,7 @@
.upd_pdr = {
{
.pdr_id = 1,
+ .pdi_present = true,
.pdi = {
.source_iface =
OSMO_PFCP_SOURCE_IFACE_ACCESS,
.local_f_teid_present = true,
diff --git a/tests/libosmo-pfcp/pfcp_test.ok b/tests/libosmo-pfcp/pfcp_test.ok
index 2b8cc1a..23ce16d 100644
--- a/tests/libosmo-pfcp/pfcp_test.ok
+++ b/tests/libosmo-pfcp/pfcp_test.ok
@@ -89,10 +89,10 @@
=== start test_enc_dec[8]
encoding: SESSION_MOD_REQ
-PFCPv1 SESSION_MOD_REQ hdr={seq=9 SEID=0x0} ies={ 'Remove PDR'={ { 'PDR ID'=1
} } 'Remove FAR'={ { 'FAR ID'=1 } } 'Create PDR'={ { 'PDR ID'=3
'Precedence'=255 'PDI'={ 'Source Interface'=Access 'F-TEID'=CHOOSE-v4 } 'Outer
Header Removal'=GTP_U_UDP_IPV4 'FAR ID'=3 } } 'Create FAR'={ { 'FAR ID'=3
'Apply Action'=( FORW ) 'Forwarding Parameters'={ 'Destination
Interface'=Access 'Outer Header Creation'=( GTP_U_UDP_IPV4
),TEID:0xabcdef,v4:10.9.8.7 } } } 'Update PDR'={ { 'PDR ID'=1 'Outer Header
Removal'=GTP_U_UDP_IPV4 'FAR ID'=1 } } 'Update FAR'={ { 'FAR ID'=1 'Update
Forwarding Parameters'={ 'Network Instance'="internet" } } } }
+PFCPv1 SESSION_MOD_REQ hdr={seq=9 SEID=0x0} ies={ 'Remove PDR'={ { 'PDR ID'=1
} } 'Remove FAR'={ { 'FAR ID'=1 } } 'Create PDR'={ { 'PDR ID'=3
'Precedence'=255 'PDI'={ 'Source Interface'=Access 'F-TEID'=CHOOSE-v4 } 'Outer
Header Removal'=GTP_U_UDP_IPV4 'FAR ID'=3 } } 'Create FAR'={ { 'FAR ID'=3
'Apply Action'=( FORW ) 'Forwarding Parameters'={ 'Destination
Interface'=Access 'Outer Header Creation'=( GTP_U_UDP_IPV4
),TEID:0xabcdef,v4:10.9.8.7 } } } 'Update PDR'={ { 'PDR ID'=1 'Outer Header
Removal'=GTP_U_UDP_IPV4 'PDI'={ 'Source Interface'=Access 'F-TEID'=CHOOSE-v4 }
'FAR ID'=1 } } 'Update FAR'={ { 'FAR ID'=1 'Update Forwarding Parameters'={
'Network Instance'="internet" } } } }
osmo_pfcp_msg_encode() rc = 0
-21 34 00 ab 00 00 00 00 00 00 00 00 00 00 09 00 00 0f 00 06 00 38 00 02 00 01
00 10 00 08 00 6c 00 04 00 00 00 01 00 01 00 29 00 38 00 02 00 03 00 1d 00 04
00 00 00 ff 00 02 00 0a 00 14 00 01 00 00 15 00 01 05 00 5f 00 01 00 00 6c 00
04 00 00 00 03 00 03 00 25 00 6c 00 04 00 00 00 03 00 2c 00 02 02 00 00 04 00
13 00 2a 00 01 00 00 54 00 0a 01 00 00 ab cd ef 0a 09 08 07 00 09 00 13 00 38
00 02 00 01 00 5f 00 01 00 00 6c 00 04 00 00 00 01 00 0a 00 18 00 6c 00 04 00
00 00 01 00 0b 00 0c 00 16 00 08 69 6e 74 65 72 6e 65 74 .
-osmo_pfcp_msg_decode_header() rc = 175
+21 34 00 b9 00 00 00 00 00 00 00 00 00 00 09 00 00 0f 00 06 00 38 00 02 00 01
00 10 00 08 00 6c 00 04 00 00 00 01 00 01 00 29 00 38 00 02 00 03 00 1d 00 04
00 00 00 ff 00 02 00 0a 00 14 00 01 00 00 15 00 01 05 00 5f 00 01 00 00 6c 00
04 00 00 00 03 00 03 00 25 00 6c 00 04 00 00 00 03 00 2c 00 02 02 00 00 04 00
13 00 2a 00 01 00 00 54 00 0a 01 00 00 ab cd ef 0a 09 08 07 00 09 00 21 00 38
00 02 00 01 00 5f 00 01 00 00 02 00 0a 00 14 00 01 00 00 15 00 01 05 00 6c 00
04 00 00 00 01 00 0a 00 18 00 6c 00 04 00 00 00 01 00 0b 00 0c 00 16 00 08 69
6e 74 65 72 6e 65 74 .
+osmo_pfcp_msg_decode_header() rc = 189
rc == msgb_length()
osmo_pfcp_msg_decode_tlv() rc = 0
parsed == orig
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30247
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Idc70ae23f15d3af65f98557cc51a111f2e6d75c9
Gerrit-Change-Number: 30247
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in libosmo-pfcp[master]: pfcp_test: init logging, for PFCP errors
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246 )
Change subject: pfcp_test: init logging, for PFCP errors
..
pfcp_test: init logging, for PFCP errors
Initialize logging so that potential errors are shown by the test.
Normally, pfcp_test does not cause any logging. However, I encountered a
linking problem, which caused error logging from libosmo-pfcp, which was
not shown because osmo logging aborted the program first.
Change-Id: I32a99d27ff72edceacb2cf4f4cd996650bc10710
---
M tests/libosmo-pfcp/pfcp_test.c
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/46/30246/1
diff --git a/tests/libosmo-pfcp/pfcp_test.c b/tests/libosmo-pfcp/pfcp_test.c
index b0f3a50..d6853b1 100644
--- a/tests/libosmo-pfcp/pfcp_test.c
+++ b/tests/libosmo-pfcp/pfcp_test.c
@@ -500,13 +500,32 @@
}
}
+static const struct log_info_cat log_categories[] = {
+};
+
+const struct log_info log_info = {
+ .cat = log_categories,
+ .num_cat = ARRAY_SIZE(log_categories),
+};
+
int main(int argc, char **argv)
{
ctx = talloc_named_const(NULL, 0, "pfcp_test");
msgb_talloc_ctx_init(ctx, 0);
+ /* If libosmo-pfcp encounters encoding/decoding errors, it causes
logging in DLPFCP. */
+ osmo_init_logging2(ctx, _info);
+ log_set_print_category_hex(osmo_stderr_target, 0);
+ log_set_print_category(osmo_stderr_target, 1);
+ log_set_print_level(osmo_stderr_target, 1);
+ log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE);
+ log_set_print_timestamp(osmo_stderr_target, 0);
+ log_set_print_extended_timestamp(osmo_stderr_target, 0);
+
test_enc_dec();
+ log_fini();
+
talloc_free(ctx);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I32a99d27ff72edceacb2cf4f4cd996650bc10710
Gerrit-Change-Number: 30246
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-bts[master]: osmux: Use new osmux_xfrm_input API to set name on each link
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30213 ) Change subject: osmux: Use new osmux_xfrm_input API to set name on each link .. Patch Set 1: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/30213/comment/ee839b0b_e8f76942 PS1, Line 168: to_ To be consistent with the sockaddr API output I suggest using "r=ADDR" instead of "to_ADDR". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaea980a2e11282add12f9af585500d90f0462279 Gerrit-Change-Number: 30213 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 22:42:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-msc[master]: libosmonetify SMPP
Attention is currently required from: laforge, pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 ) Change subject: libosmonetify SMPP .. Patch Set 57: (4 comments) File src/libsmpputil/smpp_msc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/a1a8b9d7_5537ec00 PS57, Line 849: The bad side of using auto-formatting :) File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/0fd4aa27_7eeae12a PS49, Line 347: osmo_stream_srv_send(esme->srv, msg); > Yes? osmo_stream_srv_send() returns no value... File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/012cac07_f5a7e68a PS57, Line 767: return -ENOMEM; I know it's unlikely that msgb_alloc() would return NULL, but still: shouldn't we close the connection here? libosmonetif has some data for you, so it calls your callback, but you don't read() from socket. Data is still there, so I guess it will keep calling your callback again and again? https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/1e47a141_65cde513 PS57, Line 855: lost I would say 'closed', because 'lost' sounds like things went wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 57 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: msuraev Gerrit-Comment-Date: Sun, 20 Nov 2022 22:33:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: msuraev Gerrit-MessageType: comment
Change in libosmocore[master]: Add define for unset Frame Number
Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30245 ) Change subject: Add define for unset Frame Number .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641f1a1bf1e86ced8ffe89e88bc48afb79823393 Gerrit-Change-Number: 30245 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: msuraev Gerrit-Comment-Date: Sun, 20 Nov 2022 22:10:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-netif[master]: osmux: Refactor osmux_xfrm_output_pull() to simplify code flow
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30225 ) Change subject: osmux: Refactor osmux_xfrm_output_pull() to simplify code flow .. Patch Set 3: (1 comment) File src/osmux_output.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30225/comment/218a1454_f0848117 PS3, Line 62: next While at it, maybe replace the goto with a proper while-loop? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0da1d7875bd32f6c1022676b64f9f0d14bad3144 Gerrit-Change-Number: 30225 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: osmith Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 22:10:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-netif[master]: osmux: Check received osmuxh->amr_ft is correct before using it
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30224 ) Change subject: osmux: Check received osmuxh->amr_ft is correct before using it .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iab525c5b7eb1e455a8229fb39e96897aac53298c Gerrit-Change-Number: 30224 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 22:03:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-netif[master]: amr: Guard against incorrect AMR FT passed to osmo_amr_{bits,bytes}()
Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/30223 )
Change subject: amr: Guard against incorrect AMR FT passed to
osmo_amr_{bits,bytes}()
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30223
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ib11d4b64c6df19a85c4374fde89e1b56f410e438
Gerrit-Change-Number: 30223
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: msuraev
Gerrit-Reviewer: osmith
Gerrit-Attention: pespin
Gerrit-Comment-Date: Sun, 20 Nov 2022 22:02:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in libosmo-netif[master]: tests/osmux: Add extra asserts to validate osmux header is pulled cor...
Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30222 ) Change subject: tests/osmux: Add extra asserts to validate osmux header is pulled correctly .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2ccc22c53c33025c477236166ea97972c21ec3e Gerrit-Change-Number: 30222 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Attention: msuraev Gerrit-Comment-Date: Sun, 20 Nov 2022 22:01:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-netif[master]: osmux: Improve logging of osmux_xfrm_input
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30211 ) Change subject: osmux: Improve logging of osmux_xfrm_input .. Patch Set 3: (2 comments) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30211/comment/56b42dd7_b1586bd9 PS3, Line 189: state->rtph->ssrc alignment is broken here https://gerrit.osmocom.org/c/libosmo-netif/+/30211/comment/714bc3a5_ddbb450e PS3, Line 334: struct osmux_link *link const? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 Gerrit-Change-Number: 30211 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: osmith Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 22:01:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-netif[master]: osmux: Support recreating lost RTP packets at start of the batch
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30197 ) Change subject: osmux: Support recreating lost RTP packets at start of the batch .. Patch Set 4: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/30197/comment/a734e228_79da1b33 PS4, Line 10: the hole wording: 'gap' might be a better fit here. File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30197/comment/6d9232a7_63aabf78 PS3, Line 454: 1- > ok nvm Agreeing with Oliver here. I haven't seen this style used anywhere so far. Moreover, the '-' in actively used in Russian spelling (in some cases you can even replace a verb with '-'). Not critical, but weird. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3 Gerrit-Change-Number: 30197 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 21:53:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: Add define for unset Frame Number
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30245 ) Change subject: Add define for unset Frame Number .. Patch Set 4: (1 comment) Patchset: PS3: > Would be good to explain where is it going to be used... Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641f1a1bf1e86ced8ffe89e88bc48afb79823393 Gerrit-Change-Number: 30245 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 21:49:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in libosmocore[master]: Add define for unset Frame Number
Attention is currently required from: msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30245 to look at the new patch set (#4). Change subject: Add define for unset Frame Number .. Add define for unset Frame Number It's handy for OsmoPCU as well as upcoming LAPD T200 code. Related: OS#4074 Change-Id: I641f1a1bf1e86ced8ffe89e88bc48afb79823393 --- M include/osmocom/gsm/gsm_utils.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/30245/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641f1a1bf1e86ced8ffe89e88bc48afb79823393 Gerrit-Change-Number: 30245 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Attention: msuraev Gerrit-MessageType: newpatchset
Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_set_name()
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 ) Change subject: osmux: Introduce API osmux_xfrm_input_set_name() .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 21:44:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: adjust coding style in l1sched_trigger()
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30240 ) Change subject: trxcon: adjust coding style in l1sched_trigger() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I96a40fdbea5085999b9aeb98b418ae27132f6fda Gerrit-Change-Number: 30240 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 21:36:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Add define for unset Frame Number
Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30245 ) Change subject: Add define for unset Frame Number .. Patch Set 3: (1 comment) Patchset: PS3: Would be good to explain where is it going to be used... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641f1a1bf1e86ced8ffe89e88bc48afb79823393 Gerrit-Change-Number: 30245 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Attention: msuraev Gerrit-Comment-Date: Sun, 20 Nov 2022 21:34:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: rework l1sched_trigger(), split l1sched_trigger_all()
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30239 ) Change subject: trxcon: rework l1sched_trigger(), split l1sched_trigger_all() .. Patch Set 2: (1 comment) File src/host/trxcon/src/sched_clck.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30239/comment/704b6e46_962d7f28 PS2, Line 47: #define l1sched_trigger_all_advance(sched) \ Pretty much the same question as for previous patch: if l1sched_trigger_all() is only called that way, what's the point of givin as parameter smth which could be computed inside from the other parameter? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0 Gerrit-Change-Number: 30239 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: msuraev Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 21:34:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: LAPD: move tx_hist code into static function
Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 ) Change subject: LAPD: move tx_hist code into static function .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: msuraev Gerrit-Comment-Date: Sun, 20 Nov 2022 21:33:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: make l1sched_trigger() accept the [advanced] TDMA Fn
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30238 ) Change subject: trxcon: make l1sched_trigger() accept the [advanced] TDMA Fn .. Patch Set 2: (1 comment) File src/host/trxcon/src/sched_clck.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30238/comment/100d9183_87882520 PS2, Line 45: /* Advance TDMA frame number in order to give the transceiver That's pretty confusing: you accept as parameter exact same thing which was computed internally before - what's the point? Is there a case where l1sched_trigger() would be called with a different fn value? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icc9127bfacfbb78ab9d74103b2db03be850f3d4f Gerrit-Change-Number: 30238 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: msuraev Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 21:26:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: separate l1sched_clck_handle() from BURST.ind handling
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30243 ) Change subject: trxcon: separate l1sched_clck_handle() from BURST.ind handling .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I25573d1142aec2fee28d884127f14573b681 Gerrit-Change-Number: 30243 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 21:18:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: implement Ready-to-Send PHYIF API
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30241 ) Change subject: trxcon: implement Ready-to-Send PHYIF API .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic8f74413f5fad277340e007dd4296f890155a2c1 Gerrit-Change-Number: 30241 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 21:15:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: rx_sch_fn(): do not use sched->fn_counter_proc
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30242 ) Change subject: trxcon: rx_sch_fn(): do not use sched->fn_counter_proc .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I56027876b50e53b474c2f54ac216cd141142020e Gerrit-Change-Number: 30242 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 21:11:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: LAPD: move tx_hist code into static function
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 ) Change subject: LAPD: move tx_hist code into static function .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 20 Nov 2022 20:39:57 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: Add define for unset Frame Number
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30245 ) Change subject: Add define for unset Frame Number .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641f1a1bf1e86ced8ffe89e88bc48afb79823393 Gerrit-Change-Number: 30245 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 20 Nov 2022 20:39:53 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: use 'trxcon_phyif_' prefix for the PHYIF API
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30221 )
Change subject: trxcon: use 'trxcon_phyif_' prefix for the PHYIF API
..
trxcon: use 'trxcon_phyif_' prefix for the PHYIF API
Change-Id: Icd2fc41cb3f42a791bf619c5f7b8fa4154371ba4
Related: OS#5599
---
M src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
M src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h
M src/host/trxcon/src/trx_if.c
M src/host/trxcon/src/trxcon_fsm.c
M src/host/trxcon/src/trxcon_main.c
M src/host/trxcon/src/trxcon_shim.c
6 files changed, 97 insertions(+), 97 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
b/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
index 7a5740d..43363cb 100644
--- a/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
+++ b/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
@@ -5,72 +5,72 @@
#include
/* PHYIF command type */
-enum phyif_cmd_type {
- PHYIF_CMDT_RESET,
- PHYIF_CMDT_POWERON,
- PHYIF_CMDT_POWEROFF,
- PHYIF_CMDT_MEASURE,
- PHYIF_CMDT_SETFREQ_H0,
- PHYIF_CMDT_SETFREQ_H1,
- PHYIF_CMDT_SETSLOT,
- PHYIF_CMDT_SETTA,
+enum trxcon_phyif_cmd_type {
+ TRXCON_PHYIF_CMDT_RESET,
+ TRXCON_PHYIF_CMDT_POWERON,
+ TRXCON_PHYIF_CMDT_POWEROFF,
+ TRXCON_PHYIF_CMDT_MEASURE,
+ TRXCON_PHYIF_CMDT_SETFREQ_H0,
+ TRXCON_PHYIF_CMDT_SETFREQ_H1,
+ TRXCON_PHYIF_CMDT_SETSLOT,
+ TRXCON_PHYIF_CMDT_SETTA,
};
-/* param of PHYIF_CMDT_SETFREQ_H0 */
-struct phyif_cmdp_setfreq_h0 {
+/* param of TRXCON_PHYIF_CMDT_SETFREQ_H0 */
+struct trxcon_phyif_cmdp_setfreq_h0 {
uint16_t band_arfcn;
};
-/* param of PHYIF_CMDT_SETFREQ_H1 */
-struct phyif_cmdp_setfreq_h1 {
+/* param of TRXCON_PHYIF_CMDT_SETFREQ_H1 */
+struct trxcon_phyif_cmdp_setfreq_h1 {
uint8_t hsn;
uint8_t maio;
const uint16_t *ma;
unsigned int ma_len;
};
-/* param of PHYIF_CMDT_SETSLOT */
-struct phyif_cmdp_setslot {
+/* param of TRXCON_PHYIF_CMDT_SETSLOT */
+struct trxcon_phyif_cmdp_setslot {
uint8_t tn;
uint8_t pchan; /* enum gsm_phys_chan_config */
};
-/* param of PHYIF_CMDT_SETTA */
-struct phyif_cmdp_setta {
+/* param of TRXCON_PHYIF_CMDT_SETTA */
+struct trxcon_phyif_cmdp_setta {
int8_t ta; /* intentionally signed */
};
-/* param of PHYIF_CMDT_MEASURE (command) */
-struct phyif_cmdp_measure {
+/* param of TRXCON_PHYIF_CMDT_MEASURE (command) */
+struct trxcon_phyif_cmdp_measure {
uint16_t band_arfcn;
};
-/* param of PHYIF_CMDT_MEASURE (response) */
-struct phyif_rspp_measure {
+/* param of TRXCON_PHYIF_CMDT_MEASURE (response) */
+struct trxcon_phyif_rspp_measure {
uint16_t band_arfcn;
int dbm;
};
-struct phyif_cmd {
- enum phyif_cmd_type type;
+struct trxcon_phyif_cmd {
+ enum trxcon_phyif_cmd_type type;
union {
- struct phyif_cmdp_setfreq_h0 setfreq_h0;
- struct phyif_cmdp_setfreq_h1 setfreq_h1;
- struct phyif_cmdp_setslot setslot;
- struct phyif_cmdp_setta setta;
- struct phyif_cmdp_measure measure;
+ struct trxcon_phyif_cmdp_setfreq_h0 setfreq_h0;
+ struct trxcon_phyif_cmdp_setfreq_h1 setfreq_h1;
+ struct trxcon_phyif_cmdp_setslot setslot;
+ struct trxcon_phyif_cmdp_setta setta;
+ struct trxcon_phyif_cmdp_measure measure;
} param;
};
-struct phyif_rsp {
- enum phyif_cmd_type type;
+struct trxcon_phyif_rsp {
+ enum trxcon_phyif_cmd_type type;
union {
- struct phyif_rspp_measure measure;
+ struct trxcon_phyif_rspp_measure measure;
} param;
};
/* BURST.req - a burst to be transmitted */
-struct phyif_burst_req {
+struct trxcon_phyif_burst_req {
uint32_t fn;
uint8_t tn;
uint8_t pwr;
@@ -79,7 +79,7 @@
};
/* BURST.ind - a received burst */
-struct phyif_burst_ind {
+struct trxcon_phyif_burst_ind {
uint32_t fn;
uint8_t tn;
int16_t toa256;
@@ -89,8 +89,8 @@
};
-int phyif_handle_burst_ind(void *priv, const struct phyif_burst_ind *bi);
-int phyif_handle_burst_req(void *phyif, const struct phyif_burst_req *br);
-int phyif_handle_cmd(void *phyif, const struct phyif_cmd *cmd);
-int phyif_handle_rsp(void *priv, const struct phyif_rsp *rsp);
-void phyif_close(void *phyif);
+int trxcon_phyif_handle_burst_ind(void *priv, const struct
trxcon_phyif_burst_ind *bi);
+int trxcon_phyif_handle_burst_req(void *phyif, const struct
trxcon_phyif_burst_req *br);
+int trxcon_phyif_handle_cmd(void *phyif, const struct trxcon_phyif_cmd *cmd);
+int trxcon_phyif_handle_rsp(void *priv, const struct trxcon_phyif_rsp *rsp);
+void trxcon_phyif_close(void *phyif);
diff
Change in osmocom-bb[master]: trxcon: drop unneeded imports in trxcon_main.c
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30104 ) Change subject: trxcon: drop unneeded imports in trxcon_main.c .. trxcon: drop unneeded imports in trxcon_main.c Change-Id: I2868f83f55a6cbf3efc59f35ab771d22cf93 --- M src/host/trxcon/src/trxcon_main.c 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/trxcon/src/trxcon_main.c b/src/host/trxcon/src/trxcon_main.c index cf04679..95e5549 100644 --- a/src/host/trxcon/src/trxcon_main.c +++ b/src/host/trxcon/src/trxcon_main.c @@ -28,8 +28,6 @@ #include #include -#include - #include #include #include @@ -39,14 +37,11 @@ #include #include -#include - #include #include #include #include #include -#include #include #define COPYRIGHT \ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2868f83f55a6cbf3efc59f35ab771d22cf93 Gerrit-Change-Number: 30104 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmocom-bb[master]: trxcon: move l1sched/phyif shim API to libtrxcon.la
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30103 )
Change subject: trxcon: move l1sched/phyif shim API to libtrxcon.la
..
trxcon: move l1sched/phyif shim API to libtrxcon.la
Change-Id: I56701b471a6f1c30ffd107037c2b1aed65621b2c
Related: OS#5599
---
M src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
M src/host/trxcon/src/Makefile.am
M src/host/trxcon/src/trx_if.c
M src/host/trxcon/src/trxcon_main.c
A src/host/trxcon/src/trxcon_shim.c
6 files changed, 273 insertions(+), 239 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
b/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
index a92cb89..7a5740d 100644
--- a/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
+++ b/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h
@@ -89,8 +89,8 @@
};
-int phyif_handle_burst_ind(void *phyif, const struct phyif_burst_ind *bi);
+int phyif_handle_burst_ind(void *priv, const struct phyif_burst_ind *bi);
int phyif_handle_burst_req(void *phyif, const struct phyif_burst_req *br);
int phyif_handle_cmd(void *phyif, const struct phyif_cmd *cmd);
-int phyif_handle_rsp(void *phyif, const struct phyif_rsp *rsp);
+int phyif_handle_rsp(void *priv, const struct phyif_rsp *rsp);
void phyif_close(void *phyif);
diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
index ed6adc3..9148771 100644
--- a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
+++ b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
@@ -13,6 +13,9 @@
/* Logging context for sched and l1c */
const char *log_prefix;
+ /* GSMTAP instance (optional) */
+ struct gsmtap_inst *gsmtap;
+
/* The L1 scheduler */
struct l1sched_state *sched;
/* PHY interface (e.g. TRXC/TRXD) */
diff --git a/src/host/trxcon/src/Makefile.am b/src/host/trxcon/src/Makefile.am
index e0ce6a2..34b7a3c 100644
--- a/src/host/trxcon/src/Makefile.am
+++ b/src/host/trxcon/src/Makefile.am
@@ -40,6 +40,7 @@
libtrxcon_la_SOURCES = \
trxcon_inst.c \
trxcon_fsm.c \
+ trxcon_shim.c \
l1ctl.c \
$(NULL)
diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c
index 77001ac..fd6a3b0 100644
--- a/src/host/trxcon/src/trx_if.c
+++ b/src/host/trxcon/src/trx_if.c
@@ -390,7 +390,7 @@
},
};
- phyif_handle_rsp(trx, );
+ phyif_handle_rsp(trx->priv, );
}
/*
@@ -675,7 +675,7 @@
"RX burst tn=%u fn=%u rssi=%d toa=%d\n",
bi.tn, bi.fn, bi.rssi, bi.toa256);
- return phyif_handle_burst_ind(trx, );
+ return phyif_handle_burst_ind(trx->priv, );
}
int trx_if_handle_phyif_burst_req(struct trx_instance *trx,
diff --git a/src/host/trxcon/src/trxcon_main.c
b/src/host/trxcon/src/trxcon_main.c
index 94deeab..54a8067 100644
--- a/src/host/trxcon/src/trxcon_main.c
+++ b/src/host/trxcon/src/trxcon_main.c
@@ -48,7 +48,6 @@
#include
#include
#include
-#include
#define COPYRIGHT \
"Copyright (C) 2016-2022 by Vadim Yanitskiy \n" \
@@ -87,87 +86,6 @@
static void *tall_trxcon_ctx = NULL;
-static void trxcon_gsmtap_send(const struct l1sched_lchan_desc *lchan_desc,
- uint32_t fn, uint8_t tn, uint16_t band_arfcn,
- int8_t signal_dbm, uint8_t snr,
- const uint8_t *data, size_t data_len)
-{
- /* GSMTAP logging may be not enabled */
- if (app_data.gsmtap == NULL)
- return;
-
- /* Omit frames with unknown channel type */
- if (lchan_desc->gsmtap_chan_type == GSMTAP_CHANNEL_UNKNOWN)
- return;
-
- /* TODO: distinguish GSMTAP_CHANNEL_PCH and GSMTAP_CHANNEL_AGCH */
- gsmtap_send(app_data.gsmtap, band_arfcn, tn,
lchan_desc->gsmtap_chan_type,
- lchan_desc->ss_nr, fn, signal_dbm, snr, data, data_len);
-}
-
-/* External L1 API for the scheduler */
-int l1sched_handle_config_req(struct l1sched_state *sched,
- const struct l1sched_config_req *cr)
-{
- struct trxcon_inst *trxcon = sched->priv;
-
- switch (cr->type) {
- case L1SCHED_CFG_PCHAN_COMB:
- {
- struct trxcon_param_set_phy_config_req req = {
- .type = TRXCON_PHY_CFGT_PCHAN_COMB,
- .pchan_comb = {
- .tn = cr->pchan_comb.tn,
- .pchan = cr->pchan_comb.pchan,
- },
- };
-
- return osmo_fsm_inst_dispatch(trxcon->fi,
TRXCON_EV_SET_PHY_CONFIG_REQ, );
- }
- default:
- LOGPFSML(trxcon->fi, LOGL_ERROR,
-
Change in osmocom-bb[master]: trxcon: reorganize the core logic into libtrxcon.la
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30101 )
Change subject: trxcon: reorganize the core logic into libtrxcon.la
..
trxcon: reorganize the core logic into libtrxcon.la
This is needed for the integration with osmo-trx-ms. It was decided
to run the scheduler within the transceiver process, so that we can
reduce scheduling latency. The idea is to maintain trxcon as a sub-
module in osmo-trx.git and link osmo-trx-ms against the libtrxcon.
We cannot use hard-coded logging categoris in a library, so add new
API for setting them: trxcon_set_log_cfg(). Use DLGLOBAL by default.
Change-Id: Idf207947f620a7394e0a0e5bf2c37bcd8df64bbe
Related: OS#5599
---
M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
M src/host/trxcon/src/Makefile.am
M src/host/trxcon/src/l1ctl.c
M src/host/trxcon/src/logging.c
M src/host/trxcon/src/trxcon_fsm.c
M src/host/trxcon/src/trxcon_inst.c
M src/host/trxcon/src/trxcon_main.c
7 files changed, 111 insertions(+), 44 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
index e5ba5ec..ed6adc3 100644
--- a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
+++ b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
@@ -31,6 +31,16 @@
} l1p;
};
+enum trxcon_log_cat {
+ TRXCON_LOGC_FSM,/* trxcon_fsm */
+ TRXCON_LOGC_L1C,/* L1CTL control */
+ TRXCON_LOGC_L1D,/* L1CTL data */
+ TRXCON_LOGC_SCHC, /* l1sched control */
+ TRXCON_LOGC_SCHD, /* l1sched data */
+};
+
+void trxcon_set_log_cfg(const int *logc, unsigned int logc_num);
+
struct trxcon_inst *trxcon_inst_alloc(void *ctx, unsigned int id, uint32_t
fn_advance);
void trxcon_inst_free(struct trxcon_inst *trxcon);
diff --git a/src/host/trxcon/src/Makefile.am b/src/host/trxcon/src/Makefile.am
index e0dc337..e0ce6a2 100644
--- a/src/host/trxcon/src/Makefile.am
+++ b/src/host/trxcon/src/Makefile.am
@@ -35,20 +35,30 @@
$(NULL)
+noinst_LTLIBRARIES += libtrxcon.la
+
+libtrxcon_la_SOURCES = \
+ trxcon_inst.c \
+ trxcon_fsm.c \
+ l1ctl.c \
+ $(NULL)
+
+libtrxcon_la_LIBADD = \
+ libl1sched.la \
+ $(LIBOSMOCORE_LIBS) \
+ $(LIBOSMOGSM_LIBS) \
+ $(NULL)
+
+
bin_PROGRAMS = trxcon
trxcon_SOURCES = \
l1ctl_server.c \
- l1ctl.c \
- trx_if.c \
- logging.c \
- trxcon_fsm.c \
- trxcon_inst.c \
trxcon_main.c \
+ logging.c \
+ trx_if.c \
$(NULL)
trxcon_LDADD = \
- libl1sched.la \
- $(LIBOSMOCORE_LIBS) \
- $(LIBOSMOGSM_LIBS) \
+ libtrxcon.la \
$(NULL)
diff --git a/src/host/trxcon/src/l1ctl.c b/src/host/trxcon/src/l1ctl.c
index 17c136a..47998d6 100644
--- a/src/host/trxcon/src/l1ctl.c
+++ b/src/host/trxcon/src/l1ctl.c
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
#include
#include
@@ -45,6 +46,10 @@
#define L1CTL_LENGTH 256
#define L1CTL_HEADROOM 32
+/* Logging categories configurable via trxcon_set_log_cfg() */
+int g_logc_l1c = DLGLOBAL;
+int g_logc_l1d = DLGLOBAL;
+
static const char *arfcn2band_name(uint16_t arfcn)
{
enum gsm_band band;
@@ -67,7 +72,7 @@
msg = msgb_alloc_headroom(L1CTL_LENGTH + L1CTL_HEADROOM,
L1CTL_HEADROOM, "l1ctl_tx_msg");
if (!msg) {
- LOGP(DL1C, LOGL_ERROR, "Failed to allocate memory\n");
+ LOGP(g_logc_l1c, LOGL_ERROR, "Failed to allocate memory\n");
return NULL;
}
@@ -88,7 +93,7 @@
if (!msg)
return -ENOMEM;
- LOGPFSMSL(fi, DL1C, LOGL_DEBUG,
+ LOGPFSMSL(fi, g_logc_l1c, LOGL_DEBUG,
"Send PM Conf (%s %d = %d dBm)\n",
arfcn2band_name(band_arfcn),
band_arfcn & ~ARFCN_FLAG_MASK, dbm);
@@ -116,7 +121,7 @@
if (!msg)
return -ENOMEM;
- LOGPFSMSL(fi, DL1C, LOGL_DEBUG, "Send Reset Ind (%u)\n", type);
+ LOGPFSMSL(fi, g_logc_l1c, LOGL_DEBUG, "Send Reset Ind (%u)\n", type);
res = (struct l1ctl_reset *) msgb_put(msg, sizeof(*res));
res->type = type;
@@ -134,7 +139,7 @@
if (!msg)
return -ENOMEM;
- LOGPFSMSL(fi, DL1C, LOGL_DEBUG, "Send Reset Conf (%u)\n", type);
+ LOGPFSMSL(fi, g_logc_l1c, LOGL_DEBUG, "Send Reset Conf (%u)\n", type);
res = (struct l1ctl_reset *) msgb_put(msg, sizeof(*res));
res->type = type;
@@ -183,7 +188,7 @@
fbsb_conf_make(msg, 255, 0);
- LOGPFSMSL(fi, DL1C, LOGL_DEBUG, "Send FBSB Conf (timeout)\n");
+ LOGPFSMSL(fi, g_logc_l1c, LOGL_DEBUG, "Send FBSB Conf (timeout)\n");
return
Change in osmocom-bb[master]: trxcon: rx_sch_fn(): do not use sched->fn_counter_proc
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30242 ) Change subject: trxcon: rx_sch_fn(): do not use sched->fn_counter_proc .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I56027876b50e53b474c2f54ac216cd141142020e Gerrit-Change-Number: 30242 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:32:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: implement Ready-to-Send PHYIF API
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30241 ) Change subject: trxcon: implement Ready-to-Send PHYIF API .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic8f74413f5fad277340e007dd4296f890155a2c1 Gerrit-Change-Number: 30241 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:32:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: adjust coding style in l1sched_trigger()
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30240 ) Change subject: trxcon: adjust coding style in l1sched_trigger() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I96a40fdbea5085999b9aeb98b418ae27132f6fda Gerrit-Change-Number: 30240 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:32:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: rework l1sched_trigger(), split l1sched_trigger_all()
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30239 ) Change subject: trxcon: rework l1sched_trigger(), split l1sched_trigger_all() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0 Gerrit-Change-Number: 30239 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:31:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: make l1sched_trigger() accept the [advanced] TDMA Fn
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30238 ) Change subject: trxcon: make l1sched_trigger() accept the [advanced] TDMA Fn .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icc9127bfacfbb78ab9d74103b2db03be850f3d4f Gerrit-Change-Number: 30238 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:31:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: separate l1sched_clck_handle() from BURST.ind handling
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30243 ) Change subject: trxcon: separate l1sched_clck_handle() from BURST.ind handling .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I25573d1142aec2fee28d884127f14573b681 Gerrit-Change-Number: 30243 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:30:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: separate l1sched_clck_handle() from BURST.ind handling
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30243 ) Change subject: trxcon: separate l1sched_clck_handle() from BURST.ind handling .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I25573d1142aec2fee28d884127f14573b681 Gerrit-Change-Number: 30243 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:30:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: drop unneeded imports in trxcon_main.c
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30104 ) Change subject: trxcon: drop unneeded imports in trxcon_main.c .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2868f83f55a6cbf3efc59f35ab771d22cf93 Gerrit-Change-Number: 30104 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:30:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: use 'trxcon_phyif_' prefix for the PHYIF API
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30221 ) Change subject: trxcon: use 'trxcon_phyif_' prefix for the PHYIF API .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icd2fc41cb3f42a791bf619c5f7b8fa4154371ba4 Gerrit-Change-Number: 30221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:30:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: move l1sched/phyif shim API to libtrxcon.la
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30103 ) Change subject: trxcon: move l1sched/phyif shim API to libtrxcon.la .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I56701b471a6f1c30ffd107037c2b1aed65621b2c Gerrit-Change-Number: 30103 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Sun, 20 Nov 2022 16:29:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon: reorganize the core logic into libtrxcon.la
Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30101 ) Change subject: trxcon: reorganize the core logic into libtrxcon.la .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf207947f620a7394e0a0e5bf2c37bcd8df64bbe Gerrit-Change-Number: 30101 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 16:29:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Split tbf_fsm as tbf_{ul,dl}_fsm
Attention is currently required from: pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/30220 )
Change subject: Split tbf_fsm as tbf_{ul,dl}_fsm
..
Patch Set 3:
(1 comment)
File src/tbf_dl_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/30220/comment/d3e22479_0c2d5581
PS3, Line 7: * modify it under the terms of the GNU General Public License
Which license should be used? For example bts.cpp uses GNU AGPLv3+
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30220
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I879af3f4b3e330687d498cd59f5f4933d6ca56f0
Gerrit-Change-Number: 30220
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-CC: msuraev
Gerrit-Attention: pespin
Gerrit-Comment-Date: Sun, 20 Nov 2022 12:27:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in libosmo-netif[master]: osmux: Improve logging of osmux_xfrm_input
Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30211 ) Change subject: osmux: Improve logging of osmux_xfrm_input .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 Gerrit-Change-Number: 30211 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 12:21:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-netif[master]: osmux: Support recreating lost RTP packets at start of the batch
Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30197 ) Change subject: osmux: Support recreating lost RTP packets at start of the batch .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3 Gerrit-Change-Number: 30197 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 12:21:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_set_name()
Attention is currently required from: osmith, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 ) Change subject: osmux: Introduce API osmux_xfrm_input_set_name() .. Patch Set 3: Code-Review+1 (3 comments) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/cde3c373_bb47f764 PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > If there's some deployed software which is hard to update and modify than the > issues which makes upd […] Done https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/50bfc7ff_8e78031e PS2, Line 777: osmo_talloc_replace_string(link, >name, name); > See my other comment in my answer. Done File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/6ec47527_88b8ee4c PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output: > This is not the case though - backward compatibility is when we keep old > behavior for old API while […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 20 Nov 2022 12:20:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith Comment-In-Reply-To: pespin Comment-In-Reply-To: msuraev Gerrit-MessageType: comment
