Change in ...osmo-bts[master]: bts: Set T200 DCCH values for CCCH

2019-06-25 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/14568 )

Change subject: bts: Set T200 DCCH values for CCCH
..


Patch Set 1:

So after looking a bit at the related code:

bts.c calls libosmocore's lapdm_channel_init2(), which in turn calls 
get_n200_dcch() which will return -1 for CCH and then in turn 
lapdm_channel_init2() will return -EINVAL.

So I think we should in bts.c only print the log line if t200_by_lchan() 
returns != -1, and avoid calling lapdm_channel_init2() in that case too.

I initially tried avoiding a call to lchan_init_lapdm() in osmo-bts if lchan 
was CCCH, but it doesn't seem to like that since then lapdm_rll_tx_cb is never 
called and it seems RACH requests are never handled?


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08
Gerrit-Change-Number: 14568
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 Jun 2019 12:15:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: bts: Set T200 DCCH values for CCCH

2019-06-21 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/14568 )

Change subject: bts: Set T200 DCCH values for CCCH
..


Patch Set 1: Code-Review-1

The CCCH is a uni-directional downlink-only logical channel whcih doesn't run 
any LAPDm.

So in fact, we should never end up initializing lapdm_dl related structures for 
that channel.  I guess it's some generic code that doesn't "know" that we use 
sub-slot 4 for CCCH/BCCH (0..3 are the SDCCH/4 on a combined CCCH+SDCCH4


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08
Gerrit-Change-Number: 14568
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:30:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: bts: Set T200 DCCH values for CCCH

2019-06-21 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/14568 )

Change subject: bts: Set T200 DCCH values for CCCH
..


Patch Set 1:

I'm not sure this is the best approach or even really correct, comments 
welcome. If that type of value is really not used in the end, we'd still then 
set it to 0 for instance.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08
Gerrit-Change-Number: 14568
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:09:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: bts: Set T200 DCCH values for CCCH

2019-06-21 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/14568


Change subject: bts: Set T200 DCCH values for CCCH
..

bts: Set T200 DCCH values for CCCH

Otherwise t200_ms_dcch array values are left uninitialized with random
values, and passed later on to lapdm_channel_init2().

Catched due to some strange values seen in log (see D0 and D3):
osmo-bts/src/common/bts.c:421 (bts=0,trx=0,ts=0,ss=4) Setting T200 D0=1028672, 
D3=2, S0=520, S3=520 (all in ms)

There doesn't seem to be any related field passed by BSC to specifically
set T200 for this chan type, so let's use the one from SDCCH.

Related: OS#4066
Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08
---
M src/common/bts.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/68/14568/1

diff --git a/src/common/bts.c b/src/common/bts.c
index b912f33..80c7834 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -392,6 +392,7 @@
t200_ms_acch[DL_SAPI3] = bts->t200_ms[T200_SACCH_SDCCH] + fn_advance_ms;

switch (lchan->type) {
+   case GSM_LCHAN_CCCH:
case GSM_LCHAN_SDCCH:
t200_ms_dcch[DL_SAPI0] = bts->t200_ms[T200_SDCCH] + 
fn_advance_ms;
t200_ms_dcch[DL_SAPI3] = bts->t200_ms[T200_SDCCH_SAPI3] + 
fn_advance_ms;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3d7e1883811acf97aac97325739f2ff97fc2aa08
Gerrit-Change-Number: 14568
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange