Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 13: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21862/13/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/13/src/gb/gprs_bssgp_rim.c@343 PS13, Line 343: buf_ptr[1] = len & 0xff; > Something is definitely wrong here: you store (x >> 8) and then overwrite it > by (x & 0xff). […] Thanks for pointing this out. This is a bug. A fix is already merged, see: I3cce0b2796793554a421fd3ce8e749c52d22eaea -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 21 Jan 2021 17:21:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 13: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21862/13/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/13/src/gb/gprs_bssgp_rim.c@343 PS13, Line 343: buf_ptr[1] = len & 0xff; Something is definitely wrong here: you store (x >> 8) and then overwrite it by (x & 0xff). I guess the second part should go to buf_ptr[2]? See CID#216670. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 20 Jan 2021 09:26:41 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 19 Jan 2021 09:39:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 18 Jan 2021 20:34:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 13: (2 comments) > Patch Set 12: Code-Review-1 > > my last comments were not still addressed. Looks like I overlooked these. https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c@29 PS10, Line 29: #include > why do you include cbsp here? The deocde_cell_id_u func is declared in > osmocom/gsm/gsm0808_utils. […] Done https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c@55 PS10, Line 55: rc = gsm0808_decode_cell_id_u((union gsm0808_cell_id_u*)>reprt_cell, > You cannot do this cast, the gprs_ra_id struct you are using is not > compatible and not part of cell_ […] I am using struct osmo_cell_global_id_ps for cont->reprt_cell and this is part of union gsm0808_cell_id_u. I was using gprs_ra_id before, but I migrated to osmo_cell_global_id_ps, so it should be correct, or not? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 18 Jan 2021 20:16:58 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#13). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal RIM application specific payload information in a generic way. Lets add the container structurs required for NACC. Depends: libosmocore If48f412c32e8e5a3e604a78d12b74787a4786374 Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,859 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/13 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 12: Code-Review-1 my last comments were not still addressed. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 12 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 15 Jan 2021 15:15:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#12). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal RIM application specific payload information in a generic way. Lets add the container structurs required for NACC. Depends: libosmocore If48f412c32e8e5a3e604a78d12b74787a4786374 Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,859 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/12 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 12 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 10: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c@29 PS10, Line 29: #include why do you include cbsp here? The deocde_cell_id_u func is declared in osmocom/gsm/gsm0808_utils.h https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c@55 PS10, Line 55: rc = gsm0808_decode_cell_id_u((union gsm0808_cell_id_u*)>reprt_cell, You cannot do this cast, the gprs_ra_id struct you are using is not compatible and not part of cell_id_u, use "struct osmo_cell_global_id_ps" for reprt_cell instead -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 10 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 14 Jan 2021 11:20:16 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21862 )
Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..
Patch Set 10:
(1 comment)
> Patch Set 9: Code-Review+1
>
> my struct reuse comment was still not addresses, in case you still want to do
> it.
Thats strange, I have updated it. The current patchset should now have it.
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h
File include/osmocom/gprs/gprs_bssgp_rim.h:
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@7
PS6, Line 7:struct {
> see gsm0808_decode_cell_id_u()
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 10
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Thu, 14 Jan 2021 11:07:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#10). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal RIM application specific payload information in a generic way. Lets add the container structurs required for NACC. Depends: libosmocore If48f412c32e8e5a3e604a78d12b74787a4786374 Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,859 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 10 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 9: Code-Review+1 my struct reuse comment was still not addresses, in case you still want to do it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 13 Jan 2021 13:11:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 12 Jan 2021 22:30:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21862 )
Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..
Patch Set 8:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h
File include/osmocom/gprs/gprs_bssgp_rim.h:
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@7
PS6, Line 7:struct {
> Makes sense, but I could not find a parsing function for the struct. […]
see gsm0808_decode_cell_id_u()
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 8
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-CC: pespin
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:40:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#8). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal RIM application specific payload information in a generic way. Lets add the container structurs required for NACC. Depends: libosmocore If48f412c32e8e5a3e604a78d12b74787a4786374 Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,853 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21862 )
Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..
Patch Set 7:
(18 comments)
Thanks for reviewing!
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h
File include/osmocom/gprs/gprs_bssgp_rim.h:
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@2
PS6, Line 2:
> license/copyright statement?
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@7
PS6, Line 7:struct {
> You could reuse "struct osmo_cell_global_id_ps" from https://gerrit.osmocom.
> […]
Makes sense, but I could not find a parsing function for the struct. I re-used
the existing ones now.
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@73
PS6, Line 73: Si3
> I don't recall the details: But won't we need SI3 as part of the NACC
> feature? We have been waiting […]
The SI3 application container is not used by the NACC application, since the
NACC application will only use NACC application containers. To me the SI3
application seems a bit redundant. The SI3 can also be requested within an NACC
application container. Maybe it is for some other purpose when only SI3 is
required. (8c.6.2 SI3 application)
If we add new application containers at some later point we will make the ABI
incompatible, but the API will still work. From what I can see SI3 is not
needed for NACC and we do not need it now. I have placed the TODOs as a hint
where new application containers would go.
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c
File src/gb/gprs_bssgp_rim.c:
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@4
PS6, Line 4: * (C) 2020 by sysmocom - s.f.m.c. GmbH
> -2021 now I guess?
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@144
PS6, Line 144: buf++;
> so now buf point s to index '1' but the length check above passed with len ==
> 1, i.e. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@145
PS6, Line 145: c
> I think we should set cont->err_app_cont to NULL if the length was only '1'?
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@159
PS6, Line 159: 1)
> shouldnt' this be +1, i.e. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@217
PS6, Line 217: DE
> I think somebody else already meantioned that those macros don't really look
> all that great and shou […]
I have replaced the macros now - I used macros because I was afraid that I
couldn't use different struct types as parameters, but I found a way now to
cast the structs.
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@256
PS6, Line 256: if (len <
> please try to use less magic numbers but instead sizeof() or offsetof()
> macros to gt to those 15 / 3 […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@259
PS6, Line 259: EN
> same here regarding one line
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@300
PS6, Line 300: DE
> why on one line?
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@355
PS6, Line 355: uint
> putting 32kBytes on the stack didn't look very good to me. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@359
PS6, Line 359: if (le
> magic numbers
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@362
PS6, Line 362: ENC_RIM
> magic numbers
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@461
PS6, Line 461: if (le
> magic numbers
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@466
PS6, Line 466: & s
> no space, this looks like a logical "and" otherwise.
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@532
PS6, Line 532: if (len
> magic numbers
Done
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@601
PS6, Line 601: 3
> ?
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 7
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 08 Jan 2021 22:58:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21862 )
Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h
File include/osmocom/gprs/gprs_bssgp_rim.h:
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@7
PS6, Line 7:struct {
You could reuse "struct osmo_cell_global_id_ps" from
https://gerrit.osmocom.org/c/libosmocore/+/22013 here.
In any case, you ruse this struct in at least 2 places, so better move its
definition outside and reuse it.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 6
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 07 Jan 2021 14:19:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 6: (18 comments) https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h File include/osmocom/gprs/gprs_bssgp_rim.h: https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@2 PS6, Line 2: license/copyright statement? https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@73 PS6, Line 73: Si3 I don't recall the details: But won't we need SI3 as part of the NACC feature? We have been waiting for months for NS2 API to stabilize to finally release a new libosmocore, and we cannot merge an API/ABI now that we expect to break soon after the merge because parts are missing. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h File include/osmocom/gprs/gprs_bssgp_rim.h: https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h@13 PS5, Line 13: const uint8_t *app_cont; > is this a pointer to struct bssgp_ran_inf_rim_cont ? I don't think so, it's opaque user data (of length app_cont_len) https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@4 PS6, Line 4: * (C) 2020 by sysmocom - s.f.m.c. GmbH -2021 now I guess? https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@144 PS6, Line 144: buf++; so now buf point s to index '1' but the length check above passed with len == 1, i.e. we are pointing one beind the end of the buffer https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@145 PS6, Line 145: c I think we should set cont->err_app_cont to NULL if the length was only '1'? https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@159 PS6, Line 159: 1) shouldnt' this be +1, i.e. the cause byte plus the container content? https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@217 PS6, Line 217: DE I think somebody else already meantioned that those macros don't really look all that great and should be - if possible replaced by functions. But what I don't understand is why the entire macro and the 'if' statement would need to go into a single line? IS there some logic I'm missing? tis loos like perl syntax "ACTION if CONDITION" whcih obviously is not supported in C. https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@256 PS6, Line 256: if (len < please try to use less magic numbers but instead sizeof() or offsetof() macros to gt to those 15 / 3 / 3. Alternatively, put a comment in the line above exlpaining what those lengths are. Otherwise the reader/reviewer has a hard time knowing if those are correct. https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@259 PS6, Line 259: EN same here regarding one line https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@300 PS6, Line 300: DE why on one line? https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@355 PS6, Line 355: uint putting 32kBytes on the stack didn't look very good to me. But then I read up and determined it should work on most systems today (linux apparently now has a default stack size of 2MB per thread, often 8MB). If the encoder functions were using msgb, it might have been easier to first put the inner TLV and then later wrap (push) the outer TLV around it. Without msgb it's probably a bit harder, but it looks like the outer heaer is of fixed length, so you could call bssgp_enc_app_err_cont_nacc() with the exact location after where later the tag/length fields will be? In any case, not really worth spending time on, given that the 32k on the stack apparently won't hurt. https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@359 PS6, Line 359: if (le magic numbers https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@362 PS6, Line 362: ENC_RIM magic numbers https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@461 PS6, Line 461: if (le magic numbers https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@466 PS6, Line 466: & s no space, this looks like a logical "and" otherwise. https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@532 PS6, Line 532: if (len magic numbers https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@601 PS6, Line 601: 3 ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch:
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 6: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 06 Jan 2021 21:21:56 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 5: (9 comments) I did have done the API changes (unions, full parse) now. However, I did not update the patch yet since I am not entirely done yet. There are basically two problems left: The encoder functions currently write to an uint8_t buffer but depending on how the API will be used an msg buffer might be better. I started working on osmo-pcu, there I will use the API, I first want to see how things turn out there. One big adavantage of msg buffers would also be that they have array bounds checking. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h File include/osmocom/gprs/gprs_bssgp_rim.h: https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h@13 PS5, Line 13: const uint8_t *app_cont; > is this a pointer to struct bssgp_ran_inf_rim_cont ? yes, but to its unparsed binary version. The memory location is inside *buf, which is given as parameter to the decoder function. So, when buf is freed there will be a problem, but I do not see any alternative. The strings can be up to 65535 (or 32767?, I am not sure), so reserving this statically memory is not a good option. Dynamic allocation is also not very attractive here... https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h@73 PS5, Line 73: uint8_t app_id; > I see lots of structs sharing half of the fields. What about adding a HDR > struct or alike? […] I thought about having a header shared over all message types. However, when looking closely its always a bit different. We would have to put a header that satisfies every message / container type (bool xyz_present members) but then the structs do not match up with the spec anymore. I would like to keep it like this. I have now put unions into the application container structs, so things become easier at least at that level. We could also add a "master" struct that unifies all possible rim container types, then we could have a single function that decodes/encodes everything. However I think this would be overkill since in the actual application we would still need If or switch depending on a discriminator. Then it is probably better to go by the TLV IEI on that level. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@32 PS5, Line 32: #define DEC_RIM_CONT_COMMON \ > this looks more like a function tbh. It was a function... https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@51 PS5, Line 51: #define ENC_RIM_CONT_COMMON \ > same, would be a lot clearer (to read and ebug) having a static function. […] If I do it that way I can only call the function with one struct type, so it does not work for me. Its probably not that effective anyway. I think its only used in 3 locations anyway. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@68 PS5, Line 68: memset(cont, 0, sizeof(*cont)); > this memset not needed afaict. Its not needed because I set the struct members to NULL / 0 in the else branches below. I think its better to remove the else branches and keep the memset. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@106 PS5, Line 106: ENC_RIM_CONT_COMMON > if (enc_rim_cont_common(cont) < 0) […] This is all in the macro. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@127 PS5, Line 127: memset(cont, 0, sizeof(*cont)); > memset not needed afaict see above https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@288 PS5, Line 288: } else > coding sytle: else clause shoudl also have brackets if "if" clause have them. Done https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@514 PS5, Line 514: return (int)(buf_ptr - buf); > You may need to cast this through intptr_t to avoid warnings. like this: return (int)((intptr_t)buf_ptr - (intptr_t)buf) ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 06 Jan 2021 09:53:43 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 ) Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. Patch Set 5: (9 comments) YOu need to resolve the merging conflicts. Some of my comments are not really hardlines, just some ideas to improve the code. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h File include/osmocom/gprs/gprs_bssgp_rim.h: https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h@13 PS5, Line 13: const uint8_t *app_cont; is this a pointer to struct bssgp_ran_inf_rim_cont ? https://gerrit.osmocom.org/c/libosmocore/+/21862/5/include/osmocom/gprs/gprs_bssgp_rim.h@73 PS5, Line 73: uint8_t app_id; I see lots of structs sharing half of the fields. What about adding a HDR struct or alike? Even better, one struct with a union handling different msg types. It may also make sense to write it in primitive<->msgb alike code like we do in other protocol stacks. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@32 PS5, Line 32: #define DEC_RIM_CONT_COMMON \ this looks more like a function tbh. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@51 PS5, Line 51: #define ENC_RIM_CONT_COMMON \ same, would be a lot clearer (to read and ebug) having a static function. Let the compiler decide whether to inline or not. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@68 PS5, Line 68: memset(cont, 0, sizeof(*cont)); this memset not needed afaict. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@106 PS5, Line 106: ENC_RIM_CONT_COMMON if (enc_rim_cont_common(cont) < 0) return -EINVAL; https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@127 PS5, Line 127: memset(cont, 0, sizeof(*cont)); memset not needed afaict https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@288 PS5, Line 288: } else coding sytle: else clause shoudl also have brackets if "if" clause have them. https://gerrit.osmocom.org/c/libosmocore/+/21862/5/src/gb/gprs_bssgp_rim.c@514 PS5, Line 514: return (int)(buf_ptr - buf); You may need to cast this through intptr_t to avoid warnings. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 04 Jan 2021 09:33:03 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#5). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal generic RIM application specific payload information. Lets add the container structurs required for NACC. Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,369 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#4). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal generic RIM application specific payload information. Lets add the container structurs required for NACC. Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,368 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#3). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal generic RIM application specific payload information. Lets add the container structurs required for NACC. Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,368 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21862 to look at the new patch set (#2). Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers .. bssgp_rim: add encoder/decoder for NACC related RIM containers BSSGP RIM uses a number of nested containers to signal generic RIM application specific payload information. Lets add the container structurs required for NACC. Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Related: SYS#5103 --- M include/Makefile.am A include/osmocom/gprs/gprs_bssgp_rim.h M src/gb/Makefile.am A src/gb/gprs_bssgp_rim.c M src/gb/libosmogb.map M tests/Makefile.am A tests/gb/gprs_bssgp_rim_test.c A tests/gb/gprs_bssgp_rim_test.ok M tests/testsuite.at 9 files changed, 1,369 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
