Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/19146 )
Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
..
gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
The sysmobts uses the same OML attributes as IP.access. Because the IP.access
attribute only supports IPv4 as NSVC configuration, add an own attribute.
Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588
---
M include/osmocom/gsm/protocol/gsm_12_21.h
M src/gsm/abis_nm.c
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h
b/include/osmocom/gsm/protocol/gsm_12_21.h
index 86d12ea..06755c9 100644
--- a/include/osmocom/gsm/protocol/gsm_12_21.h
+++ b/include/osmocom/gsm/protocol/gsm_12_21.h
@@ -511,6 +511,7 @@
/* osmocom (osmo-bts) specific attributes, used in combination
* with the "org.osmocom" manufacturer identification */
+ NM_ATT_OSMO_NS_LINK_CFG = 0xfd, /* osmocom version supports
IPv4 & IPv6 in difference to IPACC */
NM_ATT_OSMO_REDUCEPOWER = 0xfe, /* TLV_TYPE_TV */
};
#define NM_ATT_BS11_FILE_DATA NM_ATT_EVENT_TYPE
diff --git a/src/gsm/abis_nm.c b/src/gsm/abis_nm.c
index 3fb8f0f..13837d2 100644
--- a/src/gsm/abis_nm.c
+++ b/src/gsm/abis_nm.c
@@ -589,6 +589,7 @@
/*! org.osmocom GSM A-bis OML TLV parser definition */
const struct tlv_definition abis_nm_osmo_att_tlvdef = {
.def = {
+ [NM_ATT_OSMO_NS_LINK_CFG] = { TLV_TYPE_TL16V },
[NM_ATT_OSMO_REDUCEPOWER] = { TLV_TYPE_TV },
},
};
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588
Gerrit-Change-Number: 19146
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
Gerrit-MessageType: merged
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 7: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c@515 PS6, Line 515: NM_ATT_OSMO_NS_LINK_CFG > Shouldn't this be a part of abis_nm_osmo_att_tlvdef? At least > NM_ATT_OSMO_REDUCEPOWER is defined the […] see my comment https://gerrit.osmocom.org/c/libosmocore/+/19146#message-613e3f74ae329e8cf29b825cd7cac017631dd3f3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 16:41:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/7/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/7/src/gsm/abis_nm.c@592 PS7, Line 592: TLV_TYPE_TL16V > Hmm, wouldn't TLV_TYPE_TV be enough BTW? no, it needs to be a tlv because the length isn't fixed. (the new ns_link_cfg can also support ipv4). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 04 Aug 2020 08:54:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/7/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/7/src/gsm/abis_nm.c@592 PS7, Line 592: TLV_TYPE_TL16V Hmm, wouldn't TLV_TYPE_TV be enough BTW? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 03 Aug 2020 06:50:03 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 03 Aug 2020 01:38:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c@515 PS6, Line 515: NM_ATT_OSMO_NS_LINK_CFG > Shouldn't this be a part of abis_nm_osmo_att_tlvdef? At least > NM_ATT_OSMO_REDUCEPOWER is defined the […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Sat, 01 Aug 2020 20:07:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19146 to look at the new patch set (#7). Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG The sysmobts uses the same OML attributes as IP.access. Because the IP.access attribute only supports IPv4 as NSVC configuration, add an own attribute. Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 --- M include/osmocom/gsm/protocol/gsm_12_21.h M src/gsm/abis_nm.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/19146/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c@515 PS6, Line 515: NM_ATT_OSMO_NS_LINK_CFG Shouldn't this be a part of abis_nm_osmo_att_tlvdef? At least NM_ATT_OSMO_REDUCEPOWER is defined there. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 28 Jul 2020 17:50:01 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h File include/osmocom/gsm/protocol/gsm_12_21.h: https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@428 PS2, Line 428: NM_ATT_IPACC_PAGING_CFG = 0x8f, NM_ATT_IPACC_PAGING_CFG = NM_ATT_BS11_RF_RES_IND_PER https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@464 PS2, Line 464: NM_ATT_BS11_RF_RES_IND_PER = 0x8f, NM_ATT_IPACC_PAGING_CFG = NM_ATT_BS11_RF_RES_IND_PER https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@514 PS2, Line 514: , /* > not sure if it is legal to have two enum members map to the same value > (NM_ATT_BS11_PASSWORD just a […] we're doing it already with 0x8f. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 28 Jul 2020 09:32:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h File include/osmocom/gsm/protocol/gsm_12_21.h: https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@514 PS2, Line 514: , /* not sure if it is legal to have two enum members map to the same value (NM_ATT_BS11_PASSWORD just a few lines above). We may have to eithe use unique values, or move to a different enum or #defines for the osmcoom specific NM_ATT. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Jul 2020 10:56:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 06 Jul 2020 09:08:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/19146 )
Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
..
gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
The sysmobts uses the same OML attributes as IP.access. Because the IP.access
attribute only supports IPv4 as NSVC configuration, add an own attribute.
Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588
---
M include/osmocom/gsm/protocol/gsm_12_21.h
M src/gsm/abis_nm.c
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/19146/1
diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h
b/include/osmocom/gsm/protocol/gsm_12_21.h
index 86d12ea..06755c9 100644
--- a/include/osmocom/gsm/protocol/gsm_12_21.h
+++ b/include/osmocom/gsm/protocol/gsm_12_21.h
@@ -511,6 +511,7 @@
/* osmocom (osmo-bts) specific attributes, used in combination
* with the "org.osmocom" manufacturer identification */
+ NM_ATT_OSMO_NS_LINK_CFG = 0xfd, /* osmocom version supports
IPv4 & IPv6 in difference to IPACC */
NM_ATT_OSMO_REDUCEPOWER = 0xfe, /* TLV_TYPE_TV */
};
#define NM_ATT_BS11_FILE_DATA NM_ATT_EVENT_TYPE
diff --git a/src/gsm/abis_nm.c b/src/gsm/abis_nm.c
index 3fb8f0f..c4c7b97 100644
--- a/src/gsm/abis_nm.c
+++ b/src/gsm/abis_nm.c
@@ -512,6 +512,7 @@
[NM_ATT_IPACC_SEC_POSSIBLE] = { TLV_TYPE_TL16V },
[NM_ATT_IPACC_IML_SSL_STATE] = { TLV_TYPE_TL16V },
[NM_ATT_IPACC_REVOC_DATE] = { TLV_TYPE_TL16V },
+ [NM_ATT_OSMO_NS_LINK_CFG] = { TLV_TYPE_TL16V },
},
};
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588
Gerrit-Change-Number: 19146
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
