Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 10 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Oct 2020 19:26:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 10: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/10/TODO-RELEASE File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/10/TODO-RELEASE@12 PS10, Line 12: libosmocore >1.4.0 (1.4.1?) need BSSMAP-LE, BSSLAP, GAD coding that's for sure not going to be 1.4.1 if all those features are needed ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 10 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Oct 2020 10:51:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 10: finally a V+1! thank heavens. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 10 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 08 Oct 2020 22:39:28 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#10). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore) Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M TODO-RELEASE M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 30 files changed, 1,858 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 10 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#9). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore) Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M TODO-RELEASE M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 30 files changed, 1,858 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 9 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#8). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore) Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M TODO-RELEASE M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 30 files changed, 1,861 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 8 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#7). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore) Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M TODO-RELEASE M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 29 files changed, 1,858 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#6). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore) Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M TODO-RELEASE M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 29 files changed, 1,849 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#5). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore) Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 28 files changed, 1,848 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 3: latest build failure relatest to #include Apparently gsm_data now depends on that, which is unfortunate and means that even all small utility program now need LIBOSMO_SIGTRAN_CFLAGS (or whatever it may be called. Hopefully it's just the header file and we don't need to actually link tools like meas_feed2pcap against libosmo-sigtran (as they obviosly don't use sigtran stuff). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 08 Oct 2020 07:10:20 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/3//COMMIT_MSG@7 PS3, Line 7: LCS: implement the bulk of Location Services I guess this should have a Requires/Depends: libosmocore.git ? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 08 Oct 2020 07:03:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c File src/osmo-bsc/lcs_loc_req.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c@144 PS1, Line 144: // FIXME LCS QoS IE is mandatory for requesting the location > This probably needs to be addressed before merging? we don't require the IE, just we "should" be pedantic about accepting the message when that IE is missing. Not necessary to implement now. https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c@461 PS1, Line 461: int paging_request_cancel(struct bsc_subscr *bsub, enum bsc_paging_reason reasons) > unsigned you mean the return value? keeping the same rc as paging_request_stop() above. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 12:24:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#3). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 28 files changed, 1,848 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:24:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#2). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 28 files changed, 1,848 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c File src/osmo-bsc/lcs_loc_req.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c@8 PS1, Line 8: this should all be AGPLv3 for osmo-bsc code! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 03 Oct 2020 08:07:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h File include/osmocom/bsc/lcs_loc_req.h: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h@8 PS1, Line 8:LOGPFSML(LOC_REQ->fi, level, fmt, ## args); \ > missing () around LOC_REQ ack https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h File include/osmocom/bsc/lcs_ta_req.h: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h@11 PS1, Line 11: LOGPFSML(TA_REQ->fi, level, fmt, ## args); \ > () ack https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c File src/osmo-bsc/lb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@49 PS1, Line 49: // TODO use > what about this? it's mentioned in the SYS# issue for this. the tests work fine without the BSC sending a RESET, but for practical operation the BSC should RESET to the SMLC, which will follow in another patch https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@653 PS1, Line 653: "serving mobile location centre", > caps at start of word? i took this style from another ctrg_desc, see bsc_ctrg_desc -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 01 Oct 2020 14:37:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20357 )
Change subject: LCS: implement the bulk of Location Services
..
Patch Set 1:
(7 comments)
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h
File include/osmocom/bsc/lcs_loc_req.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h@8
PS1, Line 8:LOGPFSML(LOC_REQ->fi, level, fmt, ## args); \
missing () around LOC_REQ
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h
File include/osmocom/bsc/lcs_ta_req.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h@11
PS1, Line 11: LOGPFSML(TA_REQ->fi, level, fmt, ## args); \
()
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c
File src/osmo-bsc/lb.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@49
PS1, Line 49: // TODO use
what about this?
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@653
PS1, Line 653: "serving mobile location centre",
caps at start of word?
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c
File src/osmo-bsc/lcs_loc_req.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c@144
PS1, Line 144: // FIXME LCS QoS IE is mandatory for requesting the location
This probably needs to be addressed before merging?
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_ta_req.c
File src/osmo-bsc/lcs_ta_req.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_ta_req.c@207
PS1, Line 207: bsslap_ta_resp = (struct osmo_bssap_le_pdu) {
lol
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c@461
PS1, Line 461: int paging_request_cancel(struct bsc_subscr *bsub, enum
bsc_paging_reason reasons)
unsigned
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
Gerrit-Change-Number: 20357
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 01 Oct 2020 11:53:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
