Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

2022-11-29 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30344 )

Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
..

vty: Fix lost 'no timer-dynamic T3113' config when writing current config

The default is to have a dynamic T3113. However, if the user wished to
set it statically, it would show up when writing the current VTY config.

Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
---
M src/osmo-bsc/bts_vty.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index e01d9b8..50e49b8 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -3033,7 +3033,7 @@
 #define TNUM_STR "T-number, optionally preceded by 't' or 'T'\n"
 DEFUN_ATTR(cfg_bts_t3113_dynamic, cfg_bts_t3113_dynamic_cmd,
   "timer-dynamic T",
-  "Calculate T3113 dynamically based on channel config and load\n"
+  "Calculate T3113 dynamically based on channel config and load 
(default)\n"
   TNUM_STR,
   CMD_ATTR_IMMEDIATE)
 {
@@ -4516,6 +4516,8 @@
/* if we have a limit, write it */
if (bts->paging.free_chans_need >= 0)
vty_out(vty, "  paging free %d%s", bts->paging.free_chans_need, 
VTY_NEWLINE);
+   if (!bts->T3113_dynamic)
+   vty_out(vty, "  no timer-dynamic T3113%s", VTY_NEWLINE);

vty_out(vty, "  neighbor-list mode %s%s",
get_value_string(bts_neigh_mode_strs, 
bts->neigh_list_manual_mode), VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

2022-11-28 Thread laforge 
Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30344 )

Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 29 Nov 2022 07:31:59 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

2022-11-28 Thread fixeria 
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30344 )

Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
..


Patch Set 2: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/30344/comment/0c6906ae_c637abc6
PS1, Line 9: whished
> typo: wished
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 28 Nov 2022 15:42:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

2022-11-28 Thread pespin 
Attention is currently required from: pespin.
Hello Jenkins Builder, neels, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/30344

to look at the new patch set (#2).

Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
..

vty: Fix lost 'no timer-dynamic T3113' config when writing current config

The default is to have a dynamic T3113. However, if the user wished to
set it statically, it would show up when writing the current VTY config.

Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
---
M src/osmo-bsc/bts_vty.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/30344/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

2022-11-28 Thread fixeria 
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30344 )

Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
..


Patch Set 1: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/30344/comment/68caa9c2_914d2a28
PS1, Line 9: whished
typo: wished



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 28 Nov 2022 14:05:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

2022-11-28 Thread neels 
Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30344 )

Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 28 Nov 2022 13:52:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

2022-11-28 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30344 )


Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
..

vty: Fix lost 'no timer-dynamic T3113' config when writing current config

The default is to have a dynamic T3113. However, if the user whished to
set it statically, it would show up when writing the current VTY config.

Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
---
M src/osmo-bsc/bts_vty.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/30344/1

diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index e01d9b8..50e49b8 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -3033,7 +3033,7 @@
 #define TNUM_STR "T-number, optionally preceded by 't' or 'T'\n"
 DEFUN_ATTR(cfg_bts_t3113_dynamic, cfg_bts_t3113_dynamic_cmd,
   "timer-dynamic T",
-  "Calculate T3113 dynamically based on channel config and load\n"
+  "Calculate T3113 dynamically based on channel config and load 
(default)\n"
   TNUM_STR,
   CMD_ATTR_IMMEDIATE)
 {
@@ -4516,6 +4516,8 @@
/* if we have a limit, write it */
if (bts->paging.free_chans_need >= 0)
vty_out(vty, "  paging free %d%s", bts->paging.free_chans_need, 
VTY_NEWLINE);
+   if (!bts->T3113_dynamic)
+   vty_out(vty, "  no timer-dynamic T3113%s", VTY_NEWLINE);

vty_out(vty, "  neighbor-list mode %s%s",
get_value_string(bts_neigh_mode_strs, 
bts->neigh_list_manual_mode), VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange