Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-17 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 


Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-17 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
..


Patch Set 1:

> > Login shell has already been added through a script, so no issue
 > with that. Let's keep the default file like in all other osmocom
 > projects.
 >
 >
 > Couldn't a long shell simply be invokved with the -c option and
 > pass an abspath? Or is that beyond the capabilities of the login
 > implementation used on systems where sysmon will be run?

I tested that and it doesn't allow passing parameters, it takes everything 
(including spaces) as path to a binary (and then is unable to find it).

Using a specific .sh file to run the command has already been tested and 
already deployed.


--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Mon, 17 Dec 2018 10:55:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
..


Patch Set 1:

> Login shell has already been added through a script, so no issue with that. 
> Let's keep the default file like in all other osmocom projects.


Couldn't a long shell simply be invokved with the -c option and pass an 
abspath? Or is that beyond the capabilities of the login implementation used on 
systems where sysmon will be run?


--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Mon, 17 Dec 2018 10:44:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
..


Patch Set 1:

> > Patch Set 1: Code-Review-1
 > >
 > > As far as I can tell, in all repos we have default cfg_file as
 > $CWD/*.cfg, so I'd rather keep same behavior for all osmocom
 > projects.
 > >
 > > Another discussion is whether we want to move all osmocom
 > projects to have /etc/osmocom/*.cfg by default. It'd then make
 > sense to by default check first $CWD and if not found look for
 > /etc/osmocom, to maintain it backwards-compatible.
 > 
 > The plan is to use this as login shell and I'm not sure what's $CWD
 > in this case so it's better to use absolute path.

Login shell has already been added through a script, so no issue with that. 
Let's keep the default file like in all other osmocom projects.


--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Dec 2018 16:00:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
..


Patch Set 1:

> Patch Set 1: Code-Review-1
>
> As far as I can tell, in all repos we have default cfg_file as $CWD/*.cfg, so 
> I'd rather keep same behavior for all osmocom projects.
>
> Another discussion is whether we want to move all osmocom projects to have 
> /etc/osmocom/*.cfg by default. It'd then make sense to by default check first 
> $CWD and if not found look for /etc/osmocom, to maintain it 
> backwards-compatible.

The plan is to use this as login shell and I'm not sure what's $CWD in this 
case so it's better to use absolute path.


--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Dec 2018 15:58:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
..


Patch Set 1: Code-Review-1

As far as I can tell, in all repos we have default cfg_file as $CWD/*.cfg, so 
I'd rather keep same behavior for all osmocom projects.

Another discussion is whether we want to move all osmocom projects to have 
/etc/osmocom/*.cfg by default. It'd then make sense to by default check first 
$CWD and if not found look for /etc/osmocom, to maintain it 
backwards-compatible.


--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Dec 2018 15:55:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-14 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12319


Change subject: Use absolute path for default config
..

Use absolute path for default config

Change-Id: I37c559af99872de9290335699e2118924ae2156a
Related: SYS#2655
---
M src/osysmon_main.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/19/12319/1

diff --git a/src/osysmon_main.c b/src/osysmon_main.c
index 486ee8f..caa25d8 100644
--- a/src/osysmon_main.c
+++ b/src/osysmon_main.c
@@ -130,7 +130,7 @@
const char *config_file;
bool daemonize;
 } cmdline_opts = {
-   .config_file = "osmo-sysmon.cfg",
+   .config_file = "/etc/osmocom/osmo-sysmon.cfg",
.daemonize = false,
 };


--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max