Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Max has posted comments on this change. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. Patch Set 5: Note: test failure doesn't seem to be related to the code change - I've created https://osmocom.org/issues/3766 to track it. -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Assignee: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Tom Tsou Gerrit-CC: tnt Gerrit-Comment-Date: Thu, 24 Jan 2019 16:23:17 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Assignee: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Tom Tsou Gerrit-CC: tnt Gerrit-Comment-Date: Thu, 24 Jan 2019 15:18:58 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Max has posted comments on this change. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. Patch Set 5: Code-Review+1 I've dropped changes from .cfg - after all, it's a temporary plug until further optimizations are implemented to allow developers to run tests without affecting regular users. Once optimizations are in place than we can simply enable this by default without the need to change configs as well. -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Assignee: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Harald Welte Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Tom Tsou Gerrit-CC: tnt Gerrit-Comment-Date: Thu, 24 Jan 2019 14:50:24 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Max has uploaded a new patch set (#5) to the change originally created by Vadim Yanitskiy. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. VTY: add extended (11-bit) RACH detection toggle Since I838c21db29c54f1924dd478c2b34b46b70aab2cd we have both TS1 and TS2 synch. sequences, in addition to "default" TS0. Let's finally introduce the VTY configuration parameter, that can be used to toggle optional detection of both TS1 and TS2. Note: we keep this optional because of potentially bad impact on performance. There's no point in paying the performance penalty unless upper levels (BTS, PCU) actually make use of it. Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Related: OS#3054 --- M CommonLibs/trx_vty.c M CommonLibs/trx_vty.h M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/osmo-trx.cpp 5 files changed, 36 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/23/11423/5 -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Assignee: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Max has uploaded a new patch set (#4) to the change originally created by Vadim Yanitskiy. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. VTY: add extended (11-bit) RACH detection toggle Since I838c21db29c54f1924dd478c2b34b46b70aab2cd we have both TS1 and TS2 synch. sequences, in addition to "default" TS0. Let's finally introduce the VTY configuration parameter, that can be used to toggle optional detection of both TS1 and TS2. Note: we keep this optional because of potentially bad impact on performance. There's no point in paying the performance penalty unless upper levels (BTS, PCU) actually make use of it. Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Related: OS#3054 --- M CommonLibs/trx_vty.c M CommonLibs/trx_vty.h M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/osmo-trx.cpp 5 files changed, 37 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/23/11423/4 -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Assignee: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Assignee: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 24 Jan 2019 12:42:55 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. Patch Set 1: Hi Harald, > [...] when RACH Detection is enabled on TCH during handover, > we never need TS1/TS2 and hence can optimize that case. Thanks, good point! I was thinking about that. > did you actually do some benchmarking to see > if my suspicion about performance impact was correct? Not yet, and not sure will I be able to do in short term. Anyway, which tool(s) would you recommend for benchmarking? > it would be great if we could somehow do this automatically, > [...] Maybe some addition to the TRXCTRL protocol? [...] This is also a good idea! But it would require more efforts, and could be done in a separate change I think. -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Harald Welte Gerrit-Comment-Date: Mon, 22 Oct 2018 15:33:20 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11423 ) Change subject: VTY: add extended (11-bit) RACH detection toggle .. Patch Set 1: * did you actually do some benchmarking to see if my suspicion about performance impact was correct? * it would be great if we could somehow do this automatically without having yet another config option at OsmoTRX. Maybe some addition to the TRXCTRL protocol? A separate verb, or something that can be stated during activation of the timeslot? btw: As far as I know, the 11bit RACH (and hence TS1/TS2) is ever only used on RACH. So when RACH Detection is enabled on TCH during handover, we never need TS1/TS2 and hence can optimize that case. -- To view, visit https://gerrit.osmocom.org/11423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8 Gerrit-Change-Number: 11423 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Harald Welte Gerrit-Comment-Date: Mon, 22 Oct 2018 06:50:40 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/11423
Change subject: VTY: add extended (11-bit) RACH detection toggle
..
VTY: add extended (11-bit) RACH detection toggle
Since I838c21db29c54f1924dd478c2b34b46b70aab2cd we have both TS1
and TS2 synch. sequences, in addition to "default" TS0. Let's
finally introduce the VTY configuration parameter, that can
be used to toggle optional detection of both TS1 and TS2.
Note: we keep this optional because of potentially bad impact on
performance. There's no point in paying the performance penalty
unless upper levels (BTS, PCU) actually make use of it.
Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Related: OS#3054
---
M CommonLibs/trx_vty.c
M CommonLibs/trx_vty.h
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
M Transceiver52M/osmo-trx.cpp
M doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg
M doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg
M doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg
M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg
9 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/23/11423/1
diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index 45b58eb..1bece1e 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -304,6 +304,22 @@
return CMD_SUCCESS;
}
+DEFUN(cfg_ext_rach, cfg_ext_rach_cmd,
+ "ext-rach (disable|enable)",
+ "Enable extended (11-bit) RACH (default=disable)\n")
+{
+ struct trx_ctx *trx = trx_from_vty(vty);
+
+ if (strcmp("disable", argv[0]) == 0)
+ trx->cfg.ext_rach = false;
+ else if (strcmp("enable", argv[0]) == 0)
+ trx->cfg.ext_rach = true;
+ else
+ return CMD_WARNING;
+
+ return CMD_SUCCESS;
+}
+
DEFUN(cfg_rt_prio, cfg_rt_prio_cmd,
"rt-prio <1-32>",
"Set the SCHED_RR real-time priority\n"
@@ -417,6 +433,7 @@
vty_out(vty, " rssi-offset %f%s", trx->cfg.rssi_offset,
VTY_NEWLINE);
vty_out(vty, " swap-channels %s%s", trx->cfg.swap_channels ? "enable" :
"disable", VTY_NEWLINE);
vty_out(vty, " egprs %s%s", trx->cfg.egprs ? "enable" : "disable",
VTY_NEWLINE);
+ vty_out(vty, " ext-rach %s%s", trx->cfg.ext_rach ? "enable" :
"disable", VTY_NEWLINE);
if (trx->cfg.sched_rr != 0)
vty_out(vty, " rt-prio %u%s", trx->cfg.sched_rr, VTY_NEWLINE);
@@ -454,6 +471,7 @@
vty_out(vty, " RSSI to dBm offset: %f%s", trx->cfg.rssi_offset,
VTY_NEWLINE);
vty_out(vty, " Swap channels: %s%s", trx->cfg.swap_channels ? "Enabled"
: "Disabled", VTY_NEWLINE);
vty_out(vty, " EDGE support: %s%s", trx->cfg.egprs ? "Enabled" :
"Disabled", VTY_NEWLINE);
+ vty_out(vty, " Extended RACH support: %s%s", trx->cfg.ext_rach ?
"Enabled" : "Disabled", VTY_NEWLINE);
vty_out(vty, " Real Time Priority: %u (%s)%s", trx->cfg.sched_rr,
trx->cfg.sched_rr ? "Enabled" : "Disabled", VTY_NEWLINE);
vty_out(vty, " Channels: %u%s", trx->cfg.num_chans, VTY_NEWLINE);
@@ -564,6 +582,7 @@
install_element(TRX_NODE, _rssi_offset_cmd);
install_element(TRX_NODE, _swap_channels_cmd);
install_element(TRX_NODE, _egprs_cmd);
+ install_element(TRX_NODE, _ext_rach_cmd);
install_element(TRX_NODE, _rt_prio_cmd);
install_element(TRX_NODE, _filler_cmd);
diff --git a/CommonLibs/trx_vty.h b/CommonLibs/trx_vty.h
index c921722..8d251ee 100644
--- a/CommonLibs/trx_vty.h
+++ b/CommonLibs/trx_vty.h
@@ -57,6 +57,7 @@
double offset;
double rssi_offset;
bool swap_channels;
+ bool ext_rach;
bool egprs;
unsigned int sched_rr;
unsigned int num_chans;
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index d6ddce8..28d1a30 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -159,7 +159,8 @@
* are still expected to report clock indications through control channel
* activity.
*/
-bool Transceiver::init(FillerType filler, size_t rtsc, unsigned rach_delay,
bool edge)
+bool Transceiver::init(FillerType filler, size_t rtsc, unsigned rach_delay,
+ bool edge, bool ext_rach)
{
int d_srcport, d_dstport, c_srcport, c_dstport;
@@ -173,6 +174,7 @@
return false;
}
+ mExtRACH = ext_rach;
mEdge = edge;
mDataSockets.resize(mChans);
@@ -583,6 +585,10 @@
if (mEdge && (type == TSC))
type = EDGE;
+ /* Enable extended (11-bit) RACH detection if required */
+ if (mExtRACH && (type == RACH))
+type = EXT_RACH;
+
/* Debug: dump bursts to disk */
/* bits 0-7 - chan 0 timeslots
* bits 8-15 - chan 1 timeslots */
@@ -635,9 +641,11 @@
noise = 20.0 * log10(rxFullScale / state->mNoiseLev);
}
+ unsigned max_toa = (type ==
