Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28986 ) Change subject: GTP mockup: list active GTP endecaps actions .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: abandon
Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions
Attention is currently required from: neels, pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28986 ) Change subject: GTP mockup: list active GTP endecaps actions .. Patch Set 3: (1 comment) Patchset: PS2: > I personally see no reason for using the mockup stuff in the ttcn3 tests, and > hence no reason for th […] I tend to agree with pespin's assessment. We shouldn't have development/debug only features [enabled] in normal production builds. Particularlly not if they make it look like some objects existed, while in reality they don't. Looks like a huge source of potential user confusion. Also, for the TTCN-3 tests, I think in general the goal should be to run the unmodified program just like in production, with all of its interfaces etc. If for some reason we cannot do that in our existing normal jenkins slaves or docker containers, we can always use some kind of special slaves (we already do for example for testing the E1 / frame relay bits. So I think if some testing/mocking is happening, it should happen on the tester (application, OS, VM, ...) side, and not inside the implementation-under-test. VTY tests is a different special case, and we're not arguing about that here. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Thu, 11 Aug 2022 19:07:01 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions
Attention is currently required from: laforge, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28986 ) Change subject: GTP mockup: list active GTP endecaps actions .. Patch Set 3: (1 comment) Patchset: PS3: modified the commit log to better explain why the patch is useful -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 10 Aug 2022 18:11:41 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions
Attention is currently required from: neels, laforge, fixeria. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 to look at the new patch set (#3). Change subject: GTP mockup: list active GTP endecaps actions .. GTP mockup: list active GTP endecaps actions In GTP mockup mode, keep a GTP device (struct upf_gtp_dev) so that the GTP actions activated in mockup mode are listed on VTY. Drop the global GTP mockup mode, and instead allow single GTP devices to be mockup devices. Do not always open the mnl_socket, but only open it when an actual non-mockup GTP device is being opened. (In the presence of non-mockup GTP devices, this still happens directly upon program startup.) The GTP mockup was first introduced for VTY tests during 'make check'. So far, in mockup mode, all GTP tunnel actions were simply cut short, and no tunnels were ever listed as active. TTCN3 tests do query osmo-upf to list currently active tunnels, so the GTP mockup fails these tests. To allow running TTCN3 tests without cap_net_admin privileges, always list (fake) active GTP tunnels. Useful in a lab environment: send PFCP commands to osmo-upf and get a listing of GTP tunnels that would have been active. So far, osmo-upf always uses only the first GTP device configured, but if we add support for multiple GTP devices, this patch allows putting only single devices in mockup mode. Related: SYS#5599 Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 --- M doc/examples/osmo-upf/osmo-upf-mockup.cfg M include/osmocom/upf/upf.h M include/osmocom/upf/upf_gtp.h M src/osmo-upf/osmo_upf_main.c M src/osmo-upf/up_gtp_action.c M src/osmo-upf/upf.c M src/osmo-upf/upf_gtp.c M src/osmo-upf/upf_vty.c M tests/upf.vty 9 files changed, 82 insertions(+), 66 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/86/28986/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
