Change in pysim[master]: Use zero padding for EF['ACC'] field
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Use zero padding for EF['ACC'] field The ``EF_ACC`` field defines the access control class (ACC) for a subscriber. Without this patch, the implementation adds padding 1 towards the most significant bits if the input is shorter than 2 bytes. However, it should be padded with 0, otherwise additional ACCs are allocated to the subscriber. (Probably only a single bit shall be set to 1) Excerpt from [ETSI TS 131 102, 4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf): ``` EF_ACC: Two bytes: B1, B2 B1.b8...B1.b4: high priority users (class 15...11) B1.b3: always 0 B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be evenly distributed across subscribers ``` **Legend:** Byte X, bit Y: BX.bY Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 --- M pySim/cards.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/cards.py b/pySim/cards.py index ad6ddbc..8ac80bf 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -76,7 +76,7 @@ return sw def update_acc(self, acc): - data, sw = self._scc.update_binary(EF['ACC'], lpad(acc, 4)) + data, sw = self._scc.update_binary(EF['ACC'], lpad(acc, 4, c='0')) return sw def read_hplmn_act(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 4 Gerrit-Owner: Falkenber9 Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: merged
Change in pysim[master]: Use zero padding for EF['ACC'] field
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 3 Gerrit-Owner: Falkenber9 Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 07 Apr 2021 16:23:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 07 Apr 2021 10:04:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 06 Apr 2021 19:30:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
Robert Falkenberg has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23632 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 4: Sorry, pushed wrong branch. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 Gerrit-Change-Number: 23632 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 05 Apr 2021 19:11:55 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
Robert Falkenberg has restored this change. ( https://gerrit.osmocom.org/c/pysim/+/23632 ) Change subject: Use zero padding for EF['ACC'] field .. Restored -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 Gerrit-Change-Number: 23632 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: restore
Change in pysim[master]: Use zero padding for EF['ACC'] field
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 2: > Patch Set 2: > > What happened? Jenkins doesen't like it anymore. Where can I find the reason? First time it was due to some connection problem during the build verification: Could not install packages due to an EnvironmentError: 404 Client Error: Not Found for url: https://pypi.org/simple/pkg-resources/ I tried to re-trigger the build, but now it fails because something has changed on the test SIM card(s). I guess we're experiencing this problem https://osmocom.org/issues/4383 again. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 05 Apr 2021 17:20:34 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
Robert Falkenberg has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 2: What happened? Jenkins doesen't like it anymore. Where can I find the reason? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 05 Apr 2021 16:57:07 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
Robert Falkenberg has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/23632 ) Change subject: Use zero padding for EF['ACC'] field .. Abandoned Duplicate -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 Gerrit-Change-Number: 23632 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in pysim[master]: Use zero padding for EF['ACC'] field
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/23631 to look at the new patch set (#2). Change subject: Use zero padding for EF['ACC'] field .. Use zero padding for EF['ACC'] field The ``EF_ACC`` field defines the access control class (ACC) for a subscriber. Without this patch, the implementation adds padding 1 towards the most significant bits if the input is shorter than 2 bytes. However, it should be padded with 0, otherwise additional ACCs are allocated to the subscriber. (Probably only a single bit shall be set to 1) Excerpt from [ETSI TS 131 102, 4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf): ``` EF_ACC: Two bytes: B1, B2 B1.b8...B1.b4: high priority users (class 15...11) B1.b3: always 0 B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be evenly distributed across subscribers ``` **Legend:** Byte X, bit Y: BX.bY Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 --- M pySim/cards.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/23631/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in pysim[master]: Use zero padding for EF['ACC'] field
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/23632 to look at the new patch set (#4). Change subject: Use zero padding for EF['ACC'] field .. Use zero padding for EF['ACC'] field The ``EF_ACC`` field defines the access control class (ACC) for a subscriber. Without this patch, the implementation adds padding 1 towards the most significant bits if the input is shorter than 2 bytes. However, it should be padded with 0, otherwise additional ACCs are allocated to the subscriber. (Probably only a single bit shall be set to 1) Excerpt from [ETSI TS 131 102, 4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf): ``` EF_ACC: Two bytes: B1, B2 B1.b8...B1.b4: high priority users (class 15...11) B1.b3: always 0 B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be evenly distributed across subscribers ``` **Legend:** Byte X, bit Y: BX.bY Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 --- M pySim/cards.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/23632/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 Gerrit-Change-Number: 23632 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in pysim[master]: Use zero padding for EF['ACC'] field
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/23632 to look at the new patch set (#3). Change subject: Use zero padding for EF['ACC'] field .. Use zero padding for EF['ACC'] field The ``EF_ACC`` field defines the access control class (ACC) for a subscriber. Without this patch, the implementation adds padding 1 towards the most significant bits if the input is shorter than 2 bytes. However, it should be padded with 0, otherwise additional ACCs are allocated to the subscriber. (Probably only a single bit shall be set to 1) Excerpt from [ETSI TS 131 102, 4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf): ``` EF_ACC: Two bytes: B1, B2 B1.b8...B1.b4: high priority users (class 15...11) B1.b3: always 0 B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be evenly distributed across subscribers ``` **Legend:** Byte X, bit Y: BX.bY Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 --- M pySim/cards.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/23632/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 Gerrit-Change-Number: 23632 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in pysim[master]: Use zero padding for EF['ACC'] field
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/23632 to look at the new patch set (#2). Change subject: Use zero padding for EF['ACC'] field .. Use zero padding for EF['ACC'] field Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 --- M pySim/cards.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/23632/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08 Gerrit-Change-Number: 23632 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in pysim[master]: Use zero padding for EF['ACC'] field
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 1: > Patch Set 1: > > The ``EF_ACC`` field defines the access control class (ACC) for a subscriber. > > Current implementation adds padding 1 towards the most significant bits if > the input is shorter than 2 bytes. > > However, it should be padded with 0, otherwise additional ACCs are allocated > to the subscriber. (Probably only a single bit shall be set to 1) > > Excerpt from [ETSI TS 131 102, > 4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf): > > ``` > EF_ACC: Two bytes: B1, B2 > > B1.b8...B1.b4: high priority users (class 15...11) > B1.b3: always 0 > B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be > evenly distributed across subscribers > ``` > > **Legend:** Byte X, bit Y: BX.bY This description should be in the commit message. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 05 Apr 2021 15:39:30 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 1: (1 comment) thanks! let's remove the old line rather than commenting it out and get it merged. https://gerrit.osmocom.org/c/pysim/+/23631/1/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/23631/1/pySim/cards.py@79 PS1, Line 79: # let's remove that old line of code. There's no need to keep it around, the history is stored in git. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 05 Apr 2021 11:49:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
Robert Falkenberg has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 1: The ``EF_ACC`` field defines the access control class (ACC) for a subscriber. Current implementation adds padding 1 towards the most significant bits if the input is shorter than 2 bytes. However, it should be padded with 0, otherwise additional ACCs are allocated to the subscriber. (Probably only a single bit shall be set to 1) Excerpt from [ETSI TS 131 102, 4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf): ``` EF_ACC: Two bytes: B1, B2 B1.b8...B1.b4: high priority users (class 15...11) B1.b3: always 0 B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be evenly distributed across subscribers ``` **Legend:** Byte X, bit Y: BX.bY -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Falkenberg Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 05 Apr 2021 06:24:51 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: Use zero padding for EF['ACC'] field
Robert Falkenberg has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Use zero padding for EF['ACC'] field Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 --- M pySim/cards.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/23631/1 diff --git a/pySim/cards.py b/pySim/cards.py index 5eb2884..0d5d6b9 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -76,7 +76,8 @@ return sw def update_acc(self, acc): - data, sw = self._scc.update_binary(EF['ACC'], lpad(acc, 4)) + #data, sw = self._scc.update_binary(EF['ACC'], lpad(acc, 4)) + data, sw = self._scc.update_binary(EF['ACC'], lpad(acc, 4, c='0')) return sw def read_hplmn_act(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9 Gerrit-Change-Number: 23631 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Falkenberg Gerrit-MessageType: newchange
