Re: [Gimp-developer] PATCH - tiny bug in the rect tool
On Tue, 7 Feb 2006, Sven Neumann wrote: Thanks for the patch, I have committed the change to CVS. In general though, the preferred way to submit patches is by using our bug-tracker. I know, but it was so small that I assumed it would be commited pretty soon anyway (and it was, thanks). If not I would have put it in bugzilla. By the way, in http://developer.gimp.org/HACKING it say Please submit patches to the gimp-developer@lists.xcf.berkeley.edu mailing list. It's also a good idea to file a bug-report at http://bugzilla.gnome.org/ and attach your patch to it. Maybe it should be changed to suggest bugzilla as the primary method? -- /Dennis Björklund ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] PATCH - tiny bug in the rect tool
This is a patch for a tiny little bug in the the aspect calculation of the rectangle tool (division by zero). When I fixed the above I also noticed that the center point of the rectangle was calculated using integer division even though the center coordinates are gdoubles and thus can store the real center. So I changed the division by 2 into division by 2.0. ps. real as in both correct and non-integer! -- /Dennis Björklund Index: app/tools/gimprectangletool.c === RCS file: /cvs/gnome/gimp/app/tools/gimprectangletool.c,v retrieving revision 1.30 diff -u -r1.30 gimprectangletool.c --- app/tools/gimprectangletool.c 4 Feb 2006 05:37:20 - 1.30 +++ app/tools/gimprectangletool.c 6 Feb 2006 19:53:31 - @@ -2548,13 +2548,13 @@ width = x2 - x1; height = y2 - y1; - if (width 0.01) + if (height 0.01) aspect = width / height; else aspect = 0; - center_x = (x1 + x2) / 2; - center_y = (y1 + y2) / 2; + center_x = (x1 + x2) / 2.0; + center_y = (y1 + y2) / 2.0; g_signal_handlers_block_by_func (entry, rectangle_dimensions_changed, ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] FAQ (-: sooner or later :-) KDEification of GIMP
On Wed, 22 Jun 2005, Sven Neumann wrote: IMO it is important that typeahead in the file chooser works just like typeahead in all other list and tree views. I don't think that changing the behaviour of typeahead is a good idea. One can also say that it's important that typing in a path always works the same in the dialog and having different things happen when you type paths starting with / then paths without is also not good. For example, what happens if you type ../foo ? Didn't someone point out that the dialog was fixed so that when you type in something it uses the typahead of the file list (I complained that sometimes the bookmark list is focused in my verion of gtk+/gimp when I open the dialog). Does that mean that you can't use type ahead on the bookmark list? Well, I described how I want it to work. We all have our dreams. -- /Dennis ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] FAQ (-: sooner or later :-) KDEification of GIMP
On Wed, 22 Jun 2005, Sven Neumann wrote: If the bookmarks list has the keyboard focus (which it shouldn't have initially), then you can of course use typeahead on the bookmarks list. Good. Not sure what fix you are referring to but this seems to be some kind of rumour. I couldn't find the mail now but I think someone in the thread said that typeahead now worked in the open dialog no matter what widget in it had the focus. Not important anyway, this problem is fixed as far as I understand. Just for fun I put in an enhancement bug in the gtk bugzilla for making the type ahead in the file dialog specialized for paths. So that you can type bar/foo in it and jump directly to that sub directory. bar/foo is not an entry in the current list view, just bar is in this example so it would not work with normal type ahead. But making the type ahead specialized for paths in the file dialog is as I described it before a good idea to me. I don't really expect it to change anything, but maybe one could get some comment from the gtk+ developers about the idea. http://bugzilla.gnome.org/show_bug.cgi?id=308618 And if you guys want to add anything to the bug, please be polite and don't make it into a flame-bug :-) -- /Dennis ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] FAQ (-: sooner or later :-) KDEification of GIMP
On Mon, 20 Jun 2005, Marc wrote: One thing is that people, and _many_ people, just want their location entry back, for lots of reasons: discoverability, pastability and so on. But for some reason this simply does not happen. Do you want this only in gimp or in all programs that use the gtk+ widgets and dialogs? I think the gtk dialog can be made better and should be improved for all applications, not just gimp. Things I don't like: * In fedora 3 I can type in a filename and it selects that file in the file tree view and it just works. It does not work with full paths so I either have to navigate to the correct directory first (which I usually do using a bookmark) or have to use the hidden feature of Ctrl-L (almost never do this). If one fixes so one can type in any path directly, and not just filenames in the current selected dir, then the Ctrl-L is not needed anymore. * The file tree view does not always have input focus when the dialog is opened. So sometimes when I type in a filename the focus is in the bookmark part of the dialog and it matches a bookmark instead. Also, some keys to fast give bookmarks and filelist input focus would be nice (and tab:ing to the right widget is too much work). I've not filed any bugs for the above and I don't know if maybe this have already been improved in later versions of gtk+ then what's in FC3. It's simply not a big enough problem for me that I've done that but I still would want these things to be improved. The battle for you to fight is with gtk2 and not with gimp. If gimp started to use another dialog then what other gtk2 programs did, then people would start a fight about that. I also think that some of you in this thread are unfair to Sven. From my point of view he tries to help as much as he can. For you reverting to the old dialog is a solution, for me that would make the dialog a lot worse. I love the bookmark feature. I usually just use a couple of directories in total and I have these as bookmarks. Currently not everyone is happy with the new dialog but hopefully it can be improved so most of us are happy in the future. If not, then what do you suggest? Either way you choose someone will be unhappy. -- /Dennis ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] FAQ (-: sooner or later :-) KDEification of GIMP
On Mon, 20 Jun 2005, Robert L Krawitz wrote: Adding a simple file (text) entry box with tab completion (and a preference to turn on autocompletion) would, IMHO, solve virtually all of the problems. Or just make the current system work better. In my installation you can type in a filename, one just need to add tab-completion to it and make it support full paths. For example, I want to just be able to type /tmp and press enter and then the dialog changes to that dir. I can't do that today. As I said, I don't know what happend in later versions of gtk then what is in FC3, it might already be improved (you can always hope :-). The ctrl-L popup has lots of problems; not only is it not apparent how to get to it (there's nothing that points at ctrl-L), but it's very clumsy to use (you have to type ctrl-L, type in the filename -- while having to deal with its quirks -- and then click OK twice). No one say that the CTRL-L is any good. It's just a workaround for those of us that are used to tab completion, until we have something better. I hope it can work as explained above in the future. and find the one I want). As far as images go, I currently have about 70 directories with images (65 subdirectories for my digital camera, and some miscellaneous ones). Maybe you need one bookmark to the parent and not 65 bookmarks to all subdirectories, Navigating through all of this is a real pain; the ones I'm most interested in I simply memorize. Right, and I make bookmarks of the places I use the most. Anyway, what I said was just that going back to the old dialog removes the bookmark feature that I use a lot. So no matter if you use the new or old dialog one of us will be unhappy. Not that going back seems to be an option, but if it was I would be against it. -- /Dennis ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] FAQ (-: sooner or later :-) KDEification of GIMP
On Mon, 20 Jun 2005, Robert L Krawitz wrote: Again: adding a simple text entry box for the filename, with tab completion but not autocompletion, would entirely solve my problem here! And I would be happy if you could enter these things in the entry box that pop up when you just start to type. Maybe one should do some hacking and simply make some LD_PRELOAD hack that replaces the dialog in gtk with almost the same one but with an entry box added. Not very pretty but it could help some people.. Maybe a project for someone to play with during some lonely weekend. -- /Dennis ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Report from GIMP talk at FOSDEM
On Wed, 2 Mar 2005, Sven Neumann wrote: Pango didn't have support for letter spacing yet nor does it support vertical text. The release notes for pango 1.5 includes this which I hope should help with the vertical text (or any angle): * Add support for rotated rendering to the FT2 backend -- /Dennis ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Report from GIMP talk at FOSDEM
On Wed, 2 Mar 2005, Sven Neumann wrote: transform routines). Vertical text however has the glyphs all upright but is rendered from top to bottom (like chinese). Isn't that just normal (centered) text with newlines between each character? -- /Dennis Björklund ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] xtns-extras ?
On Sun, 23 Jan 2005, Sven Neumann wrote: to rename the Xtns menu entry to Extras. If it was that simple. There are however lots of scripts and plug-ins, that are out of our control, who are adding to the Toolbox/Xtns menu. Changing the name of the menu in GIMP would cause two menu entries to appear in the toolbox: Extras and Xtns. How does that work with a translation of Gimp? -- /Dennis Björklund ___ Gimp-developer mailing list Gimp-developer@lists.xcf.berkeley.edu http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
[Gimp-developer] Help system
I run gimp in swedish and the translation is very good. The help files however are mostly blank pages. I have to quit and start gimp in english in order to get any help. Of course this problem can be solved by deleting the swedish documentation and then I assume I would get the english one. But it's not the best solution. Also, even if there had been a more complete translation, how do I know if that is a translation of the latest english version? Being able to select language at run time would be helpful. gettext() works well because the translation is only used when the original text is as it was when it was translated. Maybe one could make something similar with the doc, like a md5sum of the help page. If the checksum does not match the one stored with the translation then the english original help is used (or some other language that the user prefer, just like it works with gettext). -- /Dennis Björklund ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
