Re: [Gimp-developer] Re: color balance (preserve luminosity) bug
On 12/21/05, miriam clinton (iriXx) wrote: example images of too much cleaveage for a mailing list kthx. there are women on this list too This is just photogtaphy, not even nu. Nothing too much, really Alexandre ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Re: color balance (preserve luminosity) bug
On Wed, Dec 14, 2005 at 11:05:46AM -0800, sean wrote: example images of bug manifestation could you put these images online? we don't mail images on this list. thanks, carol ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Re: color balance (preserve luminosity) bug
There is free speech; and then there is tact and manners. Playboy centrefolds on a devel list are not what I call manners, nor do I consider that ironic, given my tag line. A man may certainly say what he likes - but manners maketh the man. QED? mC~ Tim Jedlicka wrote: Sorry OT - but...perhaps you should change your tag line if you are easily offended. I suspect Voltaire would approve, and if not, I doubt he would object. Not disagreeing (nor agreeing) with your comment, simply pionting out the irony of your tag line. On 12/20/05, *miriam clinton (iriXx)* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: example images of too much cleaveage for a mailing list kthx. there are women on this list too -- I disapprove of what you say, but I will defend to the death your right to say it. -Voltaire No virus found in this incoming message. Checked by AVG Free Edition. Version: 7.1.371 / Virus Database: 267.14.1/207 - Release Date: 19/12/2005 -- I disapprove of what you say, but I will defend to the death your right to say it. -Voltaire ~ www.iriXx.org ~ www.copyleftmedia.org.uk ~ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Re: color balance (preserve luminosity) bug
I'm sorry Miriam, but claiming those photos were anything even remotely close to Playboy centerfolds is simply a drastic distortion. Those photos were tastefully done, and are certainly *much* less revealing than many of the photos on the cover of Cosmo' and such that are sitting at every grocery store checkout counter. No portions of the woman's breasts or any other private parts were revealed, nor were the clothes at all see-through, nor did they particularly show revealing contours of anything underneath. Yes, the V cut is a little low, but it doesn't show *anything*. It seems to me that you are being *way* overly sensitive. s/KAM - Original Message - From: miriam clinton (iriXx) [EMAIL PROTECTED] To: Tim Jedlicka [EMAIL PROTECTED]; gimp-developer@lists.xcf.berkeley.edu Sent: Wednesday, December 21, 2005 5:39 PM Subject: Re: [Gimp-developer] Re: color balance (preserve luminosity) bug There is free speech; and then there is tact and manners. Playboy centrefolds on a devel list are not what I call manners, nor do I consider that ironic, given my tag line. A man may certainly say what he likes - but manners maketh the man. QED? mC~ Tim Jedlicka wrote: Sorry OT - but...perhaps you should change your tag line if you are easily offended. I suspect Voltaire would approve, and if not, I doubt he would object. Not disagreeing (nor agreeing) with your comment, simply pionting out the irony of your tag line. On 12/20/05, *miriam clinton (iriXx)* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: example images of too much cleaveage for a mailing list kthx. there are women on this list too -- I disapprove of what you say, but I will defend to the death your right to say it. -Voltaire No virus found in this incoming message. Checked by AVG Free Edition. Version: 7.1.371 / Virus Database: 267.14.1/207 - Release Date: 19/12/2005 -- I disapprove of what you say, but I will defend to the death your right to say it. -Voltaire ~ www.iriXx.org ~ www.copyleftmedia.org.uk ~ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Re: color balance (preserve luminosity) bug
On Thu, Dec 22, 2005 at 10:45:56AM +1100, miriam clinton (iriXx) wrote: Alexandre Prokoudine wrote: On 12/21/05, miriam clinton (iriXx) wrote: example images of too much cleaveage for a mailing list kthx. there are women on this list too This is just photogtaphy, not even nu. Nothing too much, really That does not mean that it is pleasant to have to look at. If you want to get your kicks out of pornography, kindly keep it to your bedroom. Consider the other participants on this list - I know I am not the only woman here. I could give you several other reasons why 'not even nu' photography is damaging to both men and women in society and to a woman's self-image. But this is not the place for an essay on anorexia nervosa and the moral decay of society. Oh please. The images in question are so not pornography. You could see people dressed like that in G rated Disney films. This is a mailing list about GIMP development. GIMP is about all sorts of images. Prudish lectures about images have nothing to do with GIMP development. If that's all you can contribute, you don't really belong on this list. As far as I'm concerned, even images with nudity are fine here, so long as there's some artistic merit. Giving URLs to images instead of attaching them is preferred however. This is the final word on this subject. I don't want to see any more posts from you, Miriam, regarding this. -Yosh ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Re: color balance (preserve luminosity) bug
On 12/22/05, miriam clinton (iriXx) wrote: This is just photogtaphy, not even nu. Nothing too much, really That does not mean that it is pleasant to have to look at. If you want to get your kicks out of pornography, kindly keep it to your bedroom. Consider the other participants on this list - I know I am not the only woman here. I could give you several other reasons why 'not even nu' photography is damaging to both men and women in society and to a woman's self-image. But this is not the place for an essay on anorexia nervosa and the moral decay of society. Miriam, I'm not in a mood to argue about thresholds of sensitivity, especially when it comes to portrait photography. If you are not the only woman in this list, then I'd like to hear from others, possibly offlist, because I would like to encourage development of GIMP, not development of flamewars. Until then I will have to live with the fact that you are trying to talk for people who haven't granted you the right to do so ;) Alexandre ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Re: color balance (preserve luminosity) bug
example images of too much cleaveage for a mailing list kthx. there are women on this list too sean wrote: example images of bug manifestation -- I disapprove of what you say, but I will defend to the death your right to say it. -Voltaire ~ www.iriXx.org ~ www.copyleftmedia.org.uk ~ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Re: color balance (preserve luminosity) bug
I'm not working on directly with the Gimp source, but I did fix the
bug with Preserve Luminosity. The offending code in color-balance.c
lines 182-187:
if (cb-preserve_luminosity)
{
gimp_rgb_to_hsl_int (r_n, g_n, b_n);
b_n = gimp_rgb_to_l_int (r, g, b);
gimp_hsl_to_rgb_int (r_n, g_n, b_n);
}
I'm working in Objective-C, so my code isn't copy paste ready.
Basically, if cb- preserve_luminosity, re-scale the slider values so
that the lightness of R1+G1+B1 = the lightness of the base pixel
R+G+B, now use these modified slider values when changing the pixel
values:
-(NSBitmapImageRep *)colorAdjustedImage:(NSBitmapImageRep *)baseImageRep
preserveLumenance:(BOOL)preserveLumenance
colorTone:(LSColorTone)colorTone
{
int w,h,x,y = 0;
unsigned char *srcData, *p1;
int n, red, green, blue;
double shadowScale, midScale, highlightScale;
shadowScale = midScale = highlightScale = 1.0;
if (preserveLumenance == YES) {
shadowScale =1.0 / ( ([_shadowToneRed doubleValue] / 100.0)
+
([_shadowToneGreen doubleValue] / 100.0) + ([_shadowToneBlue
doubleValue] / 100.0) );
midScale = 1.0 / ( ( [_midToneRed doubleValue] / 100.0)
+ (
[_midToneGreen doubleValue] / 100.0) + ( [_midToneBlue doubleValue]
/ 100.0) );
highlightScale = 1.0 / ( ( [_highToneRed doubleValue] / 100.0)
+ (
[_highToneGreen doubleValue] / 100.0) + ( [_highToneBlue doubleValue]
/ 100.0) );
shadowScale = shadowScale -1/3 ? -1/3 : shadowScale;
shadowScale = shadowScale 1/3 ? 1/3 : shadowScale;
shadowScale = shadowScale == 0 ? 1.0 : shadowScale;
midScale = midScale -1/3 ? -1/3 : midScale;
midScale = midScale 1/3 ? 1/3 : midScale;
midScale = midScale == 0 ? 1.0 : midScale;
highlightScale = highlightScale -1/3 ? -1/3 : highlightScale;
highlightScale = highlightScale 1/3 ? 1/3 : highlightScale;
highlightScale = highlightScale == 0 ? 1.0 : highlightScale;
}
// update the tonal range values from any changes in the UI
[self applyToneToColorAdjustment:colorToneMatrix];
// now set the slider values for the different tonal ranges
cyan_red[LSColorToneShadow] = shadowScale * [_shadowToneRed
doubleValue];
magenta_green[LSColorToneShadow] = shadowScale * [_shadowToneGreen
doubleValue];
yellow_blue[LSColorToneShadow] = shadowScale * [_shadowToneBlue
doubleValue];
cyan_red[LSColorToneMidtone] = midScale * [_midToneRed doubleValue];
magenta_green[LSColorToneMidtone] = midScale * [_midToneGreen doubleValue];
yellow_blue[LSColorToneMidtone] = midScale * [_midToneBlue doubleValue];
cyan_red[LSColorToneHighlights] = highlightScale *
[_highToneRed doubleValue];
magenta_green[LSColorToneHighlights] = highlightScale *
[_highToneGreen doubleValue];
yellow_blue[LSColorToneHighlights] = highlightScale *
[_highToneBlue doubleValue];
// create the color lookup tables for the current slider values
and tonal ranges
[self color_balance_create_lookup_tables];
// change the pixels
w = [baseImageRep pixelsWide];
h = [baseImageRep pixelsHigh];
srcData = [baseImageRep bitmapData];
n = [baseImageRep bitsPerPixel] / 8;
for ( y = 0 ; y h ; y++) {
for ( x = 0 ; x w ; x++) {
int r, g, b = 0;
p1 = srcData + n * (y * w + x);
// get the pixels color components
r = p1[0];
g = p1[1];
b = p1[2];
// lookup the new color values in the LUTS contructed from
slider values and tonal selections
red = r_lookup[r];
green = g_lookup[g];
blue = b_lookup[b];
// preserve lumenance if requested to do so
// original code from adapted from the Gimp, which does
not work correctly.
//if (preserveLumenance == YES) {
//gimp_rgb_to_hsl_int (red, green, blue); // red
becomes hue, green becomes saturation, blue becomes lightness
//blue = gimp_rgb_to_l_int (r, g, b); // get the
lightness, set it
//gimp_hsl_to_rgb_int (red, green, blue);
//}
// stomp the pixel component values
p1[0] = red;
p1[1] = green;
p1[2] = blue;
}
}
return baseImageRep;
}
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
