Re: [PATCH] git: make git -C '' cmd not to barf
On March 3, 2015 11:30:13 PM GMT+05:30, Junio C Hamano gits...@pobox.com wrote: On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Karthik Nayak karthik@gmail.com writes: now it works like cd which silently succeeds Missing . at end of sentence. And lack of capitalization at the beginning. Yes, noted, Will fix with next patch. More importantly, lack of justification--why is it a good idea to make it works like cd '' in the first place? git.c | 4 +++- That would probably also deserve a test. Will include a patch with next patch version. Another huh? I had on the actual code was if this counts as envchanged, if you are not actually changing the directory at all. Is this meant as a micro for GSoC, by the way? Yes, it's meant for GSoC. I did overlook that. Will fix in next patch version. Thanks for your suggestions -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] git: make git -C '' cmd not to barf
now it works like cd which silently succeeds Signed-off-by: Karthik Nayak karthik@gmail.com --- git.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/git.c b/git.c index 8c7ee9c..f4c2285 100644 --- a/git.c +++ b/git.c @@ -204,7 +204,9 @@ static int handle_options(const char ***argv, int *argc, int *envchanged) fprintf(stderr, No directory given for -C.\n ); usage(git_usage_string); } - if (chdir((*argv)[1])) + if (*(*argv)[1] == 0) + ; /* Ignore as a directory */ + else if (chdir((*argv)[1])) die_errno(Cannot change to '%s', (*argv)[1]); if (envchanged) *envchanged = 1; -- 2.3.1.167.g7f4ba4b.dirty -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] git: make git -C '' cmd not to barf
Karthik Nayak karthik@gmail.com writes: now it works like cd which silently succeeds Missing . at end of sentence. git.c | 4 +++- That would probably also deserve a test. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] git: make git -C '' cmd not to barf
On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Karthik Nayak karthik@gmail.com writes: now it works like cd which silently succeeds Missing . at end of sentence. And lack of capitalization at the beginning. More importantly, lack of justification--why is it a good idea to make it works like cd '' in the first place? git.c | 4 +++- That would probably also deserve a test. Another huh? I had on the actual code was if this counts as envchanged, if you are not actually changing the directory at all. Is this meant as a micro for GSoC, by the way? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
