Re: [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR
On Mon, Apr 28, 2014 at 05:23:25PM +0200, Erik Faye-Lund wrote: On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko ma...@slonopotamus.org wrote: nedalloc was initially added in f0ed82 to fix slowness of standard WinXP memory allocator. Since WinXP is EOLed, this point is no longer valid. The actual reason behind this commit is incompatibility of malloc.c.h with MinGW-W64 headers. Alternative solution implies updating nedalloc to something newer. Did you measure that malloc on newer Windows-versions are actually faster? AFAIK, malloc does a lot more inside the CRT than in the kernel... Windows 8, msysGit. git repack -adf on msysgit/git (best of 3 runs) + nedalloc: 10.5s - nedalloc: 11s git repack -adf on torvalds/linux (best of 3 runs) + nedalloc: 3m 24s - nedalloc: 3m 47s We need to make a decision: drop nedalloc, update nedalloc to later release, patch nedalloc to make it work under MinGW-W64 or disable nedalloc under MinGW-W64 (still leaving it enabled under MinGW). P.S. Waiting for Resolving deltas when cloning torvalds/linux is a pain, perhaps someone should run gprof on it. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR
Marat Radchenko wrote: We need to make a decision: drop nedalloc, update nedalloc to later release, patch nedalloc to make it work under MinGW-W64 or disable nedalloc under MinGW-W64 (still leaving it enabled under MinGW). I say go for the latter (disable for mingw-264). It can be fixed later, and in the meantime nobody gets affected negatively. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR
Did you measure that malloc on newer Windows-versions are actually faster?
No, I didn't. As I said, real reason for this patch is that Git version of
nedalloc fails to compile under MinGW-W64. If we still want to use nedalloc
under MinGW, this patch should be replaced with:
a) Updating nedalloc to newer release that succeeds to compile under MinGW-W64
(I'd prefer this option). As a bonus point, we can drop most (if not all) fixes
that Git currently has on top of nedallox.
OR
b) Patching specific problems that prevent compilation.
OR
c) Introducing separate MinGW/MinGW-W64 behavior to compat.mak.uname, least
preferred
option.N�r��yb�X��ǧv�^�){.n�+ا���ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf
Re: [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR
Erik Faye-Lund wrote: On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko ma...@slonopotamus.org wrote: nedalloc was initially added in f0ed82 to fix slowness of standard WinXP memory allocator. Since WinXP is EOLed, this point is no longer valid. The actual reason behind this commit is incompatibility of malloc.c.h with MinGW-W64 headers. Alternative solution implies updating nedalloc to something newer. Did you measure that malloc on newer Windows-versions are actually faster? AFAIK, malloc does a lot more inside the CRT than in the kernel... If it does turn out that nedalloc is not needed any more, please remove it from compat/, too. ;-) Thanks for cleaning up. Jonathan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR
Marat Radchenko wrote: nedalloc was initially added in f0ed82 to fix slowness of standard WinXP memory allocator. Since WinXP is EOLed, this point is no longer valid. The fact that WinXP is EOLed doesn't mean people are not using it any more =/ I think it should be supported by Git at least for a while. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR
From: Felipe Contreras felipe.contre...@gmail.com Marat Radchenko wrote: nedalloc was initially added in f0ed82 to fix slowness of standard WinXP memory allocator. Since WinXP is EOLed, this point is no longer valid. The fact that WinXP is EOLed doesn't mean people are not using it any more =/ I think it should be supported by Git at least for a while. -- Felipe Contreras -- My family and I have a number of XP machines [chooses frying pan vs fire..] I'd expect a lot of basic users who are more difficult to support to still be on XP for a while. At least until the next big zero day weakness openss up ;-) Philip -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
