Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

[Оля Тележная]

> We hung back on it to leave it as low-hanging fruit for other Outreachy
> applicants. Perhaps Olga would like to pick it up now that the
> application period is over.

It's absolutely not a problem for me, I can do that as one more
warm-up exercise in the beginning of the internship.

Thanks!

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

[Jeff King]

On Wed, Nov 08, 2017 at 10:44:46AM +0900, Junio C Hamano wrote:

> > We could also consider it a #leftoverbits that perhaps some other
> > Outreachy candidate would pick up[1].
> >
> > In the meantime, Junio, I think we'd want to queue this with the intent
> > to graduate it to "pu" or possibly "next", but not "master". Then if
> > somebody (Olga or another applicant) produces the endgame patch, we can
> > queue it on top and move it further. And if nobody does, I can pick it
> > after the application period is over.
> 
> So... do we still want to keep this in 'next', or does somebody
> wants to do honors?  
> 
> I'd really prefer *not* to see you or me ending up finishing it up,
> but at the same time, I really hate seeing a halfway or 3/4 done
> topic hanging around in 'pu'.

We hung back on it to leave it as low-hanging fruit for other Outreachy
applicants. Perhaps Olga would like to pick it up now that the
application period is over.

Alternatively, it might be a nice task for the Bloomberg hackathon this
weekend. I'll add it to the list of topics there, too.

-Peff

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

[Junio C Hamano]

Jeff King  writes:

> I do think there are a few ugly bits in the result (like that
> initializer for packed_git_mru :) ), so I'd prefer not to merge this
> down until we do that final step.
>
> So the big question is: who wants to do it?
>
> I think you've done a good job here, and this would count for your
> Outreachy application's contribution. But if you'd like to do that next
> step, you are welcome to.
>
> We could also consider it a #leftoverbits that perhaps some other
> Outreachy candidate would pick up[1].
>
> In the meantime, Junio, I think we'd want to queue this with the intent
> to graduate it to "pu" or possibly "next", but not "master". Then if
> somebody (Olga or another applicant) produces the endgame patch, we can
> queue it on top and move it further. And if nobody does, I can pick it
> after the application period is over.

So... do we still want to keep this in 'next', or does somebody
wants to do honors?  

I'd really prefer *not* to see you or me ending up finishing it up,
but at the same time, I really hate seeing a halfway or 3/4 done
topic hanging around in 'pu'.

> [1] For those who find this mail through the archive, there's more
> discussion in this thread:
>
>   
> https://public-inbox.org/git/CAL21BmnvJSaN+Tnw7Hdc5P5biAnM5dfWR7gX5FrAG1r_D8th=a...@mail.gmail.com/

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

[Jeff King]

On Mon, Oct 02, 2017 at 12:37:53PM +0300, Оля Тележная wrote:

> >> Simplify mru.[ch] and related code by reusing the double-linked list
> >> implementation from list.h instead of a custom one.
> >> This commit is an intermediate step. Our final goal is to get rid of
> >> mru.[ch] at all and inline all logic.
> >
> > Thanks, this version looks correct to me.
> 
> Great! What is better - to complete my application now (and say only
> about this patch) or to complete it in last days (and say about
> everything that I've done. Maybe there would be something new).

I think it's good to get it started now. You can always make changes to
it later. And in particular, you should fill out the eligibility section
s we can make sure that part is good before going further.

> > I think you've done a good job here, and this would count for your
> > Outreachy application's contribution. But if you'd like to do that next
> > step, you are welcome to.
> 
> I was thinking about starting my small research about main task of the
> internship. I could postpone it and end with this task, there's no
> problem for me.

I do think you should spend some time thinking about and researching the
main task. I'd hope to see in the applications that the candidate has
a sense of the problem space and a realistic plan for approaching the
work.

> Or, if someone from the newbies wants to have a small simple task -
> it's a great opportunity for him/her. By the way, I am ready to help
> if he/she will have questions or difficulties.

Wonderful. :) I do hope to get Outreachy interns involve in normal list
activities like discussion and review, not just producing their own
patches.

> So please make a decision on your own, I will be happy in any scenario.

Why don't we give it a week or so to see if anybody else picks it up.

-Peff

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

[Оля Тележная]

>> Simplify mru.[ch] and related code by reusing the double-linked list
>> implementation from list.h instead of a custom one.
>> This commit is an intermediate step. Our final goal is to get rid of
>> mru.[ch] at all and inline all logic.
>
> Thanks, this version looks correct to me.

Great! What is better - to complete my application now (and say only
about this patch) or to complete it in last days (and say about
everything that I've done. Maybe there would be something new).

> I do think there are a few ugly bits in the result (like that
> initializer for packed_git_mru :) ), so I'd prefer not to merge this
> down until we do that final step.
>
> So the big question is: who wants to do it?
>
> I think you've done a good job here, and this would count for your
> Outreachy application's contribution. But if you'd like to do that next
> step, you are welcome to.

I was thinking about starting my small research about main task of the
internship. I could postpone it and end with this task, there's no
problem for me.
Or, if someone from the newbies wants to have a small simple task -
it's a great opportunity for him/her. By the way, I am ready to help
if he/she will have questions or difficulties.
So please make a decision on your own, I will be happy in any scenario.

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

[Jeff King]

On Sat, Sep 30, 2017 at 05:51:01PM +, Olga Telezhnaya wrote:

> Simplify mru.[ch] and related code by reusing the double-linked list
> implementation from list.h instead of a custom one.
> This commit is an intermediate step. Our final goal is to get rid of
> mru.[ch] at all and inline all logic.

Thanks, this version looks correct to me.

I do think there are a few ugly bits in the result (like that
initializer for packed_git_mru :) ), so I'd prefer not to merge this
down until we do that final step.

So the big question is: who wants to do it?

I think you've done a good job here, and this would count for your
Outreachy application's contribution. But if you'd like to do that next
step, you are welcome to.

We could also consider it a #leftoverbits that perhaps some other
Outreachy candidate would pick up[1].

In the meantime, Junio, I think we'd want to queue this with the intent
to graduate it to "pu" or possibly "next", but not "master". Then if
somebody (Olga or another applicant) produces the endgame patch, we can
queue it on top and move it further. And if nobody does, I can pick it
after the application period is over.

-Peff

[1] For those who find this mail through the archive, there's more
discussion in this thread:

  
https://public-inbox.org/git/CAL21BmnvJSaN+Tnw7Hdc5P5biAnM5dfWR7gX5FrAG1r_D8th=a...@mail.gmail.com/