Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
Alexey Shumkin writes: > This is actually a fixup of de6029a2d7734a93a9e27b9c4471862a47dd8123, > which was applied before final patch series was sent. > > Also, see 3994e8a98dc7bbf67e61d23c8125f44383499a1f for the explanation > of such a replacement. These are not very useful in a log message. People who read the history 6 months down the road would want to see why we want to use iso8859-1 not iso-8859-1 explained. Both "iso8859-1" and "iso-8859-1" are understood as latin-1 by modern platforms, but the latter is not understood by older platforms;update tests to use the former. This is in line with 3994e8a9 (t4201: use ISO8859-1 rather than ISO-8859-1, 2009-12-03), which did the same. > Signed-off-by: Alexey Shumkin > Reviewed-by: Johannes Sixt I do not recall this exact patch reviewed by J6t, but perhaps I missed a message on the list? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
On Thu, Jul 04, 2013 at 11:47:04PM -0700, Junio C Hamano wrote: > Alexey Shumkin writes: > > > This is actually a fixup of de6029a2d7734a93a9e27b9c4471862a47dd8123, > > which was applied before final patch series was sent. > > > > Also, see 3994e8a98dc7bbf67e61d23c8125f44383499a1f for the explanation > > of such a replacement. > > These are not very useful in a log message. People who read the > history 6 months down the road would want to see why we want to use > iso8859-1 not iso-8859-1 explained. > > Both "iso8859-1" and "iso-8859-1" are understood as latin-1 > by modern platforms, but the latter is not understood by > older platforms;update tests to use the former. > > This is in line with 3994e8a9 (t4201: use ISO8859-1 rather > than ISO-8859-1, 2009-12-03), which did the same. Yep, it whould be better, I thought to do like this but I didn't ) > > > Signed-off-by: Alexey Shumkin > > Reviewed-by: Johannes Sixt > > I do not recall this exact patch reviewed by J6t, but perhaps I > missed a message on the list? I've reread 'SubmittingPatches' doc, and I can say I used "Reviewed-by" incorrectly. Sorry for this. It must be "Suggested-by" there, I guess. -- Alexey Shumkin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
Alexey Shumkin writes: >> Both "iso8859-1" and "iso-8859-1" are understood as latin-1 >> by modern platforms, but the latter is not understood by >> older platforms;update tests to use the former. >> >> This is in line with 3994e8a9 (t4201: use ISO8859-1 rather >> than ISO-8859-1, 2009-12-03), which did the same. > Yep, it whould be better, I thought to do like this but I didn't ) >> >> > Signed-off-by: Alexey Shumkin >> > Reviewed-by: Johannes Sixt >> >> I do not recall this exact patch reviewed by J6t, but perhaps I >> missed a message on the list? > I've reread 'SubmittingPatches' doc, and I can say I used "Reviewed-by" > incorrectly. Sorry for this. It must be "Suggested-by" there, I guess. OK, then I'll queue this patch (but not 2-4/5 yet) with log message amended. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
On Fri, Jul 05, 2013 at 01:11:49AM -0700, Junio C Hamano wrote: > Alexey Shumkin writes: > > >>Both "iso8859-1" and "iso-8859-1" are understood as latin-1 > >>by modern platforms, but the latter is not understood by > >>older platforms;update tests to use the former. > >> > >> This is in line with 3994e8a9 (t4201: use ISO8859-1 rather > >>than ISO-8859-1, 2009-12-03), which did the same. > > Yep, it whould be better, I thought to do like this but I didn't ) > >> > >> > Signed-off-by: Alexey Shumkin > >> > Reviewed-by: Johannes Sixt > >> > >> I do not recall this exact patch reviewed by J6t, but perhaps I > >> missed a message on the list? > > I've reread 'SubmittingPatches' doc, and I can say I used "Reviewed-by" > > incorrectly. Sorry for this. It must be "Suggested-by" there, I guess. > > OK, then I'll queue this patch (but not 2-4/5 yet) with log message > amended. Excuse me, you've said "Ok" for 2/5 message, and then explained (as I understood) then "subtle difference" between EOF and \EOF. Should I change the message somehow? > > Thanks. -- Alexey Shumkin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
Alexey Shumkin writes: >> OK, then I'll queue this patch (but not 2-4/5 yet) with log message >> amended. > Excuse me, you've said "Ok" for 2/5 message, and then explained (as I > understood) then "subtle difference" between EOF and \EOF. > Should I change the message somehow? I left it up to you. If I queued without waiting, it wouldn't have been up-to-you, so... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
