[GitHub] [activemq] jbonofre commented on issue #379: [AMQ-7249] jetty, scala and camel upgrades for vulnerabilities fixes
jbonofre commented on issue #379: [AMQ-7249] jetty, scala and camel upgrades for vulnerabilities fixes URL: https://github.com/apache/activemq/pull/379#issuecomment-518950389 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre merged pull request #380: [AMQ-7253] Upgrade to commons-dbcp2 2.6.0 and commons-pool 2.6.2
jbonofre merged pull request #380: [AMQ-7253] Upgrade to commons-dbcp2 2.6.0 and commons-pool 2.6.2 URL: https://github.com/apache/activemq/pull/380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre merged pull request #377: AMQ-7244 - Update Apache Directory + FileServer
jbonofre merged pull request #377: AMQ-7244 - Update Apache Directory + FileServer URL: https://github.com/apache/activemq/pull/377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre merged pull request #381: [AMQ-7254] Fix OSGi headers
jbonofre merged pull request #381: [AMQ-7254] Fix OSGi headers URL: https://github.com/apache/activemq/pull/381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-openwire] killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization
killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r311354658 ## File path: src/nms-openwire.csproj ## @@ -0,0 +1,44 @@ + + + +netstandard2.0 +Apache.NMS.ActiveMQ +Apache.NMS.ActiveMQ +1.8.0 +Apache Software Foundation +Apache ActiveMQ Review comment: Should be fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-openwire] killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization
killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r311354627 ## File path: test/nms-openwire-test.csproj ## @@ -0,0 +1,66 @@ + + + +netcoreapp2.2 +Apache.NMS.ActiveMQ.Test +Apache.NMS.ActiveMQ.Test + +Library + +true +Apache Software Foundation +Apache ActiveMQ +Apache NMS ActiveMQ Review comment: SHould be fixed... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-openwire] killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization
killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r311354605 ## File path: src/nms-openwire.csproj ## @@ -0,0 +1,44 @@ + + + +netstandard2.0 +Apache.NMS.ActiveMQ +Apache.NMS.ActiveMQ +1.8.0 +Apache Software Foundation +Apache ActiveMQ +Apache NMS (.Net Standard Messaging Library): Openwire implementation of Apache NMS API +Copyright (C) 2005-2019 Apache Software Foundation +LICENSE.txt + https://activemq.apache.org/components/nms/ + https://activemq.apache.org/assets/img/activemq_logo_icon.png + https://github.com/apache/activemq-nms-openwire +git +apache;activemq;nms;api;net;messaging +true +NMSKey.snk +true +Apache ActiveMQ + + + +..\..\build\ + + + + + + + + + + + + + Review comment: Should be fixed now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-openwire] killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization
killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r311339413 ## File path: test/nms-openwire-test.csproj ## @@ -0,0 +1,66 @@ + + + +netcoreapp2.2 Review comment: What is there to this? I changed to `TargetFrameworks` and added net35 and net40 but the solution wont compile now. I also added some itemgroup conditions I saw in the API solution.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-openwire] killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization
killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r311339413 ## File path: test/nms-openwire-test.csproj ## @@ -0,0 +1,66 @@ + + + +netcoreapp2.2 Review comment: What is there to this? I changed to `TargetFrameworks` and added net35 and net40 but the solution wont compile now. I also added some itemgroup conditions I saw in the API solution.   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram opened a new pull request #2788: ARTEMIS-2447 allow mapping admin to manage in LDAP plugin
jbertram opened a new pull request #2788: ARTEMIS-2447 allow mapping admin to manage in LDAP plugin URL: https://github.com/apache/activemq-artemis/pull/2788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] bs-logisoft opened a new pull request #2787: NO-JIRA Add artemis-service.xml
bs-logisoft opened a new pull request #2787: NO-JIRA Add artemis-service.xml URL: https://github.com/apache/activemq-artemis/pull/2787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit
cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-518693552 > +1 from me more tests the better, just needs a jira, and squash commits Same +1 for me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering message in the case of consume close
michaelandrepearce commented on a change in pull request #2703: ARTEMIS-2380
Fix delivering message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r311086892
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##
@@ -1175,6 +1179,17 @@ public void addConsumer(final Consumer consumer) throws
Exception {
}
+ @Override
+ public void addLingerRef(Consumer consumer, MessageReference lingerRef)
throws Exception {
+ lingerRef.emptyConsumerID();
+ lingerRefMap.put(lingerRef, consumer);
Review comment:
Original order of message when rollback occurs needs to preserved so that
theyre replayed the same order again
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering message in the case of consume close
michaelandrepearce commented on a change in pull request #2703: ARTEMIS-2380
Fix delivering message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r311085883
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##
@@ -1175,6 +1179,17 @@ public void addConsumer(final Consumer consumer) throws
Exception {
}
+ @Override
+ public void addLingerRef(Consumer consumer, MessageReference lingerRef)
throws Exception {
+ lingerRef.emptyConsumerID();
+ lingerRefMap.put(lingerRef, consumer);
Review comment:
Remember Artemis is mutliprotocol. E.g. it supports more than just JMS
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] coheigea commented on issue #376: AMQ-7259 - Update HTTPClient and replace deprecated calls
coheigea commented on issue #376: AMQ-7259 - Update HTTPClient and replace deprecated calls URL: https://github.com/apache/activemq/pull/376#issuecomment-518659720 @cshannon I think I've created all relevant JIRAs for 5.15.10 - let me know if there are any problems with it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering message in the case of consume close
wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering
message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r310975418
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##
@@ -1175,6 +1179,17 @@ public void addConsumer(final Consumer consumer) throws
Exception {
}
+ @Override
+ public void addLingerRef(Consumer consumer, MessageReference lingerRef)
throws Exception {
+ lingerRef.emptyConsumerID();
+ lingerRefMap.put(lingerRef, consumer);
Review comment:
@franz1981
> Beware putting `MessageReference` into a `Map`:
`MessageReferenceImpl::hashCode` relies on `getMessage().hashCode()` and
`CoreMessage::hashCode` will use the native hash code (like
`java.lang.System#identityHashCode`).
> It is known that it would break biased locking optimization on it (see
https://blogs.oracle.com/dave/biased-locking-in-hotspot for more detail): given
that `CoreMessage` heavily relies on `synchronized` operation, I would suggest
to measure the perf impact of it first
Thanks, franz. I'll have a look and measure the perf.
@michaelandrepearce
> On that note, need to ensure order is preserved hashmap looses any ordering
Good point. BTW, as i read from JMS spec, session is not thread safe, so
closing consumer and committing session from which consumer is created can't be
from multiple threads, correct? If not thread safe, the issue referred in this
PR should be happening rarely? Just not sure whether it's deserved to fix this
trivial problem by adding some tricky and fragile code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering message in the case of consume close
wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering
message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r310975418
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##
@@ -1175,6 +1179,17 @@ public void addConsumer(final Consumer consumer) throws
Exception {
}
+ @Override
+ public void addLingerRef(Consumer consumer, MessageReference lingerRef)
throws Exception {
+ lingerRef.emptyConsumerID();
+ lingerRefMap.put(lingerRef, consumer);
Review comment:
@franz1981
> Beware putting `MessageReference` into a `Map`:
`MessageReferenceImpl::hashCode` relies on `getMessage().hashCode()` and
`CoreMessage::hashCode` will use the native hash code (like
`java.lang.System#identityHashCode`).
> It is known that it would break biased locking optimization on it (see
https://blogs.oracle.com/dave/biased-locking-in-hotspot for more detail): given
that `CoreMessage` heavily relies on `synchronized` operation, I would suggest
to measure the perf impact of it first
Thanks, franz. I'll have a look and measure the perf.
> On that note, need to ensure order is preserved hashmap looses any ordering
Good point. BTW, as i read from JMS spec, session is not thread safe, so
closing consumer and committing session from which consumer is created can't be
from multiple threads, correct? If not thread safe, the issue referred in this
PR should be happening rarely? Just not sure whether it's deserved to fix this
trivial problem by adding some tricky and fragile code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering message in the case of consume close
wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering
message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r310975418
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##
@@ -1175,6 +1179,17 @@ public void addConsumer(final Consumer consumer) throws
Exception {
}
+ @Override
+ public void addLingerRef(Consumer consumer, MessageReference lingerRef)
throws Exception {
+ lingerRef.emptyConsumerID();
+ lingerRefMap.put(lingerRef, consumer);
Review comment:
@franz1981
> Beware putting `MessageReference` into a `Map`:
`MessageReferenceImpl::hashCode` relies on `getMessage().hashCode()` and
`CoreMessage::hashCode` will use the native hash code (like
`java.lang.System#identityHashCode`).
> It is known that it would break biased locking optimization on it (see
https://blogs.oracle.com/dave/biased-locking-in-hotspot for more detail): given
that `CoreMessage` heavily relies on `synchronized` operation, I would suggest
to measure the perf impact of it first
Thanks, franz. I'll have a look and measure the perf.
> On that note, need to ensure order is preserved hashmap looses any ordering
Good point. BTW, as i read from JMS spec, session is not thread safe, so
closing consumer and committing session from which consumer is created can't be
from multiple threads, correct? If not thread safe, the issue referred in this
PR should be happening rarely? Just not sure whether it's deserved to fix this
trivial problem by adding some tricky and fragile code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #9: [PoC] Testing toolkit
michaelandrepearce commented on issue #9: [PoC] Testing toolkit URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-518574536 +1 from me more tests the better, just needs a jira, and squash commits This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers
wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-518556136 @franz1981 > And while catching up, the producers are not seriously decreasing their rate? This PR has helped in your tests? This PR helped to improve consumer throughput while entering into page mode with lots of subscribers. I didn't see the producers rate seriously decreased, although producers slowed down bcs consumers used extra io. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
