[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #15: AMQNET-596: Added local message expiry connection uri connection property
michaelandrepearce merged pull request #15: AMQNET-596: Added local message expiry connection uri connection property URL: https://github.com/apache/activemq-nms-amqp/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #15: AMQNET-596: Added local message expiry connection uri connection property
michaelandrepearce commented on issue #15: AMQNET-596: Added local message expiry connection uri connection property URL: https://github.com/apache/activemq-nms-amqp/pull/15#issuecomment-520733543 @cjwmorgan-sol great thanks, merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #14: AMQNET-591: Transactions support
michaelandrepearce commented on issue #14: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/14#issuecomment-520753478 @cjwmorgan-sol i think the current workaround is safer, than setting something arbitarily, that may cause other unexpected issues. At the end of the day this is only temp until AMQPNetlite release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] HavretGC opened a new pull request #19: AMQNET-600: Equals and GetHashCode should be overridden for IDestination implementations
HavretGC opened a new pull request #19: AMQNET-600: Equals and GetHashCode should be overridden for IDestination implementations URL: https://github.com/apache/activemq-nms-amqp/pull/19 This change is vital if one wants to use NMS AMQP with Spring CachingConnectionFactory, as current implementation prevents it from caching senders and consumers by destination. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] coheigea commented on issue #387: [AMQ-7249] Upgrade to Jetty 9.4.19.v20190610
coheigea commented on issue #387: [AMQ-7249] Upgrade to Jetty 9.4.19.v20190610 URL: https://github.com/apache/activemq/pull/387#issuecomment-520835904 @jbonofre I have a fix for the failing tests in the http module. The karaf itests are also failing though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #14: AMQNET-591: Transactions support
cjwmorgan-sol commented on issue #14: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/14#issuecomment-520846837 > @cjwmorgan-sol i think the current workaround is safer, than setting something arbitarily, that may cause other unexpected issues. At the end of the day this is only temp until AMQPNetlite release. Alright looks fine to me then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 opened a new pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 opened a new pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520888383 This PR is adding `BackupRequestMessage`'s `nodeID` information for shared store colocated setup, to enable proper validation of backup group names: I don't know yet how to handle the case where old brokers are communicating with new ones, but throwing an exception + logging a warn message. I'm opened to other approaches ;) I will add some tests on my PTO return, but I've left this here to make it available for comment/reviewes :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram opened a new pull request #2794: ARTEMIS-2451 limit size of destination cache
jbertram opened a new pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520889867 @howardgao @jbertram wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] tabish121 opened a new pull request #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
tabish121 opened a new pull request #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795 When converting from AMQP to core and back again support annotations that aren't able to be placed into Core message properties by storing the bytes from encoding the types to AMQP encodings and then decoding them again when converting back into AMQP messages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface
jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-520923490 I think this would be better in the User Guide rather than the JavaDoc for this class. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-520926445 Im a bit lost why this is needed. I thought if amqp in and amqp out we did no conversion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] tabish121 commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
tabish121 commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-520927162 Large messages or messages that travel across a cluster are still converted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2691: ARTEMIS-2364 collision avoidance for redelivery
jbertram commented on a change in pull request #2691: ARTEMIS-2364 collision
avoidance for redelivery
URL: https://github.com/apache/activemq-artemis/pull/2691#discussion_r313526420
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##
@@ -1037,6 +1039,11 @@ public SecuritySettingPlugin run() {
addressSettings.setRedeliveryDelay(XMLUtil.parseLong(child));
} else if
(REDELIVERY_DELAY_MULTIPLIER_NODE_NAME.equalsIgnoreCase(name)) {
addressSettings.setRedeliveryMultiplier(XMLUtil.parseDouble(child));
+ } else if
(REDELIVERY_COLLISION_AVOIDANCE_FACTOR_NODE_NAME.equalsIgnoreCase(name)) {
+double redeliveryCollisionAvoidanceFactor =
XMLUtil.parseDouble(child);
+
Validators.GE_ZERO.validate(REDELIVERY_COLLISION_AVOIDANCE_FACTOR_NODE_NAME,
redeliveryCollisionAvoidanceFactor);
+
Validators.LE_ONE.validate(REDELIVERY_COLLISION_AVOIDANCE_FACTOR_NODE_NAME,
redeliveryCollisionAvoidanceFactor);
+
addressSettings.setRedeliveryCollisionAvoidanceFactor(redeliveryCollisionAvoidanceFactor);
Review comment:
For continuity with 5.x I think the configuration should use
`redelivery-collision-avoidance-factor` since 5.x uses
`collisionAvoidanceFactor`. That said, this is really just a matter of opinion
and not strict correctness. It could be implemented any number of ways.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2754: NO-JIRA: Fix RAT plugin warnings for built .NET examples
jbertram commented on issue #2754: NO-JIRA: Fix RAT plugin warnings for built .NET examples URL: https://github.com/apache/activemq-artemis/pull/2754#issuecomment-520941635 This would be easier to track if you just added these `` elements it to the apache-rat-plugin configuration in the main `pom.xml`. That controls the exclusions for everything in the project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2716: Allow setting message properties when sending messages via REST.
jbertram commented on issue #2716: Allow setting message properties when sending messages via REST. URL: https://github.com/apache/activemq-artemis/pull/2716#issuecomment-520942489 This needs a "New Feature" JIRA in https://issues.apache.org/jira/browse/ARTEMIS and the commit message needs to reference the JIRA. See [here](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram edited a comment on issue #2716: Allow setting message properties when sending messages via REST.
jbertram edited a comment on issue #2716: Allow setting message properties when sending messages via REST. URL: https://github.com/apache/activemq-artemis/pull/2716#issuecomment-520942489 This needs a "New Feature" JIRA in https://issues.apache.org/jira/browse/ARTEMIS and the commit message needs to reference the JIRA. See [here](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages). The commit looks good other than that. Nice work! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2779: ARTEMIS-2444 Artemis hawtio plugin overriding sublevel tabs
asfgit closed pull request #2779: ARTEMIS-2444 Artemis hawtio plugin overriding sublevel tabs URL: https://github.com/apache/activemq-artemis/pull/2779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521005728 Rather than this, would it not be better address those then to avoid the conversion. I know clebert wanted at one time to make amqp large message support a required feature for 2.8.0 obv that didnt happen but maybe doing that and addressing the other bit maybe better than adding further workarounds that will need to be maintained This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] tabish121 commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
tabish121 commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521008001 As reported in the original JIRA when an AMQP message is converted to core that contains complex AMQP types inside annotation sections the converter currently blows up instead of handling the message which is not correct as a core client should still be able to receive the message. For the cases of conversions due to large messages or moving over clusters the current broker again cannot handle those and so this is a reasonable fix as it preserves the AMQP data. If you want to contribute a complete solution such that AMQP to AMQP the message is never converted that would be welcome however until that time a fix is needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521123570 So i checked, the bridging code (e.g. intra cluster etc) encodes the message natively then embeds inside a core, as such the original message is fully preserved as is. This just then leaves two issue areas: 1) Large Messages 2) Conversion to Core Currently core doesn't support complex types, as such i think its wrong to leach AMQP encoding into core, as people could start relying on that. Either we should support complex types in core properly or we don't support and those are dropped. Reason for this is what occurs when other protocols support complex types we will be left with a legacy of AMQP encoded inside core. Re large messages this just sounds like we simply aren't fully supporting AMQP large messages, this is known, either we need to support them or we don't. As such i see a few better options here: 1) Support Large Messages for AMQP fully 2) Support complex types in CORE 3) Support 1 & 2 Im against having a solution that leaks AMQP encoding into CORE. just as much as i know we dont like to modify AMQP in transit. I think this should be a no go area. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313726708 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java ## @@ -97,7 +98,7 @@ private final Set tempQueues = new ConcurrentHashSet<>(); - private final Set knownDestinations = new ConcurrentHashSet<>(); + private final ConcurrentMaxSizeCache knownDestinations = new ConcurrentMaxSizeCache<>(100); Review comment: Can we make this configurable (e.g. a setting in the CF), 100 is a bit of a magic number. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
