[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] sunchao commented on a change in pull request #9770: ARROW-12019: [Rust] [Parquet] Update README for 2.6.0 support
sunchao commented on a change in pull request #9770: URL: https://github.com/apache/arrow/pull/9770#discussion_r599282803 ## File path: rust/parquet/README.md ## @@ -50,14 +50,18 @@ See [crate documentation](https://docs.rs/crate/parquet/4.0.0-SNAPSHOT) on avail If you are upgrading from version 3.0 or previous of this crate, you likely need to change your code to use [`ConvertedType`] rather than -[`LogicalType`]. Version 4.0 introduces an *entirely new* struct -called `LogicalType` to align with the `LogicalType` introduced in -Parquet Format 2.4.0. The type previously called `LogicalType` was was -renamed to `ConvertedType`. +[`LogicalType`] to preserve existing behaviour in your code. +Version 2.4.0 of the Parquet format introduced a `LogicalType` to replace the existing `ConvertedType`. +This crate used `parquet::basic::LogicalType` to map to the `ConvertedType`, but this has been renamed to `parquet::basic::ConvertedType` from version 4.0 of this crate. + +The `ConvertedType` is deprecated in the format, but is still written +to preserve backward compatibility. +It is preferred that `LogicalType` is used, as it suports nanosecond Review comment: suports -> supports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609356 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/a188d8a0-dba7-4b68-a94c-fec45491e8e7...8e975c53-7927-48f0-bead-26f02f78d258/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/1e8a5013-85d8-4c2c-be7f-2b94e2cbb9b0...2f4b2001-0279-4247-a3a6-b6d1206a54a2/ [Finished] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/80392a01-5a25-439f-8d05-36428d06e670...d37eae78-d47b-437c-a446-785b22ea6098/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/3f41104f-f4a1-4e63-b63d-ba5a0345077e...b128a180-d4cc-4f8c-87d8-7461ac95fab3/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609304 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/a188d8a0-dba7-4b68-a94c-fec45491e8e7...d49a28b3-1cfc-46c0-8168-55fc575ca113/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/1e8a5013-85d8-4c2c-be7f-2b94e2cbb9b0...f669128b-6f9a-4b26-b6d5-e9a54ca1d1b5/ [Finished] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/80392a01-5a25-439f-8d05-36428d06e670...9e9ad27d-3d1b-49b4-a53d-4ab373b0bc8b/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/3f41104f-f4a1-4e63-b63d-ba5a0345077e...d7d64a93-77e0-4c74-b3dc-33ce423ee9c2/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9768: ARROW-12010: [C++][Compute] DRAFT Improve performance of the hash table used in GroupIdentifier
github-actions[bot] commented on pull request #9768: URL: https://github.com/apache/arrow/pull/9768#issuecomment-804622859 https://issues.apache.org/jira/browse/ARROW-12010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy
codecov-io commented on pull request #9775: URL: https://github.com/apache/arrow/pull/9775#issuecomment-804622488 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=h1) Report > Merging [#9775](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=desc) (cd369c9) into [master](https://codecov.io/gh/apache/arrow/commit/29feea07fea118ad6ffc4d2615a5798412fe2f19?el=desc) (29feea0) will **decrease** coverage by `0.32%`. > The diff coverage is `81.29%`. [](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=tree) ```diff @@Coverage Diff @@ ## master#9775 +/- ## == - Coverage 82.59% 82.27% -0.33% == Files 248 249 +1 Lines 5829458359 +65 == - Hits4814948013 -136 - Misses 1014510346 +201 ``` | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=tree) | Coverage Δ | | |---|---|---| | [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `96.06% <ø> (-0.01%)` | :arrow_down: | | [rust/arrow/src/compute/kernels/window.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3dpbmRvdy5ycw==) | `100.00% <ø> (ø)` | | | [rust/arrow/src/compute/kernels/zip.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3ppcC5ycw==) | `82.14% <ø> (ø)` | | | [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.92% <ø> (ø)` | | | [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `76.22% <ø> (ø)` | | | [rust/arrow/src/ipc/reader.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL3JlYWRlci5ycw==) | `84.36% <ø> (ø)` | | | [rust/arrow/src/ipc/writer.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL3dyaXRlci5ycw==) | `87.44% <ø> (+0.21%)` | :arrow_up: | | [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `83.45% <ø> (-0.06%)` | :arrow_down: | | [rust/arrow/src/json/writer.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi93cml0ZXIucnM=) | `87.91% <ø> (ø)` | | | [rust/arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree#diff-cnVzdC9hcnJvdy9zcmMvcmVjb3JkX2JhdGNoLnJz) | `83.70% <ø> (ø)` | | | ... and [82 more](https://codecov.io/gh/apache/arrow/pull/9775/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=footer). Last update [eebf64b...cd369c9](https://codecov.io/gh/apache/arrow/pull/9775?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609356 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/a188d8a0-dba7-4b68-a94c-fec45491e8e7...8e975c53-7927-48f0-bead-26f02f78d258/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/1e8a5013-85d8-4c2c-be7f-2b94e2cbb9b0...2f4b2001-0279-4247-a3a6-b6d1206a54a2/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/80392a01-5a25-439f-8d05-36428d06e670...d37eae78-d47b-437c-a446-785b22ea6098/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/3f41104f-f4a1-4e63-b63d-ba5a0345077e...b128a180-d4cc-4f8c-87d8-7461ac95fab3/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609304 Benchmark runs are scheduled for baseline = ee24399c52c4fb704cbb2a69d489792505bece53 and contender = efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/a188d8a0-dba7-4b68-a94c-fec45491e8e7...d49a28b3-1cfc-46c0-8168-55fc575ca113/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/1e8a5013-85d8-4c2c-be7f-2b94e2cbb9b0...f669128b-6f9a-4b26-b6d5-e9a54ca1d1b5/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/80392a01-5a25-439f-8d05-36428d06e670...9e9ad27d-3d1b-49b4-a53d-4ab373b0bc8b/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/3f41104f-f4a1-4e63-b63d-ba5a0345077e...d7d64a93-77e0-4c74-b3dc-33ce423ee9c2/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy
github-actions[bot] removed a comment on pull request #9775:
URL: https://github.com/apache/arrow/pull/9775#issuecomment-804407438
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute
patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9777: ARROW-12051: [GLib] Keep input stream reference of GArrowCSVReader
github-actions[bot] commented on pull request #9777: URL: https://github.com/apache/arrow/pull/9777#issuecomment-804613334 https://issues.apache.org/jira/browse/ARROW-12051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kou opened a new pull request #9777: ARROW-12051: [GLib] Keep input stream reference of GArrowCSVReader
kou opened a new pull request #9777: URL: https://github.com/apache/arrow/pull/9777 The given input stream should be alive while a new GArrowCSVReader is alive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804604641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804607422 @github-actions rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-776435517 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804604688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804604641 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/e0d43e09-f4a2-442e-ab85-4f28a32c201b...8cd62957-264c-49a8-a1d1-359f47ed1c52/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/46c491b7-dbb4-456e-badc-cbb72d0c683a...1531bc94-1387-46b8-8230-57eba998ee01/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/ea1ae6cb-374b-4a60-8acd-45753ffa64b1...7a157726-defd-4856-ae5c-d5cf3a854de9/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/f496591a-f84e-4cca-a0fe-dfb1f1ea785a...27dc9851-a5ac-4912-91e0-42575f42c442/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503786 @ursabot please benchmark name=file-write lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804602010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804602010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804598791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804598791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804526484 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/992a2fb0-9285-4a8f-add6-e3a65d715283...11c14ab5-4b64-4517-8bbb-df1dea87d5ef/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c89f88ac-27e3-40b9-ab96-c20da141a2d6...839b5fc3-5083-49a9-94d4-116a8c8ece4f/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/760726b0-84dd-4d64-af69-0c47fd94662a...39e7cc6d-6177-4357-aeb4-be56be7a6c1c/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/883239ac-8bfb-49a1-9706-f2f8d784c072...a4a4b598-027d-4bd8-9d66-c52d790c5c4b/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504976 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/c4978fe1-f03a-4b4a-84ee-67b115690008...bf22eeab-0e11-466a-ac40-8c6907b413f5/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c5461938-8098-44d0-bdf0-f49388e6ca9b...a0a89cbd-0c55-418c-99fd-52955217a321/ [Finished] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/f09a2295-7b0c-478b-bfd4-dd4675404e5e...be05e599-7213-4fd0-8d22-59c66edca30f/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/18b2a40e-761a-498e-b12b-8b0dc00b124c...bdfa6431-39a1-489b-aa87-d19b5303f38c/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/70cbcfca-bb1d-447e-a602-8a1608265ada...3329e494-549e-46d8-8ed5-bfc6f99e5bd4/ [Finished] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/bf3f2159-f847-4e6f-b12e-73d4648ac63b...01da6228-d858-4c66-9ab0-e7f028fe15a7/ [Finished] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/6dc4f116-8b96-4320-87a4-fd99054388ee...5ff126a2-7517-4b3a-b4af-6b1dc50aeeb8/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/b9031294-08ba-43ae-8245-b2ca7b90612e...ea55b6ba-bcdf-488f-a2f6-d58c56a087f3/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504421 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/8211e5fa-f2a2-468d-bc47-3225bdc61ffe...95ae11ec-e5d6-484a-ab0a-8e09972ad65e/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c014592a-b1fe-451e-b935-2ee493abc39f...23b711d3-7d7b-4d3c-9dc0-248b5ec6efdf/ [Finished] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/c0b997f4-f442-46f1-aabf-d02490c7497b...76a59563-8733-4bcd-8650-cb8739e94a24/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/ac654995-45f1-4c4d-92ea-796a50259a71...79d1ee19-7a0a-4f85-ac55-7f3c0452ff69/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504976 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/c4978fe1-f03a-4b4a-84ee-67b115690008...bf22eeab-0e11-466a-ac40-8c6907b413f5/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c5461938-8098-44d0-bdf0-f49388e6ca9b...a0a89cbd-0c55-418c-99fd-52955217a321/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/f09a2295-7b0c-478b-bfd4-dd4675404e5e...be05e599-7213-4fd0-8d22-59c66edca30f/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/18b2a40e-761a-498e-b12b-8b0dc00b124c...bdfa6431-39a1-489b-aa87-d19b5303f38c/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804526484 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/992a2fb0-9285-4a8f-add6-e3a65d715283...11c14ab5-4b64-4517-8bbb-df1dea87d5ef/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c89f88ac-27e3-40b9-ab96-c20da141a2d6...839b5fc3-5083-49a9-94d4-116a8c8ece4f/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/760726b0-84dd-4d64-af69-0c47fd94662a...39e7cc6d-6177-4357-aeb4-be56be7a6c1c/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/883239ac-8bfb-49a1-9706-f2f8d784c072...a4a4b598-027d-4bd8-9d66-c52d790c5c4b/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #8949: ARROW-10880: [Java] Support compressing RecordBatch IPC buffers by LZ4
liyafan82 commented on pull request #8949: URL: https://github.com/apache/arrow/pull/8949#issuecomment-804525790 > @liyafan82 @emkornfield Can you one of you update https://github.com/apache/arrow/blob/master/docs/source/status.rst#ipc-format once this is all finished? @pitrou I will keep this in mind. Thanks for your kind reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #9744: ARROW-12012: [Java][JDBC] Fix BinaryConsumer reallocation
liyafan82 commented on pull request #9744: URL: https://github.com/apache/arrow/pull/9744#issuecomment-804525245 Mostly look good. Thank you @zxf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #9744: ARROW-12012: [Java][JDBC] Fix BinaryConsumer reallocation
liyafan82 commented on pull request #9744: URL: https://github.com/apache/arrow/pull/9744#issuecomment-804525164 Rerunning integration tests. The failure seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504268 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/09d60fb0-8d1a-4baf-9b94-7319ef860a42...da3568bc-cbb8-4d3c-a883-83a25197665a/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/3fef1021-70b2-4e21-81c0-5b4bc1c2d6f4...0fb1c1f2-0dbe-4850-a812-db219814a50b/ [Finished] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/638bd6a7-e996-4574-bc53-dc6d32efb997...968bdd9c-3ca3-4704-b099-51a7f3b42f91/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/ed40d342-89ab-4a29-8b26-a90849cbe31a...e9a41728-4c80-4c68-a974-0b60e9afc419/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504421 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/8211e5fa-f2a2-468d-bc47-3225bdc61ffe...95ae11ec-e5d6-484a-ab0a-8e09972ad65e/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c014592a-b1fe-451e-b935-2ee493abc39f...23b711d3-7d7b-4d3c-9dc0-248b5ec6efdf/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/c0b997f4-f442-46f1-aabf-d02490c7497b...76a59563-8733-4bcd-8650-cb8739e94a24/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/ac654995-45f1-4c4d-92ea-796a50259a71...79d1ee19-7a0a-4f85-ac55-7f3c0452ff69/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504268 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/09d60fb0-8d1a-4baf-9b94-7319ef860a42...da3568bc-cbb8-4d3c-a883-83a25197665a/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/3fef1021-70b2-4e21-81c0-5b4bc1c2d6f4...0fb1c1f2-0dbe-4850-a812-db219814a50b/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/638bd6a7-e996-4574-bc53-dc6d32efb997...968bdd9c-3ca3-4704-b099-51a7f3b42f91/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/ed40d342-89ab-4a29-8b26-a90849cbe31a...e9a41728-4c80-4c68-a974-0b60e9afc419/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504976 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/c4978fe1-f03a-4b4a-84ee-67b115690008...bf22eeab-0e11-466a-ac40-8c6907b413f5/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c5461938-8098-44d0-bdf0-f49388e6ca9b...a0a89cbd-0c55-418c-99fd-52955217a321/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/f09a2295-7b0c-478b-bfd4-dd4675404e5e...be05e599-7213-4fd0-8d22-59c66edca30f/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/18b2a40e-761a-498e-b12b-8b0dc00b124c...bdfa6431-39a1-489b-aa87-d19b5303f38c/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504958 @ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3 --show-output=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504857 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/a2779746-5c34-4cf5-b0f2-75354a809b73...2cd41405-62a8-4e68-8add-4010a672335a/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/ddfff0d9-0db6-4f7a-b8ca-afe0059c5888...ee8b7ee6-c709-49c8-8bd6-2c56ad8b9837/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/6dc4f116-8b96-4320-87a4-fd99054388ee...5ff126a2-7517-4b3a-b4af-6b1dc50aeeb8/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/b9031294-08ba-43ae-8245-b2ca7b90612e...ea55b6ba-bcdf-488f-a2f6-d58c56a087f3/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504836 @ursabot please benchmarkname=file-write lang=Python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504752 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/2ac96973-6986-4cd1-96d5-d6e54489a673...2b576ad1-db5a-4065-9ff5-5dc52bba36ae/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/2a495d40-a81e-462b-9a2c-32ee30dd8204...5c308763-5da0-4f60-993d-dbd8678bf1ce/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/760726b0-84dd-4d64-af69-0c47fd94662a...39e7cc6d-6177-4357-aeb4-be56be7a6c1c/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/883239ac-8bfb-49a1-9706-f2f8d784c072...a4a4b598-027d-4bd8-9d66-c52d790c5c4b/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504729 @ursabot please benchmark name=file-.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504421 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/8211e5fa-f2a2-468d-bc47-3225bdc61ffe...95ae11ec-e5d6-484a-ab0a-8e09972ad65e/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c014592a-b1fe-451e-b935-2ee493abc39f...23b711d3-7d7b-4d3c-9dc0-248b5ec6efdf/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/c0b997f4-f442-46f1-aabf-d02490c7497b...76a59563-8733-4bcd-8650-cb8739e94a24/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/ac654995-45f1-4c4d-92ea-796a50259a71...79d1ee19-7a0a-4f85-ac55-7f3c0452ff69/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504384 @ursabot please benchmark lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504268 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/09d60fb0-8d1a-4baf-9b94-7319ef860a42...da3568bc-cbb8-4d3c-a883-83a25197665a/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/3fef1021-70b2-4e21-81c0-5b4bc1c2d6f4...0fb1c1f2-0dbe-4850-a812-db219814a50b/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/638bd6a7-e996-4574-bc53-dc6d32efb997...968bdd9c-3ca3-4704-b099-51a7f3b42f91/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/ed40d342-89ab-4a29-8b26-a90849cbe31a...e9a41728-4c80-4c68-a974-0b60e9afc419/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804504207 @ursabot please benchmark lang=R -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503963 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/70cbcfca-bb1d-447e-a602-8a1608265ada...3329e494-549e-46d8-8ed5-bfc6f99e5bd4/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/bf3f2159-f847-4e6f-b12e-73d4648ac63b...01da6228-d858-4c66-9ab0-e7f028fe15a7/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/6dc4f116-8b96-4320-87a4-fd99054388ee...5ff126a2-7517-4b3a-b4af-6b1dc50aeeb8/ [Scheduled] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/b9031294-08ba-43ae-8245-b2ca7b90612e...ea55b6ba-bcdf-488f-a2f6-d58c56a087f3/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503941 @ursabot please benchmark lang=Python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503786 @ursabot please benchmark name=file-write lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503791 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language: `@ursabot please benchmark lang=Python` `@ursabot please benchmark lang=C++` `@ursabot please benchmark lang=R` To filter Python and R benchmarks by name: `@ursabot please benchmark name=file-write` `@ursabot please benchmark name=file-write lang=Python` `@ursabot please benchmark name=file-.*` To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: `@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3` For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503706 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language: `@ursabot please benchmark lang=Python` `@ursabot please benchmark lang=C++` `@ursabot please benchmark lang=R` To filter Python and R benchmarks by name: `@ursabot please benchmark name=file-write` `@ursabot please benchmark name=file-write lang=Python` `@ursabot please benchmark name=file-.*` To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: `@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3` For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503698 @ursabot please benchmark lang=Python lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503646 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language: `@ursabot please benchmark lang=Python` `@ursabot please benchmark lang=C++` `@ursabot please benchmark lang=R` To filter Python and R benchmarks by name: `@ursabot please benchmark name=file-write` `@ursabot please benchmark name=file-write lang=Python` `@ursabot please benchmark name=file-.*` To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: `@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3` For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503643 @ursabot please benchmark something=something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503464 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language: `@ursabot please benchmark lang=Python` `@ursabot please benchmark lang=C++` `@ursabot please benchmark lang=R` To filter Python and R benchmarks by name: `@ursabot please benchmark name=file-write` `@ursabot please benchmark name=file-write lang=Python` `@ursabot please benchmark name=file-.*` To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: `@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3` For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503460 @ursabot please benchmark lang=Java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503371 @ursabot hello -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503375 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language: `@ursabot please benchmark lang=Python` `@ursabot please benchmark lang=C++` `@ursabot please benchmark lang=R` To filter Python and R benchmarks by name: `@ursabot please benchmark name=file-write` `@ursabot please benchmark name=file-write lang=Python` `@ursabot please benchmark name=file-.*` To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: `@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3` For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503301 @ursabot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804503305 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language: `@ursabot please benchmark lang=Python` `@ursabot please benchmark lang=C++` `@ursabot please benchmark lang=R` To filter Python and R benchmarks by name: `@ursabot please benchmark name=file-write` `@ursabot please benchmark name=file-write lang=Python` `@ursabot please benchmark name=file-.*` To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: `@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3` For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot removed a comment on pull request #9272: [WIP] Benchmark placebo
ursabot removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-797872526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-797872509 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804498390 Supported benchmark command examples: `@ursabot benchmark help` To run all benchmarks: `@ursabot please benchmark` To filter benchmarks by language: `@ursabot please benchmark lang=Python` `@ursabot please benchmark lang=C++` `@ursabot please benchmark lang=R` To filter Python and R benchmarks by name: `@ursabot please benchmark name=file-write` `@ursabot please benchmark name=file-write lang=Python` `@ursabot please benchmark name=file-.*` To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: `@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3` For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804484031 Supported benchmark command examples: @ursabot benchmark help @ursabot please benchmark To filter benchmarks by language: @ursabot please benchmark lang=Python @ursabot please benchmark lang=C++ @ursabot please benchmark lang=R To filter `Python` and `R` benchmarks by name: @ursabot please benchmark name=file-write @ursabot please benchmark name=file-write lang=Python @ursabot please benchmark name=file-.* To filter `C++` benchmarks by `archery's` `--suite-filter` and `--benchmark-filter`: @ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3 For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804483606 Supported benchmark command examples: @ursabot benchmark help @ursabot please benchmark To filter benchmarks by language: @ursabot please benchmark lang=Python @ursabot please benchmark lang=C++ @ursabot please benchmark lang=R To filter Python and R benchmarks by name: @ursabot please benchmark name=file-write @ursabot please benchmark name=file-write lang=Python @ursabot please benchmark name=file-.* To filter C++ benchmarks by archery --suite-filter and --benchmark-filter: @ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3 For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804464584 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/992a2fb0-9285-4a8f-add6-e3a65d715283...11c14ab5-4b64-4517-8bbb-df1dea87d5ef/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c89f88ac-27e3-40b9-ab96-c20da141a2d6...839b5fc3-5083-49a9-94d4-116a8c8ece4f/ [Finished] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/760726b0-84dd-4d64-af69-0c47fd94662a...39e7cc6d-6177-4357-aeb4-be56be7a6c1c/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/883239ac-8bfb-49a1-9706-f2f8d784c072...a4a4b598-027d-4bd8-9d66-c52d790c5c4b/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #9272: [WIP] Benchmark placebo
ursabot edited a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804464584 Benchmark runs are scheduled for baseline = 356c300c5ee1e2b23a83652514af11e3a731d596 and contender = 0f7cd4b8cb71cd5a7135404b2abc6e77de3aea7f. Results will be available as each benchmark for each run completes: [Scheduled] ursa-dgx1: https://conbench.ursa.dev/compare/runs/992a2fb0-9285-4a8f-add6-e3a65d715283...11c14ab5-4b64-4517-8bbb-df1dea87d5ef/ [Scheduled] ursa-i9-9960x: https://conbench.ursa.dev/compare/runs/c89f88ac-27e3-40b9-ab96-c20da141a2d6...839b5fc3-5083-49a9-94d4-116a8c8ece4f/ [Scheduled] ec2-t3-large-us-east-2: https://conbench.ursa.dev/compare/runs/760726b0-84dd-4d64-af69-0c47fd94662a...39e7cc6d-6177-4357-aeb4-be56be7a6c1c/ [Finished] ec2-t3-xlarge-us-east-2: https://conbench.ursa.dev/compare/runs/883239ac-8bfb-49a1-9706-f2f8d784c072...a4a4b598-027d-4bd8-9d66-c52d790c5c4b/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-804464283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9705: ARROW-11365: [Rust] [Parquet] Logical type printer and parser
nevi-me commented on a change in pull request #9705:
URL: https://github.com/apache/arrow/pull/9705#discussion_r599118931
##
File path: rust/parquet/src/arrow/schema.rs
##
@@ -959,11 +962,14 @@ mod tests {
Field::new("boolean", DataType::Boolean, false),
Field::new("int8", DataType::Int8, false),
Field::new("int16", DataType::Int16, false),
+Field::new("uint8", DataType::UInt8, false),
+Field::new("uint16", DataType::UInt16, false),
Field::new("int32", DataType::Int32, false),
Field::new("int64", DataType::Int64, false),
Field::new("double", DataType::Float64, true),
Field::new("float", DataType::Float32, true),
Field::new("string", DataType::Utf8, true),
+Field::new("string_2", DataType::Utf8, true),
Review comment:
This is where things get interesting. UTF8 maps to the converted type,
and STRING to the logical type. So, the pecking order is to check for logical
type, then fall back to converted type.
It gets tricky when the logical and converted types are the same string
value, but that is fine as the converted type is always written out. Q good
example is DECIMAL(12,2), it is the same in either logical or converted type.
I was confused with this, as I initially tried parsing logical and converted
types separately, without mixing them in one file. After @sunchao's review on
the other PRs, it started to make sense that they can coexist.
So, both map to the same Arrow type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9045: ARROW-11180: [Developer] cmake-format pre-commit hook doesn't run
kou commented on pull request #9045: URL: https://github.com/apache/arrow/pull/9045#issuecomment-804431484 @MarcoGorelli I found some problems: * `python run-cmake-format.py` (no `paths` arguments) doesn't work because `PATTERNS` data aren't suitable for `glob()`. * We also need exclude `cpp/src/arrow/util/config.h.cmake` because it's not a CMake file. (It may be better that we rename the `.cmake` extension of the file.) I've fixed them and rebased on the current master. Could you check this? If it's OK to you, I'll merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9776: ARROW-12048: [Rust][DataFusion] Support Common Table Expressions
github-actions[bot] commented on pull request #9776: URL: https://github.com/apache/arrow/pull/9776#issuecomment-804416180 https://issues.apache.org/jira/browse/ARROW-12048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kou closed pull request #9746: ARROW-12013: [C++][FlightRPC] Fix bundled gRPC version probing
kou closed pull request #9746: URL: https://github.com/apache/arrow/pull/9746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #9746: ARROW-12013: [C++][FlightRPC] Fix bundled gRPC version probing
kou commented on a change in pull request #9746:
URL: https://github.com/apache/arrow/pull/9746#discussion_r599091271
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -2371,30 +2371,30 @@ macro(build_grpc)
set(ABSL_LIBRARIES)
# Abseil libraries gRPC depends on
+ # Follows grpc++ package config template for link order of libraries
+ # https://github.com/grpc/grpc/blob/v1.35.0/CMakeLists.txt#L16361
set(_ABSL_LIBS
Review comment:
It's specific to the version of gRPC not Abseil.
gRPC may change using Abseil libraries.
I agree with your worry. I hope that we can improve this later.
##
File path: cpp/src/arrow/flight/CMakeLists.txt
##
@@ -102,19 +102,24 @@ function(test_grpc_version DST_VAR DETECT_VERSION
TEST_FILE)
endif()
endfunction()
-test_grpc_version(GRPC_VERSION "1.36" "check_tls_opts_136.cc")
-test_grpc_version(GRPC_VERSION "1.34" "check_tls_opts_134.cc")
-test_grpc_version(GRPC_VERSION "1.32" "check_tls_opts_132.cc")
-test_grpc_version(GRPC_VERSION "1.27" "check_tls_opts_127.cc")
-message(
- STATUS
-"Found approximate gRPC version: ${GRPC_VERSION}
(ARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS=${ARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS})"
- )
+if(GRPC_VENDORED)
+ # v1.35.0 -> 1.35
+ string(REGEX MATCH "[0-9]+\\.[0-9]+" GRPC_VERSION
"${ARROW_GRPC_BUILD_VERSION}")
+else()
+ test_grpc_version(GRPC_VERSION "1.36" "check_tls_opts_136.cc")
+ test_grpc_version(GRPC_VERSION "1.34" "check_tls_opts_134.cc")
+ test_grpc_version(GRPC_VERSION "1.32" "check_tls_opts_132.cc")
+ test_grpc_version(GRPC_VERSION "1.27" "check_tls_opts_127.cc")
+ message(
+STATUS
+ "Found approximate gRPC version: ${GRPC_VERSION}
(ARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS=${ARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS})"
+)
+endif()
if(GRPC_VERSION EQUAL "1.27")
add_definitions(-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc_impl::experimental)
elseif(GRPC_VERSION EQUAL "1.32")
add_definitions(-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc::experimental)
-elseif(GRPC_VERSION EQUAL "1.34")
+elseif(GRPC_VERSION EQUAL "1.34" OR GRPC_VERSION EQUAL "1.35")
Review comment:
OK. We can add `-DARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS=ON` to one
or more CI jobs that use bundled gRPC later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy
github-actions[bot] commented on pull request #9775: URL: https://github.com/apache/arrow/pull/9775#issuecomment-804411748 https://issues.apache.org/jira/browse/ARROW-12047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9770: ARROW-12019: [Rust] [Parquet] Update README for 2.6.0 support
alamb commented on a change in pull request #9770: URL: https://github.com/apache/arrow/pull/9770#discussion_r599087360 ## File path: rust/parquet/README.md ## @@ -50,14 +50,18 @@ See [crate documentation](https://docs.rs/crate/parquet/4.0.0-SNAPSHOT) on avail If you are upgrading from version 3.0 or previous of this crate, you likely need to change your code to use [`ConvertedType`] rather than -[`LogicalType`]. Version 4.0 introduces an *entirely new* struct -called `LogicalType` to align with the `LogicalType` introduced in -Parquet Format 2.4.0. The type previously called `LogicalType` was was -renamed to `ConvertedType`. +[`LogicalType`] to preserve existing behaviour in your code. +Version 2.4.0 of the Parquet format introduced a `LogicalType` to replace the existing `ConvertedType`. +This crate used `parquet::basic::LogicalType` to map to the `ConvertedType`, but this has been renamed to `parquet::basic::ConvertedType` from version 4.0 of this crate. + +The `ConvertedType` is deprecated in the format, but is still written +to preserve backward compatibility. +It is preferred that `LogicalType` is used, as it suports nanosecond +precision timestamps without using the deprecated `Int96` Parquet type. ## Supported Parquet Version -- Parquet-format 2.4.0 +- Parquet-format 2.6.0 Review comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9775: ARROW-12047: [Rust] [Parquet] Cleanup clippy
github-actions[bot] commented on pull request #9775:
URL: https://github.com/apache/arrow/pull/9775#issuecomment-804407438
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute
patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing
alamb commented on a change in pull request #9762:
URL: https://github.com/apache/arrow/pull/9762#discussion_r599086894
##
File path: rust/datafusion/src/catalog/catalog.rs
##
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Describes the interface and built-in implementations of catalogs,
+//! representing collections of named schemas.
+
+use crate::catalog::schema::SchemaProvider;
+use std::any::Any;
+use std::collections::HashMap;
+use std::sync::{Arc, RwLock};
+
+/// Represents a catalog, comprising a number of named schemas.
+pub trait CatalogProvider: Sync + Send {
+/// Returns the catalog provider as [`Any`](std::any::Any)
+/// so that it can be downcast to a specific implementation.
+fn as_any() -> Any;
+
+/// Retrieves the list of available schema names in this catalog.
+fn schema_names() -> Vec;
Review comment:
Vec<> might be possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9329: ARROW-11511: [Rust] Replace `Arc` by `ArrayData` in all arrays
alamb commented on pull request #9329: URL: https://github.com/apache/arrow/pull/9329#issuecomment-804405923 Thanks @nevi-me for pushing the over the line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays
alamb commented on a change in pull request #9771:
URL: https://github.com/apache/arrow/pull/9771#discussion_r599084717
##
File path: rust/parquet/src/arrow/arrow_writer.rs
##
@@ -189,11 +199,12 @@ fn write_leaves(
ArrowDataType::Float16 => Err(ParquetError::ArrowError(
"Float16 arrays not supported".to_string(),
)),
-ArrowDataType::FixedSizeList(_, _)
-| ArrowDataType::FixedSizeBinary(_)
-| ArrowDataType::Union(_) => Err(ParquetError::NYI(
-"Attempting to write an Arrow type that is not yet
implemented".to_string(),
-)),
+ArrowDataType::FixedSizeList(_, _) | ArrowDataType::Union(_) => {
+Err(ParquetError::NYI(
+"Attempting to write an Arrow type that is not yet implemented"
+.to_string(),
Review comment:
```suggestion
format!("Attempting to write an Arrow type {?} to parquet
that is not yet implemented", array.data_type())
```
( I realize the error message is not changed by this PR I just saw it when
looking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] Dandandan edited a comment on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels
Dandandan edited a comment on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804390782 Haha @ch-sc @javierluraschi I tried it on this website which I used before for some simple checks https://rextester.com/l/postgresql_online_compiler but it shows `null` on every input now 藍 So forget what I said, it is very useful to do this both for Arrow & DataFusion :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels
Dandandan commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804390782 Haha @ch-sc @javierluraschi I tried it on this website which I used before https://rextester.com/l/postgresql_online_compiler but it shows `null` on every input now 藍 So forget what I said, it is very useful to do this both for Arrow & DataFusion :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] jpedroantunes commented on pull request #9726: ARROW-11987: [C++][Gandiva] Implement trigonometric functions
jpedroantunes commented on pull request #9726: URL: https://github.com/apache/arrow/pull/9726#issuecomment-804389337 @emkornfield any idea about this AMD64 Conda build problem (do not seems related to my pull request)? https://github.com/apache/arrow/pull/9726/checks?check_run_id=2166216447 It seems to be inconsistent, sometimes it fails, other times it passes. Just this is missing so this can be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] returnString commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing
returnString commented on a change in pull request #9762:
URL: https://github.com/apache/arrow/pull/9762#discussion_r599063974
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -512,6 +573,12 @@ pub struct ExecutionConfig {
optimizers: Vec>,
/// Responsible for planning `LogicalPlan`s, and `ExecutionPlan`
query_planner: Arc,
+/// Default catalog name for table resolution
+default_catalog: String,
Review comment:
This is a very good question!
I think we could allow for that distinction, but it gets a little bit messy
as we'd probably want to enforce that you can't have a default schema without a
default catalog, so it'd look something like `Option<(String, Option)>`
(in fact, I had something like that for a bit before I settled on just using
`datafusion.public` as the default setting for back-compat).
I'm struggling to think of a use case though 樂 Maybe if someone were
developing a system where they wanted to _force_ users to fully qualify their
table names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] Dandandan opened a new pull request #9776: ARROW-12048: [Rust][DataFusion] Support Common Table Expressions
Dandandan opened a new pull request #9776: URL: https://github.com/apache/arrow/pull/9776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels
github-actions[bot] commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804378434 https://issues.apache.org/jira/browse/ARROW-11973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9671: ARROW-12045: [Go][Parquet] Initial Chunk of Parquet port to Go
github-actions[bot] commented on pull request #9671: URL: https://github.com/apache/arrow/pull/9671#issuecomment-804378353 https://issues.apache.org/jira/browse/ARROW-12045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays
nevi-me commented on a change in pull request #9771:
URL: https://github.com/apache/arrow/pull/9771#discussion_r599053605
##
File path: rust/parquet/src/arrow/arrow_writer.rs
##
@@ -156,6 +156,16 @@ fn write_leaves(
row_group_writer.close_column(col_writer)?;
Ok(())
}
+ArrowDataType::FixedSizeBinary(_) => {
+let mut col_writer = get_col_writer( row_group_writer)?;
+write_leaf(
+ col_writer,
+array,
+levels.pop().expect("Levels exhausted"),
+)?;
+row_group_writer.close_column(col_writer)?;
+Ok(())
+}
Review comment:
lol, there isn't. Someone (won't name them) copied this chunk
separately, thinking that it'll be different. Then they forgot to merge it when
they realised that there was no difference.
I'll fix it shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels
jorgecarleitao commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804370136 I tried on mysql, postgres and big query and was happy with the table you provided on JIRA. I am also curious how I got a different result than @Dandandan xD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] returnString commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing
returnString commented on a change in pull request #9762:
URL: https://github.com/apache/arrow/pull/9762#discussion_r599049329
##
File path: rust/datafusion/src/catalog/schema.rs
##
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Describes the interface and built-in implementations of schemas,
+//! representing collections of named tables.
+
+use crate::datasource::TableProvider;
+use crate::error::{DataFusionError, Result};
+use std::any::Any;
+use std::collections::HashMap;
+use std::sync::{Arc, RwLock};
+
+/// Represents a schema, comprising a number of named tables.
+pub trait SchemaProvider: Sync + Send {
+/// Returns the schema provider as [`Any`](std::any::Any)
+/// so that it can be downcast to a specific implementation.
+fn as_any() -> Any;
+
+/// Retrieves the list of available table names in this schema.
+fn table_names() -> Vec;
+
+/// Retrieves a specific table from the schema by name, provided it exists.
+fn table(, name: ) -> Option>;
+
+/// If supported by the implementation, adds a new table to this schema.
+/// If a table of the same name existed before, it is replaced in the
schema and returned.
+#[allow(unused_variables)]
+fn register_table(
+,
+name: String,
+table: Arc,
Review comment:
The underscore method was my first approach here but I then discovered
that it carried those symbols through to the docs as well (e.g. inline
parameter names in vscode using rust analyser - presumably also the generated
ones in docs.rs too? didn't test that bit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] ch-sc commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels
ch-sc commented on pull request #9772: URL: https://github.com/apache/arrow/pull/9772#issuecomment-804367750 Hi @Dandandan, I actaully checked on Postgres (11) beforehand and it did return exactly the values I provided in the table. ``` SELECT TRUE AND NULL; --> NULL SELECT FALSE AND NULL; --> FALSE SELECT TRUE OR NULL; --> TRUE SELECT FALSE OR NULL; --> NULL ``` Which Postgres version are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] returnString commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing
returnString commented on a change in pull request #9762:
URL: https://github.com/apache/arrow/pull/9762#discussion_r599044375
##
File path: rust/datafusion/src/catalog/catalog.rs
##
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Describes the interface and built-in implementations of catalogs,
+//! representing collections of named schemas.
+
+use crate::catalog::schema::SchemaProvider;
+use std::any::Any;
+use std::collections::HashMap;
+use std::sync::{Arc, RwLock};
+
+/// Represents a catalog, comprising a number of named schemas.
+pub trait CatalogProvider: Sync + Send {
+/// Returns the catalog provider as [`Any`](std::any::Any)
+/// so that it can be downcast to a specific implementation.
+fn as_any() -> Any;
+
+/// Retrieves the list of available schema names in this catalog.
+fn schema_names() -> Vec;
Review comment:
I iniitally tried to implement these returning `&[]` but with the
threading requirements I struggled to get anything working that way. I _think_
this would require a larger refactoring to enable, but I'm not 100% sure on
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays
github-actions[bot] commented on pull request #9771: URL: https://github.com/apache/arrow/pull/9771#issuecomment-804363911 https://issues.apache.org/jira/browse/ARROW-12043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9762: ARROW-12037: [Rust] [DataFusion] Support catalogs and schemas for table namespacing
alamb commented on a change in pull request #9762:
URL: https://github.com/apache/arrow/pull/9762#discussion_r599027565
##
File path: rust/datafusion/src/catalog/catalog.rs
##
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Describes the interface and built-in implementations of catalogs,
+//! representing collections of named schemas.
+
+use crate::catalog::schema::SchemaProvider;
+use std::any::Any;
+use std::collections::HashMap;
+use std::sync::{Arc, RwLock};
+
+/// Represents a catalog, comprising a number of named schemas.
+pub trait CatalogProvider: Sync + Send {
+/// Returns the catalog provider as [`Any`](std::any::Any)
+/// so that it can be downcast to a specific implementation.
+fn as_any() -> Any;
+
+/// Retrieves the list of available schema names in this catalog.
+fn schema_names() -> Vec;
Review comment:
What do you think about returning something more like `Vec<>` to
prevent requiring a copy?
Ideally it would be nice if we could do something like
```
fn schema_names() -> impl Iterator
```
As all uses of the results here will need to iterate over the names I suspect
##
File path: rust/datafusion/src/catalog/catalog.rs
##
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Describes the interface and built-in implementations of catalogs,
+//! representing collections of named schemas.
+
+use crate::catalog::schema::SchemaProvider;
+use std::any::Any;
+use std::collections::HashMap;
+use std::sync::{Arc, RwLock};
+
+/// Represents a catalog, comprising a number of named schemas.
+pub trait CatalogProvider: Sync + Send {
+/// Returns the catalog provider as [`Any`](std::any::Any)
+/// so that it can be downcast to a specific implementation.
+fn as_any() -> Any;
+
+/// Retrieves the list of available schema names in this catalog.
+fn schema_names() -> Vec;
+
+/// Retrieves a specific schema from the catalog by name, provided it
exists.
+fn schema(, name: ) -> Option>;
+}
+
+/// Simple in-memory implementation of a catalog.
+pub struct MemoryCatalogProvider {
Review comment:
In some other PR perhaps we can put the concrete implementations into
their own modules. I don't think this one is big enough to warrant that yet,
however; I just wanted to point it out
##
File path: rust/datafusion/src/catalog/schema.rs
##
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Describes the interface and built-in implementations of schemas,
+//! representing collections of named tables.
+
+use crate::datasource::TableProvider;
+use
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays
jorgecarleitao commented on a change in pull request #9771:
URL: https://github.com/apache/arrow/pull/9771#discussion_r599033492
##
File path: rust/parquet/src/arrow/arrow_writer.rs
##
@@ -156,6 +156,16 @@ fn write_leaves(
row_group_writer.close_column(col_writer)?;
Ok(())
}
+ArrowDataType::FixedSizeBinary(_) => {
+let mut col_writer = get_col_writer( row_group_writer)?;
+write_leaf(
+ col_writer,
+array,
+levels.pop().expect("Levels exhausted"),
+)?;
+row_group_writer.close_column(col_writer)?;
+Ok(())
+}
Review comment:
I can't spot the difference between this and all cases above. Is there
any?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
