[GitHub] [arrow] tianchen92 commented on pull request #6433: ARROW-7495: [Java] Remove "empty" concept from ArrowBuf, replace with custom referencemanager
tianchen92 commented on pull request #6433: URL: https://github.com/apache/arrow/pull/6433#issuecomment-633778149 > @tianchen92 can you rebase this once? I will merge then. Thanks, rebased:) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] tianchen92 commented on pull request #6433: ARROW-7495: [Java] Remove "empty" concept from ArrowBuf, replace with custom referencemanager
tianchen92 commented on pull request #6433: URL: https://github.com/apache/arrow/pull/6433#issuecomment-631284400 > include a test which ensures that the Netty Allocator returns an empty-behaving byte buffer when users allocate a zero byte buffer Thanks jacques, I created https://issues.apache.org/jira/browse/ARROW-8870 to track. @emkornfield Please help merge this PR when you have time, thanks a lot! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] tianchen92 commented on pull request #6433: ARROW-7495: [Java] Remove "empty" concept from ArrowBuf, replace with custom referencemanager
tianchen92 commented on pull request #6433: URL: https://github.com/apache/arrow/pull/6433#issuecomment-630540722 > > Good suggestion, seems empty ArrowBuf was used in vectors before populating data. I have added a set of tests in TestValueVector. > > The tests you added are all vector based. I'd like to tests against the "empty" ArrowBuf as well. I see, I added more cases in TestArrowBuf This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] tianchen92 commented on pull request #6433: ARROW-7495: [Java] Remove "empty" concept from ArrowBuf, replace with custom referencemanager
tianchen92 commented on pull request #6433: URL: https://github.com/apache/arrow/pull/6433#issuecomment-625704614 > I think it would be good to have a set of tests ensuring that the behavior of the empty buffer is consistent. For example, refcnt, release/allocate, etc. That way, if someone changes the noop reference manager which this is depending on in the future, we don't break the expected behavior of an EmptyBuf as used by all the vector classes. Other than that, this looks good. Good suggestion, seems empty ArrowBuf was used in vectors before populating data. I have added a set of tests in TestValueVector. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] tianchen92 commented on pull request #6433: ARROW-7495: [Java] Remove "empty" concept from ArrowBuf, replace with custom referencemanager
tianchen92 commented on pull request #6433: URL: https://github.com/apache/arrow/pull/6433#issuecomment-624480936 > @tianchen92 , can you please revise thia? Looks like the work is completed ok, revised, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
