[Github-comments] [geany/geany-plugins] Thanks for Vimode (#979)

2020-05-15 Thread mvim
Long time user of Geany and a Vim user for dev. I use Geany to organize my 
notes and now I can use some familiar vim features.

Made my day finding this! **Thanks!**

_[Please close - just leaving a message]_


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/979

Re: [Github-comments] [geany/geany-plugins] Thanks for Vimode (#979)

2020-05-15 Thread mvim
Closed #979.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/979#event-3343236588

Re: [Github-comments] [geany/geany] Use Scintilla's JSON lexer for JSON instead of the JavaScript/C++ lexer (#2454)

2020-05-15 Thread Ellie
@eht16 just google "JSON for comments", apart from posts telling you it's not 
allowed you'll find quite a bunch of different parsers to enable this. And 
Visual Studio Code (which is pretty popular) uses this style for all its 
configs, too. I don't have proper statistics, but I think it should be easy 
enough to see that a non-trivial amount of people uses this

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2454#issuecomment-629573293

Re: [Github-comments] [geany/geany] Use Scintilla's JSON lexer for JSON instead of the JavaScript/C++ lexer (#2454)

2020-05-15 Thread Enrico Tröger
@ell1e what is "common"? This is hard to define in a general way and the JSON 
standard does *not* allow comments.

@d5l6 I wonder if it wouldn't be better to keep the custom filetype and just 
add the Scintilla JSON lexer to Geany and update the custom filetype definition 
to use it.
Otherwise we need also a migration path for existing users or they will end up 
with two JSON filetypes. Not sure which one would be used then.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2454#issuecomment-629520411

Re: [Github-comments] [geany/geany-themes] Fix typos and use https for Geany URL (#38)

2020-05-15 Thread Frank Lanitz
Merged #38 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/38#event-3342700602

[Github-comments] [geany/geany-themes] Fix typos and use https for Geany URL (#38)

2020-05-15 Thread Enrico Tröger

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-themes/pull/38

-- Commit Summary --

  * Fix typos and use https for Geany URL

-- File Changes --

M README.md (6)

-- Patch Links --

https://github.com/geany/geany-themes/pull/38.patch
https://github.com/geany/geany-themes/pull/38.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/38


Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)

2020-05-15 Thread Enrico Tröger
Sounds good to me to use mainly `G_OS_INFO_KEY_PRETTY_NAME`. I still would add 
`G_OS_INFO_KEY_VERSION_CODENAME` (in braces or so). E.g. for Ubuntu, this gives 
the version like `20.04 LTS` *and* the codename `focal` which might be handy 
and saves some tedious version vs. codename lookups.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2498#issuecomment-629480146

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-15 Thread Enrico Tröger
Sorry, my last comment is wrong. The underscore fix in Scintilla is *not* in 
the 3.20.0 release.
Since I noticed it only after updating our Scintilla copy, we got #2506 anyway 
:).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-629478153

[Github-comments] [geany/geany] Update Scintilla to version 3.20.0 (#2506)

2020-05-15 Thread Enrico Tröger

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2506

-- Commit Summary --

  * Update Scintilla to version 3.20.0

-- File Changes --

M scintilla/Makefile.am (1)
M scintilla/gtk/Converter.h (5)
M scintilla/gtk/PlatGTK.cxx (111)
M scintilla/gtk/ScintillaGTK.cxx (140)
M scintilla/gtk/ScintillaGTK.h (11)
M scintilla/gtk/ScintillaGTKAccessible.cxx (9)
M scintilla/gtk/ScintillaGTKAccessible.h (2)
A scintilla/include/Compat.h (70)
M scintilla/include/ILexer.h (9)
M scintilla/include/Makefile.am (1)
M scintilla/include/Platform.h (14)
M scintilla/include/SciLexer.h (72)
M scintilla/include/Scintilla.h (55)
M scintilla/include/Scintilla.iface (862)
M scintilla/lexers/LexAbaqus.cxx (2)
M scintilla/lexers/LexAsm.cxx (21)
M scintilla/lexers/LexBash.cxx (7)
M scintilla/lexers/LexBasic.cxx (15)
M scintilla/lexers/LexBatch.cxx (835)
M scintilla/lexers/LexCPP.cxx (79)
M scintilla/lexers/LexCmake.cxx (5)
M scintilla/lexers/LexD.cxx (6)
M scintilla/lexers/LexHTML.cxx (62)
M scintilla/lexers/LexHaskell.cxx (9)
M scintilla/lexers/LexLaTeX.cxx (16)
M scintilla/lexers/LexMatlab.cxx (2)
M scintilla/lexers/LexPerl.cxx (41)
M scintilla/lexers/LexProps.cxx (18)
M scintilla/lexers/LexPython.cxx (94)
M scintilla/lexers/LexR.cxx (2)
M scintilla/lexers/LexRuby.cxx (6)
M scintilla/lexers/LexRust.cxx (7)
M scintilla/lexers/LexSQL.cxx (17)
M scintilla/lexers/LexTCL.cxx (5)
M scintilla/lexers/LexVerilog.cxx (6)
A scintilla/lexlib/CatalogueModules.h (70)
M scintilla/lexlib/CharacterCategory.cxx (163)
M scintilla/lexlib/CharacterCategory.h (2)
M scintilla/lexlib/CharacterSet.h (4)
M scintilla/lexlib/DefaultLexer.cxx (20)
M scintilla/lexlib/DefaultLexer.h (10)
M scintilla/lexlib/LexerBase.cxx (21)
M scintilla/lexlib/LexerBase.h (6)
M scintilla/lexlib/LexerModule.h (8)
M scintilla/lexlib/LexerSimple.cxx (8)
M scintilla/lexlib/LexerSimple.h (3)
M scintilla/lexlib/OptionSet.h (15)
M scintilla/lexlib/PropSetSimple.cxx (4)
M scintilla/lexlib/PropSetSimple.h (2)
M scintilla/lexlib/StyleContext.h (4)
M scintilla/lexlib/SubStyles.h (12)
M scintilla/lexlib/WordList.cxx (38)
M scintilla/lexlib/WordList.h (2)
M scintilla/scintilla_changes.patch (6)
M scintilla/src/AutoComplete.h (4)
M scintilla/src/CallTip.cxx (242)
M scintilla/src/CallTip.h (35)
M scintilla/src/CaseConvert.cxx (19)
M scintilla/src/CaseConvert.h (2)
M scintilla/src/CaseFolder.cxx (4)
M scintilla/src/CaseFolder.h (4)
M scintilla/src/Catalogue.cxx (38)
M scintilla/src/CellBuffer.cxx (99)
M scintilla/src/CellBuffer.h (52)
M scintilla/src/CharClassify.cxx (2)
M scintilla/src/CharClassify.h (4)
M scintilla/src/ContractionState.cxx (30)
M scintilla/src/Decoration.cxx (14)
M scintilla/src/Document.cxx (211)
M scintilla/src/Document.h (96)
M scintilla/src/EditModel.cxx (3)
M scintilla/src/EditModel.h (3)
M scintilla/src/EditView.cxx (119)
M scintilla/src/EditView.h (2)
M scintilla/src/Editor.cxx (347)
M scintilla/src/Editor.h (55)
M scintilla/src/ExternalLexer.cxx (106)
M scintilla/src/ExternalLexer.h (58)
M scintilla/src/Indicator.cxx (11)
M scintilla/src/Indicator.h (8)
M scintilla/src/KeyMap.cxx (4)
M scintilla/src/KeyMap.h (6)
M scintilla/src/LineMarker.cxx (624)
M scintilla/src/LineMarker.h (2)
M scintilla/src/MarginView.cxx (2)
M scintilla/src/Partitioning.h (38)
M scintilla/src/PerLine.cxx (135)
M scintilla/src/PerLine.h (31)
M scintilla/src/Position.h (5)
M scintilla/src/PositionCache.cxx (23)
M scintilla/src/PositionCache.h (2)
M scintilla/src/RESearch.cxx (26)
M scintilla/src/RESearch.h (26)
M scintilla/src/RunStyles.cxx (8)
M scintilla/src/ScintillaBase.cxx (47)
M scintilla/src/ScintillaBase.h (5)
M scintilla/src/Selection.cxx (76)
M scintilla/src/Selection.h (101)
M scintilla/src/SparseVector.h (103)
M scintilla/src/SplitVector.h (8)
M scintilla/src/Style.cxx (10)
M scintilla/src/Style.h (11)
M scintilla/src/UniConversion.h (8)
M scintilla/src/UniqueString.cxx (6)
M scintilla/src/UniqueString.h (4)
M scintilla/src/ViewStyle.cxx (29)
M scintilla/src/ViewStyle.h (2)
M scintilla/src/XPM.cxx (37)
M scintilla/src/XPM.h (28)
M scintilla/version.txt (2)

-- Patch Links --

https://github.com/geany/geany/pull/2506.patch
https://github.com/geany/geany/pull/2506.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506


Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)

2020-05-15 Thread Matthew Brush
> The result of g_get_os_info must be freed even it is not explicitly stated in 
> the docs 

I assumed based on the lack of `[transfer full]` or whatever annotation that it 
wasn't required, since basically every binding will have a leak otherwise, but 
you are correct and it's just a bug that the annotation is missing and all 
automatically generated bindings will leak.

> Output on ArchLinux:
> Output on Windows 7:

Thanks for testing! Based on the output on Ubuntu, Arch and Windows so far, I 
suggest we go with only printing the "pretty name", like just this one printf:

```c
geany_debug("OS: %s", get_os_info_field(G_OS_INFO_KEY_PRETTY_NAME));
```

Sound good?

@techee would it be possible that you could test this on Macos? I'm not sure 
how involved that would be, if it's too much trouble, no worries.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2498#issuecomment-629428177

Re: [Github-comments] [geany/geany] Date format no longer respected in Ubuntu 20 (#2505)

2020-05-15 Thread Dan Dascalescu
Closed #2505.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2505#event-3340060001

Re: [Github-comments] [geany/geany] Date format no longer respected in Ubuntu 20 (#2505)

2020-05-15 Thread Dan Dascalescu
Thanks @elextr, I've set the format via Edit -> Insert date -> Set custom date 
format.

A bit confused about what "Templates" meant in that dialog, and who uses 
software manuals noawadays for text editors? :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2505#issuecomment-629125568

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-15 Thread Enrico Tröger
> Anyway the thing is to wait for the Scintilla change to ripple through 
> Scintilla LTS branch and into Geany and see if its better (and if other fonts 
> are worse :(

This already happened, the change is in the Scintilla 3.20.0 release and it 
works on my system, i.e. I do see underscores again.

So, we just need to update Scintilla and get this resolved (at least for some 
or ideally most users).
I'll give it a shot.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-629109110

Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)

2020-05-15 Thread Enrico Tröger
Yay!
I agree also that the pretty name is redundant.

The result of `g_get_os_info` must be freed even it is not explicitly stated in 
the docs 
(https://gitlab.gnome.org/GNOME/glib/-/blob/master/glib/gutils.c#L1507).

Output on ArchLinux:
```
10:08:55: Geany INFO: OS Information:
10:08:55: Geany INFO:   Name   : Arch Linux (arch/)
10:08:55: Geany INFO:   Pretty Name: Arch Linux
10:08:55: Geany INFO:   Version:  ()
```

Output on Windows 7:
```
22:50:54: Geany INFO: OS Information:
22:50:54: Geany INFO:   Name   : Windows (windows/)
22:50:54: Geany INFO:   Pretty Name: Windows 7 SP17Vista SP2Vista 
SP1VistaXP SP3XP SP2XP SP1XP
22:50:54: Geany INFO:   Version: 7 SP17Vista SP2Vista 
SP1VistaXP SP3XP SP2XP SP1XP (7_sp17vista_sp2vista_sp1vistaxp_sp3xp_sp2xp_sp1xp)
```

The missing version on ArchLinux is OK because it's a rolling release and 
`/etc/os-release` doesn't have any VERSION key at all.
I'm not sure about the weird looking version on Windows, either it is just my 
installation or it usually looks like this ... :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2498#issuecomment-629099805