Re: [Github-comments] [geany/geany] Slow startup (#2649)
> opening session files takes from 100ms to 300ms per file. IIRC he had similar > times on Linux und MacOS. Local files on a normal disk or what? What filetypes? One file, many files? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2649#issuecomment-723680831
Re: [Github-comments] [geany/geany] Slow startup (#2649)
@frlan reported also slowiness on startup. His debug message log indicated the startup itself is as fast as expected but opening session files takes from 100ms to 300ms per file. IIRC he had similar times on Linux und MacOS. Besides that, I agree with @elextr: this either needs some detailed measurements or a good hint what could have changed or since when. Additionally, on Windows, Geany is always and probably since ever rather slow. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2649#issuecomment-723678354
Re: [Github-comments] [geany/geany] Slow startup (#2649)
Information from the OPs of those comments/mails about how slow (numbers, "seems" isn't a measure) and how to reproduce might be useful. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2649#issuecomment-723675642
[Github-comments] [geany/geany] Slow startup (#2649)
Seems to not be an issue on Linux. References: https://github.com/geany/geany/issues/2639#issuecomment-723489800 https://github.com/geany/geany/issues/2639#issuecomment-723494612 https://github.com/geany/geany-osx/issues/20 https://www.mail-archive.com/users@lists.geany.org/msg02989.html -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2649
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
Merged #1024 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#event-3971178480
Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)
@ndroock1, @Rasbats and all who still had problems: we've just releases Geany 1.37 (https://github.com/geany/geany/releases/tag/1.37.1) with a fix for the startup crash. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2639#issuecomment-723644071
Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)
Closed #2639 via 847a758c054dd1006e53fe2cfbf4c6c5a720d9a6. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2639#event-3971015836
[Github-comments] [geany/geany] Release 1.37.1 - Geany 1.37.1
## Windows * Fix crash on first startup ([Issue#2639](https://github.com/geany/geany/issues/2639), [PR#2645](https://github.com/geany/geany/pull/2645)). -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/releases/tag/1.37.1
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@b4n approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#pullrequestreview-525827142
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@frlan pushed 1 commit. 2a8969f0f69ba5dba96298a314004d3adfff6300 PrettyPrinter: Fix declaration of input_buffer -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/1024/files/31285dc8b337198bcf36629df1e52f1d1eb7ad23..2a8969f0f69ba5dba96298a314004d3adfff6300
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@b4n True. Will update it -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#issuecomment-723589309
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@b4n requested changes on this pull request. The problem is not freeing `input_buffer` which *should* be freed, but that the `input_buffer` variable shouldn't be `const` (since 3fad1285599766a7932667688871c04610bd8651). The change you propose would lead to leaking quite a lot of memory. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#pullrequestreview-525815271
[Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1024 -- Commit Summary -- * PrettyPrinter: Don't try to free const gchar* input_buffer -- File Changes -- M pretty-printer/src/PluginEntry.c (4) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1024.patch https://github.com/geany/geany-plugins/pull/1024.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024
Re: [Github-comments] [geany/geany-plugins] Problem with "Lua Script" after upgrade (GTK 3) (#690)
I'm on Debian Buster :) I'm not totally sure which dialog you're showing, but for me e.g. the dialog examples and a couple other that display this kind of dialogs all come without an image at all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/690#issuecomment-723577371
Re: [Github-comments] [geany/geany-plugins] Problem with "Lua Script" after upgrade (GTK 3) (#690)
What OS are you using? If it Debian or any non Ubuntu-based distribution then maybe this problem was born here https://salsa.debian.org/gnome-team/gtk3/-/tree/ubuntu/focal/debian/patches ? Rebuilding for all GTK 3 packages only with patchs from Debian will stay last way of checking :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/690#issuecomment-723570607
Re: [Github-comments] [geany/geany-plugins] Problem with "Lua Script" after upgrade (GTK 3) (#690)
> Maybe problem > [here](https://github.com/geany/geany-plugins/blob/master/geanylua/glspi_dlg.c#L14): > `GTK_MESSAGE_OTHER` (without icon) replaced by `GTK_MESSAGE_INFO` (with > icon)? Well, IIUC that just aliases `GTK_MESSAGE_OTHER` to `GTK_MESSAGE_INFO` on GTK < 2.10 (presumably because `GTK_MESSAGE_OTHER` is new in 2.10 or something like that?). Should not affect GTK 2.24 vs 3.x AFAICT. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/690#issuecomment-723566279
Re: [Github-comments] [geany/www.geany.org] Geany e. V. General Assembly 2020 was done (#27)
@elextr The only set thing is, "one meeting per year" No date. It can be either at Jan, 1st or December, 31th --Only having a combined one at new years eve will not work unless you are sending out to invitations :D -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/27#issuecomment-723565669
Re: [Github-comments] [geany/geany-plugins] Problem with "Lua Script" after upgrade (GTK 3) (#690)
@b4n , thanks, looks better:  > However, I don't understand why you see a "missing image" image under GTK3. Maybe problem [here](https://github.com/geany/geany-plugins/blob/master/geanylua/glspi_dlg.c#L14): `GTK_MESSAGE_OTHER` (without icon) replaced by `GTK_MESSAGE_INFO` (with icon)? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/690#issuecomment-723562115
Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)
> And in any case, relying on the marker not creating conflicts is IMO too > optimistic for anything but user calling the feature and having a chance to > see if it's wrong. Yes, I noticed that there is only one toggle comment marker, not one per filetype as I first thought. Given the increasing popularity of doc comments that use extra characters after the comment token to signify stuff for docomment purposes there is every chance one day different languages will need different toggle markers, but thats another issue, not this one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2648#issuecomment-723558987
Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)
Agreed. My point was that it's perfectly OK to have whatever marker one on wants, and it shouldn't break the feature here. If it's not convenient for the user is not our problem, it's the user's; but if we let the user select a marker, it should not break anything (or we should forbid it). And in any case, relying on the marker not creating conflicts is IMO too optimistic for anything but user calling the feature and having a chance to see if it's wrong. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2648#issuecomment-723558248
Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)
> Well, IMO that's one possible usage of it (admittedly, the expected one), but > it doesn't strike me as "wrong" to use it some other way. Well, its the usage for which the feature is designed, if it is used in unintended ways and doesn't work that is not a bug. And since the feature expects a unique(ish) toggle marker it breaks this config file toggle feature. Using space for the toggle marker will likely uncomment comments inside the selection, but I guess if thats what the user expects its ok for them, they just have to be careful which lines they select. > > Won't that double comment comments which is sure to cause issues full of > > commented comments comments. :grin: > Well, currently that's the case: lines commented get extra comment prefix, > looking like #~ # […], which indeed look kind of odd. Ahh, after RTFC the skipping comments only happens on languages that have multi-line comments so they don't try to nest. So it basically seems to me that there needs to be specific code for commenting Geany config files (which we know to be `.conf` filetype even if they are called `filetypes.c`) and it should comment uncommented lines using the comment marker for `.conf` files. If that happens to be space then the user just has to be careful selecting lines to uncomment, but they were ok with doing that in their own code, so should be ok with doing it in the config file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2648#issuecomment-723550812
Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)
> > How so? > > You basically said it in the following sentence, the feature is for toggling > blocks of code on/off during development without worrying about internal > comments, its not for setting/unsetting comments for permanent use, which is > why I made the note about users misunderstanding the feature and breaking it > by setting the marker to something common in normal comments, like space. Well, IMO that's one possible usage of it (admittedly, the expected one), but it doesn't strike me as "wrong" to use it some other way. > > e.g. consider all lines uncommented no matter what. > > Won't that double comment comments which is sure to cause issues full of > commented comments comments. grin Well, currently that's the case: lines commented get extra comment prefix, looking like `#~ # […]`, which indeed look kind of odd. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2648#issuecomment-723547752
Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)
> How so? You basically said it in the following sentence, the feature is for toggling blocks of code on/off during development without worrying about internal comments, its not for setting/unsetting comments for permanent use, which is why I made the note about users misunderstanding the feature and breaking it by setting the marker to something common in normal comments, like space. Perhaps the feature should be renamed so it isn't the same as comment/uncomment in other editors, so users don't assume its the same without understanding it. > make sure we only ever toggle on Well, in this use that is all we need, so (without looking at how complex it is) we could add an extra parameter to the toggle comment code to limit it to on for uncommented lines only. Or make a separate function, YMMV. > e.g. consider all lines uncommented no matter what. Won't that double comment comments which is sure to cause issues full of commented comments comments. :grin: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2648#issuecomment-723539469
Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)
@rezso Could you give some information on your setup? System version, maybe libxml2 and Geany-Plugins version? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1023#issuecomment-723535722
Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)
> But basically if the toggle comment character is set to space the whole > toggle comment feature is broken everywhere, not just here. How so? It works fine when triggered, and leads to inserting what looks like a regular comment. Using a marker that is not usually used allows to use the toggle comment feature to easily disable some part of the code without worrying about regular comments getting uncommented, but if your comments were using the marker you'd have the same problem, and if you didn't select commented lines you wouldn't have any problem either way. > IIRC the discussions at the time, toggle comment was used so selected ranges > can be uncommented easily in the resulting file without removing the original > comments. Fair enough, but we should make sure we only ever toggle *on*, e.g. consider all lines uncommented no matter what. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2648#issuecomment-723535605
Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)
Well the toggle comment feature will only toggle comments with the comment marker in them, hence so long as its not space (as you identified) it will leave existing comments alone and simply comment all the uncommented lines, which is what we want. IIRC the discussions at the time, toggle comment was used so selected ranges can be uncommented easily without removing the original comments. But basically if the toggle comment character is set to space the whole toggle comment feature is broken everywhere, not just here. Thats a user problem (most likely a misunderstanding of how "toggle comment" differs from comment/uncomment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2648#issuecomment-723530091
