[Github-comments] Re: [geany/geany] Terminal/console feature on Windows (#675)
Just an aside for Windows users, has anybody tried Geany on WSL? IIUC thats a Ubuntu container that should "just work"? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/675#issuecomment-1418571806 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Terminal/console feature on Windows (#675)
@yashpalgoyal1304 > But I don't think that would work either... Correct. Geany and GTK are not Java. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/675#issuecomment-1418569092 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Terminal/console feature on Windows (#675)
I also recently found one more application: java terminal widget [JediTerm] (used by [trolCommander]). It comes from JetBrains and is hosted [here] on github. But I don't think that would work either... [JediTerm]: https://www.opensourceagenda.com/projects/jediterm [here]: https://github.com/JetBrains/jediterm [trolCommander]: https://trolsoft.ru/en/soft/trolcommander#:~:text=programm%20based%20on-,JediTerm,-(F2%20hotkey -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/675#issuecomment-1418519013 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)
> multiterm could likely be salvaged with relatively low effort? Just needs "somebody" to do it ;-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1217#issuecomment-1418332620 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)
wrt the others, FWIW I guess that * devhelp is kind of a lost cause short of bundling libdevhelp * geanypy as well, and I don't know feature difference, but indeed peasy is probably more current anyway * multiterm could likely be salvaged with relatively low effort? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1217#issuecomment-1418296039 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)
@eht16 well done for tricking me into giving it another shot ;) Though you only got bare minimum resurrection from old work, but that doesn't actually don't look that bad, not sure why I never submitted it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1217#issuecomment-1418295648 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] webhelper: Port to webkit2gtk (PR #1224)
Based off work from @hyperair that was merged at some point in #677, but reverted since then (see there). This adds a couple bits on top to fix some issues, and I believe the "meh no GTK2" whining of mine is lost to time and the fact there's no supported webkit for GTK2 anymore anyway. BEWARE: this has been given little testing in the 2020s, I just rebased, merged a couple branches to the point there diffed empty, and did some very basic testing (it builds, it runs, and *seems* to work). Take it, leave it, improve it, comment on it, etc. I'll be there try not to forget looking at this for any comment though :wink: NOTE: it's not at 100% feature-parity with the old version, mostly because of API changes regarding the inspector (II[RU]C, docking settings are not as controllable anymore), yet the inspector itself has seen countless improvements of course. But again, maybe things have changed since 2018. See also #1217. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1224 -- Commit Summary -- * webhelper: Initial port to webkit2gtk * webhelper: Initialize webkit favicon database * webhelper: Fix ctrl+scroll zooming in gtk3 * webhelper: Port context menu to WebKitContextMenu * webhelper: Use the right type for GSimpleAction * webhelper: Port link hovering functionality to webkit2gtk * webhelper: Fix constness of a variable * webhelper: Add missing G_CALLBACK() casts * webhelper: Avoid a deprecation * webhelper: Make gtk3-only * webhelper: Remove pre-GTK3 compatibility checks * webhelper: Don't use deprecated GtkStock * webhelper: Port inspector signal handlers to webkit2gtk * webhelper: Fix flip-panes action * webhelper: Remove custom docking position support * webhelper: Fix loading progress display -- File Changes -- M build/webhelper.m4 (5) M webhelper/src/Makefile.am (3) M webhelper/src/gwh-browser.c (762) M webhelper/src/gwh-browser.h (11) M webhelper/src/gwh-plugin.c (60) M webhelper/src/gwh-settings.c (9) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1224.patch https://github.com/geany/geany-plugins/pull/1224.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1224 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@eht16 I incorporated your suggested changes. I'm still learning Github, I apologize if I'm not navigating this pull request correctly đŸ˜… (at my work, I'm used to Gitlab) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#issuecomment-1418276063 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)
re WebHelper, I kind of plan to port it to something not dead someday (webkit2), but it's been a long while and it didn't happen, mostly as @elextr mentioned because it means some non-trivial rewrites. Also, I don't actually use that plugin very much (otherwise I probably would have picked this up by then), and mostly wrote it as a feature request if I recall. If people care, I could possibly try and revamp an old webkit2 port attempt (I think Debian had something back in the days as well), but I wasn't wholly happy about t because it didn't have full feature parity. And who knows, maybe it'd give somebody else ideas. Yet if nobody cares, you can also drop it, I won't cry on its demise :shrug: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1217#issuecomment-1418273924 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
Reopened #1221. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#event-8441755413 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
>
> Looks good! Thanks.
>
> > While "rainbow colours" sounds nice "Bracketcolors" is more descriptive, so
> > a user looking for it is more likely to find it.
>
> Full agree. @asifamin13 maybe you could just mention "rainbow colors" in the
> README, that might already suffice that users can find it also with this name.
>
> I did a quick code review without having a deeper look at the logic. From a
> quick test, it works as advertised and I got many fancy brackets :).
>
> A few comments @asifamin13:
>
> * Could you add the plugin name in
> https://github.com/geany/geany-plugins/blob/master/build/geany-plugins.nsi#L176
> (this is for the Windows installer, use `bracketcolors.dll`)
> * As Geany itself also colorizes the brackets in an idle callback, did you
> check that both implementations do not interfere with each other?
> * I got a few compiler warnings which might be worth looking into:
>
> ```
> BracketMap.cc: In member function 'void BracketMap::Show()':
> BracketMap.cc:122:21: warning: loop variable 'it' creates a copy from type
> 'const std::pair >' [-Wrange-loop-construct]
> 122 | for (const auto it : mBracketMap) {
> | ^~
> BracketMap.cc:122:21: note: use reference type to prevent copying
> 122 | for (const auto it : mBracketMap) {
> | ^~
> | &
> bracketcolors.cc: In function 'gboolean utils_parse_color(const gchar*,
> GdkColor*)':
> bracketcolors.cc:276:27: warning: 'gboolean gdk_color_parse(const gchar*,
> GdkColor*)' is deprecated: Use 'gdk_rgba_parse' instead
> [-Wdeprecated-declarations]
> 276 | return gdk_color_parse(spec, color);
> |~~~^
> In file included from /usr/include/gtk-3.0/gdk/gdkcairo.h:26,
> from /usr/include/gtk-3.0/gdk/gdk.h:33,
> from /usr/include/gtk-3.0/gtk/gtk.h:30,
> from /home/enrico/apps/include/geany/gtkcompat.h:30,
> from /home/enrico/apps/include/geany/editor.h:27,
> from /home/enrico/apps/include/geany/document.h:31,
> from /home/enrico/apps/include/geany/build.h:26,
> from /home/enrico/apps/include/geany/geanyplugin.h:36,
> from bracketcolors.cc:40:
> /usr/include/gtk-3.0/gdk/deprecated/gdkcolor.h:79:11: note: declared here
>79 | gboolean gdk_color_parse (const gchar*spec,
> | ^~~
> ```
Thanks for the feedback!
- The deprecated `gdk*` warning are ok. I removed the unused debugging code
that was causing the others.
- I added the bracketcolors entry to `geany-plugins.nsi`.
- I confirmed my plugin behaves correctly when Geany colors brackets itself,
like when brackets are missing
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1418273658
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
Closed #1221. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#event-8441754664 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@asifamin13 commented on this pull request. > @@ -0,0 +1,32 @@ +Color brackets, parenthesis, and braces +=== thanks, fixed! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#discussion_r1096813044 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@asifamin13 commented on this pull request.
> +// nested bracket
+orderStack.push(endPos);
+}
+
+GetOrder(bracket) = orderStack.size() - 1;
+}
+}
+
+
+
+//
-
+void BracketMap::Show()
+/*
+
+-
*/
+{ g_debug("%s: Showing bracket map ...", __FUNCTION__);
they aren't needed anymore. I removed the commented ones as well
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1096812976
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@asifamin13 commented on this pull request. > @@ -0,0 +1,35 @@ +# = yes, is there a better way to handle this? I'm new to the autotools world, so any recommendations would be appreciated -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#discussion_r1096812891 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@asifamin13 commented on this pull request.
> +
+static Length& GetLength(Bracket &bracket) {
+return std::get<0>(bracket);
+}
+static Order& GetOrder(Bracket &bracket) {
+return std::get<1>(bracket);
+}
+
+static const Length& GetLength(const Bracket &bracket) {
+return std::get<0>(bracket);
+}
+static const Order& GetOrder(const Bracket &bracket) {
+return std::get<1>(bracket);
+}
+};
+
this was from a standard template I use, fixed
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1096812788
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@asifamin13 commented on this pull request. > @@ -0,0 +1,143 @@ +/* + * BracketMap.cc + * + * Copyright 2013 Asif Amin thanks for catching this, fixed! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#discussion_r1096812623 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@asifamin13 pushed 1 commit. 0ac738a0532a8638bbe9d9bd55aed0eac671df78 Bracket Colors, initial code review -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1221/files/b75167c3c1d56d476abc06458a84ee84b7d907ca..0ac738a0532a8638bbe9d9bd55aed0eac671df78 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] TOML configuration language support (#1268)
Well, [__HE__](https://github.com/zufuliu/notepad2/graphs/contributors) is active, others not so much. Actually its not clear what license its under, the header refers to `License.txt` and there is one in the Scintilla directory immediately above the lexers directory and a different one in the top level directory, although that again says lexilla and scintilla is under their own license. I guess the same could be done if Neil accepted it in Lexilla. But anyway, if its not upstreamed its unlikely to get in Geany sadly. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1268#issuecomment-1418091283 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@eht16 commented on this pull request.
> +// nested bracket
+orderStack.push(endPos);
+}
+
+GetOrder(bracket) = orderStack.size() - 1;
+}
+}
+
+
+
+//
-
+void BracketMap::Show()
+/*
+
+-
*/
+{ g_debug("%s: Showing bracket map ...", __FUNCTION__);
Should those `g_debug` statements remain in the code? Also the commented ones?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#pullrequestreview-1284256497
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Feature Request: repeat command (Issue #3382)
I don't mind if it is added as part of the GeanyMacro plugin or a separate plugin. But I think it doesn't fit too well into Geany core. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3382#issuecomment-1418089147 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@eht16 requested changes on this pull request.
Oh, and could you please add your plugin to the list in the top README?
> @@ -0,0 +1,32 @@
+Color brackets, parenthesis, and braces
+===
RestructuredText (the text format used here) requires that underlines are
exactly as long as the heading above.
> @@ -0,0 +1,143 @@
+/*
+ * BracketMap.cc
+ *
+ * Copyright 2013 Asif Amin
2013? I guess it's a typo :).
If so, ideally change all occurrences.
> @@ -0,0 +1,35 @@
+# =
Are these two "ax_cxx_*" M4 macros copied from Geany?
> +
+static Length& GetLength(Bracket &bracket) {
+return std::get<0>(bracket);
+}
+static Order& GetOrder(Bracket &bracket) {
+return std::get<1>(bracket);
+}
+
+static const Length& GetLength(const Bracket &bracket) {
+return std::get<0>(bracket);
+}
+static const Order& GetOrder(const Bracket &bracket) {
+return std::get<1>(bracket);
+}
+};
+
Why so many empty lines?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#pullrequestreview-1284250581
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
Looks good! Thanks.
> While "rainbow colours" sounds nice "Bracketcolors" is more descriptive, so a
> user looking for it is more likely to find it.
Full agree.
@asifamin13 maybe you could just mention "rainbow colors" in the README, that
might already suffice that users can find it also with this name.
I did a quick code review without having a deeper look at the logic.
>From a quick test, it works as advertised and I got many fancy brackets :).
A few comments @asifamin13:
- Could you add the plugin name in
https://github.com/geany/geany-plugins/blob/master/build/geany-plugins.nsi#L176
(this is for the Windows installer, use `bracketcolors.dll`)
- As Geany itself also colorizes the brackets in an idle callback, did you
check that both implementations do not interfere with each other?
- I got a few compiler warnings which might be worth looking into:
```
BracketMap.cc: In member function 'void BracketMap::Show()':
BracketMap.cc:122:21: warning: loop variable 'it' creates a copy from type
'const std::pair >' [-Wrange-loop-construct]
122 | for (const auto it : mBracketMap) {
| ^~
BracketMap.cc:122:21: note: use reference type to prevent copying
122 | for (const auto it : mBracketMap) {
| ^~
| &
bracketcolors.cc: In function 'gboolean utils_parse_color(const gchar*,
GdkColor*)':
bracketcolors.cc:276:27: warning: 'gboolean gdk_color_parse(const gchar*,
GdkColor*)' is deprecated: Use 'gdk_rgba_parse' instead
[-Wdeprecated-declarations]
276 | return gdk_color_parse(spec, color);
|~~~^
In file included from /usr/include/gtk-3.0/gdk/gdkcairo.h:26,
from /usr/include/gtk-3.0/gdk/gdk.h:33,
from /usr/include/gtk-3.0/gtk/gtk.h:30,
from /home/enrico/apps/include/geany/gtkcompat.h:30,
from /home/enrico/apps/include/geany/editor.h:27,
from /home/enrico/apps/include/geany/document.h:31,
from /home/enrico/apps/include/geany/build.h:26,
from /home/enrico/apps/include/geany/geanyplugin.h:36,
from bracketcolors.cc:40:
/usr/include/gtk-3.0/gdk/deprecated/gdkcolor.h:79:11: note: declared here
79 | gboolean gdk_color_parse (const gchar*spec,
| ^~~
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1418077202
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] TOML configuration language support (#1268)
> Well, now the creator of that needs to agree to change the license from > Notepad's to Lexilla's to upstream it. Nah, he can generate more sponsorship dollars by reserving the rights. I'd say he's earned it. Have you *seen* [how active][0] that project is? A regular beehive. [0]:https://github.com/zufuliu/notepad2/graphs/commit-activity -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1268#issuecomment-1417918831 You are receiving this because you are subscribed to this thread. Message ID:
