[Github-comments] Re: [geany/geany-plugins] Markdown Plugin Preview not working after starting geany with a file that was already opened the other day (#1062)
> Don't know if that will make it available in the windows build as @eht16 > comment above notes It is not and will be not available in the Windows builds, this is already the case since Geany 1.38. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1062#issuecomment-2241538732 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add feature: copy filename / copy filepath to clipboard (#868)
> So I find myself here because after installing the > "geany-plugins-2.0_setup.exe" -- I don't see the addons plugin or the Tools > menu option to copy file path. I guess I had to copy addons.dll from > C:\Users\Geany-Plugins 2.0\lib\geany to C:\Users\Geany > 2.0\lib\geany > > This doesn't seem right... should the default install directory for the > Geany-Plugins 2.0 for windows be same as the install directory for Geany 2.0? This was already reported in https://github.com/geany/geany-plugins/issues/1321 and fixed in https://github.com/geany/geany-plugins/pull/1324. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/868#issuecomment-2241535100 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)
> @eht16 OK (especially if you plan to have the Geany web site static). I guess we will keep a small Django site anyway for the Pastebin service and even if not this won't be the problem. > @techee if you release a bugfix maybe you need to version it 2.0-1 like > Ubuntu does with its packages. Not sure it the plugin needs updating to > handle that. Uhh, don't tell this the Debian/Ubuntu guys :). They use the -1 suffix for package versions of the same upstream version. > Yes, but how to get this version "inside" the package so the updatechecker > plugin knows it's 2.0-1 and can compare it with what the server returns as > the latest version? From the code point of view the Geany version will still > be 2.0. We could bake something like a "build number" or so into Geany which starts with 1 for every version and for rebuilds (like in your example) could then have the build number increased. The plugin will check the version number and the build number together. The server sends then the version and the build number to the plugin. We don't need to extract those information from the installer file, it could be managed seperately with a simple web interface on the server or just a file. Less convenient but also less fragile :D. Thinking this further, for such cases when we update the installer for an existing version, we probably should also make this clear to the user, e.g. also show the build number in the plugin notification dialog. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1314#issuecomment-2221079158 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Documentation generator manual links to wrong dir (#992)
According to https://packages.debian.org/bookworm/amd64/geany-plugin-gendoc/filelist the manual is installed in another location than the plugin expects. I wonder if the build system should handle this or Debian must patch the paths. @hyperair @evgeni? @LadyAleena could you whether other plugins' help do work? E.g. try "Scope" or "Commander"? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/992#issuecomment-2212523572 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)
Looks good, fine to squash+merge for me. -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/50#issuecomment-2212521194 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)
@eht16 pushed 1 commit. 931dd8bd0f3daf129b4d8731610f8bed213765a5 fixup: fix typo -- View it on GitHub: https://github.com/geany/www.geany.org/pull/50/files/fba270deb176f193bdbc38b10fe3aae23df87316..931dd8bd0f3daf129b4d8731610f8bed213765a5 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Add Github, Mastodon and Matrix icons to footer (PR #53)
@eht16 pushed 1 commit. 3ca41ff91531df5277efca3a38999b0d9c2dab89 Add Github, Mastodon and Matrix icons to footer -- View it on GitHub: https://github.com/geany/www.geany.org/pull/53/files/0340894e17bd7d3e1ed7a781a7b8ddea31ccf2e8..3ca41ff91531df5277efca3a38999b0d9c2dab89 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/www.geany.org] Add Github, Mastodon and Matrix icons to footer (PR #53)
This should make it easier to find the links to external resources. Looks like:  You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/53 -- Commit Summary -- * Add Github, Mastodon and Matrix icons to footer -- File Changes -- A geany/static/img/github.svg (1) A geany/static/img/mastodon.svg (3) A geany/static/img/matrix.svg (9) M geany/templates/skel.html (5) -- Patch Links -- https://github.com/geany/www.geany.org/pull/53.patch https://github.com/geany/www.geany.org/pull/53.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/53 You are receiving this because you are subscribed to this thread. Message ID: geany/www.geany.org/pull/5...@github.com
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
@eht16 pushed 1 commit. 9cf72b0d42679ae8bf551d0d83836c9a83f77335 CI: use Ubuntu 22.04 for Meson build -- View it on GitHub: https://github.com/geany/geany/pull/3811/files/2259ae9197007b279924645e8b43acc8778a5669..9cf72b0d42679ae8bf551d0d83836c9a83f77335 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
I added a commit to require Meson 0.56. Feel free to squash the commits together. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2212420795 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
@eht16 pushed 1 commit. 2259ae9197007b279924645e8b43acc8778a5669 Require Meson 0.56 or newer -- View it on GitHub: https://github.com/geany/geany/pull/3811/files/90968916af982c0a8f26d5a1b3f4623200312e9e..2259ae9197007b279924645e8b43acc8778a5669 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)
> My thinking is that if we make a bug in the plugin's update logic, we'll have > to make a new release to fix it while we can update the server's code any > time without any release and it also offers more flexibility in case we need > to change something in the future. This is a good point. Still, I think it would be best to let the plugin decide whether to update or not. But we can definetely improve the server response and provide more information, e.g. like suggested in https://github.com/geany/geany-plugins/issues/1314#issuecomment-2196230450 but as response instead of request. Having the logic in the plugin would not require to send any information to the server and so be more privacy friendly. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1314#issuecomment-2212410944 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [FR] Portable Windows builds (Issue #3915)
Basically you don't need a third party package. In https://github.com/geany/www.geany.org/pull/52 I described how to get Geany running portable with a simple Batch script. @sdasda if you like, feel free to try it and report back whether it works. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3915#issuecomment-2212404110 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Add a simple Geany portable variant to the FAQ (PR #52)
@elextr what do you think? And it'd be nice if you could check for improvements on my wording :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/52#issuecomment-2212403687 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/www.geany.org] Add a simple Geany portable variant to the FAQ (PR #52)
Inspired by https://github.com/geany/geany/issues/3915. You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/52 -- Commit Summary -- * Add a simple Geany portable variant to the FAQ -- File Changes -- M page_content/documentation/faq.md (25) M static_docs/templates/pages/i18n.html (2) -- Patch Links -- https://github.com/geany/www.geany.org/pull/52.patch https://github.com/geany/www.geany.org/pull/52.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/52 You are receiving this because you are subscribed to this thread. Message ID: geany/www.geany.org/pull/5...@github.com
[Github-comments] Re: [geany/geany-plugins] Default plugins folder incorrect / not found (Issue #1321)
Closed #1321 as completed via 9c2ea2c320ffa235777c85e0e9fd5e4002873ac0. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1321#event-13258211497 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Default plugins folder incorrect / not found (Issue #1321)
Closed #1321 as completed via #1324. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1321#event-13258211494 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Windows installer: Prefer Geany installation directory over user's HOME (PR #1324)
Merged #1324 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1324#event-13258211467 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [RFC] Enable keyboard searching for Compiler and Messages tree views (PR #3823)
Merged #3823 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3823#event-13258194272 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Addons: Hide status icon on startup until Geany has started (PR #1359)
Merged #1359 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1359#event-13258192068 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Addons: Remove obsolete GTK_CHECK_VERSION checks (PR #1358)
Merged #1358 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1358#event-13258188982 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Do we agree to merge this? It's a simple change which improves the Meson Windows build. I agree with @kugel- that at least for now we don't need to be backwards compatible with a four years old Ubuntu system for an alternate build system, the full featured Autotools based build system still exists. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2185319596 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Tested on Windows and works. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171874834 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] (FR) Please provide official FlatPak for Geany (Issue #3905)
Closed #3905 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3905#event-13175285670 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] (FR) Please provide official FlatPak for Geany (Issue #3905)
Just for the records, there is a long story in https://github.com/geany/geany/issues/1303 about AppImages and Flatpaks. I don't think it is likely that we (Geany maintainers) will provide a Flatpak package officially. We don't have so much resources (in terms of time) and nobody of us (as far as I know) uses Geany via Flatpak. And so the motivation to invest time for having a well maintained Flatpak image is rather low. And all what @elextr said. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3905#issuecomment-2171434425 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Bad owner or permissions on /etc/ssh/ssh_config.d/ Could not read from remote repository. (Issue #3679)
Closed #3679 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3679#event-13175276312 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Nightly Builds for GTK3 (#797)
Already done in nightly builds and CI. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/797#issuecomment-2171431972 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Nightly Builds for GTK3 (#797)
Closed #797 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/797#event-13175274067 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] GTK3 Nightly Builds (#2003)
Closed #2003 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2003#event-13175272286 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] GTK3 Nightly Builds (#2003)
I'd like to close this. We do have GTK3 nightly and CI builds and there is no more Travis, six years later :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2003#issuecomment-2171431487 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Support setting SCI_SETCARETPERIOD (PR #3901)
I don't have a strong opinion on this either. I agree that we can postpone this until there might raise actual need. But maybe we could close the PR instead and leaving a comment here that it could be resurrected if needed? The list of open PRs is quite long and one has to search for it anyway. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3901#issuecomment-2171429963 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Remove references to what was called Twitter once (PR #51)
Merged #51 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/51#event-13175248919 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
I'll test the CI installers in the next days when time permits. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171428358 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Support setting SCI_SETCARETPERIOD (PR #3901)
We could extend the comment to explain that this setting overrides the GTK default and when changed, the GTK blinking rate is fully ignored. I could imagine this could be still useful when users want different settings for Geany and the rest of the DE. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3901#issuecomment-2171276760 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Drop win32_message_dialog()s (PR #3903)
> > Anyway, tested on native Windows and works. > > I think the question is more "is it OK to drop it" :) The answer was given implicitly by testing it :). I don't remember why those dialogs did exist and I'm not even sure there was a distinct reason for. Most of the Geany Windows stuff I wrote almost two decades ago, was mostly out of curiosity whether it works, what can be done and what cannot. Since I don't use Windows (and did not use it for longer than Geany exists), I have no preference what dialogs to show. Dropping the native message dialogs removes code and reduces the risk of future breakages, so I think this is good. > GTK dialogs have confirmation on the right, Windows on the left. Would this > be a problem for Windows users? > > Note that for other custom dialogs like search, replace, preferences, etc. > Geany already uses the GTK order so this change would make things > "consistently wrong" instead of "inconsistently correct". My two cents: being "consistently wrong" is probably better in this case for the benefit of better looking dialogs (especially if a dark or other custom GTK theme is used). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3903#issuecomment-2171272416 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: allow forward slashes (/) instead of backslashes (\) in "Open file" dialog (Issue #3868)
I guess so as well. @cousteaulecommandant with current GIT master (installers can be found on https://nightly.geany.org/mingw64/) and with the release, you can enable native Windows file open/save dialogs, maybe these offer better navigation aids. Apart from that, I agree with @elextr that we probably cannot modify the GTK file chooser dialogs. So closing, re-open if you disagree. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3868#issuecomment-2171268485 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: allow forward slashes (/) instead of backslashes (\) in "Open file" dialog (Issue #3868)
Closed #3868 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3868#event-13174638756 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2121257090 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
Seeen it but didn't have time until now. With the new installers pasting to geany.org works fine now. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2171266224 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/www.geany.org] Remove references to what was called Twitter once (PR #51)
Since the Twitter account is not active anymore, remove our references to it. You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/51 -- Commit Summary -- * Remove references to what was called Twitter once -- File Changes -- M geany/templates/home.html (5) M page_content/contribute/support.md (4) -- Patch Links -- https://github.com/geany/www.geany.org/pull/51.patch https://github.com/geany/www.geany.org/pull/51.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/51 You are receiving this because you are subscribed to this thread. Message ID: geany/www.geany.org/pull/5...@github.com
[Github-comments] Re: [geany/geany] Drop win32_message_dialog()s (PR #3903)
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3903#pullrequestreview-2120432970 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Drop win32_message_dialog()s (PR #3903)
> > I'm all for it, but given I don't use Windows I don't think my vote is fair > > > > Yeah, @eht16 is the official Windows guru and enthusiast :-) I'm neither of those but I'm aware you like to assign this to me :). Anyway, tested on native Windows and works. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3903#issuecomment-2169545521 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
We are getting closer :). "gsettings-desktop-schemas" is missing in the dependency list in build/gtk-bundle-from-msys2.sh (sorry if I wasn't clear about it before). This package contains the GLib schemas files necessary for the "glib-networking" package. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2169525153 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Single click inside editor makes selection when modified warning appears (Issue #3906)
I was bitten by this a couple of times as well. Fix works, thanks @techee! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3906#issuecomment-2169477373 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Avoid unwanted selection when infobar shows by mouse click in Scintilla (PR #3909)
@eht16 approved this pull request. Tested and works great. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3909#pullrequestreview-2120415575 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
> I just noticed some more dead code inside `win32.c` that was used by the > native implementation so I removed it. Love it that you clean up the (probably mine) old win32 code :heart: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2169419576 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n do you mind rebasing on current master? Then we'll get easy to test installers from the CI and could finally merge this one. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2169412511 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Addons: Remove obsolete GTK_CHECK_VERSION checks (PR #1358)
@eht16 commented on this pull request. > -#if ! GTK_CHECK_VERSION(2, 10, 0) gtk_widget_hide(check_systray); -#endif This is so me...you are completely right. Thanks for spotting, fixed. Funny thing, this attempt to hide the option didn't work at all because in Geany itself we call `gtk_widget_show_all()` when creating the plugin preferences dialog and so it was shown again. Anyway, GTK2 is long time ago. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1358#discussion_r1635482279 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Addons: Remove obsolete GTK_CHECK_VERSION checks (PR #1358)
@eht16 pushed 1 commit. 678c81edbf221adedb2917e327062365b178d33a fixup: remove left-over systray call -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1358/files/695748bccca5f8ad2a5ed6a21970b60439935b0e..678c81edbf221adedb2917e327062365b178d33a You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [plugins/filebrowser] Change external open default to `xdg-open` (PR #3815)
Merged #3815 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3815#event-13090947550 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Tweak toggle additional widgets docs (PR #3821)
LGTM. @b4n fine for you too? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3821#issuecomment-2156462267 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [build] Improve custom command dialog (PR #3833)
Merged #3833 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3833#event-13090847506 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: make VERSION contain string, not a double (PR #3893)
Merged #3893 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3893#event-13090836171 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
Merged #3878 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#event-13090818674 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
Closed #3660 via #3878. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#event-13090818721 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)
Merged #1352 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1352#event-13090813491 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: Add glib-compile-schemas.exe to GTK bundle (PR #3885)
Merged #3885 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3885#event-13090811532 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Spellcheck remove obsolete gtk check version (PR #1360)
@eht16 pushed 1 commit. 349931c4037708a366c6841a4f0a1504dfde79ed SpellCheck: Remove obsolete GTK_CHECK_VERSION checks -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1360/files/e014f1643ef830237002999c9f09559d577b68bf..349931c4037708a366c6841a4f0a1504dfde79ed You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Spellcheck remove obsolete gtk check version (PR #1360)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1360 -- Commit Summary -- * Addons: Hide status icon on startup until Geany has started * SpellCheck: Remove obsolete GTK_CHECK_VERSION checks -- File Changes -- M addons/src/ao_systray.c (1) M spellcheck/src/gui.c (16) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1360.patch https://github.com/geany/geany-plugins/pull/1360.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1360 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] [geany/geany-plugins] Addons: Hide status icon on startup until Geany has started (PR #1359)
This avoids showing the status icon without an icon on startup and even if it is disabled while Geany is starting. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1359 -- Commit Summary -- * Addons: Hide status icon on startup until Geany has started -- File Changes -- M addons/src/ao_systray.c (1) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1359.patch https://github.com/geany/geany-plugins/pull/1359.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1359 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] [geany/geany-plugins] Addons: Remove obsolete GTK_CHECK_VERSION checks (PR #1358)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1358 -- Commit Summary -- * Addons: Remove obsolete GTK_CHECK_VERSION checks -- File Changes -- M addons/src/addons.c (2) M addons/src/ao_doclist.c (17) M addons/src/ao_systray.c (16) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1358.patch https://github.com/geany/geany-plugins/pull/1358.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1358 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)
Thanks! I updated the wiki page https://wiki.geany.org/config/docker-compose to only provide a custom filetype for Docker-Compose files. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-2143939064 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)
Merged #3757 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#event-13012400300 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] filetypes.Dockerfile.conf (Issue #3752)
Closed #3752 as completed via #3757. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3752#event-13012400441 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] ProjectOrganizer, Workbench: Use GStatBuf for "g_stat()" calls (PR #1353)
Merged #1353 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1353#event-12996576609 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)
Merged #3886 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3886#event-12996209621 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)
@eht16 commented on this pull request. > @@ -16,7 +16,7 @@ More than financial support, the Geany project needs help > with: If you want to donate money to the Geany project, it will be used to support further development of Geany, to pay running costs for hosting and domains and support presenting Geany on various [Open Source Conferences][5]. There are different options to donate, including bank transfer and Liberapay. -Bank transfer to the [Geany e.V.][8] account is the preferred way for donating money as the money is transferred directly without a third party involved and additional fees can be avoided. +Bank transfer to the [Geany e.V.][8] account (only SEPA / Europe) is the preferred way for donating money as the money is transferred directly without a third party involved and additional fees can be avoided. Do you mind changing it? :D -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/50#discussion_r1621898599 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)
Alright, thanks for the attempt. It seems the Scintilla Bash lexer highlights keywords only at the start of a line which is basically fine for real shell scripts. I think then it is fine as it is. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-2141405553 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] ProjectOrganizer, Workbench: Use GStatBuf for "g_stat()" calls (PR #1353)
For some reason, since the latest MSYS2 update on my Windows system, I got compiler errors that `g_stat()` requires a `GStatBuf` type as second argument. According to the docs, https://docs.gtk.org/glib/func.stat.html, this is correct and in Geany we also use `GStatBuf` in all places. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1353 -- Commit Summary -- * ProjectOrganizer, Workbench: Use GStatBuf for g_stat() calls -- File Changes -- M projectorganizer/src/prjorg-project.c (2) M workbench/src/tm_control.c (2) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1353.patch https://github.com/geany/geany-plugins/pull/1353.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1353 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)
One last remark: could we add `AS` to the keywords? It's not strictly a directive on its own but is part of the `FROM` directive, e.g. `FROM debian:bullseye-slim AS builder` and without the highlighting looks a bit broken. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-2132203817 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)
> @eht16 you're the de-facto expert here, remember you did some work on it, now > you're doomed Remember, this is certainly at least one decade ago and since then I successfully managed to avoid doing any PowerShell :). > I'll try and update this, but feel also free to take this PR over fixing > whatever you think makes sense. Again, all I did was looking at (possibly an > older version of) the link and came up with this just seeing missing keywords > from examples. Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3886#issuecomment-2132202603 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)
@eht16 pushed 1 commit. 7707c7a346a585bbb79e766bae912d389ad90b2b PowerShell: Add keyword "clean" and aliases "foreach" and "where" -- View it on GitHub: https://github.com/geany/geany/pull/3886/files/5a2a436e69550bed35fdc215baffb8c09a0fa25f..7707c7a346a585bbb79e766bae912d389ad90b2b You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
> Alright, I made the suggested changes: > > 1. I made GtkFileChooserNative configurable, by default enabled on macOS > and Windows, disabled on Linux. Sweet, works perfectly. > 3. Not sure if intentional or if it's some left-over but `ui_utils.c` > still contains native win32 dialogs: > https://github.com/geany/geany/blob/11b4a00a3020b1c9ace3d3ae65aa5ec7d5ff84e0/src/ui_utils.c#L2012 > I replaced those with GtkFileChooserNative and eliminated the native > code in win32.c. I guess it's some sort of left-over because it wasn't as buggy as the full file dialogs and so they were out of my focus. Thanks for cleaning up my dirt :D. > 4. For now I didn't modify plugins which also contain some GtkFileChooser > code but I could do the same for them too if desired. I think this improve the overall user experience. Though maybe this can be done later as well and maybe also by the respective plugin maintainers (at least for those plugins which still have an active maintainer). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2132197631 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)
@eht16 commented on this pull request. > @@ -152,6 +152,8 @@ Section "Dependencies" SEC04 SectionEnd Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"' > OK. If `$INSTDIR` ought to be the same, maybe just make the 2.1 installer > depend on Geany 2.1's one and call it a day. Good point, done. > > How does this behave if the executable is missing? If it is mandatory, then > > maybe mark the dependency somehow? > > Not sure, I'll test this. We could add the GLib package to the Tested: the installer silently ignores a missing "glib-compile-schemas". In this case, this is good I'd say. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1352#discussion_r1615172950 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)
To the removed ones: - "default" - no idea - "where" - according to http://xahlee.info/powershell/powershell_aliases.html and https://superuser.com/a/1397265, "where" is an alias So, we could add "where" to the aliases list. I checked the aliases in PowerShell on my Windows 7 machine, there are "foreach" and "where" listed which are missing in the current list. As far as I remember, the defined aliases on my system should be default, I don't think I ever messed with them (until now I didn't even know PowerShell knows aliases :D). Agree with @elextr about "clean". The rest looks fine to me, remember I don't have a clue about PowerShell as well :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3886#issuecomment-2132189774 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)
@eht16 pushed 1 commit. 5298197dbef2ae5ac5047d461aa521b8b32406c4 Windows: Make installer depend on Geany 2.1 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1352/files/c145a8c902356cb43ec9439e87124de52cabc4ab..5298197dbef2ae5ac5047d461aa521b8b32406c4 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)
@eht16 commented on this pull request. > @@ -152,6 +152,8 @@ Section "Dependencies" SEC04 SectionEnd Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"' > How does this behave if the executable is missing? If it is mandatory, then > maybe mark the dependency somehow? Not sure, I'll test this. We could add the GLib package to the plugins bundle, it would be redundant to the one in the Geany bundle but probably won't hurt. > Also, has `$INSTDIR` has to be the same as Geany's? If not, we won't find the > executable here, will we? True. But much more things won't work then, the compiled schemas will probably only searched in Geany's installation directory. Using another installation directory for G-P doesn't make much sense at all. > Do we need to re-run this on uninstall to "de-compile" the uninstalled > schemas? In theory, yes. In reality, we do not uninstall the installed schema files. To do so, we had to track each installed file to know what to uninstall. This would be nice but also quite some work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1352#discussion_r1614693385 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Make Custom Target should have a directory combo box (Issue #3883)
But why not, the combo box could be empty by default and so is not used. If the user wants to adds something, then it will be used. OTOH, this can also be achieved by using "-C src all" (or whatever target is desired) using the existing functionality. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3883#issuecomment-2131231860 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] #!/bin/busybox ash (Issue #3884)
Alternative and already working, you can add a header line to hint Geany what filetype to use: ```sh #!/bin/busybox ash # -*- Sh -*- ``` It is roughly described in https://geany.org/manual/#various-preferences (search for "extract_filetype_regex"). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3884#issuecomment-2131230565 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)
@eht16 commented on this pull request. > @@ -16,7 +16,7 @@ More than financial support, the Geany project needs help > with: If you want to donate money to the Geany project, it will be used to support further development of Geany, to pay running costs for hosting and domains and support presenting Geany on various [Open Source Conferences][5]. There are different options to donate, including bank transfer and Liberapay. -Bank transfer to the [Geany e.V.][8] account is the preferred way for donating money as the money is transferred directly without a third party involved and additional fees can be avoided. +Bank transfer to the [Geany e.V.][8] account (only SEPA / Europe) is the preferred way for donating money as the money is transferred directly without a third party involved and additional fees can be avoided. ```suggestion Bank transfer to the [Geany e.V.][8] account is the preferred way for donating money as the money is transferred directly without a third party involved and additional fees can be avoided. Please note bank transfers are only possible if your bank participates in [SEPA][10], usually this applies to banks in most European countries. ``` To me, this is clearer. What do you think? `[SEPA][10]` should be a reference to https://en.wikipedia.org/wiki/Single_Euro_Payments_Area and need to be added at the bottom. -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/50#pullrequestreview-2078951947 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
@eht16 commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const
> re_string_t *input, int idx,
#define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
#define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
-#ifdef WIN32
+#ifdef _WIN32
```sh
# git grep -i tagRegexTable ctags/parsers/
ctags/parsers/dosbatch.c:20:static tagRegexTable dosTagRegexTable [] = {
ctags/parsers/dosbatch.c:39:def->tagRegexTable = dosTagRegexTable;
ctags/parsers/dosbatch.c:40:def->tagRegexCount = ARRAY_SIZE
(dosTagRegexTable);
ctags/parsers/matlab.c:20:static tagRegexTable matlabTagRegexTable [] = {
ctags/parsers/matlab.c:48: def->tagRegexTable = matlabTagRegexTable;
ctags/parsers/matlab.c:49: def->tagRegexCount = ARRAY_SIZE
(matlabTagRegexTable);
```
If this detection is sufficient, we have two parsers in Geany using the regex
library. For me that doesn't really justify putting efforts into switching the
library until there is a need for.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3878#discussion_r1614592211
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> @eht16 paste configuration issue should be fixed. But indeed it's unrelated > to this PR, just to you using a newer GLib Yes, it is fixed. Thanks for fixing it! > > Can't we "simply" run `glib-compile-schemas` during GP (and possibly Geany) > > installation? it's e.g. what Linux distros would do (e.g. Debian has a > > trigger or whatever for whenever you install a new schema in the system > > directory so the compiled schemas are rebuilt) > > Hmm, this could work. I'll give it a try soon. Done in https://github.com/geany/geany/pull/3885 and #1352. Together with the bundle changes of this PR, this should work fine. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2131219825 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Windows: Add glib-compile-schemas.exe to GTK bundle (PR #3885)
This is necessary to compile GLib schemas, e.g. when installing plugins with their dependencies. It is not strictly necessary to compile the schemas again on installation as they are already compiled during the bundle creation but it probably wont hurt and might be useful if installing Geany over an existing installation. When the command is executed by the installer a little black console window pops up for a very small fraction of a second. I guess we can live with this. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3885 -- Commit Summary -- * Windows: Add glib-compile-schemas.exe to GTK bundle * Windows: Compile GLib schemas after installation -- File Changes -- M geany.nsi.in (2) M scripts/gtk-bundle-from-msys2.sh (4) -- Patch Links -- https://github.com/geany/geany/pull/3885.patch https://github.com/geany/geany/pull/3885.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3885 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1352 -- Commit Summary -- * Windows: Compile GLib schemas after installation -- File Changes -- M build/geany-plugins.nsi (2) M build/gtk-bundle-from-msys2.sh (1) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1352.patch https://github.com/geany/geany-plugins/pull/1352.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1352 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
@eht16 commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef _WIN32 It's ``` 344Kgeany/ctags/gnu_regex ``` vs ``` 1.4Mctags/gnulib ``` If size matters. Since we use it probably mainly only for Windows, maybe it does not matter. PR https://github.com/universal-ctags/ctags/pull/3054 introduced the gnulib version and argues that the glibc version is too old, related issues also state that it is slow. I can't verify if this is also true for Geany but I would guess since we use uctags' parsers, it might be. @elextr's last comment reads like we already agreed on doing "that update"? :D OTOH it might cause quite some work for a small benefit. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#discussion_r1610394852 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)
Was there any confusion? Now, I'm confused: should this mean bank transfers are only possible in Europe at all or should it mean bank transfers using SEPA are only supported in Europe? -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/50#issuecomment-2121284181 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> > No leftover configuration. I could reproduce this with pastebin.geany.org > > on Linux and Windows. > > After removing the keys from the `[parse]` section in > > `geniuspaste/data/pastebin.geany.org.conf` so that the section remains > > empty in the config, it works. > > What does the section contain?? What's in GIT master: https://github.com/geany/geany-plugins/blob/master/geniuspaste/data/pastebin.geany.org.conf#L12 >because here (Debian) it works with the shipped configuration, even in a fresh >separate install and configuration directory. Weird, here is Debian Testing but Geany is installed from GIT master. > > @b4n what do you think about the schemas compile problem? > > Can't we "simply" run `glib-compile-schemas` during GP (and possibly Geany) > installation? it's e.g. what Linux distros would do (e.g. Debian has a > trigger or whatever for whenever you install a new schema in the system > directory so the compiled schemas are rebuilt) Hmm, this could work. I'll give it a try soon. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121278862 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
@eht16 commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef _WIN32 I couldn't find any reference to this in uctags and so assumed, it's our own copy without upstream. And in https://github.com/geany/geany/pull/3660#issuecomment-2121229911 you said basically the same, didn't you? If I'm not completely wrong, I'd say this is OK except we intend to upstream this code ever again or, as you also said, replace it the gnulib implementation which uctags uses. Though this feels like a whole another story :(. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#discussion_r1607320372 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)
`#ebdfd8` seems fine to me. Let's see what @rovf says. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/71#issuecomment-2121252920 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)
If there are no objections, I would merge this next weekend and update the Wiki accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-2120677402 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)
@b4n they are indeed. I gave `#e4d3c7` it try as a rather lighter brown than before.  This might be better for selection background. Though this makes the braces and the `...` in the varags of the function definition harder to read. I'm really bad at colors :(. @rovf since you reported it and obviously are using this theme, do you have any preference or a better alternative? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/71#issuecomment-2120666462 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
Since the changes in upstream ctags have been pulled into Geany already, the last use was in `ctags/gnu_regex/regex_internal.h` which is our code, if I'm not mistaken. So, what do you think about #3878 to remove the `WIN32` macro completely? CI and manual builds on Windows with Autotools and Meson succeeded. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2120615938 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)
Sorry for the commit spam. I wanted to squash them together but somehow I failed to do so :(. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851#issuecomment-2120599747 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
Closes #3660. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3878 -- Commit Summary -- * Remove custom WIN32 compiler macro in favor of _WIN32 -- File Changes -- M m4/geany-mingw.m4 (1) -- Patch Links -- https://github.com/geany/geany/pull/3878.patch https://github.com/geany/geany/pull/3878.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)
Closed #3702 as completed via #3851. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#event-12866765344 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)
Merged #3851 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851#event-12866765079 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> > When trying to paste some file, Geany crashes for me when it is executed > > natively. I don't know yet why this happens and I didn't manage it yet to > > debug it with gdb. This might be related to my system where I use some > > firewall rules to block unwanted internet access from Windows and also have > > proxy connections configured and after all, it is Windows 7. > > That's pretty bad :) I'd be nice to have more info, and possibly whether it's > new or not. I got it. After much of debugging and mostly fiddling around, I found two causes: - we need two more dependencies in addition to the ones above: "curl" and "zstd" - we need the GLib schemas for "gsettings-desktop-schemas" The letter one is a bit tricky because some of those schemas are installed already in the Geany bundle and there we compile them also to `share/glib-2.0/schemas/gschemas.compiled`. But here we are in G-P and it has its own bundle creation which doesn't know anything about we did for the Geany bundle. If we would compile the schemas in the G-P bundle, we would override whatever was in the Geany bundle. So far, I see only bad options: - in the G-P bundle, we install GLib, GTK and maybe more dependencies to have all schemas we need and then compile them, on installation of the plugins the compiled schema bundle would override the one installed by Geany - in the Geany bundle, we install "gsettings-desktop-schemas" and let them compile as before. This is what I have tried and it works fine. But only as long as we have any dependency in G-P which brings more schemas and those won't get compiled. This is probably such a case where a combined installer with everything included would be easier. > > When I start Geany from within the MSYS2 environment, pasting some file > > works to some extend, at least no crash :). But the response look weird: > > […] The link below "\1" is actually also "\1". > > The `response_str` in `pastebin_parse_response` is > > "https://www.geany.org/p/6vzVo; which is correct. So there seems to be a > > problem with parsing the URL. I don't know if this related to these changes > > or not. > > This is weird, don't you have old leftover configuration for the plugin? This > should only happen if your configuration has a `[parse]` section with an > incorrect `replace` (if there are none, it would then use the default `\1`), > e.g. one referencing a missing group in the `search` pattern. No leftover configuration. I could reproduce this with pastebin.geany.org on Linux and Windows. After removing the keys from the `[parse]` section in `geniuspaste/data/pastebin.geany.org.conf` so that the section remains empty in the config, it works. I think this is not related to the changes here and probably was already broken before. With this change and the additional dependencies mentioned above, I've got it finally working on Windows!!! https://www.geany.org/p/mD5RN/ <- pasted from within Geany on Windows! @b4n what do you think about the schemas compile problem? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2120515090 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F
It can be solved. The mentioned Scintilla API is already available in the GIT master version of Geany. So we need to use it and probably add some new styles for inactive selection text. It still needs someone willing to do it but it's possible. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3874#issuecomment-2120436741 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)
Merged #1339 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#event-12858384938 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)
Tested and works. Thank you! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#issuecomment-2119229141 You are receiving this because you are subscribed to this thread. Message ID:
