[Github-comments] [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-22 Thread Jiří Techet via Github-comments

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3641

-- Commit Summary --

  * Update some paths in HACKING

-- File Changes --

M HACKING (10)

-- Patch Links --

https://github.com/geany/geany/pull/3641.patch
https://github.com/geany/geany/pull/3641.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3641
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2023-10-22 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

a9363bc15d2c66ea91eeec923961f93e41bff216  Add Raku (Perl 6) filetype support 
(lexer and ctags parser)

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3169/files/eb6efa91e364c40a841000ceb3e5fa4463120d56..a9363bc15d2c66ea91eeec923961f93e41bff216
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-10-22 Thread Jiří Techet via Github-comments
> @techee plug in a bigger screen, or better get a theme that doesn't include 
> so much padding. Or both 😀

Or none of these and use my normal solution "don't use Windows" :-) Testing 
Geany was just a good opportunity to install one and half years worth of 
updates...

> Seriously though, compared to my MS Surface tablet (no it doesn't have Geany) 
> it does look quite expanded. The tablet (in landscape) fits many more lines 
> than that, what font size are you using?

The "recommended" scale for the (HiDPI) screen is set to 300% and yes, 
everything is quite big. But when changed to 250%, everything gets really small 
so I don't know how it's calculated.

> Edit: or is the dell a rely small screen?

It's an older model with 16:9 screen, the newer ones have 16:10 so I think that 
would be just enough to fit the preferences dialog there.

Anyway, back to "not using Windows" again...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3605#issuecomment-1774054106
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-osx] On macOS 14 windows sometimes disappear when resized (Issue #48)

2023-10-22 Thread Jiří Techet via Github-comments
While resizing the main window or dialogs like the preferences dialog, they 
disappear at certain sizes:

https://github.com/geany/geany-osx/assets/713965/99af9540-3d8d-4a2c-b43a-0a0b7531cc6b";>

When the cursor is moved over the dialog or the window is minimized and then 
re-shown, it starts showing the dialog elements again.

Based on a report from @frlan, this doesn't happen on macOS 13, the window just 
flickers a bit during the resize.

I've created a bug report upstream here: 
[6178](https://gitlab.gnome.org/GNOME/gtk/-/issues/6178)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/48
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Jiří Techet via Github-comments
> Where is "unknown" set? I pinged you on the assumption it was deep in the 
> bowels of tagmanager?

It's outside the tag manager:

https://github.com/geany/geany/blob/fefef55569424b72e540bafa4bec514e7e2fd6f5/src/symbols.c#L1947

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3632#issuecomment-1774038364
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Jiří Techet via Github-comments
> Perhaps it should show something that is less 
> commonly[1](https://github.com/geany/geany/issues/3632#user-content-fn-1-6f42eafda92f7637071dab0f8cb444e5)
>  a valid scope, perhaps - @techee?

Can be. (I personally don't care much as I use Geany with hidden statusbar.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3632#issuecomment-1774035596
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-20 Thread Jiří Techet via Github-comments
> @techee might be the macOS builds affected by this as well?

I used meson for Geany itself (not usre if it suffers from the same problem) 
and autotools for plugins. In any case I made a completely clean build from 
release tarballs so I hope it's alright. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3620#issuecomment-1773205700
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] symbols panels dont update list after switching files (Issue #3622)

2023-10-20 Thread Jiří Techet via Github-comments
> One more guess: did you pass /tmp/geanytest with --prefix to ./configure? If 
> not, Geany would load the geany.glade file from your old installation and 
> this would explain at least the missing filter entry @techee mentioned.

Really good guess - that could probably explain about everything because with 
the old glade file, weird things will start happening.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3622#issuecomment-1773147711
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] symbols panels dont update list after switching files (Issue #3622)

2023-10-20 Thread Jiří Techet via Github-comments
I don't seem to be able to reproduce the issue here - switching to the other 
file shows its own symbols immediately. I'm also a bit puzzled by how your 
Symbols tab looks like - with Geany 2.0 you should see a filter entry in this 
tab, yet there is none in your case which looks like some older Geany (but the 
message in your screenshot clearly says Geany 2.0):

https://github.com/geany/geany/assets/713965/5905d083-99fb-4eef-937f-b00b426dfec5";>

Also, if you compiled Geany in `/tmp/geanytest` you should check which 
`libgeany.so` is called in your case because the newly built executable could 
load the old library. (But then you are seeing "This is Geany 2.0" so it 
appears the new library was loaded.)

A bit mysterious...

Does the same happen when you run Geany without plugins?  `geany -p`

Also, have you compiled geany-plugins? It seems you did based on the block 
cursor as it seems vimode is running right? Are you sure you compiled it 
against the version you have in `/tmp/geanytest`?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3622#issuecomment-1773121124
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-10-20 Thread Jiří Techet via Github-comments
By the way this is how the settings page looks on my (older) Dell XPS 13 on 
Windows 11:

![Screenshot 2023-10-20 
154048](https://github.com/geany/geany/assets/713965/8ce59fb4-9123-4f58-ae72-0b41de0c3ea3)

The top of the window is aligned with the top of the screen and at the bottom 
one has to guess which button is which to confirm the dialog.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3605#issuecomment-1772806143
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Issue with the terminal of the mac (Issue #3369)

2023-10-19 Thread Jiří Techet via Github-comments
Seems to be fixed in macOS 14.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3369#issuecomment-1771687080
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-osx] MacOSX Autocomplete Bug in Fullscreen Mode (#18)

2023-10-19 Thread Jiří Techet via Github-comments
Closed #18 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/18#event-10716334628
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-osx] MacOSX Autocomplete Bug in Fullscreen Mode (#18)

2023-10-19 Thread Jiří Techet via Github-comments
This should be fixed in Geany 2.0.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/18#issuecomment-1771608558
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] `AddGeanyLexers()` omits the AsciiDoc module since 19336d2 (Issue #3615)

2023-10-19 Thread Jiří Techet via Github-comments
> sorry

Don't worry. Crashes caused by my commits will start appearing _after_ the 
release :-)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3615#issuecomment-1770933340
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix crash opening an AsciiDoc document (PR #3616)

2023-10-19 Thread Jiří Techet via Github-comments
@rdipardo @b4n Thanks! Crash fixed and I agree it's safer to check if we manage 
to get the lexer.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3616#issuecomment-1770927557
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-19 Thread Jiří Techet via Github-comments
> @techee yeah, but here just using the icon name won't solve it, you also need 
> to use the symbolic version for the problematic icons.

Ah, OK, I missed that. But then it's really a problem of the icon theme I think.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3614#issuecomment-1770461334
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-19 Thread Jiří Techet via Github-comments
> although @techee has a point that as the icons that please Adwaita are used 
> by GTK itself, it's likely not to cause much trouble.

I was looking for this page (which I couldn't find yesterday) for stock icons 
and their replacements:

https://developer-old.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-ABOUT:CAPS

This has been advised by GTK since 3.10 and many applications started using 
these icons in the meantime so I think we are pretty safe regarding the icons 
themselves. IMO it's mostly just a matter of using the correct GTK API (plus 
deprecating some plugin API like `ui_image_menu_item_new()` and having a 
substitute for it).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3614#issuecomment-1770413940
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-19 Thread Jiří Techet via Github-comments
> [elextr](https://github.com/elextr) closed this as 
> [completed](https://github.com/geany/geany/issues?q=is%3Aissue+is%3Aclosed+archived%3Afalse+reason%3Acompleted)
>  [9 hours ago](https://github.com/geany/geany/issues/3610#event-10700778434)

Is it fixed though and is this a problem of the used font? I'm not really 
familiar with pango and what exact implications the commit Neil mentioned had 
in Scintilla but it appears it triggered this problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3610#issuecomment-1770384523
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-19 Thread Jiří Techet via Github-comments
> Or we mention it somewhere in the announcement email? @eht16 😆

It's not new to 2.0 though. I just tried Geany 1.38 packaged with Debian 
Bookworm and the issue is there too - yet, nobody is complaining. So maybe 
people use another icon theme or older distributions (or maybe we are the only 
people left still using Geany :-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1770368442
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread Jiří Techet via Github-comments
> This needs to be tested on a wide range of distros, not just Debian, and not 
> just Gnome, Cinnamon, XFCE, etc and Windows.

I don't think it needs to be tested on all thinkable distributions (just tried 
briefly on macOS and it seems to work), it should work the same way everywhere.

On the other hand it's not just a few functions renaming and a few strings 
renaming as I thought it would be and we are just too close to the release (and 
too close to the midnight - at least those of us living in the correct 
hemisphere and time zone ;-) so I'd say better to postpone this after 2.0.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3614#issuecomment-1769422861
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Jiří Techet via Github-comments
At least GTK seems to have a test for these icon names so I think their 
presence is kind of required:

https://gitlab.gnome.org/GNOME/gtk/-/blob/main/testsuite/gtk/check-icon-names.c


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769315846
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Jiří Techet via Github-comments
> Might there be any risk that other themes may not work well with the changed 
> icon references? I guess this is hard to answer; the icon loading mechanism 
> are big mystique to me and so I'm just wondering how much we could break with 
> this change.

Just speculating but `gtk_image_new_from_stock()` has been deprecated since GTK 
3.10 and we now require GTK 3.24 so we shouldn't run into the risk that Geany 
is started on some outdated distribution with an icon theme not supporting the 
names used by `gtk_image_new_from_icon_name()`. It will probably be the other 
way round - that themes support the `-symbolic` names and neglect the old 
naming like in the case of Adwaita.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769301599
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



>  
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
 
-   i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
-   while (TRUE)
+   file_prefs.tab_order_beside = FALSE;
+   file_prefs.tab_order_ltr = TRUE;

Nice! It:
1. Fixes the issue of the reordered tabs
2. Also opens a file from the command-line as the last tab which is much more 
logical than the second tab before
3. Eliminates some ugly code

The code looks good to me as well.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#discussion_r1364508947
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Jiří Techet via Github-comments
> You guys like to have me updating screenshots I guess...

Nah, it could have totally stayed the way it was.

> The screenshot for the prefs dialog with the changed default for the tab 
> label length is updated for 1000 chars, pixels, apples, Euros 😄.

We are aiming for 1000 screenshot updates in this PR :-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1769245236
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Jiří Techet via Github-comments
Regardless of whether it is an Adwaita icon theme bug (I just tried with other 
icon themes and apart from the Adwaita one, all work well), I think if the 
patch is as simple as you propose (possibly covering more instances), we should 
do it - otherwise we might get flooded with bug reports regarding this problem 
and we might have to make a new release because of it anyway.

In fact, `gtk_image_new_from_stock()` is deprecated and we should migrate to 
`gtk_image_new_from_icon_name()` anyway so we can even call it a small step in 
the right direction.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1768577824
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
@techee approved this pull request.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#pullrequestreview-1685192114
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
> Looks good to me based on the code itself and I think it could go to 2.0. I 
> just haven't tested it yet (which I'm going to do now).

I just tested it and, yes, it is fixed, and, yes, the re-arrangement is really 
annoying without this patch so I think it should go to 2.0. (Somehow, I didn't 
have the option to place new tabs behind the current one enabled so I didn't 
notice the problem.)

One unrelated glitch I noticed is that when you close Geany with some files 
opened, and then open it from the command-line with some file as an argument, 
this file is always opened in the second tab - I would expect it to open behind 
the tab which was last active when Geany closed. I expect that when the 
command-line file gets opened, the "current" file is still the first one so it 
appears behind it. But not really a big problem and maybe even not worth fixing 
as users hopefully forget which tab was active when they closed Geany :-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1768537925
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
> @eht16 @techee @elextr I added that to %2.0, but if it's not new since 1.38 
> and you don't feel it's simple enough, we can postpone. It's actually not a 
> problem with the default settings, so it's less bad -- although any sane 
> person would have enabled the problematic option 😁

Looks good to me based on the code itself and I think it could go to 2.0. I 
just haven't tested it yet (which I'm going to do now).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1768460063
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] projectorganizer: ignored directory patterns are not applied to project root paths (Issue #1283)

2023-10-18 Thread Jiří Techet via Github-comments
> But using patterns allows the plugin to autoselect which projects to disable 
> since it can distinguish between project1_dir/remote (which is the slow 
> remote mount) and project2_dir/local (which is fast local storage).

But I think the problem (if I understand it correctly) is, that when you have a 
project `foo` which contains only remote directories and files (imagine 
something like e.g. Geany's root project directories and files), you don't want 
even to list the files inside `foo` and ignore it completely before anything 
gets loaded. But one can overcome it by creating the Geany project one 
directory above so `foo` becomes a single directory of the project and can get 
ignored as a whole.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1283#issuecomment-1768453811
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Jiří Techet via Github-comments
Merged #3612 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#event-10692845087
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Jiří Techet via Github-comments
> BTW, what's the unit of the setting? pixels, chars, apples?

The tooltip of the entry says "Characters to be visible on the tab label of the 
file". While it's a bit inaccurate wrt international text as @b4n noted, it's 
probably fine for "normal" projects and files.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#issuecomment-1768426948
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Jiří Techet via Github-comments
The whole value 9 doesn't fit into the entry which looks ugly and, to 
me, somehow a rounded value like 1000 (which is still sufficient in terms of 
"unlimited" number of characters in a tab) looks more pleasing.

I'm adding this nit-picky change for consideration for 2.0 since it should 
be low-risk, and, also, because once the default value "9" gets 
written to user's config files, it will stay there forever even if we 
change it in future releases.

Now:
Screenshot 2023-10-18 at 10 59 21;

After:
Screenshot 2023-10-18 at 10 59 02;

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3612

-- Commit Summary --

  * Change default tab_label_length from 9 to 1000

-- File Changes --

M src/ui_utils.c (2)

-- Patch Links --

https://github.com/geany/geany/pull/3612.patch
https://github.com/geany/geany/pull/3612.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany-plugins] projectorganizer: ignored directory patterns are not applied to project root paths (Issue #1283)

2023-10-18 Thread Jiří Techet via Github-comments
>  I don't use the plugin's sidebar BTW - I haven't even noticed that there is 
> one till now.

Just curious - what are you using the plugin for then?

> I'd also be fine with an option to disable to plugin/directory traversal on a 
> per project basis 

I can do that - IMO that makes more sense than ignoring the whole project based 
on the ignored directory patterns. To be clear, this option would disable the 
whole plugin completely for certain projects because when ProjectOrganizer 
cannot see files in the project directory, it cannot do anything useful.

> although I actually think projectorganizer does lookups on just the open tabs 
> even without the index from what I've seen in the code

I'm not aware of that, could you point me to the code? In any case, the 
documents in open tabs are opened and parsed by Geany already so the files have 
to be transferred over network anyway.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1283#issuecomment-1767972917
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-17 Thread Jiří Techet via Github-comments
OK to merge so I can test the full macOS build + bundling tomorrow?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3599#issuecomment-1767171751
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



On doc/images/main_window.png:

But I think the message window could be made a tiny bit smaller and the whole 
window could be taller to compensate for this (if Enrico has a big enough 
monitor).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1362748518
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



On doc/images/main_window.png:

I think Enrico wanted to show all the tabs of the message window but 
unfortunately these are the Adwaita's infamous "bloated and scaled up" tabs 
from #3063 so they take a huge amount of space :(.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1362745514
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-17 Thread Jiří Techet via Github-comments
Can you bisect the exact commit where you started getting the blurry text? (I 
don't see anything too bad myself.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3610#issuecomment-1767109517
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Force meson to use the ".so" extension instead of ".dylib" for plugins on macOS (Issue #3606)

2023-10-17 Thread Jiří Techet via Github-comments
Closed #3606 as completed via #3608.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3606#event-10682898784
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] macOS: use ".so" extension for plugins instead of ".dylib" (PR #3608)

2023-10-17 Thread Jiří Techet via Github-comments
Merged #3608 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3608#event-10682898554
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] macOS: use ".so" extension for plugins instead of ".dylib" (PR #3608)

2023-10-17 Thread Jiří Techet via Github-comments
>  it looks good if I believe the docs that a value of [] make it use the 
> default behavior.

Yeah, kind of weird because otherwise it expects a string but it works. I 
tested it on linux, using some crazy suffix in the "darwin" branch and it gets 
ignored and plugins with the "so" extension are created with the [] suffix. So 
I think it works as expected.

Merging.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3608#issuecomment-1767044129
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Jiří Techet via Github-comments
> Well, one issue is that people using the plugin won't be notified about 2.0 
> anyway, as it'll make it older than basically whatever their version is… but 
> we can't do anything about that.

They should get notified because of
```
geany_running.major < geany_current.major
```
The problem was rather the potential "false positive" update notifications of 
the plugin. (I think the biggest problem of the code was to reason about what 
actually it would do.)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1284#issuecomment-1766850406
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Jiří Techet via Github-comments
Merged #1284 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1284#event-10681174674
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] projectorganizer: ignored directory patterns are not applied to project root paths (Issue #1283)

2023-10-17 Thread Jiří Techet via Github-comments
I'm not sure if I understand the problem correctly. "root" for the plugin is
- either the project directory itself, e.g. `/home/techet/projects/geany`
- or added external directories, e.g. `/home/techet/projects/geany-plugins` and 
possibly some more

Since `/home/techet/projects/geany` is the directory containing the project, it 
doesn't make sense to ignore it - you wouldn't see any files in the sidebar if 
you did it. Similarly, it doesn't make sense to do this for external 
directories because you can simply remove those you don't want to see.

So how is your project organized - the mounted directories are mounted 
somewhere inside the project directory itself?

Couldn't the problem rather be in the "Index all project files" settings under 
Project->Properties->Project Organizer which, when enabled, parses all files 
(and possibly loads their full contents over network)?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1283#issuecomment-1766783487
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Jiří Techet via Github-comments
> Indeed the check is wrong in many aspects -- event 0.0.2 would be < then 
> 1.38.1

Here you'll be saved by the copy-paste error of the current code where the last 
digit is ignored ;-).

The current code won't behave as bad as I thought originally because for 
releases the value on the server is the highest number. It would be just in the 
meantime, like now, where we already have 2.0 and server says 1.38 and for the 
code 1.38 > 2.0. Anyway, better to fix and also handle the last digit of the 
version.

> Also, it uses GEANY_VERSION, which is a compile-time thing, so better update 
> your update checker! It could benefit from Geany exposing 
> main_get_version_string() or similar (but probably not under that name).

Yeah, but hopefully most of the time users update geany+plugins at the same 
time.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1284#issuecomment-1766739854
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Jiří Techet via Github-comments
The condition is wrong and for version 2.0 it will constantly report 
there's an update available when upgrading from 1.x (where x > 0).

I had a "visionary" moment regarding possible 2.0 problems and had a 
look at the updatechecker plugin if it handles major versions - id does, but 
wrongly (in addition, there are two identical conditions for the 
"minor" version but the "mini" version check is missing).

I haven't tested this at all (not sure how to test when there's no 
actual release).

@b4n @eht16 I think this or some other variant of this patch should go to 2.0.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1284

-- Commit Summary --

  * updatechecker: Fix logic comparing version numbers

-- File Changes --

M updatechecker/src/updatechecker.c (22)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1284.patch
https://github.com/geany/geany-plugins/pull/1284.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1284
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-17 Thread Jiří Techet via Github-comments
Could at least the part setting the version in meson.build to "2.0" be merged? 
geany-plugins now depend on 2.0 and this prevents a successful build when meson 
is used for Geany.

(I'd like to test if everything is alright for the macOS build before the 
release.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3599#issuecomment-1766474950
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] mscos: use ".so" extension for plugins instead of ".dylib" (PR #3608)

2023-10-17 Thread Jiří Techet via Github-comments
Geany currently loads only plugins with the ".so" extension on macOS. 
This extension is still needed since we use autotools for geany-plugins which 
also generate ".so".

I tested it and it does nothing on linux while on macOS it changes the 
extension correctly to ".so".

Unless it's a big a problem, I'd like to have this merged for 2.0 so I 
can use meson for the build.

Fixes #3606.

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3608

-- Commit Summary --

  * mscos: use ".so" extension for plugins instead of 
".dylib"

-- File Changes --

M plugins/meson.build (6)

-- Patch Links --

https://github.com/geany/geany/pull/3608.patch
https://github.com/geany/geany/pull/3608.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3608
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Jiří Techet via Github-comments
> "improved support of ctags file format" could be mentioned so users know they 
> can use these files and there should be no issues with them.

Maybe also worth mentioning that this is the recommended way of generating tag 
files.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1765934225
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Force meson to use the ".so" extension instead of ".dylib" for plugins on macOS (Issue #3606)

2023-10-17 Thread Jiří Techet via Github-comments
> Maybe 
> https://mesonbuild.com/Reference-manual_functions.html#library_name_suffix

Cool, thanks, that appears to be it, I'll test.

> I was thinking of people who download plugins from the internet, most will be 
> for linux, will they work? I guess so far there has been no complaint, so 
> maybe mac people don't download stuff from the internet?

I bundle most of the plugins (that don't have any too-hard-to-build 
dependencies like webkit) as part of the Geany bundle and they work. I just 
need the plugins from geany-plugins to have the same extension as those that 
are built with Geany. But the above link looks promising.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3606#issuecomment-1765889061
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Force meson to use the ".so" extension instead of ".dylib" for plugins on macOS (Issue #3606)

2023-10-16 Thread Jiří Techet via Github-comments
> Probably should use .dylib on mac

But Geany won't load them. And geany-plugins are still using autotools and 
generate ".so". So I think it would be easier if meson could generate ".so" 
instead of ".dylib" so we'd have the same extension coming both from geany and 
geany-plugins.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3606#issuecomment-1765414788
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Jiří Techet via Github-comments
Great, so I've just re-pushed the squashed version in case someone wants to 
have a look at it. I'll merge it tomorrow (well, actually later today) but feel 
free to merge it earlier if you want.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1765411983
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-10-16 Thread Jiří Techet via Github-comments
Sounds good.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3605#issuecomment-1765401203
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Force meson to use the ".so" extension instead of ".dylib" for plugins on macOS (Issue #3606)

2023-10-16 Thread Jiří Techet via Github-comments
Is there a way to set the file extension for the plugins built using 
`shared_module()`? On macOS it defaults to ".dylib" but Geany expects that the 
extension is ".so" so these plugins don't load. geany-plugins still use 
autotools which produce ".so" those load alright.

Not critical for the release, I'll revert to using autotools for this release 
but it would be good to figure this out for the future.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3606
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Jiří Techet via Github-comments
> Apart the small doc changes, LGTM. 

Committed now.

Alright, I'll wait for @elextr if he has some more comments to the 
documentation, then squash the commits a bit and merge the result afterwards.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1765385506
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

69ad323270615947ae6249c9eab2396c7301cf43  Add a remark about tag file naming 
when 'l' field is used

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/bc49cd2750dacf0bb5f82b7f30d328df79f23e9e..69ad323270615947ae6249c9eab2396c7301cf43
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Fix blooper leading to incorrect variable formatting (PR #3604)

2023-10-16 Thread Jiří Techet via Github-comments
Merged #3604 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3604#event-10671311822
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix blooper leading to incorrect variable formatting (PR #3604)

2023-10-16 Thread Jiří Techet via Github-comments
Ugh, ugly one. I could make some excuses that I took it over from #3542 but I 
missed it completely myself as well. Quick merge to cover the shame.

Thanks, GCC.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3604#issuecomment-1765374954
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread Jiří Techet via Github-comments
> I closed this PR because I think using the official ctags file format is "the 
> future" and that we should ship those with Geany and encourage users to use 
> it. 

Which brings me to one more thing - we should document which format is the 
recommended one. So in #3049 I added one more commit for your red pen:

https://github.com/geany/geany/pull/3049/commits/bc49cd2750dacf0bb5f82b7f30d328df79f23e9e

(I re-shuffled some sections so the diff is bigger than the actual changes, the 
commit message should say what was changed.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#issuecomment-1764512720
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

bc49cd2750dacf0bb5f82b7f30d328df79f23e9e  Document the recommended way of 
generating tags files

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/43ee190b8ff0886a4b55313a7f75ba0da4c6083d..bc49cd2750dacf0bb5f82b7f30d328df79f23e9e
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread Jiří Techet via Github-comments
I closed this PR because I think using the official ctags file format is "the 
future" and that we should ship those with Geany and encourage users to use it. 
The TM tag file format is good for our unit tests so we know to what internal 
value the mapping happened.

> Its ok having the original kind in the file, but how do we know what it 
> originally mapped to so we can invisibly fix changes?

The idea was that if we found the original ctags kind in the file, we would use 
that one and perform the mapping based on the current mapping tables used in 
Geany - the same thing we do already for ctags files. If not found, we'd use 
the "legacy" `tm_tag_...` value stored in the file.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#issuecomment-1764438728
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread Jiří Techet via Github-comments
Closed #3208.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#event-10664842109
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread Jiří Techet via Github-comments
> It would appear that the marker is added to the shared buffer

Oh, I misread the code - I thought it was using `SCI_GETCHARACTERPOINTER` and 
that would be sharing just `gchar *`. But it's `SCI_GETDOCPOINTER` so it's the 
Scintilla's "document" which is shared and it probably stores the information 
about markers too.

So yeah, it's less mysterious now and also probably not something we can fix 
easily.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603#issuecomment-1764363796
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread Jiří Techet via Github-comments
> Do the change markers have to be set up in each Scintilla individually? If so 
> it probably isn't being done on the split because the plugins don't know 
> about its existence (as its a plugin itself).

This is what I would expect - but then the markers shouldn't appear at all. I 
would expect no markers at all in the splitview plugin.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603#issuecomment-1764314699
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread Jiří Techet via Github-comments
For instance, in the screenshot below, the split view shows a circle where the 
git-changebar shows a diff and these markers are life-added/removed as the code 
is edited.

I had a look at the code but I don't understand how it is possible that the 
split window's Scintilla gets affected by the marker change in the main window. 
From what I understand, the split window plugin shares the underlying Scintilla 
buffer with the main window so the changes made in one editor appear in the 
other editor. But this IMO shouldn't affect things like markers because the 
Scintilla instances are separate. 

I kind of understand why it's the white circle - it's the marker number 0 and 
it's not set to the right value for the split window but I don't understand why 
it appears at all. I also tried adding some extra code to git-changebar to make 
sure that e.g. some Geany callback doesn't return the split window's Scintilla 
but it doesn't seem to be the case.

(This is not some recent regression - I tried it with Geany 1.38 and it behaves 
the same way.)

https://github.com/geany/geany/assets/713965/3d8011bf-3ca5-47f6-8a9b-2b8fcd283f02";>


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific theme changes (c79e60f)

2023-10-16 Thread Jiří Techet via Github-comments
If you run into some more problems on Windows, just tell me - I tested it only 
briefly.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/commit/c79e60f1cc0c25106ab803b2b4c9e61926ce12fa#r130082186
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



>   }
-   else if (0 == strcmp(key, "file")) /* static (local) 
tag */
-   tag->local = TRUE;
-   else if (0 == strcmp(key, "signature")) /* arglist */
+   else
+   g_array_append_val(unknown_fields, i);
+   }
+
+   if (!tag->scope)
+   {
+   /* search for scope introduced by scope kind name only 
after going
+* through all extension fields and having tag->lang 
updated when
+* "language" field is present */
+   for (idx = 0; !tag->scope && idx < unknown_fields->len; 
idx++)

> Or make this i, and make the local idx, which might be more idiomatic.

Yes, this is better, done this way.

By the way, how did you do these fancy committable "suggested change" thingies 
at github?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#discussion_r1360465788
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

43ee190b8ff0886a4b55313a7f75ba0da4c6083d  Fix compiler warnings related to loop 
index variables

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/a088e452fbbef8bc08d0bc350265d98e45f048f0..43ee190b8ff0886a4b55313a7f75ba0da4c6083d
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

a088e452fbbef8bc08d0bc350265d98e45f048f0  Fix some compiler warnings

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/4ca132618802e4114c5ee08cbd8a7e55c8609e4c..a088e452fbbef8bc08d0bc350265d98e45f048f0
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-15 Thread Jiří Techet via Github-comments
> I added a few minor changes, including a small behavioral one: the goto popup 
> is again positioned at the mouse if triggered with it, which makes it 
> slightly better for that use case.

Looks good (and works too from what I've tried) - though the previous version 
was just fine too. Apparently I'm not such a popup gourmet :-)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1763488969
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



> +Generating tags files using ctags
+*
+Geany supports loading tag files generated using the ``ctags`` command-line
+tool from the universal-ctags project 
(https://github.com/universal-ctags/ctags).
+Even though Geany should work with any ctags file, it is recommended to use
+certain fields to give Geany some additional information. The recommended 
fields
+are ``EfiklsZSt``, so, for instance, to generate tags for all sources in the 
geany
+directory, one can use::
+
+ctags --fields=EfiklsZSt -o geany.c.tags -R geany
+
+Additional options may be given to the ``ctags`` tool, for instance, to 
restrict
+the generated tags file to some languages only, use certain tag kinds, etc.
+
+Note that when the ``l`` field (specifying the programming language for every 
tag)
+is enabled, the language of the tag is set based on this field instead of the

Thanks, repushed with all the suggested changes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#discussion_r1359877782
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

4ca132618802e4114c5ee08cbd8a7e55c8609e4c  Improve wording of geany.txt

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/bb64384a6af2631ff6f4168118ff27e0dff1c4b5..4ca132618802e4114c5ee08cbd8a7e55c8609e4c
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific theme changes (c79e60f)

2023-10-15 Thread Jiří Techet via Github-comments
Yeah, done now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/commit/c79e60f1cc0c25106ab803b2b4c9e61926ce12fa#r130019403
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)

2023-10-14 Thread Jiří Techet via Github-comments
If this PR is going to get merged, I'd just suggest also applying the following 
patch on top of the theme.

https://github.com/geany/geany-osx/blob/master/prof_gnome_windows_changes.patch

It changes text colors to #00 instead of the slightly gray which is native 
for macOS, and also reduces the size of the status bar.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3129#issuecomment-1763170674
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific changes to Prof-Gnome (PR #35)

2023-10-14 Thread Jiří Techet via Github-comments
Closed #35.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/pull/35#event-10655784846
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)

2023-10-14 Thread Jiří Techet via Github-comments
> How "slow" is it in reality? After all tags are only read once, even seconds 
> is likely to be acceptable.

I just tested it and it's actually about the same both with and without 
`scope:`. Roughly 1 million tags per second.

So while I still think the patch is worth applying, it can wait after 2.0.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3592#issuecomment-1763059572
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-14 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



> +Generating tags files using ctags
+*
+Geany supports loading tag files generated using the ``ctags`` command-line
+tool from the universal-ctags project 
(https://github.com/universal-ctags/ctags).
+Even though Geany should work with any ctags file, it is recommended to use
+certain fields to give Geany some additional information. The recommended 
fields
+are ``EfiklsZSt``, so, for instance, to generate tags for all sources in the 
geany
+directory, one can use::
+
+ctags --fields=EfiklsZSt -o geany.c.tags -R geany
+
+Additional options may be given to the ``ctags`` tool, for instance, to 
restrict
+the generated tags file to some languages only, use certain tag kinds, etc.
+
+Note that when the ``l`` field (specifying the programming language for every 
tag)
+is enabled, the language of the tag is set based on this field instead of the

Oh, my response from yesterday disappeared somewhere. So once again - you mean 
whether to use the word "tag" or "symbol" here, right? I checked geany.txt and 
we only use "tags" in "tags file" but never talk about tags themselves so 
probably "symbol" is the correct one here. I've modified it to:

```
Note that when the ``l`` field (specifying the programming language) is enabled,
the language of all symbols is set based on the value of this field instead of
the language specified in the extension of the tags file.
```

Does it sound OK?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#discussion_r1359479477
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] ctags: Matlab: ignore defs within block comments and allow spaces before function defs (PR #3563)

2023-10-14 Thread Jiří Techet via Github-comments
> I need to understand how to integrate the parsing function with the rest of 
> ctags

I think the only thing you have to do is to overwrite the existing regex-based 
parser with the code of this parser. And then have a look at the unit tests to 
see what fails.

> I'd consider at least pulling https://github.com/geany/geany/pull/3358

Done, thanks!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3563#issuecomment-1762773338
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] ctags: Matlab: generate tag with only the function name, not the function name plus arguments (PR #3358)

2023-10-14 Thread Jiří Techet via Github-comments
I had a look at the code and it appears to do the right thing. The changes seem 
simple enough that they shouldn't cause any problems - so even though we are 
close to release, I'm merging this.

Thanks!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3358#issuecomment-1762771062
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] ctags: Matlab: generate tag with only the function name, not the function name plus arguments (PR #3358)

2023-10-14 Thread Jiří Techet via Github-comments
Merged #3358 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3358#event-10652554773
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Jiří Techet via Github-comments
> Thanks a lot for debugging this up to that point!

Essential plugin, life would be unbearable without it :-).

>  I somehow didn't notice this until fairly recently, and was puzzled (and 
> frightened) at what it could be, yet didn't have time to dig in.

I was worried it could be some "unsolvable" conflict with the changebar that is 
now part of Scintilla. But then all the printfs I added seemed to return the 
right value and then I displayed line numbers in the Scintilla popup and it was 
clear it wasn't set correctly.

> I don't see a problem re-asking for the line; although at some point I'll try 
> and understand what changed in Scintilla that would lead to this.

Yeah, who knows.

It's actually kind of surprising that it works now because 
`SCI_POINTXFROMPOSITION` didn't work when I removed `SCI_SETFIRSTVISIBLELINE` 
in front of the size request and moved it behind - so `SCI_POINTXFROMPOSITION` 
works only for the displayed editor area but in this case it isn't displayed 
yet and `sci` has some who-knows-what size before the size request. But I don't 
know how this could be fixed.

Anyway, good, it works now, the world seems to be saved for a while :-)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1280#issuecomment-1762210813
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



> @@ -878,6 +878,10 @@ get_widget_for_buf_range (GeanyDocument *doc,
MIN (width + 2, alloc.width),
MIN (height + 1, alloc.height));
   
+  /* Size request seems to scroll Scintilla view so we have to re-set visible 
lines again */
+  scintilla_send_message (sci, SCI_SETENDATLASTLINE, 0, 0);

No, it doesn't seem to be necessary, I just copied the two lines above. 
Repushed without this line.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1280#discussion_r1358803186
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

9ad218bcdd6f57550bbcc2932c01bc71d89f2316  git-changebar: Re-set first visible 
line after Scintilla size request

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1280/files/03f175bf5b1611b1e714ec2fde1d9ef773b08854..9ad218bcdd6f57550bbcc2932c01bc71d89f2316
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] ctags: Matlab: ignore defs within block comments and allow spaces before function defs (PR #3563)

2023-10-13 Thread Jiří Techet via Github-comments
@cousteaulecommandant Sorry for the late response :-(

If it's not a big problem (and it shouldn't be, you should be able to simulate 
what the regex parser does), I'd suggest that you update your parser with all 
features that the universal-ctags regex parser has (otherwise it won't be 
accepted) and then submit it to the universal-ctags project. The maintainer is 
very responsive and I don't expect he wouldn't accept it. Or maybe even better, 
open an issue there and ask there and ask first to avoid some unnecessary work.

A readline-based parser will always be a compromise - it's easy to create 
something functional quickly but the more and more language features you add, 
the more messy it will be. So if you want to create some more complex parser, 
you'd have to create a token-based parser.

>From my point of view, the Matlab parser in Geany fulfilled its purpose - it 
>attracted a Matlab developer, you, who also knows C and who is able to improve 
>it. Done :-). So I think in the next time we update ctags parsers, I'll grab 
>whatever parser there is in the ctags project - if you manage to get your 
>parser to ctags afterwards, just ping me, and I'll grab it for Geany.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3563#issuecomment-1761994692
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Update to Scintilla 4.x (#2519)

2023-10-13 Thread Jiří Techet via Github-comments
Closed #2519 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2519#event-10646868613
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



> + if (sci_get_line_from_position(sci, pos_next) == line)
+   char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;

> I went ahead and implemented the more basic version that is similar to what 
> was there but don't produce incorrect results on the wrapping corner case. So 
> I'm happier, and you're not too unhappy because it's not as complicated as it 
> could be 

The best of both worlds indeed, LGTM :-)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#discussion_r1358313969
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3597)

2023-10-13 Thread Jiří Techet via Github-comments
Works for me (tested both with and without a git repo) and I think it's cleaner 
than https://github.com/geany/geany/pull/3578. So I vote for merging this 
version.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3597#issuecomment-1761550314
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



>  case-sensitive.  This helps Geany to read the file properly. If this
 line is missing, Geany tries to auto-detect the used format but this
-might fail.
+might fail.  Tag files using the CTags format should be left unmodified in the

OK.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#discussion_r1358256408
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



> @@ -1689,12 +1689,13 @@ Global tags files can have three different formats:
 * Pipe-separated format
 * CTags format
 
-The first line of global tags files should be a comment, introduced
-by ``#`` followed by a space and a string like ``format=pipe``,
-``format=ctags`` or ``format=tagmanager`` respectively, these are
+For the tagmanager or pipe-separated format, the first line of global tag files
+should be a comment, introduced by ``#`` followed by a space and a string like

Will do (also not mine ;-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#discussion_r1358256236
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request.



> @@ -1785,6 +1786,25 @@ This works basically the same as on other platforms::
 "c:\program files\geany\bin\geany" -g c:\mytags.php.tags 
c:\code\somefile.php
 
 
+Generating tags files using ctags
+*
+Geany supports loading tag files generated using the ``ctags`` command-line
+tool from the universal-ctags project 
(https://github.com/universal-ctags/ctags).
+Even though Geany should work with any ctags file, it is recommended to use
+certain fields to give Geany some additional information. The recommended 
fields
+are ``EfiklsZSt``, so, for instance, to generate tags for all sources in the 
geany

But there should still be comma after "so", right?

I will also renamed the "geany" directory to something like "my_project" to 
avoid possible confusion with the geany binary.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#discussion_r1358254677
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Support parsing scopeKind/p of ctags files (Issue #3598)

2023-10-12 Thread Jiří Techet via Github-comments
When given, it specifies the kind introducing the scope information. May be 
another way to speed up parsing of scope in addition to the sZ field.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3598
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)

2023-10-12 Thread Jiří Techet via Github-comments
@elextr Would you mind having a look at the update of geany.txt I made in 
https://github.com/geany/geany/pull/3049 if it looks alright to you?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3592#issuecomment-1760450881
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

bb64384a6af2631ff6f4168118ff27e0dff1c4b5  Update geany.txt with ctags usage for 
generating tag files

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/d945009828e3c36b366a42448b009ea66f784090..bb64384a6af2631ff6f4168118ff27e0dff1c4b5
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread Jiří Techet via Github-comments
> I don't see how it should get better by postponing to 2.1.

OK, I just thought it kind of died because of different opinions but I'm all 
for it myself.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760445091
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
> At least we can easily change the PHP tags generation script when needed.

But we still need to support user's tag files possibly generated by older ctags 
versions so it should stay there for some time even if we update the php parser.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1760381748
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
@techee pushed 3 commits.

e1ae976a7284d59f24b387825e967a2e6794a330  Add ctags 'readtags' library to allow 
us parse ctags files
d364c30e7973ceaf387f8c64211d3980a462f90b  Fix compilation when TM_DEBUG is 
defined
d945009828e3c36b366a42448b009ea66f784090  Use the readtags library to parse 
ctags files

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/c5bfe6ace392f4f8c925de1fcb0e22efee94aed5..d945009828e3c36b366a42448b009ea66f784090
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread Jiří Techet via Github-comments
Yeah, I'm afraid it's time to create the 2.1 milestone ;-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760342824
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)

2023-10-12 Thread Jiří Techet via Github-comments
> But if uctags still generates the parent_kind:A::B::C form the problem will 
> still apply in the case of ctags generated files without sZ so needs to still 
> be able to read those files. And document the ctags option as recommended 
> somewhere.

The documentation is a good point, I'll write something.

> How "slow" is it in reality? After all tags are only read once, even seconds 
> is likely to be acceptable.

I haven't benchmarked that, it probably just "doesn't feel right" than being 
some real problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3592#issuecomment-1760097675
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
> Good catch. Maybe it'd be worth submitting an update to that parser to be 
> more in line with the convention as well.

We'll still need the "unknown" check to support older ctags binaries 
unfortunately.

OK to rebase this branch on top of master so it can be more easily tested with 
the php and py tag files? I'd also squash the commits a bit.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1760091651
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-12 Thread Jiří Techet via Github-comments
After updating to Scintilla 5.3.7 the Scintilla popup with the diff against git 
shows the wrong number.

It seems that gtk_widget_set_size_request() scrolls Scintilla view so despite 
it was set previously, it isn't set correctly after this call and has to be 
re-set.

Note that the call to SCI_SETFIRSTVISIBLELINE has to stay at the original 
location too, otherwise subsequent calculation using SCI_POINTXFROMPOSITION 
doesn't work because the line may not be visible.

@b4n Does this look OK to you? Maybe there's a better way to fix this 
problem so take this only as a hint where the problem is.

Fixes #1279 
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1280

-- Commit Summary --

  * git-changebar: Re-set first visible line after Scintilla size request

-- File Changes --

M git-changebar/src/gcb-plugin.c (4)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1280.patch
https://github.com/geany/geany-plugins/pull/1280.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1280
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-11 Thread Jiří Techet via Github-comments
Maybe should I also grab the latest version of the libreadtags library for this 
PR? I noticed you also submitted some patch to it in the spring.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1758610973
You are receiving this because you are subscribed to this thread.

Message ID: 

<    4   5   6   7   8   9   10   11   12   13   >