Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
And since @codebrainz already did the work, let's continue with #2618. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-708017985
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
> I would just leave it as it is - this is not something worth ifdefs or any > extra code IMO. Too late, I already created follow-up #2618, which puts it in a self-contained utils function, making the main code flow cleaner than in this PR and allowing support for older GLibs and MacOS/others. There was already `#ifdef` in there, now there's some more, which eventually will be able to mostly be removed. One could argue it's overkill for such a trivial "feature", but Geany's issue tracker has a chronic problem of people not reporting OS/version, so making that easier is, IMO, worth the extra `#ifdef`-ed code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-707256404
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
> Agree. It might be good to just #ifdef this code out on Macos, since it's not > working at all. > Or just #ifdef it to say something like "Unidentified Macos version" so at > least that much is obvious. I would just leave it as it is - this is not something worth ifdefs or any extra code IMO. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-707151162
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Or just #ifdef it to say something like "Unidentified Macos version" so at least that much is obvious. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-706621385
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
> Would be probably better to update glib itself... Definitely would be better to upstream, but probably too much trouble. > But I don't think it's something too critical to have. Agree. It might be good to just `#ifdef` this code out on Macos, since it's not working at all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-706594956
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
> I guess we could add a check for Macos in our code and make it output > something a little more useful. Would be probably better to update glib itself, otherwise we have to include macos headers and link against macos frameworks by ourselves which we don't have to do now. But I don't think it's something too critical to have. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-706590814
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Thanks for testing. You're right, it looks like [`g_get_os_info()`](https://gitlab.gnome.org/GNOME/glib/-/blob/497ea1a420801d58dc093af58a0034bcf0fd4094/glib/gutils.c#L1492) only supports `G_OS_INFO_KEY_NAME` on Macos. I guess we could add a check for Macos in our code and make it output something a little more useful. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-706586585
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Just for reference, I get ``` 19:29:17: Geany INFO: GTK 3.24.20, GLib 2.66.0 19:29:17: Geany INFO: OS: Unknown (Unknown) ``` on macOS - `g_get_os_info()` is probably not implemented there. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-706585365
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Merged #2498 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#event-3836857236
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
@codebrainz pushed 1 commit. 64269774d7c8139bdb12f43d78a631acf2b700ea Show OS info in debug messages -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2498/files/83c61f94fa2d6f7eb124ced76ae6942bbf09de00..64269774d7c8139bdb12f43d78a631acf2b700ea
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
I added a commit to update as discussed. Output looks like this now: ``` Geany-INFO: 07:02:22.879: Geany 1.37 (git >= 27e81be20), en_CA.UTF-8 Geany-INFO: 07:02:22.879: GTK 3.24.20, GLib 2.64.3 Geany-INFO: 07:02:22.879: OS: Ubuntu 20.04.1 LTS (focal) ``` TODO: squash commits and fast-forward when merging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-683295005
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
@codebrainz pushed 1 commit. 83c61f94fa2d6f7eb124ced76ae6942bbf09de00 Show only pretty and code names -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2498/files/ff9c5ac15e020e27321fbb25b83b8d8d57d1e737..83c61f94fa2d6f7eb124ced76ae6942bbf09de00
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
@codebrainz I guess we could go ahead even without MacOS results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-678778960
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Sounds good to me to use mainly `G_OS_INFO_KEY_PRETTY_NAME`. I still would add `G_OS_INFO_KEY_VERSION_CODENAME` (in braces or so). E.g. for Ubuntu, this gives the version like `20.04 LTS` *and* the codename `focal` which might be handy and saves some tedious version vs. codename lookups. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-629480146
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
> The result of g_get_os_info must be freed even it is not explicitly stated in
> the docs
I assumed based on the lack of `[transfer full]` or whatever annotation that it
wasn't required, since basically every binding will have a leak otherwise, but
you are correct and it's just a bug that the annotation is missing and all
automatically generated bindings will leak.
> Output on ArchLinux:
> Output on Windows 7:
Thanks for testing! Based on the output on Ubuntu, Arch and Windows so far, I
suggest we go with only printing the "pretty name", like just this one printf:
```c
geany_debug("OS: %s", get_os_info_field(G_OS_INFO_KEY_PRETTY_NAME));
```
Sound good?
@techee would it be possible that you could test this on Macos? I'm not sure
how involved that would be, if it's too much trouble, no worries.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2498#issuecomment-629428177
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Yay! I agree also that the pretty name is redundant. The result of `g_get_os_info` must be freed even it is not explicitly stated in the docs (https://gitlab.gnome.org/GNOME/glib/-/blob/master/glib/gutils.c#L1507). Output on ArchLinux: ``` 10:08:55: Geany INFO: OS Information: 10:08:55: Geany INFO: Name : Arch Linux (arch/) 10:08:55: Geany INFO: Pretty Name: Arch Linux 10:08:55: Geany INFO: Version: () ``` Output on Windows 7: ``` 22:50:54: Geany INFO: OS Information: 22:50:54: Geany INFO: Name : Windows (windows/) 22:50:54: Geany INFO: Pretty Name: Windows 7 SP17Vista SP2Vista SP1VistaXP SP3XP SP2XP SP1XP 22:50:54: Geany INFO: Version: 7 SP17Vista SP2Vista SP1VistaXP SP3XP SP2XP SP1XP (7_sp17vista_sp2vista_sp1vistaxp_sp3xp_sp2xp_sp1xp) ``` The missing version on ArchLinux is OK because it's a rolling release and `/etc/os-release` doesn't have any VERSION key at all. I'm not sure about the weird looking version on Windows, either it is just my installation or it usually looks like this ... :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-629099805
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Yeah, I've only tested on Ubuntu 20.04 so not sure, but if it's consistent, I agree that name/version is enough or even just pretty name really. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-626242604
Re: [Github-comments] [geany/geany] Show OS info in debug messages (#2498)
LGBI, can't test ATM due to the requirement for Glib 2.64. Pending testing it I might suggest making it one line (in printf) "OS: %s %s", name, version and leave Pretty Name off. But I guess it depends on what it looks like on various systems, for example will Linux Mint be only in Pretty name and Ubuntu be in Name or how else will derived distros be shown? TBD also when anyone can try it on Windows and OSX. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498#issuecomment-626164976
[Github-comments] [geany/geany] Show OS info in debug messages (#2498)
This PR conditionally uses newer GLib API to get information about the OS and to print it in with the existing debug messages. I dont really have a preference on the formatting of the info, this PR is tested against own-built Geany on Ubuntu 20.04. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2498 -- Commit Summary -- * Show OS info in debug messages -- File Changes -- M src/libmain.c (22) -- Patch Links -- https://github.com/geany/geany/pull/2498.patch https://github.com/geany/geany/pull/2498.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2498
