subject:"\[Gluster\-devel\] NFS Ganesha fails to export a volume"

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-20 Thread Strahil Nikolov

Hm...

In such case , we got only 1 real problem left -> ocf:heartbeat:portblock 
supports only IPTABLES.
In my EL8 tests , NFS-Ganesha works if firewalld is disabled and I install 
iptables & iptables-services, yet this is highly unrecommended by Red Hat.

I got a feature request opened 
https://github.com/ClusterLabs/resource-agents/issues/1577 , but I believe that 
we also need a bugzilla entry on bugzilla.redhat.com .What do you think about ?

I do not know other Distro that is using NFTABLES by default .


Any advise on that ?

Best Regards,
Strahil Nikolov







В петък, 20 ноември 2020 г., 04:55:26 Гринуич+2, Shwetha Acharya 
 написа: 





Thanks for bringing this to our attention @Strahil

[1] and [2]  were discretely worked handling different issues at the same span 
of time. Merging [2] was to be done before [1], which was done otherwise. 

[1] https://review.gluster.org/#/c/glusterfs/+/23039/
[2] https://review.gluster.org/#/c/glusterfs/+/22636/

Regards,
Shwetha

On Wed, Nov 18, 2020 at 12:41 PM Ravishankar N  wrote:
> 
> On 18/11/20 12:17 pm, Strahil Nikolov wrote:
>> Nope, it's a deeper s**t.
>> I had to edit the ".spec.in" file so it has Source0 point to local tar.gz.
>> The I edit the requires in both ".spec" & ".spec.in" and also I had to 
>> remove an obsolete stanza in the glusterfs section.
>>
>> In the end, I got the source - extracted, copied the spec & spec.in , and 
>> then tar.gz-ed again and put it into the dir.
>>
>> Only then the rpms were properly built.
>>
>> The proposed patch is fixing the issue.
> Thanks for confirming!
>>
>> Why do we have line 285 in 
>> https://raw.githubusercontent.com/gluster/glusterfs/devel/glusterfs.spec.in ?
>>
>> I guess I need to open 2 issues for the glusterfs:
>> - that obsolete stanza is useless
> 
> Using git blame points me to 
> https://github.com/gluster/glusterfs/commit/f9118c2c9389e0793951388c2d69ce0350bb9318.
>  
> Adding Shwetha to confirm if the change was intended.
> 
> -Ravi
> 
>>
>>
>> Best Regards,
>> Strahil Nikolov
>>
>>
>>
>> В вторник, 17 ноември 2020 г., 14:16:36 Гринуич+2, Ravishankar N 
>>  написа:
>>
>>
>>
>>
>>
>> Hi Strahil,
>>
>> I would have imagined editing the 'Requires' section in
>> glusterfs.spec.in would have sufficed. Do you need rpms though? A source
>> install is not enough?
>>
>> Regards,
>> Ravi
>>
>> On 17/11/20 5:32 pm, Strahil Nikolov wrote:
>>> Hi Ravi,
>>>
>>>
>>> Any idea how to make the glusterfs-ganesha.x86_64 require resource-agents 
>>> >= 4.1.0 (instead of 4.2.0) ?
>>> I 've replaced every occurance I found and still it tries to grab 
>>> resource-agents 4.2 (which is not available on EL8).
>>>
>>> Best Regards,
>>> Strahil Nikolov
>>>
>>>
>>>
>>>
>>>
>>>
>>> В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar 
>>> N  написа:
>>>
>>>
>>>
>>>
>>>
>>>
>>> I am surprised too that it wasn't caught earlier.
>>>
>>>
>>> Steps:
>>>
>>> 1. Clone the gluster repo
>>>
>>> 2. Compile  the 
>>> sourcehttps://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/
>>>
>>> 3. Make the changes (in a different branch if you prefer), compile again 
>>> and install
>>>
>>> 4.  Test it out:
>>>
>>> [root@linuxpad glusterfs]#  gluster v create testvol  
>>> 127.0.0.2:/home/ravi/bricks/brick{1..2} force
>>> volume create: testvol: success: please start the volume to access data
>>> [root@linuxpad glusterfs]#
>>> [root@linuxpad glusterfs]# gluster v start testvol
>>> volume start: testvol: success
>>> [root@linuxpad glusterfs]#
>>> [root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
>>> volume set: failed: The option nfs-ganesha should be enabled before setting 
>>> ganesha.enable.
>>> [root@linuxpad glusterfs]#
>>>      
>>>
>>> I just tried the change and it looks like some new error shows up. Not too 
>>> familiar with these settings; I will need to debug further.
>>>
>>> Thanks,
>>>
>>> Ravi
>>>
>>>
>>> On 16/11/20 4:05 pm, Strahil Nikolov wrote:
>>>
>>>
      I can try to help with the testing (I'm quite new to that).
 Can someone share documentation of that process ?

 yet we have another problem -> ganesha is deployed with 
 ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses 
 NFTABLES ...

 Best Regards,
 Strahil Nikolov






 В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv 
 Kaul  написа:







 On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  
 wrote:

>      On 15/11/20 8:24 pm, Strahil Nikolov wrote:
>
>>      Hello All,
>>
>> did anyone get a chance to look 
>> athttps://github.com/gluster/glusterfs/issues/1778  ?
>>
> A look at
> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
> seems to indicate this could be due to a typo error. Do you have a
> source install where you can apply this simple diff and see if it fixes
> the issue?

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-19 Thread Shwetha Acharya

Thanks for bringing this to our attention @Strahil

[1] and [2]  were discretely worked handling different issues at the same
span of time. Merging [2] was to be done before [1], which was done
otherwise.

[1] https://review.gluster.org/#/c/glusterfs/+/23039/
[2] https://review.gluster.org/#/c/glusterfs/+/22636/

Regards,
Shwetha

On Wed, Nov 18, 2020 at 12:41 PM Ravishankar N 
wrote:

>
> On 18/11/20 12:17 pm, Strahil Nikolov wrote:
> > Nope, it's a deeper s**t.
> > I had to edit the ".spec.in" file so it has Source0 point to local
> tar.gz.
> > The I edit the requires in both ".spec" & ".spec.in" and also I had to
> remove an obsolete stanza in the glusterfs section.
> >
> > In the end, I got the source - extracted, copied the spec & spec.in ,
> and then tar.gz-ed again and put it into the dir.
> >
> > Only then the rpms were properly built.
> >
> > The proposed patch is fixing the issue.
> Thanks for confirming!
> >
> > Why do we have line 285 in
> https://raw.githubusercontent.com/gluster/glusterfs/devel/glusterfs.spec.in
>  ?
> >
> > I guess I need to open 2 issues for the glusterfs:
> > - that obsolete stanza is useless
>
> Using git blame points me to
>
> https://github.com/gluster/glusterfs/commit/f9118c2c9389e0793951388c2d69ce0350bb9318.
>
> Adding Shwetha to confirm if the change was intended.
>
> -Ravi
>
> >
> >
> > Best Regards,
> > Strahil Nikolov
> >
> >
> >
> > В вторник, 17 ноември 2020 г., 14:16:36 Гринуич+2, Ravishankar N <
> ravishan...@redhat.com> написа:
> >
> >
> >
> >
> >
> > Hi Strahil,
> >
> > I would have imagined editing the 'Requires' section in
> > glusterfs.spec.in would have sufficed. Do you need rpms though? A source
> > install is not enough?
> >
> > Regards,
> > Ravi
> >
> > On 17/11/20 5:32 pm, Strahil Nikolov wrote:
> >> Hi Ravi,
> >>
> >>
> >> Any idea how to make the glusterfs-ganesha.x86_64 require
> resource-agents >= 4.1.0 (instead of 4.2.0) ?
> >> I 've replaced every occurance I found and still it tries to grab
> resource-agents 4.2 (which is not available on EL8).
> >>
> >> Best Regards,
> >> Strahil Nikolov
> >>
> >>
> >>
> >>
> >>
> >>
> >> В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar N<
> ravishan...@redhat.com>  написа:
> >>
> >>
> >>
> >>
> >>
> >>
> >> I am surprised too that it wasn't caught earlier.
> >>
> >>
> >> Steps:
> >>
> >> 1. Clone the gluster repo
> >>
> >> 2. Compile  the sourcehttps://
> docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/
> >>
> >> 3. Make the changes (in a different branch if you prefer), compile
> again and install
> >>
> >> 4.  Test it out:
> >>
> >> [root@linuxpad glusterfs]#  gluster v create testvol  
> >> 127.0.0.2:/home/ravi/bricks/brick{1..2}
> force
> >> volume create: testvol: success: please start the volume to access data
> >> [root@linuxpad glusterfs]#
> >> [root@linuxpad glusterfs]# gluster v start testvol
> >> volume start: testvol: success
> >> [root@linuxpad glusterfs]#
> >> [root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
> >> volume set: failed: The option nfs-ganesha should be enabled before
> setting ganesha.enable.
> >> [root@linuxpad glusterfs]#
> >>
> >>
> >> I just tried the change and it looks like some new error shows up. Not
> too familiar with these settings; I will need to debug further.
> >>
> >> Thanks,
> >>
> >> Ravi
> >>
> >>
> >> On 16/11/20 4:05 pm, Strahil Nikolov wrote:
> >>
> >>
> >>>  I can try to help with the testing (I'm quite new to that).
> >>> Can someone share documentation of that process ?
> >>>
> >>> yet we have another problem -> ganesha is deployed with
> ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses
> NFTABLES ...
> >>>
> >>> Best Regards,
> >>> Strahil Nikolov
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul<
> yk...@redhat.com>  написа:
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N
> wrote:
> >>>
>   On 15/11/20 8:24 pm, Strahil Nikolov wrote:
> 
> >  Hello All,
> >
> > did anyone get a chance to look athttps://
> github.com/gluster/glusterfs/issues/1778  ?
> >
>  A look at
> 
> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
>  seems to indicate this could be due to a typo error. Do you have a
>  source install where you can apply this simple diff and see if it
> fixes
>  the issue?
> 
> >>> I think you are right - I seem to have introduced it as part ofhttps://
> github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
> - my bad.
> >>>
> >>> However, it was merged ~1 year ago, and no one has complained thus
> far... :-/
> >>> 1. Is no one using NFS Ganesha?
> >>> 2. We are lacking tests for NFS Ganesha - code coverage indicates this
> path is not covered.
> >>>
> >>> Y.
> >>>
> >>>
> 
>  diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-18 Thread Strahil Nikolov

Nope, it's a deeper s**t.
I had to edit the ".spec.in" file so it has Source0 point to local tar.gz.
The I edit the requires in both ".spec" & ".spec.in" and also I had to remove 
an obsolete stanza in the glusterfs section.

In the end, I got the source - extracted, copied the spec & spec.in , and then 
tar.gz-ed again and put it into the dir.

Only then the rpms were properly built.

The proposed patch is fixing the issue.


Why do we have line 285 in 
https://raw.githubusercontent.com/gluster/glusterfs/devel/glusterfs.spec.in ?

I guess I need to open 2 issues for the glusterfs:
- that obsolete stanza is useless


Best Regards,
Strahil Nikolov



В вторник, 17 ноември 2020 г., 14:16:36 Гринуич+2, Ravishankar N 
 написа: 





Hi Strahil,

I would have imagined editing the 'Requires' section in 
glusterfs.spec.in would have sufficed. Do you need rpms though? A source 
install is not enough?

Regards,
Ravi

On 17/11/20 5:32 pm, Strahil Nikolov wrote:
> Hi Ravi,
>
>
> Any idea how to make the glusterfs-ganesha.x86_64 require resource-agents >= 
> 4.1.0 (instead of 4.2.0) ?
> I 've replaced every occurance I found and still it tries to grab 
> resource-agents 4.2 (which is not available on EL8).
>
> Best Regards,
> Strahil Nikolov
>
>
>
>
>
>
> В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar 
> N  написа:
>
>
>
>
>
>
> I am surprised too that it wasn't caught earlier.
>
>
> Steps:
>
> 1. Clone the gluster repo
>
> 2. Compile  the 
> sourcehttps://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/
>
> 3. Make the changes (in a different branch if you prefer), compile again and 
> install
>
> 4.  Test it out:
>
> [root@linuxpad glusterfs]#  gluster v create testvol  
> 127.0.0.2:/home/ravi/bricks/brick{1..2} force
> volume create: testvol: success: please start the volume to access data
> [root@linuxpad glusterfs]#
> [root@linuxpad glusterfs]# gluster v start testvol
> volume start: testvol: success
> [root@linuxpad glusterfs]#
> [root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
> volume set: failed: The option nfs-ganesha should be enabled before setting 
> ganesha.enable.
> [root@linuxpad glusterfs]#
>    
>
> I just tried the change and it looks like some new error shows up. Not too 
> familiar with these settings; I will need to debug further.
>
> Thanks,
>
> Ravi
>
>
> On 16/11/20 4:05 pm, Strahil Nikolov wrote:
>
>
>>    I can try to help with the testing (I'm quite new to that).
>> Can someone share documentation of that process ?
>>
>> yet we have another problem -> ganesha is deployed with 
>> ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses 
>> NFTABLES ...
>>
>> Best Regards,
>> Strahil Nikolov
>>
>>
>>
>>
>>
>>
>> В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv 
>> Kaul  написа:
>>
>>
>>
>>
>>
>>
>>
>> On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  
>> wrote:
>>
>>>    On 15/11/20 8:24 pm, Strahil Nikolov wrote:
>>>
    Hello All,

 did anyone get a chance to look 
 athttps://github.com/gluster/glusterfs/issues/1778  ?

>>> A look at
>>> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
>>>   
>>> seems to indicate this could be due to a typo error. Do you have a
>>> source install where you can apply this simple diff and see if it fixes
>>> the issue?
>>>
>> I think you are right - I seem to have introduced it as part 
>> ofhttps://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
>>   - my bad.
>>
>> However, it was merged ~1 year ago, and no one has complained thus far... :-/
>> 1. Is no one using NFS Ganesha?
>> 2. We are lacking tests for NFS Ganesha - code coverage indicates this path 
>> is not covered.
>>
>> Y.
>>
>>
>>>      
>>> diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>>> b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>>> index 558f04fb2..d7bf96adf 100644
>>> --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>>> +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>>> @@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char
>>> **op_errstr)
>>>    }
>>>    } else if (len_strcmp(key, keylen, "ganesha.enable")) {
>>>    key_matched = _gf_true;
>>> -    if (!strcmp(value, "off") == 0) {
>>> +    if (strcmp(value, "off") == 0) {
>>>    ret = ganesha_manage_export(dict, "off", _gf_true,
>>> op_errstr);
>>>    if (ret)
>>>    goto out;
>>>
>>> Thanks,
>>>
>>> Ravi
>>>
    It's really strange that NFS Ganesha has ever passed the tests.
 How do we test NFS Ganesha exporting ?

 Best Regards,
 Strahil Nikolov
 ___

 Community Meeting Calendar:

 Schedule -
 Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
 Bridge:https://bluejeans.com/441850968




 Gluster-devel mailing list

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-17 Thread Ravishankar N



On 18/11/20 12:17 pm, Strahil Nikolov wrote:

Nope, it's a deeper s**t.
I had to edit the ".spec.in" file so it has Source0 point to local tar.gz.
The I edit the requires in both ".spec" & ".spec.in" and also I had to remove 
an obsolete stanza in the glusterfs section.

In the end, I got the source - extracted, copied the spec & spec.in , and then 
tar.gz-ed again and put it into the dir.

Only then the rpms were properly built.

The proposed patch is fixing the issue.

Thanks for confirming!


Why do we have line 285 in 
https://raw.githubusercontent.com/gluster/glusterfs/devel/glusterfs.spec.in ?

I guess I need to open 2 issues for the glusterfs:
- that obsolete stanza is useless


Using git blame points me to 
https://github.com/gluster/glusterfs/commit/f9118c2c9389e0793951388c2d69ce0350bb9318. 
Adding Shwetha to confirm if the change was intended.


-Ravi




Best Regards,
Strahil Nikolov



В вторник, 17 ноември 2020 г., 14:16:36 Гринуич+2, Ravishankar N 
 написа:





Hi Strahil,

I would have imagined editing the 'Requires' section in
glusterfs.spec.in would have sufficed. Do you need rpms though? A source
install is not enough?

Regards,
Ravi

On 17/11/20 5:32 pm, Strahil Nikolov wrote:

Hi Ravi,


Any idea how to make the glusterfs-ganesha.x86_64 require resource-agents >= 
4.1.0 (instead of 4.2.0) ?
I 've replaced every occurance I found and still it tries to grab 
resource-agents 4.2 (which is not available on EL8).

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar 
N  написа:






I am surprised too that it wasn't caught earlier.


Steps:

1. Clone the gluster repo

2. Compile  the 
sourcehttps://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/

3. Make the changes (in a different branch if you prefer), compile again and 
install

4.  Test it out:

[root@linuxpad glusterfs]#  gluster v create testvol  
127.0.0.2:/home/ravi/bricks/brick{1..2} force
volume create: testvol: success: please start the volume to access data
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v start testvol
volume start: testvol: success
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
volume set: failed: The option nfs-ganesha should be enabled before setting 
ganesha.enable.
[root@linuxpad glusterfs]#
 


I just tried the change and it looks like some new error shows up. Not too 
familiar with these settings; I will need to debug further.

Thanks,

Ravi


On 16/11/20 4:05 pm, Strahil Nikolov wrote:



     I can try to help with the testing (I'm quite new to that).
Can someone share documentation of that process ?

yet we have another problem -> ganesha is deployed with ocf:heartbeat:portblock 
which supports only IPTABLES, while EL8 uses NFTABLES ...

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv 
Kaul  написа:







On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  wrote:


     On 15/11/20 8:24 pm, Strahil Nikolov wrote:


     Hello All,

did anyone get a chance to look 
athttps://github.com/gluster/glusterfs/issues/1778  ?


A look at
https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
seems to indicate this could be due to a typo error. Do you have a
source install where you can apply this simple diff and see if it fixes
the issue?


I think you are right - I seem to have introduced it as part 
ofhttps://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
  - my bad.

However, it was merged ~1 year ago, and no one has complained thus far... :-/
1. Is no one using NFS Ganesha?
2. We are lacking tests for NFS Ganesha - code coverage indicates this path is 
not covered.

Y.


   
diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c

b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
index 558f04fb2..d7bf96adf 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char
**op_errstr)
     }
     } else if (len_strcmp(key, keylen, "ganesha.enable")) {
     key_matched = _gf_true;
-    if (!strcmp(value, "off") == 0) {
+    if (strcmp(value, "off") == 0) {
     ret = ganesha_manage_export(dict, "off", _gf_true,
op_errstr);
     if (ret)
     goto out;

Thanks,

Ravi


     It's really strange that NFS Ganesha has ever passed the tests.
How do we test NFS Ganesha exporting ?

Best Regards,
Strahil Nikolov
___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge:https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

 

___

Community

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-17 Thread Strahil Nikolov

Hi Ravi,


Any idea how to make the glusterfs-ganesha.x86_64 require resource-agents >= 
4.1.0 (instead of 4.2.0) ?
I 've replaced every occurance I found and still it tries to grab 
resource-agents 4.2 (which is not available on EL8).

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar N 
 написа: 






I am surprised too that it wasn't caught earlier. 


Steps:

1. Clone the gluster repo

2. Compile  the source 
https://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/

3. Make the changes (in a different branch if you prefer), compile again and 
install

4.  Test it out:

[root@linuxpad glusterfs]#  gluster v create testvol  
127.0.0.2:/home/ravi/bricks/brick{1..2} force
volume create: testvol: success: please start the volume to access data
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v start testvol
volume start: testvol: success
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
volume set: failed: The option nfs-ganesha should be enabled before setting 
ganesha.enable.
[root@linuxpad glusterfs]# 
  

I just tried the change and it looks like some new error shows up. Not too 
familiar with these settings; I will need to debug further.

Thanks,

Ravi


On 16/11/20 4:05 pm, Strahil Nikolov wrote:


>  I can try to help with the testing (I'm quite new to that).
> Can someone share documentation of that process ?
> 
> yet we have another problem -> ganesha is deployed with 
> ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses NFTABLES 
> ...
> 
> Best Regards,
> Strahil Nikolov
> 
> 
> 
> 
> 
> 
> В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul 
>  написа: 
> 
> 
> 
> 
> 
> 
> 
> On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  wrote:
> 
>>  On 15/11/20 8:24 pm, Strahil Nikolov wrote:
>> 
>>>  Hello All,
>>> 
>>> did anyone get a chance to look at 
>>> https://github.com/gluster/glusterfs/issues/1778 ?
>>> 
>> A look at 
>> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
>>  
>> seems to indicate this could be due to a typo error. Do you have a 
>> source install where you can apply this simple diff and see if it fixes 
>> the issue?
>> 
> I think you are right - I seem to have introduced it as part of 
> https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
>  - my bad.
> 
> However, it was merged ~1 year ago, and no one has complained thus far... :-/
> 1. Is no one using NFS Ganesha? 
> 2. We are lacking tests for NFS Ganesha - code coverage indicates this path 
> is not covered.
> 
> Y.
> 
> 
>>
>> diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c 
>> b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>> index 558f04fb2..d7bf96adf 100644
>> --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>> +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>> @@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char 
>> **op_errstr)
>>   }
>>   } else if (len_strcmp(key, keylen, "ganesha.enable")) {
>>   key_matched = _gf_true;
>> -    if (!strcmp(value, "off") == 0) {
>> +    if (strcmp(value, "off") == 0) {
>>   ret = ganesha_manage_export(dict, "off", _gf_true, 
>> op_errstr);
>>   if (ret)
>>   goto out;
>> 
>> Thanks,
>> 
>> Ravi
>> 
>>>  It's really strange that NFS Ganesha has ever passed the tests.
>>> How do we test NFS Ganesha exporting ?
>>> 
>>> Best Regards,
>>> Strahil Nikolov
>>> ___
>>> 
>>> Community Meeting Calendar:
>>> 
>>> Schedule -
>>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
>>> Bridge: https://bluejeans.com/441850968
>>> 
>>> 
>>> 
>>> 
>>> Gluster-devel mailing list
>>> Gluster-devel@gluster.org
>>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>>> 
>> 
>>>  
>> ___
>> 
>> Community Meeting Calendar:
>> 
>> Schedule -
>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
>> Bridge: https://bluejeans.com/441850968
>> 
>> 
>> 
>> 
>> Gluster-devel mailing list
>> Gluster-devel@gluster.org
>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>> 
>> 
>> 
> 

___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-17 Thread Ravishankar N


Hi Strahil,

I would have imagined editing the 'Requires' section in 
glusterfs.spec.in would have sufficed. Do you need rpms though? A source 
install is not enough?


Regards,
Ravi

On 17/11/20 5:32 pm, Strahil Nikolov wrote:

Hi Ravi,


Any idea how to make the glusterfs-ganesha.x86_64 require resource-agents >= 
4.1.0 (instead of 4.2.0) ?
I 've replaced every occurance I found and still it tries to grab 
resource-agents 4.2 (which is not available on EL8).

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar 
N  написа:






I am surprised too that it wasn't caught earlier.


Steps:

1. Clone the gluster repo

2. Compile  the 
sourcehttps://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/

3. Make the changes (in a different branch if you prefer), compile again and 
install

4.  Test it out:

[root@linuxpad glusterfs]#  gluster v create testvol  
127.0.0.2:/home/ravi/bricks/brick{1..2} force
volume create: testvol: success: please start the volume to access data
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v start testvol
volume start: testvol: success
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
volume set: failed: The option nfs-ganesha should be enabled before setting 
ganesha.enable.
[root@linuxpad glusterfs]#
   


I just tried the change and it looks like some new error shows up. Not too 
familiar with these settings; I will need to debug further.

Thanks,

Ravi


On 16/11/20 4:05 pm, Strahil Nikolov wrote:



   I can try to help with the testing (I'm quite new to that).
Can someone share documentation of that process ?

yet we have another problem -> ganesha is deployed with ocf:heartbeat:portblock 
which supports only IPTABLES, while EL8 uses NFTABLES ...

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv 
Kaul  написа:







On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  wrote:


   On 15/11/20 8:24 pm, Strahil Nikolov wrote:


   Hello All,

did anyone get a chance to look 
athttps://github.com/gluster/glusterfs/issues/1778  ?


A look at
https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117  
seems to indicate this could be due to a typo error. Do you have a

source install where you can apply this simple diff and see if it fixes
the issue?


I think you are right - I seem to have introduced it as part 
ofhttps://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
  - my bad.

However, it was merged ~1 year ago, and no one has complained thus far... :-/
1. Is no one using NFS Ganesha?
2. We are lacking tests for NFS Ganesha - code coverage indicates this path is 
not covered.

Y.


 
diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c

b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
index 558f04fb2..d7bf96adf 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char
**op_errstr)
   }
   } else if (len_strcmp(key, keylen, "ganesha.enable")) {
   key_matched = _gf_true;
-    if (!strcmp(value, "off") == 0) {
+    if (strcmp(value, "off") == 0) {
   ret = ganesha_manage_export(dict, "off", _gf_true,
op_errstr);
   if (ret)
   goto out;

Thanks,

Ravi


   It's really strange that NFS Ganesha has ever passed the tests.
How do we test NFS Ganesha exporting ?

Best Regards,
Strahil Nikolov
___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge:https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

   

___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge:https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel





___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-16 Thread Strahil Nikolov

I was thinking about an automatic way for testing ...

I will use my notes to rebuild a fresh cluster on EL8 and I will give feedback 
if the patch is fixing it .


Thanks all for the assitance.

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar N 
 написа: 






I am surprised too that it wasn't caught earlier. 


Steps:

1. Clone the gluster repo

2. Compile  the source 
https://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/

3. Make the changes (in a different branch if you prefer), compile again and 
install

4.  Test it out:

[root@linuxpad glusterfs]#  gluster v create testvol  
127.0.0.2:/home/ravi/bricks/brick{1..2} force
volume create: testvol: success: please start the volume to access data
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v start testvol
volume start: testvol: success
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
volume set: failed: The option nfs-ganesha should be enabled before setting 
ganesha.enable.
[root@linuxpad glusterfs]# 
  

I just tried the change and it looks like some new error shows up. Not too 
familiar with these settings; I will need to debug further.

Thanks,

Ravi


On 16/11/20 4:05 pm, Strahil Nikolov wrote:


>  I can try to help with the testing (I'm quite new to that).
> Can someone share documentation of that process ?
> 
> yet we have another problem -> ganesha is deployed with 
> ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses NFTABLES 
> ...
> 
> Best Regards,
> Strahil Nikolov
> 
> 
> 
> 
> 
> 
> В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul 
>  написа: 
> 
> 
> 
> 
> 
> 
> 
> On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  wrote:
> 
>>  On 15/11/20 8:24 pm, Strahil Nikolov wrote:
>> 
>>>  Hello All,
>>> 
>>> did anyone get a chance to look at 
>>> https://github.com/gluster/glusterfs/issues/1778 ?
>>> 
>> A look at 
>> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
>>  
>> seems to indicate this could be due to a typo error. Do you have a 
>> source install where you can apply this simple diff and see if it fixes 
>> the issue?
>> 
> I think you are right - I seem to have introduced it as part of 
> https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
>  - my bad.
> 
> However, it was merged ~1 year ago, and no one has complained thus far... :-/
> 1. Is no one using NFS Ganesha? 
> 2. We are lacking tests for NFS Ganesha - code coverage indicates this path 
> is not covered.
> 
> Y.
> 
> 
>>
>> diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c 
>> b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>> index 558f04fb2..d7bf96adf 100644
>> --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>> +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
>> @@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char 
>> **op_errstr)
>>   }
>>   } else if (len_strcmp(key, keylen, "ganesha.enable")) {
>>   key_matched = _gf_true;
>> -    if (!strcmp(value, "off") == 0) {
>> +    if (strcmp(value, "off") == 0) {
>>   ret = ganesha_manage_export(dict, "off", _gf_true, 
>> op_errstr);
>>   if (ret)
>>   goto out;
>> 
>> Thanks,
>> 
>> Ravi
>> 
>>>  It's really strange that NFS Ganesha has ever passed the tests.
>>> How do we test NFS Ganesha exporting ?
>>> 
>>> Best Regards,
>>> Strahil Nikolov
>>> ___
>>> 
>>> Community Meeting Calendar:
>>> 
>>> Schedule -
>>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
>>> Bridge: https://bluejeans.com/441850968
>>> 
>>> 
>>> 
>>> 
>>> Gluster-devel mailing list
>>> Gluster-devel@gluster.org
>>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>>> 
>> 
>>>  
>> ___
>> 
>> Community Meeting Calendar:
>> 
>> Schedule -
>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
>> Bridge: https://bluejeans.com/441850968
>> 
>> 
>> 
>> 
>> Gluster-devel mailing list
>> Gluster-devel@gluster.org
>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>> 
>> 
>> 
> 

___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-16 Thread Strahil Nikolov

I can try to help with the testing (I'm quite new to that).
Can someone share documentation of that process ?

yet we have another problem -> ganesha is deployed with ocf:heartbeat:portblock 
which supports only IPTABLES, while EL8 uses NFTABLES ...

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul 
 написа: 







On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  wrote:
> 
> On 15/11/20 8:24 pm, Strahil Nikolov wrote:
>> Hello All,
>>
>> did anyone get a chance to look at 
>> https://github.com/gluster/glusterfs/issues/1778 ?
> 
> A look at 
> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
>  
> seems to indicate this could be due to a typo error. Do you have a 
> source install where you can apply this simple diff and see if it fixes 
> the issue?

I think you are right - I seem to have introduced it as part of 
https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
 - my bad.

However, it was merged ~1 year ago, and no one has complained thus far... :-/
1. Is no one using NFS Ganesha? 
2. We are lacking tests for NFS Ganesha - code coverage indicates this path is 
not covered.

Y.

>  
> diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c 
> b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> index 558f04fb2..d7bf96adf 100644
> --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> @@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char 
> **op_errstr)
>   }
>   } else if (len_strcmp(key, keylen, "ganesha.enable")) {
>   key_matched = _gf_true;
> -    if (!strcmp(value, "off") == 0) {
> +    if (strcmp(value, "off") == 0) {
>   ret = ganesha_manage_export(dict, "off", _gf_true, 
> op_errstr);
>   if (ret)
>   goto out;
> 
> Thanks,
> 
> Ravi
>>
>> It's really strange that NFS Ganesha has ever passed the tests.
>> How do we test NFS Ganesha exporting ?
>>
>> Best Regards,
>> Strahil Nikolov
>> ___
>>
>> Community Meeting Calendar:
>>
>> Schedule -
>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
>> Bridge: https://bluejeans.com/441850968
>>
>>
>>
>>
>> Gluster-devel mailing list
>> Gluster-devel@gluster.org
>> https://lists.gluster.org/mailman/listinfo/gluster-devel
> 
>>
> 
> ___
> 
> Community Meeting Calendar:
> 
> Schedule -
> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
> Bridge: https://bluejeans.com/441850968
> 
> 
> 
> 
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> https://lists.gluster.org/mailman/listinfo/gluster-devel
> 
> 
___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-16 Thread sankarshan

On Mon, 16 Nov 2020 at 16:45, Ravishankar N  wrote:

> I am surprised too that it wasn't caught earlier.
>

There have been sporadic requests around maintaining v3 but of late I
haven't heard a lot around NFS-Ganesha. I am not surprised to learn that
there is tests lacking - this is unlikely to be one-off.

-- 
sankarshan mukhopadhyay

___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968

Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-16 Thread Ravishankar N


I am surprised too that it wasn't caught earlier.

Steps:

1. Clone the gluster repo

2. Compile  the source 
https://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/


3. Make the changes (in a different branch if you prefer), compile again 
and install


4.  Test it out:

[root@linuxpad glusterfs]#  gluster v create testvol 
127.0.0.2:/home/ravi/bricks/brick{1..2} force

volume create: testvol: success: please start the volume to access data
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v start testvol
volume start: testvol: success
[root@linuxpad glusterfs]#
[root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on
volume set: failed: The option nfs-ganesha should be enabled before 
setting ganesha.enable.

[root@linuxpad glusterfs]#

I just tried the change and it looks like some new error shows up. Not 
too familiar with these settings; I will need to debug further.


Thanks,

Ravi

On 16/11/20 4:05 pm, Strahil Nikolov wrote:

I can try to help with the testing (I'm quite new to that).
Can someone share documentation of that process ?

yet we have another problem -> ganesha is deployed with ocf:heartbeat:portblock 
which supports only IPTABLES, while EL8 uses NFTABLES ...

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul 
 написа:







On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N  wrote:

On 15/11/20 8:24 pm, Strahil Nikolov wrote:

Hello All,

did anyone get a chance to look at 
https://github.com/gluster/glusterfs/issues/1778 ?

A look at
https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
seems to indicate this could be due to a typo error. Do you have a
source install where you can apply this simple diff and see if it fixes
the issue?

I think you are right - I seem to have introduced it as part of 
https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
 - my bad.

However, it was merged ~1 year ago, and no one has complained thus far... :-/
1. Is no one using NFS Ganesha?
2. We are lacking tests for NFS Ganesha - code coverage indicates this path is 
not covered.

Y.

   
diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c

b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
index 558f04fb2..d7bf96adf 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char
**op_errstr)
   }
   } else if (len_strcmp(key, keylen, "ganesha.enable")) {
   key_matched = _gf_true;
-    if (!strcmp(value, "off") == 0) {
+    if (strcmp(value, "off") == 0) {
   ret = ganesha_manage_export(dict, "off", _gf_true,
op_errstr);
   if (ret)
   goto out;

Thanks,

Ravi

It's really strange that NFS Ganesha has ever passed the tests.
How do we test NFS Ganesha exporting ?

Best Regards,
Strahil Nikolov
___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel


___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-16 Thread Yaniv Kaul

On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N 
wrote:

>
> On 15/11/20 8:24 pm, Strahil Nikolov wrote:
> > Hello All,
> >
> > did anyone get a chance to look at
> https://github.com/gluster/glusterfs/issues/1778 ?
>
> A look at
>
> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117
> seems to indicate this could be due to a typo error. Do you have a
> source install where you can apply this simple diff and see if it fixes
> the issue?
>

I think you are right - I seem to have introduced it as part of
https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553
- my bad.

However, it was merged ~1 year ago, and no one has complained thus far...
:-/
1. Is no one using NFS Ganesha?
2. We are lacking tests for NFS Ganesha - code coverage indicates this path
is not covered.

Y.


> diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> index 558f04fb2..d7bf96adf 100644
> --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> @@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char
> **op_errstr)
>   }
>   } else if (len_strcmp(key, keylen, "ganesha.enable")) {
>   key_matched = _gf_true;
> -if (!strcmp(value, "off") == 0) {
> +if (strcmp(value, "off") == 0) {
>   ret = ganesha_manage_export(dict, "off", _gf_true,
> op_errstr);
>   if (ret)
>   goto out;
>
> Thanks,
>
> Ravi
> >
> > It's really strange that NFS Ganesha has ever passed the tests.
> > How do we test NFS Ganesha exporting ?
> >
> > Best Regards,
> > Strahil Nikolov
> > ___
> >
> > Community Meeting Calendar:
> >
> > Schedule -
> > Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
> > Bridge: https://bluejeans.com/441850968
> >
> >
> >
> >
> > Gluster-devel mailing list
> > Gluster-devel@gluster.org
> > https://lists.gluster.org/mailman/listinfo/gluster-devel
> >
>
> ___
>
> Community Meeting Calendar:
>
> Schedule -
> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
> Bridge: https://bluejeans.com/441850968
>
>
>
>
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> https://lists.gluster.org/mailman/listinfo/gluster-devel
>
>
___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

2020-11-16 Thread Ravishankar N



On 15/11/20 8:24 pm, Strahil Nikolov wrote:

Hello All,

did anyone get a chance to look at 
https://github.com/gluster/glusterfs/issues/1778 ?


A look at 
https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117 
seems to indicate this could be due to a typo error. Do you have a 
source install where you can apply this simple diff and see if it fixes 
the issue?


diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c 
b/xlators/mgmt/glusterd/src/glusterd-op-sm.c

index 558f04fb2..d7bf96adf 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char 
**op_errstr)

 }
 } else if (len_strcmp(key, keylen, "ganesha.enable")) {
 key_matched = _gf_true;
-    if (!strcmp(value, "off") == 0) {
+    if (strcmp(value, "off") == 0) {
 ret = ganesha_manage_export(dict, "off", _gf_true, 
op_errstr);

 if (ret)
 goto out;

Thanks,

Ravi


It's really strange that NFS Ganesha has ever passed the tests.
How do we test NFS Ganesha exporting ?

Best Regards,
Strahil Nikolov
___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel



___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] NFS Ganesha fails to export a volume

2020-11-15 Thread Strahil Nikolov

Hello All,

did anyone get a chance to look at 
https://github.com/gluster/glusterfs/issues/1778 ?

It's really strange that NFS Ganesha has ever passed the tests.
How do we test NFS Ganesha exporting ?

Best Regards,
Strahil Nikolov
___

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

Re: [Gluster-devel] NFS Ganesha fails to export a volume

[Gluster-devel] NFS Ganesha fails to export a volume

13 matches

Site Navigation

Mail list logo

Footer information