Re: Committer role?

2015-01-14 Thread Piotr Drąg
2015-01-10 15:12 GMT+01:00 Sveinn í Felli :
> Great, thanks a lot Baurzhan, just what I was looking for ;-)
> It was the first step I was missing. Now it works as intended.
>

Hi,

I noticed you've committed updated translations to stable gnome-3-14
branches on several modules. That's great, but you should also
remember to commit to master, currently at
, so that all
future releases will have the lastest translations as well. I think I
cherry-picked and pushed to master all the translations that you did
so far, but please keep that in mind from now on.

Thank you for your work,

-- 
Piotr Drąg
http://raven.fedorapeople.org/
___
gnome-i18n mailing list
gnome-i18n@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: Committer role?

2015-01-14 Thread Sveinn í Felli

Þann mið 14.jan 2015 15:25, skrifaði Piotr Drąg:

2015-01-10 15:12 GMT+01:00 Sveinn í Felli :

Great, thanks a lot Baurzhan, just what I was looking for ;-)
It was the first step I was missing. Now it works as intended.



Hi,

I noticed you've committed updated translations to stable gnome-3-14
branches on several modules. That's great, but you should also
remember to commit to master, currently at
, so that all
future releases will have the lastest translations as well. I think I
cherry-picked and pushed to master all the translations that you did
so far, but please keep that in mind from now on.



Yes, it was intentional to submit to gnome-3-14 first, was testing the 
resulting MO files on my system (which is more or less gnome-3-14 based).


Maybe I'll try to setup a summit workflow for GNOME on my machine.

Thanks a lot for the upward pushing.

Sveinn

___
gnome-i18n mailing list
gnome-i18n@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: Committer role?

2015-01-14 Thread Piotr Drąg
2015-01-14 16:34 GMT+01:00 Sveinn í Felli :
> Þann mið 14.jan 2015 15:25, skrifaði Piotr Drąg:
>> I noticed you've committed updated translations to stable gnome-3-14
>> branches on several modules. That's great, but you should also
>> remember to commit to master, currently at
>> , so that all
>> future releases will have the lastest translations as well. I think I
>> cherry-picked and pushed to master all the translations that you did
>> so far, but please keep that in mind from now on.
>>
>
> Yes, it was intentional to submit to gnome-3-14 first, was testing the
> resulting MO files on my system (which is more or less gnome-3-14 based).
>
> Maybe I'll try to setup a summit workflow for GNOME on my machine.
>
> Thanks a lot for the upward pushing.
>

I'm sorry I went ahead with committing without asking first! I thought
it was a simple mistake, and not done intentional (there were cases
like this in the past.) I'll make sure to ask next time. It is a good
rule of thumb to commit to both master and stable branches at the same
time though - no translations will get lost, and you can always commit
fixes later. :)

Best regards,

-- 
Piotr Drąg
http://raven.fedorapeople.org/
___
gnome-i18n mailing list
gnome-i18n@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: Committer role?

2015-01-14 Thread Rafael Ferreira
2015-01-14 13:50 GMT-02:00 Piotr Drąg :
> 2015-01-14 16:34 GMT+01:00 Sveinn í Felli :
>
>> Yes, it was intentional to submit to gnome-3-14 first, was testing the
>> resulting MO files on my system (which is more or less gnome-3-14 based).
>>

FYI, you can test MO files without submitting to Git repository. You
just need to install the MO file in the proper place in your system,
which in my case is/usr/share/locale/$LANG/LC_MESSAGES/

Cheers,
Rafael Ferreira
___
gnome-i18n mailing list
gnome-i18n@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-i18n