Re: Build and run in separate directory

2006-02-19 Thread Mike Alexander
--On February 17, 2006 3:40:59 PM -0500 Derek Atkins <[EMAIL PROTECTED]> 
wrote:



FYI, I just rototilled the Makefiles to solve this problem, but
my changes are going to conflict with your patches.  But could you
pull down r13281 and verify that it works for you, please?


Thanks for sorting things out.  I'm currently at 13293 and the Makefile 
changes seem to work fine.


--
Mike Alexander   [EMAIL PROTECTED]
Ann Arbor, MIPGP key ID: BEA343A6


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Problems running GnuCash 1.9.0 on kubuntu 5.10

2006-02-19 Thread Derek Atkins

Hi,

You need to install the guile-g-wrap package.  See:

http://wiki.gnucash.org/wiki/Building

-derek

Quoting Aaron Larson <[EMAIL PROTECTED]>:


I've been a very happy user of gnucash now for several years, and with
the release of 1.9.0 decided I should try to give back by being a
tester, but I'm having trouble running my newly build version:

I'm using Kubuntu 5.10 (pretty fresh install), and installed the 1.9
source tarball, and using the package manager downloaded all the
dependencies to build gnucash (this is my first attempt).  It went
better than "nightmare" with the only interesting case being the
missing g-wrap-wct.h file as described in
http://blog.moria.org.uk/computers/code/g-wrap

I created the file as described in that message, and 1.9 builds:

 ./configure --prefix=/tmp/gnucash/
 make
 make install

I created a new user and ran gnucash in that user's home directory.
gnucash popped up a dialog indicating that the configuration files
were not in their expected location and offered to do the setup for
me.  I selected all default options.  1.9 then died with:

 : In procedure scm-error in expression (scm-error 
(quote misc-error) #f ...):

 : no code for module (g-wrap gw standard)

I've found lots of references to this sort of error, but all about
building, not running.  Note that GnuCash 1.8.10 is also installed on
this machine.  I can get a fresh machine without gnucash installed and
rebuild if that is necessary, or provide additional details of machine
configuration, etc.

Like I said above, I was hoping to be helpful, so, only respond if
it seems worth your while.  I can certainly wait for a packaged
distro.

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel





--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Eildert Groeneveld
Andrew

just wondering: did the patch make it into svn?

cause if it did it did not solve my problem:




;;; WARNING (wrong arguments for gnc:make-gnc-monetary:  #f #< 
num: -736000 denom: 100>)
In /usr/local/share/gnucash/guile-modules/gnucash/report/advanced-portfolio.scm:
...
 184: 51  (let* (# # # # ...) (for-each # #) (moneyincoll # dividendcoll 
#f) ...)
 275: 52* (if (or include-empty #) (let # # ...) ...)
 276: 53  (let (# # # #) (total-value # # #) (total-moneyin # moneyincoll 
#f) ...)
 276: 54* [gnc:monetary-neg ...
 277: 55*  [gnc:sum-collector-commodity # # #]
In /usr/local/share/gnucash/scm/commodity-utilities.scm:
 885: 56   (cond ((and foreign exchange-fn) (let (#) (foreign # # ...) ...)) 
(#t #f))
 886: 57   (let ((balance #)) (foreign (quote format) (lambda # #) ...) ...)
 887: 58*  [# format # #f]
In /usr/local/share/gnucash/scm/report-utilities.scm:
 448: 59   (case action ((quote add) (add-commodity-value commodity 
amount)) ...)
 ...
 414: 60   [map # ((#f #))]
In unknown file:
   ?: 61*  [# (#f #)]
In /usr/local/share/gnucash/scm/report-utilities.scm:
 415: 62*  [# #f #< num: -736000 denom: 
100>]
In /usr/local/share/gnucash/scm/commodity-utilities.scm:
 890: 63   (if (gnc:commodity-equiv? domestic curr) (balance # 
domestic ...) ...)
 892: 64   [# add # ...
 893: 65*   [gnc:gnc-monetary-amount #f]
In unknown file:
   ?: 66(and (eq? (quote #) (record-type-descriptor obj)) (struct-ref obj 
1))
   ?: 67*   [eq? #> ...
   ?: 68*[record-type-descriptor #f]
   ?: 69 (if (struct? obj) (struct-vtable obj) (error (quote not-a-record) 
obj))
   ...
   ?: 70 [scm-error misc-error #f "~A ~S" (not-a-record #f) #f]
: In procedure scm-error in expression (scm-error (quote 
misc-error) #f ...):
: not-a-record #f


greetings

Eildert

On Saturday 18 February 2006 06:56, Andrew Sackville-West wrote:
> On Fri, 17 Feb 2006 19:58:24 -0700
>
> Mark Johnson <[EMAIL PROTECTED]> wrote:
> > Andrew Sackville-West wrote:

> > a new house, I've fallen behind in recording real transactions and have
> > not yet determined if these use cases work in 1.8.12.
> >
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


1.9.0 build worked !!! wad (ANNOUNCE: Release of GnuCash 1.9.0 (unstable))

2006-02-19 Thread Navneet Karnani
Sorry about this message. I realized (after 2 weeks of trying to build) that the error was due to the wrong version of the g-wrap library i was using on my system. It got fixed and I have it up and running.- Navneet
On 2/9/06, Christian Stimming <
[EMAIL PROTECTED]> wrote:
Navneet Karnani schrieb:> I tried downloading the tar.gz and extracting it. Realized i had to do a> build to install and run it. Tried that too, but it fails. Gives me some> compilation errors related to some int fields. Anything I am doing wrong
> ? Can i get a binary release from somewhere ?This is an unstable release, intended for developers and testers.(Exactly as written in the announcement!) If you are not familiar withbuilding from source code, including with how to deal with compilation
errors, then you should not use this right now. Please wait a few monthsuntil your distribution will offer binary packages for you.(Having said that, you would at least have to send the full errormessage here, plus the relevant version numbers of your compile
environment, like gcc, distribution, gtk versions etc)Christian Stimming-- - Navneet... and you thought the world was a big place

-- - Navneet... and you thought the world was a big place
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: ANNOUNCE: Release of GnuCash 1.9.0 (unstable)

2006-02-19 Thread Navneet Karnani
Sorry about this message. I realized (after 2 weeks of trying to build) that the error was due to the wrong version of the g-wrap library i was using on my system. It got fixed and I have it up and running.- Navneet
On 2/9/06, Christian Stimming <[EMAIL PROTECTED]> wrote:
Navneet Karnani schrieb:> I tried downloading the tar.gz and extracting it. Realized i had to do a> build to install and run it. Tried that too, but it fails. Gives me some> compilation errors related to some int fields. Anything I am doing wrong
> ? Can i get a binary release from somewhere ?This is an unstable release, intended for developers and testers.(Exactly as written in the announcement!) If you are not familiar withbuilding from source code, including with how to deal with compilation
errors, then you should not use this right now. Please wait a few monthsuntil your distribution will offer binary packages for you.(Having said that, you would at least have to send the full errormessage here, plus the relevant version numbers of your compile
environment, like gcc, distribution, gtk versions etc)Christian Stimming-- - Navneet... and you thought the world was a big place
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


bounties

2006-02-19 Thread don Paolo Benvenuto
Hi guys!

I'm putting bounties on some new gnucash feaures, namely:

- US$ 100.00 for adding to the general accounts tab the possibility to
see the "actual" balances referred to a given date. It could be done via
a text box to put in the upper right corner.

- US$ 100.00 for adding the possibility to present the report options
before calculating the report. That'd be useful because with many
accounts and many txns the account are generating in a very long time,
and normally you have to customize the default settings in order to get
what you want. There should be a flag control in the preferences, where
the possibility to present the options before calculating any report
would be set: "set reports options before calculating them", and all
reports should obey this setting.

That's my 2 ¢... ehm, my 200$ !

-- 
Buon Cammino!

don Paolo Benvenuto

Vuoi sapere di più su quello che succede qui?
leggi il mio diario a http://www.chiesamissionaria.it/diario

Visita l'enciclopedia libera, dove puoi contribuire anche tu:
http://it.wikipedia.org/


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gnucash gentoo-amd64

2006-02-19 Thread Nicola Buso
Hi,

gnucash correctly compile (20060214) thanks for all your work.

regards,

nicola.



Derek Atkins wrote:
> Hi,
> 
> This should be fixed in r13257.  Could you please check and verify?
> 
> Thanks,
> 
> -derek
> 
> Martin Klaffenboeck <[EMAIL PROTECTED]> writes:
> 
> 
>>>In file included from PostgresBackend.c:336:
>>>base-autogen.c: In function `pgendAccountCompareVersion':
>>>base-autogen.c:1078: warning: cast from pointer to integer of different size
>>>base-autogen.c: In function `pgendBookCompareVersion':
>>>base-autogen.c:1105: warning: cast from pointer to integer of different size
>>>base-autogen.c: In function `pgendTransactionCompareVersion':
>>>base-autogen.c:1132: warning: cast from pointer to integer of different size
>>>base-autogen.c: In function `pgendPriceCompareVersion':
>>>base-autogen.c:1159: warning: cast from pointer to integer of different size
>>>base-autogen.c: In function `pgendAccountGetDeletedVersion':
>>>base-autogen.c:1185: warning: cast from pointer to integer of different size
>>>base-autogen.c: In function `pgendBookGetDeletedVersion':
>>>base-autogen.c:1209: warning: cast from pointer to integer of different size
>>>base-autogen.c: In function `pgendTransactionGetDeletedVersion':
>>>base-autogen.c:1233: warning: cast from pointer to integer of different size
>>>base-autogen.c: In function `pgendPriceGetDeletedVersion':
>>>base-autogen.c:1257: warning: cast from pointer to integer of different size
>>>make[6]: *** [PostgresBackend.lo] Error 1
>>>make[6]: Leaving directory
>>>`/var/tmp/portage/gnucash-svn-20060112/work/gnucash-svn-20060112/src/backend/postgres'
>>>make[5]: *** [all-recursive] Error 1
> 
> 

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Problems running GnuCash 1.9.0 on kubuntu 5.10

2006-02-19 Thread Aaron Larson
I've been a very happy user of gnucash now for several years, and with
the release of 1.9.0 decided I should try to give back by being a
tester, but I'm having trouble running my newly build version:

I'm using Kubuntu 5.10 (pretty fresh install), and installed the 1.9
source tarball, and using the package manager downloaded all the
dependencies to build gnucash (this is my first attempt).  It went
better than "nightmare" with the only interesting case being the
missing g-wrap-wct.h file as described in
http://blog.moria.org.uk/computers/code/g-wrap

I created the file as described in that message, and 1.9 builds:

  ./configure --prefix=/tmp/gnucash/
  make
  make install

I created a new user and ran gnucash in that user's home directory.
gnucash popped up a dialog indicating that the configuration files
were not in their expected location and offered to do the setup for
me.  I selected all default options.  1.9 then died with:

  : In procedure scm-error in expression (scm-error (quote 
misc-error) #f ...):
  : no code for module (g-wrap gw standard)

I've found lots of references to this sort of error, but all about
building, not running.  Note that GnuCash 1.8.10 is also installed on
this machine.  I can get a fresh machine without gnucash installed and
rebuild if that is necessary, or provide additional details of machine
configuration, etc.

Like I said above, I was hoping to be helpful, so, only respond if
it seems worth your while.  I can certainly wait for a packaged
distro.

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Release of GnuCash 1.9.1 (unstable)

2006-02-19 Thread Chris Lyttle
The GnuCash development team proudly announces GnuCash 1.9.1 aka "So we
meet again", the second of several unstable 1.9.x releases of the
GnuCash Open Source Accounting Software which will eventually lead to
the stable version 2.0.0. This release contains many bugfixes since the
first release but is still only intended for developers and adventurous
testers who want to help tracking down bugs.

What's New in GnuCash 1.9.1?

o WARNING WARNING WARNING - Make sure you make backups of any files
  used in testing versions of GnuCash in the 1.9.x series. Although the
  developers go to great lengths to ensure that no data will be lost we
  cannot guarantee that your data will not be affected if for some
  reason GnuCash crashes in testing these releases.
o PLEASE TEST TEST AND TEST SOME MORE any and all features important
  to you. Then post any bugs you find to bugzilla
  http://bugzilla.gnome.org/enter_bug.cgi?product=GnuCash
o If you have the urge to help beyond testing please get involved in
  the discussions on the GnuCash mailing lists which you will find at
  http://www.gnucash.org. We especially need people to help with
  updating the documentation as all texts refer currently to the 1.8.x
  series. Please see http://wiki.gnucash.org/wiki/Development on how to
  get involved.
o Major bugfixes include -
 o Register fixes
 o Finance::Quote issues
 o Correctly open an account and its sub-accounts.
 o Change the reports from using a hard-coded fiscal year to using the
   global accounting period set in the preferences.  Both the start date
   and the end date are used, so the user is free to choose any
arbitrary period.
 o Use the price nearest to midday to get the value in the default
   currency.
 o Make the desktop more HIG-compliant.
 o Patch to prevent crash when voiding a transaction.
 o Aqbanking updates
 o Report fixes
 o Autodetect OFX and use it if we find it.
 o Qof fixes

Caveats

Caveats for testers:
Any 1.9.x version might crash unexpectedly at any point during
runtime. If you test some serious work in a 1.9.x release, make sure you
hit "Save" after ever non-trivial workstep.
Keep in mind that features which are not used in everyday work might
crash unexpectedly at all times. This includes but is not limited to:
graphical reports, scheduled transaction editor, price editor, financial
calculator, OFX/QIF/HBCI import.
Especially all the new features might crash instantly on
testing. This applies in particular to any of the budget-related
features. We may always decide to disable such new features for the
initial 2.0.0 release, and re-enable them in a later release.
The documentation is completely outdated. All help texts
usually only refer to the 1.8.x series; please expect all descriptions
in the help texts to be totally wrong when applied to the upcoming 1.9.x
series. Everyone is invited to help improve the documentation; see
http://wiki.gnucash.org/wiki/Development"; on how to get involved.

How can you help?

Testing: Test it and help us discover all bugs that might show up in
there. Please enter each and every bug into bugzilla at
http://bugzilla.gnome.org/enter_bug.cgi?product=GnuCash
Translating: The new release comes with plenty of new translation
strings. If you consider contributing a translation, we invite you to
test this release already, but please keep in mind that we are not yet
in our string freeze phase. Please check
http://wiki.gnucash.org/wiki/Translation_Status for updates
on this, as we recommend to wait for the string freeze phase for the
serious translation work.

Available at the usual places!

http://www.gnucash.org
http://download.sourceforge.net/gnucash

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: [Gnucash-changes] r13301 - gnucash/trunk/src/engine/test-core - Fix uninitialized variable warning

2006-02-19 Thread Chris Shoemaker
On Sun, Feb 19, 2006 at 03:48:50PM -0500, Christian Stimming wrote:
> Author: cstim
> Date: 2006-02-19 15:48:50 -0500 (Sun, 19 Feb 2006)
> New Revision: 13301
> Trac: http://svn.gnucash.org/trac/changeset/13301
> 
> Modified:
>gnucash/trunk/src/engine/test-core/test-engine-stuff.c
> Log:
> Fix uninitialized variable warning
> 
> Modified: gnucash/trunk/src/engine/test-core/test-engine-stuff.c
> ===
> --- gnucash/trunk/src/engine/test-core/test-engine-stuff.c2006-02-19 
> 19:29:51 UTC (rev 13300)
> +++ gnucash/trunk/src/engine/test-core/test-engine-stuff.c2006-02-19 
> 20:48:50 UTC (rev 13301)
> @@ -1547,6 +1547,8 @@
>case 11:
>  op = QOF_QUERY_XOR;
>  break;
> +  default:
> +g_assert_not_reached();
>};
>if (gnc_engine_debug_random) printf ("op = %d (int was %d), ", op, op_num);
>return op;

This fix is insufficent to silence warning for gcc version 3.4.4.
I'll just initialize it.

-chris
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Derek Atkins

Quoting Phil Longstaff <[EMAIL PROTECTED]>:


On February 19, 2006 08:41 pm, Derek Atkins wrote:

I still can't believe that there's no way to tell valgrind
"this memory object is initialized, even if it may be 'tained'
by uninitialized memory"..   That would seem to be a core
suppression method, the "I know this data object is clean".


There is a mechanism if you don't mind adding a compile-time dependence on
valgrind.


We already do..   It's optional.  If we find the valgrind dev environment
then we use it in a few places.


Phil


-derek

--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Phil Longstaff
On February 19, 2006 08:41 pm, Derek Atkins wrote:
> I still can't believe that there's no way to tell valgrind
> "this memory object is initialized, even if it may be 'tained'
> by uninitialized memory"..   That would seem to be a core
> suppression method, the "I know this data object is clean".

There is a mechanism if you don't mind adding a compile-time dependence on 
valgrind.

Phil
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Derek Atkins
Chris Shoemaker <[EMAIL PROTECTED]> writes:

> Been there, done that.  The problem with using valgrind suppressions
> for this is that you'd need a supression for every codepath that jumps
> on a guid read, like every instance of a ghashtable that uses guid
> keys and every place we store a guid and later compare with it.  
>
> I think it's better just to use the valid portion of the dirent.
> Something like:
>
> md5_process_bytes(de, strlen(de->d_name), &guid_context);
> total += strlen(de->d_name);

I still can't believe that there's no way to tell valgrind
"this memory object is initialized, even if it may be 'tained'
by uninitialized memory"..   That would seem to be a core
suppression method, the "I know this data object is clean".

It's sounding like valgrind is making (in this case incorrect)
assumptions that if you process uninitialzed data and then use
the result of that processing, the result is 'tainted'.  In
random number generation, that's a false assumption..

On the other hand, we DO initialize from /dev/urandom  So the lack
of extra entropy might not be a huge problem.
*grumps*

> -chris

-derek

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Chris Shoemaker
On Sun, Feb 19, 2006 at 02:01:08PM -0500, Phil Longstaff wrote:
> On February 19, 2006 06:43 pm, Derek Atkins wrote:
> > Phil Longstaff <[EMAIL PROTECTED]> writes:
> > > The attached patch replaces the const 16 with GUID_DATA_SIZE, only
> > > compares the guid data, not the other field in the struct, and removes
> > > the use of the dirent structure in md5 calculation.
> >
> > I've applied everything but the part to remove the dirent/md5 call.
> > We shouldn't reduce our entropy.  We should just add a valgrind
> > suppression for that particular issue.
> >
> > -derek
> 
> No problem.  I wasn't happy with it anyway.  I'm more concerned about the 
> read 
> after the end of a malloc'ed area than about the uninitialized memory.  I'll 
> figure out a patch for the valgrind suppressions and send in a patch.

Been there, done that.  The problem with using valgrind suppressions
for this is that you'd need a supression for every codepath that jumps
on a guid read, like every instance of a ghashtable that uses guid
keys and every place we store a guid and later compare with it.  

I think it's better just to use the valid portion of the dirent.
Something like:

md5_process_bytes(de, strlen(de->d_name), &guid_context);
total += strlen(de->d_name);

-chris
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Phil Longstaff
On February 19, 2006 06:43 pm, Derek Atkins wrote:
> Phil Longstaff <[EMAIL PROTECTED]> writes:
> > The attached patch replaces the const 16 with GUID_DATA_SIZE, only
> > compares the guid data, not the other field in the struct, and removes
> > the use of the dirent structure in md5 calculation.
>
> I've applied everything but the part to remove the dirent/md5 call.
> We shouldn't reduce our entropy.  We should just add a valgrind
> suppression for that particular issue.
>
> -derek

No problem.  I wasn't happy with it anyway.  I'm more concerned about the read 
after the end of a malloc'ed area than about the uninitialized memory.  I'll 
figure out a patch for the valgrind suppressions and send in a patch.

Phil
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Phil Longstaff
On February 19, 2006 06:09 pm, Josh Sled wrote:
> On Sun, 2006-02-19 at 17:57 -0500, Derek Atkins wrote:
> > > 2) After g2 is up, I open an account, switch to ledger view, put my
> > > cursor into a split and start pressing delete-tab-delete-tab...  I then
> > > get the listing shown in attachment gnucash.valgrind.  I added printf
> > > statements to show as splits were allocated and freed.  Most serious is
> > > that a split continues to be accessed after it is freed.
> >
> > This is certainly something that needs to get fixed!  Thank you. 
> > Hopefully someone could track down the reference?
>
> See http://bugzilla.gnome.org/show_bug.cgi?id=108347 and
> http://bugzilla.gnome.org/show_bug.cgi?id=141287 and
> http://bugzilla.gnome.org/show_bug.cgi?id=125480 ... they all seem very
> likely to be related, and maybe or symptoms of the same underlying
> problem(s?).

I think so.  I've been poking around these.

Phil
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Derek Atkins
Phil Longstaff <[EMAIL PROTECTED]> writes:

> The attached patch replaces the const 16 with GUID_DATA_SIZE, only compares 
> the guid data, not the other field in the struct, and removes the use of the 
> dirent structure in md5 calculation.

I've applied everything but the part to remove the dirent/md5 call.
We shouldn't reduce our entropy.  We should just add a valgrind
suppression for that particular issue.

-derek
-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Josh Sled
On Sun, 2006-02-19 at 17:57 -0500, Derek Atkins wrote:
> > 2) After g2 is up, I open an account, switch to ledger view, put my cursor
> > into a split and start pressing delete-tab-delete-tab...  I then get the
> > listing shown in attachment gnucash.valgrind.  I added printf statements to
> > show as splits were allocated and freed.  Most serious is that a split
> > continues to be accessed after it is freed.
> 
> This is certainly something that needs to get fixed!  Thank you.  Hopefully
> someone could track down the reference?

See http://bugzilla.gnome.org/show_bug.cgi?id=108347 and
http://bugzilla.gnome.org/show_bug.cgi?id=141287 and
http://bugzilla.gnome.org/show_bug.cgi?id=125480 ... they all seem very
likely to be related, and maybe or symptoms of the same underlying
problem(s?).

-- 
...jsled
http://asynchronous.org/ - `a=jsled; b=asynchronous.org; echo [EMAIL PROTECTED]
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: G2 and valgrind

2006-02-19 Thread Derek Atkins

Quoting Phil Longstaff <[EMAIL PROTECTED]>:


I've been playing around with G2 and valgrind 3.1.0 and have seen the
following issues on SuSE 9.3:

1) There are lots of messages about decisions based on uninitialized 
variables

and accessing past the end of malloc'ed mem in the code dealing with guids.
It seems as though readdir() does not completely initialize the dirent struct
that it returns.  There were also messages that md5_process_bytes() was
accessing bytes from the dirent that were off the end of memory malloc'ed by
opendir().


These are all perfectly fine.  It's just trying to get random data, so
the fact that the data is uninitialized is okay.  If it bothers you,
you should add a valgrind supression.


  Finally, there were messages that guid_equal() was returning a
result based on uninitialized values because the comparison was done
including the __align_me field, not just the guid data.


This should get fixed.


The attached patch replaces the const 16 with GUID_DATA_SIZE, only compares
the guid data, not the other field in the struct, and removes the use of the
dirent structure in md5 calculation.


The first part of the patch is okay in theory (I haven't looked at the code).
The second part of the patch is not okay.


2) After g2 is up, I open an account, switch to ledger view, put my cursor
into a split and start pressing delete-tab-delete-tab...  I then get the
listing shown in attachment gnucash.valgrind.  I added printf statements to
show as splits were allocated and freed.  Most serious is that a split
continues to be accessed after it is freed.


This is certainly something that needs to get fixed!  Thank you.  Hopefully
someone could track down the reference?


Phil


-derek
--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: kubuntu and gettext

2006-02-19 Thread Derek Atkins

Quoting Aaron Larson <[EMAIL PROTECTED]>:


AL> I removed gettext, applied the patch, and did ./configure and a make
AL> foo-canvas-text.lo, and it built.  I'll do a rebuild from clean to
AL> make sure it didn't break anything else.  I should have an answer
AL> tonite.  I definitely need a faster test machine :-(

Sorry, no joy.


[snip]

In file included from /usr/include/glib-2.0/glib/gi18n.h:23,
from dialog-account.c:28:
/usr/include/libintl.h:40: error: syntax error before 'const'
/usr/include/libintl.h:44: error: syntax error before 'const'
/usr/include/libintl.h:51: error: syntax error before 'const'
/usr/include/libintl.h:81: error: syntax error before 'const'
/usr/include/libintl.h:85: error: syntax error before 'const'
/usr/include/libintl.h:90: error: syntax error before 'const'
In file included from dialog-account.c:28:
/usr/include/glib-2.0/glib/gi18n.h:25:1: error: "_" redefined
In file included from /usr/include/libgnome-2.0/libgnome/gnome-i18n.h:40,
from /usr/include/libgnome-2.0/libgnome/libgnome.h:30,
from /usr/include/libgnomeui-2.0/gnome.h:5,
from dialog-account.c:27:
/usr/include/libbonobo-2.0/bonobo/bonobo-i18n.h:69:1: error: this is 
the location of the previous definition

make[2]: *** [dialog-account.lo] Error 1
make[2]: Leaving directory `/home/alarson/gnucash-1.9.0/src/gnome-utils'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/alarson/gnucash-1.9.0/src/gnome-utils'
make: *** [all] Error 2


Hmm, so bonobo-i18n.h is conflicting with gi18n.h   Neither of these
files are owned by GnuCash...  So it's possble that in your particular case
you just cannot compile without gettext.

-derek

--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Bugs (?) in gnc-pricedb.c

2006-02-19 Thread Andrew Sackville-West
On Wed, 08 Feb 2006 02:50:47 -0500
Mike Alexander <[EMAIL PROTECTED]> wrote:

> While looking for another problem I found what look like bugs in a 
> couple of functions [1] in gnc-pricedb.c.  It appears to me that the 
> loop termination test is backwards in a couple of places.  I've 
> attached a patch that fixes this (if it is indeed a problem).
> 
> I added a number of patches to bug reports, but since I don't know how 
> to cause this bug to occur I didn't create a bug report for it.
> 
> [1] gnc_pricedb_convert_balance_latest_price and 
> gnc_pricedb_convert_balance_nearest_price.

Hampton, 

I see other problems with these functions...
for ex: if (!price-list) { balance = gnc_numeric_zero; return balance;};

well, that just doens't make sense. just because there is no price-list
we return a 0 for the balance? granted the function has pricedb in the
name and so its reasonable to assume there is a pricelist, but how do
you distinguish between a no price-list situation and a balance that is
actually zero? 

more freaking reading!

A

> 
> -- 
> Mike Alexander   [EMAIL PROTECTED]
> Ann Arbor, MIPGP key ID: BEA343A6
> 


pgpYx9yu7IBgJ.pgp
Description: PGP signature
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Andrew Sackville-West
On Sun, 19 Feb 2006 14:43:14 -0700
Mark Johnson <[EMAIL PROTECTED]> wrote:

> Derek Atkins wrote:
> 
> > Quoting Andrew Sackville-West <[EMAIL PROTECTED]>:
> >
> >> On Sun, 19 Feb 2006 12:20:42 -0800
> >> Andrew Sackville-West <[EMAIL PROTECTED]> wrote:
> >>
> >>> <>
> >>>
> >>> I've done some more testing using different options for price source
> >>> and whether to show gains or not and the report, as currently modified
> >>> in my tree shows no difference between these various settings. I need
> >>> to go back to an earlier version of this report and see how it behaves.
> >>
> >>
> >> I've done some testing with the original version of the report and
> >> afaict its not working properly either.
> >>
> >> I have an account with a purchase of fakestock on 2/8/06 at 12.35 a
> >> share, ten shares. then I have a pricedb entry same day that reflects
> >> this. Then I entered another purchase of 10 shares at $15.00 a share
> >> two days later. Regardless of the report settings, it always reports
> >> incorrect information. It reports 20 shares at $12.35 price and shows
> >> total value of $248.50 (20*12.35) total money in at 273.50  (123.50 +
> >> 150) and a negative gain (-6.xx% i think). Well, this is plain wrong
> >> and the report should be able to pick up that price change from the
> >> purchase two days later and should show a positive gain because I have
> >> shares purchased at a lower price than current value. Am I right in
> >> this assessment?
> >
> >
> > IMHO, yes, this assessment is correct.
> 
> Agreed.  On the bright side:
> 1. It is consistently using transactions as the source of cost 
> information, AND
> 2. using the pricedb as the source of current value.

It should IMO also use transactions for current value and make a
decision as to which is more accurate, or closer in date to the report
date. but only use buy or sell transactions as those are the only ones
that provide a "price". 
> 
> These two things are, I believe, the correct behaviour.  The question 
> comes back to automatically creating a pricedb entry for a buy and sell, 
> which looks to be a reasonable thing to do.  The caveat is that not all 
> stock transactions should create a pricedb entry.
> 
> Two options:
> 1. Perhaps, one could have a dialog asking the user (with a check box 
> for "don't ask again" and an Edit->Preferences check box for this). 
> 2.  Those transactions that are "buy" or "sell" could automatically 
> create a pricedb entry.  Those that are a conversion from another stock 
> or a transfer between stock accounts should not.
> 
> Additional thought would have to be given to transactions such as stock 
> splits or consolidations that change the number of shares (and therefore 
> the price), but not the cost basis.

yes yes and yes but, one thing at a time ;). my poor little brain can
only take so much!!


when I get back to working on this (couple days probably), I'll see if
I can generalize the value of the stock so that it can use both
properly. I'll ignore the currency conversion for now as that seems to
be another monster altogether. Once I get reliable results for value,
then I can look into that. 

Cheers

A
> 
> >
> >> A
> >
> >
> > -derek
> >
> Mark
> 


pgpevmbfj3VmX.pgp
Description: PGP signature
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Mark Johnson

Derek Atkins wrote:


Quoting Andrew Sackville-West <[EMAIL PROTECTED]>:


On Sun, 19 Feb 2006 12:20:42 -0800
Andrew Sackville-West <[EMAIL PROTECTED]> wrote:


<>

I've done some more testing using different options for price source
and whether to show gains or not and the report, as currently modified
in my tree shows no difference between these various settings. I need
to go back to an earlier version of this report and see how it behaves.



I've done some testing with the original version of the report and
afaict its not working properly either.

I have an account with a purchase of fakestock on 2/8/06 at 12.35 a
share, ten shares. then I have a pricedb entry same day that reflects
this. Then I entered another purchase of 10 shares at $15.00 a share
two days later. Regardless of the report settings, it always reports
incorrect information. It reports 20 shares at $12.35 price and shows
total value of $248.50 (20*12.35) total money in at 273.50  (123.50 +
150) and a negative gain (-6.xx% i think). Well, this is plain wrong
and the report should be able to pick up that price change from the
purchase two days later and should show a positive gain because I have
shares purchased at a lower price than current value. Am I right in
this assessment?



IMHO, yes, this assessment is correct.


Agreed.  On the bright side:
1. It is consistently using transactions as the source of cost 
information, AND

2. using the pricedb as the source of current value.

These two things are, I believe, the correct behaviour.  The question 
comes back to automatically creating a pricedb entry for a buy and sell, 
which looks to be a reasonable thing to do.  The caveat is that not all 
stock transactions should create a pricedb entry.


Two options:
1. Perhaps, one could have a dialog asking the user (with a check box 
for "don't ask again" and an Edit->Preferences check box for this). 
2.  Those transactions that are "buy" or "sell" could automatically 
create a pricedb entry.  Those that are a conversion from another stock 
or a transfer between stock accounts should not.


Additional thought would have to be given to transactions such as stock 
splits or consolidations that change the number of shares (and therefore 
the price), but not the cost basis.





A



-derek


Mark

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: r13297 - gnucash/trunk - Implement new-hierarchy-druid placeholder-value merge policy as discussed on -devel.

2006-02-19 Thread Josh Sled
On Sun, 2006-02-19 at 14:36 -0500, Derek Atkins wrote:
> This patch causes this build failure:

Mea culpa. Fixed.
-- 
...jsled
http://asynchronous.org/ - `a=jsled; b=asynchronous.org; echo [EMAIL PROTECTED]
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Derek Atkins

Quoting Andrew Sackville-West <[EMAIL PROTECTED]>:


On Sun, 19 Feb 2006 12:20:42 -0800
Andrew Sackville-West <[EMAIL PROTECTED]> wrote:


<>

I've done some more testing using different options for price source
and whether to show gains or not and the report, as currently modified
in my tree shows no difference between these various settings. I need
to go back to an earlier version of this report and see how it behaves.


I've done some testing with the original version of the report and
afaict its not working properly either.

I have an account with a purchase of fakestock on 2/8/06 at 12.35 a
share, ten shares. then I have a pricedb entry same day that reflects
this. Then I entered another purchase of 10 shares at $15.00 a share
two days later. Regardless of the report settings, it always reports
incorrect information. It reports 20 shares at $12.35 price and shows
total value of $248.50 (20*12.35) total money in at 273.50  (123.50 +
150) and a negative gain (-6.xx% i think). Well, this is plain wrong
and the report should be able to pick up that price change from the
purchase two days later and should show a positive gain because I have
shares purchased at a lower price than current value. Am I right in
this assessment?


IMHO, yes, this assessment is correct.


A


-derek

--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: kubuntu and gettext

2006-02-19 Thread Aaron Larson
> "DA" == Derek Atkins <[EMAIL PROTECTED]> writes:

DA> Aaron Larson <[EMAIL PROTECTED]> writes:
DA> Well, this is a compile failure in goffice, which admittedly hasn't
DA> been tested in all potential configurations.  It looks like the code
DA> is not properly acquiring the HAVE_GETTEXT setting, or something, but
DA> I'd need to know how you configured first.
>> 
DA> It certainly looks like the problem is in foo-canvas-i18n.h
>> 
DA> -derek

DA> OOPS, that last patch was definitely wrong.  (Serves me right for not
DA> testing it before I send it out).  Can you try THIS patch instead of
DA> that last one and let me know if it works for you?

I removed gettext, applied the patch, and did ./configure and a make
foo-canvas-text.lo, and it built.  I'll do a rebuild from clean to
make sure it didn't break anything else.  I should have an answer
tonite.  I definitely need a faster test machine :-(

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Andrew Sackville-West
On Sun, 19 Feb 2006 12:20:42 -0800
Andrew Sackville-West <[EMAIL PROTECTED]> wrote:

><>
> 
> I've done some more testing using different options for price source
> and whether to show gains or not and the report, as currently modified
> in my tree shows no difference between these various settings. I need
> to go back to an earlier version of this report and see how it behaves. 

I've done some testing with the original version of the report and
afaict its not working properly either.

I have an account with a purchase of fakestock on 2/8/06 at 12.35 a
share, ten shares. then I have a pricedb entry same day that reflects
this. Then I entered another purchase of 10 shares at $15.00 a share
two days later. Regardless of the report settings, it always reports
incorrect information. It reports 20 shares at $12.35 price and shows
total value of $248.50 (20*12.35) total money in at 273.50  (123.50 +
150) and a negative gain (-6.xx% i think). Well, this is plain wrong
and the report should be able to pick up that price change from the
purchase two days later and should show a positive gain because I have
shares purchased at a lower price than current value. Am I right in
this assessment?

A

> 
> What I'm having trouble wrapping my head around is how it should behave.
> 
> In my opinion, it should essentially show a snapshot of the value of
> the portfolio at a given point in time. That is, for each stock, it
> should provide a a total value of the stock owned at the date specified
> in the report. So what is the source of that stock value information?
> there are two possible sources 1) the pricedb and 2) the actual
> transactions.  In my opinion, the default should be to check both of
> these, see which is closer to the specified date and return that value
> * number of shares held. All the other computations (% gain, total
> return) are completed using that value. 
> 
> It seems to me that this should be fairly straightforward and that
> there is no real conflict between the two sources of data, unless they
> have differing values entered for the same date. In which case, we'd
> have to give one a precendent over the other. (IMO, that should be the
> transactions. a purchase or sale of a stock at a particular price is
> "Real" data whereas a pricedb entry is not). 
> 
> So, am I on the right track here? 
> 
> And how does what you have said below affect that? It should be fairly
> straightforward to search the two sources of price data and pick the
> one that more closely matches the date of the report and spew that
> information. 
> 
> thanks all for your continued help with this.
> 
> A
> 
> > 
> > The report that shows the development of a price over time (the "Price 
> > Scatterplot"), as well as all the other reports that depend on exchange 
> > prices, has therefore the option of choosing the "price source". I 
> > implemented that at the time because to me the only meaningful choices here 
> > were 1. either prices from the pricedb, *or* 2. implicit prices, but no mix 
> > of both. That's why the option "price source" has one choice to use the 
> > "implicit prices" and two other choices that will use prices "from the 
> > pricedb". So the solution to this two choices has been to give the user the 
> > option to choose between one out of two methods. I'm actually quite sure 
> > that 
> > any mix between both methods, at least for the same commodity, really 
> > doesn't 
> > give meaningful results. The "exchange-fn" IIRC should be the abstraction 
> > to 
> > provide access to both methods the same way. The way the exchange-fn was 
> > calculated is probably not the most efficient one, but at least it gave 
> > accurate results for the choices that were available. 
> > 
> > However, although I coded quite a lot of the multi-currency stuff, this is 
> > all 
> > now quite a long time ago and I don't remember anything I ever did at the 
> > time. Hopefully I added enough comments in the scheme code.
> > 
> > In summary: The question of the price source has been an issue since the 
> > introduction of the pricedb to gnucash, and it had to be solved in all 
> > multi-commodity reports, not only the advanced-portfolio.scm. If you think 
> > the available reportsystem-wide implementation needs changes, you are of 
> > course welcome to do them, but please keep in mind that this whole issue is 
> > really not trivial. In particular, both price source options are pretty 
> > much 
> > orthogonal to each other and I haven't heard any convincing proposal to mix 
> > them, so I'd rather suggest to continue to treat both separately at some 
> > level.
> > 
> > Regards,
> > 
> > Christian
> 


pgpJKyoKGXrX8.pgp
Description: PGP signature
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Andrew Sackville-West
On Sun, 19 Feb 2006 15:08:55 +0100
Christian Stimming <[EMAIL PROTECTED]> wrote:

> Hi Andrew and Mark,
> 
> Am Samstag, 18. Februar 2006 18:20 schrieb Mark Johnson:
> > >2) you can always come in the next day and record the current price for
> > > the fund so that the pricedb shows the current value. Make sense? the
> > > only thing you'll lose will be the price history. Its okay that you don't
> > > show the current market price at the time of the transfer/exchange. you
> > > can always provide that number later so that your reports show the
> > > current market value.
> >
> > True.  What about the possibility of reports based upon the pricedb
> > entries?  Eg. a graph of the price history.  Such entries would produce
> > unwelcome blips.  I'm just thinking here about possible future features,
> > and, I suppose, the meaning of pricedb entries.
> 
> Just to remind you of the current reports and so that everyone is on the same 
> page: The distinction between prices "from the pricedb" and those calculated 
> "implictly from existing transactions" has always existed and had to be dealt 
> with always. 

Chris, thanks for the background on this. it is helpful. 

I've done some more testing using different options for price source
and whether to show gains or not and the report, as currently modified
in my tree shows no difference between these various settings. I need
to go back to an earlier version of this report and see how it behaves. 

What I'm having trouble wrapping my head around is how it should behave.

In my opinion, it should essentially show a snapshot of the value of
the portfolio at a given point in time. That is, for each stock, it
should provide a a total value of the stock owned at the date specified
in the report. So what is the source of that stock value information?
there are two possible sources 1) the pricedb and 2) the actual
transactions.  In my opinion, the default should be to check both of
these, see which is closer to the specified date and return that value
* number of shares held. All the other computations (% gain, total
return) are completed using that value. 

It seems to me that this should be fairly straightforward and that
there is no real conflict between the two sources of data, unless they
have differing values entered for the same date. In which case, we'd
have to give one a precendent over the other. (IMO, that should be the
transactions. a purchase or sale of a stock at a particular price is
"Real" data whereas a pricedb entry is not). 

So, am I on the right track here? 

And how does what you have said below affect that? It should be fairly
straightforward to search the two sources of price data and pick the
one that more closely matches the date of the report and spew that
information. 

thanks all for your continued help with this.

A

> 
> The report that shows the development of a price over time (the "Price 
> Scatterplot"), as well as all the other reports that depend on exchange 
> prices, has therefore the option of choosing the "price source". I 
> implemented that at the time because to me the only meaningful choices here 
> were 1. either prices from the pricedb, *or* 2. implicit prices, but no mix 
> of both. That's why the option "price source" has one choice to use the 
> "implicit prices" and two other choices that will use prices "from the 
> pricedb". So the solution to this two choices has been to give the user the 
> option to choose between one out of two methods. I'm actually quite sure that 
> any mix between both methods, at least for the same commodity, really doesn't 
> give meaningful results. The "exchange-fn" IIRC should be the abstraction to 
> provide access to both methods the same way. The way the exchange-fn was 
> calculated is probably not the most efficient one, but at least it gave 
> accurate results for the choices that were available. 
> 
> However, although I coded quite a lot of the multi-currency stuff, this is 
> all 
> now quite a long time ago and I don't remember anything I ever did at the 
> time. Hopefully I added enough comments in the scheme code.
> 
> In summary: The question of the price source has been an issue since the 
> introduction of the pricedb to gnucash, and it had to be solved in all 
> multi-commodity reports, not only the advanced-portfolio.scm. If you think 
> the available reportsystem-wide implementation needs changes, you are of 
> course welcome to do them, but please keep in mind that this whole issue is 
> really not trivial. In particular, both price source options are pretty much 
> orthogonal to each other and I haven't heard any convincing proposal to mix 
> them, so I'd rather suggest to continue to treat both separately at some 
> level.
> 
> Regards,
> 
> Christian


pgpjr5yzTwUPO.pgp
Description: PGP signature
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: r13297 - gnucash/trunk - Implement new-hierarchy-druid placeholder-value merge policy as discussed on -devel.

2006-02-19 Thread Derek Atkins
Josh,

This patch causes this build failure:

druid-hierarchy.c: In function `on_final_account_next':
druid-hierarchy.c:855: warning: implicit declaration of function 
`account_merge_error_detection'
druid-hierarchy.c:856: warning: assignment makes pointer from integer without a 
cast
make[5]: *** [druid-hierarchy.lo] Error 1
make[5]: Leaving directory 
`/home/warlord/src/gnucash/gnucash-svn/build/src/gnome'

-derek

Joshua Sled <[EMAIL PROTECTED]> writes:

> Author: jsled
> Date: 2006-02-19 11:36:08 -0500 (Sun, 19 Feb 2006)
> New Revision: 13297
> Trac: http://svn.gnucash.org/trac/changeset/13297
>
> Modified:
>gnucash/trunk/ChangeLog
>gnucash/trunk/src/app-utils/gnc-account-merge.c
>gnucash/trunk/src/app-utils/gnc-account-merge.h
>gnucash/trunk/src/gnome/druid-hierarchy.c
> Log:
> Implement new-hierarchy-druid placeholder-value merge policy as discussed on 
> -devel.

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Customer report

2006-02-19 Thread Derek Atkins

Quoting "Michael D. Wise" <[EMAIL PROTECTED]>:


Not yet...


I forgot to tell you I opened a bug this morning. The number is 331771.


Indeed.  Can you go attach the screenshots (or a test datafile showing
the problem) to that bug?   I cannot reproduce the problem here with
my own data.


Michael

-derek


-derek

--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Customer report

2006-02-19 Thread Michael D. Wise
On Sun, 2006-02-19 at 09:48 -0500, Derek Atkins wrote:
> "Michael D. Wise" <[EMAIL PROTECTED]> writes:
> 
> > I have posted a couple of invoices for a customer.  When I run the
> > customer report, the correct amount due shows up in 0-30 days but
> > nothing shows up above that (the invoices are not listed and the total
> > due is 0).
> 
> What version of gnucash?
> What are the post-dates of the invoice?
> What is the date-range of the report?
> 
> > Do I need to open a bug?
> 
> Not yet...
> 
I forgot to tell you I opened a bug this morning. The number is 331771.

Michael
> -derek
> -- 
>Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>Member, MIT Student Information Processing Board  (SIPB)
>URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
>[EMAIL PROTECTED]PGP key available
> 


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Customer report

2006-02-19 Thread Derek Atkins

Plesae be sure to CC gnucash-devel on all your replies...

Quoting "Michael D. Wise" <[EMAIL PROTECTED]>:


On Sun, 2006-02-19 at 09:48 -0500, Derek Atkins wrote:

"Michael D. Wise" <[EMAIL PROTECTED]> writes:

> I have posted a couple of invoices for a customer.  When I run the
> customer report, the correct amount due shows up in 0-30 days but
> nothing shows up above that (the invoices are not listed and the total
> due is 0).

What version of gnucash?
What are the post-dates of the invoice?
What is the date-range of the report?



Version is r13293.  The invoice dates are both 3 February 2006 and the
report date is from Current Year Start till Today using the drop lists.


Hmm..  Okay, could you file a bug, attach a screenshot of your A/R account
showing the posted invoices, a screenshot of the report, and a screenshot
of your report-options screen?

If you can attach a test data file too, that would be even better!

Thanks,


Michael


-derek
--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: kubuntu and gettext

2006-02-19 Thread Derek Atkins
Aaron Larson <[EMAIL PROTECTED]> writes:

> DA> Well, this is a compile failure in goffice, which admittedly hasn't
> DA> been tested in all potential configurations.  It looks like the code
> DA> is not properly acquiring the HAVE_GETTEXT setting, or something, but
> DA> I'd need to know how you configured first.
>
> DA> It certainly looks like the problem is in foo-canvas-i18n.h
>
> DA> -derek

OOPS, that last patch was definitely wrong.  (Serves me right for not
testing it before I send it out).  Can you try THIS patch instead of
that last one and let me know if it works for you?

Thanks!

-derek

Index: lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas/foo-canvas-i18n.h
===
--- lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas/foo-canvas-i18n.h	(revision 13293)
+++ lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas/foo-canvas-i18n.h	(working copy)
@@ -34,37 +34,6 @@
 #define __LIBFOO_CANVAS_I18N_H__
 
 #include 
+#include 
 
-G_BEGIN_DECLS
-
-#if !defined(__LIBFOO_CANVAS_I18NP_H__)
-
-#ifdef ENABLE_NLS
-#include 
-#ifdef GNOME_EXPLICIT_TRANSLATION_DOMAIN
-#undef _
-#define _(String) dgettext (GNOME_EXPLICIT_TRANSLATION_DOMAIN, String)
-#else
-#define _(String) gettext (String)
-#endif
-#ifdef gettext_noop
-#define N_(String) gettext_noop (String)
-#else
-#define N_(String) (String)
-#endif
-#else
-/* Stubs that do something close enough.  */
-#define textdomain(String) (String)
-#define gettext(String) (String)
-#define dgettext(Domain,Message) (Message)
-#define dcgettext(Domain,Message,Type) (Message)
-#define bindtextdomain(Domain,Directory) (Domain)
-#define _(String) (String)
-#define N_(String) (String)
-#endif
-
-#endif
-
-G_END_DECLS
-
 #endif /* __LIBFOO_CANVAS_I18N_H__ */

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: kubuntu and gettext

2006-02-19 Thread Derek Atkins
Aaron Larson <[EMAIL PROTECTED]> writes:

> DA> Well, this is a compile failure in goffice, which admittedly hasn't
> DA> been tested in all potential configurations.  It looks like the code
> DA> is not properly acquiring the HAVE_GETTEXT setting, or something, but
> DA> I'd need to know how you configured first.
>
> DA> It certainly looks like the problem is in foo-canvas-i18n.h
>
> DA> -derek

Can you try this patch and let me know if it works for you?

-derek

Index: lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas/foo-canvas-i18n.h
===
--- lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas/foo-canvas-i18n.h	(revision 13293)
+++ lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas/foo-canvas-i18n.h	(working copy)
@@ -34,37 +34,6 @@
 #define __LIBFOO_CANVAS_I18N_H__
 
 #include 
+#include 
 
-G_BEGIN_DECLS
-
-#if !defined(__LIBFOO_CANVAS_I18NP_H__)
-
-#ifdef ENABLE_NLS
-#include 
-#ifdef GNOME_EXPLICIT_TRANSLATION_DOMAIN
-#undef _
-#define _(String) dgettext (GNOME_EXPLICIT_TRANSLATION_DOMAIN, String)
-#else
-#define _(String) gettext (String)
-#endif
-#ifdef gettext_noop
-#define N_(String) gettext_noop (String)
-#else
-#define N_(String) (String)
-#endif
-#else
-/* Stubs that do something close enough.  */
-#define textdomain(String) (String)
-#define gettext(String) (String)
-#define dgettext(Domain,Message) (Message)
-#define dcgettext(Domain,Message,Type) (Message)
-#define bindtextdomain(Domain,Directory) (Domain)
-#define _(String) (String)
-#define N_(String) (String)
-#endif
-
-#endif
-
-G_END_DECLS
-
 #endif /* __LIBFOO_CANVAS_I18N_H__ */

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: [PATCH] Re: Fancy Invoice

2006-02-19 Thread Derek Atkins

Quoting Brian <[EMAIL PROTECTED]>:


Thank you.  I wanted to do what you changed, but did not have a clue
about how to go about it in gnucash.  Now I have an example :)

It seems that we both missed the company-id actually being put into the
report.  I've added it to the bottom of the address as I did not know of
a better place for it.  Ideas are welcome.  Most bills I get from
suppliers seem to have it as the last line of their name & address,
probably because it was easier and cheaper than reprinting, etc..  I had
also added it to the actual address in 1.8 so it would show on invoices,
etc. since it was not a separate entity.


attached is a one line patch adding the company-id.


Applied.

-derek

--
  Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
  Member, MIT Student Information Processing Board  (SIPB)
  URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
  [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: kubuntu and gettext

2006-02-19 Thread Aaron Larson
> "DA" == Derek Atkins <[EMAIL PROTECTED]> writes:

DA> Aaron Larson <[EMAIL PROTECTED]> writes:
>> The other day I said I'd try compiling from a fresh kubuntu install.
>> I'm working my way through it, I'll have something soon...
>> 
>> If I don't have gettext installed then I get the following error.  A
>> brief look at ./configure output and the source led me to believe that
>> gettext was intended to be optional, so I thought I'd post the
>> error.  I can provide more info if you want.

DA> What configure parameters did you use?

None.

./configure
make

This was with the 1.9.0 src tarball in kubuntu 5.10.  

>> gcc -DHAVE_CONFIG_H -I. -I. -I../../../../.. -I../../../../.. 
>> -I../../../../.. -I../../../../.. -I../../../../../lib/libgsf-1.12.3 
>> -I../../../../../lib/goffice-0.0.4 -I../../../../../lib/goffice-0.0.4 
>> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 
>> -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/gtk-2.0 
>> -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo 
>> -I/usr/include/libglade-2.0 -I/usr/include/libgnomeprint-2.2 
>> -I/usr/include/libart-2.0 -DFOOCANVASLIBDIR=\"/usr/local/lib\" 
>> -DFOOCANVASDATADIR=\"/usr/local/share\" 
>> -DFOOCANVASPIXMAPDIR=\"/usr/local/share/pixmaps\" 
>> -DFOOCANVASBINDIR=\"/usr/local/bin\" 
>> -DFOOCANVASLOCALSTATEDIR=\"/usr/local/var\" -DFOOCANVASLOCALEDIR=\"\" 
>> -DG_LOG_DOMAIN=\"Foocanvas\" -DVERSION=\"1.9.0\" -g -O2 -Wall -Wunused 
>> -Wmissing-prototypes -Wmissing-declarations -Werror 
>> -Wdeclaration-after-statement -Wno-pointer-sign -MT foo-canvas-text.lo -MD 
>> -MP -MF .deps/foo-canvas-text.Tpo -c foo-canvas-
DA>  t!
>> ext.c  -fPIC -DPIC -o .libs/foo-canvas-text.o
>> In file included from foo-canvas-text.c:48:
>> foo-canvas-i18n.h:58:1: error: "gettext" redefined
>> In file included from /usr/include/glib-2.0/glib/gi18n.h:23,
>> from foo-canvas-text.c:5:
>> /usr/include/libintl.h:108:1: error: this is the location of the previous 
>> definition
>> In file included from foo-canvas-text.c:48:
>> foo-canvas-i18n.h:59:1: error: "dgettext" redefined
>> In file included from /usr/include/glib-2.0/glib/gi18n.h:23,
>> from foo-canvas-text.c:5:
>> /usr/include/libintl.h:110:1: error: this is the location of the previous 
>> definition
>> In file included from foo-canvas-text.c:48:
>> foo-canvas-i18n.h:62:1: error: "_" redefined
>> In file included from foo-canvas-text.c:5:
>> /usr/include/glib-2.0/glib/gi18n.h:25:1: error: this is the location of the 
>> previous definition
>> make[8]: *** [foo-canvas-text.lo] Error 1
>> make[8]: Leaving directory 
>> `/home/alarson/gnucash-1.9.0/lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas'

DA> Well, this is a compile failure in goffice, which admittedly hasn't
DA> been tested in all potential configurations.  It looks like the code
DA> is not properly acquiring the HAVE_GETTEXT setting, or something, but
DA> I'd need to know how you configured first.

DA> It certainly looks like the problem is in foo-canvas-i18n.h

DA> -derek

DA> -- 
DA>Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
DA>Member, MIT Student Information Processing Board  (SIPB)
DA>URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
DA>[EMAIL PROTECTED]PGP key available
DA> ___
DA> gnucash-devel mailing list
DA> gnucash-devel@gnucash.org
DA> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: [PATCH] Re: Fancy Invoice

2006-02-19 Thread Brian
On Sun, 2006-12-02 at 13:32 -0500, Derek Atkins wrote:
> Hi,
> 
> Brian <[EMAIL PROTECTED]> writes:
> 
> > I also think these changes could be applied to the 1.8.12 as well since
> > I started them there quite a while ago.
> >
> > Side note:  the gnc:make-number-range-option also does not render on the
> > screen the best.  It seems to have a display box slightly shorter than
> > the number text it is displaying. I had to compensate by making the
> > minimum display number width wider.
> 
> I've applied these changes to SVN (r13237).  I made a bunch of changes
> to your changes so it's likely that you'll need to "svn revert" after
> you update or you'll probably get svn merge conflicts in your tree.
> I've verified that these changes work.
> 
> Enjoy!
> 
> -derek

Thank you.  I wanted to do what you changed, but did not have a clue
about how to go about it in gnucash.  Now I have an example :)

It seems that we both missed the company-id actually being put into the
report.  I've added it to the bottom of the address as I did not know of
a better place for it.  Ideas are welcome.  Most bills I get from
suppliers seem to have it as the last line of their name & address,
probably because it was easier and cheaper than reprinting, etc..  I had
also added it to the actual address in 1.8 so it would show on invoices,
etc. since it was not a separate entity.


attached is a one line patch adding the company-id.
-- 
Brian <[EMAIL PROTECTED]>
Index: src/business/business-reports/fancy-invoice.scm
===
--- src/business/business-reports/fancy-invoice.scm	(revision 13293)
+++ src/business/business-reports/fancy-invoice.scm	(working copy)
@@ -722,7 +722,7 @@
 	'attribute (list "align" "right")
 	'attribute (list "width" "33%"))
 (gnc:html-table-append-row!
- table (list (string-expand (if addy addy "") #\newline "")
+ table (list (string-expand (string-append (if addy addy "") (if id (string-append "\n" id) "")) #\newline "")
 		 (string-expand
 		  (string-append (if phone
  (string-append (_ "Phone:") " " phone)
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: kubuntu and gettext

2006-02-19 Thread Derek Atkins
Aaron Larson <[EMAIL PROTECTED]> writes:

> The other day I said I'd try compiling from a fresh kubuntu install.
> I'm working my way through it, I'll have something soon...
>
> If I don't have gettext installed then I get the following error.  A
> brief look at ./configure output and the source led me to believe that
> gettext was intended to be optional, so I thought I'd post the
> error.  I can provide more info if you want.

What configure parameters did you use?

>  gcc -DHAVE_CONFIG_H -I. -I. -I../../../../.. -I../../../../.. 
> -I../../../../.. -I../../../../.. -I../../../../../lib/libgsf-1.12.3 
> -I../../../../../lib/goffice-0.0.4 -I../../../../../lib/goffice-0.0.4 
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 
> -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/gtk-2.0 
> -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo 
> -I/usr/include/libglade-2.0 -I/usr/include/libgnomeprint-2.2 
> -I/usr/include/libart-2.0 -DFOOCANVASLIBDIR=\"/usr/local/lib\" 
> -DFOOCANVASDATADIR=\"/usr/local/share\" 
> -DFOOCANVASPIXMAPDIR=\"/usr/local/share/pixmaps\" 
> -DFOOCANVASBINDIR=\"/usr/local/bin\" 
> -DFOOCANVASLOCALSTATEDIR=\"/usr/local/var\" -DFOOCANVASLOCALEDIR=\"\" 
> -DG_LOG_DOMAIN=\"Foocanvas\" -DVERSION=\"1.9.0\" -g -O2 -Wall -Wunused 
> -Wmissing-prototypes -Wmissing-declarations -Werror 
> -Wdeclaration-after-statement -Wno-pointer-sign -MT foo-canvas-text.lo -MD 
> -MP -MF .deps/foo-canvas-text.Tpo -c foo-canvas-
 t!
>  ext.c  -fPIC -DPIC -o .libs/foo-canvas-text.o
> In file included from foo-canvas-text.c:48:
> foo-canvas-i18n.h:58:1: error: "gettext" redefined
> In file included from /usr/include/glib-2.0/glib/gi18n.h:23,
>  from foo-canvas-text.c:5:
> /usr/include/libintl.h:108:1: error: this is the location of the previous 
> definition
> In file included from foo-canvas-text.c:48:
> foo-canvas-i18n.h:59:1: error: "dgettext" redefined
> In file included from /usr/include/glib-2.0/glib/gi18n.h:23,
>  from foo-canvas-text.c:5:
> /usr/include/libintl.h:110:1: error: this is the location of the previous 
> definition
> In file included from foo-canvas-text.c:48:
> foo-canvas-i18n.h:62:1: error: "_" redefined
> In file included from foo-canvas-text.c:5:
> /usr/include/glib-2.0/glib/gi18n.h:25:1: error: this is the location of the 
> previous definition
> make[8]: *** [foo-canvas-text.lo] Error 1
> make[8]: Leaving directory 
> `/home/alarson/gnucash-1.9.0/lib/goffice-0.0.4/goffice/cut-n-paste/foocanvas'

Well, this is a compile failure in goffice, which admittedly hasn't
been tested in all potential configurations.  It looks like the code
is not properly acquiring the HAVE_GETTEXT setting, or something, but
I'd need to know how you configured first.

It certainly looks like the problem is in foo-canvas-i18n.h

-derek

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Customer report

2006-02-19 Thread Derek Atkins
"Michael D. Wise" <[EMAIL PROTECTED]> writes:

> I have posted a couple of invoices for a customer.  When I run the
> customer report, the correct amount due shows up in 0-30 days but
> nothing shows up above that (the invoices are not listed and the total
> due is 0).

What version of gnucash?
What are the post-dates of the invoice?
What is the date-range of the report?

> Do I need to open a bug?

Not yet...

-derek
-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Derek Atkins
Andrew Sackville-West <[EMAIL PROTECTED]> writes:

>> > In 
>> > /usr/local/share/gnucash/guile-modules/gnucash/report/advanced-portfolio.scm:
>> >...
>> > 186: 51  (let* (# # # # ...) (if price-is-dirty #) (for-each # #) ...)
>> > 315: 52* (if (or include-empty (not #)) (let* (# # # ...) (if # #) ...) 
>> > ...)
>> > 316: 53  (let* (# # # #) (if # #) (if show-symbol #) ...)
>> > 316: 54* [gnc:monetary-neg ...
>> > 317: 55*  [gnc:sum-collector-commodity # # #> > #>]
>
> I believe the first # is the problem, but can't
> figure out how you would be getting one of these. I *think* I've
> covered all cases before you get to this point so that this doesn't
> happen. Obviously I haven't. Are you sure the diff was applied
> properly? can I send you a complete copy of the report for you to
> plug in?

I think the issue here are /both/ # entries in frame 55.
This error is /absolutely/ the fault of commod-currency being #f.  In
this code:

 (price-list (price-fn commodity to-date))
 (price  (if (> (length price-list) 0)
 (car price-list) #f))
 (commod-currency (gnc:price-get-currency price))

The problem is that price-fn returns an empty list and therefore
the price is #f and as a result the commod-currency is #f

-derek
-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Christian Stimming
Hi Andrew and Mark,

Am Samstag, 18. Februar 2006 18:20 schrieb Mark Johnson:
> >2) you can always come in the next day and record the current price for
> > the fund so that the pricedb shows the current value. Make sense? the
> > only thing you'll lose will be the price history. Its okay that you don't
> > show the current market price at the time of the transfer/exchange. you
> > can always provide that number later so that your reports show the
> > current market value.
>
> True.  What about the possibility of reports based upon the pricedb
> entries?  Eg. a graph of the price history.  Such entries would produce
> unwelcome blips.  I'm just thinking here about possible future features,
> and, I suppose, the meaning of pricedb entries.

Just to remind you of the current reports and so that everyone is on the same 
page: The distinction between prices "from the pricedb" and those calculated 
"implictly from existing transactions" has always existed and had to be dealt 
with always. 

The report that shows the development of a price over time (the "Price 
Scatterplot"), as well as all the other reports that depend on exchange 
prices, has therefore the option of choosing the "price source". I 
implemented that at the time because to me the only meaningful choices here 
were 1. either prices from the pricedb, *or* 2. implicit prices, but no mix 
of both. That's why the option "price source" has one choice to use the 
"implicit prices" and two other choices that will use prices "from the 
pricedb". So the solution to this two choices has been to give the user the 
option to choose between one out of two methods. I'm actually quite sure that 
any mix between both methods, at least for the same commodity, really doesn't 
give meaningful results. The "exchange-fn" IIRC should be the abstraction to 
provide access to both methods the same way. The way the exchange-fn was 
calculated is probably not the most efficient one, but at least it gave 
accurate results for the choices that were available. 

However, although I coded quite a lot of the multi-currency stuff, this is all 
now quite a long time ago and I don't remember anything I ever did at the 
time. Hopefully I added enough comments in the scheme code.

In summary: The question of the price source has been an issue since the 
introduction of the pricedb to gnucash, and it had to be solved in all 
multi-commodity reports, not only the advanced-portfolio.scm. If you think 
the available reportsystem-wide implementation needs changes, you are of 
course welcome to do them, but please keep in mind that this whole issue is 
really not trivial. In particular, both price source options are pretty much 
orthogonal to each other and I haven't heard any convincing proposal to mix 
them, so I'd rather suggest to continue to treat both separately at some 
level.

Regards,

Christian
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel