Re: Test fro overridden method
Richard Frith-Macdonald schrieb:
>
> On 30 Dec 2006, at 16:09, Fred Kiefer wrote:
>
>>> BOOL
>>> GSObjCHasOverridden(Class baseClass, id object, SEL selector)
>>> {
>>> if (GSObjCIsClass(object))
>>> {
>>> if ((Class)object == baseClass
>>> || GSGetMethod((Class)object, selector, NO. YES) ==
>>> GSGetMethod(base, selector, NO. YES))
>>> {
>>> return YES;
>>> }
>>> }
>>> else
>>> {
>>> Class instanceClass = GSObjCClass(object);
>>>
>>> if (instanceClass == baseClass
>>> || GSGetMethod(instanceClass, selector, YES. YES) ==
>>> GSGetMethod(base, selector, YES. YES))
>>> {
>>> return YES;
>>> }
>>> }
>>> return NO;
>>> }
>>
>> Thank you very much for this code. This uses some fast but GNU runtime
>> specific functions. I will stick with my slower method of testing until
>> this implementation makes it into GSobjCRuntime and we also have an
>> abstraction that allows similar tests with the Apple runtime.
>
> Actually, it doesn't use ANY GNU runtime specific functions, it's
> entirely runtime independent code!
>
> It uses functions from GSObjCRuntime.h and GSObjCRuntime.m ... which are
> wrappers round either GNU runtime functions or Apple runtime functions
> depending on which system you build.
>
> The equivalent GNU runtime specific code would use object_is_class()
> rather than GSObjCIsClass() and would use class_get_instance_method()
> and class_get_class_method() rather than GSGetMethod()
>
Oops, thank you for pointing this out. I should have checked in the code
before making this statement. The used functions are in the Additions of
base and would thereby be valid to be used in gui. Still I think this
function looks too serious to be thrown into a gui class as a helper. It
would confuse people like me. :-)
Cheers,
Fred
___
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Test base library stable branch please
On Fri, 29 Dec 2006 21:23:25 +, "Paddy Smith" <[EMAIL PROTECTED]> said: [...] > I'd be happy to send/build you ppc binaries if it helps, but I imagine > you have buildds for that :-) Nope. I just have my i386 machine, and no buildd (it's a private build), so ppc binaries would be helpful. Thanks. (hmm. I may have to change the layout of my archive to handle different architectures...) Hubert ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Test fro overridden method
On 30 Dec 2006, at 16:09, Fred Kiefer wrote:
BOOL
GSObjCHasOverridden(Class baseClass, id object, SEL selector)
{
if (GSObjCIsClass(object))
{
if ((Class)object == baseClass
|| GSGetMethod((Class)object, selector, NO. YES) ==
GSGetMethod(base, selector, NO. YES))
{
return YES;
}
}
else
{
Class instanceClass = GSObjCClass(object);
if (instanceClass == baseClass
|| GSGetMethod(instanceClass, selector, YES. YES) ==
GSGetMethod(base, selector, YES. YES))
{
return YES;
}
}
return NO;
}
Thank you very much for this code. This uses some fast but GNU runtime
specific functions. I will stick with my slower method of testing
until
this implementation makes it into GSobjCRuntime and we also have an
abstraction that allows similar tests with the Apple runtime.
Actually, it doesn't use ANY GNU runtime specific functions, it's
entirely runtime independent code!
It uses functions from GSObjCRuntime.h and GSObjCRuntime.m ... which
are wrappers round either GNU runtime functions or Apple runtime
functions depending on which system you build.
The equivalent GNU runtime specific code would use object_is_class()
rather than GSObjCIsClass() and would use class_get_instance_method()
and class_get_class_method() rather than GSGetMethod()
___
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Test base library stable branch please
On 12/28/06, Hubert Chan <[EMAIL PROTECTED]> wrote: On Sat, 23 Dec 2006 15:38:16 +, Richard Frith-Macdonald <[EMAIL PROTECTED]> said: > Could people please make an effort to check out the stable branch > (http://svn.gna.org/viewcvs/gnustep/libs/base/branches/base-1_13_0/) > of the base library from subversion and check that none of the > backported bugfixes is faulty. I'm just shifting to this (r24274) now. so far that patch and the fix for bug #18107 work here (many thanks, once again!) and I've not noticed any new problems. Users of the Debian packages who don't want to compile it on their own can use my precompiled versions, available at: http://debian.uhoreg.ca/experimental/gnustep/gnustep-base/ You can also use the apt sources line: deb http://debian.uhoreg.ca/experimental/gnustep/ ./ It should be able to install straight on top of the regular Debian packages. Let me know if there are any problems with it. I'll try to keep the packages relatively up to date. Right now, the packages are based on an SVN checkout from last Saturday. superb! I'd be happy to send/build you ppc binaries if it helps, but I imagine you have buildds for that :-) Regards, Paddy ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Test fro overridden method
Richard Frith-Macdonald schrieb:
>
> On 29 Dec 2006, at 01:26, Fred Kiefer wrote:
>
>> Could somebody please verify that this method does what I expect it to
>> do?
>> I need such a test within NSDocument. Here Apple takes special care that
>> if somebody has implemented the old interface methods for NSDocument in
>> a subclass, then these methods are actually called instead of the new
>> interface methods.
>>
>> /*
>> * Private helper method to check, if the method given via the
>> selector sel
>> * has been overridden in the current subclass.
>> */
>> - (BOOL)_hasOverridden: (SEL)sel
>> {
>> // The actual signature is not important as we wont call the methods.
>> IMP meth1;
>> IMP meth2;
>>
>> meth1 = [self methodForSelector: sel];
>> meth2 = [[NSDocument class] instanceMethodForSelector: sel];
>>
>> return (meth1 != meth2);
>> }
>
> I'm not sure what you mean by 'verify' ... but unless someone has
> overridden any of the three methods you use, I would expect the code to
> return 1 if the method for _sel has been overridden, 0 otherwise.
>
> You can bypass issues with those methods being overridden by calling the
> appropriate runtime functions, however if someone has overridden the
> methods they probably did so for a reason, and bypassing them could
> also cause problems. So while using the runtime directly can help, it
> can also (if less likely) cause problems. I would guess it is less
> likely to cause problems than cure them, so runtime use is probably
> better, but it's by no means certain.
>
> I suppose the most efficient implementation one could do would be
> something like ...
>
> BOOL
> GSObjCHasOverridden(Class baseClass, NSObject *instance, SEL selector)
> {
> Class instanceClass = GSObjCClass(instance);
>
> if (instanceClass == baseClass
> || GSGetMethod(instanceClass, selector, YES. YES) ==
> GSGetMethod(base, selector, YES. YES))
> {
> return YES;
> }
> return NO;
> }
>
> which might be a candidate for inclusion in GSObjCRuntime.[hm]
>
> Of course, it might be worth being able to test overriding of class
> methods too, depending on whether you pass an instance or a class
>
> BOOL
> GSObjCHasOverridden(Class baseClass, id object, SEL selector)
> {
> if (GSObjCIsClass(object))
> {
> if ((Class)object == baseClass
> || GSGetMethod((Class)object, selector, NO. YES) ==
> GSGetMethod(base, selector, NO. YES))
> {
> return YES;
> }
> }
> else
> {
> Class instanceClass = GSObjCClass(object);
>
> if (instanceClass == baseClass
> || GSGetMethod(instanceClass, selector, YES. YES) ==
> GSGetMethod(base, selector, YES. YES))
> {
> return YES;
> }
> }
> return NO;
> }
Thank you very much for this code. This uses some fast but GNU runtime
specific functions. I will stick with my slower method of testing until
this implementation makes it into GSobjCRuntime and we also have an
abstraction that allows similar tests with the Apple runtime.
Cheers,
Fred
___
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Test fro overridden method
On 29 Dec 2006, at 01:26, Fred Kiefer wrote:
Could somebody please verify that this method does what I expect it
to do?
I need such a test within NSDocument. Here Apple takes special care
that
if somebody has implemented the old interface methods for
NSDocument in
a subclass, then these methods are actually called instead of the new
interface methods.
/*
* Private helper method to check, if the method given via the
selector sel
* has been overridden in the current subclass.
*/
- (BOOL)_hasOverridden: (SEL)sel
{
// The actual signature is not important as we wont call the
methods.
IMP meth1;
IMP meth2;
meth1 = [self methodForSelector: sel];
meth2 = [[NSDocument class] instanceMethodForSelector: sel];
return (meth1 != meth2);
}
I'm not sure what you mean by 'verify' ... but unless someone has
overridden any of the three methods you use, I would expect the code
to return 1 if the method for _sel has been overridden, 0 otherwise.
You can bypass issues with those methods being overridden by calling
the appropriate runtime functions, however if someone has overridden
the methods they probably did so for a reason, and bypassing them
could also cause problems. So while using the runtime directly can
help, it can also (if less likely) cause problems. I would guess it
is less likely to cause problems than cure them, so runtime use is
probably better, but it's by no means certain.
I suppose the most efficient implementation one could do would be
something like ...
BOOL
GSObjCHasOverridden(Class baseClass, NSObject *instance, SEL selector)
{
Class instanceClass = GSObjCClass(instance);
if (instanceClass == baseClass
|| GSGetMethod(instanceClass, selector, YES. YES) == GSGetMethod
(base, selector, YES. YES))
{
return YES;
}
return NO;
}
which might be a candidate for inclusion in GSObjCRuntime.[hm]
Of course, it might be worth being able to test overriding of class
methods too, depending on whether you pass an instance or a class
BOOL
GSObjCHasOverridden(Class baseClass, id object, SEL selector)
{
if (GSObjCIsClass(object))
{
if ((Class)object == baseClass
|| GSGetMethod((Class)object, selector, NO. YES) ==
GSGetMethod(base, selector, NO. YES))
{
return YES;
}
}
else
{
Class instanceClass = GSObjCClass(object);
if (instanceClass == baseClass
|| GSGetMethod(instanceClass, selector, YES. YES) ==
GSGetMethod(base, selector, YES. YES))
{
return YES;
}
}
return NO;
}
___
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev
